On Fri, Nov 20, 2015 at 3:06 AM, Greg Kroah-Hartman
wrote:
> On Thu, Nov 12, 2015 at 07:58:54AM +0200, Or Gerlitz wrote:
>> On Sat, Oct 31, 2015 at 12:41 AM, wrote:
>> So this is an wholy orthogonal mechanism for memory registrations or
>> de-registrations vs what's
On Mon, Nov 16, 2015, Matan Barak wrote:
> On Thu, Oct 15, 2015 , Matan Barak wrote:
>> Hi Doug,
>> This series adds the support for RoCE v2. In order to support RoCE v2,
>> we add gid_type attribute to every GID. When the RoCE GID management
>> populates the GID table, it duplicates each GID wi
On Tue, Nov 24, 2015 at 6:23 PM, Sagi Grimberg wrote:
> @@ -1100,7 +1122,14 @@ isert_init_send_wr(struct isert_conn *isert_conn,
> struct isert_cmd *isert_cmd,
>
> isert_cmd->rdma_wr.iser_ib_op = ISER_IB_SEND;
> send_wr->wr_id = (uintptr_t)&isert_cmd->tx_desc;
> - send_wr->o
On Tue, Nov 24, 2015 at 6:23 PM, Sagi Grimberg wrote:
> From: Jenny Derzhavetz
>
> When all the task data is sent as immeidatedata, we are
> allowed to use the local_dma_lkey as it is not sent to
> the wire. In the long run we'd really need to rework
> the wire.
the part below doesn't fit into c
On Tue, Nov 24, 2015 at 6:23 PM, Sagi Grimberg wrote:
> With remote invalidate we won't local invalidate
> but we still want to increment the rkey.
nit, better to phrase is as "we won't do local invalidate"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a
On Wed, Nov 25, 2015 at 9:55 AM, Sagi Grimberg wrote:
> For NO_DATA commands the iser specification explicitly states that
> read_stag and write_stag should be 0 which means that inv_rkey is 0
> too. We don't do remote invalidate in case inv_rkey is 0.
I see, so if this is case, can you elimina
On Wed, Nov 25, 2015 at 7:09 PM, santosh shilimkar
wrote:
>>> As already indicated to Sagi [1], RDS IB FR support is work in
>>> progress and I was hoping to get it ready for 4.5.
These are really good news! can you please elaborate a bit on the
design changes this move introduced in RDS?
--
To u
On Wed, Nov 25, 2015 at 10:48 AM, Sagi Grimberg
wrote:
> On 25/11/2015 10:41, Or Gerlitz wrote:
>> On Wed, Nov 25, 2015 at 9:55 AM, Sagi Grimberg
>> wrote:
>> I see, so if this is case, can you eliminate one the checks here
>>>>> + if (isert_co
On Tue, Nov 24, 2015 at 6:23 PM, Sagi Grimberg wrote:
>
> From: Jenny Derzhavetz
>
> Declare that we support remote invalidation in case we are:
> 1. using Fastreg method
> 2. always registering memory.
decide if you want or don't want to use periods @ the end of these
cases, but be consistent..
On Mon, Nov 30, 2015 at 4:34 PM, Mike Marciniszyn
wrote:
Being a non native English speaker I am not fully sure, but "copyin
corrupting" sounds like slang / street talking... proper English
please
> Commit e622f2f4ad21 ("IB: split struct ib_send_wr")
> introduced a regression for HCAs whose user
Doug,
We're against into this... upstream is on 4.4-rc3 while your latest
branch in kernel.org (the one that carries thefor-next tag) is rebased
to 4.3-rc3...
--> our internal build and review systems for patches to linux-rdma
can'tmake any use of your tree. People here have to rebase their
On Tue, Dec 8, 2015 at 8:17 PM, Doug Ledford wrote:
>
> On 12/08/2015 01:13 PM, Sagi Grimberg wrote:
>
> > I mentioned this in v1. This patch set is applied over Christoph's
> > device attributes patch. Will it go in as well?
>
> No, that's too big and not the right sort of fix for 4.4-rc. I ha
On Fri, Oct 23, 2015 at 5:52 PM, Doug Ledford wrote:
> On 10/23/2015 02:46 AM, Or Gerlitz wrote:
>> Doug, there are few singleton patches to mlxN drivers, just to make
>> sure they are not left behind (thanks)
>> a small mlx5 enhancement, Signed by Eli C. the drive
On Wed, Dec 9, 2015 at 12:04 AM, Doug Ledford wrote:
> Makes sense.
thanks.
> Show me what you are talking about (either a link to Ira's
> patch you are referring to or your own patch).
The patch is three liner to add the cached attrs --
http://marc.info/?l=linux-rdma&m=142309296813985&w=2 -- i
On Wed, Dec 9, 2015 at 12:59 AM, Jason Gunthorpe
wrote:
> On Wed, Dec 09, 2015 at 12:47:55AM +0200, Or Gerlitz wrote:
>> The patch is three liner to add the cached attrs --
>> http://marc.info/?l=linux-rdma&m=142309296813985&w=2 -- if you are OK
>> with that, I wi
On Wed, Dec 9, 2015 at 1:13 AM, Or Gerlitz wrote:
> On Wed, Dec 9, 2015 at 12:59 AM, Jason Gunthorpe
> wrote:
>> On Wed, Dec 09, 2015 at 12:47:55AM +0200, Or Gerlitz wrote:
>
>>> The patch is three liner to add the cached attrs --
>>> http://marc.info/?l=linux
On 12/10/2015 10:09 PM, Majd Dibbiny wrote:
This patchs adds support for Raw Packet QP for the mlx5 device.
Raw Packet QP, unlike other QP types, has no matching mlx5_core_qp
object but rather it is built of RQ/SQ/TIR/TIS/TD mlx5_core object.
The Raw Packet QP state changes are implemented by c
On 12/15/2015 9:03 PM, Doug Ledford wrote:
Or, you specifically asked me to wait until this week. I made my
initial impressions clear (I don't necessarily like the removal of the
attr struct, but I like the removal of all of the query calls, and I'm
inclined to take the patch in spite of not li
On 12/16/2015 3:40 PM, Sagi Grimberg wrote:
I really don't have a strong preference on either of the approaches. I
just want to see this included one way or the other.
sure, agree, I will send my patches tomorrow
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the b
the device structure
Or Gerlitz (5):
IB/core: Avoid calling ib_query_device when possible
IB/ulps: Avoid calling ib_query_device
net/rds: Avoid calling ib_query_device
xprtrdma: Avoid calling ib_query_device
staging/o2iblnd: Avoid calling ib_query_device
drivers/infiniband
Instead, use the cached copy of the attributes present on the device.
Based on a patch from Christoph Hellwig
Signed-off-by: Or Gerlitz
---
drivers/infiniband/core/cm.c | 12 +---
drivers/infiniband/core/cma.c| 8
drivers/infiniband/core/fmr_pool.c | 20
From: Ira Weiny
This way both the IB core and upper level drivers can access these cached
device attributes rather than querying or caching them on their own.
Signed-off-by: Ira Weiny
Signed-off-by: Or Gerlitz
---
drivers/infiniband/core/device.c | 6 ++
include/rdma/ib_verbs.h
Instead, use the cached copy of the attributes present on the device.
Based on a patch from Christoph Hellwig
Signed-off-by: Or Gerlitz
---
net/rds/ib.c | 34 +++---
net/rds/iw.c | 23 +--
2 files changed, 16 insertions(+), 41 deletions(-)
diff
Instead, use the cached copy of the attributes present on the device.
Based on a patch from Christoph Hellwig
Signed-off-by: Or Gerlitz
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers
Instead, use the cached copy of the attributes present on the device.
Based on a patch from Christoph Hellwig
Signed-off-by: Or Gerlitz
---
net/sunrpc/xprtrdma/frwr_ops.c | 7 ++---
net/sunrpc/xprtrdma/svc_rdma_transport.c | 48 +---
net/sunrpc/xprtrdma
Instead, use the cached copy of the attributes present on the device.
Based on a patch from Christoph Hellwig
Signed-off-by: Or Gerlitz
---
drivers/infiniband/ulp/ipoib/ipoib_cm.c | 19 ---
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 14 +++--
drivers/infiniband/ulp/ipoib
Guys,
Using 4.4-rc5+ [1] and **not** applying any of the patches I sent today,
I noted that RoCE passive side isn't working (rdma-cm, ibv_rc_pingpong
works).
I have two nodes in ConnectX3 VPI config (port1 IB and port2 Eth), the
one with the 4.4-rc5 kernel can act as both (rping) client/serve
On Thu, Dec 17, 2015 at 5:36 PM, Christoph Hellwig wrote:
> [...] I heartily disagree with this approach [...]
OK, I will remove your name and re-submit that
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majord
On 12/17/2015 7:41 PM, Jason Gunthorpe wrote:
On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote:
+ ret = ib_query_device(device, &device->attrs);
+ if (ret) {
+ printk(KERN_WARNING "Couldn't query the device attributes\n");
+ goto out;
+
On 12/17/2015 4:18 PM, Sagi Grimberg wrote:
I'm using 4.4-rc2+ and I have RoCE working.
I tried 4.4-rc2 and I see the same problem. I will make my .config
available to you and Moni so you can try it out on your systems Sunday.
I see this over both CX2 and CX3-pro, both are in VPI config.
BTW
x27;s comment and removed ib_query_device,
this changed patch #1 and added patch #7.
- removed ref to Christoph patch in the change-logs of patches 2-6
Ira Weiny (1):
IB/core: Save the device attributes on the device structure
Or Gerlitz (6):
IB/core: Avoid calling ib_query_device
IB/ulps:
Use the cached copy of the attributes present on the device, except for
the case of a query originating from user-space, where we have to invoke
the driver query_device entry, so they can fill in their udata.
Signed-off-by: Or Gerlitz
---
drivers/infiniband/core/cm.c | 12
Instead, use the cached copy of the attributes present on the device.
Signed-off-by: Or Gerlitz
---
net/rds/ib.c | 34 +++---
net/rds/iw.c | 23 +--
2 files changed, 16 insertions(+), 41 deletions(-)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index
Instead, use the cached copy of the attributes present on the device.
Signed-off-by: Or Gerlitz
---
net/sunrpc/xprtrdma/frwr_ops.c | 7 ++---
net/sunrpc/xprtrdma/svc_rdma_transport.c | 48 +---
net/sunrpc/xprtrdma/verbs.c | 24
Instead, use the cached copy of the attributes present on the device.
Signed-off-by: Or Gerlitz
---
drivers/infiniband/ulp/ipoib/ipoib_cm.c | 19 ---
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 14 +++--
drivers/infiniband/ulp/ipoib/ipoib_main.c| 21
From: Ira Weiny
This way both the IB core and upper level drivers can access these cached
device attributes rather than querying or caching them on their own.
Signed-off-by: Ira Weiny
Signed-off-by: Or Gerlitz
---
drivers/infiniband/core/device.c | 8
include/rdma/ib_verbs.h
Instead, use the cached copy of the attributes present on the device.
Signed-off-by: Or Gerlitz
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
The copy of the attributes present on the device is now used by all consumers
expect for uverbs in case of serving user-space query, where dev->query_device
is called.
Signed-off-by: Or Gerlitz
---
drivers/infiniband/core/device.c | 19 ---
include/rdma/ib_verbs.h |
On Fri, Dec 18, 2015 at 7:16 AM, ira.weiny wrote:
> More than anything what I hate is all the places that allocate struct
> ib_device_attr just to free it after the query call.
did you care to look on patches 2-6, this is exactly what they are doing.
--
To unsubscribe from this list: send the li
On 12/18/2015 3:55 PM, Christoph Hellwig wrote:
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 284916d..e45776e 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1306,7 +1306,6 @@ struct ib_mr {
u64iova;
u32
On 12/17/2015 3:58 PM, Or Gerlitz wrote:
Using 4.4-rc5+ [1] and **not** applying any of the patches I sent today,
I noted that RoCE passive side isn't working (rdma-cm, ibv_rc_pingpong
works).
I have two nodes in ConnectX3 VPI config (port1 IB and port2 Eth), the
one with the 4.4-rc5 k
On 12/18/2015 4:14 PM, Bart Van Assche wrote:
On 12/18/2015 02:55 PM, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig
Shouldn't the description of this patch be changed into something like
"Remove the usecnt field from ib_mr since it is always zero" ?
Agree.
I would like us to
On 12/18/2015 3:55 PM, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig
Reviewed-by: Sagi Grimberg
Reviewed-by: Jason Gunthorpe [core]
Reviewed-by: Steve Wise
Here, too, please avoid empty change logs to IB core patches.
Or.
---
include/rdma/ib_verbs.h | 5 -
1 file chang
On 12/20/2015 9:25 AM, Or Gerlitz wrote:
On 12/18/2015 3:55 PM, Christoph Hellwig wrote:
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 284916d..e45776e 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1306,7 +1306,6 @@ struct ib_mr {
u64
On 12/20/2015 11:31 AM, Sagi Grimberg wrote:
However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs:
Implement memory windows support in uverbs") is wrong. A memory
window allocation should really reference the MR and not the PD (which
is referenced by the MR). Otherwise the MR dereg
On 12/20/2015 11:31 AM, Sagi Grimberg wrote:
However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs:
Implement memory windows support in uverbs") is wrong. A memory
window allocation should really reference the MR and not the PD (which
is referenced by the MR). Otherwise the MR dereg
On 12/20/2015 5:41 PM, Christoph Hellwig wrote:
I can't see a useful explanation for removing an unused structure. But if you
really want one and come up with a coherent sentence or two I can add it.
patch title - IB/core: Remove struct ib_phys_buf
change log:
Remove struct ib_phys_buf sinc
On 12/20/2015 1:22 PM, Leon Romanovsky wrote:
---
include/infiniband/verbs.h | 3 +++
src/cmd.c | 5 -
2 files changed, 7 insertions(+), 1 deletion(-)
You need to document the new creation flags in a man page. If this
doesn't exist, this should be added to Eran's submi
On 12/18/2015 4:10 PM, Bart Van Assche wrote:
Shouldn't this patch be split per ULP driver to make review easier ?
The patch is very simple and does the same practice in all ULPs. If it
helps I can spit off the srp initiator and target bits into a different
patch, let me know.
If you have
On 12/18/2015 6:49 PM, Jason Gunthorpe wrote:
On Fri, Dec 18, 2015 at 10:08:41AM +0200, Or Gerlitz wrote:
On 12/17/2015 7:41 PM, Jason Gunthorpe wrote:
On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote:
+ ret = ib_query_device(device, &device->attrs);
+
On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote:
> On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote:
>> On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote:
>>> From: Leon Romanovsky
>>> Modify enum ib_device_cap_flags such that other patches which add new
>>> enum values pas
On Mon, Dec 21, 2015 at 9:27 AM, Leon Romanovsky wrote:
> On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz wrote:
>> On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote:
>>> On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote:
>>>> On Sun, Dec 20, 2015 at 12:16:09P
On Mon, Dec 21, 2015 at 6:20 AM, Nicholas A. Bellinger
wrote:
> Applied to target-pending/for-next as v4.5-rc1 material, along with
> Reviewed-by tags from HCH.
Hi Nic, thanks for stepping in and picking that.
Sagi, are you going to spin an increment in the initiator version?
Or.
--
To unsubsc
-> "Ethernet port to fail"
Fixing this by passing the port of the request and checking this port
of the device.
OK, so this fix will work for both ib/eth and eth/ib configs, right? good.
Fixes: b8cab5dab15f ('IB/cma: Accept connection without a valid netdev on RoCE')
On 12/21/2015 5:01 PM, Matan Barak wrote:
This patch fixes a bug in VPI systems, where the first port is configured
as IB and the second one is configured as Ethernet. In this case, if the
rdma_id isn't bounded to a port, cma_match_net_dev will try to verify that the
first port is a RoCE port a
On Wed, Dec 16, 2015 at 7:53 AM, Or Gerlitz wrote:
> On 12/15/2015 9:03 PM, Doug Ledford wrote:
>> Or, you specifically asked me to wait until this week. I made my
>> initial impressions clear (I don't necessarily like the removal of the
>> attr struct, but I like
On 12/21/2015 5:01 PM, Matan Barak wrote:
Previously, cma_match_net_dev called cma_protocol_roce which
tried to verify that the IB device uses RoCE protocol. However,
if rdma_id didn't have a bounded port, it used the first port
of the device.
In VPI systems, the first port might be an IB port w
On 12/22/2015 9:17 AM, Or Gerlitz wrote:
On 12/21/2015 5:01 PM, Matan Barak wrote:
This patch fixes a bug in VPI systems, where the first port is
configured
as IB and the second one is configured as Ethernet. In this case, if
the rdma_id isn't bounded to a port, cma_match_net_dev will t
On Tue, Dec 15, 2015 at 8:30 PM, Matan Barak wrote:
> Pass hca_core_clock_offset to user-space is mandatory in order to
> let the user-space read the free-running clock register from the
> right offset in the memory mapped page.
> Passing this value is done by changing the vendor's command
> and r
On 12/22/2015 11:37 PM, Or Gerlitz wrote:
On Tue, Dec 15, 2015 at 8:30 PM, Matan Barak wrote:
>Pass hca_core_clock_offset to user-space is mandatory in order to
>let the user-space read the free-running clock register from the
>right offset in the memory mapped page.
>Passing t
Hi Dave, Doug
We're happily assigning new maintainers for mlx4/mlx5 core and IB drivers.
This is aligned with Eli (mlx5) and Roland (mlx4).
FWIW, I did the whole change to go through netdev.
Or.
Or Gerlitz (2):
MAINTAINERS: Assign new maintainers to Mellanox mlx5 core and IB dr
The driver was written originally by Roland Dreier, currently there's
no official maintainer. Yishai steps in as maintainer.
Signed-off-by: Or Gerlitz
Cc: Roland Dreier
---
MAINTAINERS | 19 +++
1 file changed, 19 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
Matan and Leon step in as co-maintainers to replace Eli Cohen
who wrote and maintained the core and IB drivers.
Signed-off-by: Or Gerlitz
---
MAINTAINERS | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c6b78b0..c7586a5 100644
On 12/22/2015 1:13 AM, Faisal Latif wrote:
+
+enum i40iw_memreg_type {
+ IW_MEMREG_TYPE_MEM = 0x,
+ IW_MEMREG_TYPE_QP = 0x0001,
+ IW_MEMREG_TYPE_CQ = 0x0002,
+ IW_MEMREG_TYPE_MW = 0x0003,
+ IW_MEMREG_TYPE_FMR = 0x0004,
+ IW_MEMREG_TYPE_FMEM = 0x0005,
+};
On 12/23/2015 6:35 PM, Faisal Latif wrote:
I will provide new patch series for latest k.o. Also will make sure of shallow
threading for the series.
Please make sure that the cover letter will include the full output of
the git generated cover-letter so we can see the location of changes you
On 12/22/2015 1:13 AM, Faisal Latif wrote:
Add entry for port mapper services.
Signed-off-by: Faisal Latif
---
include/uapi/rdma/rdma_netlink.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h
index c19a5dc..4fa418d 10064
On 12/22/2015 1:13 AM, Faisal Latif wrote:
This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet
controller for PCI Physical Functions.
Is there any public info on the X722, I didn't manage to find such.
It also has support for Virtual Function driver (i40iwvf.ko), whic
On Tue, Dec 15, 2015 at 8:30 PM, Matan Barak wrote:
> This patch-set adds user-space support for time-stamping in mlx5_ib.
> It implements the necessary API:
> (a) ib_create_cq_ex - Add support for CQ creation flags
> (b) ib_query_device - return timestamp_mask and hca_core_clock.
> We also add
On Mon, Dec 21, 2015 at 3:29 PM, Sagi Grimberg wrote:
>> Sagi, are you going to spin an increment in the initiator version?
> I don't know if it's worth a driver version update?
yes, I think it does. Finally we're getting real close to the visions
of the spec authors... do you have some perfor
On 12/24/2015 9:57 AM, Matan Barak wrote:
I totally agree that it's better to use the local IP address and not
just get a random device by using 127.0.0.1. You could get a specific
device by binding it, but then - use its local IP instead of
127.0.0.1.
Yes guys, it might be better but the user
On 12/24/2015 5:31 AM, Doug Ledford wrote:
On 12/20/2015 12:16 PM, Leon Romanovsky wrote:
Leon Romanovsky (3):
IB/core: Align coding style of ib_device_cap_flags structure
IB/core: Add cross-channel support
IB/mlx5: Add driver cross-channel support
drivers/infiniband/core/uverbs_cmd.
On 12/24/2015 9:05 AM, Faisal Latif wrote:
>Why the iwarp port mapper implementationhas to be repeated in each
>driver? can you join your code in a common place and avoid the duplication?
>
>root@r-dcs58 hw]# git grep RDMA_NL_ nes
>nes/nes.c: [RDMA_NL_IWPM_REG_PID] = {.dump = iwpm_register_
On 12/24/2015 9:31 AM, Faisal Latif wrote:
On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote:
On 12/22/2015 1:13 AM, Faisal Latif wrote:
+
+enum i40iw_memreg_type {
+ IW_MEMREG_TYPE_MEM = 0x,
+ IW_MEMREG_TYPE_QP = 0x0001,
+ IW_MEMREG_TYPE_CQ = 0x0002
On 12/24/2015 12:12 PM, Sagi Grimberg wrote:
This patch seems to generate a list corruption [1] when I test
with Doug's for-4.5 tree. Eran, care to take a look at this?
This patch is part from a series that was introduced in 4.3-rc1 [1], did
4.4-rc5/6 worked for you before you uploaded there
On 12/24/2015 12:00 PM, Christoph Hellwig wrote:
On Thu, Dec 24, 2015 at 10:02:29AM +0200, Or Gerlitz wrote:
We had consensus among the reviewers that the 1st patch ("IB/core: Align
coding style of ib_device_cap_flags structure") is wrong cleanup which
basically is (1) unneeded (2) cr
On 12/24/2015 12:42 PM, Sagi Grimberg wrote:
This patch seems to generate a list corruption [1] when I test
with Doug's for-4.5 tree. Eran, care to take a look at this?
This patch is part from a series that was introduced in 4.3-rc1 [1],
Then something else broke it. Can people check their
On Thu, Dec 24, 2015 at 12:02 PM, Christoph Hellwig wrote:
> On Thu, Dec 24, 2015 at 11:17:46AM +0200, Kamal Heib wrote:
>> We've located the driver in the staging subtree. This follows a requirement
>> to implement an IB transport library - Soft RoCE is in the same boat like
>> the hfi1
>> drive
On 12/29/2015 12:43 PM, Hal Rosenstock wrote:
Port number is not part of ClassPortInfo attribute but is
still needed as a parameter when invoking process_mad.
Please remove the blank line above your 1st sentence.
To properly handle this attribute, port_num is added as a
parameter to get_coun
On 12/29/2015 3:24 PM, Matan Barak wrote:
From: Maor Gottlieb
s/handlning/handling/
When attaching multicast for RoCE v2, we need to be able to steer
packets to the QPs. Hence, we add support for IPV4 over IB steering.
not sure to follow on the change-log, can you clarify it little further
On 12/29/2015 3:24 PM, Matan Barak wrote:
From: Moni Shoua
Some mlx4 adapters are RoCEv2 capable. To enable this feature some
hardware configuration is required. This is
1. Set port general parameters
2. Configure the outgoing UDP destination port
3. Configure the QP that work with RoCEv2
Sig
On 12/29/2015 3:24 PM, Matan Barak wrote:
The mlx4 driver uses a special QP to implement the GSI QP. This kind
of QP allows to build the InfiniBand headers in SW to be put before
the payload that comes in with the WR. The mlx4 HW builds the packet,
calculates the ICRC and puts it at the end of th
On 12/29/2015 4:41 PM, Leon Romanovsky wrote:
From: Leon Romanovsky
The create_cq() can receive creation flags which were used
differently by two commits which added create_cq extended
command and cross-channel. The merged code caused to not
accept any flags at all.
This patch unifies the chec
On 12/29/2015 3:24 PM, Matan Barak wrote:
[...] We use a new firmware command in order to populate the GID table and
store the type along with the GID value.
Its a new value to existing command.. so better say we use a new value
to the SET_PORT firmware command to do X
Also here, break out
On 12/29/2015 3:24 PM, Matan Barak wrote:
@@ -905,6 +906,8 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct
mlx4_dev_cap *dev_cap)
dev_cap->flags2 |= MLX4_DEV_CAP_FLAG2_EQE_STRIDE;
MLX4_GET(dev_cap->bmme_flags, outbox,
QUERY_DEV_CAP_BMME_FLAGS_OFFSE
On 12/29/2015 3:24 PM, Matan Barak wrote:
Advertise RoCE support in port_immutable according to the hardware
capabilities. This enables the verbs stack to use RoCE v2 mode.
Advertise RoCE V2 support
Signed-off-by: Matan Barak
I guess you wanted "IB/mlx4: Advertise RoCE V2 support" for th
On Tue, Dec 29, 2015 at 3:24 PM, Matan Barak wrote:
> @@ -2413,34 +2442,27 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp,
> struct ib_ud_wr *wr,
>
> if (is_eth) {
> struct in6_addr in6;
> -
> + u16 ether_type;
> u16 pcp = (be32_to_cpu
On 12/23/2015 2:56 PM, Matan Barak wrote:
+__be16 ib_ud_ip4_csum(struct ib_ud_header *header)
+{
+ struct iphdr iph;
+
+ iph.ihl = 5;
+ iph.version = 4;
+ iph.tos = header->ip4.tos;
+ iph.tot_len = header->ip4.tot_len;
+ iph.id
On 10/28/2015 4:52 PM, Matan Barak wrote:
@@ -134,16 +138,14 @@ static int write_gid(struct ib_device *ib_dev, u8 port,
{
int ret = 0;
struct net_device *old_net_dev;
- unsigned long flags;
/* in rdma_cap_roce_gid_table, this funciton should be protected by a
Hi Matan,
I see these two smatch complaints on code added with this series, can
you please take a look?
drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn:
variable dereferenced before check 'src_addr' (see line 500)
drivers/infiniband/core/cma_configfs.c:172 make_cma_ports() war
On 12/30/2015 10:23 AM, Matan Barak wrote:
int mlx4_CONFIG_DEV_wrapper(struct mlx4_dev *dev, int slave,
struct mlx4_vhcr *vhcr,
struct mlx4_cmd_mailbox *inbox,
struct mlx4_cmd_mailbox *outbox,
On 12/30/2015 10:27 AM, Matan Barak wrote:
On 12/29/2015 5:19 PM, Or Gerlitz wrote:
On 12/29/2015 3:24 PM, Matan Barak wrote:
@@ -905,6 +906,8 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev,
struct mlx4_dev_cap *dev_cap)
dev_cap->flags2 |= MLX4_DEV_CAP_FLAG2_EQE_STR
On 12/30/2015 12:48 PM, Matan Barak wrote:
On 12/30/2015 8:04 AM, Or Gerlitz wrote:
Hi Matan,
I see these two smatch complaints on code added with this series, can
you please take a look?
drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn:
variable dereferenced before check
On 12/30/2015 2:04 PM, Bart Van Assche wrote:
Hello Christoph,
Can you check whether the branch in the subject of this e-mail works
fine on your setup (commit 59caaed7a7) ? On my test setup (Dell R430
with two ConnectX-3 adapters) this branch crashes during boot in
get_counter_table() (see al
On 12/30/2015 1:04 PM, Moni Shoua wrote:
The last hunk that you removed had a role and was by no means
dead-code, right? so... (1) why it's correct to remove it? (2) if you
want to introduce different way to implement what was done here, why
in this patch? maybe add pre-patch for that
In a way y
On 12/31/2015 4:41 PM, Yuval Shaia wrote:
To support security applications, that need to filter out connections based
on SGID, an ioctl command to retrieve SGID of a given socket is added.
[...]
+
+found:
+ if (!(neigh->nud_state & NUD_VALID))
+ return -EINVAL;
+
+ gid
On Mon, Jan 4, 2016 at 5:44 AM, wrote:
> From: Ira Weiny
>
> Attributed ID was declared as an int while the value should really be big
> endian 16.
>
> Fixes: 35c4cbb17811 ("IB/core: Create get_perf_mad function in sysfs.c")
>
remove this blank line (&& I provided you this comment multiple time
On Wed, Dec 23, 2015 at 10:53 PM, Or Gerlitz wrote:
> On Mon, Dec 21, 2015 at 3:29 PM, Sagi Grimberg
> wrote:
>
>>> Sagi, are you going to spin an increment in the initiator version?
>
>> I don't know if it's worth a driver version update?
>
> yes,
On 1/4/2016 10:44 PM, Hal Rosenstock wrote:
ib_mad_snoop_handler uses send_buf rather than send_wr
Signed-off-by: Hal Rosenstock
Please use higher language in commit titles e.g
IB/core: Documentation fix in the MAD header file
---
Change since v1:
Fixed typo in patch description
diff --g
On Tue, Jan 5, 2016 at 6:46 PM, Steve Wise wrote:
> Hey Doug, I don't see this branch. Which branch has the accepted device attr
> change?
k.o/for-4.5 on Doug's kernel.org tree
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.ke
On Tue, Jan 5, 2016 at 9:00 PM, Hefty, Sean wrote:
>> > There are no in tree users and the only attempt at adding one was
>> rejected.
>>
>> There are no in tree users of this but there is your madeye tool (which
>> is out of tree). This is still a useful debug tool for MADs and there
>> are peopl
601 - 700 of 2427 matches
Mail list logo
