e two" version into my devel branch!
Thanks!
Linus Walleij
y: Vladimir Zapolskiy
Patch applied with Geert's review tag.
Yours,
Linus Walleij
what the function is doing.
Yours,
Linus Walleij
nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.21-tag1
>
> for you to fetch changes up to b59d0e782706785b7042539e820e95df3be4d04c:
>
> pinctrl: Add RZ/A2 pin and gpio controller (2018-11-23 09:30:27 +0100)
Pulled into my devel branch!
Excellent work as always, thanks a lot Geert!
Yours,
Linus Walleij
Acked-by: Linus Walleij
Yours,
Linus Walleij
here is sometimes more than one way to do things
around here :/
Geert will know what is best.
Yours,
Linus Walleij
tory at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.20-tag3
>
> for you to fetch changes up to ef26d96023a4c34b1bcc4294f570df2b63a1b952:
Pulled into the pinctrl "devel" branch, thanks!
Yours,
Linus Walleij
-28 09:49:15 +0200)
Pulled into my "devel" branch now, thanks!
Yours,
Linus Walleij
On Tue, Sep 11, 2018 at 2:04 PM Geert Uytterhoeven wrote:
> On Sun, Jul 29, 2018 at 11:33 PM Linus Walleij
> wrote:> > On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang
> wrote:
> > > > That all being said, I think this patch is still useful as is.
> > >
>
On Sun, Jan 21, 2018 at 1:12 PM Wolfram Sang
wrote:
> The ';' was missing. And cosmetic: there was a space too much.
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Niklas Söderlund
> ---
>
> No changes since V2, only Niklas' tag added.
Patch applied with Geert's ACK.
Yours,
Linus Walleij
nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.20-tag1
>
> for you to fetch changes up to 2ed03c835d6f4dbe9f0d093187825d1c0e2e9b39:
>
> pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function (2018-08-30
> 14:17:20 +0200)
Pulled into pinctrl "devel" branch, thanks!
Yours,
Linus Walleij
On Tue, Aug 7, 2018 at 10:03 AM Biju Das wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Patch applied with the ACKs.
Yours,
Linus Walleij
iju Das
Patch applied with Geert's review tag.
Yours,
Linus Walleij
On Mon, Aug 13, 2018 at 3:58 PM Biju Das wrote:
> This patch series aims to add PFC support for RZ/G2M SoC.
Looks good to me, Geert will queue the patches when he's happy.
Yours,
Linus Walleij
On Tue, Aug 7, 2018 at 9:21 AM Biju Das wrote:
> Add a check for unused gpios to avoid chip->request() call to client
> driver for unused gpios.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Patch applied with Geert's ACK.
Yours,
Linus Walleij
uires every driver in the kernel to pass in a valid parent device
representing the OF node. And there are so many hairy corner cases
where they don't.
Yours,
Linus Walleij
erved-ranges: See gpio.txt
Maybe you could add an extra example using the reserved ranges?
Yours,
Linus Walleij
On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang wrote:
> > That all being said, I think this patch is still useful as is.
>
> Linus, do you have time to comment on this?
This looks like a good solution to me.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
On Mon, Jul 23, 2018 at 10:26 PM Wolfram Sang
wrote:
> And don't reimplement in the driver.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
On Thu, Jul 12, 2018 at 11:31 AM Geert Uytterhoeven
wrote:
> Allow gpiolib to read back the current I/O direction configuration by
> implementing the .get_direction() callback.
>
> Signed-off-by: Geert Uytterhoeven
Patch applied with the tags!
Yours,
Linus Walleij
ranch, thanks for excellent work as usual!
Yours,
Linus Walleij
ENGTH from all pins.
>
> Fixes: b92ac66a1819602b ("pinctrl: sh-pfc: Add R8A77970 PFC support")
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Simon Horman
> Reviewed-by: Sergei Shtylyov
> Reviewed-by: Geert Uytterhoeven
Patch applied directly for fixes per Geert's suggestion.
Yours,
Linus Walleij
ate power throught the pull-up resistor), so please queue
this as a fix and also tag for stable.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
78170efd4 ("PCI: versatile: Add DT-based ARM Versatile PB PCIe host
> driver")
> Fixes: 5f6b6ccdbe1c ("PCI: xgene: Add APM X-Gene PCIe driver")
> Fixes: 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller
> support")
> Signed-off-by: Sergei Shtylyov
> Cc: sta...@vger.kernel.org
Nice, clean and thorough fix!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
> Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
Patch applied!
Yours,
Linus Walleij
tatic pin comments (2018-05-23
> 14:43:49 +0200)
Pulled into my "devel" branch for v4.18, thanks!
Yours,
Linus Walleij
platform device.
>
> This also fixes a problem introduced with error checking when calling
> platform_get_irq().
>
> Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
OK this patch applied!
Yours,
Linus Walleij
hat is
in my devel branch and send incremental patches on top if
something needs changing?
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=devel=e6ca26abd37606ba4864f20c85d3fe4a2173b93f
Sorry for not knowing by heart what was applied or when, it's
just too much for me sometimes.
Yours,
Linus Walleij
h Simon's
ACK.
Yours,
Linus Walleij
<lee.jo...@linaro.org>
Patch applied for v4.18 with Hoan's ACK.
Yours,
Linus Walleij
ot the actual patch, I guess I will find it
sooner or later.
Wolfram: if I don't find it, poke me with something sharp so I get to apply it.
Yours,
Linus Walleij
eed for drivers to
> repeat that again.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
On Thu, Apr 19, 2018 at 4:05 PM, Wolfram Sang
<wsa+rene...@sang-engineering.com> wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
t;
> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
> Reviewed-by: Rob Herring <r...@kernel.org>
> ---
>
> Renesas R-Car M3-N support has been merged for v4.17.
> Document the missing device tree bindings.
>
> v1 -> v2:
> - Add Simon and Rob Reviewed-by tags
Patch applied.
Yours,
Linus Walleij
- Add the reviewed-by and ACKs
- Fold in Hoan's fix
- Resend
We are always a bit fuzzy around the edges with carrying ACKs etc
forward for new revisions. Surely that is fine with this minor
revision for ACPI.
Yours,
Linus Walleij
hris Paterson <chris.paters...@renesas.com>
Patch applied to the GPIO tree with all the review tags.
Yours,
Linus Walleij
Deduplicate VIN4 pin definitions (2018-03-21
> 18:25:48 +0100)
Pulled to the pin control "devel" branch, good work!
Yours,
Linus Walleij
> 09:17:54 +0100)
Pulled into the pinctrl devel branch for v4.17!
Excellent job as usual!
And I'm amazed that Renesas manage to churn out
so many ASICs.
Yours,
Linus Walleij
On Fri, Mar 2, 2018 at 9:20 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
>
> On Thu, Mar 1, 2018 at 5:06 PM, Linus Walleij <linus.wall...@linaro.org>
> wrote:
>> On Mon, Feb 12, 2018 at 2:55 PM, Geert Uytterhoeven
>> <geert+rene...@glider.be> wrot
onboard.com>
> Cc: Manfred Schlaegl <manfred.schla...@gmx.at>
> Cc: Marek Vasut <ma...@denx.de>
> Cc: Archit Taneja <arch...@codeaurora.org>
> Cc: Andrzej Hajda <a.ha...@samsung.com>
> Cc: Alison Wang <alison.w...@freescale.com>
> Cc: Eric Anholt
ndling code from the
> driver.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
> v3:
Patch applied for v4.16 fixes.
Yours,
Linus Walleij
patch is only in v4.16-rc1 and later, can you please
> take it directly as a fix for v4.16?
>
> https://patchwork.kernel.org/patch/10234351/
OK I pulled this out of patchwork and applied for fixes.
Yours,
Linus Walleij
d-off-by: Hien Dang <hien.dang...@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara...@renesas.com>
> [Modify structure of the bank info to simplify a saving registers]
> [Remove DEV_PM_OPS macro]
> Signed-off-by: Yoshihiro Kaneko <ykaneko0...@gmail.com>
This v4 version applied with Tested- and reviewed tags.
Yours,
Linus Walleij
ndling code from the
> driver.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Acked-by: Linus Walleij <linus.wall...@linaro.org>
Can I apply this and only this patch to GPIO?
Should it be applied for fixes, next?
Else please funnel this through the irqchip tree with my
ACK.
Yours,
Linus Walleij
ase if the GPIO
> is set to output.
>
> Tested-by: Phil Reid <pr...@electromag.com.au>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Geert pointed out a bug in *_cansleep() so I have m
value_nocheck(desc, value);
+ gpiod_set_value_nocheck(desc, value);
}
EXPORT_SYMBOL_GPL(gpiod_set_value);
@@ -3247,7 +3256,7 @@ void gpiod_set_value_cansleep(struct gpio_desc
*desc, int value)
{
might_sleep_if(extra_checks);
VALIDATE_DESC_VOID(desc);
- __gpiod_set_value_nocheck(desc, value);
+ gpiod_set_value_nocheck(desc, value);
}
EXPORT_SYMBOL_GPL(gpiod_set_value_cansleep);
Yours,
Linus Walleij
t; solution.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Patch applied.
Yours,
Linus Walleij
t; solution.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Patch applied.
Yours,
Linus Walleij
; into a sequence. Thus use the corresponding function "seq_puts".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Leaving to Geert to pick this up. (Looks good.)
Yours,
Linus Walleij
ups, and functions (2017-12-21
> 10:08:23 +0100)
Pulled to my devel branch for v4.16, thanks!
Yours,
Linus Walleij
Converted to use the WAKEUP_PATH driver PM flag]
> Signed-off-by: Ulf Hansson <ulf.hans...@linaro.org>
Acked-by: Linus Walleij <linus.wall...@linaro.org>
I guess it is dependent on the other patches?
If you want me to just apply it to the GPIO tree, tell me.
Yours,
Linus Walleij
On Tue, Dec 19, 2017 at 5:03 PM, Geert Uytterhoeven
<geert+rene...@glider.be> wrote:
> R8A7778 is R-Car (not R-Mobile) M1.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Patch applied with the ACKs.
Yours,
Linus Walleij
Pulled into my devel branch for v4.16.
Thanks for your efforts! Great work as usual.
Yours,
Linus Walleij
I would have to add yet more APIs to do that.
Hm.
Together with Geert's comments I start to lean towards actually
just creating two new #defines in .
It has the upside that we can also check the return value
for errors.
Yours,
Linus Walleij
ll's API hierarchy.
>>
>> Yes, sounds good!
>>
>> > Interested in fixing it, or should I?
>>
>> Please do. I don't want to add magic numbers to the kernel ;)
>
> OK?
Just slow, sorry. Sent a patch now!
Yours,
Linus Walleij
hierarchy.
Interested in fixing it, or should I?
I can almost ACK it before you write the patch.
Yours,
Linus Walleij
On Tue, Dec 5, 2017 at 10:57 AM, Phil Reid <pr...@electromag.com.au> wrote:
> On 5/12/2017 16:39, Linus Walleij wrote:
>> Just compare it to zero. if (!gpiod_get_direction())
>>
>> This flag is only for requesting GPIOs in the old API.
>> We didn't add a
!gpiod_get_direction())
This flag is only for requesting GPIOs in the old API.
We didn't add a define in the new API, it seemed overengineered.
Yours,
Linus Walleij
troduced named i2c-gpio DT bindings, and deprecated the
> more error-prone unnamed variant.
>
> Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O
> flags, which were implicitly assumed before.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Reviewed
drain please flag it properly in DT/ACPI
> DSDT/board file
> gpio-91 (?): enforced open drain please flag it properly in DT/ACPI
> DSDT/board file
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
troduced named i2c-gpio DT bindings, and deprecated the
> more error-prone unnamed variant.
>
> Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O
> flags, which were implicitly assumed before.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Reviewed
troduced named i2c-gpio DT bindings, and deprecated the
> more error-prone unnamed variant.
>
> Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O
> flags, which were implicitly assumed before.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Reviewed
pca953x: add onsemi,pca9654 id")
> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
Patch applied with Rob's ACK.
Thanks for spotting this in time.
Yours,
Linus Walleij
lt;geert+rene...@glider.be>
> ---
> Linus: it seems this one fell through the cracks, as the later
> f76a2d9d7f9524c5 ("gpio-rcar: document R8A77970 bindings") did get
> applied.
>
> Thx!
>
> v2:
> - Add Acked-by, rebased.
Oopsie. Maybe my oversight.
Patch applied!
Yours,
Linus Walleij
ff-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
Patch applied with Geert's review tag.
Sorry for delay, too busy as always.
Yours,
Linus Walleij
+0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.15-tag2
Pulled into the pinctrl devel branch.
Thanks to all @Renesas, excellent work as usual.
Yours,
Linus Walleij
On Mon, Oct 16, 2017 at 2:07 PM, Geert Uytterhoeven
<ge...@linux-m68k.org> wrote:
> On Mon, Oct 16, 2017 at 1:41 PM, Linus Walleij <linus.wall...@linaro.org>
> wrote:
>> On Mon, Oct 16, 2017 at 11:02 AM, Geert Uytterhoeven
>> <ge...@linux-m68k.org> wrote:
&g
t anyone anymore.
Can you check that you have this patch in your tree?
Yours,
Linus Walleij
terhoeven <geert+rene...@glider.be>
Patch applied with Simon's tag.
Yours,
Linus Walleij
On Wed, Oct 4, 2017 at 1:35 PM, Geert Uytterhoeven
<geert+rene...@glider.be> wrote:
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Patch applied with Simon's tag.
Yours,
Linus Walleij
; Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
> ---
> v2:
> * added Reviewed-by
Looks good, I expect Geert to queue this for me with a pull
request like with other Renesas stuff.
Yours,
Linus Walleij
+0200)
Pulled into my devel branch, thanks!
Yours,
Linus Walleij
o the pinctrl tree if need be.
It is pinctrl related so it makes sense to carry it there if SH
maintainers are not responding.
Just send a separate pull request and indicate if it needs to
go in for fixes or devel.
Yours,
Linus Walleij
why the GPIO binding is a bit .. esoteric
at times. I guess I should fix that.
Yours,
Linus Walleij
;pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
> pins"
>
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
Patch applied.
Yours,
Linus Walleij
On Wed, Aug 16, 2017 at 1:12 PM, Biju Das <biju@bp.renesas.com> wrote:
> Renesas RZ/G1E (R8A7745) SoC GPIO blocks are identical to the R-Car Gen2
> family. Add support for its GPIO controllers.
>
> Signed-off-by: Biju Das <biju@bp.renesas.com>
Patch applied wit
-08-16 14:26:32 +0200)
Pulled into my devel branch for v4.14, excellent work as usual!
Yours,
Linus Walleij
umi...@gmail.com>
Patch applied.
Yours,
Linus Walleij
>>
>> Fixes: d10bbd156926 ("gpio: rcar: add gen[123] fallback compatibility
>> strings")
>> Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
>
> Hi Linus,
>
> I believe Geert is on holidays at the moment (maybe you are to‽).
Nah neither of us are as it seems :)
I wait for the two of you to figure this out before applying anything.
Yours,
Linus Walleij
ff-by: Rob Herring <r...@kernel.org>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Cc: Lee Jones <l...@kernel.org>
> Cc: Eric Anholt <e...@anholt.net>
> Cc: Stefan Wahren <stefan.wah...@i2se.com>
> Cc: Florian Fainelli <f.faine...@gmail.com>
> Cc: Ray Ju
forward them to me when he's happy with them.
Yours,
Linus Walleij
I plan to queue these up in sh-pfc-for-v4.14.
All look good to me.
Yours,
Linus Walleij
rivers for Renesas SoCs.
>
> Also deprecate renesas,gpio-rcar as its name is more generic than its
> implementation.
>
> Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Totally uncontroversial DT binding changes so patch applied for next
with Geert's review tag.
Yours,
Linus Walleij
ixes: 5a49b644b3075f88 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Patch applied.
Yours,
Linus Walleij
(2017-06-26 10:21:38 +0200)
Pulled in for devel.
It's late, but you all worked hard to make this happen so we should
be liberal, also it is a new driver.
Yours,
Linus Walleij
buffers irrespective of the mode of the line as a whole.
We might need even more documentation because this is really
confusing.
But for now it lets drivers work, which is nice.
Rough consensus and running code should be our guide.
Yours,
Linus Walleij
hris Paterson <chris.paters...@renesas.com>
> ---
> v1->v2
> * Modified the text "RZ-G1M" to "RZ/G1M"
Patch applied with the ACKs.
Yours,
Linus Walleij
a decision. In
particular, if somebody tells you "choose (a) or (b), we really need you
to decide on this", you're in trouble as a manager. The people you
manage had better know the details better than you, so if they come to
you for a technical decision, you're screwed. You're clearly not
competent to make that decision for them.
(It goes on, it's the best part of the entire Documentation/* dir in my
opinion, please take the time to read it in full.)
So: what do you guys, using this feature, and Andy, who raised serious
concerns, think is the right binding? That is what *I* need to know.
Yours,
Linus Walleij
esome, good work as usual.
Pulled to my pinctrl devel branch.
Yours,
Linus Walleij
'm just overloaded. I sent that revert to Torvalds today.
> I can send another version of that patch with
> only 'output-enable' if you wish.
That's what we want.
> Once we reach consesus, I can then send v6 of our pin controller driver
> based on that.
OK sounds like a plan.
Sorry for the mess, I'm just trying to get this right :/
Yours,
Linus Walleij
these
quirky tables to be gone in the next hardware generation, right?
Then the right place for it is in the quirky driver for the quirky
first-generation
hardware.
Yours,
Linus Walleij
it is pin
configuration and should use a DT property.
Yours,
Linus Walleij
On Fri, May 5, 2017 at 2:45 PM, Chris Brandt <chris.bra...@renesas.com> wrote:
> On Friday, May 05, 2017, Linus Walleij wrote:
>> > This is the part of the whole "DT is for hardware description only" that
>> doesn't really make sense to me.
>&g
r
renesas,bi-directional;
renesas,output-enable;
following the Qualcomm pattern in that case.
But let's see if something else comes out of this discussion.
Yours,
Linus Walleij
On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko
<andy.shevche...@gmail.com> wrote:
> Linus, for me it looks like better to revert that change, until we
> will have clear picture why existing configuration parameters can't
> work.
Yeah I'll revert the binding for fixes.
Yours,
Linus Walleij
just means open drain.
It is dangerous to merge things we don't understand.
Surely someone inside Renesas can answer this question.
Yours,
Linus Walleij
hat happens
electrically?
Isn't this bias-high-impedance / High-Z?
Hopefully you can find the answer from Renesas hardware dept.
You can certainly call it whatever the datasheet calls it
in your driver #defines but for the DT bindings we would
ideally have the physical world things.
Yours,
Linus Walleij
_param(unsigned
long config)
{
return (enum pin_config_param) (config & 0xffUL);
}
static inline u32 pinconf_to_config_argument(unsigned long config)
{
return (u32) ((config >> 8) & 0xffUL);
}
Why can't you use this in your code instead of macros?
We generally prefer static inlines over macros because they are easier
to read.
Yours,
Linus Walleij
arse_dt_config();
>> + * we simply discard pinconf argument here
>> + */
>> +#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL)
>
> Perhaps this should be moved to pinconf-generic.h, to make sure it stays
> up-to-date?
I agree. Use the generic macros.
If further processing is needed, make a static inline to discard config flags
etc.
Yours,
Linus Walleij
>
> Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com>
> Cc: linux-g...@vger.kernel.org
> Cc: Geert Uytterhoeven <geert+rene...@glider.be>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
> ---
>
1 - 100 of 187 matches
Mail list logo
