[PATCH] thermal: rcar_gen3_thermal: Add Standby-Mode function support

2018-11-02 Thread Nguyen An Hoan
From: Hoan Nguyen An According to the hardware manual, Gen3 supports Standby-mode. Add this function, and we should use this function while suspend to reduce the energy consumption. Signed-off-by: Hoan Nguyen An --- drivers/thermal/rcar_gen3_thermal.c | 23 ++- 1 file

[PATCH] thermal: rcar_gen3_thermal: Add Standby-mode function support

2018-11-02 Thread Nguyen An Hoan
From: Hoan Nguyen An According to the hardware manual, Gen3 supports Standby-mode, Add this function, and we should use this function while suspend to reduce the energy consumption. Signed-off-by: Hoan Nguyen An --- drivers/thermal/rcar_gen3_thermal.c | 21 - 1 file

Re: [PATCH v3 1/3] mmc: tmio: enable module clock before resetting when resuming

2018-11-02 Thread Masahiro Yamada
On Thu, Nov 1, 2018 at 8:52 AM Niklas Söderlund wrote: > > From: Niklas Söderlund > > On runtime power management resume, the host clock needs to be > enabled before calling tmio_mmc_reset. If the mmc device has a power > domain entry, the host clock is enabled via genpd_runtime_resume, >

Re: [PATCH v3 2/3] mmc: tmio: fix reset operation

2018-11-02 Thread Masahiro Yamada
On Thu, Nov 1, 2018 at 8:53 AM Niklas Söderlund wrote: > > From: Niklas Söderlund > > SD / MMC did not operate properly when suspend transition failed. > Because the SCC was not reset at resume, issue of the command failed. > Call the host specific reset function and reset the hardware in order

Re: [PATCH] thermal: rcar_gen3_thermal: Fix does not have interrupts counting

2018-11-02 Thread Niklas Söderlund
Hi Hoan-san, Thanks for your patch. On 2018-10-30 18:10:01 +0900, Nguyen An Hoan wrote: > From: Hoan Nguyen An > > This patch fixes thermal interrupts that did not happen when temprature > changed. > Add the function rcar_gen3_thermal_update_threshold(), this function is used > to >

Re: [PATCH v2 0/3] mmc: renesas_sdhi: extend quirk selection to handle ES revisions

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 08:34:16PM +0100, Wolfram Sang wrote: > > > Patch 1/3 adds support to select quirks based on SoC + ES revision using > > soc_device_match() and converts the only existing quirk. Patch 2/3 > > Removes the old method to select quirk based on compatibility string. > >

Re: [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock

2018-11-02 Thread Simon Horman
On Wed, Oct 31, 2018 at 11:59:44PM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund > > The driver sets an incorrect clock and depends on the clock driver > knowledge of this incorrect setting to still set a 200Mhz SDn clock. > Instead of spreading the workaround between the two drivers

Re: [PATCH v3 3/3] mmc: renesas_sdhi: add initial setting of interrupt mask register

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 12:05:54AM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund > > The initial value of the interrupt mask register may be different from > the H/W manual at the startup of the kernel by setting from the > bootloader. Since the error interrupts may be unmasked, the

Re: [PATCH] thermal: rcar_gen3_thermal: Add Standby-Mode function support

2018-11-02 Thread Niklas Söderlund
Hi Hoan, Thanks for your work. On 2018-11-02 16:06:10 +0900, Nguyen An Hoan wrote: > From: Hoan Nguyen An > > According to the hardware manual, Gen3 supports Standby-mode. > Add this function, and we should use this function while > suspend to reduce the energy consumption. Out of curiosity

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote: > > > This patch have quiet a few dependencies I'm afraid, let me know if you > > wish to be notified once they all upstream. I don't think it's a good > > idea to pick this up before all dependencies are resolved. > > Yes, we

Re: [PATCH] arm64: dts: renesas: condor: switch from EtherAVB to GEther

2018-11-02 Thread Simon Horman
On Wed, Oct 31, 2018 at 08:29:50PM +0300, Sergei Shtylyov wrote: > On 10/31/2018 5:30 PM, Simon Horman wrote: > > > > The "official" Condor boards have always been wired to mount NFS via > > > GEther, not EtherAVB -- the boards resoldered for EtherAVB were local > > > to Cogent Embedded, so we've

Re: [PATCH] mmc: tmio: delete wait in tuning process

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote: > From: Masaharu Hayakawa > > The manual does not contain information that a wait is needed in the > tuning process, this might be a leftover from early development. > Removing the wait don't have any effect on operation so delete

Re: [PATCH 3/4] ARM: dts: r8a77470: Add QSPI support

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 12:35:04PM +, Fabrizio Castro wrote: > Add QSPI[01] support to the RZ/G1C SoC specific device tree. > > Signed-off-by: Fabrizio Castro > --- > arch/arm/boot/dts/r8a77470.dtsi | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git

Re: [PATCH v3 1/3] mmc: tmio: enable module clock before resetting when resuming

2018-11-02 Thread Simon Horman
On Thu, Nov 01, 2018 at 12:05:52AM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund > > On runtime power management resume, the host clock needs to be > enabled before calling tmio_mmc_reset. If the mmc device has a power > domain entry, the host clock is enabled via genpd_runtime_resume,

Re: [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock

2018-11-02 Thread Niklas Söderlund
Hi Simon, On 2018-11-02 12:55:02 +0100, Simon Horman wrote: > On Wed, Oct 31, 2018 at 11:59:44PM +0100, Niklas Söderlund wrote: > > From: Niklas Söderlund > > > > The driver sets an incorrect clock and depends on the clock driver > > knowledge of this incorrect setting to still set a 200Mhz SDn

Re: [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock

2018-11-02 Thread Simon Horman
On Fri, Nov 02, 2018 at 01:42:47PM +0100, Niklas Söderlund wrote: > Hi Simon, > > On 2018-11-02 12:55:02 +0100, Simon Horman wrote: > > On Wed, Oct 31, 2018 at 11:59:44PM +0100, Niklas Söderlund wrote: > > > From: Niklas Söderlund > > > > > > The driver sets an incorrect clock and depends on

Re: [PATCH 2/2] clk: renesas: rcar-gen3: add HS400 quirk for SD clock

2018-11-02 Thread Sergei Shtylyov
Hello! On 11/01/2018 02:25 AM, Niklas Söderlund wrote: > From: Niklas Söderlund > > On H3 (ES1.0,ES2.0) and M3-W (ES1.0,ES1.1) the clock setting for HS400 > needs a quirk to function properly. The reason for the quirk is that > there are two settings which produces same divider vale for the

[PATCH] gpio: rcar: Request GPIO while enabling interrupt

2018-11-02 Thread Fabrizio Castro
There are cases when the bootloader configures a pin to work as a function rather than GPIO, and other cases when the pin is configured as a function at POR. This commit makes sure the pin is configured as a GPIO the moment we need it to work as an interrupt. Signed-off-by: Fabrizio Castro ---

[PATCH] watchdog: renesas_wdt: Fix typos

2018-11-02 Thread Fabrizio Castro
Signed-off-by: Fabrizio Castro --- drivers/watchdog/renesas_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c index 0d74c3e..b570962 100644 --- a/drivers/watchdog/renesas_wdt.c +++

[PATCH] clk: renesas: r8a77970: add RPC clock

2018-11-02 Thread Sergei Shtylyov
On R-Car V3M (R8A77970), the RPC/RPCD2 clocks are output by the common divider. Describe them, as well as the RPC-IF module clock. Signed-off-by: Sergei Shtylyov --- This patch is against the 'clk-renesas' branch of Geert Uytterhoeven's 'renesas-drivers.git' repo.

Re: [PATCH] watchdog: renesas_wdt: Fix typos

2018-11-02 Thread Guenter Roeck
On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote: Do not use "," but ";" to separate instructions. > Signed-off-by: Fabrizio Castro Reviewed-by: Guenter Roeck > --- > drivers/watchdog/renesas_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

RE: [RFC] gpio: rcar: Request GPIO before enabling interrupt

2018-11-02 Thread Fabrizio Castro
Hello Linus, Thank you for your feedback! I am sorry for the delay of my answer, I was hoping others would jump in the discussion as well. > > + err = gc->request(gc, hwirq); > > This is done in some drivers when what you want is exactly > the work carried out by that callback. But can't