On Thu, Jan 25, 2018 at 06:02:56PM +, Fabrizio Castro wrote:
> This commit extends the driver to add restart support by implementing
> the restart callback to trigger the watchdog as quickly as possible.
>
> Signed-off-by: Fabrizio Castro
> Signed-off-by: Ramesh Shanmugasundaram
>
> ---
>
On Thu, Jan 25, 2018 at 06:02:58PM +, Fabrizio Castro wrote:
> R-Car Gen2 (and RZ/G1) platforms need some tweaking for SMP and watchdog
> to coexist nicely.
> This new driver is based on top of Wolfram Sang's driver
> (drivers/watchdog/renesas_wdt.c), and it contains the quirks necessary
> for
On Tue, Jan 30, 2018 at 08:22:44PM +, Fabrizio Castro wrote:
> On R-Car Gen2 and RZ/G1 the rwdt clock needs to be always ON, therefore
> when suspending to RAM we need to explicitly disable the counting by
> clearing TME from RWTCSRA.
> Also, on some systems RWDT is the only piece of HW that al
On 01/31/2018 04:13 AM, Geert Uytterhoeven wrote:
Hi Fabrizio,
On Wed, Jan 31, 2018 at 11:47 AM, Fabrizio Castro
wrote:
Subject: Re: [RFC v3 11/25] watchdog: renesas_wdt: Add R-Car Gen2 support
On Tue, Jan 30, 2018 at 08:22:44PM +, Fabrizio Castro wrote:
On R-Car Gen2 and RZ/G1 the rwdt c
On 01/31/2018 10:24 AM, Fabrizio Castro wrote:
Due to commits:
* "ARM: shmobile: Add watchdog support",
* "ARM: shmobile: rcar-gen2: Add watchdog support", and
* "soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2",
we now have everything we needed for the watchdog to work on Gen2
more
effective handlers.
Signed-off-by: Fabrizio Castro
Signed-off-by: Ramesh Shanmugasundaram
Reviewed-by: Guenter Roeck
---
v3->v4:
* New patch spawn out from patch 12/16. The restart handler on Gen3 is
controversial, hopefully this patch will help finalizing the discussion.
drivers/
need to explicitly disable the
> counting by clearing TME from RWTCSRA.
>
> Signed-off-by: Fabrizio Castro
> Signed-off-by: Ramesh Shanmugasundaram
>
Reviewed-by: Guenter Roeck
> ---
> v4->v5:
> * various improvements suggested by Wolfram
>
> drivers/w
On Thu, Feb 16, 2017 at 12:23:18PM -0500, Chris Brandt wrote:
> Some Renesas SoCs do not have a reset register and the only way to do a SW
> controlled reset is to use the watchdog timer. Additionally, since all the
> WDT timeout options are so quick, a system reset is about the only thing
> it's g
On Thu, Feb 16, 2017 at 06:40:05PM +, Chris Brandt wrote:
> On Thursday, February 16, 2017, Guenter Roeck wrote:
> > On Thu, Feb 16, 2017 at 12:23:18PM -0500, Chris Brandt wrote:
> > > Some Renesas SoCs do not have a reset register and the only way to do a SW
> > >
On 02/16/2017 06:00 PM, Chris Brandt wrote:
On Thursday, February 16, 2017, Guenter Roeck wrote:
Hmm, ok. Guess I don't have to understand that you can not use the
watchdog driver because of the above, but implementing exactly the same
functionality in a separate driver is ok.
[ I am sure
On 02/17/2017 12:09 AM, Geert Uytterhoeven wrote:
Hi Günter,
On Fri, Feb 17, 2017 at 5:45 AM, Guenter Roeck wrote:
On 02/16/2017 06:00 PM, Chris Brandt wrote:
On Thursday, February 16, 2017, Guenter Roeck wrote:
If this WDT had a timeout longer than 125ms, I would make a real watchdog
driver
On Wed, Feb 22, 2017 at 01:35:12PM +, Chris Brandt wrote:
> Hello Geert and Guenter,
>
> On Thursday, February 16, 2017, Guenter Roeck wrote:
> > FWIW, the watchdog subsystem should support that easily, even with 125 ms
> > hardware timeout. We added that capability
On 03/02/2017 05:57 AM, Chris Brandt wrote:
Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset
handler is also included since a WDT overflow is the only method for
restarting an RZ/A SoC.
Signed-off-by: Chris Brandt
---
drivers/watchdog/Kconfig | 8 ++
drivers/watchdog/
On Thu, Mar 02, 2017 at 05:31:18PM +, Chris Brandt wrote:
> On Thursday, March 02, 2017, Guenter Roeck worte:
> > > > The above two lines are unnecessary.
> > >
> > > OK.
> > >
> > > #I'll assume you mean take out just the last s
On Thu, Mar 02, 2017 at 03:38:07PM +, Chris Brandt wrote:
> Hello Guenter,
>
> Thank you for your review!
>
>
> On Thursday, March 02, 2017, Guenter Roeck wrote:
> > > +/*
> > > + * Renesas RZ/A Series WDT Driver
> > > + *
> > > +
On Thu, Mar 02, 2017 at 06:22:17PM +, Chris Brandt wrote:
> On Thursday, March 02, 2017, Guenter Roeck wrote:
> > > > > > The rate check should probably be here to avoid situations where
> > > > > > rate < 16384.
> > > > >
> >
On 03/03/2017 09:31 AM, Chris Brandt wrote:
Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset
handler is also included since a WDT overflow is the only method for
restarting an RZ/A SoC.
Signed-off-by: Chris Brandt
---
v2:
* removed extra lines from file header comments
* c
On 03/04/2017 02:37 PM, Chris Brandt wrote:
Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset
handler is also included since a WDT overflow is the only method for
restarting an RZ/A SoC.
Signed-off-by: Chris Brandt
Reviewed-by: Guenter Roeck
---
v3:
* added #include
On 03/04/2017 02:37 PM, Chris Brandt wrote:
Describe the WDT hardware in the RZ/A series.
Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
Acked-by: Rob Herring
Reviewed-by: Guenter Roeck
---
v3:
* Add Acked-by, Reviewed-by.
v2:
* added to renesas-wdt.txt instead of creating
ed-by: Guenter Roeck
---
v4:
* changed from timer@ to watchdog@
v3:
* added Reviewed-by
v2:
* changed "renesas,r7s72100-reset" to "renesas,r7s72100-wdt"
* changed "renesas,wdt-reset" to "renesas,rza-wdt"
* added interupt property (even though it is not used)
*
On Mon, Feb 26, 2018 at 10:49:05PM +0100, Wolfram Sang wrote:
> The datasheet says we should stop the timer before changing the clock
> divider. So, let's meet that recommendation.
>
> Signed-off-by: Wolfram Sang
> ---
> drivers/watchdog/renesas_wdt.c | 9 +++--
> 1 file changed, 7 insertion
On 02/27/2018 05:00 AM, Wolfram Sang wrote:
- rwdt_write(priv, 0, RWTCSRB);
- rwdt_write(priv, priv->cks, RWTCSRA);
Isn't this done implicitly with the above already ?
After all, priv->cks won't have RWTCSRA_TME set.
Yes. The request came from a group doing some (safety?) audit wh
On Tue, Feb 27, 2018 at 05:22:56PM +0100, Wolfram Sang wrote:
>
> > the core gets it wrong. Just add a note to the probe function where cks is
> > initialized that RWTCSRA_TME must not be set, and that RWTCSRA_TME must be
> > cleared before changing the divider.
>
> But we would still need to dis
ion in mind
that there may be some delay in userspace before it gets to send the next ping.
Presumably that is not a concern here, so
Reviewed-by: Guenter Roeck
> ---
> v6->v7:
> * backup and restore register RWTCNT instead of using rwdt_get_timeleft and
> rwdt
;
> Reviewed-by: Geert Uytterhoeven
> Reviewed-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> v6->v7:
> * no change
>
> drivers/watchdog/renesas_wdt.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c
On 03/02/2018 02:45 AM, Fabrizio Castro wrote:
Dear All,
perhaps someone from this email thread could explain to me what's the actual
(general) expectation from a system perspective (at resume) from the watchdog,
because I can see pitfalls whether 1) we simply start the watchdog at resume or
2)
; Signed-off-by: Ramesh Shanmugasundaram
>
> [Geert: blacklisting logic]
> Signed-off-by: Geert Uytterhoeven
> ---
> v7->v8:
> * folded patch "watchdog: renesas_wdt: Blacklist early R-Car Gen2 SoCs" from
> Geert into this patch.
>
> Since Simon only reviewed Ge
On Tue, Mar 20, 2018 at 10:36:26PM +0100, Wolfram Sang wrote:
> From: Veeraiyan Chidambaram
>
> This patch adds the WDIOF_CARDRESET support for the Renessas platform
> watchdog, to know if the board reboot is due to a watchdog reset.
>
> This is done via the WOVF bit (bit 4) of the RWTCSRA regis
Reviewed-by: Guenter Roeck
---
Change since v1: s/M3N/M3-N/ (Thanks, Geert!)
Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
b/Documentation/devicetree/bindings
On Thu, Apr 19, 2018 at 04:06:29PM +0200, Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
>
> Build tested only. buil
On 04/20/2018 05:20 AM, Geert Uytterhoeven wrote:
System restart triggered by watchdog time-out works fine on a Koelsch
board with R-Car M2-W ES2.0.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
---
Thanks to Magnus and Shimoda-san for providing board access!
---
drivers
f-by: Wolfram Sang
> Reviewed-by: Geert Uytterhoeven
> Reviewed-by: Guenter Roeck
> Reviewed-by: Simon Horman
> Reviewed-by: Vaishali Thakkar
Unfortunately this patch isn't based on anything recognized by git,
and even though it is simple I can't get it to apply. Can someone
This one applies.
Reviewed-by: Guenter Roeck
Thanks!
Guenter
---
Change since V2: rebase to 4.17-rc3
Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
b/Documentation
On 05/06/2018 04:23 AM, Wolfram Sang wrote:
Signed-off-by: Wolfram Sang
Applied to hwmon-next.
Thanks,
Guenter
---
drivers/hwmon/fschmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c
index 5e78229ade049f..22d3a84f13ef
On 12/9/18 8:36 AM, Wolfram Sang wrote:
Hi Guenter,
I can relate to the policy argument, though. Regardless of this patch, I
wonder if we can make it configurable from userspace. A draft:
#define WDIOF_RESUME_OPTS 0x0800
#define WDIOS_RESUME_KEEP 0x0008
#define WDIOS_RESUME_RESET
On 12/10/18 1:37 AM, Fabrizio Castro wrote:
Hello Guenter,
From: Guenter Roeck On Behalf Of Guenter Roeck
Sent: 09 December 2018 18:13
Subject: Re: [RFC] watchdog: renesas_wdt: don't keep timer value during
suspend/resume
On 12/9/18 8:36 AM, Wolfram Sang wrote:
Hi Guenter,
I can r
On Mon, Dec 17, 2018 at 08:14:11PM +0100, Wolfram Sang wrote:
> Those functions are not only deprecated, but gone for good.
>
> Fixes: 62cd1c40ce1c ("watchdog: kill unref/ref ops")
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> Documentation/watc
On Mon, Dec 17, 2018 at 08:33:14PM +0100, Wolfram Sang wrote:
> Add the first rule we recently agreed on.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> Documentation/watchdog/watchdog-pm.txt | 19 +++
> 1 file changed, 19 insertions
rman
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
> b/Documentation/devicetree/bindings/watchdog/renesas-wdt
branch with all tags. Wim will
pick it up
from there.
Thanks,
Guenter
https://patchwork.kernel.org/patch/10657119/
regards,
Biju
-Original Message-
From: Simon Horman
Sent: 30 October 2018 14:00
To: Biju Das
Cc: Wim Van Sebroeck ; Guenter Roeck
; Rob Herring ; Mark Rutland
; linux
On 2/12/19 12:52 AM, Geert Uytterhoeven wrote:
Hi all,
On Mon, Feb 11, 2019 at 9:43 PM Marek Vasut wrote:
On 2/6/19 12:24 AM, Eduardo Valentin wrote:
On Mon, Jan 28, 2019 at 01:10:11PM +0100, Marek Vasut wrote:
On 1/15/19 1:35 AM, Marek Vasut wrote:
On 12/22/18 3:19 AM, Marek Vasut wrote:
On 4/14/19 3:26 AM, Wolfram Sang wrote:
The function is not easy to read and has two problems: a) -EINVAL is
returned when the module parameter is invalid but the DT parameter is
OK, and b) for the module parameter, zero is a valid value but for DT it
is invalid.
That was on purpose: A module
On 4/14/19 6:42 AM, Wolfram Sang wrote:
The function is not easy to read and has two problems: a) -EINVAL is
returned when the module parameter is invalid but the DT parameter is
OK, and b) for the module parameter, zero is a valid value but for DT it
is invalid.
That was on purpose: A modul
On Sun, Apr 14, 2019 at 12:03:06PM +0200, Wolfram Sang wrote:
> If we want to match all revisions, it is enough to leave the field
> empty.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
>
> Only build tested, no HW. Found by code review.
&
On 4/14/19 4:09 AM, Wolfram Sang wrote:
And make sure the final obtained value gets properly scaled. Remove two
empty lines to group the initialization blocks while we are here.
Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
---
Tested with a Renesas Lager board (R-Car H2
a. We should probably do the same for
[devm_]watchdog_register_device().
For the series, except patch 1:
Reviewed-by: Guenter Roeck
Thanks,
Guenter
Thanks,
Wolfram
Wolfram Sang (16):
watchdog: refactor watchdog_init_timeout
watchdog: add error messages when initializing timeout
On Mon, Apr 15, 2019 at 12:52:01PM +0200, Wolfram Sang wrote:
> Support an already running watchdog by checking its enable bit and set
> up the status accordingly before registering the device.
>
> Signed-off-by: Wolfram Sang
> ---
>
> This patch was tested using a Renesas Salvator XS board (R-C
know and I can do something locally in the driver and sorry for
the noise.
Only reason is that I could not figure out a way to make it work.
LGTM except for nitpick.
Reviewed-by: Guenter Roeck
include/linux/kernel.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a
On Fri, Jan 06, 2017 at 09:41:44AM +0100, Wolfram Sang wrote:
> It occured to me that the panic pretimeout governor will stall the
> softdog, because it is purely software which simply halts on panic.
> Testing governors with the softdog on the other hand is really useful.
> So, make this feature a
On 01/19/2017 12:14 PM, Wolfram Sang wrote:
+#if IS_ENABLED(CONFIG_SOFT_WATCHDOG_PRETIMEOUT)
static void softdog_pretimeout(unsigned long data)
I would prefer __maybe_unused here ..
{
watchdog_notify_pretimeout(&softdog_dev);
@@ -82,16 +83,23 @@ static void softdog_pretimeout(unsi
y useful, so make this feature a compile time option which nees to
> be enabled explicitly. This also removes the overhead if pretimeout
> support is not used because it will now be compiled away (saving ~10% on
> ARM32).
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
On Wed, Mar 02, 2016 at 11:33:36PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
>
>
On Wed, Mar 02, 2016 at 11:33:37PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang
> ---
>
> Should go individually via subsystem tree.
>
> drivers/watc
Hi Wolfram,
On Wed, Mar 30, 2016 at 05:28:42PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang
>
> Add support for watchdogs (RWDT and SWDT) found on RCar Gen3 based SoCs
> from Renesas.
>
> Signed-off-by: Wolfram Sang
> ---
>
[ ... ]
> + *
> + * This program is free software; you can redis
Hi Wolfram,
On 04/01/2016 04:36 AM, Wolfram Sang wrote:
Hi Guenter,
+static bool nowayout = WATCHDOG_NOWAYOUT;
+module_param(nowayout, bool, S_IRUGO);
Sure you want this parameter readable ? No problem with me, but it is unusual,
so I figure it is worth asking.
No reason, will stick to the
On Fri, Apr 01, 2016 at 01:56:24PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang
>
> This patch adds the RWDT device node for r8a7795.
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Wolfram Sang
Acked-by: Guenter Roeck
I assume the dts patches will go through the
On Fri, Apr 01, 2016 at 01:56:25PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang
>
> This patch enables watchdog timer for Salvator-X board.
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Wolfram Sang
Acked-by: Guenter Roeck
> ---
> arch/arm64/boot/dts/renesa
On Fri, Apr 01, 2016 at 01:56:26PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defcon
On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrote:
> >> My Salvator-X reboots after timeout from "cat > /dev/watchdog0", but
> >> it doesn't reboot through "reboot" or "reboot -f"?
> >
> > That sadly doesn't wo
On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote:
> Hi Günter,
>
> On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote:
> > On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote:
> >> On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrot
On Mon, Apr 04, 2016 at 08:14:02PM +0200, Geert Uytterhoeven wrote:
> Hi Günter,
>
> On Mon, Apr 4, 2016 at 7:52 PM, Guenter Roeck wrote:
> > On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote:
> >> On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote:
>
On Tue, Apr 12, 2016 at 05:56:11PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang
>
> Let's have balanced round brackets.
>
> Signed-off-by: Wolfram Sang
Nice catch. Shows that someone is actually reading comments :-)
Reviewed-by: Guenter Roeck
> ---
> driver
will change but also wait a bit for more comments.
I for my part don't have any. Feel free to add
Reviewed-by: Guenter Roeck
to the series when you resend.
Thanks,
Guenter
On 07/17/2017 10:12 AM, Wolfram Sang wrote:
We should never return more time left than there actually is. So, switch
to a plain divider instead of DIV_ROUND_CLOSEST.
Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
---
This is similar to a patch for the renesas-rwdt[1]. I think it
On Wed, Jul 26, 2017 at 11:54:36PM +0200, Wolfram Sang wrote:
> As mentioned in a response to a previous patch, clock handling for Renesas
> R-Car is done via RuntimePM. Patch 1 implements that consequently. Patch 2
> is a cleanup then possible and patch 3 is a trivial copyright update.
>
> This i
On Mon, Aug 14, 2017 at 05:47:28PM +0200, Wolfram Sang wrote:
> On Mon, Aug 14, 2017 at 08:32:30AM -0700, Guenter Roeck wrote:
> > On Wed, Jul 26, 2017 at 11:54:36PM +0200, Wolfram Sang wrote:
> > > As mentioned in a response to a previous patch, clock handling for Renesas
>
0 1 32768 0 0
> WDT running rwdt1 1 32768 0 0
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/renesas_wdt.c | 33 +++---
On Wed, Jul 26, 2017 at 11:54:39PM +0200, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/renesas_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c
On Wed, Jul 26, 2017 at 11:54:38PM +0200, Wolfram Sang wrote:
> It is not needed outside probe() anymore.
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/renesas_wdt.c | 10 +-
> 1 file change
t; Acked-by: Rob Herring
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
> b/Documentation/devicetree/bindings/watchdo
On Mon, Oct 30, 2017 at 04:43:19PM +0100, Geert Uytterhoeven wrote:
> Document support for the Watchdog Timer (WDT) Controller in the Renesas
> R-Car V3M (r8a77970) SoC. Restore sort order while at it.
>
> No driver update is needed.
>
> Signed-off-by: Geert Uytterhoeven
Re
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
> b/Documentation/devicet
On Tue, Jun 05, 2018 at 07:18:33PM +0200, Geert Uytterhoeven wrote:
> From: Masaharu Hayakawa
>
> Document support for the Watchdog Timer (WDT) Controller in the Renesas
> R-Car E3 (R8A77990) SoC.
>
> No driver update is needed.
>
> Signed-off-by: Masaharu Hayakawa
> Signed-off-by: Geert Uytte
: Guenter Roeck
Acked-by: Rob Herring
The patch is queued in my tree, so there should be no need to resend it anymore.
Guenter
---
v2:
- Add Reviewed-by, Acked-by.
---
Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a
ntroduce watchdog_stop_on_unregister helper")
Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
---
drivers/watchdog/watchdog_dev.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index ffbdc4642ea5..f6c24b
x27;t been opened by userspace
yet. Strange scenario, yes, but sane state is much preferred anyhow.
Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
---
drivers/watchdog/renesas_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/wat
On 08/28/2018 03:29 AM, Wolfram Sang wrote:
With NOWAYOUT, prevent bind/unbind possibilities in SYSFS.
Proof-of-concept, not for upstream yet.
Signed-off-by: Wolfram Sang
---
So, this is really an RFC to check if something like this is considered useful
or not. If so, we probably need to do it
On Tue, Aug 28, 2018 at 09:14:13PM +0200, Wolfram Sang wrote:
> To prevent removing if NOWAYOUT, we invalidate the .remove function and
> suppress the bind/unbind attributes in sysfs. These are driver
> capabilities, so we need to set it up at runtime during init. To avoid
> boilerplate, introduce
On Tue, Aug 28, 2018 at 10:07:40PM +0200, Wolfram Sang wrote:
> Hi Guenter,
>
> > > + __driver.remove = NULL; \
> >
> > Does that really do any good ? If I understand correctly, the only
> > impact is that the platform driver remove function will believe that
> > nothing needs to be done
On Wed, Aug 29, 2018 at 09:42:38AM +0200, Wolfram Sang wrote:
> To prevent removing if NOWAYOUT, we invalidate the .remove function and
> suppress the bind/unbind attributes in sysfs. These are driver
> capabilities, so we need to set it up at runtime during init. To avoid
> boilerplate, introduce
On Thu, Sep 06, 2018 at 01:37:37PM -0500, Chris Brandt wrote:
> The RZ/A2 watchdog timer extends the clock source options in order to
> allow for longer timeouts.
>
> Signed-off-by: Chris Brandt
> ---
> v2:
> * use DIV_ROUND_UP
> * use %u for pr_debug
> * use of_match data to determine the size o
On Thu, Sep 06, 2018 at 11:52:47AM -0700, Guenter Roeck wrote:
> On Thu, Sep 06, 2018 at 01:37:37PM -0500, Chris Brandt wrote:
> > The RZ/A2 watchdog timer extends the clock source options in order to
> > allow for longer timeouts.
> >
> > Signed-off-by: Chris Brandt
On Fri, Sep 07, 2018 at 02:10:58AM +, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
> Signed-off-by: Kuninori Morimoto
Reviewed-by: Guenter Roeck
>
On Fri, Sep 07, 2018 at 02:11:17AM +, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
> Signed-off-by: Kuninori Morimoto
Reviewed-by: Guenter Roeck
>
On 09/06/2018 06:22 PM, Chris Brandt wrote:
The RZ/A2 watchdog timer extends the clock source options in order to
allow for longer timeouts.
Signed-off-by: Chris Brandt
---
v3:
* Removed + 1 from DIV_ROUND_UP line
* resetting to 0 if time to big did not make as much sense are resetting
On Fri, Sep 07, 2018 at 02:10:58AM +, Kuninori Morimoto wrote:
> From: Kuninori Morimoto
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
> Signed-off-by: Kuninori Morimoto
> Reviewed-by: Guenter Roeck
Hmmm .. any ch
On Mon, Sep 10, 2018 at 01:53:28PM +, Chris Brandt wrote:
> On Saturday, September 08, 2018 1, Guenter Roeck wrote:
> > > +#define CKS_3BIT 0x7
> > > +#define CKS_4BIT 0xF
> >
> > Any special reason for the value of those defines ? They are ju
On Mon, Sep 10, 2018 at 05:36:39PM +, Chris Brandt wrote:
> On Monday, September 10, 2018 1, Guenter Roeck wrote:
> > > #2. If the CKS is only 4-bits, the max HW timeout is 32 seconds. (so
> > > 'timeout' can never be more that a u8).
> > >
> > Tha
On Mon, Sep 10, 2018 at 02:52:32PM -0500, Chris Brandt wrote:
> The RZ/A2 watchdog timer extends the clock source options in order to
> allow for longer timeouts.
>
> Signed-off-by: Chris Brandt
Reviewed-by: Guenter Roeck
> ---
> v4:
> * Documented CKS_3BIT/CKS_4BIT bett
On Mon, Sep 10, 2018 at 02:52:33PM -0500, Chris Brandt wrote:
> Document support for RZ/A2
>
> Signed-off-by: Chris Brandt
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> di
y: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
> b/Documentation/devicetree/bindings/w
On Thu, Oct 04, 2018 at 10:29:19AM +0900, Cao Van Dong wrote:
> Dear Marc-san,
>
> Thanks for your comment!
>
> >>Formerly, when registering the hwmon device, we pass NULL as the device.
> >>It's not a problem.
> >>Recently, the developer has replaced the parameter NULL as the device by
> >>the a
On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote:
Do not use "," but ";" to separate instructions.
> Signed-off-by: Fabrizio Castro
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/renesas_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+),
On Wed, Nov 07, 2018 at 08:46:02PM +0100, Wolfram Sang wrote:
> The datasheet says we must stop the timer before changing the clock
> divider. This can happen when the restart handler is called while the
> watchdog is running.
>
> Signed-off-by: Wolfram Sang
Reviewed-by
/
Signed-off-by: Wolfram Sang
Above exchange says it all, no need to repeat.
Reviewed-by: Guenter Roeck
---
Fabrizio: can you agree to that? The R-Car BSP team and we (the R-Car upstream
team) would prefer it this way (knowing it is also not perfect).
drivers/watchdog/renesas_wdt.c | 11
/patch/10252209/
Signed-off-by: Wolfram Sang
Above exchange says it all, no need to repeat.
Reviewed-by: Guenter Roeck
Thanks.
I can relate to the policy argument, though. Regardless of this patch, I
wonder if we can make it configurable from userspace. A draft:
#define WDIOF_RESUME_OPTS
On 10/02/2018 01:35 AM, Cao Van Dong wrote:
In __hwmon_device_register() function of hwmon.c, we have assigned 'dev' directly
to 'hdev->parent'.
Formerly, when registering the hwmon device, we pass NULL as the device. This
is not affected.
Recently, the developer has replaced the parameter NULL
On 10/02/2018 02:06 AM, Cao Van Dong wrote:
Dear Geert-san,
Thanks for your comment!
In __hwmon_device_register() function of hwmon.c, we have assigned 'dev' directly
to 'hdev->parent'.
Formerly, when registering the hwmon device, we pass NULL as the device. This
is not affected.
Recently, t
On 10/02/2018 06:33 PM, Cao Van Dong wrote:
Dear Guenter-san,
Thanks for your comment!
In __hwmon_device_register() function of hwmon.c, we have assigned 'dev' directly
to 'hdev->parent'.
Formerly, when registering the hwmon device, we pass NULL as the device. This
is not affected.
Recently,
he init message anyhow,
> shorten it while we are here; no need for versioning there as well and
> the name is already given via pr_fmt.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/softdog.c | 17 +
> 1 file ch
1 - 100 of 124 matches
Mail list logo