Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
with today linux-next (next-20141120) and display is indeed working for me. So it seems that whatever caused the error in the phy-exynos-mipi-video driver reported by Paolo, got fixed recently. My working git hash is: 65a8d01 arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy a9b43cb

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Vivek Gautam
exynos_defconfig Same here. With this display works for me. Without $Subject patch i get lookup in drm. I tested with today linux-next (next-20141120) and display is indeed working for me. So it seems that whatever caused the error in the phy-exynos-mipi-video driver reported by Paolo, got fixed

[PATCH] ASoC: samsung: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND operation which is i

2014-11-20 Thread Padmavathi Venna
Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Padmavathi Venna padm...@samsung.com --- sound/soc/samsung/i2s.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/i2s.c

Re: [alsa-devel] [PATCH] ASoC: samsung: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND ope

2014-11-20 Thread Padma Venkat
Hi, On 11/20/14, Padmavathi Venna padm...@samsung.com wrote: Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Padmavathi Venna padm...@samsung.com --- sound/soc/samsung/i2s.c |5 +++-- 1 files changed, 3

[PATCH] ASoC: samsung: ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-20 Thread Padmavathi Venna
In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND operation which is introduced in commit a5a56871f804edac93a53b5e871c0e9818fb9033 (ASoC: samsung: add support for exynos7 I2S controller) and

Re: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-20 Thread Sylwester Nawrocki
Hi, On 20/11/14 08:04, Padma Venkat wrote: diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 947352d..8db8c66 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -494,7 +494,7 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai, if (dir

Re: [PATCH v3 2/5] drivers: soc: Add support for Exynos PMU driver

2014-11-20 Thread Russell King - ARM Linux
On Thu, Nov 20, 2014 at 11:09:25AM +0530, Amit Daniel Kachhap wrote: diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 063113d..44d220d 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -6,3 +6,4 @@ obj-$(CONFIG_ARCH_QCOM) += qcom/

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Ulf Hansson
On 20 November 2014 01:35, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 19, 2014 09:54:00 AM Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources

Re: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-20 Thread Padma Venkat
Hi Sylwester, On 11/20/14, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 20/11/14 08:04, Padma Venkat wrote: diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 947352d..8db8c66 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -494,7

Re: [PATCH 0/3] PM / Domains: Add initial PM clock support to genpd

2014-11-20 Thread Ulf Hansson
On 20 November 2014 01:33, Kevin Hilman khil...@kernel.org wrote: Ulf Hansson ulf.hans...@linaro.org writes: It's quite common for PM domains to use PM clocks. Typically from SOC specific code, the per device PM clock list is created and pm_clk_suspend|resume() are invoked to handle clock

[RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
This patch makes kms drivers to be independent drivers. For this, it removes all register codes to kms drivers from exynos_drm_drv module and adds module_init/exit for each kms driver so that each kms driver can be called independently. Changelog v3: - Use module_platform_driver macro instead

[RFC PATCH v3 2/4] drm/exynos: make non kms drivers to be indenpendent drivers

2014-11-20 Thread Inki Dae
This patch makes non kms drivers to be independent drivers. For this, it removes all register codes to non kms drivers from exynos_drm_drv module and adds module_init/exit for each non kms driver so that each non kms driver can be called independently. In addition, this patch adds non kms

[RFC PATCH v3 0/4] separeate sub drivers into independent drivers

2014-11-20 Thread Inki Dae
Hi all, This patch set separeates sub drivers into independent drivers. patch 1/4: - make all kms drivers - fimd, hdmi, dp and dsi - to be independent drivers. patch 2/4: - make all non kms drivers - g2d and ipp - to be independent drivers. patch 3/4: - make vidi

[RFC PATCH v3 3/4] drm/exynos: make vidi driver to be independent driver

2014-11-20 Thread Inki Dae
This patch makes vidi driver to be independent driver. For this, it removes register codes to vidi driver from exynos_drm_drv module and adds module_init/exit for vidi driver so that this driver can be called independently. In addition, this patch adds component support to vidi driver so that

[RFC PATCH v3 4/4] drm/exynos: clean up machine compatible string check

2014-11-20 Thread Inki Dae
Use 'for' statemant instead of hard-coded 'if' statement. Changelog v3: - none Changelog v2: - none Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

Re: [alsa-devel] [PATCH] ASoC: samsung: ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-20 Thread Sylwester Nawrocki
On 20/11/14 11:03, Padmavathi Venna wrote: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND operation which is introduced in commit a5a56871f804edac93a53b5e871c0e9818fb9033 (ASoC:

[PATCH 1/1] [media] platform: Deletion of unnecessary checks before two function calls

2014-11-20 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 11:44:20 +0100 The functions i2c_put_adapter() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the

Re: [PATCH 1/3] PM / Domains: Initial PM clock support for genpd

2014-11-20 Thread Ulf Hansson
On 19 November 2014 18:25, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Nov 19, 2014 at 03:00:36PM +0100, Ulf Hansson wrote: It's quite common for PM domains to use PM clocks. Typically from SOC specific code, the per device PM clock list is created and pm_clk_suspend|resume() are

Re: [PATCH v2 00/33] thermal: exynos: convert the driver to use per-SoC type operations

2014-11-20 Thread Lukasz Majewski
Hi Eduardo, Hi, This patch series replaces the hardware registers abstractions in the Exynos thermal driver by the usage of per-SoC type operations. Such solution provides simpler, easier to understand code and allows removal of ~250 LOCs (~11% of the whole source code) from the driver.

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Grygorii Strashko
On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources - pm_runtime_enable() Well, and now how the driver knows if the device is on before accessing

Re: [PATCH] MAINTAINERS: update email address and cleanup for exynos entry

2014-11-20 Thread Arnd Bergmann
On Monday 17 November 2014, Ben Dooks wrote: On 14/11/14 07:54, Kukjin Kim wrote: Use kernel.org account instead of samsung.com and cleanup for Samsung s3c, s5p and exynos SoCs. Cc: Ben Dooks ben.do...@codethink.co.uk I do wish these would be sent to the mail address I use for Linux

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Ulf Hansson
On 20 November 2014 13:17, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources -

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Andrzej Hajda
On 11/20/2014 11:24 AM, Inki Dae wrote: This patch makes kms drivers to be independent drivers. For this, it removes all register codes to kms drivers from exynos_drm_drv module and adds module_init/exit for each kms driver so that each kms driver can be called independently. Changelog v3:

[PATCH 0/2] Add regulator-haptic driver

2014-11-20 Thread Jaewon Kim
This patch series adds regulator-haptic driver. The regulator-haptic has haptic motor and it is controlled by voltage of regulator via force feedback framework. Jaewon Kim (2): Input: add regulator haptic driver ARM: dts: Add regulator-haptic device node for exynos3250-rinato

[PATCH 2/2] ARM: dts: Add regulator-haptic device node for exynos3250-rinato

2014-11-20 Thread Jaewon Kim
This patch adds regulator-haptic device node controlled by regulator. Signed-off-by: Jaewon Kim jaewon02@samsung.com --- arch/arm/boot/dts/exynos3250-rinato.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts

[PATCH 1/2] Input: add regulator haptic driver

2014-11-20 Thread Jaewon Kim
This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework Signed-off-by: Jaewon Kim jaewon02@samsung.com Signed-off-by: Hyunhee Kim hyunhee@samsung.com Acked-by: Kyungmin Park

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
On 2014년 11월 20일 22:19, Andrzej Hajda wrote: On 11/20/2014 11:24 AM, Inki Dae wrote: This patch makes kms drivers to be independent drivers. For this, it removes all register codes to kms drivers from exynos_drm_drv module and adds module_init/exit for each kms driver so that each kms driver

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae inki@samsung.com wrote: If you try to build exynosdrm as module you will receive errors due to multiple definitions of init_module, ie module_init/module_*_driver macros can be used once per module. Ah, right. we had ever tried same

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Inki Dae
Hi Javier, On 2014년 11월 18일 22:53, Javier Martinez Canillas wrote: The Exynos DRM driver register its sub-devices platform drivers in the probe function but after commit 43c0767 (of/platform: Move platform devices under /sys/devices/platform), this is causing a deadlock in __driver_attach().

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
Hi Javier, On 2014년 11월 20일 23:06, Javier Martinez Canillas wrote: Hello Inki, On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae inki@samsung.com wrote: If you try to build exynosdrm as module you will receive errors due to multiple definitions of init_module, ie module_init/module_*_driver

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Andrzej Hajda
On 11/20/2014 02:56 PM, Inki Dae wrote: On 2014년 11월 20일 22:19, Andrzej Hajda wrote: On 11/20/2014 11:24 AM, Inki Dae wrote: This patch makes kms drivers to be independent drivers. For this, it removes all register codes to kms drivers from exynos_drm_drv module and adds module_init/exit for

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Pankaj Dubey
Merge branch 'akpm/master' 282497e mm: add strictlimit knob used exynos_defconfig Same here. With this display works for me. Without $Subject patch i get lookup in drm. I tested with today linux-next (next-20141120) and display is indeed working for me. So it seems that whatever caused

[PATCH 2/2] ARM: dts: Add max77693-haptic node for exynos4412-trats2

2014-11-20 Thread Jaewon Kim
This patch adds max77693-haptic node to support for haptic motor driver. Signed-off-by: Jaewon Kim jaewon02@samsung.com --- arch/arm/boot/dts/exynos4412-trats2.dts |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts

[PATCH 1/2] ARM: dts: add pwm node for exynos4412-trats2

2014-11-20 Thread Jaewon Kim
This patch add PWM(Pulse Width Modulation) node and handle to use pwm property. Signed-off-by: Jaewon Kim jaewon02@samsung.com --- arch/arm/boot/dts/exynos4412-trats2.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2014 03:07 PM, Inki Dae wrote: Could you re-base this patch on top of exynos-drm-next? I tried to separate sub drivers into independent drivers but it seems that we need more times. So I will merge your patch. Sure, I'll rebase on top of exynos-drm-next and re-post so

Re: [PATCH 1/2] Input: add regulator haptic driver

2014-11-20 Thread Pankaj Dubey
Hi Jaewon, On 20 November 2014 19:01, Jaewon Kim jaewon02@samsung.com wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework Signed-off-by: Jaewon Kim jaewon02@samsung.com

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
On 2014년 11월 20일 23:23, Andrzej Hajda wrote: On 11/20/2014 02:56 PM, Inki Dae wrote: On 2014년 11월 20일 22:19, Andrzej Hajda wrote: On 11/20/2014 11:24 AM, Inki Dae wrote: This patch makes kms drivers to be independent drivers. For this, it removes all register codes to kms drivers from

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Grygorii Strashko
On 11/20/2014 03:01 PM, Ulf Hansson wrote: On 20 November 2014 13:17, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to

Re: [PATCH 1/2] Input: add regulator haptic driver

2014-11-20 Thread Dan Murphy
Hi On 11/20/2014 08:33 AM, Pankaj Dubey wrote: Hi Jaewon, On 20 November 2014 19:01, Jaewon Kim jaewon02@samsung.com wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework

[PATCH 4/4] ARM: EXYNOS: cpuidle: allow driver usage on Exynos3250 SoC

2014-11-20 Thread Bartlomiej Zolnierkiewicz
Register cpuidle platform device on Exynos3250 SoC allowing EXYNOS cpuidle driver usage on this SoC. Cc: Daniel Lezcano daniel.lezc...@linaro.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/exynos.c

[PATCH 3/4] ARM: EXYNOS: cpuidle: add AFTR mode support for Exynos3250

2014-11-20 Thread Bartlomiej Zolnierkiewicz
Cc: Daniel Lezcano daniel.lezc...@linaro.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/firmware.c | 8 +++- arch/arm/mach-exynos/pm.c | 12 +++- arch/arm/mach-exynos/regs-pmu.h |

[PATCH 1/4] ARM: EXYNOS: fix CPU1 hotplug for AFTR mode on Exynos3250

2014-11-20 Thread Bartlomiej Zolnierkiewicz
CPU1 hotplug may hang when AFTR is used. Fix it by: - setting AUTOWAKEUP_EN bit in ARM_COREx_CONFIGURATION register in exynos_cpu_power_up() - not clearing reserved bits of ARM_COREx_CONFIGURATION register in exynos_cpu_power_down() - waiting while an undocumented register 0x0908 becomes

[PATCH 2/4] ARM: EXYNOS: add code for setting/clearing boot flag

2014-11-20 Thread Bartlomiej Zolnierkiewicz
This code is needed for cpuidle (W-)AFTR mode support on Exynos3250. Cc: Daniel Lezcano daniel.lezc...@linaro.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/common.h | 6 ++

[PATCH 0/4] ARM: EXYNOS: cpuidle: add AFTR mode support for Exynos3250

2014-11-20 Thread Bartlomiej Zolnierkiewicz
Hi, This patch series adds support for AFTR idle mode on boards with Exynos3250 SoC and allows EXYNOS cpuidle driver usage on these boards. It has been tested on Samsung Rinato board (Gear 2). Depends on: - for-next branch of linux-samsung.git kernel tree (or next-20141114 branch of

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2014 04:06 PM, Inki Dae wrote: BTW, it would be great if exynos-drm-next is pulled in linux-next. That is what most people use to test integration issues so you can catch earlier any regression that may arise. You have to email Stephen Rothwell s...@canb.auug.org.au and

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Paolo Pisati
On Thu, Nov 20, 2014 at 03:22:23PM +0530, Vivek Gautam wrote: On linux-samsung tree the only patch that's missing apart from dptx-phy patches is the syscon patch from Pankaj Dubey: b784b98 mfd: syscon: Decouple syscon interface from platform devices So with below git hash,

[PATCH] ARM: dts: Specify default clocks for Exynos4 camera devices

2014-11-20 Thread Sylwester Nawrocki
Specify the default mux and divider clocks in device tree to ensure the FIMC devices on Trats, Trats2, Universal_c210 and Odroid X2/U3 boards are clocked from recommended clock source and with maximum supported frequency. For Trats2 also the MIPI-CSIS and the camera sensor clocks are configured,

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Kevin Hilman
: Exynos5: Use pmu_system_controller phandle for dp phy 36391a5 Add linux-next specific files for 20141119 9b1ced1 Merge branch 'akpm/master' 282497e mm: add strictlimit knob With this display works for me. Without $Subject patch i get lookup in drm. The current linux-next (next-20141120

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Paolo, On 11/20/2014 04:57 PM, Paolo Pisati wrote: On Thu, Nov 20, 2014 at 03:22:23PM +0530, Vivek Gautam wrote: On linux-samsung tree the only patch that's missing apart from dptx-phy patches is the syscon patch from Pankaj Dubey: b784b98 mfd: syscon: Decouple syscon interface from

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Inki Dae
2014-11-21 0:26 GMT+09:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: Hello Inki, On 11/20/2014 04:06 PM, Inki Dae wrote: BTW, it would be great if exynos-drm-next is pulled in linux-next. That is what most people use to test integration issues so you can catch earlier any

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello, For completeness I'll comment what we talked with Kevin on IRC since probably this is the same issue that Paolo is facing. On 11/20/2014 05:41 PM, Kevin Hilman wrote: Peach # setenv preboot usb start; sleep 1setenv bootargs console=tty1 console=ttySAC3,115200 debug earlyprintk rw

Re: [PATCH v5 1/2] clk: samsung: exynos5440: move restart code into clock driver

2014-11-20 Thread Sylwester Nawrocki
On 19/11/14 04:37, Pankaj Dubey wrote: +static int exynos5440_clk_restart_notify(struct notifier_block *this, + unsigned long code, void *unused) +{ + u32 val, status; + + status = readl_relaxed(reg_base + 0xbc); + val =

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Kevin Hilman
Javier Martinez Canillas javier.marti...@collabora.co.uk writes: Hello, For completeness I'll comment what we talked with Kevin on IRC since probably this is the same issue that Paolo is facing. On 11/20/2014 05:41 PM, Kevin Hilman wrote: Peach # setenv preboot usb start; sleep 1setenv

Re: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-20 Thread Felipe Balbi
On Fri, Oct 31, 2014 at 11:12:33AM +0100, Marek Szyprowski wrote: This patch adds mutex, which protects initialization and deinitialization procedures against suspend/resume methods. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com doesn't apply either: checking file

Re: [PATCH v5] usb: dwc2/gadget: rework disconnect event handling

2014-11-20 Thread Felipe Balbi
On Mon, Nov 17, 2014 at 09:59:42AM +0100, Marek Szyprowski wrote: This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about unplugged usb cable. DISCONNINT interrupt cannot be used for this purpose, because it

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Rafael J. Wysocki
On Thursday, November 20, 2014 11:13:01 AM Ulf Hansson wrote: On 20 November 2014 01:35, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 19, 2014 09:54:00 AM Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() -

Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-20 Thread Gustavo Padovan
2014-11-13 Inki Dae inki@samsung.com: This patch fixes null pointer dereference issue incurred when ipp driver is enabled and Exynos drm driver is closed. Non kms driver should register its own sub driver to setup necessary resources, which is done by load(). So null pointer dereference

[PATCH 2/3] Revert drm/exynos: fix null pointer dereference issue

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk This reverts commit cea24824ab432f8acabb254d6805e9aa756de6af. Moving subdriver probe to exynos_drm_platform_probe() was making exynos_drm_device_subdrv_probe() fail because the platform data wasn't set yet. It only gets set in

[PATCH 1/3] drm/exynos: revert fixes for the infinite loop issue

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk This reverts commit 06a2f5c2c4e0cb4ff38ca3769ae1f81cc2d030cf and f7c2f36f4395f12d8ecb25c28ee88ec87b457089. These two patches were trying to fix an issue that was causing an infinite loop at the load of the exynos-drm but they were not

[PATCH 3/3] drm/exynos: move Exynos platform drivers registration to init

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Registering the Exynos DRM subdevices platform drivers in the probe function is causing an infinite loop. Fix this by moving it to the exynos_drm_init() function to register the drivers on module init. Registering drivers in the probe

[PATCH 0/3] drm/exynos: Fix exynos-drm initialization

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk These patches were tested both in drm-exynos-next and linux-next (with drm-exynos-next merged in) and it solves the infinite loop and parent device lock deadlock. It was tested with Ajay's DP patches applied. A tree based on drm-exynos-next

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Paolo Pisati
On Thu, Nov 20, 2014 at 10:22:54AM -0800, Kevin Hilman wrote: Javier Martinez Canillas javier.marti...@collabora.co.uk writes: Hello, For completeness I'll comment what we talked with Kevin on IRC since probably this is the same issue that Paolo is facing. On 11/20/2014 05:41 PM,

[PATCH 3/3] drm/exynos: avoid leak if exynos_dpi_probe() fails

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The component must be deleted if the probe fails. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 2/3] drm/exynos: avoid race condition when adding a drm component

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk exynos_drm_component_add() correctly checks if a component is present on drm_component_list however it release the lock right after the check and before we add the new component to the list. That just creates room to add the same component

[PATCH 1/3] drm/exynos: free DP if probe fails to find a panel or bridge

2014-11-20 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk DP was leaked everytime function returns EPROBE_DEFER, free it before returning. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++-- 1 file changed, 15

Re: [PATCH 1/2] Input: add regulator haptic driver

2014-11-20 Thread Jaewon Kim
Hi Pankaj, 2014년 11월 20일 23:33에 Pankaj Dubey 이(가) 쓴 글: Hi Jaewon, On 20 November 2014 19:01, Jaewon Kim jaewon02@samsung.com wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework

Re: [PATCH 1/2] Input: add regulator haptic driver

2014-11-20 Thread Jaewon Kim
Hi Dan, 2014년 11월 21일 00:09에 Dan Murphy 이(가) 쓴 글: Hi On 11/20/2014 08:33 AM, Pankaj Dubey wrote: Hi Jaewon, On 20 November 2014 19:01, Jaewon Kim jaewon02@samsung.com wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force

Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-20 Thread Inki Dae
On 2014년 11월 21일 08:12, Gustavo Padovan wrote: 2014-11-13 Inki Dae inki@samsung.com: This patch fixes null pointer dereference issue incurred when ipp driver is enabled and Exynos drm driver is closed. Non kms driver should register its own sub driver to setup necessary resources,

Re: [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver

2014-11-20 Thread Vivek Gautam
Hi Pankaj, On Tue, Nov 18, 2014 at 4:17 PM, Pankaj Dubey pankaj.du...@samsung.com wrote: Let's register restart handler from PMU driver for restart functionality. So that we can remove restart hooks from machine specific file, and thus moving ahead when PMU moved to driver folder, this

Re: [PATCH v3 2/5] drivers: soc: Add support for Exynos PMU driver

2014-11-20 Thread amit daniel kachhap
On Thu, Nov 20, 2014 at 3:33 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Nov 20, 2014 at 11:09:25AM +0530, Amit Daniel Kachhap wrote: diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 063113d..44d220d 100644 --- a/drivers/soc/Makefile +++

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-20 Thread Padma Venkat
Hi Mark, CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The driver by default uses manual mode. But on exynos7 the manual mode is

Re: [PATCH v4 1/2] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-11-20 Thread Wolfram Sang
On Thu, Oct 30, 2014 at 01:34:29PM +0530, Pankaj Dubey wrote: Let's handle i2c interrupt re-configuration in i2c driver. This will help us in removing some soc specific checks from machine files and will help in removing static iomapping of SYS register in exynos.c Since only Exynos5250, and