Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

On Tue, Feb 07, 2017 at 06:12:34PM +0100, Willy Tarreau wrote: > On Tue, Feb 07, 2017 at 09:02:51AM -0800, James Bottomley wrote: > > On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote: > > > Hi James, > > > > > > On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > > > > On

[PATCH] scsi/sd: release scan_mutex during sync_cache and start_stop

When a device is deleted through sysfs handle "delete", the code locks shost->scan_mutex. If multiple devices are deleted at the same time, these deletes will be handled in series. On the other hand, sd_shutdown() sometimes issues long latency commands: sync cache and start_stop. It is not

Re: [PATCH -next] scsi: qedi: Fix possible memory leak in qedi_iscsi_update_conn()

On 07/02/17 8:22 PM, "Wei Yongjun" wrote: >From: Wei Yongjun > >'conn_info' is malloced in qedi_iscsi_update_conn() and should be >freed before leaving from the error handling cases, otherwise it >will cause memory leak. > >Fixes: ace7f46ba5fd

Re: [PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

Hi Florian, On Tue, 2017-02-07 at 15:03 -0800, Florian Fainelli wrote: > From: Russell King > > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Add routines to support T10 DIF tag. > > Signed-off-by: Quinn Tran > Signed-off-by: Anil Gurumurthy > Signed-off-by: Himanshu Madhani

Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs

On Tue, 2017-02-07 at 15:12 -0800, Christoph Hellwig wrote: > And the real patch after compile fixing it is here of course: > Getting rid of the extra se_node_acl->acl_free_comp seems to make sense here.. The only potential issue is if returning from configfs syscall rmdir

Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E

On 2/7/2017 1:03 AM, Johannes Thumshirn wrote: Yes but patch 03/18 'lpfc: NVME Initiator: Base modifications Part A' still has calls to lpfc_sli_hbq_count(phba) (and in fact introduces this change). I realize I cut these in a silly way. In the v1 patches, I had a big patch that I then

Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

> "Arnd" == Arnd Bergmann writes: Arnd> Shifting a dma_addr_t right by 32 bits causes a compile-time Arnd> warning when that type is only 32 bit wide: Arnd> drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': Arnd> drivers/scsi/aacraid/src.c:414:29: error: right

[PATCH net-next v2 02/12] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King

[PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

Hi all, Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures

Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs

And the real patch after compile fixing it is here of course: diff --git a/drivers/target/target_core_internal.h b/drivers/target/target_core_internal.h index 9ab7090f7c83..96c38f30069d 100644 --- a/drivers/target/target_core_internal.h +++ b/drivers/target/target_core_internal.h @@ -152,6

[PATCH net-next v2 04/12] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface

[PATCH net-next v2 03/12] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got

[PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function

[PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()

From: Russell King octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated

Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs

On Tue, Feb 07, 2017 at 01:17:49PM +, Nicholas A. Bellinger wrote: > - list_del(>acl_list); > + list_del_init(>acl_list); All these list_del_init changes don't make sense to me - the whole target code never does a list_empty check on ->acl_list. Looking further I think all nacls

[PATCH net-next v2 05/12] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start'

[PATCH net-next v2 11/12] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20:

[PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King

Re: [PATCH v1 0/8] scsi: ufs: enhancements, bug fixes and debug support

> "Subhash" == Subhash Jadavani writes: Subhash> This patch series adds following things: - Gear scaling during Subhash> clock scaling to save additional power - Make clock scaling Subhash> independent clock gating so that we can set lower clock gating Subhash>

[PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class

[PATCH net-next v2 07/12] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable

[PATCH net-next v2 06/12] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King ---

[PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes

From: Russell King Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the

Re: [PATCH 5/5] target: Fix COMPARE_AND_WRITE ref leak for non GOOD status

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > + if (orig->se_lun_acl != NULL) { > + pr_warn_ratelimited("Detected existing explicit" > + " se_lun_acl->se_lun_group reference for %s" > +

Re: [PATCH 3/5] target: Fix early transport_generic_handle_tmr abort scenario

On Tue, Feb 07, 2017 at 01:17:48PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch fixes a bug where incoming task management requests > can be explicitly aborted during an active LUN_RESET, but who's > struct work_struct are canceled in-flight

Re: [PATCH 2/5] target: Use correct SCSI status during EXTENDED_COPY exception

Looks fine: Reviewed-by: Christoph Hellwig

Re: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

> "Colin" == Colin King writes: Colin> aac_fib_send can return -ve error returns and hence rcode should Colin> be signed. Currently the rcode >= 0 check is always true and -ve Colin> errors are not being checked. Colin> Thanks to Dan Carpenter for spotting my

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

> "Kashyap" == Kashyap Desai writes: Kashyap, Kashyap> Data length will be always guaranteed to be a multiple Kashyap> of the logical block size until and unless we have some Kashyap> firmware defect. In past, We have seen some partial/complete Kashyap> DMA data

RE: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, February 7, 2017 5:00 AM > To: dl-esc-Aacraid Linux Driver ; James E.J. > Bottomley ; Martin K. Petersen > > Cc: Arnd Bergmann

RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, February 7, 2017 3:51 AM > To: dl-esc-Aacraid Linux Driver ; James E . J . > Bottomley ; Martin K . Petersen > ;

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

On Tue, Feb 07, 2017 at 09:02:51AM -0800, James Bottomley wrote: > On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote: > > Hi James, > > > > On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > > > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: > > (...) > > > > We

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote: > Hi James, > > On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: > (...) > > > We don't have the referenced commit above in 3.10 so we should be > > > safe.

Re: [Lsf-pc] LSF/MM Question

On Tue, 2017-02-07 at 16:09 +, Jim Mostek via Lsf-pc wrote: > wondering about the upcoming Linux Storage Filesystem & MM summint in > March. LSF/MM Question > > What presentations are there so far? LSF/MM is not really a conference, it's a summit. That means it's going to be discussion

Re: [PATCH 00/10] mpt3sas: full mq support

On 02/07/2017 04:40 PM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 04:39:01PM +0100, Hannes Reinecke wrote: >> But we do; we're getting the index/tag/smid from the high-priority list, >> which is separated from the normal SCSI I/O tag space. >> (which reminds me; there's another cleanup

Re: [PATCH 00/10] mpt3sas: full mq support

On Tue, Feb 07, 2017 at 04:39:01PM +0100, Hannes Reinecke wrote: > But we do; we're getting the index/tag/smid from the high-priority list, > which is separated from the normal SCSI I/O tag space. > (which reminds me; there's another cleanup patch to be had in > _ctl_do_mpt_command(), but that's

Re: [PATCH 00/10] mpt3sas: full mq support

On 02/07/2017 04:34 PM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 03:38:51PM +0100, Hannes Reinecke wrote: >> The SCSI passthrough commands pass in pre-formatted SGLs, so the driver >> just has to map them. >> If we were converting that we first have to re-format the >> (driver-specific)

Re: [PATCH 00/10] mpt3sas: full mq support

On Tue, Feb 07, 2017 at 03:38:51PM +0100, Hannes Reinecke wrote: > The SCSI passthrough commands pass in pre-formatted SGLs, so the driver > just has to map them. > If we were converting that we first have to re-format the > (driver-specific) SGLs into linux sg lists, only to have them converted >

[patch] aacraid: information leak in aac_send_raw_srb()

The aac_srb_reply struct ends in a 2 byte hole so we end up leaking a bit of information to user space. Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/aacraid/commctrl.c

[PATCH -next] scsi: qedi: Fix possible memory leak in qedi_iscsi_update_conn()

From: Wei Yongjun 'conn_info' is malloced in qedi_iscsi_update_conn() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")

Re: [PATCH 00/10] mpt3sas: full mq support

On 02/07/2017 02:19 PM, Christoph Hellwig wrote: > Patch 1-7 look fine to me with minor fixups, and I'd love to see > them go into 4.11. The last one looks really questionable, > and 8 and 9 will need some work so that the MPT passthrough ioctls > either go away or make use of struct request and

[PATCH RFC] enclosure: fix symlinks creation

James, one of our customers complains that in some cases, when using multipath, the enclosure driver fails to create the symlinks in sysfs. This is an example of what happens: [ 19.251902] scsi 0:0:27:0: Direct-Access SEAGATE ST8000NM0075 E002 PQ: 0 ANSI: 6 [ 19.261874] scsi

[PATCH RFC] enclosure: fix sysfs symlinks creation when using multipath

With multipath, it may happen that the same device is passed to enclosure_add_device() multiple times and that the enclosure_add_links() function fails to create the symlinks because the device's sysfs directory entry is still NULL. In this case, the links will never be created because all the

[PATCH] scsi: aacraid: fix information leak on hbainfo.driver_name

From: Colin Ian King The driver_name field is not initialized and hence information on the stack is being leaked to userspace on the copy_to_user. Fix this. Signed-off-by: Colin Ian King --- drivers/scsi/aacraid/commctrl.c | 2 +- 1 file

[PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

From: Nicholas Bellinger After the v4.2+ RCU conversion to se_node_acl->lun_entry_hlist, a BUG_ON() was added in core_enable_device_list_for_node() to detect when the passed *lun does not match the existing orig->se_lun pointer reference. However, this scenario can occur

[PATCH 2/5] target: Use correct SCSI status during EXTENDED_COPY exception

From: Nicholas Bellinger This patch adds the missing target_complete_cmd() SCSI status parameter change in target_xcopy_do_work(), that was originally missing in commit 926317de33. It correctly propigates up the correct SCSI status during EXTENDED_COPY exception cases,

Re: [patch] scsi: qedi: silence sprintf() overflow warning

Am 07.02.2017 14:01, schrieb Dan Carpenter: > The problem here is this: > > sprintf(host_buf, "qedi_ofld%d", qedi->shost->host_no); > > host_buf is 16 character so we only have 6 characters left for > ->host_no. But ->host_no is set in scsi_host_alloc(): > > index =

[PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs

From: Nicholas Bellinger This patch addresses a long-standing bug with multi-session (eg: iscsi-target + iser-target) se_node_acl dynamic free withini transport_deregister_session(). This bug is caused when a storage endpoint is configured with demo-mode

[PATCH 3/5] target: Fix early transport_generic_handle_tmr abort scenario

From: Nicholas Bellinger This patch fixes a bug where incoming task management requests can be explicitly aborted during an active LUN_RESET, but who's struct work_struct are canceled in-flight before execution. This occurs when core_tmr_drain_tmr_list() invokes

[PATCH 0/5] target: Miscellaneous bug-fixes for >= v4.10

From: Nicholas Bellinger Hi all, This series contains a handful of bug-fixes that I've been validating on v4.1.y code for production usage over the past couple of months. All of these are long-standing issues that I don't think other folks have been able to hit (or at

[PATCH 5/5] target: Fix COMPARE_AND_WRITE ref leak for non GOOD status

From: Nicholas Bellinger This patch addresses a long standing bug where the commit phase of COMPARE_AND_WRITE would result in a se_cmd->cmd_kref reference leak if se_cmd->scsi_status returned non SAM_STAT_GOOD. This would manifest first as a lost SCSI response, and

Re: [PATCH 01/10] mpt3sas: switch to pci_alloc_irq_vectors

Looks fine: Reviewed-by: Christoph Hellwig Btw, I think the !smp_affinity_enable path should just go away sooner or later.

Re: [PATCH 07/10] mpt3sas: use hi-priority queue for TMFs

On Tue, Jan 31, 2017 at 10:25:57AM +0100, Hannes Reinecke wrote: > When sending a TMF via the ioctl interface we should be using > the hi-priority queue instead of the scsi queue to be consistent > with overall TMF usage. Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 00/10] mpt3sas: full mq support

Patch 1-7 look fine to me with minor fixups, and I'd love to see them go into 4.11. The last one looks really questionable, and 8 and 9 will need some work so that the MPT passthrough ioctls either go away or make use of struct request and the block layer and SCSI infrastructure.

Re: [PATCH 03/10] mpt3sas: implement _dechain_st()

On 02/07/2017 02:15 PM, Christoph Hellwig wrote: > On Tue, Jan 31, 2017 at 10:25:53AM +0100, Hannes Reinecke wrote: >> Split off _dechain_st() as separate function. >> No functional change. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/mpt3sas/mpt3sas_base.c | 23

Re: [PATCH 06/10] mpt3sas: Introduce mpt3sas_get_st_from_smid()

> inline u8 > mpt3sas_scsi_direct_io_get(struct MPT3SAS_ADAPTER *ioc, u16 smid) > { > - return ioc->scsi_lookup[smid - 1].direct_io; > + struct scsiio_tracker *st = mpt3sas_get_st_from_smid(ioc, smid); > + > + return st ? st->direct_io : 0; This wrapper can go away and be merged

Re: [PATCH 05/10] mpt3sas: open-code _scsih_scsi_lookup_get()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 03/10] mpt3sas: implement _dechain_st()

On Tue, Jan 31, 2017 at 10:25:53AM +0100, Hannes Reinecke wrote: > Split off _dechain_st() as separate function. > No functional change. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- > 1 file changed, 14

Re: [PATCH 02/10] mpt3sas: set default value for cb_idx

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 04/10] mpt3sas: separate out _base_recovery_check()

Looks fine, Reviewed-by: Christoph Hellwig

[patch] scsi: qedi: silence sprintf() overflow warning

The problem here is this: sprintf(host_buf, "qedi_ofld%d", qedi->shost->host_no); host_buf is 16 character so we only have 6 characters left for ->host_no. But ->host_no is set in scsi_host_alloc(): index = ida_simple_get(_index_ida, 0, 0, GFP_KERNEL); It could theoretically

Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

On 02/07/2017 01:59 PM, Arnd Bergmann wrote: > Shifting a dma_addr_t right by 32 bits causes a compile-time warning when > that type is only 32 bit wide: > > drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': > drivers/scsi/aacraid/src.c:414:29: error: right shift count >= width of

[PATCH] scsi: aacraid: avoid open-coded upper_32_bits

Shifting a dma_addr_t right by 32 bits causes a compile-time warning when that type is only 32 bit wide: drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': drivers/scsi/aacraid/src.c:414:29: error: right shift count >= width of type [-Werror=shift-count-overflow] This changes the

[bug report] scsi_dh_rdac: switch to scsi_execute_req_flags()

Hello Hannes Reinecke, The patch 327825574132: "scsi_dh_rdac: switch to scsi_execute_req_flags()" from Nov 3, 2016, leads to the following static checker warning: drivers/scsi/device_handler/scsi_dh_rdac.c:551 send_mode_select() error: potential NULL dereference 'ctlr->ms_sdev'.

RE: [PATCH 18/39] megaraid_sas: MR_TargetIdToLdGet u8 to u16 and avoid invalid raid-map access

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:51 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

[PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

From: Colin Ian King aac_fib_send can return -ve error returns and hence rcode should be signed. Currently the rcode >= 0 check is always true and -ve errors are not being checked. Thanks to Dan Carpenter for spotting my original broken fix to this issue.

Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

On 07/02/17 11:37, Dan Carpenter wrote: > On Tue, Feb 07, 2017 at 11:27:38AM +, Colin King wrote: >> From: Colin Ian King >> >> The check on rcode >= 0 is always true because rcode is unsigned >> and can never be less than zero. Remove the redundant check. >> >>

Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

On Tue, Feb 07, 2017 at 11:27:38AM +, Colin King wrote: > From: Colin Ian King > > The check on rcode >= 0 is always true because rcode is unsigned > and can never be less than zero. Remove the redundant check. > > Signed-off-by: Colin Ian King

[PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

From: Colin Ian King The check on rcode >= 0 is always true because rcode is unsigned and can never be less than zero. Remove the redundant check. Signed-off-by: Colin Ian King --- drivers/scsi/aacraid/aachba.c | 2 +- 1 file changed, 1

RE: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Tuesday, February 07, 2017 5:22 AM > To: Shivasharan S > Cc: linux-scsi@vger.kernel.org; martin.peter...@oracle.com; > the...@redhat.com; j...@linux.vnet.ibm.com; > kashyap.de...@broadcom.com;

Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E

On 02/07/2017 12:08 AM, James Smart wrote: > > NVME Initiator: Base modifications > > This is part E of parts A..F. > > Part E is limited to lpfc_sli.c. This is the location of most of changes > for the following: > - sli3 ring vs sli4 wq splits > - io abort interfaces > - actual queuing

RE: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

> -Original Message- > From: Kashyap Desai [mailto:kashyap.de...@broadcom.com] > Sent: Monday, February 06, 2017 10:48 PM > To: 'Tomas Henzl'; Shivasharan Srikanteshwara; 'linux-scsi@vger.kernel.org' > Cc: 'martin.peter...@oracle.com'; 'j...@linux.vnet.ibm.com'; Sumit Saxena; >

Re: [PATCH v2 02/18] lpfc: use pci_irq_alloc_vectors and pci_irq_free_vectors

On 02/07/2017 12:08 AM, James Smart wrote: > > I replaced the v1 patch with Christoph's original > > james > > From: Christoph Hellwig > > This avoids having to store the msix_entries array and simpliefies the > shutdown and cleanup path a lot. > > Signed-off-by: Christoph

Re: [PATCH v2 01/18] lpfc: Correct WQ creation for pagesize

On 02/07/2017 12:08 AM, James Smart wrote: > > Correct WQ creation for pagesize > > The driver was calculating the adapter command pagesize indicator from > the system pagesize. However, the buffers the driver allocates are only > one size (SLI4_PAGE_SIZE), so no calculation was necessary. > >