From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds ANY_LAYOUT prerequisites logic for accepting a set of
protection + data payloads via iov_iter. Also includes helpers for
calcuating SGLs + invoking vhost_scsi_map_to_sgl() with a known number
of iovecs.
Required by ANY_LAYOUT
From: Nicholas Bellinger n...@linux-iscsi.org
With the new ANY_LAYOUT logic in place for vhost_scsi_handle_vqal(),
there is no longer a reason to keep around the legacy code with
!ANY_LAYOUT assumptions.
Go ahead and drop the pre virtio 1.0 logic in vhost_scsi_handle_vq()
and associated helpers
From: Nicholas Bellinger n...@linux-iscsi.org
This patch fixes vhost_scsi_handle_vq() failure cases that result in BUG_ON()
getting triggered when vhost_scsi_free_cmd() is called, and -tvc_se_cmd has
not been initialized by target_submit_cmd_map_sgls().
It changes tcm_vhost_release_cmd() to use
From: Nicholas Bellinger n...@linux-iscsi.org
With the recent removal of MSG_*_TAG defines in commit 68d81f40,
vhost-scsi is now using TCM_*_TAG and doesn't depend upon host
side scsi_tcq.h definitions anymore.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Signed
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds ANY_LAYOUT support with a new vqs[].vq.handle_kick()
callback in vhost_scsi_handle_vqal().
It calculates data_direction + exp_data_len for the new tcm_vhost_cmd
descriptor by walking both outgoing + incoming iovecs using iov_iter
From: Nicholas Bellinger n...@linux-iscsi.org
Hi MST, Paolo, Al Co,
Here is -v3 for adding vhost/scsi ANY_LAYOUT + VERSION_1 host feature
bit support.
It adds a new vhost_virtqueue -handle_kick() callback to determine the
start of protection and data payloads iovecs past starting virtio-scsi
From: Nicholas Bellinger n...@linux-iscsi.org
With the new ANY_LAYOUT logic in place for vhost_scsi_handle_vqal(),
there is no longer a reason to keep around the legacy code with
!ANY_LAYOUT assumptions.
Go ahead and drop the pre virtio 1.0 logic in vhost_scsi_handle_vq()
and associated helpers
From: Nicholas Bellinger n...@linux-iscsi.org
There is a large amount of code that still references the original
'tcm_vhost' naming conventions, instead of modern 'vhost_scsi'.
Go ahead and do a global rename to make the usage consistent.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini
From: Nicholas Bellinger n...@linux-iscsi.org
Signal support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits
required for virtio-scsi 1.0 spec layout requirements.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Nicholas Bellinger n...@linux
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes vhost_scsi_map_to_sgl() parameters to accept virtio
iovec ptr + len when determing pages_nr.
This is currently done with iov_num_pages() - PAGE_ALIGN, so allow
the same parameters as well.
Cc: Michael S. Tsirkin m...@redhat.com
Cc
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds ANY_LAYOUT support with a new vqs[].vq.handle_kick()
callback in vhost_scsi_handle_vqal().
It calculates data_direction + exp_data_len for the new tcm_vhost_cmd
descriptor by walking both outgoing + incoming iovecs, assuming
From: Nicholas Bellinger n...@linux-iscsi.org
Required for ANY_LAYOUT support when the incoming virtio-scsi response
header + fixed size sense buffer payload may span more than a single
iovec entry.
This changes existing code to save cmd-tvc_resp_iod instead of the
first single iovec base
From: Nicholas Bellinger n...@linux-iscsi.org
This patch fixes vhost_scsi_handle_vq() failure cases that result in BUG_ON()
getting triggered when vhost_scsi_free_cmd() is called, and -tvc_se_cmd has
not been initialized by target_submit_cmd_map_sgls().
It changes tcm_vhost_release_cmd() to use
From: Nicholas Bellinger n...@linux-iscsi.org
With the recent removal of MSG_*_TAG defines in commit 68d81f40,
vhost-scsi is now using TCM_*_TAG and doesn't depend upon host
side scsi_tcq.h definitions anymore.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Signed
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds ANY_LAYOUT prerequisites logic for accepting a set of
protection + data payloads via iovec + offset. Also includes helpers
for calcuating SGLs + invoking vhost_scsi_map_to_sgl() with a known
number of iovecs.
Required by ANY_LAYOUT
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a new memcpy_fromiovec_out() library function which modifies
the passed *iov following memcpy_fromiovec(), but also returns the next current
iovec pointer via **iov_out.
This is useful for vhost ANY_LAYOUT support when guests
From: Nicholas Bellinger n...@linux-iscsi.org
Hi MST, Paolo, Co,
This -v2 series adds vhost/scsi ANY_LAYOUT + VERSION_1 host feature bit
support.
It adds a new vhost_virtqueue -handle_kick() callback to determine the
start of protection and data payloads iovecs past starting virtio-scsi
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a vhost_skip_iovec_bytes() helper for skipping ahead
a number of bytes into the passed *iov_in + off_in, saving the current
**iov_out + off_out so it may be used by the caller.
This is useful for virtio-scsi READs when needing to skip
On Fri, 2015-01-30 at 10:33 +0100, Paolo Bonzini wrote:
On 30/01/2015 09:12, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a new memcpy_fromiovec_out() library function which modifies
the passed *iov following memcpy_fromiovec(), but also
On Fri, 2015-01-30 at 12:51 +0200, Michael S. Tsirkin wrote:
On Fri, Jan 30, 2015 at 08:12:28AM +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes vhost_scsi_map_to_sgl() parameters to accept virtio
iovec ptr + len when determing pages_nr
On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote:
Hi Nicholas,
On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
Hi Nicolas,
On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
n...@linux
From: Nicholas Bellinger n...@linux-iscsi.org
Move logic for typical vhost_scsi_handle_vq() - tcm_vhost_workqueue -
tcm_vhost_submission_work() dispatch into vhost_scsi_queue_desc().
Can be shared by vhost_scsi_handle_vqal() code.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini pbonz
From: Nicholas Bellinger n...@linux-iscsi.org
This patch fixes vhost_scsi_handle_vq() failure cases that result in BUG_ON()
getting triggered when vhost_scsi_free_cmd() is called, and -tvc_se_cmd has
not been initialized by target_submit_cmd_map_sgls().
It changes tcm_vhost_release_cmd() to use
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes vhost_scsi_map_to_sgl() parameters to accept virtio
iovec ptr + len when determing pages_nr.
This is currently done with iov_num_pages() - PAGE_ALIGN, so allow
the same parameters as well.
Cc: Michael S. Tsirkin m...@redhat.com
Cc
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a new memcpy_fromiovec_out() library function which modifies
the passed *iov following memcpy_fromiovec(), but also returns the next current
iovec pointer via **iov_out.
This is useful for vhost ANY_LAYOUT support when guests
From: Nicholas Bellinger n...@linux-iscsi.org
Hi MST Paolo,
The series adds initial vhost/scsi ANY_LAYOUT layout support.
It assumes request/CDB and response/sense_buffer headers may span more
than a single iovec using lib/iovec.c logic, along with a new addition
of memcpy_fromiovec_out
From: Nicholas Bellinger n...@linux-iscsi.org
Required for ANY_LAYOUT support when the incoming virtio-scsi response
header + fixed size sense buffer payload may span more than a single
iovec entry.
This changes existing code to save cmd-tvc_resp_iod instead of the
first single iovec base
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds initial ANY_LAYOUT support with a new vhost_virtqueue
callback in vhost_scsi_handle_vqal().
It calculates data_direction + exp_data_len for the new tcm_vhost_cmd
descriptor by walking both outgoing + incoming iovecs, assuming
From: Nicholas Bellinger n...@linux-iscsi.org
Signal support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits
required for virtio-scsi 1.0 spec layout requirements.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Nicholas Bellinger n...@linux
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds ANY_LAYOUT prerequisites logic for accepting a set of
protection + data payloads via iovec + offset. Also includes helpers
for calcuating SGLs + invoking vhost_scsi_map_to_sgl() with a known
number of iovecs.
Required by ANY_LAYOUT
On Wed, 2015-01-21 at 17:18 +0100, Bart Van Assche wrote:
Hello,
Although several SCSI LLDs compare sc_data_direction with the value
DMA_BIDIRECTIONAL apparently scsi_setup_cmnd() never sets
sc_data_direction to the value DMA_BIDIRECTIONAL. Is this behavior on
purpose ?
Yes.
.
Thank you,
--nab
From 33f211fcf0f4149b13de826dcbe204241f71b2e8 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger n...@linux-iscsi.org
Date: Thu, 22 Jan 2015 00:56:53 -0800
Subject: [PATCH] iscsi-target: Drop problematic active_ts_list usage
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
On Thu, 2015-01-22 at 11:14 +0100, Bart Van Assche wrote:
On 01/22/15 11:02, Nicholas A. Bellinger wrote:
On Wed, 2015-01-21 at 17:18 +0100, Bart Van Assche wrote:
Although several SCSI LLDs compare sc_data_direction with the value
DMA_BIDIRECTIONAL apparently scsi_setup_cmnd() never sets
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
Hi Nicolas,
On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
Hi Gavin,
On Thu, 2015-01-22 at 06:38 +0800, Gavin Guo wrote:
Hi all,
The general protection fault screenshot is attached.
Summary
On Thu, 2015-01-15 at 13:28 +0200, Andy Shevchenko wrote:
Instead of pushing each byte via stack let's use custom specifier which allows
to print small buffers as a hex string.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +---
On Tue, 2015-01-20 at 15:27 -0800, Andy Grover wrote:
Hi all,
tcmu-runner is a userspace daemon that simplifies the configuration and
processing of SCSI commands from LIO to userspace handlers, via the new
TCMU userspace passthrough backstore.
https://github.com/agrover/tcmu-runner
On Thu, 2015-01-15 at 13:40 +0200, Andy Shevchenko wrote:
Instead of pushing each byte via stack the %*ph specifier allows to supply
just
a pointer and length of the buffer. The patch converts code to use the
specifier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
On Wed, 2015-01-14 at 11:05 +0100, Bart Van Assche wrote:
The LIO and SCST SCSI target subsystems consist of the following components:
* A core that processes SCSI commands and that provides common
functionality like persistent reservations, LUN masking and an interface
that allows
attribute.
Thank you,
--nab
Andy Grover (1):
iscsi-target: Fix typos in enum cmd_flags_table
Lee Duncan (1):
target: Allow Write Exclusive non-reservation holders to READ
Nicholas Bellinger (4):
vhost-scsi: Add missing virtio-scsi - TCM attribute conversion
Documentation/target: Update
On Fri, 2015-01-09 at 15:43 -0500, Martin K. Petersen wrote:
nab == Nicholas A Bellinger n...@linux-iscsi.org writes:
nab The concern is when older hardware drivers are reporting say
nab queue_max_hw_sectors=128 with initiators are not actively honoring
nab block limits EVPD MAXIMUM
From: Nicholas Bellinger n...@linux-iscsi.org
This patch drops the arbitrary maximum I/O size limit in sbc_parse_cdb(),
which currently for fabric_max_sectors is hardcoded to 8192 (4 MB for 512
byte sector devices), and for hw_max_sectors is a backend driver dependent
value.
This limit
From: Nicholas Bellinger n...@linux-iscsi.org
Now that fabric_max_sectors is no longer used to enforce the maximum
I/O size, go ahead and drop it's left-over usage in target-core and
associated backend drivers.
Cc: Christoph Hellwig h...@lst.de
Cc: Martin K. Petersen martin.peter...@oracle.com
On Thu, 2015-01-08 at 14:49 -0800, Nicholas A. Bellinger wrote:
On Thu, 2015-01-08 at 09:37 -0500, Martin K. Petersen wrote:
nab == Nicholas A Bellinger n...@linux-iscsi.org writes:
nab IIRC, most modern hardware is reporting a large enough value for
nab queue_max_hw_sectors
On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote:
On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote:
On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote:
On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote:
SNIP
The point is that a simple session wide
On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote:
On 01/07/15 22:39, Mike Christie wrote:
On 01/07/2015 10:57 AM, Hannes Reinecke wrote:
On 01/07/2015 05:25 PM, Sagi Grimberg wrote:
Hi everyone,
Now that scsi-mq is fully included, we need an iSCSI initiator that
would use it
On Thu, 2015-01-08 at 10:58 -0800, Andy Grover wrote:
On 01/07/2015 02:11 PM, Douglas Gilbert wrote:
T10 have now dropped the LID1 and LID4 stuff (its the length
of the LIST IDENTIFIER field: 1 byte or 4 bytes) by obsoleting
all LID1 variants in SPC-5 revision 01. So the LID1 variants
are
On Thu, 2015-01-08 at 09:37 -0500, Martin K. Petersen wrote:
nab == Nicholas A Bellinger n...@linux-iscsi.org writes:
nab IIRC, most modern hardware is reporting a large enough value for
nab queue_max_hw_sectors() to support 8 MB I/Os, but I'm thinking that
nab this could end up being
On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote:
On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote:
On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote:
On 01/07/15 22:39, Mike Christie wrote:
On 01/07/2015 10:57 AM, Hannes Reinecke wrote:
On 01/07/2015 05
On Wed, 2015-01-07 at 22:26 +0200, Sagi Grimberg wrote:
On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
SNIP
Hey Nic,
Hope all is well.
So this skeleton is interesting to me. As this is a fabric module I
assume
On Wed, 2015-01-07 at 18:25 +0200, Sagi Grimberg wrote:
Hi everyone,
Now that scsi-mq is fully included, we need an iSCSI initiator that
would use it to achieve scalable performance. The need is even greater
for iSCSI offload devices and transports that support multiple HW
queues. As iSER
On Sun, 2015-01-04 at 12:16 -0500, Mike Snitzer wrote:
Hi,
I'd like to attend LSF (and the first day of Vault).
As a DM maintainer I'm open to discussing anything DM related. In
particular I'd like to at least have hallway track discussions with
key people interested in DM multipath
On Tue, 2015-01-06 at 19:08 -0800, Lee Duncan wrote:
On 01/06/2015 01:23 PM, Nicholas A. Bellinger wrote:
On Mon, 2015-01-05 at 10:49 -0800, Lee Duncan wrote:
From: Lee Duncan ldun...@suse.com
For PGR reservation type Exclusive Access, allow all
registrants to read from the device
Hey Christoph,
Adding CC' for MKP.
On Wed, 2015-01-07 at 00:24 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch avoids the arbitrary limiting of I/O size to fabric_max_sectors,
which currently has a hardcoded max of 8192 (4 MB for 512 byte sector
On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
nvme_of
head
On Tue, 2015-01-06 at 23:07 +0200, Michael S. Tsirkin wrote:
On Tue, Jan 06, 2015 at 08:18:05PM +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
While looking at hch's recent conversion to drop the MSG_*_TAG
definitions, I noticed a long standing bug
On Tue, 2015-01-06 at 14:39 -0800, Nicholas A. Bellinger wrote:
On Tue, 2014-12-23 at 09:28 +0100, Christoph Hellwig wrote:
On Mon, Dec 22, 2014 at 11:31:53AM +0100, Stefan Priebe - Profihost AG
wrote:
Hi,
since the below patch i've some problems with iscsi.
The LIO based
From: Nicholas Bellinger n...@linux-iscsi.org
Now that fabric_max_sectors is no longer used to enforce the maximum
I/O size, go ahead and drop it's left-over usage in target-core and
associated backend drivers.
Cc: Christoph Hellwig h...@lst.de
Cc: Roland Dreier rol...@purestorage.com
Signed-off
From: Nicholas Bellinger n...@linux-iscsi.org
This patch avoids the arbitrary limiting of I/O size to fabric_max_sectors,
which currently has a hardcoded max of 8192 (4 MB for 512 byte sector
devices).
This is problematic because Linux initiators have only recently started
to honor block limits
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
nvme_of
head: 40d8c11927282d59855d645b35798edd97828da5
commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial
skeleton commit
On Tue, 2014-12-23 at 09:28 +0100, Christoph Hellwig wrote:
On Mon, Dec 22, 2014 at 11:31:53AM +0100, Stefan Priebe - Profihost AG wrote:
Hi,
since the below patch i've some problems with iscsi.
The LIO based iscsi Server is full of messages like this:
SCSI OP 2ah with too big
Hi Doug,
On Thu, 2014-12-18 at 11:53 -0500, Douglas Gilbert wrote:
SNIP
FreeNAS's iSCSI target also implements ODX which is one
reason why I have been looking at it (hint to NAB). With
ODX it does cut one significant corner in only supporting
access upon reference RODs. Its ODX
headers_install.sh badness
Lino Sanfilippo (1):
iscsi-target: fix error path in iscsi_target_init_module()
Markus Elfring (1):
target: Deletion of unnecessary checks before the function call
module_put
Nicholas Bellinger (22):
target: Move dev_cit to struct se_subsystem_api
target: Move
On Thu, 2014-12-18 at 16:54 +0200, Ilias Tsitsimpis wrote:
On Tue, Dec 16, 2014 at 12:09AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi all,
This series addresses two issues raised recently by Ilias wrt
AllRegistrants reservation handling in target
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes core_scsi3_pro_release() logic to allow an
existing AllRegistrants type reservation to be re-reserved by
any registered I_T nexus.
This addresses a issue where AllRegistrants type RESERVE was
receiving RESERVATION_CONFLICT status
From: Nicholas Bellinger n...@linux-iscsi.org
Hi all,
This series addresses two issues raised recently by Ilias wrt
AllRegistrants reservation handling in target code that does not
adhere to SPC-4 specification requirements.
This first is a informational change to PR-IN READ_FULL_STATUS
From: Nicholas Bellinger n...@linux-iscsi.org
This patch fixes the usage of R_HOLDER bit for an All Registrants
reservation in READ_FULL_STATUS, where only the registration who
issued RESERVE was being reported as having an active reservation.
It changes core_scsi3_pri_read_full_status
On Sat, 2014-12-13 at 08:33 +0100, James Bottomley wrote:
On Fri, 2014-12-12 at 17:53 -0800, Nicholas A. Bellinger wrote:
On Sat, 2014-12-13 at 00:52 +0100, James Bottomley wrote:
On Fri, 2014-12-12 at 14:59 -0800, Nicholas A. Bellinger wrote:
Hello T10/SCSI folks,
A question
Hello T10/SCSI folks,
A question came up on the LIO target-devel mailing list recently wrt the
proper handling of Persistent Reservations + All Registrants logic in a
couple of different scenarios.
The crux of the confusion stems from how registrations are treated
before an explicit PR-OUT
On Thu, 2014-12-11 at 22:12 -0500, Martin K. Petersen wrote:
Vlad == Vladislav Bolkhovitin v...@vlnb.net writes:
Vlad,
Vlad We are currently developing a SCSI target system with T10-PI. We
Vlad are using block integrity interface and found a problem that this
Vlad interface fundamentally
On Sat, 2014-12-13 at 00:52 +0100, James Bottomley wrote:
On Fri, 2014-12-12 at 14:59 -0800, Nicholas A. Bellinger wrote:
Hello T10/SCSI folks,
A question came up on the LIO target-devel mailing list recently wrt the
proper handling of Persistent Reservations + All Registrants logic
,
+ shost-sg_tablesize, SCSI_MAX_SG_SEGMENTS) *
+ sizeof(struct scatterlist);
memset(cmd-prot_sdb, 0, sizeof(struct scsi_data_buffer));
cmd-prot_sdb-table.sgl =
Nice catch.
Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org
Adding
On Sun, 2014-11-30 at 12:00 +0100, Lino Sanfilippo wrote:
In iscsi_target_init_module() unwind transport protocol registration in case
that iscsit_load_discovery_tpg() failed.
Signed-off-by: Lino Sanfilippo linosanfili...@gmx.de
---
drivers/target/iscsi/iscsi_target.c | 1 +
1 file
On Sun, 2014-11-30 at 19:14 +0100, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Delete a local array that is only used to be initialized by memset.
A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
identifier x;
type T;
@@
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts PSCSI to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial
From: Nicholas Bellinger n...@linux-iscsi.org
Now that PSCSI is only exposing four hw_* read-only device attributes,
go ahead and drop the left-over - legacy PHBA_PDEV checks in various
se_dev_set_* code, since it's now only used by virtual devices.
Signed-off-by: Nicholas Bellinger n...@linux
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts RAMDISK to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts IBLOCK to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial
From: Nicholas Bellinger n...@linux-iscsi.org
Hi all,
This series addresses a long standing limitation going back to early
LIO v3.x days, where all TCM backend devices originally used local
scope struct config_item_types in target_core_configfs.c code that
resulted in same /sys/kernel/config
From: Nicholas Bellinger n...@linux-iscsi.org
Now that backend drivers are populating their own device attributes,
go ahead and remove left-over definitions + internal attribute list
of device attributes from target_core_configfs.c code
Also update TB_CIT_SETUP(dev_attrib,...) to signal ct_attr
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts FILEIO to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds initial support for dev_cit as external config_item_type.
This includes a new struct target_backend_cits to hold the external CITs
within struct se_subsystem_api, and target_core_setup_sub_cits() to be
used by backend drivers ahead
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for dev_alua_tg_pt_gps_cit as an external
config_item_type
using TB_CIT_SETUP() helper macro, and sets only ct_group_ops following
existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for dev_pr_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for dev_attrib_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for dev_wwn_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts TCM-USER to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial
From: Nicholas Bellinger n...@linux-iscsi.org
Now that target_core_backend_configfs.h macros will be using these
se_dev_set attribute functions externally to allow backend drivers
to populate different attributes, go ahead and add EXPORT_SYMBOL()
for the existing default set of 30 device
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a number of configfs e-attr macros following
what existing target_core_configfs.c code does for internal
target_backend_dev_attrib setup, and similar to how target
fabric drivers allow for external config_item_type + cit-ct_attrs
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for dev_stat_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets only ct_group_ops following
existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct
From: Nicholas Bellinger n...@linux-iscsi.org
This helper macro adds the default set of 30 device attributes for
virtual devices from existing target_core_configfs.c code, and moves
the definitions into a single macro to create the structs necessary
for backend drivers.
It allows them
On Wed, 2014-11-26 at 14:58 +0100, Hannes Reinecke wrote:
tcm_loop has the I_T nexus associated with the HBA. This causes
commands to become misdirected if the HBA has more than one
target portal group; any command is then being sent to the
first target portal group instead of the correct one.
On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote:
From: Markus Elfring elfr...@users.sourceforge.net
Date: Fri, 21 Nov 2014 10:25:45 +0100
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO-write_pending if data_length == 0
Sagi Grimberg (1):
iser-target
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO-write_pending if data_length == 0
Sagi Grimberg (1):
iser-target
On Tue, 2014-10-21 at 12:24 +0300, Sagi Grimberg wrote:
On 10/21/2014 2:39 AM, Nicholas A. Bellinger wrote:
Hi Linus,
Here are the target updates for v3.18-rc2 code. These where originally
destined for -rc1, but due to the combination of travel last week for
KVM Forum and my mistake
Hey Paolo,
On Thu, 2014-10-09 at 12:49 +0200, Paolo Bonzini wrote:
Il 09/10/2014 10:49, Paolo Bonzini ha scritto:
It does not happen if you close QEMU with SIGTERM, ctrl-c, or with the
quit command, because no attempt is done to bring down the VM data
structures (or free memory, or
qla_target: improve qlt_unmap_sg()
qla_target: rearrange struct qla_tgt_prm
qla_target: don't delete changed nacls
Nicholas Bellinger (5):
iscsi-target: Drop duplicate __iscsi_target_login_thread check
target/user: Fix up smatch warnings in tcmu_netlink_event
target: Fix APTPL metadata handling
On Tue, 2014-10-07 at 09:58 +0300, Sagi Grimberg wrote:
On 10/6/2014 5:15 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch explicitly disables TX completion interrupt coalescing logic
in isert_put_response() and isert_put_datain
On Mon, 2014-10-06 at 16:40 -0700, Zach Brown wrote:
Both of the file target's calls to vfs_fsync_range() got the end offset
off by one. The range is inclusive, not exclusive. It would sync a bit
more data than was required.
The sync path already tested the length of the range and fell
From: Nicholas Bellinger n...@linux-iscsi.org
This patch addresses a bug where individual vhost-scsi configfs endpoint
groups can be removed from below while active exports to QEMU userspace
still exist, resulting in an OOPs.
It adds a configfs_depend_item() in vhost_scsi_set_endpoint
701 - 800 of 1624 matches
Mail list logo
