RE: [PATCH 00/10] mpt3sas: full mq support

2017-02-16 Thread Kashyap Desai
> > - Later we can explore if nr_hw_queue more than one really add benefit. > > From current limited testing, I don't see major performance boost if > > we have nr_hw_queue more than one. > > > Well, the _actual_ code to support mq is rather trivial, and really serves > as a > good testbed for scsi

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-16 Thread Hannes Reinecke
; James Bottomley; linux- >> s...@vger.kernel.org; Sathya Prakash Veerichetty; PDL-MPT-FUSIONLINUX >> Subject: Re: [PATCH 00/10] mpt3sas: full mq support >> >> On 02/15/2017 10:18 AM, Kashyap Desai wrote: >>>> >>>> >>>> Hannes, >>>> >&

RE: [PATCH 00/10] mpt3sas: full mq support

2017-02-16 Thread Kashyap Desai
DL-MPT-FUSIONLINUX > Subject: Re: [PATCH 00/10] mpt3sas: full mq support > > On 02/15/2017 10:18 AM, Kashyap Desai wrote: > >> > >> > >> Hannes, > >> > >> Result I have posted last time is with merge operation enabled in > >> bloc

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-15 Thread Hannes Reinecke
On 02/15/2017 10:18 AM, Kashyap Desai wrote: >> >> >> Hannes, >> >> Result I have posted last time is with merge operation enabled in block >> layer. If I disable merge operation then I don't see much improvement >> with >> multiple hw request queues. Here is the result, >> >> fio results when nr_h

RE: [PATCH 00/10] mpt3sas: full mq support

2017-02-15 Thread Kashyap Desai
> > > Hannes, > > Result I have posted last time is with merge operation enabled in block > layer. If I disable merge operation then I don't see much improvement > with > multiple hw request queues. Here is the result, > > fio results when nr_hw_queues=1, > 4k read when numjobs=24: io=248387MB, bw=

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-15 Thread Sreekanth Reddy
On Mon, Feb 13, 2017 at 6:41 PM, Hannes Reinecke wrote: > On 02/13/2017 07:15 AM, Sreekanth Reddy wrote: >> On Fri, Feb 10, 2017 at 12:29 PM, Hannes Reinecke wrote: >>> On 02/10/2017 05:43 AM, Sreekanth Reddy wrote: On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: > On 02/09/2017

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-15 Thread Hannes Reinecke
On 02/15/2017 09:15 AM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 02:19:09PM +0100, Christoph Hellwig wrote: >> Patch 1-7 look fine to me with minor fixups, and I'd love to see >> them go into 4.11. > > Any chance to see a resend of these? > Sure. Will do shortly. Cheers, Hannes -- D

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-15 Thread Christoph Hellwig
On Tue, Feb 07, 2017 at 02:19:09PM +0100, Christoph Hellwig wrote: > Patch 1-7 look fine to me with minor fixups, and I'd love to see > them go into 4.11. Any chance to see a resend of these?

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-13 Thread Hannes Reinecke
On 02/13/2017 07:15 AM, Sreekanth Reddy wrote: > On Fri, Feb 10, 2017 at 12:29 PM, Hannes Reinecke wrote: >> On 02/10/2017 05:43 AM, Sreekanth Reddy wrote: >>> On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: >> [ .. ] > > > Ha

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-12 Thread Sreekanth Reddy
On Fri, Feb 10, 2017 at 12:29 PM, Hannes Reinecke wrote: > On 02/10/2017 05:43 AM, Sreekanth Reddy wrote: >> On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: >>> On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: > [ .. ] Hannes, I have created a md raid0 with 4 SAS SSD

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Hannes Reinecke
On 02/10/2017 05:43 AM, Sreekanth Reddy wrote: > On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: >> On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: [ .. ] >>> >>> >>> Hannes, >>> >>> I have created a md raid0 with 4 SAS SSD drives using below command, >>> #mdadm --create /dev/md0 --level=0 -

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Sreekanth Reddy
;>>>> -Original Message- >>>>>>> From: Hannes Reinecke [mailto:h...@suse.de] >>>>>>> Sent: Tuesday, January 31, 2017 4:47 PM >>>>>>> To: Christoph Hellwig >>>>>>> Cc: Martin K. Petersen; Jame

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Hannes Reinecke
gt;>> Sent: Wednesday, February 01, 2017 12:21 PM >>>> To: Kashyap Desai; Christoph Hellwig >>>> Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; >>>> Sathya >>>> Prakash Veerichetty; PDL-MPT-FUSIONLINUX; Sreekanth Reddy

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Sreekanth Reddy
: Kashyap Desai; Christoph Hellwig >>> Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; >>> Sathya >>> Prakash Veerichetty; PDL-MPT-FUSIONLINUX; Sreekanth Reddy >>> Subject: Re: [PATCH 00/10] mpt3sas: full mq support >>> >>> On 01/

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Hannes Reinecke
On 02/07/2017 04:40 PM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 04:39:01PM +0100, Hannes Reinecke wrote: >> But we do; we're getting the index/tag/smid from the high-priority list, >> which is separated from the normal SCSI I/O tag space. >> (which reminds me; there's another cleanup pat

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Christoph Hellwig
On Tue, Feb 07, 2017 at 04:39:01PM +0100, Hannes Reinecke wrote: > But we do; we're getting the index/tag/smid from the high-priority list, > which is separated from the normal SCSI I/O tag space. > (which reminds me; there's another cleanup patch to be had in > _ctl_do_mpt_command(), but that's be

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Hannes Reinecke
On 02/07/2017 04:34 PM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 03:38:51PM +0100, Hannes Reinecke wrote: >> The SCSI passthrough commands pass in pre-formatted SGLs, so the driver >> just has to map them. >> If we were converting that we first have to re-format the >> (driver-specific) S

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Christoph Hellwig
On Tue, Feb 07, 2017 at 03:38:51PM +0100, Hannes Reinecke wrote: > The SCSI passthrough commands pass in pre-formatted SGLs, so the driver > just has to map them. > If we were converting that we first have to re-format the > (driver-specific) SGLs into linux sg lists, only to have them converted >

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Hannes Reinecke
On 02/07/2017 02:19 PM, Christoph Hellwig wrote: > Patch 1-7 look fine to me with minor fixups, and I'd love to see > them go into 4.11. The last one looks really questionable, > and 8 and 9 will need some work so that the MPT passthrough ioctls > either go away or make use of struct request and t

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-07 Thread Christoph Hellwig
Patch 1-7 look fine to me with minor fixups, and I'd love to see them go into 4.11. The last one looks really questionable, and 8 and 9 will need some work so that the MPT passthrough ioctls either go away or make use of struct request and the block layer and SCSI infrastructure.

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
; PDL-MPT-FUSIONLINUX; Sreekanth Reddy Subject: Re: [PATCH 00/10] mpt3sas: full mq support On 01/31/2017 06:54 PM, Kashyap Desai wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, January 31, 2017 4:47 PM To: Christoph Hellwig Cc: Martin K. Petersen; James

RE: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Kashyap Desai
USIONLINUX; Sreekanth Reddy > Subject: Re: [PATCH 00/10] mpt3sas: full mq support > > On 01/31/2017 06:54 PM, Kashyap Desai wrote: > >> -Original Message- > >> From: Hannes Reinecke [mailto:h...@suse.de] > >> Sent: Tuesday, January 31, 2017 4:47 PM >

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
@broadcom.com Subject: Re: [PATCH 00/10] mpt3sas: full mq support On 01/31/2017 11:02 AM, Christoph Hellwig wrote: On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: Hi all, this is a patchset to enable full multiqueue support for the mpt3sas driver. While the HBA only has a

RE: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Kashyap Desai
.com > Subject: Re: [PATCH 00/10] mpt3sas: full mq support > > On 01/31/2017 11:02 AM, Christoph Hellwig wrote: > > On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: > >> Hi all, > >> > >> this is a patchset to enable full multiqueue support fo

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 11:02 AM, Christoph Hellwig wrote: > On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: >> Hi all, >> >> this is a patchset to enable full multiqueue support for the mpt3sas driver. >> While the HBA only has a single mailbox register for submitting commands, >> it does h

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Christoph Hellwig
On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: > Hi all, > > this is a patchset to enable full multiqueue support for the mpt3sas driver. > While the HBA only has a single mailbox register for submitting commands, > it does have individual receive queues per MSI-X interrupt and a