RE: [PATCH net-next 0/4] r8152: firmware support

2014-08-25 Thread Hayes Wang
From: David Miller [mailto:da...@davemloft.net] [...] That still doesn't convince me. The functions I see you removing are just programming a set of registers in some way. That is to clear the break point of the firmware. If a firmware exists, you should clear it before updating a new one.

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 25 Aug 2014 06:43:02 + Except the step 3, 4, 6 and 7, the other steps depend on the context of the firmware. That is, for different firmware, some actions would be removed or added, and some settings would be different. Especially the step

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Clemens Ladisch
Daniel Mack wrote: a) Linux snd-usb-audio currently pre-calculates the estimated packet sizes to expect from a USB device, and will only receive packets that have the expected size or are smaller. snd-usb-audio allows packets to be 25 % larger. This can be worked around by setting the

Re: [PATCH 4/6] phy: remove the old lookup method

2014-08-25 Thread Vivek Gautam
Hi Heikki, On Thu, Aug 21, 2014 at 5:03 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: The users of the old method are now converted to the new one. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Tested-by: Vivek Gautam gautam.vi...@samsung.com ---

[PATCH net-next] r8152: check code with checkpatch.pl

2014-08-25 Thread Hayes Wang
626: CHECK: Alignment should match open parenthesis 646: CHECK: Alignment should match open parenthesis 655: CHECK: Alignment should match open parenthesis 695: CHECK: Alignment should match open parenthesis 729: CHECK: Alignment should match open parenthesis 739: CHECK: Alignment should

Re: [PATCH v5 1/3] usb: gadget: f_fs: fix the redundant ep files problem

2014-08-25 Thread Robert Baldyga
On 08/24/2014 04:14 PM, Michal Nazarewicz wrote: On Thu, Aug 21 2014, Robert Baldyga r.bald...@samsung.com wrote: Up to now, when endpoint addresses in descriptors were non-consecutive, there were created redundant files, which could cause problems in kernel, when user tryed to read/write to

Re: [PATCH 4/6] phy: remove the old lookup method

2014-08-25 Thread Heikki Krogerus
On Mon, Aug 25, 2014 at 01:11:34PM +0530, Vivek Gautam wrote: Please squash the attached diff which removes the 'init_data' field from some of the other instances of devm_phy_create() in few other drivers. This should prevent any build errors that i could see with multi_v7_defconfig. OK, I'll

Re: [PATCH 4/6] phy: remove the old lookup method

2014-08-25 Thread Vivek Gautam
On Mon, Aug 25, 2014 at 1:47 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: On Mon, Aug 25, 2014 at 01:11:34PM +0530, Vivek Gautam wrote: Please squash the attached diff which removes the 'init_data' field from some of the other instances of devm_phy_create() in few other drivers.

[PATCH v3] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard

2014-08-25 Thread Rasmus Villemoes
Clearly this was meant to be an include guard, but a trailing underscore was missing. It has been this way since the file was introduced in 0fe6f1d1 (usb: udc: add Faraday fusb300 driver). Fixes: 0fe6f1d1 (usb: udc: add Faraday fusb300 driver) Cc: sta...@vger.kernel.org Signed-off-by: Rasmus

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Daniel Mack
Hi Clemens, On 08/25/2014 09:15 AM, Clemens Ladisch wrote: Daniel Mack wrote: a) Linux snd-usb-audio currently pre-calculates the estimated packet sizes to expect from a USB device, and will only receive packets that have the expected size or are smaller. snd-usb-audio allows packets to be

Re: [PATCH RESEND] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-25 Thread Ivan T. Ivanov
On Tue, 2014-08-19 at 14:06 -0500, Felipe Balbi wrote: On Fri, Aug 15, 2014 at 12:21:19PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T.

RE: [PATCH v2 02/16] libusbg: Add guards for libconfig version

2014-08-25 Thread Krzysztof Opasiak
-Original Message- From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] Sent: Friday, August 22, 2014 2:11 PM To: Krzysztof Opasiak; matt.por...@linaro.org; linux- u...@vger.kernel.org Cc: s.wa...@samsung.com; k.lewando...@samsung.com; andrze...@samsung.com;

[PATCH v3 12/15] libusbg: Add import gadget functionality

2014-08-25 Thread Krzysztof Opasiak
Whole gadget can be exported to file using usbg_export_gadget(). This commit adds complementary API function usbg_import_gadget() which allows to import whole gadget (including attrs, strings, configs, functions and bindings) from file to configfs. Signed-off-by: Krzysztof Opasiak

[PATCH v3 08/15] libusbg: Allow to store error information in usbg_gadget

2014-08-25 Thread Krzysztof Opasiak
If error occurred during parsing user should have an oportunity to get details about place and type of error. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/usbg.c |8 1 file changed, 8 insertions(+) diff --git a/src/usbg.c b/src/usbg.c index cd526e1..a87a6b1 100644

[PATCH v3 06/15] libusbg: examples: Add sample application to export gadget

2014-08-25 Thread Krzysztof Opasiak
Add sample C code which shows how to use new functionality of libusbg - gadget export. This program allows to export chosen gadget from configfs to a file. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- examples/Makefile.am |3 +- examples/gadget-export.c | 81

[PATCH v3 13/15] libusbg: Add functions to get import error text and line

2014-08-25 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 43 +++ src/usbg.c | 48 2 files changed, 91 insertions(+) diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h

[PATCH v3 07/15] libusbg: Add errors which may happen during parsing

2014-08-25 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h |4 src/usbg.c | 24 2 files changed, 28 insertions(+) diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h index 3a66ae3..3d3cba0 100644 --- a/include/usbg/usbg.h +++

[PATCH v3 11/15] libusbg: Allow to store error information in usbg_state

2014-08-25 Thread Krzysztof Opasiak
If error occurred during parsing user should have an opportunity to get details about place and type of error. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/usbg.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/usbg.c b/src/usbg.c index 9d64171..4178194 100644

[PATCH v3 02/15] libusbg: Add label field to usbg_function structure

2014-08-25 Thread Krzysztof Opasiak
Add some field where additional label for function can be stored. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/usbg.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index b1b5f44..55edd9e 100644 --- a/src/usbg.c +++

[PATCH v3 01/15] libusbg: Add dependency to libconfig

2014-08-25 Thread Krzysztof Opasiak
This library is used to import and export gadget/function/config to and from file. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- configure.ac|1 + libusbg.pc.in |2 +- src/Makefile.am |4 +++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v3 00/15] Add import from/export to file functionality

2014-08-25 Thread Krzysztof Opasiak
Dear Matt, This quite big series adds new part of libusbg API which allows to import/export gadget/function/configuration from/to file. Motivation: Libusbg allows to create a binary file which set up custom gadget. This is useful but if we have to create custom binary for each gadget we wast a

[PATCH v3 05/15] libusbg: Add export gadget functionality

2014-08-25 Thread Krzysztof Opasiak
Whole gadget setting process take a lot of simple commands (or lines of code). Those shell commands may take a while or require dedicated script and hard-coding gadget configuration. To avoid such situation add to library ability to export a whole gadget into file. Signed-off-by: Krzysztof

[PATCH v3 03/15] libusbg: Add export function functionality

2014-08-25 Thread Krzysztof Opasiak
Function settings may be complicated and their configuration may take a long while. To save time it would be convenient to allow for storing function settings in a file. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 11 src/usbg.c | 156

[PATCH v3 04/15] libusbg: Add export config functionality

2014-08-25 Thread Krzysztof Opasiak
Configuration may have several functions if we add strings and some attributes it gives a few shell commands to set it up. To avoid this add export cofiguration which allows to store usb configuration in a file. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h |

[PATCH v3 15/15] libusbg: doc: Add document about gadget schemes

2014-08-25 Thread Krzysztof Opasiak
Add document which clarify reasons of implementing gadget schemes and also describes syntax of such files. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- doc/gadget_schemes.txt | 301 1 file changed, 301 insertions(+) create mode

[PATCH v3 09/15] libusbg: Add import function functionality

2014-08-25 Thread Krzysztof Opasiak
Functions can be exported to file using usbg_export_function(). This commit adds complementary API function usbg_import_function() which allows to import function from file to configfs. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 13 src/usbg.c

[PATCH v3 14/15] libusbg: examples: Add gadget-import sample app

2014-08-25 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- examples/Makefile.am |3 +- examples/gadget-import.c | 79 ++ src/usbg.c |6 ++-- 3 files changed, 84 insertions(+), 4 deletions(-) create mode 100644

[PATCH v3 10/15] libusbg: Add import config functionality

2014-08-25 Thread Krzysztof Opasiak
Configurations can be exported to file using usbg_export_config(). This commit adds complementary API function usbg_import_config() which allows to import configuration (with attrs, strings and bindings) from file to chosen gadget. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com ---

[PATCH] usb: gadget: composite: dequeue cdev-req before free its buffer

2014-08-25 Thread Li Jun
As Felipe suggested, dequeue the cdev-req before free its buffer. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Li Jun b47...@freescale.com diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 6935a82..4514e73 100644 --- a/drivers/usb/gadget/composite.c +++

[PATCH v6 1/3] usb: gadget: f_fs: fix the redundant ep files problem

2014-08-25 Thread Robert Baldyga
Up to now, when endpoint addresses in descriptors were non-consecutive, there were created redundant files, which could cause problems in kernel, when user tried to read/write to them. It was result of fact that maximum endpoint address was taken as total number of endpoints in funciton. This

[PATCH v6 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-25 Thread Robert Baldyga
This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga r.bald...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/function/f_fs.c | 23

[PATCH v6 0/3] usb: gadget: f_fs: userspace API fixes and improvements

2014-08-25 Thread Robert Baldyga
This patchset contains changes in FunctionFS making it easier and safer to use. It fixes bug in endpoint files handling code, adds new ioctl allowing to obtain endpoint descriptor, and introduces virtual address mapping which allows to separate endpoint address space in function from physical

[PATCH v6 3/3] usb: gadget: f_fs: virtual endpoint address mapping

2014-08-25 Thread Robert Baldyga
This patch introduces virtual endpoint address mapping. It separates function logic form physical endpoint addresses making it more hardware independent. Following modifications changes user space API, so to enable them user have to switch on the FUNCTIONFS_VIRTUAL_ADDR flag in descriptors.

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack dan...@zonque.org wrote: Hi Clemens, On 08/25/2014 09:15 AM, Clemens Ladisch wrote: Daniel Mack wrote: a) Linux snd-usb-audio currently pre-calculates the estimated packet sizes to expect from a USB device, and will only receive packets that have

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Daniel Mack
On 08/25/2014 11:23 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack dan...@zonque.org wrote: The easiest is probably really to just calculate correct packet sizes and stick to them. After all, the actual clock is really arbitrary, we just have to pick something that is in

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 2:57 PM, Daniel Mack dan...@zonque.org wrote: On 08/25/2014 11:23 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack dan...@zonque.org wrote: The easiest is probably really to just calculate correct packet sizes and stick to them. After all, the actual

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Daniel Mack
On 08/25/2014 11:30 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:57 PM, Daniel Mack dan...@zonque.org wrote: On 08/25/2014 11:23 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack dan...@zonque.org wrote: The easiest is probably really to just calculate correct packet sizes

[PATCH] xhci: Disable streams on Via XHCI with device-id 0x3432

2014-08-25 Thread Hans de Goede
This is a bit bigger hammer then I would like to use for this, but for now it will have to make do. I'm working on getting my hands on one of these so that I can try to get streams to work (with a quirk flag if necessary) and then we can re-enable them. For now this at least makes uas capable

Re: [PATCH 1/1] HID: usbhid: add usb_clear_halt determination for next hid_start_in

2014-08-25 Thread Oliver Neukum
On Fri, 2014-08-22 at 14:23 -0400, Alan Stern wrote: On Sat, 23 Aug 2014, vichy wrote: from your patch, I have some questions: a. in Alan's version, if both HID_CLEAR_HALT and HID_RESET_PENDING are set, hid_reset will both clear ep halt and reset devcie. But in original one, even

Re: [PATCHv2 10/13] usb: dwc2: initialize the spin_lock for both host and gadget

2014-08-25 Thread Dinh Nguyen
On 8/22/14, 3:57 PM, Felipe Balbi wrote: Hi, On Fri, Aug 22, 2014 at 08:52:23PM +, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Wednesday, July 30, 2014 8:21 AM Move spin_lock_init to common location for both host and gadget. Signed-off-by:

AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
Hi all, I'm investigating an issue with a HDD enclosure based on AS2105 chip. A 4TB GPT partition is not considered valid because reported last LBA reported by the enclosure makes kernel think that secondary GPT is outside disk plate. I found this patch [1] forcing it to use READ_CAPACITY_16

[PATCH 1/2] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-25 Thread Ivan T. Ivanov
PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Acked-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/ci_hdrc_msm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 2/2] usb: chipidea: msm: Initialize PHY on reset event

2014-08-25 Thread Ivan T. Ivanov
Initialize USB PHY after every Link controller reset Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 30bdd51..4935ac3 100644

Re: [PATCH 1/1] HID: usbhid: add usb_clear_halt determination for next hid_start_in

2014-08-25 Thread vichy
hi Alan: usb_unbind_and_rebind_marked_interfaces is called if config parameter is not null, it seems no matter post_reset routine fail or not. Yes, that's right. I should have said: Because the post_reset routine failed, usb_unbind_and_rebind_marked_interfaces indirectly calls

Re: [PATCH 1/1] HID: usbhid: add usb_clear_halt determination for next hid_start_in

2014-08-25 Thread vichy
hi Oliver: 2014-08-25 18:21 GMT+08:00 Oliver Neukum oneu...@suse.de: On Fri, 2014-08-22 at 14:23 -0400, Alan Stern wrote: On Sat, 23 Aug 2014, vichy wrote: from your patch, I have some questions: a. in Alan's version, if both HID_CLEAR_HALT and HID_RESET_PENDING are set, hid_reset will

Re: some question about unbind and rebind usb interfaces

2014-08-25 Thread vichy
hi Alan: After usb_reset_device, the whole enumeration will run again, No, only part of the enumeration. The kernel does read the device and config descriptors again. But if the reset succeeded, the kernel doesn't carry out any of the other parts of enumeration. here the kernel you mean

Re: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Oliver Neukum
On Mon, 2014-08-25 at 10:58 +, Alfredo Dal Ava Junior wrote: - 1TB and 2TB: READ_CAPACITY_10 returns correct size value - 3TB and 4TB: READ_CAPACITY_10 returns size in a 2TB modulus If we fix capacity size by reporting (READ_CAPACITY_10 + MODULO_2TB), the result will be invalid when

Re: [PATCH 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 3:07 PM, Daniel Mack dan...@zonque.org wrote: On 08/25/2014 11:30 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:57 PM, Daniel Mack dan...@zonque.org wrote: On 08/25/2014 11:23 AM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack dan...@zonque.org wrote:

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-25 Thread Michael Grzeschik
Hi Laurent, On Wed, Aug 20, 2014 at 07:05:30PM +0200, Laurent Pinchart wrote: Hi Hans and Michael, On Wednesday 20 August 2014 02:06:54 Hans Verkuil wrote: On 08/19/2014 05:01 PM, Laurent Pinchart wrote: Hi Michael, Thank you for the patch. (CC'ing Hans Verkuil and the

Re: [PATCH 1/1] HID: usbhid: add usb_clear_halt determination for next hid_start_in

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, vichy wrote: hi Oliver: 2014-08-25 18:21 GMT+08:00 Oliver Neukum oneu...@suse.de: On Fri, 2014-08-22 at 14:23 -0400, Alan Stern wrote: On Sat, 23 Aug 2014, vichy wrote: from your patch, I have some questions: a. in Alan's version, if both HID_CLEAR_HALT and

Re: some question about unbind and rebind usb interfaces

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, vichy wrote: hi Alan: After usb_reset_device, the whole enumeration will run again, No, only part of the enumeration. The kernel does read the device and config descriptors again. But if the reset succeeded, the kernel doesn't carry out any of the other parts of

Re: [PATCH 1/1] HID: usbhid: add usb_clear_halt determination for next hid_start_in

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, vichy wrote: hi Alan: usb_unbind_and_rebind_marked_interfaces is called if config parameter is not null, it seems no matter post_reset routine fail or not. Yes, that's right. I should have said: Because the post_reset routine failed,

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread Alan Stern
On Sun, 24 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 01:29:32PM -0400, Alan Stern wrote: Other than this, I'm fine with the code ... you can add the acked by from me when we resolve the above question. Okay. It's true that this issue is only tangentially related to

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-25 Thread Laurent Pinchart
Hi Michael, On Monday 25 August 2014 15:59:57 Michael Grzeschik wrote: On Wed, Aug 20, 2014 at 07:05:30PM +0200, Laurent Pinchart wrote: On Wednesday 20 August 2014 02:06:54 Hans Verkuil wrote: On 08/19/2014 05:01 PM, Laurent Pinchart wrote: Hi Michael, Thank you for the patch.

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-25 Thread Philipp Zabel
Hi Laurent, Am Montag, den 25.08.2014, 16:48 +0200 schrieb Laurent Pinchart: [...] Format descriptions are currently duplicated in every driver, causing higher memory usage and different descriptions for the same format depending on the driver. Hans, should we try to fix this ?

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Peter Chen wrote: Hi Felipe Alan, It is the follow-up for: http://www.spinics.net/lists/linux-usb/msg112193.html This patchset adds reset API at usb_gadget_driver, the UDC driver can call it at bus_reset handler instead of calling disconnect. The benefits of this

[PATCH 2/2] USB: quirks: enable device-qualifier quirk for Elan Touchscreen

2014-08-25 Thread Johan Hovold
Enable device-qualifier quirk for Elan Touchscreen, which often fails to handle requests for the device_descriptor. Note that the device sometimes do respond properly with a Request Error (three times as USB core retries), but usually fails to respond at all. When this happens any further

[PATCH 1/2] USB: core: add device-qualifier quirk

2014-08-25 Thread Johan Hovold
Add new quirk for devices that cannot handle requests for the device_qualifier descriptor. A USB-2.0 compliant device must respond to requests for the device_qualifier descriptor (even if it's with a request error), but at least one device is known to misbehave after such a request.

[PATCH 0/2] USB: core: add add device-qualifier quirk

2014-08-25 Thread Johan Hovold
This is quirk is indeed needed to get the Elan Touchscreen found on some Samsung laptops to enumerate reliably. I'm still looking into the disconnects I've been experiencing. For some reason I cannot reproduce the repeated disconnects any longer, although the device still disconnects at least

[PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by pre-calculating the size of

[PATCH v2 2/4] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-25 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), uac2-pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 29

[PATCH v2 1/4] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-25 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 39

[PATCH v2 4/4] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-25 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). Now that we have smaller and dynamically

[PATCH v2 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-25 Thread Daniel Mack
Hi, this is v2 of the f_uac2 timing fixup series. Changes from v1: * drop UAC_EP_CS_ATTR_FILL_MAX approach and rather size the packets correctly * add a patch to fix buffer wrap problems in the ALSA buffer logic, which wasn't needed before The first two

BUG: xhci_hcd: Crashes system when reseting endpoint

2014-08-25 Thread Ricardo Ribalda Delgado
Hello When I connect a usb gadget mass storage to my laptop the whole system crashes. It seems that the bug happens when the gadget/host initialize a reset. I lose all control to the computer, and the only way to recover control is rebooting it via powerbutton. Kernel that does not work: 3.14

E-mail Account Warning

2014-08-25 Thread From Administrator
E-mail Account Warning !!! This mail is from Administrator; we wish to bring to your notice the Condition of your email account. We have just noticed that you have exceeded your email Database limit of 500 MB quota and your email IP is causing conflict because it is been accessed in different

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream

Re: [PATCH 1/4] usbip: move usbip userspace code out of staging

2014-08-25 Thread Greg KH
On Sun, Aug 24, 2014 at 05:05:39PM -0700, Valentina Manea wrote: On Tue, Aug 19, 2014 at 9:30 PM, Valentina Manea valentina.mane...@gmail.com wrote: At this point, USB/IP userspace code is fully functional and can be moved out of staging. Signed-off-by: Valentina Manea

Re: [PATCH 4/4] MAINTAINERS: Add an entry for USB/IP driver

2014-08-25 Thread gregkh
On Wed, Aug 20, 2014 at 12:44:45PM +0530, sanjeev sharma wrote: Hello Valentina, I have started looking into USB IP Project and this look's very interesting and Do we have anything left in this Project apart from reviewing user-land protocol ? What do you mean by this? Does the code not

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 10:52 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as

Re: [PATCH 0/4] *** SUBJECT HERE ***

2014-08-25 Thread Greg KH
On Wed, Aug 20, 2014 at 07:30:58AM +0300, Valentina Manea wrote: After migrating userspace code to libudev, converting usbip-host to a device driver and various bug fixes and enhancements, USB/IP is fully functional and can be moved out of staging. This patch series moves it as following: *

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Daniel Mack
Hi, On 08/25/2014 07:22 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is

Re: [PATCH] xhci: Disable streams on Via XHCI with device-id 0x3432

2014-08-25 Thread Greg Kroah-Hartman
On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote: This is a bit bigger hammer then I would like to use for this, but for now it will have to make do. I'm working on getting my hands on one of these so that I can try to get streams to work (with a quirk flag if necessary) and then

Re: [PATCH] Including XHCI_TRUST_TX_LENGTH for Renesas uPD720202 USB 3.0 chip.

2014-08-25 Thread Greg KH
On Fri, Aug 22, 2014 at 12:33:10PM -0300, Rodrigo Severo wrote: Renesas uPD720202 USB 3.0 chip needs XHCI_TRUST_TX_LENGTH quirk workaround as per below logs produced when using a Diammond video capture dongle: Aug 21 18:07:33 [kernel] handle_tx_event: 67 callbacks suppressed Aug 21

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Daniel Mack
Hi, On 08/25/2014 07:43 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 10:52 PM, Jassi Brar jassisinghb...@gmail.com wrote: I believe you want to do the following in afunc_set_alt(). - req-length = prm-max_psize; + req-length = uac2-c_pktsize; Sorry I intended... - prm-max_psize

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-25 Thread Bryan Wu
On Sat, Aug 23, 2014 at 2:52 AM, Michal Sojka so...@merica.cz wrote: Hi Bryan, thanks for the review. See some comments below. On Sat, Aug 23 2014, Bryan Wu wrote: On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka so...@merica.cz wrote: With this patch, USB host activity can be signaled by

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Jassi Brar
On Mon, Aug 25, 2014 at 11:40 PM, Daniel Mack dan...@zonque.org wrote: Hi, On 08/25/2014 07:22 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel, messages sent by the controller can be divided into two groups: those intended for

Re: [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-08-25 Thread Stephen Warren
On 08/25/2014 12:48 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. diff --git

Re: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: Add new bindings used for USB support by the Tegra XUSB pad controller. This includes additional PHY types, USB-specific pinconfig properties, etc. I'll mainly defer to Thierry for this patch, since he's the expert on this HW module. diff

Re: [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages

Re: [PATCH v2 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: Add device-tree binding documentation for the xHCI controller present on Tegra124 and later SoCs. diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt

Re: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 18:48 +, Alfredo Dal Ava Junior wrote: On Mon, 25 Aug 2014, Alan Stern wrote: Don't forget that lots of disks go crazy if you try to read from a nonexistent block, that is, one beyond the end of the disk. IMO, this bug cannot be worked around in any

Re: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: On Mon, 25 Aug 2014, Alan Stern wrote: Don't forget that lots of disks go crazy if you try to read from a nonexistent block, that is, one beyond the end of the disk. IMO, this bug cannot be worked around in any reasonable manner.

Re: [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: Add support for the on-chip xHCI host controller present on Tegra SoCs. The driver is currently very basic: it loads the controller with its firmware, starts the controller, and is able to service messages sent by the controller's firmware. The

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common? sdev-scsi_level doesn't get set when sdev is allocated, so it initially contains 0, so the LUN

RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 15 Aug 2014 James Bottomley wrote: So how did the partition get on there at the correct size in the first place? Even under windows partition managers believe the disk size they get from the system if the disk is blank. The HDD can be partitioned outside the enclosure, when connected

Re: [PATCH net-next] r8152: check code with checkpatch.pl

2014-08-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 25 Aug 2014 15:53:00 +0800 626: CHECK: Alignment should match open parenthesis 646: CHECK: Alignment should match open parenthesis 655: CHECK: Alignment should match open parenthesis 695: CHECK: Alignment should match open parenthesis

Re: [PATCH v2 1/1] usb: ehci: using wIndex + 1 for hub port

2014-08-25 Thread Greg Kroah-Hartman
On Mon, Aug 25, 2014 at 01:29:54PM +0800, Peter Chen wrote: On Tue, Aug 5, 2014 at 8:28 AM, Peter Chen peter.c...@freescale.com wrote: The roothub's index per controller is from 0, but the hub port index per hub is from 1, this patch fixes can't find device at roohub problem for connecting

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-25 Thread Daniel Mack
On 08/25/2014 09:00 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 11:40 PM, Daniel Mack dan...@zonque.org wrote: Sure, but rates across devices will never match, so it doesn't matter really. Two clocks on two devices will always drift, even if they're totally accurate by their own means. You

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common? sdev-scsi_level doesn't get set when sdev is

Fwd: [PATCH] Including XHCI_TRUST_TX_LENGTH for Renesas uPD720202 USB 3.0 chip.

2014-08-25 Thread Rodrigo Severo
On Mon, Aug 25, 2014 at 3:17 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Aug 22, 2014 at 12:33:10PM -0300, Rodrigo Severo wrote: Renesas uPD720202 USB 3.0 chip needs XHCI_TRUST_TX_LENGTH quirk workaround as per below logs produced when using a Diammond video capture dongle:

RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 25 Aug 2014 Alan Stern wrote: On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: That's right. I don't know why Windows behaves that way. Please look this output from diskpart (Windows): DISKPART list partition Partition ### Type Size Offset -

Re: [PATCH] Including XHCI_TRUST_TX_LENGTH for Renesas uPD720202 USB 3.0 chip.

2014-08-25 Thread Greg KH
On Mon, Aug 25, 2014 at 05:10:55PM -0300, Rodrigo Severo wrote: On Mon, Aug 25, 2014 at 3:17 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Aug 22, 2014 at 12:33:10PM -0300, Rodrigo Severo wrote: Renesas uPD720202 USB 3.0 chip needs XHCI_TRUST_TX_LENGTH quirk workaround

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage could set capacity as UNDETERMINED/ Zero (or keep using the

RES: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 25 Aug 2014 Alan Stern wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for the READ CAPACITY(10) to report a value less than 2 TB. Really

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Alan Stern wrote: On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common?

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Oliver Neukum
On Mon, 2014-08-25 at 16:21 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 17:19 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Alan Stern wrote: On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work

RE: [PATCHv2 10/13] usb: dwc2: initialize the spin_lock for both host and gadget

2014-08-25 Thread Paul Zimmerman
From: Dinh Nguyen [mailto:dinh.li...@gmail.com] Sent: Monday, August 25, 2014 3:58 AM On 8/22/14, 3:57 PM, Felipe Balbi wrote: Hi, On Fri, Aug 22, 2014 at 08:52:23PM +, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Wednesday, July 30, 2014

  1   2   >