On Fri, Nov 16, 2018 at 10:38:18AM -0500, Alan Stern wrote:
> On Fri, 16 Nov 2018, Ben Dooks wrote:
>
> > On 14/11/18 18:47, Alan Stern wrote:
> > > On Wed, 14 Nov 2018, Ben Dooks wrote:
> > >
> > >> From: Ben Dooks
> > >>
> > >
The tasklet initialisation would be better done by tasklet_init()
instead of assuming all the fields are in an ok state by default.
This does not fix any actual know bug.
Signed-off-by: Ben Dooks
---
drivers/net/usb/cdc_ncm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
] http://lxr.free-electrons.com/source/drivers/reset/core.c#L102
If we didn't have the shared reset, we'd have one of node per phy
and not have to have two sub-nodes... I don't think any other bits
of the PHY framework are shared.
--
Ben Dooks http://www.codethink
On 08/09/16 21:42, Kevin Hilman wrote:
Ben Dooks <ben.do...@codethink.co.uk> writes:
On 08/09/16 20:52, Martin Blumenstingl wrote:
On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman <khil...@baylibre.com> wrote:
+ phy = devm_phy_create(>dev, NULL, _meson_usb2_ops);
+
meson_usb2_power_on() you could do:
pm_runtime_get_sync(pdev);
and in phy_meson_usb2_power_off
pm_runtime_put(pdev);
https://www.kernel.org/doc/Documentation/power/runtime_pm.txt
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Pro
be the best place to handle >1
device with shared items such as reset.
The version I wrote, I simply enabled the clocks and reset the device
when probed to work around the shared reset.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
On 26/06/16 19:48, Greg Kroah-Hartman wrote:
> On Fri, Jun 17, 2016 at 04:11:55PM +0100, Ben Dooks wrote:
>> Make at91_dt_syscon_sfr() static as it is not used or declared
>> outside the drivers/usb/host/ohci-at91.c file.
>>
>> drivers/usb/host/ohci-at9
The usbhs_write32 function is not used outside of the rcar3.c
file, so fix the following sparse warning by making it static:
drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not
declared. Should it be static?
Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>
Make at91_dt_syscon_sfr() static as it is not used or declared
outside the drivers/usb/host/ohci-at91.c file.
drivers/usb/host/ohci-at91.c:144:15: warning: symbol 'at91_dt_syscon_sfr' was
not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>
---
Cc: Alan
2016-02-19 34 {
>> 69bec725 Peter Chen 2016-02-19 35 struct device_node *node;
>>
>>
>
> I think what we want here is to make the compilation of of.o conditional on
> CONFIG_OF, so we get only one of the two definitions.
Ah, so make the of.o conditional, and a
t;>
>>>
>>
>> I think what we want here is to make the compilation of of.o conditional on
>> CONFIG_OF, so we get only one of the two definitions.
>>
>> Arnd
>
> Thanks, Arnd. It is the correct solution, I will send patch soon.
Aha, I didn't th
it be static?
Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>
---
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Philipp Zabel <p.za...@pengutronix.de>
Cc: Alan Stern <st...@rowland.harvard.edu>
Cc: Peter Chen <peter.
On 22/05/15 14:50, Felipe Balbi wrote:
> Hi,
>
> On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote:
>> I am trying to get the full-speed USB host working on an custom
>> AM3517 device with the 3.18.12 kernel. The hardware works (a
>> 2.6.37 kernel has been use
if this is
if (quirks CLEAR_HALT_CONDITIONS) {
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
On 22/05/15 23:13, Ben Dooks wrote:
On 22/05/15 16:50, Felipe Balbi wrote:
Hi,
On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote:
I am trying to get the full-speed USB host working on an custom
AM3517 device with the 3.18.12 kernel. The hardware works (a
2.6.37 kernel has been used
[ 77.849913] usb usb1: SerialNumber: 48064400.ohci
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 22/05/15 16:50, Felipe Balbi wrote:
Hi,
On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote:
I am trying to get the full-speed USB host working on an custom
AM3517 device with the 3.18.12 kernel. The hardware works (a
2.6.37 kernel
,w} defines in a follow-up patch.
I'm fine with this too. Is this targetted at v4.2 ?
Yes, although we may move it to the soc specific include directories
to avoid adding more to linux/
I will be sorting this out next week.
- --
Ben Dooks http
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 28/04/15 17:30, Felipe Balbi wrote:
Hi,
On Tue, Apr 28, 2015 at 04:40:14PM +0100, Ben Dooks wrote:
/* Register access macros */ -#ifdef CONFIG_AVR32 -#define
usba_io_readl __raw_readl -#define usba_io_writel
__raw_writel -#define
Use linux/atmel_io.h to provide IO accessors which work on both
AVR32 and ARM for on-chip peripherals.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
--
CC: Nicolas Ferre nicolas.fe...@atmel.com
CC: Felipe Balbi ba...@ti.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
CC: linux-usb
Change r8a66597-udc to use devm functions and cleanup the result.
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Update driver to use devm_kzalloc() to make tracking of resources
easier. Also remove the exit point via cleanup as there's no
cleanup necessary from this point now.
As a note, also removes the error print as the allocation calls
produce errors if they do not return memory.
Signed-off-by: Ben
With the updates for devm, the cleanup path no longer needs to
check for NULL device state, so remove it and return directly
if the irq resource missing
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 10 +++---
1 file changed, 3 insertions(+), 7
Change the sudmac register handling in the devm_ioremap_resource
to use the devm variant.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597
Use the devm_request_irq() call to get the interrupt for the
device and have it automatically free on exit.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget
With the devm additions, the clean_up and clean_up3 are now
not needed or used. Change clean_up3 and make everything use
clean_up2 and just remove clean_up.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 5 ++---
1 file changed, 2 insertions(+), 3
Change to using the devm_clk_get() to get the clock and
have it automatically freed on exit.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
Remove usages of pdev-dev in the driver probe function
with just dev to make the references to it easier to
write. Convert all the current users of it to use it.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 18 +-
1 file changed, 9
---
drivers/usb/gadget/r8a66597-udc.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597-udc.c
index aff0a67..7f3af74 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++
looks like something that the PHY layer should
do. Why don't you write a PHY driver and teach xhci-core about
PHYs ? Then, more people would benefit.
The rcar phy code should already do this, so I agree.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
controller
that select between multiply PHY.
No, it's not the case.
There is an interesting case, the USB3 shares a PHY with a SATA
and the PCIE and SATA also share a PHY on the R8A7790.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
On 10/04/14 12:14, David Laight wrote:
From: Ben Dooks
On 10/04/14 11:49, Sergei Shtylyov wrote:
On 10-04-2014 13:20, David Laight wrote:
It doesn't do any pin muxing. It switches SoC internal USB
signals between
USB controllers. The pins remain the same.
Doesn't something like
On 04/04/14 18:09, Bjorn Helgaas wrote:
On Thu, Mar 06, 2014 at 06:01:19PM +, Ben Dooks wrote:
Add OF match table for pci-rcar-gen2 driver for device tree support.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
I'm not sure what the status of this is. I saw comments about a missing
On 30/03/14 20:10, Sergei Shtylyov wrote:
Hello.
On 03/06/2014 09:21 PM, Ben Dooks wrote:
Add OF match table for pci-rcar-gen2 driver for device tree support.
[...]
diff --git a/drivers/pci/host/pci-rcar-gen2.c
b/drivers/pci/host/pci-rcar-gen2.c
index fd3e3ab..1216784 100644
--- a/drivers
On 30/03/14 20:26, Sergei Shtylyov wrote:
Hello.
On 03/30/2014 11:21 PM, Ben Dooks wrote:
Add OF match table for pci-rcar-gen2 driver for device tree support.
[...]
diff --git a/drivers/pci/host/pci-rcar-gen2.c
b/drivers/pci/host/pci-rcar-gen2.c
index fd3e3ab..1216784 100644
--- a/drivers
On 30/03/14 20:29, Sergei Shtylyov wrote:
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
Add the necessary links to add the USB phy nodes to the PCI devices
that are behind the bridges specified.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
arch/arm/boot/dts/r8a7790-lager.dts
On 30/03/14 20:28, Sergei Shtylyov wrote:
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
Enable the usbphy node so that the phy driver is available.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: linux...@vger.kernel.org
Cc
On 07/03/14 05:36, Magnus Damm wrote:
Hi Ben,
On Fri, Mar 7, 2014 at 3:01 AM, Ben Dooks ben.do...@codethink.co.uk wrote:
This is a new series covering enabling the RCar series of SoCs USB
with device-tree based booting. It has been tested on the R8A7790
Lager board.
Improvements from
On 07/03/14 17:30, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 05:30 PM, Ben Dooks wrote:
This is a new series covering enabling the RCar series of SoCs USB
with device-tree based booting. It has been tested on the R8A7790
Lager board.
Improvements from the previous series include
This is a new series covering enabling the RCar series of SoCs USB
with device-tree based booting. It has been tested on the R8A7790
Lager board.
Improvements from the previous series include:
- mapping usb to the relevant phy by dt
- better use of existing pci of
Enable pci1 and pci2 nodes for USB controllers attached to the AHBPCI
bridge devices. Node pci0 is added for the moment, but not enabled as it
could be switched to usb-gadget mode later.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Fixes from v2:
- fix missed of_match_ptr()
- fix names of channel selection booleans
Add node for USB PHY driver to the base R8A7790 device tree include file.
It is up to the board file to enable and configure it as necessary.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: devicet...@vger.kernel.org
Cc: Magnus Damm
If the PHY is specified by usb-phy handle in the device tree, then
usb_get_phy_dev() should use the device tree specified PHY. This
fixes the issue where device-tree booted Renesas SoCs fail to find
the PHY for the USB controllers.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
Cc: linux
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
The probe() method has the 'dev' local variable declared and used but strangely
not in all cases where it should be...
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
Cc: Felipe Balbi ba...@ti.com
---
Add nodes for USB PCI bridge devices.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: devicet...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: horms+rene...@verge.net.au
Conflicts:
arch/arm/boot/dts/r8a7790.dtsi
---
arch
Enable the usbphy node so that the phy driver is available.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: linux...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: Magnus Damm magnus.d...@gmail.com
Cc: Simon Horman ho
Add the necessary links to add the USB phy nodes to the PCI devices
that are behind the bridges specified.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
arch/arm/boot/dts/r8a7790-lager.dts | 37 +
1 file changed, 37 insertions(+)
diff --git a/arch
Add OF match table for pci-rcar-gen2 driver for device tree support.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
Updates since v1:
- moved documentation into patch
- moved to using bus-range parsing
- ensured usb phy can be linked to usb devices
Cc: Bjorn
On 06/03/14 19:16, Sergei Shtylyov wrote:
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
Add support for the phy-rcar-gen2-usb driver to be probed from device
tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Fixes from v2
On 06/03/14 18:01, Ben Dooks wrote:
Add OF match table for pci-rcar-gen2 driver for device tree support.
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
index fd3e3ab..1216784 100644
--- a/drivers/pci/host/pci-rcar-gen2.c
+++ b/drivers/pci/host/pci-rcar-gen2
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On 27/02/14 00:12, Sergei Shtylyov wrote:
Add support of the device tree probing for the Renesas R-Car generation 2 SoCs
documenting the device tree binding as necessary.
So what happened w.r.t to my last set of patches for this?
--
Ben Dooks http
(clk);
+ return retval;
}
Again, should have been rolled into fix patch.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-usb
On 27/01/14 18:23, Sergei Shtylyov wrote:
Hello.
On 01/26/2014 08:05 PM, Ben Dooks wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = renesas,usb-phy-r8a7790, },
+{ .compatible = renesas,rcar-gen2-usb-phy, },
Frankly speaking, I don't
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Fixes from v1:
- use of_property_reasd-bool()
- remove unused of_id variable
Cc: linux-usb
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Fixes from v2:
- fix missing of_if patch
(I clearly should not be let near git-rebase when hungry)
Fixes
On 26/01/14 18:03, Sergei Shtylyov wrote:
Hello.
On 01/26/2014 07:49 PM, Ben Dooks wrote:
Add support for the phy-rcar-gen2-usb driver to be probed from device
tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Fixes from v1
On 20/01/14 12:18, Sergei Shtylyov wrote:
Hello.
On 18-01-2014 19:03, Ben Dooks wrote:
Add support for the phy-rcar-gen2-usb driver to be probed from device
tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: linux-usb
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
Cc: linux-usb@vger.kernel.org (open list:USB PHY LAYER)
Cc: linux...@vger.kernel.org (open list:ARM/SHMOBILE ARM
);
+MODULE_DESCRIPTION(Renesas R-Car Gen2 internal PCI);
+MODULE_AUTHOR(Valentine Barshak valentine.bars...@cogentembedded.com);
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send
this is hardly 'compiled in' here.
And even it is 'always compiled in' we could just leave this in
in case it is not always compiled in.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from
On 15/05/13 15:30, Felipe Balbi wrote:
Hi,
On Wed, May 15, 2013 at 03:15:44PM +0100, Ben Dooks wrote:
It seems the board is very picky about what it will play host to
as neither of the mini-b to A adapters I have work. I am using
a mini B to mini B cable to run the card reader.
I have still
On 08/05/13 17:45, Sebastian Andrzej Siewior wrote:
* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
We are using an OMAP5432 ES2.0 on an UEVM board
and running into issues with the dwc3 usb.
Sorry, I can't help at all. I don't have the board and I never had one.
I had ES1.0 but I never got dwc3
On 08/05/13 18:02, Felipe Balbi wrote:
Hi,
On Wed, May 08, 2013 at 05:52:50PM +0200, Ben Dooks wrote:
On 08/05/13 17:45, Sebastian Andrzej Siewior wrote:
* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
We are using an OMAP5432 ES2.0 on an UEVM board
and running into issues with the dwc3 usb
(which does work).
I can supply logs if needed.
--
Ben Dooks, Senior Engineer
http://www.codethink.co.uk/
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Dooks, http://www.fluff.org/ben/ bjdo...@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
to keep
going. If this is the issue then we will need to find some other
way of resetting the entire block (currently the otg block is
initialised by the dwc3 driver before it instantiates a xHCI
platform device to handle the host side)
--
Ben Dooks http
68 matches
Mail list logo
