Re: [PATCH 1/3] mfd: omap-usb-host: Use regular platform device probe mechanism

On Tue, Sep 11, 2018 at 06:06:08PM +0300, Laurent Pinchart wrote: > The omap-usb-host driver uses platform_driver_probe() in the fs initcall > level to ensure that the devices get probed before the EHCI and OHCI > drivers arer probed. > > The EHCI and OHCI devices are created and registered by

[PATCH v2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

As devm_ioremap_resource() checks for valid resource, make use of it instead of testing ourselves. As a bonus memory region is requested. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: Drop uneeded error message drivers/usb/gadget/udc/atmel_usba_udc.

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

On Mon, Jan 22, 2018 at 06:53:38PM +0300, Sergei Shtylyov wrote: > On 01/22/2018 06:44 PM, Ladislav Michl wrote: > > >>> As devm_ioremap_resource() checks for valid resource, > >>> make use of it instead of testing ourselves. As a bonus > >>> memory r

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

Hello Sergei, On Mon, Jan 22, 2018 at 06:34:21PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/22/2018 06:21 PM, Ladislav Michl wrote: > > > As devm_ioremap_resource() checks for valid resource, > > make use of it instead of testing ourselves. As a bonus > &

[PATCH 2/2] usb: gadget: udc: atmel: Consolidate error messages

Use the same format for all error messages of driver probe function. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drive

[PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

As devm_ioremap_resource() checks for valid resource, make use of it instead of testing ourselves. As a bonus memory region is requested. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 40 - 1 file chang

[PATCH v4] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl <la...@linux-mips.org> Acked-by: Tony Lindgren <t...@atomide.com> Acked-by: Roger Quadros <rog...@ti.com> Acked-by: Alan Stern <st...@rowland.harvard.edu

Re: [PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

On Thu, Jan 18, 2018 at 10:18:41AM -0500, Alan Stern wrote: > On Thu, 18 Jan 2018, Ladislav Michl wrote: > > > Don't complain on -EPROBE_DEFER when no PHY found, the driver > > probe will be retried later. > > > > Signed-off-by: Ladislav Michl <la...@linux-mips

[PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl <la...@linux-mips.org> Acked-by: Tony Lindgren <t...@atomide.com> Acked-by: Roger Quadros <rog...@ti.com> --- Changes: - v2: None, just added Tony's ack

[PATCH v2] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl <la...@linux-mips.org> Acked-by: Tony Lindgren <t...@atomide.com> --- Changes: - v2: None, just added Tony's ack drivers/usb/host/ehci-omap.c | 5 +++-- 1

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

On Wed, Dec 13, 2017 at 12:16:05PM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 01:44:57PM +0100, Ladislav Michl wrote: > > On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > > > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > > &

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: [snip] > > > I'm afraid I don't consider this an improvement. I prefer using gotos >

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > > Make status handling in bulk in callback function more compact, > > which renders goto pointless. > > > > Signed-off-by: Ladislav

Re: [PATCH] USB: serial: Avoid goto in bulk callbacks

Hi Oliver, Johan, On Mon, Dec 11, 2017 at 11:58:21AM +0100, Oliver Neukum wrote: > Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl: > > Refactor bulk callback functions to make use of goto pointless. > > > > > > Hi, > > you seem to assume th

[PATCH] USB: serial: Avoid goto in bulk callbacks

Refactor bulk callback functions to make use of goto pointless. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/serial/generic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c

[PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

Make status handling in bulk in callback function more compact, which renders goto pointless. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/serial/ti_usb_3410_5052.c | 36 ++- 1 file changed, 14 insertions(+), 22 deletions(-) diff

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 02:59:32PM -0500, Alan Stern wrote: > On Tue, 28 Nov 2017, Ladislav Michl wrote: > > > On Tue, Nov 28, 2017 at 01:09:45PM -0500, Alan Stern wrote: > > > The EHCI debugging files require CONFIG_DYNAMIC_DEBUG to be enabled. > > > Oddly enoug

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 01:09:45PM -0500, Alan Stern wrote: > The EHCI debugging files require CONFIG_DYNAMIC_DEBUG to be enabled. > Oddly enough, the OHCI debugging files do not have the same > requirement. I don't know the reason for this difference. I see, thanks for suggestion. USB cable

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 06:39:13AM -0800, Tony Lindgren wrote: > * Ladislav Michl <la...@linux-mips.org> [171128 14:31]: > > On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > > > * Ladislav Michl <la...@linux-mips.org> [171128 09:42]: > > > >

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 10:00:32AM -0500, Alan Stern wrote: > On Tue, 28 Nov 2017, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > Hi there, > > > > > > USB hosts do not discover any connected device on OMAP3 b

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > * Ladislav Michl <la...@linux-mips.org> [171128 09:42]: > > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > > bit-banging an ir decoder, ugh, you are in for a world of hurt. Can't > >

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 11:03:50AM +0200, Felipe Balbi wrote: > Ladislav Michl <la...@linux-mips.org> writes: > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > >> On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > >> > Hi there, >

Re: EHCI and MUSB do not discover devices without CONFIG_PM

On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 09:57:51AM +0100, Ladislav Michl wrote: > > Hi Greg, > > > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, La

Re: EHCI and MUSB do not discover devices without CONFIG_PM

Hi Greg, On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > Hi there, > > > > USB hosts do not discover any connected device on OMAP3 based board > > with CONFIG_PM=n. Just enabling this

EHCI and MUSB do not discover devices without CONFIG_PM

Hi there, USB hosts do not discover any connected device on OMAP3 based board with CONFIG_PM=n. Just enabling this option is enough to restore working behaviour. Nothing unusual in log. Tested 4.14.2 and 4.15-rc1. I know a lot of stuff depends on CONFIG_PM, but is this expected behaviour? Neither

[PATCH] video: udlfb: Fix read EDID timeout

specifier. Retuned EDID is in second byte, so return error when less than two bytes are received. Fixes: 18dffdf8913a ("staging: udlfb: enhance EDID and mode handling support") Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/video/fbdev/udlfb.c | 10 +- 1

Re: USB hub clear POWER feature -> device still in 'lsusb' ?!

On Tue, May 23, 2017 at 11:40:58PM +0200, Harald Welte wrote: [snip] > But this weird combination between sysfs on the one hand side and > directly issuing USB hub control requests via uhubctl on the other side > really looks ugly. Is this really how one is supposed to power-cycle a > USB device?

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

Hi Laurent, On Sat, Nov 12, 2016 at 03:21:24AM +0200, Laurent Pinchart wrote: > Hi Bin, > > http://pandaboard.org/sites/default/files/board_reference/ES/750-2170-002-sch_revb.pdf > > It would seem that the voltage is provided by the TWL6030. I'm not sure > what's > turning it on as the MUSB

[PATCH v3 6/6] cdc-acm: handle read pipe errors

Read urbs are submitted back only on success, causing read pipe running out of urbs after few errors. No more characters can be read from tty device then until it is reopened and no errors are reported. Fix that by always submitting urbs back and clearing stall on -EPIPE. Signed-off-by: Ladislav

[PATCH v3 5/6] cdc-acm: remove is_int_ep from acm structure

is_int_ep is used only in acm_probe, no need to store it in device data. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v3: new patch in the serie drivers/usb/class/cdc-acm.c | 5 ++--- drivers/usb/class/cdc-acm.h | 1 - 2 files changed, 2 insertions(+), 4 del

[PATCH v3 4/6] cdc-acm: store in and out pipes in acm structure

Clearing stall needs pipe descriptor, store it in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: none - v3: follow CodingStyle drivers/usb/class/cdc-acm.c | 33 + drivers/usb/class/cdc-acm.h | 1 + 2 files chang

[PATCH v3 3/6] cdc-acm: refactor killing urbs

Move urb killing code into separate function and use it instead of copying that code pattern over. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: none - v3: none drivers/usb/class/cdc-acm.c | 43 --- 1 file chang

[PATCH v3 2/6] cdc-acm: avoid interface_to_usbdev call

Pointer to usb_device is already stored in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: none - v3: none drivers/usb/class/cdc-acm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drive

[PATCH v3 1/6] cdc-acm: reindent log messages

Use only one tab to indent dev_{(v)dbg,err} parameters. Signed-off-by: Ladislav Michl <la...@linux-mips.org> Acked-by: Oliver Neukum <oneu...@suse.com> --- Changes: - v2: add changelog text - v3: none drivers/usb/class/cdc-acm.c | 35 +-- 1 file

[PATCH v2 5/5] cdc-acm: handle read pipe errors

Read urbs are submitted back only on success, causing read pipe running out of urbs after few errors. No more characters can be read from tty device then until it is reopened and no errors are reported. Fix that by always submitting urbs back and clearing stall on -EPIPE. Signed-off-by: Ladislav

[PATCH v2 4/5] cdc-acm: store in and out pipes in acm structure

Clearing stall needs pipe descriptor, store it in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: None drivers/usb/class/cdc-acm.c | 27 ++- drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 15 insertions(+), 13 del

[PATCH v2 3/5] cdc-acm: refactor killing urbs

Move urb killing code into separate function and use it instead of copying that code pattern over. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: None drivers/usb/class/cdc-acm.c | 43 --- 1 file changed, 16 insertions(

[PATCH v2 2/5] cdc-acm: avoid interface_to_usbdev call

Pointer to usb_device is already stored in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: None drivers/usb/class/cdc-acm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/cla

[PATCH v2 1/5] cdc-acm: reindent log messages

Use only one tab to indent dev_{(v)dbg,err} parameters. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- Changes: - v2: add changelog text. drivers/usb/class/cdc-acm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/drive

Re: [PATCH 1/5] cdc-acm: reindent log messages

On Tue, Nov 15, 2016 at 11:07:27AM +0100, Greg KH wrote: > On Wed, Nov 09, 2016 at 12:53:25PM +0100, Ladislav Michl wrote: > > Signed-off-by: Ladislav Michl <la...@linux-mips.org> > > --- > > drivers/usb/class/cdc-acm.c | 35 +-- > &g

[PATCH] usb: musb: omap2430: use dev_err

Replace pr_err with dev_err to print also device name. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/musb/omap2430.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index cc12254..4

[PATCH] usb: musb: omap2430: make complain on -EPROBE_DEFER dev_dbg

There is no point having this complaint to be dev_err as it is just adding noise to bootlog. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/musb/omap2430.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/us

[PATCH] usb: musb: don't complain on -EPROBE_DEFER when initializing controller

Don't complain on -EPROBE_DEFER when initializing controller, the driver probe will be retried later. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/musb/musb_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_co

[PATCH] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/host/ehci-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/d

[PATCH 5/5] cdc-acm: handle read pipe errors

Read urbs are submitted back only on success, causing read pipe running out of urbs after few errors. No more characters can be read from tty device then until it is reopened and no errors are reported. Fix that by always submitting urbs back and clearing stall on -EPIPE. Signed-off-by: Ladislav

[PATCH 4/5] cdc-acm: store in and out pipes in acm structure

Clearing stall needs pipe descriptor, store it in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 27 ++- drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drive

[PATCH 3/5] cdc-acm: refactor killing urbs

Move urb killing code into separate function and use it instead of copying that code pattern over. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 43 --- 1 file changed, 16 insertions(+), 27 deletions(-) diff

[PATCH 2/5] cdc-acm: avoid interface_to_usbdev call

Pointer to usb_device is already stored in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index b

[PATCH 1/5] cdc-acm: reindent log messages

Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 78f0f85..b511289 100644 --- a/drive

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

On Tue, Nov 08, 2016 at 04:16:37PM -0700, Tony Lindgren wrote: > * Ladislav Michl <la...@linux-mips.org> [161108 15:52]: > > On Tue, Nov 08, 2016 at 03:05:30PM -0700, Tony Lindgren wrote: > > > OK. The patch below still works for me with musb_core.c > > > autosus

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

_core.c and see if that > helps? This patch works for me, also with autosuspend_delay set to 10. Tested-by: Ladislav Michl <la...@linux-mips.org> Thank you, ladis > Regards, > > Tony > > 8< -- > diff --git a/drivers/usb/musb/musb_core.c b/dri

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

On Tue, Nov 08, 2016 at 07:55:50AM -0700, Tony Lindgren wrote: > * Tony Lindgren [161108 07:50]: > > Weird, I have not figured out what happens there.. > > > > The only thing I'm still wondering about is if phy-twl4030-usb.c > > is losing ID pin interrupts occasionally but have

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

; Please review and test. You need to use v4.9-rc3 or later for testing > because of the earlier fixes. tested on IGEPv2 with v4.9-rc4, so here's my Tested-by: Ladislav Michl <la...@linux-mips.org> Best regards, ladis -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 4/4] cdc-acm: clear halt condition

On Mon, Nov 07, 2016 at 11:26:10AM +0100, Oliver Neukum wrote: > This is looking good. Please resend so Greg can pick it up. One more question. I rather point on it explicitely as it changes driver behaviour. Previously, urb was submitted again only on status == 0. This caused driver to run out

Re: [PATCH 4/4] cdc-acm: clear halt condition

e work queue > is executed. pre_reset() needs to clear the flag EVENT_RX_STALL. Hi, thanks for feedback. Here's an update: -- >8 -- Subject: [PATCHv3 4/4] cdc-acm: clear halt condition Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 59 +++

Re: [PATCH 4/4] cdc-acm: clear halt condition

On Sun, Nov 06, 2016 at 07:25:19AM +0100, Oliver Neukum wrote: > On Sun, 2016-11-06 at 01:36 +0100, Ladislav Michl wrote: > > > > @@ -475,7 +490,30 @@ static void acm_softint(struct work_struct *work) > > { > > struct acm *acm = containe

[PATCH 4/4] cdc-acm: clear halt condition

Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 54 ++--- drivers/usb/class/cdc-acm.h | 3 +++ 2 files changed, 49 insertions(+), 8 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc

[PATCH 3/4] cdc-acm: store in and out pipes in acm structure

Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 27 ++- drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 8

[PATCH 2/4] cdc-acm: avoid interface_to_usbdev call

Pointer to usb_device is already stored in acm structure. Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index b

[PATCH 1/4] cdc-acm: reindent log messages

Signed-off-by: Ladislav Michl <la...@linux-mips.org> --- drivers/usb/class/cdc-acm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 78f0f85..b511289 100644 --- a/drive

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Fri, Nov 04, 2016 at 07:48:13AM -0700, Tony Lindgren wrote: > * Ladislav Michl <la...@linux-mips.org> [161104 03:41]: > > All your patches on top of current Linus' git and revert of: > > commit 87326e858448c40e32f142c0b8dcc59d7b27c641 > > Author: Tony Lindgren <t..

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

Hi Tony, On Thu, Nov 03, 2016 at 03:55:32PM -0700, Tony Lindgren wrote: > * Tony Lindgren <t...@atomide.com> [161103 13:59]: > > * Ladislav Michl <la...@linux-mips.org> [161101 14:14]: > > > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue&q

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Fri, Nov 04, 2016 at 10:46:24AM +0100, Ladislav Michl wrote: > On Fri, Nov 04, 2016 at 10:31:38AM +0200, Felipe Balbi wrote: > [snip] > > Sounds like VBUS dropping to me. Remember, MUSB is really anal about > > VBUS levels. If it drops enough for the PHY to report one of those

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Fri, Nov 04, 2016 at 10:31:38AM +0200, Felipe Balbi wrote: [snip] > Sounds like VBUS dropping to me. Remember, MUSB is really anal about > VBUS levels. If it drops enough for the PHY to report one of those 4 > VBUS levels, then MUSB just gives up. > > What we used to do back at Nokia was

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Thu, Nov 03, 2016 at 03:55:32PM -0700, Tony Lindgren wrote: > * Tony Lindgren <t...@atomide.com> [161103 13:59]: > > * Ladislav Michl <la...@linux-mips.org> [161101 14:14]: > > > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue") &g

Re: musb RPM sleep-while-atomic in 4.9-rc1

On Thu, Nov 03, 2016 at 02:26:35PM -0700, Tony Lindgren wrote: [snip] > Here's the patch updated to use the existing finish_resume_work. > Is that along the lines you were thinking? > > Adding also Ladis to Cc too. Just gave it a try. Sure it wasn't supposed to fix "musb with hub" issue, but at

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote: [snip] > I think the way usbnet handles -EPIPE is the best. We are a bit on thin > ice because the CDC spec does not list under which conditions we should > see a stall, thus by implication: never. > But in general you cannot ignore a

Re: [BUG] cdc-acm: no data available after port open

Hi, On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote: > On Thu, 2016-11-03 at 13:44 +0100, Ladislav Michl wrote: > > On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote: > > Hi, > > > > now I'm really confused. Just looked at drivers/usb/serial

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote: > On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote: > > On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote: > > > Hi Oliver, > > > > > Device operates normally after reco

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote: > On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote: > > Hi Oliver, > > > Device operates normally after reconnect. So it seems you were right, > > there's no handling for EPIPE an

Re: [BUG] cdc-acm: no data available after port open

Hi Oliver, finally got device which stops responding after while on my table... On Mon, Jun 13, 2016 at 11:02:19AM +0200, Oliver Neukum wrote: > On Mon, 2016-06-13 at 00:37 +0200, Ladislav Michl wrote: > > On Sun, Jun 12, 2016 at 11:03:45PM +0200, Ladislav Michl wrote: > > > O

Re: [PATCH] usb: musb: da8xx: Don't print phy error on -EPROBE_DEFER

Hi, On Tue, Oct 25, 2016 at 02:02:50PM -0500, David Lechner wrote: > This suppresses printing the error message "failed to get phy" in the > kernel log when the error is -EPROBE_DEFER. This prevents usless noise > in the kernel log. > > Signed-off-by: David Lechner > --- >

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

Hi, On Mon, Oct 24, 2016 at 11:07:08AM -0700, Tony Lindgren wrote: > Hi, > > * Tony Lindgren <t...@atomide.com> [161021 00:18]: > > * Ladislav Michl <la...@linux-mips.org> [161020 12:37]: > > > [ 186.457519] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_wait_bc

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Thu, Oct 20, 2016 at 05:35:24AM -0700, Tony Lindgren wrote: > Hi, > > * Ladislav Michl <la...@linux-mips.org> [161020 01:24]: > > On Wed, Oct 19, 2016 at 12:03:38PM -0500, Bin Liu wrote: > > > Hi Greg, > > > > > > Here are musb pm fixes

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Wed, Oct 19, 2016 at 12:03:38PM -0500, Bin Liu wrote: > Hi Greg, > > Here are musb pm fixes for v4.9-rc2. Please let me know if any change is > needed. Hi Bin, Tony, just moved away from 4.6 where musb worked (well, not quite reliably, but...) in host only mode with dma on dm3730. Later

Re: usbtmc: vendor specific i/o

On Wed, Sep 28, 2016 at 11:45:02AM +0200, Greg Kroah-Hartman wrote: > If it is freed, why is a read even able to happen? Ah, ick, no proper > reference counting is happening here :( > > Oh, no, wait, it is happening properly, it's just that it's not the > lifespan that the devm_kzalloc() is

Re: usbtmc: vendor specific i/o

On Thu, Aug 04, 2016 at 10:15:33PM +0200, Ladislav Michl wrote: > On Thu, Aug 04, 2016 at 06:59:30AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Aug 03, 2016 at 09:06:25AM +0200, Ladislav Michl wrote: > > > Yes, also was lacking proper description and signoff. So, I'm consid

Re: [PATCH] usb-serial: translate ezusb_convert

On Fri, Sep 23, 2016 at 09:59:57AM +0200, Greg KH wrote: > On Thu, Sep 22, 2016 at 05:54:25PM -0600, Jorge Natz wrote: > > > > ezusb_convert is a script used to convert an Intel HEX firmware file > > into a set of C arrays for use in header files. Increase the > > portability of this script by

Re: usbtmc: vendor specific i/o

On Thu, Aug 04, 2016 at 06:59:30AM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 03, 2016 at 09:06:25AM +0200, Ladislav Michl wrote: > > Yes, also was lacking proper description and signoff. So, I'm considering > > ioctls based approach okay, although that question (the only one I

Re: usbtmc: vendor specific i/o

On Wed, Aug 03, 2016 at 05:59:59AM +0200, Greg Kroah-Hartman wrote: > But your patch was "one-way", once you switched to the other mode, the > old one could not be used :( Yes, also was lacking proper description and signoff. So, I'm considering ioctls based approach okay, although that question

Re: usbtmc: vendor specific i/o

On Tue, Aug 02, 2016 at 11:25:22AM +0200, dave penkler wrote: >For supportability I would recommend to set the commands depending on the >recognised HW, not with aA ioctl. See rigol quirk. What are the device >and manufacturer ids to which these vendor extensions apply? >/dave

Re: usbtmc: vendor specific i/o

On Tue, Aug 02, 2016 at 06:58:11AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 01, 2016 at 08:40:02PM +0200, Ladislav Michl wrote: > > Hi, > > > > I need to ask usbtmc device for vendor specific data. What about adding > > ioctl > > which swit

usbtmc: vendor specific i/o

Hi, I need to ask usbtmc device for vendor specific data. What about adding ioctl which switches MsgIDs to be vendor specific? Or are there other, better, options? Patch bellow ilustrates changes to allow reading and writing vendor specific messages. Thank you, ladis diff --git

Re: [BUG] cdc-acm: no data available after port open

On Mon, Jun 13, 2016 at 11:02:19AM +0200, Oliver Neukum wrote: > On Mon, 2016-06-13 at 00:37 +0200, Ladislav Michl wrote: > > On Sun, Jun 12, 2016 at 11:03:45PM +0200, Ladislav Michl wrote: > > > Once ttyACM0 starts behave strangely, read() returns only what's in > > >

Re: [BUG] cdc-acm: no data available after port open

On Sun, Jun 12, 2016 at 11:03:45PM +0200, Ladislav Michl wrote: > Once ttyACM0 starts behave strangely, read() returns only what's in buffer > before > ttyACM0 was opened and then hangs infinitely. As this bug is hard to trigger, > has > anyone clue where to start debugging? Fo

[BUG] cdc-acm: no data available after port open

Hi there! I'm sorry for imprecise subject, but I really have no clue how to describe shortly... My setup is IGEPv2 board with DM3730 SoC which has usb device connected on EHCI controler via hub running linux-4.6. This device acts as serial-usb converter and feeds IGEP with data. After some time