indings patch for usb-xhci [1]
and it had "renesas,rcar-gen3-xhci" for RZ/G2.
In other words, if a xhci node of RZ/G2 dtsi has "renesas,rcar-gen3-xhci"
compatible,
this can probe the xhci-plat/rcar driver with the firmware V3.
[1]
https://patchwork.kernel.org/patch/1
{
I don't think you need this adding entry for r8a774a1 actually because
you also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs"
for RZ/G2.
[1]
https://patchwork.kernel.org/patch/10574875/
Best regards,
Yoshihiro Shimoda
> .compatible = "renesas,usbhs-r8a7790",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> },
> --
> 2.7.4
Hi,
> From: John Garry, Sent: Tuesday, August 21, 2018 7:30 PM
>
> On 20/08/2018 04:15, Yoshihiro Shimoda wrote:
> > Hi John, Felipe,
> >
> >> From: John Garry, Sent: Wednesday, August 15, 2018 9:55 PM
> >>
> >> On 10/08/2018 07:24, Felipe Balbi wr
k:
> NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !!
Thank you very much for your reports and sorry for the delayed response.
# I had a vacation in last week.
I submitted a patch to fix the issue as below:
https://patchwork.kernel.org/patch/10569847/
I think this patch can resolve the NOTE.
Best regards,
Yoshihiro Shimoda
albi
> Cc: Yoshihiro Shimoda
> Cc: Simon Horman
> Cc: Geert Uytterhoeven
> Signed-off-by: Greg Kroah-Hartman
> ---
I tested on r8a7795-salvator-xs. So,
Acked-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list: send the line "unsubs
ill attach/release the xhci-plat driver to reinitialize the host
hardware.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
This patch set is based on Felipe's usb.git / testing/next branch
(commit id = 47265c067c0d129f3a0e94bc221293a780af9d78).
I remove RFC on this
t;> [4]. So, I'm
> >> trying to improve the device connection framework [5] now.
> >
> > I think this case is rare enough that we don't need a general solution
> > using OF graph, so I'm fine with a simple, single property to link the
> > 2 nodes. Either reus
Hi Rob,
Thank you for the review!
> From: Rob Herring, Sent: Wednesday, May 23, 2018 2:13 AM
>
> On Tue, May 22, 2018 at 09:01:07PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds role switch support for R-Car SoCs into the USB 3.0
> > peripheral driver. Some R-Car SoCs
correctly (e.g. detect a device as
high-speed).
To achieve this by a driver, this role switch driver manages
the mode change register and attach/release the xhci-plat driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../devicetree/bindings/usb/renesas_usb3.txt
This patch adds graph parsing in device_connection_find_match().
The match function will be called with fwnode pointer in struct
device_connection. So, a caller can check the matching by using it.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/driv
This patch uses usb role switch APIs if the register suceeeded.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadg
This patch adds OF graph properties for usb role switch in r8a7795
into USB3.0 host/peripheral nodes.
TODO:
- need patches for other SoCs.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12
1 file chang
usb role switch and renesas_usb3 drivers.
- Update the dtsi file for r8a7795.
Yoshihiro Shimoda (4):
base: devcon: add graph parse in device_connection_find_match()
usb: gadget: udc: renesas_usb3: Add register of usb role switch
usb: gadget: udc: renesas_usb3: use usb role switch API
arm64: dts
appens in
printer_func_unbind() because the list entry is not removed.
So, this patch moves list_add(>list, >tx_reqs_active)
calling before usb_ep_queue().
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com>
-
Hi,
> From: Felipe Balbi, Sent: Monday, May 21, 2018 7:19 PM
>
> Hi,
>
> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes:
> > Hi,
> >
> >> From: Felipe Balbi, Sent: Monday, May 21, 2018 5:05 PM
> >
> >> seems like it would
lock_irqrestore(>lock, flags);
> mutex_unlock(>lock_printer_io);
> return -EAGAIN;
> }
> -
> - list_add(>list, >tx_reqs_active);
> -
> }
>
> spin_unlock_irqrestore(>lock, flags);
>
> --
Thank you
Hi,
> From: Felipe Balbi, Sent: Monday, May 21, 2018 3:57 PM
>
> Hi,
>
> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes:
> > The usb_ep_queue() in printer_write() is possible to call req->complete().
> > In that case, since tx_compl
on of req->list before adding the list in printer_write().
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
This issue can be caused by renesas_usbhs udc driver. I'm not sure
this patch is acceptable or not. So, I marked RFC on this patch.
drivers/usb/gadget/f
Hi Heikki,
Thank you for the reply!
> From: Heikki Krogerus, Sent: Tuesday, May 15, 2018 5:29 PM
>
> On Tue, May 15, 2018 at 02:19:14AM +, Yoshihiro Shimoda wrote:
> > Hi Heikki,
> >
> > > From: Heikki Krogerus, Sent: Monday, May 14, 2018 10:28 PM
> > &
Hi Simon-san,
> From: Simon Horman, Sent: Tuesday, May 15, 2018 5:04 PM
>
> On Tue, May 15, 2018 at 08:02:00AM +, Yoshihiro Shimoda wrote:
> > Hi Simon-san,
> >
> > Thank you for your review!
> >
> > > From: Simon Horman, Sent: Tuesday, May 15, 201
Hi Simon-san,
Thank you for your review!
> From: Simon Horman, Sent: Tuesday, May 15, 2018 4:54 PM
> On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote:
> > static void usb3_set_mode(struct renesas_usb3 *usb3, bool host)
> > {
> > - _
Hi Simon-san,
Thank you for your review!
> From: Simon Horman, Sent: Tuesday, May 15, 2018 4:35 PM
>
> On Tue, Apr 10, 2018 at 02:38:54PM +0900, Yoshihiro Shimoda wrote:
> > This patch fixes an issue that reconnection is possible to fail
> > because unexpected state handlin
Hi Heikki,
> From: Heikki Krogerus, Sent: Monday, May 14, 2018 10:28 PM
>
> On Mon, May 14, 2018 at 06:15:57PM +0900, Yoshihiro Shimoda wrote:
> > diff --git a/drivers/base/devcon.c b/drivers/base/devcon.c
> > index d427e80..5a0da33 100644
> > --- a/drivers/base/devc
This patch adds a new API "device_connection_find_by_graph()" to
find device connection by using graph.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/driver-api/device_connection.rst | 4 +--
drivers/base/devcon.c
This patch adds OF graph properties for usb role switch in r8a7795
into USB3.0 host/peripheral nodes.
TODO:
- need patches for other SoCs.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12
1 file chang
quot;device-connection-id" and "usb role switch driver" dt-bingings.
- Remove drivers/of code.
- Add a new API for find the connection by using graph on devcon.c and roles.c.
- Use each new API on the rcar usb role switch and renesas_usb3 drivers.
- Update the dtsi file for r8a7795.
This patch uses usb role switch API if the register suceeeded.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/renesas_usb
correctly (e.g. detect a device as
high-speed).
To achieve this by a driver, this role switch driver manages
the mode change register and attach/release the xhci-plat driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../devicetree/bindings/usb/renesas_usb3.txt
Hi Rob,
> From: Rob Herring, Sent: Saturday, May 12, 2018 1:07 AM
>
> On Mon, May 7, 2018 at 9:43 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Hi Rob,
> >
> > Sorry for the delayed response. I had a vacation in last week.
> >
>
Hi Felipe,
> From: Yoshihiro Shimoda, Sent: Tuesday, April 10, 2018 2:39 PM
>
> This patch set is based on v4.16.
Would you review this patch set?
I checked this is able to be applied on your testing/fixes branch.
Best regards,
Yoshihiro Shimoda
> Changes from v1:
>
Hi Rob,
Sorry for the delayed response. I had a vacation in last week.
> From: Rob Herring, Sent: Saturday, April 28, 2018 5:06 AM
>
> On Thu, Apr 26, 2018 at 08:26:41PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds a new documentation for Renesas R-Car USB 3.0 role
>
This patch adds support for a usb role switch driver. And then,
this driver uses the usb role switch APIs instead of hardware
access to initialize usb host side at specific timings.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/Kconfig
-speed).
To achieve this by a driver, this role switch driver manages
the mode change register and attach/release the xhci-plat driver.
The renesas_usb3 udc driver should call devm_of_platform_populate()
to probe this driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
This patch adds a new API "device_connection_find_by_graph()" to
find device connection by using graph.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/driver-api/device_connection.rst | 4 +--
drivers/base/devcon.c
This patch adds a new API "usb_role_switch_get_by_graph()" to find
device connection by using graph.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/common/roles.c | 30 ++
include/linux/usb/role.h | 2 ++
2 f
This patch adds OF graph properties for usb role switch in r8a7795.
TODO:
- separate a few patches to add new properties into each node.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 38 +
This patch adds a new documentation for Renesas R-Car USB 3.0 role
switch that can change the USB 3.0 role to either host or peripheral
by a hardware register that is included in USB3.0 peripheral module.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../bindin
r" dt-bingings.
- Remove drivers/of code.
- Add a new API for find the connection by using graph on devcon.c and roles.c.
- Use each new API on the rcar usb role switch and renesas_usb3 drivers.
- Update the dtsi file for r8a7795.
Yoshihiro Shimoda (6):
dt-bindings: usb: add Renesas R-Car USB
Hi,
> From: Rob Herring, Sent: Tuesday, April 24, 2018 11:33 PM
>
> On Wed, Apr 18, 2018 at 05:09:55PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds a new property for device connection framework.
>
> What's the "device connection framework" and wh
Hi Heikki,
> From: Heikki Krogerus, Sent: Tuesday, April 24, 2018 9:34 PM
>
> Hi Yoshihiro,
>
> On Wed, Apr 18, 2018 at 05:09:58PM +0900, Yoshihiro Shimoda wrote:
> > + devcon->endpoint[0] = dev_name(>dev);
> > + devcon-&
Hi,
> From: Johan Hovold, Sent: Wednesday, April 18, 2018 5:42 PM
>
> On Wed, Apr 18, 2018 at 04:22:31AM +, Yoshihiro Shimoda wrote:
> > Hi,
> >
> > > From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> > >
> > > Drop support for le
This patch adds a new documentation for Renesas R-Car USB 3.0 role
switch driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../bindings/usb/renesas,rcar-usb3-role-sw.txt | 56 ++
1 file changed, 56 insertions(+)
create mode
This patch adds a new documentation for a usb role switch driver.
The usb role switch framework will parse this to get each device
pointer by using each remote-endpoint.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../devicetree/bindings/usb/usb-role-swit
-speed).
To achieve this by a driver, this role switch driver manages
the mode change register and attach/release the xhci-plat driver.
The renesas_usb3 udc driver should call devm_of_platform_populate()
to probe this driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
This patch adds fwnode graph parsing to set usb[23]_port and udc
into the usb_role_switch structure by usb_role_switch_register().
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/common/roles.c | 40 +++-
1 file chang
This patch adds OF graph properties for usb role switch.
TODO:
- Each node should be in salvator-common.dtsi.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
.../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 28 ++
1 file changed, 28 inse
et as "RFC". Before I resolve them,
I would like to know whether this way is good or not.
[1] https://patchwork.kernel.org/patch/10332865/
Yoshihiro Shimoda (11):
Documentation: of: Add device-connection-id property
dt-bindings: usb: add usb role switch driver
dt-bindings: usb: a
This patch adds support for a usb role switch driver. And then,
this driver uses the usb role switch APIs instead of hardware
access to initialize usb host side at specific timings.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/Kconfig
This patch adds APIs that a role switch driver can get device pointer
of USB 2.0/3.0 and udc.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/common/roles.c | 36
include/linux/usb/role.h | 4
2 files chang
This patch adds device connection parsing in of_platform_populate().
TODO:
- How to free the devcon memories?
- How to remove the devcon instances?
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/of/platform.
This patch adds a new property for device connection framework.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/graph.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/graph.
This patch adds OF graph properties for usb role switch in r8a7795.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 44
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/r
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/common/roles.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
index cc1c55a..381259c 100644
--- a/drivers/usb/common/roles.c
+++ b/dr
-
> 2 files changed, 30 deletions(-)
Thank you for the patch!
The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy API
(usb_get_phy()).
Also this patch set doesn't drop the API. So, I think this subject should be
changed.
What do you think?
Dropping usb_get_phy_dev() from this
Hi Simon-san,
> From: Simon Horman, Sent: Wednesday, April 11, 2018 4:28 PM
>
> On Tue, Apr 10, 2018 at 09:13:53PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds a new property to ignore the ID signal on a board.
> >
> > Signed-off-by: Yoshihiro Shimoda <yo
Hi Heikki,
Thank you for the comments!
> From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 5:02 PM
>
> On Wed, Apr 11, 2018 at 03:15:23AM +, Yoshihiro Shimoda wrote:
> > > > + host_node = of_parse_phandle(pdev->dev.of_node, &q
Hi Heikki,
> From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 4:26 PM
>
> On Tue, Apr 10, 2018 at 09:03:46PM +0900, Yoshihiro Shimoda wrote:
> > +Example of R-Car H3 ES2.0:
> > + usb3_peri0: usb@ee02 {
> > + compatible =
Hi Andy,
Thank you for the review!
> From: Andy Shevchenko, Sent: Tuesday, April 10, 2018 9:40 PM
>
> On Tue, Apr 10, 2018 at 3:03 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > +#include
> > +#include
> > +#include
>
&
This patch adds a new property to ignore the ID signal on a board.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
drivers/usb/gadget/udc/renesas_usb3.c | 10 ++
2 files chang
match on device tree environment. However, the select
USB_ROLE_SWITCH needs to enable the rcar-usb3-role-switch driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/Kconfig| 1 +
drivers/usb/gadget/udc/renesas_usb3.c | 6 ++
2
I will add using the USB role switch APIs to renesas_usb3
driver. But, for now, since the device connection framework is not good
for device tree environment (e.g. calling the API on a driver with
device name, but device names on device tree environment will be
.).
Yoshihiro Shimoda (2):
usb: g
-speed).
To achieve this by a driver, this role switch driver manages
the mode change register and attach/release the xhci-plat driver.
The renesas_usb3 udc driver should call devm_of_platform_populate()
to probe this driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
Hi Simon-san,
> From: Simon Horman, Sent: Tuesday, April 10, 2018 6:34 PM
>
> On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote:
> > Hi Simon-san,
> >
> > > From: Simon Horman, Sent: Monday, April 9, 2018 8:58 PM
> > >
> > > On
c64060 ("usb: gadget: udc: renesas_usb3: add support for generic
phy")
Cc: <sta...@vger.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Remarks:
- A new file in v2
drivers/usb/gadget/udc/renesas_usb3.c | 8 +---
1 file
This patch set is based on v4.16.
Changes from v1:
- Add Reviewed-by in patch 1, 2, 3 and 4.
- Revise typo in patch 4.
- Add new patches as patch 5 and 6.
Yoshihiro Shimoda (6):
usb: gadget: udc: renesas_usb3: fix double phy_put()
usb: gadget: udc: renesas_usb3: should remove debugfs
not be called at this timing
because the macro uses the gadget structure.
Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move
pm_runtime_{en,dis}able()")
Cc: <sta...@vger.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Si
heral controller")
Cc: <sta...@vger.kernel.org> # v4.5+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Remarks:
- A new file in v2
drivers/usb/gadget/udc/renesas_usb3.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/gadget/udc/renesas
er.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
Changes from v1:
- Add Reviewed-by.
drivers/usb/gadget/udc/renesas_usb3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/u
_usb3: add support for generic
phy")
Cc: <sta...@vger.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
Changes from v1:
- Add Reviewed-by.
- Revise typo in the comment.
drivers
This patch fixes an issue that this driver doesn't remove its debugfs.
Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the
b-device mode")
Cc: <sta...@vger.kernel.org> # v4.14+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Rev
Hi Simon-san,
> From: Simon Horman, Sent: Monday, April 9, 2018 8:58 PM
>
> On Mon, Apr 02, 2018 at 09:21:34PM +0900, Yoshihiro Shimoda wrote:
> > This patch fixes an issue that this driver cannot call phy_init()
> > if a gadget driver is alreadly loaded because usb_add_g
This patch fixes an issue that this driver doesn't remove its debugfs.
Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the
b-device mode")
Cc: <sta...@vger.kernel.org> # v4.14+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
-
This patch set is based on v4.16. (I should have realized these issues in
v4.16-rc cycle though...)
Yoshihiro Shimoda (4):
usb: gadget: udc: renesas_usb3: fix double phy_put()
usb: gadget: udc: renesas_usb3: should remove debugfs
usb: gadget: udc: renesas_usb3: should call pm_runtime_enable
er.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c
b/drivers/usb/gadget/udc/renesas_usb3.c
index 409cde4..78a12a5 10
not be called at this timing
because the macro uses the gadget structure.
Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move
pm_runtime_{en,dis}able()")
Cc: <sta...@vger.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
er.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c
b/drivers/usb/gadget/udc/renesa
Hi Greg,
> From: Greg KH, Sent: Saturday, March 10, 2018 2:08 AM
>
> On Fri, Mar 09, 2018 at 01:48:37AM +, Yoshihiro Shimoda wrote:
> > Hi Greg,
> >
> > > From: Greg KH, Sent: Friday, March 9, 2018 2:06 AM
> > >
> > > On Thu, Mar 0
Hi Greg,
> From: Greg KH, Sent: Friday, March 9, 2018 2:06 AM
>
> On Thu, Mar 08, 2018 at 05:17:16PM +0200, Mathias Nyman wrote:
> > From: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
> >
> > This patch reverts the commit 835e4241e714 ("usb: hos
This patch adds binding for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.
This patch set is based on the latest Felipe's usb.git / testing/next
branch (commit id = 892b3e4a3df3f8fa18053aba65acd5a3dee05325).
Yoshihiro Shimoda (2):
usb: renesas_usbhs: add binding for r8a77965
usb: gadget: udc: renesas_usb3: add binging for r8a77965
Documentation/devicetree
This patch adds binding for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.
This patch adds support for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
drivers/usb/host/xhci-rcar.c | 4
2 files changed, 5 insertions(+)
diff
Hi,
I'm afraid but I will re-submit this patch because we should get review by
device tree maintainers.
Best regards,
Yoshihiro Shimoda
> From: Yoshihiro Shimoda, Sent: Tuesday, February 27, 2018 5:12 PM
>
> This patch adds support for r8a77965 (R-Car M3-N).
>
> Signed-of
This patch adds support for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
drivers/usb/host/xhci-rcar.c | 4
2 files changed, 5 insertions(+)
diff
print error message in xhci-hub if hub tries to set port link state
> for a disabled port. Return -ENODEV instead which also silences hub driver.
>
> Signed-off-by: Mathias Nyman <mathias.ny...@linux.intel.com>
Thank you very much for the patch!
I tested this patch on my environme
enabled in resume.
Fixes: 835e4241e714 ("usb: host: xhci-plat: enable clk in resume timing")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/host/xhci-plat.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/us
ction uses pio, the usbhsf_prepare_pop() can not
start the transaction because the "running" flag is 0.
Fixes: 8355b2b3082d ("usb: renesas_usbhs: fix the behavior of some
usbhs_pkt_handle")
Cc: <sta...@vger.kernel.org> # v3.19+
Signed-off-by: Yoshihiro Shimoda <yoshihi
This patch fixes an issue that the renesas_usb3_remove() causes
NULL pointer dereference because the usb3_to_dev() macro will use
the gadget instance and it will be deleted before.
Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move
pm_runtime_{en,dis}able()")
Signed-off-by:
n/xhci.git/commit/?h=for-usb-linus=4b42a60487f891d03268af668
> 23a16c31c53801d
Thank you very much for the patch. I tested this branch on my environment
(R-Car H3) and worked correctly.
So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
> -Mathias
Hi,
> From: Mathias Nyman, Sent: Wednesday, January 31, 2018 9:29 PM
>
> On 31.01.2018 13:58, Yoshihiro Shimoda wrote:
> > The commit 37be66767e3c ("usb: hub: Fix auto-remount of safely removed
> > or ejected USB-3 devices") causes the following error when we
&g
clear.
Suggested-by: Mathias Nyman <mathias.ny...@linux.intel.com>
Suggested-by: Alan Stern <st...@rowland.harvard.edu>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/usb/host/xhci-hub.c | 7 +--
1 file changed, 5 insertions(+), 2 deletion
Hi Mathias, Alan,
> -Original Message-
> From: Alan Stern, Sent: Wednesday, January 31, 2018 12:54 AM
>
> On Tue, 30 Jan 2018, Mathias Nyman wrote:
>
> > On 26.01.2018 03:47, Yoshihiro Shimoda wrote:
> > > I resent this email with addin
I resent this email with adding Mathias, Alan and Greg as CC.
-Original Message-
From: Yoshihiro Shimoda, Sent: Thursday, January 18, 2018 6:03 PM
To: linux-usb@vger.kernel.org
Subject: Questions about "usb usb8-port1: cannot disable (err = -32)"
Hi,
My environment (R-Car H
xhci spec, the PED will be set to 0
after the usb3 root hub enters "Error" or "Disconnected" state.
So, IIUC, a usb driver should not call hub_set_port_link_state() in such a case.
Question 1:
- Is my understanding correct?
Question 2:
- How do I resolve the issue? (I don't ha
This patch fixes an issue that the renesas_usb3_remove() causes
NULL pointer dereference because the usb3_to_dev() macro will use
the gadget instance and it will be deleted before.
Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move
pm_runtime_{en,dis}able()")
Signed-off-by:
:
- Needs to avoid double usb_remove_hcd() calling by rmmod or unbind and
the xhci_rcar_work().
- Needs to divide this patch (this patch has many feature changes).
If this approach is acceptable for upstream, I'll improve the patch.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shim
> ---
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
+Felipe
> -Original Message-
> From: Yoshihiro Shimoda, Sent: Wednesday, January 10, 2018 5:27 PM
>
> Hi Chris-san,
>
> > From: Chris Brandt, Sent: Monday, January 8, 2018 9:31 PM
> >
> > This patch adds the capability to support RZ/A1 SoCs.
&g
Hi Chris-san,
> From: Chris Brandt, Sent: Monday, January 8, 2018 9:31 PM
>
> This patch adds the capability to support RZ/A1 SoCs.
>
> Signed-off-by: Chris Brandt <chris.bra...@renesas.com>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@re
Hi,
> From: kbuild test robot, Sent: Thursday, December 14, 2017 2:21 AM
>
> Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for
> non-otg channel")
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
Thank you for the patc
1 - 100 of 632 matches
Mail list logo
