rrect, addresses the stated problem, no forgotten parts
found left to fix.
Acked-by: Pete Zaitcev
-- P
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ode works, surprisingly, even when the
debugfs is disabled (well, according to my review). I just have one
question - wouldn't it be cleaner to deprecate and remove the text
API altogether?
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of
This change fixes buffer overflows and silent data corruption with the
usbmon device driver text file read operations.
Signed-off-by: Fredrik Noring <nor...@nocrew.org>
Signed-off-by: Pete Zaitcev <zait...@redhat.com>
---
diff --git a/drivers/usb/mon/mon_text.c b/drivers/usb/mon/mon_
mplements it.
Now, you have to know the foo_show convention. But if you think
it's worth being a bit more explicit about "this is intended to
be a RO attribute", then okay.
Acked-by: Pete Zaitcev <zait...@redhat.com>
-- P
--
To unsubscribe from this list: send the line "
Automated tests triggered this by opening usbmon and accessing the
mmap while simultaneously resizing the buffers. This bug was with
us since 2006, because typically applications only size the buffers
once and thus avoid racing. Reported by Kirill A. Shutemov.
Signed-off-by: Pete Zaitcev <z
lock fixes it. That said, your test
suite may be more comprehensive, or you may have a device that
generates enough USB traffic with associated monitoring callbacks.
But I don't see it.
At this point, I'm going to post the patch with a Signed-Off-By.
-- Pete
(this reproduces very quickly)
/*
*
ed to make a smaller test for this, but was unsuccessful
so far. I'll poke a bit at it later, but it may take me some time.
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
return VM_FAULT_SIGBUS;
> > chunk_idx = offset / CHUNK_SIZE;
>
> missing braces ... maybe you'd rather a 'goto sigbus' approach?
Thanks. What a way to return to kernel programming for me. I'm going
to test it anyway, already started to unpacking a PC, but yeah...
-- Pe
break;
case MON_IOCT_RING_SIZE:
@@ -1231,12 +1233,15 @@ static int mon_bin_vma_fault(struct vm_fault *vmf)
unsigned long offset, chunk_idx;
struct page *pageptr;
+ mutex_lock(>fetch_lock);
offset = vmf->pgoff << PAGE_SHIFT;
if (of
ers. By defintion it's not covering things that
are related to re-allocation. Now, the re-allocation itself
grabs it, because it resets indexes into the new buffer, but
does not appear to apply here, does it now?
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t_baud_rate(struct tty_struct *tty,
> divisor = mct_u232_calculate_baud_rate(serial, value, );
> - put_unaligned_le32(cpu_to_le32(divisor), buf);
> + put_unaligned_le32(divisor, buf);
> rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
Acked
computer and continue with the -62
version for now :)
Best regards,
Pete
Here's the info I assume you'll need:
uname -a
Linux pete 4.4.0-62-generic #83-Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux
cat /proc/version_signature
Ubuntu 4.4.0-62.83-generic 4.4.40
her missed that mutex_lock_interruptible()
can set the state, or it didn't do it back then (it was in 2007), and
the 7f477358e introduced the existing code.
Acked-By: Pete Zaitcev <zait...@yahoo.com>
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[] = {
- { USB_INTERFACE_INFO(7, 1, 3) },
+ { USB_INTERFACE_INFO(USB_CLASS_PRINTER, 1, 3) },
{ USB_DEVICE(0x04b8, 0x0202) }, /* Seiko Epson Receipt Printer M129C */
If you're concerned about grepping, then fix all other places like
usblp_select_alts(), too.
-- Pete
--
To unsubscribe
Hi Jens,
On 2014.01.27 12:25, Jens Bauer wrote:
On Sun, 26 Jan 2014 17:07:42 +, Pete Batard wrote:
I, and many others, happen to think users of libusb deserve more than
one release in 4 years, even more so as continuous major development has
been going on.
I disagree.
If libusb works
On 2014.01.27 20:44, Jens Bauer wrote:
Pete, you are young
Not a good start.
What if I told you I started programming in the mid 80s? Do I still qualify?
But you have a problem. You feel attacked whenever anyone says something that
you do not agree with.
Yes, I tend to be annoyed when
On 2014.01.26 07:47, Peter Stuge wrote:
I've removed the libusbx-devel list since Pete Batard banned[1] me
after I wrote that I considered the libusbx code to have a bug[2].
Here we go again. Well, we've been through that quite a few times already.
In the thread you pointed, I explained why
will be as short lived as possible.
You are invited to visit http://libusb.info, which contains all the
links that are mentioned above, as well as additional information.
Thank you,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Quoting Dan Williams d...@redhat.com:
On Sat, 2013-08-17 at 18:05 -0400, Peter Hyman wrote:
snip
Maybe this will move the ball. We'll see. Thank you.
Yes, I was given that document by Sierra a couple years ago. No, it
doesn't help, because it only covers basic CDMA/EVDO stuff and does not
On Sun, 18 Aug 2013 00:24:30 +0800
Ming Lei ming@canonical.com wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Pete Zaitcev zait...@kotori.zaitcev.us
Signed-off-by: Ming Lei ming@canonical.com
Still looks good.
-- P
On Thu, 11 Jul 2013 17:05:26 +0800
Ming Lei ming@canonical.com wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Pete Zaitcev zait...@redhat.com
Signed-off-by: Ming Lei ming@canonical.com
Signed-off-by: Pete Zaitcev zait
git log at:
https://github.com/libusbx/libusbx/commits/master
For additional info, please visit:
http://libusbx.org
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
the
static library and DLL, for MSVC and MinGW.
In related news, the MSCV DLLs now include the .pdb, as was recently
requested.
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
://sourceforge.net/projects/libusbx/files/releases/1.0.15/source/
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
visit http://libusbx.org
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 14 Jan 2013 12:23:05 -0800
Greg KH gre...@linuxfoundation.org wrote:
Forgot to mention the side effect of the patch: one can't submit read and
write URB simultaneously via USBDEVFS_BULK ioctl(). That has been dealt in
2.4
by later patch by Pete, which I can try to port
a.k.a. 1.0.13, we hardly knew ye.
* Reverts the previous API change with regards to bMaxPower.
* Note that LIBUSBX_API_VERSION is *decreased* to 0x01FF and the
previous guidelines with regards to concurrent use of
MaxPower/bMaxPower still apply.
Regards,
/Pete
--
To unsubscribe from
it will be even more painful to leave
that for later.
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
then.
Regards,
/Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
have a look at the release note that was posted on this
list? We did our best to ensure the possibility of breakage featured
prominently.
The full content of the post is replicated below.
Regards,
/Pete
On 2012.09.20 22:42, Pete Batard wrote: Hi,
It with pleasure that I would like
controllers on Windows
* Harmonize the device number for root hubs across platforms
* Other bug fixes and improvements
Release archives can be obtained from:
https://sourceforge.net/projects/libusbx/files/releases/1.0.13/
For more information, please visit: http://libusbx.org
Regards,
/Pete
it in one go seems more self-consistent, but either way is
fine by me.
-- Pete
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the issue (version 11.117.07.00.67). Probably they started to comply
with the spec and return 12 bytes of sense according to the allocation
length in the SCSI command.
https://bugzilla.redhat.com/show_bug.cgi?id=253096#c51
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb
to 0 the initialization works automatically.
I may be able to test this.
As you recall, Huawei people themselves suggested nonzero length,
this is why we didn't want to change it. But perhaps they are
mistaken about the operation of their own hardware. Stranger
things happened...
-- Pete
it.
Look at the traffic with usbmon, it provides you timestamps for
(S)ubmission and (C)allback events.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
out and from
the
time I call usb_submit_urb until the callback is 1 jiffie or less.
In this case you don't need usbmon for timing, but still have
a look, it might clear the picture by giving a more complete view.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb
On Tue, 12 Feb 2008 19:08:30 +0100, Oliver Neukum [EMAIL PROTECTED] wrote:
Signed-off-by: Oliver Neukum [EMAIL PROTECTED]
if (handle_bidir(usblp) 0) {
+ usb_autopm_put_interface(intf);
usblp-used = 0;
Signed-Off-By: Pete Zaitcev [EMAIL PROTECTED]
-- Pete
to implement mon_dmapeek() for ARM, I'll be happy
to include it.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
in favour of usb-storage. If so,
perhaps we should remove or disble ub.c?
Actually I think it may be an argument for keeping ub, if ub exposes
a bug in the __blk_end_request. I'll look at the head of the thread
and see if Mr. Pinter has hit anything related to Mr. Ueda's work.
-- Pete
is mapped and what is
not have grown plenty complex already. I don't want to touch it
unless we create a cleaned-up URB from scratch.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
or get_free_page.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 1 Feb 2008 11:59:56 -0500 (EST), Alan Stern [EMAIL PROTECTED] wrote:
You missed the point. Windows does _not_ do it -- i.e., does not clear
a halt on either bulk endpoint. Linux does so only because somebody
(either Pete Zaitcev or Pat Lavarre, I can't remember which) pointed
out
On Fri, 1 Feb 2008 11:54:12 -0800, Matthew Dharm [EMAIL PROTECTED] wrote:
There's no way to know until Robert tests with no clear-halt at all.
Which is very easy to do: enable ub, run usbmon... voila.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
?!) and supplies wrong descriptors.
Then, berry_charge fails this:
if ((udev-actconfig-desc.bMaxPower * 2) == 500)
Cheers,
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
on the same bus makes me uncomfortable.
It's a miracle your HCs scheduler manages to find bandwidth for them.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
/kernel-parameters.txt.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
provides a useful timestamp,
especially on more modern systems with something like HPET timer.
By comparing timestamps for the case of cat writing to serial port
and to disk, one may be able to detect the difference and thus know
where to add delays that Alan mentions above.
-- Pete
-
To unsubscribe
not make any difference in
view of the trace above, is there a box with something like 2.6.21 to try?
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
might want to throw that in and see if it sticks.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
:1 -84 0
I had major issues with the Kingston in the past because they do not
like a halt clear while not halted, but nothing like this. Perhaps
it's a new cheaper revision, buggier than before.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
unconvinced.
-- Pete
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
51 matches
Mail list logo
