RE: UAC2 gadget not recognized on Windows 10

2018-06-21 Thread Felipe Balbi
Hi, Robert Bielik writes: >> Enabling SOF interrupts will be a big pain :-) Well, enabling the >> interrupt itself is a no-brainer, but it'll cause terrible CPU overload. > > Oh, I see. Hmm... would it be possible to allow upper levels to config > this dynamically ? I.e. for the ALSA subsystem

Re: UAC2 gadget not recognized on Windows 10

2018-06-20 Thread Jassi Brar
On Wed, Jun 20, 2018 at 9:16 PM, jonsm...@gmail.com wrote: > On Wed, Jun 20, 2018 at 11:19 AM Jassi Brar wrote: >> >> On Wed, Jun 20, 2018 at 8:32 PM, jonsm...@gmail.com >> wrote: >> > >> > >> > >> > On Wed, Jun 20, 2018 at 9:36 AM Jassi Brar >> > wrote: >> >> >> >> On Tue, Feb 13, 2018 at

Re: UAC2 gadget not recognized on Windows 10

2018-06-20 Thread jonsm...@gmail.com
On Wed, Jun 20, 2018 at 11:19 AM Jassi Brar wrote: > > On Wed, Jun 20, 2018 at 8:32 PM, jonsm...@gmail.com > wrote: > > > > > > > > On Wed, Jun 20, 2018 at 9:36 AM Jassi Brar wrote: > >> > >> On Tue, Feb 13, 2018 at 3:02 PM, Robert Bielik > >> wrote: > >> >> Enabling SOF interrupts will be a

Re: UAC2 gadget not recognized on Windows 10

2018-06-20 Thread Jassi Brar
On Wed, Jun 20, 2018 at 8:32 PM, jonsm...@gmail.com wrote: > > > > On Wed, Jun 20, 2018 at 9:36 AM Jassi Brar wrote: >> >> On Tue, Feb 13, 2018 at 3:02 PM, Robert Bielik >> wrote: >> >> Enabling SOF interrupts will be a big pain :-) Well, enabling the >> >> interrupt itself is a no-brainer,

Re: UAC2 gadget not recognized on Windows 10

2018-06-20 Thread Jassi Brar
On Tue, Feb 13, 2018 at 3:02 PM, Robert Bielik wrote: >> Enabling SOF interrupts will be a big pain :-) Well, enabling the >> interrupt itself is a no-brainer, but it'll cause terrible CPU overload. > > Oh, I see. Hmm... would it be possible to allow upper levels to config this > dynamically ?

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
> Enabling SOF interrupts will be a big pain :-) Well, enabling the > interrupt itself is a no-brainer, but it'll cause terrible CPU overload. Oh, I see. Hmm... would it be possible to allow upper levels to config this dynamically ? I.e. for the ALSA subsystem there is no need for the SOF

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Felipe Balbi
Hi, Robert Bielik writes: >> >> I guess UAC1 doesn't need feedback endpoints, right? Seems like that >> >> should be something specific to UAC2. At least for now. >> > >> > It seems like it is needed there aswell, see >> >

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
> >> I guess UAC1 doesn't need feedback endpoints, right? Seems like that > >> should be something specific to UAC2. At least for now. > > > > It seems like it is needed there aswell, see > > http://www.usb.org/developers/docs/devclass_docs/audio10.pdf (3.7.2.2) > > (Feedback endpoint == Synch

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Felipe Balbi
Hi, Robert Bielik writes: >> I guess UAC1 doesn't need feedback endpoints, right? Seems like that >> should be something specific to UAC2. At least for now. > > It seems like it is needed there aswell, see > http://www.usb.org/developers/docs/devclass_docs/audio10.pdf

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
> I guess UAC1 doesn't need feedback endpoints, right? Seems like that > should be something specific to UAC2. At least for now. It seems like it is needed there aswell, see http://www.usb.org/developers/docs/devclass_docs/audio10.pdf (3.7.2.2) (Feedback endpoint == Synch Endpoint) Regards /R

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Felipe Balbi
Hi, Robert Bielik writes: >> >> Indeed, that's also mandated by USB spec. Seems like we need to patch >> >> f_uac2.c. Can you check if setting the IN endpoint as implicit feedback >> >> data is enough? >> > >> > Just tried your proposed patches on 4.15.1 (with an RPi

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
> >> Indeed, that's also mandated by USB spec. Seems like we need to patch > >> f_uac2.c. Can you check if setting the IN endpoint as implicit feedback > >> data is enough? > > > > Just tried your proposed patches on 4.15.1 (with an RPi Zero) and with > > g_audio, unfortunately there is no change.

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Felipe Balbi
Hi, Robert Bielik writes: >> Indeed, that's also mandated by USB spec. Seems like we need to patch >> f_uac2.c. Can you check if setting the IN endpoint as implicit feedback >> data is enough? > > Just tried your proposed patches on 4.15.1 (with an RPi Zero) and with >

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
Hi Felipe, > Indeed, that's also mandated by USB spec. Seems like we need to patch > f_uac2.c. Can you check if setting the IN endpoint as implicit feedback > data is enough? Just tried your proposed patches on 4.15.1 (with an RPi Zero) and with g_audio, unfortunately there is no change. Device

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
> > Yes, but that isn't the issue AFAIU ? In the USB 2.0 standard related > > to synchronization > > (http://sdphca.ucsd.edu/lab_equip_manuals/usb_20.pdf chapter 5.12.4), > > an isochronous OUT ep with asynchronous synchronization is *required* > > (at least by Microsoft) to have a feedback IN ep,

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Felipe Balbi
Hi, Robert Bielik writes: >> > It seems such a feedback endpoint is now required by the standard: >> > "The USB 2.0 specification states that if isochronous OUT data >> > endpoint uses the asynchronous synchronization, an isochronous >> > feedback endpoint is needed."

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
> > It seems such a feedback endpoint is now required by the standard: > > "The USB 2.0 specification states that if isochronous OUT data > > endpoint uses the asynchronous synchronization, an isochronous > > feedback endpoint is needed." > > We actually have both EP IN and EP OUT on the UAC2

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Felipe Balbi
Hi, Robert Bielik writes: >> "Wait, never mind – I recognize that failing status code. usbaudio2.sys is >> complaining that you have an asynchronous data OUT endpoint but it can’t >> find a corresponding feedback endpoint." >> >> Unfortunately I have no idea what that

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
> > > > 4.9 is over a year old, can you try 4.14, or even better yet, 4.15? Just to confirm, I've tried with 4.14.18 (latest from https://github.com/raspberrypi/firmware), and the problem remains. Regards /R N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h�&��

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
> "Wait, never mind – I recognize that failing status code. usbaudio2.sys is > complaining that you have an asynchronous data OUT endpoint but it can’t > find a corresponding feedback endpoint." > > Unfortunately I have no idea what that means. Yet  , but putting it out there > in case someone

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
> > Kernel version is 4.9.68 (https://github.com/raspberrypi/linux , > > commit d5a3b4cab0c8eacc93e58cfa1bdbd259399caedd), the wTotalLength > > calc error is present in latest version also > > > (https://github.com/torvalds/linux/blob/master/drivers/usb/gadget/functio > n/f_uac2.c#L219) > > 4.9

Re: UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Greg KH
On Fri, Feb 09, 2018 at 03:56:30PM +, Robert Bielik wrote: > > We don't do github pull requests for the kernel, please see the long > > text response in that request for how to do it properly. > > > > Heck, we don't even use github :) > > I know, found it out the hard way  > > > > > >

RE: UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Robert Bielik
> We don't do github pull requests for the kernel, please see the long > text response in that request for how to do it properly. > > Heck, we don't even use github :) I know, found it out the hard way  > > > However, that wasn't enough. The device still isn't loaded properly. > > What do

Re: UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Greg KH
On Fri, Feb 09, 2018 at 03:27:00PM +, Robert Bielik wrote: > Dear all, > > I'm struggling with getting a RPi Zero based UAC2 gadget working with > Windows 10. In the progress I've found a bug in f_uac2.c , where > wTotalLength was calculated erroneously >

UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Robert Bielik
Dear all, I'm struggling with getting a RPi Zero based UAC2 gadget working with Windows 10. In the progress I've found a bug in f_uac2.c , where wTotalLength was calculated erroneously https://github.com/torvalds/linux/pull/515 (I'll be preparing a proper patch submission for this, which I've