On Fri, 2007-01-05 at 08:45 +, Tony Olech wrote:
> Hi Ben,
>
> when I tried to include the file that defined the quirks,
> ELAN's driver failed to compile.
>
> Thanks for your interest in this issue.
>
> ELAN is currently in favour of open source for linux drivers
> of ELAN's hardware, and t
Hi Ben,
when I tried to include the file that defined the quirks,
ELAN's driver failed to compile.
Thanks for your interest in this issue.
ELAN is currently in favour of open source for linux drivers
of ELAN's hardware, and this type of code review can only
strengthen the case. However it would
On Thursday 04 January 2007 3:24 am, Tony Olech wrote:
> Hi Dave,
>
> The problem I was faced with was getting such things as the
> OHCI register layout info, and the solution I came up with
> was using the existing header file. It would certainly be
> better if the definitions pertaining to the O
On Thu, 2007-01-04 at 11:24 +, Tony Olech wrote:
> Hi Dave,
>
> The problem I was faced with was getting such things as the
> OHCI register layout info, and the solution I came up with
> was using the existing header file. It would certainly be
> better if the definitions pertaining to the OHC
Hi Dave,
The problem I was faced with was getting such things as the
OHCI register layout info, and the solution I came up with
was using the existing header file. It would certainly be
better if the definitions pertaining to the OHCI controller
were in a seperate header file and could be included
On Wednesday 03 January 2007 5:53 pm, Benjamin Herrenschmidt wrote:
> On Wed, 2007-01-03 at 17:03 -0800, Andrew Morton wrote:
> > On Thu, 14 Dec 2006 14:13:28 +1100
> > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> >
> > > This patch separates support for big endian MMIO register access
> >
On Wed, 2007-01-03 at 17:03 -0800, Andrew Morton wrote:
> On Thu, 14 Dec 2006 14:13:28 +1100
> Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > This patch separates support for big endian MMIO register access
> > and big endian descriptors in order to support the Toshiba SCC
> > implementat
On Wed, 2007-01-03 at 17:03 -0800, Andrew Morton wrote:
> On Thu, 14 Dec 2006 14:13:28 +1100
> Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > This patch separates support for big endian MMIO register access
> > and big endian descriptors in order to support the Toshiba SCC
> > implementat
On Thu, 14 Dec 2006 14:13:28 +1100
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> This patch separates support for big endian MMIO register access
> and big endian descriptors in order to support the Toshiba SCC
> implementation which has big endian registers but little endian
> in-memory des
Benjamin Herrenschmidt wrote:
> This patch separates support for big endian MMIO register access
> and big endian descriptors in order to support the Toshiba SCC
> implementation which has big endian registers but little endian
> in-memory descriptors.
>
> It simplifies the access functions a bit
This patch separates support for big endian MMIO register access
and big endian descriptors in order to support the Toshiba SCC
implementation which has big endian registers but little endian
in-memory descriptors.
It simplifies the access functions a bit in ohci.h while at it.
Signed-off-by: Ben
This patch separates support for big endian MMIO register access
and big endian descriptors in order to support the Toshiba SCC
implementation which has big endian registers but little endian
in-memory descriptors.
It simplifies the access functions a bit in ohci.h while at it.
Signed-off-by: Ben
On Tuesday 12 December 2006 1:32 pm, Benjamin Herrenschmidt wrote:
>
> > > -static inline unsigned int ohci_readl (const struct ohci_hcd *ohci,
> > > - __hc32 __iomem * regs)
> > > +static inline unsigned int _ohci_readl (const struct ohci_hcd *ohci,
> > -static inline unsigned int ohci_readl (const struct ohci_hcd *ohci,
> > - __hc32 __iomem * regs)
> > +static inline unsigned int _ohci_readl (const struct ohci_hcd *ohci,
> > + __hc32 __iomem * regs)
>
> Hmm,
> ... assuming you fix the OHCI_BIG_ENDIAN_MMIO typo and #ifdef,
> and other stuff as noted below. And that you sanity checked it
> on some x86 PC, since I didn't make time for that and since we'd
> all be unhappy if there were some goof in this area. ;)
I'll try to find an x86 box to boot it o
On Saturday 09 December 2006 12:26 am, Benjamin Herrenschmidt wrote:
> This patch separates support for big endian MMIO register access
> and big endian descriptors in order to support the Toshiba SCC
> implementation which has big endian registers but little endian
> in-memory descriptors.
>
> It
Benjamin Herrenschmidt wrote:
> On Sun, 2006-12-10 at 08:29 +1100, Benjamin Herrenschmidt wrote:
>> > + ohci->flags |= OHCI_BIG_ENDIAN_MMIO;
>>
>> ANd that should be OHCI_QUIRK_BE_MMIO. Damn, I was sure I test built it,
>> but I screwed with my .config ...
>>
>> David, I'll send a new patch, but
On Sun, 2006-12-10 at 08:29 +1100, Benjamin Herrenschmidt wrote:
> > + ohci->flags |= OHCI_BIG_ENDIAN_MMIO;
>
> ANd that should be OHCI_QUIRK_BE_MMIO. Damn, I was sure I test built it,
> but I screwed with my .config ...
>
> David, I'll send a new patch, but not before you send me some feedback
> + ohci->flags |= OHCI_BIG_ENDIAN_MMIO;
ANd that should be OHCI_QUIRK_BE_MMIO. Damn, I was sure I test built it,
but I screwed with my .config ...
David, I'll send a new patch, but not before you send me some feedback
in case there are other things to fix.
Cheers,
Ben.
-
This patch separates support for big endian MMIO register access
and big endian descriptors in order to support the Toshiba SCC
implementation which has big endian registers but little endian
in-memory descriptors.
It simplifies the access functions a bit in ohci.h while at it.
Signed-off-by: Ben
This patch separates support for big endian MMIO register access
and big endian descriptors in order to support the Toshiba SCC
implementation which has big endian registers but little endian
in-memory descriptors.
It simplifies the access functions a bit in ohci.h while at it.
Signed-off-by: Ben
21 matches
Mail list logo
