[linux-usb-devel] Re: [PATCH] Trivial Kconfig change

2003-02-18 Thread Greg KH
On Tue, Feb 18, 2003 at 11:38:18AM +0100, Duncan Sands wrote: Refer to the module as speedtch rather than speedtch.o. Some brave person stripped such extensions automagically from the rest of the tree after I sent the original help text. Heh, I already edited your last patch to do this before

[linux-usb-devel] Re: [PATCH] speedtouch cleanups

2003-02-18 Thread Greg KH
On Tue, Feb 18, 2003 at 01:17:15PM +0100, Duncan Sands wrote: Grab bag of minor cleanups. Applied, thanks. greg k-h --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf

Re: [linux-usb-devel] death by module unloading

2003-02-18 Thread Greg KH
On Tue, Feb 18, 2003 at 08:59:15AM -0800, David Brownell wrote: Greg KH wrote: Yes, this is a problem, the module can be unloaded and then the completion fuction can be called. How? I don't see it. Unless the driver completely violates basic rules like implementing disconnect

Re: [linux-usb-devel] death by module unloading

2003-02-18 Thread Greg KH
On Tue, Feb 18, 2003 at 12:24:49PM -0500, Johannes Erdfelt wrote: On Tue, Feb 18, 2003, Greg KH [EMAIL PROTECTED] wrote: On Tue, Feb 18, 2003 at 08:59:15AM -0800, David Brownell wrote: Greg KH wrote: Yes, this is a problem, the module can be unloaded and then the completion fuction

Re: [linux-usb-devel] death by module unloading

2003-02-18 Thread Greg KH
On Tue, Feb 18, 2003 at 12:49:43PM -0500, Johannes Erdfelt wrote: On Tue, Feb 18, 2003, Greg KH [EMAIL PROTECTED] wrote: On Tue, Feb 18, 2003 at 12:24:49PM -0500, Johannes Erdfelt wrote: On Tue, Feb 18, 2003, Greg KH [EMAIL PROTECTED] wrote: On Tue, Feb 18, 2003 at 08:59:15AM -0800

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.17, 2003/02/17 10:39:56-08:00, [EMAIL PROTECTED] [PATCH] USB: trivial help texts for drivers/usb/serial/Kconfig Here are some trivial help texts for drivers/usb/serial/Kconfig. diff -Nru a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig ---

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.2, 2003/02/16 09:37:27-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: Even more trivial speedtouch change Rename UDSL_RECEIVE_BUFFER_SIZE to UDSL_RCV_BUFFER_SIZE. diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c --- a/drivers/usb/misc/speedtouch.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.18, 2003/02/17 10:40:17-08:00, [EMAIL PROTECTED] [PATCH] USB: sg_complete() warning downgrade An error check would wrongly fire after usb_sg_cancel(). This patch prevents the misfire, and also makes the diagnostic (a) more useful, (b) less scarey. diff -Nru

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.19, 2003/02/17 10:40:43-08:00, [EMAIL PROTECTED] [PATCH] USB: USB keyboard works after reboot (ehci-hcd) This resolves a problem caused by reboot not actually doing a clean shutdown of drivers. It uses a reboot notifier to make sure that typical BIOS code (using the USB 1.1

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.925.62.9, 2003/02/07 17:22:54+11:00, [EMAIL PROTECTED] [PATCH] USB: kaweth fix this is the length calculation fix against 2.5. - fix DHCP problem with correct length calculation Thanks to Oliver Kurth diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c ---

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.22, 2003/02/18 09:22:09-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: speedtouch stability fix fix It's usually considered stupid to stuff-up like this. However, for this once we'll just call it inspired. diff -Nru a/drivers/usb/misc/speedtouch.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.25, 2003/02/18 16:03:32-08:00, [EMAIL PROTECTED] [PATCH] USB serial: fix locking logic This gets rid of the port semaphore, and the serialization caused by that, and replaces it with the proper reference counting logic for the usb serial object. diff -Nru

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.8, 2003/02/16 09:39:39-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: new speedtouch send path Finally, here is the new code for sending packets. The ATM layer passes us a skb containing the packet to be sent. We need to encode that as AAL5, and then encapsulate the result

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1106, 2003/02/18 16:27:45-08:00, [EMAIL PROTECTED] [PATCH] USB: added sched.h to usb.h Thanks to Matt Wilcox for the info. diff -Nru a/include/linux/usb.h b/include/linux/usb.h --- a/include/linux/usb.h Tue Feb 18 16:35:55 2003 +++ b/include/linux/usb.h Tue Feb 18

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.12, 2003/02/17 10:09:22-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: Fix speedtouch maxi race Instead of trying to close all ATM connections in the USB disconnect routine, just notify the ATM layer that the ATM device should go down when the last connection is closed.

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.16, 2003/02/17 10:14:43-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: minor speedtouch changes Add some comments and debug info. diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c --- a/drivers/usb/misc/speedtouch.c Tue Feb 18 16:39:28 2003 +++

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.9, 2003/02/16 09:40:01-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: speedtouch dead code elimination Eliminate a pile of code that isn't used anymore now the new send code is in place, and make some cosmetic changes. diff -Nru a/drivers/usb/misc/atmsar.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.5, 2003/02/16 09:38:32-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: expose crc defs to speedtouch Expose some CRC definitions in atmsar.h (for use by speedtouch.c). diff -Nru a/drivers/usb/misc/atmsar.c b/drivers/usb/misc/atmsar.c --- a/drivers/usb/misc/atmsar.c Tue Feb

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.11, 2003/02/17 10:09:00-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: fix speedtouch micro race The disconnect routine counts the completed_receivers/spare_senders list to see if the completion handler has finished. It then kills the tasklet. However the tasklet was being

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.925.62.2, 2003/02/07 16:39:47+11:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: trivial speedtouch changes Get rid of some unused #defines. diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c --- a/drivers/usb/misc/speedtouch.c Tue Feb 18 16:46:17 2003 +++

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.925.62.7, 2003/02/07 17:21:51+11:00, [EMAIL PROTECTED] [PATCH] usb_get_driver_np() gives wrong driver name (usb_mouse) On Thu, Feb 06, 2003, Johannes Erdfelt [EMAIL PROTECTED] wrote: On Thu, Feb 06, 2003, Boris Duerner [EMAIL PROTECTED] wrote: I use the usb_get_driver_np()

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.20, 2003/02/17 10:41:09-08:00, [EMAIL PROTECTED] [PATCH] USB: ov511 bugfixes/cleanup This patch updates the 2.5 ov511 driver to version 1.64. This fixes some longstanding bugs and cleans the code up a bit. Changes: - Eliminate remaining uses of sleep_on() - Remove

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.15, 2003/02/17 10:13:56-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: speedtouch 330 support Differences: speedtouch 330 vs the older speedtouch USB: Vendor and ProdID: no difference (!) Rev: 2.00 vs 0.00 SerialNumber: 0090D0xx, xx larger for 330 Interface 1, Alt 2:

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1107, 2003/02/18 16:33:05-08:00, [EMAIL PROTECTED] USB: usbnet driver also needs the crc32 code. Thanks to David Brownell for this. diff -Nru a/drivers/usb/Makefile.lib b/drivers/usb/Makefile.lib --- a/drivers/usb/Makefile.lib Tue Feb 18 16:35:37 2003 +++

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.4, 2003/02/16 09:38:10-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: infrastructure for new speedtouch send path Put in infrastructure for the new send code. The only code changes are in the udsl_usb_probe and udsl_usb_disconnect functions, changed to initialize/finalize

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.925.62.5, 2003/02/07 16:54:22+11:00, [EMAIL PROTECTED] [PATCH] USB: pegasus update (2.5) These are very small and similar csets against both usb-2.4 and usb-2.5 trees. One part of them is adding a missing flag to one of the device descriptors. The other part is fixing a vendor name

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.925.62.8, 2003/02/07 17:22:22+11:00, [EMAIL PROTECTED] [PATCH] USB: added device id for kaweth - additional device id diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c --- a/drivers/usb/net/kaweth.c Tue Feb 18 16:44:47 2003 +++ b/drivers/usb/net/kaweth.c Tue Feb

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.10, 2003/02/16 09:41:02-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: Missing speedtouch bits Let's not forget to update the ATM transmission statistics! And let's not pretend to support AAL0 when we don't. diff -Nru a/drivers/usb/misc/speedtouch.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.23, 2003/02/18 09:29:42-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: speedtouch cleanups Grab bag of minor cleanups. diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c --- a/drivers/usb/misc/speedtouch.c Tue Feb 18 16:37:25 2003 +++

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
ChangeSet 1.1043.1.7, 2003/02/16 09:39:17-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: on-the-fly AAL5/ATM encoding for speedtouch Add a new encoding routine, udsl_write_cell, which extracts one ATM cell from a skb and writes it, doing the AAL5/ATM encoding on the fly. To make this

[linux-usb-devel] [BK PATCH] USB changes for 2.5.62

2003-02-18 Thread Greg KH
, [EMAIL PROTECTED] [PATCH] Re: Griffin Powermate: Aluminum Greg KH says please send 2.5 patch. drivers/usb/input/Kconfig |9 - 1 files changed, 4 insertions(+), 5 deletions(-) -- [EMAIL PROTECTED], 2003-02-07 16:54:22+11:00, [EMAIL PROTECTED] [PATCH] USB: pegasus update

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 09:29:37AM +0100, Duncan Sands wrote: @@ -853,6 +854,10 @@ usbfs_remove_device(dev); } device_unregister(dev-dev); + + /* mark the device as not present so any further urb submissions for +* this device will fail. */ + dev-present

Re: [linux-usb-devel] Re: usb ftdi_sio kernel 2.4.20 panic

2003-02-19 Thread Greg KH
On Tue, Feb 18, 2003 at 10:32:20AM +0100, Thomas Jarosch wrote: ftdi_sio.c: write request of 0 bytes Like I posted yesterday on the list, something in the usbserial layer or some other upstream layer seems screwed up. Works for me :) Seriously, something is wrong in the

Re: [linux-usb-devel] ftdi_sio: Losing/falsifying data during write

2003-02-19 Thread Greg KH
On Tue, Feb 18, 2003 at 09:56:55AM +0100, Thomas Jarosch wrote: Okay, I've collected more information: I commented out the ftdi_write/ftdi_read function pointers in ftdi_sio.c, so that the generic handler of usbserial handles the write calls. Attached you'll find the debug log of

Re: [linux-usb-devel] Re: [Ftdi-usb-sio-devel] OOPS with beta drivers 1.3.0

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 11:53:24PM +, Alan Cox wrote: On Wed, 2003-02-19 at 19:51, Ian Abbott wrote: It looks like the driver has managed to fill up a buffer with incoming data and pass it to the tty layer before the tty layer even knows whether opening the serial port was successful

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 05:44:54PM -0500, Johannes Erdfelt wrote: On Wed, Feb 19, 2003, Greg KH [EMAIL PROTECTED] wrote: On Wed, Feb 19, 2003 at 02:21:11PM -0800, David Brownell wrote: Greg KH wrote: Hm, maybe we should mark the device gone at the beginning of this call, or right

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 07:12:58PM -0500, Johannes Erdfelt wrote: Hm, uhci-hcd oopses if this happens :) I could reproduce this very easily without that urb change but with the usb-serial changes. Ahh, and that brings us back to the original patch. If so, it could be a bug in uhci-hcd.

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 07:33:57PM -0500, Johannes Erdfelt wrote: But what about drivers that fire off urbs and don't keep a pointer to them around? They don't know if all of their urbs are completed or not, nor should they really care. The visor driver is one good example of this.

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 07:57:29PM -0500, Johannes Erdfelt wrote: Heh. No, urbs are referenced counted now. So a driver can do the following just fine: - usb_alloc_urb() - urb data = kmalloc() - usb_submit_urb() - usb_free_urb() Then later in the completion

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 07:54:13PM -0500, Johannes Erdfelt wrote: On Thu, Feb 20, 2003, Oliver Neukum [EMAIL PROTECTED] wrote: Does the existing serial driver submit URBs after the device is physically removed? (Like if an application still has an fd open when the device was removed)

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 04:56:28PM -0800, David Brownell wrote: Greg KH wrote: On Wed, Feb 19, 2003 at 02:21:11PM -0800, David Brownell wrote: Greg KH wrote: Hm, maybe we should mark the device gone at the beginning of this call, or right at the time we realize it's gone in the hub driver

Re: [linux-usb-devel] Re: [Ftdi-usb-sio-devel] OOPS with beta drivers 1.3.0

2003-02-19 Thread Greg KH
On Thu, Feb 20, 2003 at 02:01:01AM +, Alan Cox wrote: On Wed, 2003-02-19 at 23:07, Greg KH wrote: On Wed, Feb 19, 2003 at 11:53:24PM +, Alan Cox wrote: On Wed, 2003-02-19 at 19:51, Ian Abbott wrote: It looks like the driver has managed to fill up a buffer with incoming data

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 08:05:17PM -0500, Johannes Erdfelt wrote: Yes, so it does need to keep track of them, but only a count I guess. Ah, how about the module reference count then, it's extreemly lightweight and SMP safe :) That way every driver that wants to do this doesn't have to, as the

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Thu, Feb 20, 2003 at 02:08:44AM +0100, Oliver Neukum wrote: To beat that we'd need an awful amount of refcounting and locking. No, a simple module reference count here will fix everything just fine. thanks, greg k-h --- This SF.net email

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Thu, Feb 20, 2003 at 02:13:29AM +0100, Oliver Neukum wrote: Am Donnerstag, 20. Februar 2003 01:47 schrieb Greg KH: On Thu, Feb 20, 2003 at 01:45:09AM +0100, Oliver Neukum wrote: Besides, what are you to do if incrementing a usage count in usb_submit_urb() fails ? By definition you

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Thu, Feb 20, 2003 at 02:25:48AM +0100, Oliver Neukum wrote: What do you do on disconnect() ? How do you make sure that a completion handler will eventually be called if nobody's there to unlink it. Nothing different in disconnect(). Remember that's different from module_exit(), and

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-19 Thread Greg KH
On Wed, Feb 19, 2003 at 05:08:14PM -0800, David Brownell wrote: But what about drivers that fire off urbs and don't keep a pointer to them around? They don't know if all of their urbs are completed or not, nor should they really care. The visor driver is one good example of this. It

[linux-usb-devel] Re: [PATCH] USB changes for 2.4.21-pre4

2003-02-20 Thread Greg KH
ChangeSet 1.999, 2003/02/20 11:12:04-08:00, [EMAIL PROTECTED] [PATCH] spelling fix for drivers_usb_usbnet.c Hi This fixes iPaq to iPAQ. Carsten diff -Nru a/drivers/usb/usbnet.c b/drivers/usb/usbnet.c --- a/drivers/usb/usbnet.c Thu Feb 20 12:07:00 2003 +++ b/drivers/usb/usbnet.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.4.21-pre4

2003-02-20 Thread Greg KH
ChangeSet 1.1002, 2003/02/20 11:12:35-08:00, [EMAIL PROTECTED] [PATCH] USB: new device id for kaweth - additional device ID diff -Nru a/drivers/usb/kaweth.c b/drivers/usb/kaweth.c --- a/drivers/usb/kaweth.c Thu Feb 20 12:06:54 2003 +++ b/drivers/usb/kaweth.c Thu Feb 20 12:06:54

[linux-usb-devel] Re: [PATCH] USB changes for 2.4.21-pre4

2003-02-20 Thread Greg KH
ChangeSet 1.1007, 2003/02/20 12:03:09-08:00, [EMAIL PROTECTED] [PATCH] USB: USB-MIDI support for Roland SC8820 Please find attached a patch against kernel 2.4.20 which adds support for the Roland SC8820 to the USB MIDI driver. It just adds another ID to the list of supported devices. Although

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 09:36:31AM +0100, Thomas Jarosch wrote: Also, you'll need to make the necessary 64 bit thunking layer if somehow you convince me :) I thought using the _IO macros should do it or did I miss something? No, those macros don't do it. If you have a

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 03:55:14PM +0100, Thomas Jarosch wrote: No, those macros don't do it. If you have a strong stomach, look at: arch/sparc64/kernel/ioctl32.c for just one of the arch specific files that you will have to modify. Make sure you get them all, or you will have

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 12:34:13PM +0100, Duncan Sands wrote: I get an oops on shutdown with 2.4.20 (speedtouch driver). Here is what happens: probe method called: I take a reference to the usb device with usb_inc_dev_use (machine shutting down - shutdown of usb subsystem) disconnect

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 05:53:24PM +0100, Duncan Sands wrote: What's the backtrace from the oops? usb_free_dev+19/3c Hm, wonder if the bus has been cleaned up by the shutdown sequence first. That might cause this. greg k-h --- This

Re: [linux-usb-devel] Yet another unusual_devs.h member.

2003-02-21 Thread Greg KH
On Fri, Jan 24, 2003 at 06:13:24PM -0500, Pete Zaitcev wrote: Matt Greg, would you be so kind to take this: Applied, thanks. greg k-h --- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most comprehensive and

[linux-usb-devel] Re: [2.5 bkpatch] ipaq.c: add ids for fujitsu loox

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 11:26:03AM +0530, V Ganesh wrote: hi greg, the fujitsu loox works with the ipaq driver. ids added. Applied, thanks. greg k-h --- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most

Re: [linux-usb-devel] Update: USB gadget API [1 of 3]

2003-02-21 Thread Greg KH
On Fri, Feb 07, 2003 at 09:21:16AM -0800, David Brownell wrote: In late November I posted a draft of a gadget API, which would drive the device-side USB controller hardware as more of those systems grew smart enough to use Linux inside. This is starting to look good, thanks a lot for doing

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 10:04:14PM +0100, Thomas Jarosch wrote: This is a patch against the ftdi_sio 1.3.0 driver + interim patch. The new driver should be out soon... Can you post it not compressed so we can read it? thanks, greg k-h ---

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-22 Thread Greg KH
On Sun, Feb 23, 2003 at 12:36:02AM +0100, Duncan Sands wrote: The philosophy is often called programming by contract. And the contract is: usbcore agrees to work with your driver and do everything right, if your driver agrees to do a few specific things. One of those specific things is

Re: [linux-usb-devel] Discussion of problems in usb-skeleton.c

2003-02-22 Thread Greg KH
On Fri, Feb 21, 2003 at 01:12:47PM -0500, Alan Stern wrote: I noticed that usb-skeleton.c still has a TODO entry referring to a race involving urb-status, so I took a closer look. Fixing that race will be easy, and I will be happy to submit a patch for it. But there are two other problems,

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-22 Thread Greg KH
On Sat, Feb 22, 2003 at 07:13:26PM -0500, Johannes Erdfelt wrote: The intent was for 2.4 to have this same contract. Having a reference count on the device structure is pointless if that weren't the case. Yes, and because of this, the driver model changes in 2.5 were very easy, thanks for

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-22 Thread Greg KH
On Sat, Feb 22, 2003 at 06:59:54PM -0800, David Brownell wrote: Greg KH wrote: On Sun, Feb 23, 2003 at 12:36:02AM +0100, Duncan Sands wrote: The philosophy is often called programming by contract. And the contract is: usbcore agrees to work with your driver and do everything right

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-24 Thread Greg KH
On Mon, Feb 24, 2003 at 12:26:30PM +0100, Duncan Sands wrote: Hi Greg, I went and got a new one for your debugging pleasure! It is the dev-bus-op-deallocate(dev) that kills things. What happens seems to be this: disconnect is called on the speedtch driver, then uhci is unloaded, then

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-25 Thread Greg KH
On Tue, Feb 25, 2003 at 08:42:10AM +0100, Duncan Sands wrote: The other way is to follow Dave's contract. Heh, or we could make lives easier for driver writers by not requiring such a complicated contract that almost none of the current drivers follow :) thanks, greg k-h

[linux-usb-devel] Re: [PATCH 2.5.63] USB: New vendor/product ids for scanner driver

2003-02-25 Thread Greg KH
On Tue, Feb 25, 2003 at 05:47:06PM +0100, Henning Meier-Geinitz wrote: Hi, This patch adds vendor/product ids for Artec, Avision, Brother, Medion, Primax, Prolink, Fujitsu, Plustek, and SYSCAN scanners. Applied, thanks. greg k-h P.S: - * Driver for USB Scanners (linux-2.5.60) + * Driver

[linux-usb-devel] Re: [patch 2.5.62+] ohci: registers sysfs file

2003-02-25 Thread Greg KH
On Mon, Feb 24, 2003 at 12:31:58PM -0800, David Brownell wrote: Hi, This is a slightly cleaned up version of Kevin's patch to add a registers sysfs debug file. Minor style and whitespace fixups, prints the other register, resolved config/build issues (minor). It also has two minor

[linux-usb-devel] Re: [patch 2.5.62+] ehci-hcd, partial VIA workaround

2003-02-25 Thread Greg KH
On Mon, Feb 24, 2003 at 12:57:41PM -0800, David Brownell wrote: This patch resolves a FIXME, which happens to make many of the VIA problems act significantly less severe. The change defers unlinking any QH that just became idle, since it's not unlikely it'll be used again before many

[linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-25 Thread Greg KH
On Tue, Feb 25, 2003 at 05:51:42PM +0100, Henning Meier-Geinitz wrote: Hi, Avoid crashing when read/write/ioctl is called after disconnecting the device. Keep scn until the device is closed and check scn-present in read/write/ioctl. Ick, no, I don't like this. I think the scanner driver

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 03:10:41PM +0100, Henning Meier-Geinitz wrote: Anyway, maybe add a line of warning to the dynamic minors help in Kconfig? What would that warning say? thanks, greg k-h --- This SF.net email is sponsored by:

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Tue, Feb 25, 2003 at 10:54:09PM +0100, Oliver Neukum wrote: Am Dienstag, 25. Februar 2003 22:22 schrieb Henning Meier-Geinitz: Hi, On Tue, Feb 25, 2003 at 08:05:11PM +0100, Oliver Neukum wrote: If I load the kernel USB driver, the scanner is detected by it, but accessing

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 02:02:05PM +0100, Henning Meier-Geinitz wrote: Hi, On Tue, Feb 25, 2003 at 01:22:10PM -0800, Greg KH wrote: Ick, no, I don't like this. I think the scanner driver can actually get rid of all of these horrible locks to handle the disconnect/close mess by just

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 08:16:05PM +, Alan Cox wrote: On Wed, 2003-02-26 at 18:24, Greg KH wrote: That's the reason it doesn't work. You need hotplug scripts that make the device node. Unfortunately that's a race that causes insecurity. Not true at all. What's the race? You

[linux-usb-devel] Re: [PATCH] USB speedtouch: better proc info

2003-02-26 Thread Greg KH
On Mon, Feb 24, 2003 at 10:58:51AM +0100, Duncan Sands wrote: Output the correct device name, show the state of the device (for debugging) and of the ADSL line (anyone want to write a graphical utility to show this, like under windows?). We no longer consult the usb_device struct in

Re: [linux-usb-devel] Re: Trivial patch for usb.h

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 04:32:52PM -0500, Alan Stern wrote: On Wed, 26 Feb 2003, David Brownell wrote: Alan Stern wrote: That sounds like you're saying the macros don't belong in usb.h at all. Shall I send in a patch that takes them out? I think that'd be a good solution. Or

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 10:37:30PM +0100, Henning Meier-Geinitz wrote: Unable to handle kernel NULL pointer dereference at virtual address printing eip: c01e1dd7 *pde = Oops: CPU:0 EIP:0060:[c01e1dd7]Not tainted EFLAGS: 00010082 EIP is at

[linux-usb-devel] Re: [PATCH][2.4.17] SL811HS USB HCD

2003-02-27 Thread Greg KH
On Thu, Feb 27, 2003 at 10:59:58AM +0100, engidudu wrote: Hi, In this patch we have - fixed some bugs about NAK and end transaction, - modified the interrupt handler program's flow, - implemented Double Buffering - inserted autoincrement mode in writing transactions Implementing Double

[linux-usb-devel] Re: [PATCH] USB speedtouch: better proc info

2003-02-27 Thread Greg KH
On Thu, Feb 27, 2003 at 09:01:48AM -0800, Greg KH wrote: Ugh, my merge there was messy, that's my fault, sorry. I'll go clean up the merge and see if your patch applies then. Yup, my fault. I've now applied this patch, sorry for jumping to the wrong conclusion. greg k-h

[linux-usb-devel] Re: [PATCH] USB speedtouch: better proc info

2003-02-27 Thread Greg KH
On Thu, Feb 27, 2003 at 10:11:14AM +0100, Duncan Sands wrote: On Wednesday 26 February 2003 23:59, Greg KH wrote: On Mon, Feb 24, 2003 at 10:58:51AM +0100, Duncan Sands wrote: Output the correct device name, show the state of the device (for debugging) and of the ADSL line (anyone want

[linux-usb-devel] Re: [PATCH][2.4.17] SL811HS USB HCD

2003-02-27 Thread Greg KH
On Thu, Feb 27, 2003 at 06:33:25PM +0100, engidudu wrote: sorry, we send you the path in attach and we hope it will work better. Thanks, this patch is much better, it's against a very old kernel version (2.4.17). The latest kernel already has a version of this driver and I can't diff between

Re: [linux-usb-devel] Problem with large writes to FTDI USB serial converter and alternate UHCI driver

2003-02-28 Thread Greg KH
On Fri, Feb 28, 2003 at 03:44:11PM +, Ian Abbott wrote: I noticed a problem using version 1.3.1 of the ftdi_sio driver http://prdownloads.sourceforge.net/ftdi-usb-sio/ftdi_sio-1.3.1.tar.gz?download aside to the people on the ftdi-usb-sio-devel list Any reason why you haven't been sending

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-28 Thread Greg KH
On Thu, Feb 27, 2003 at 11:15:34AM +0100, Henning Meier-Geinitz wrote: Hi, On Wed, Feb 26, 2003 at 03:12:03PM -0800, Greg KH wrote: On Wed, Feb 26, 2003 at 10:37:30PM +0100, Henning Meier-Geinitz wrote: Unable to handle kernel NULL pointer dereference at virtual address

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-28 Thread Greg KH
On Fri, Feb 28, 2003 at 09:48:03AM -0800, David Brownell wrote: The crash doesn't happen if I move back the irq unlink from destroy_scanner to disconnect_scanner: Which points at the ohci driver not allowing usb_unlink_urb() to be called after the device is disconnected. David, is this

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-28 Thread Greg KH
On Fri, Feb 28, 2003 at 12:25:42PM -0800, David Brownell wrote: Which points at the ohci driver not allowing usb_unlink_urb() to be called after the device is disconnected. David, is this true? Certainly. disconnect() is in charge of doing such unlinks. But we shouldn't oops if

Re: [linux-usb-devel] [PATCH] rio500 typo

2003-02-28 Thread Greg KH
On Wed, Feb 26, 2003 at 06:34:49PM +, John Levon wrote: I believe is meant here, but I cannot test it. This is against 2.5.63 Applied, thanks. greg k-h --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven.

Re: [linux-usb-devel] [PATCH] usbcld typo

2003-02-28 Thread Greg KH
On Wed, Feb 26, 2003 at 06:35:35PM +, John Levon wrote: Against 2.5.63. I believe is meant here, not . Applied, thanks. greg k-h --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.19, 2003/02/25 11:41:18-08:00, [EMAIL PROTECTED] [PATCH] USB: Fixed generation of devfs names in scanner driver This patch fixes the generation of devfs names if dynamic minors are disabled. drivers/usb/image/scanner.c |3 ++- 1 files changed, 2 insertions(+), 1

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.4, 2003/02/20 10:18:03-08:00, [EMAIL PROTECTED] [PATCH] USB: usbtest checks for in-order completions This makes test 10 verify that completions are returned in-order, resolving a FIXME. OHCI and EHCI do, but UHCI doesn't. (*) That simplified a cleanup of the queue fault

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.21, 2003/02/25 16:07:43-08:00, [EMAIL PROTECTED] [PATCH] USB: fixed potential races in kl5kusb105.c now that there's no locks in the usb-serial core drivers/usb/serial/kl5kusb105.c | 69 ++-- 1 files changed, 45 insertions(+), 24

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.10, 2003/02/21 09:17:40-08:00, [EMAIL PROTECTED] [PATCH] USB: USB-MIDI support for Roland SC8820 drivers/usb/class/usb-midi.h |8 1 files changed, 8 insertions(+) diff -Nru a/drivers/usb/class/usb-midi.h b/drivers/usb/class/usb-midi.h ---

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.22, 2003/02/25 16:10:13-08:00, [EMAIL PROTECTED] [PATCH] USB: Small patch Here's a small patch to make your tree in sync with mine. Somehow, a line of comment got lost somewhere. drivers/usb/storage/unusual_devs.h |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-)

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1087.1.2, 2003/02/26 16:15:42-08:00, [EMAIL PROTECTED] [PATCH] Trivial patch for usb.h The usb_snddefctrl and usb_rcvdefctrl macros are wrong. This hasn't shown up until now because usb_rcvdefctrl isn't used anywhere at all, and usb_snddefctrl is used exactly once (in core/usb.c).

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1087.1.4, 2003/02/27 09:16:13-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: better proc info Output the correct device name, show the state of the device (for debugging) and of the ADSL line (anyone want to write a graphical utility to show this, like under windows?). We no

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.14, 2003/02/25 11:12:34-08:00, [EMAIL PROTECTED] [PATCH] USB: fix potential races in mct_u232 now that there's no locks in the usb-serial core. drivers/usb/serial/mct_u232.c | 106 ++ 1 files changed, 76 insertions(+), 30

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1117.2.3, 2003/02/28 13:34:46-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: be firm when disconnected Just say -ENODEV drivers/usb/misc/speedtouch.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.11, 2003/02/21 17:02:34-08:00, [EMAIL PROTECTED] [PATCH] USB visor: fixed the driver_info cast to the proper type. drivers/usb/serial/visor.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff -Nru a/drivers/usb/serial/visor.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1117.2.4, 2003/02/28 13:41:54-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: handle usb_string failure drivers/usb/misc/speedtouch.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1087.1.3, 2003/02/26 16:29:39-08:00, [EMAIL PROTECTED] [PATCH] USB: add support for two new keyspan drivers Thanks to [EMAIL PROTECTED] for helping with this patch. drivers/usb/serial/Kconfig | 12 drivers/usb/serial/keyspan.c | 33 ++

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1117.2.2, 2003/02/28 13:34:06-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: don't race the tasklets drivers/usb/misc/speedtouch.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c ---

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.17, 2003/02/25 11:32:55-08:00, [EMAIL PROTECTED] [PATCH] USB: ehci-hcd, partial VIA workaround This patch resolves a FIXME, which happens to make many of the VIA problems act significantly less severe. The change defers unlinking any QH that just became idle, since it's not

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.63

2003-02-28 Thread Greg KH
ChangeSet 1.1002.3.9, 2003/02/21 09:17:14-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: use USB dbg macro drivers/usb/misc/speedtouch.c | 159 -- 1 files changed, 77 insertions(+), 82 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c

  1   2   3   4   5   6   7   8   9   10   >