[linux-usb-devel] Configuration changes

2003-02-26 Thread Oliver Neukum
Am Mittwoch, 26. Februar 2003 05:18 schrieb David Brownell: Yes, a configuration change is: 1. Lock device 2. Disconnect all interfaces 3. Send control message 4. Unlock device 5. Probe all the device's interfaces To a driver changing a configuration is an unplug, replug cycle.

[linux-usb-devel] Re: [PATCH] USB speedtouch: better proc info

2003-02-26 Thread Oliver Neukum
Yes, but I think that you should notify the network layer too. I see no reason any network driver shouldn't report this directly. There's nothing specific to ATM in losing signal. It's purely physical thing low level drivers should deal with. I can't notify the network layer because

[linux-usb-devel] Re: usb-storage fails to detect all luns after 2.4.19

2003-02-26 Thread Oliver Graf
Hi! On Thu, Feb 20, 2003 at 10:30:37PM +0100, Oliver Graf wrote: The problem: a multi device usb card reader is correctly detected with its four subdevices with kernel 2.4.19(-acX). But any patch after this fails to detect the subdevices. Verbose output with 2.4.19-ac4 shows: usb-storage:

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Henning Meier-Geinitz
Hi, On Tue, Feb 25, 2003 at 01:22:10PM -0800, Greg KH wrote: Ick, no, I don't like this. I think the scanner driver can actually get rid of all of these horrible locks to handle the disconnect/close mess by just using a reference count. To back this up, here's a patch that I just wrote for

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Henning Meier-Geinitz
Hi, On Tue, Feb 25, 2003 at 10:54:09PM +0100, Oliver Neukum wrote: Am Dienstag, 25. Februar 2003 22:22 schrieb Henning Meier-Geinitz: With dynamic minors: Feb 25 12:07:04 hmg1 kernel: drivers/usb/core/file.c: asking for 1 minors, starting at 0 Feb 25 12:07:04 hmg1 kernel:

Re: [linux-usb-devel] Re: usb-storage fails to detect all luns after2.4.19

2003-02-26 Thread Alan Stern
On Wed, 26 Feb 2003, Oliver Graf wrote: Hi! On Thu, Feb 20, 2003 at 10:30:37PM +0100, Oliver Graf wrote: The problem: a multi device usb card reader is correctly detected with its four subdevices with kernel 2.4.19(-acX). But any patch after this fails to detect the subdevices.

Re: [linux-usb-devel] Discussion of problems in usb-skeleton.c

2003-02-26 Thread Alan Stern
On Tue, 25 Feb 2003, David Brownell wrote: Alan Stern wrote: Heck, I've barely had a chance to write it, let alone test it. In fact, it seemed clear that nobody had tried any testing recently. One of the minor bugs I fixed was a subroutine call that passed a structure rather than a

Re: [linux-usb-devel] Discussion of problems in usb-skeleton.c

2003-02-26 Thread Alan Stern
On Wed, 26 Feb 2003, Alan Stern wrote: As it turns out, this still generates a compiler warning. There's a mistake in the min() and max() macros in include/linux/kernel.h. I will post something about that on the linux kernel mailing list. I spoke too soon (don't you just hate it when that

Re: [linux-usb-devel] Re: usb-storage fails to detect all luns after 2.4.19

2003-02-26 Thread Matthew Dharm
That could be the problem... I've also been meaning to take a look at the clear_halt code in 2.4.xx -- there was a 2.5 bug where we couldn't clear endpoint halts because of a change in the core logic. Matt On Wed, Feb 26, 2003 at 10:03:41AM -0500, Alan Stern wrote: On Wed, 26 Feb 2003, Oliver

[linux-usb-devel] confirm 184444

2003-02-26 Thread Peter Schildmann
confirm 18 __ Jetzt 52 verschiedene Briefpapiere fur Ihre E-Mails bei WEB.DE FreeMail - http://freemail.web.de/features/?mc=021140 --- This SF.net email is

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 03:10:41PM +0100, Henning Meier-Geinitz wrote: Anyway, maybe add a line of warning to the dynamic minors help in Kconfig? What would that warning say? thanks, greg k-h --- This SF.net email is sponsored by:

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Tue, Feb 25, 2003 at 10:54:09PM +0100, Oliver Neukum wrote: Am Dienstag, 25. Februar 2003 22:22 schrieb Henning Meier-Geinitz: Hi, On Tue, Feb 25, 2003 at 08:05:11PM +0100, Oliver Neukum wrote: If I load the kernel USB driver, the scanner is detected by it, but accessing

[linux-usb-devel] [PATCH] rio500 typo

2003-02-26 Thread John Levon
I believe is meant here, but I cannot test it. This is against 2.5.63 regards john --- linux-linus/drivers/usb/misc/rio500.c 2003-01-10 21:12:07.0 + +++ linux/drivers/usb/misc/rio500.c 2003-02-26 18:36:34.0 + @@ -332,7 +332,7 @@

[linux-usb-devel] [PATCH] usbcld typo

2003-02-26 Thread John Levon
Against 2.5.63. I believe is meant here, not . regards john --- linux-linus/drivers/usb/misc/usblcd.c 2003-01-03 03:06:44.0 + +++ linux/drivers/usb/misc/usblcd.c 2003-02-26 18:36:59.0 + @@ -153,7 +153,7 @@ }

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 02:02:05PM +0100, Henning Meier-Geinitz wrote: Hi, On Tue, Feb 25, 2003 at 01:22:10PM -0800, Greg KH wrote: Ick, no, I don't like this. I think the scanner driver can actually get rid of all of these horrible locks to handle the disconnect/close mess by just

Re: [linux-usb-devel] Re: usb-storage fails to detect all luns after 2.4.19

2003-02-26 Thread Oliver Graf
Hoi! On Wed, Feb 26, 2003 at 10:03:41AM -0500, Alan Stern wrote: On Wed, 26 Feb 2003, Oliver Graf wrote: On Thu, Feb 20, 2003 at 10:30:37PM +0100, Oliver Graf wrote: I tried to find the parts that changed between the version, but it seems not to be rooted in usb-storage. The call

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Henning Meier-Geinitz
Hi, On Wed, Feb 26, 2003 at 10:25:56AM -0800, Greg KH wrote: On Wed, Feb 26, 2003 at 03:10:41PM +0100, Henning Meier-Geinitz wrote: Anyway, maybe add a line of warning to the dynamic minors help in Kconfig? What would that warning say? Maybe something like: | config

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Oliver Neukum
I did create a device node manually (180/0) for testing. Maybe there was a typo in the mknod command or something like that. Now it works. Same for the libusb trouble. No problems anymore, even with dynamic minors turned on and devfs turned off. Just ignore my report :-) It's more or

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Alan Cox
On Wed, 2003-02-26 at 18:24, Greg KH wrote: That's the reason it doesn't work. You need hotplug scripts that make the device node. Unfortunately that's a race that causes insecurity. Not true at all. What's the race? You issue a minor to someone You create the node securely You set

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 08:16:05PM +, Alan Cox wrote: On Wed, 2003-02-26 at 18:24, Greg KH wrote: That's the reason it doesn't work. You need hotplug scripts that make the device node. Unfortunately that's a race that causes insecurity. Not true at all. What's the race? You

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Alan Cox
On Wed, 2003-02-26 at 19:14, Greg KH wrote: You reboot and assign a different device the id, but how will you clean up the old node ? With /dev being a ramfs that gets recreated every time the machine is rebooted? :) That works, but with a disk based one its horrible because users can

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Oliver Neukum
That's the reason it doesn't work. You need hotplug scripts that make the device node. Unfortunately that's a race that causes insecurity. Not true at all. What's the race? plug in device attach to device node script runs and adjusts permissions - so far so good some time passes device

Re: [linux-usb-devel] Dynamic minors work only with devfs?

2003-02-26 Thread Oliver Neukum
Am Mittwoch, 26. Februar 2003 20:14 schrieb Greg KH: On Wed, Feb 26, 2003 at 08:16:05PM +, Alan Cox wrote: On Wed, 2003-02-26 at 18:24, Greg KH wrote: That's the reason it doesn't work. You need hotplug scripts that make the device node. Unfortunately that's a race that causes

[linux-usb-devel] Trouble with ST5481 ISDN TA

2003-02-26 Thread Peter Schildmann
Hi, recently I brought a ST5481 based ISDN terminal adapter (Typhoon 50456) that works with the st5481_hisax driver. Sometimes I get errors like these: Feb 22 01:33:58 verdi kernel: st5481_b.c: usb_b_out: usb_submit_urb failed,status=-22 Feb 22 01:33:58 verdi kernel: st5481_b.c: usb_b_out:

Re: [linux-usb-devel] Re: Trivial patch for usb.h

2003-02-26 Thread Alan Stern
On Wed, 26 Feb 2003, David Brownell wrote: Alan Stern wrote: That sounds like you're saying the macros don't belong in usb.h at all. Shall I send in a patch that takes them out? I think that'd be a good solution. Or maybe just put them in hcd.h. Here you go. Alan Stern =

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Henning Meier-Geinitz
Hi, On Wed, Feb 26, 2003 at 10:35:05AM -0800, Greg KH wrote: However, it doesn't (yet) solve the real problem: if I disconnect the scanner while the device file is openend and then write to the scanner the kernel crashes. Where does it die? What's the oops output? Actually the crash

[linux-usb-devel] Re: [PATCH] USB speedtouch: better proc info

2003-02-26 Thread Greg KH
On Mon, Feb 24, 2003 at 10:58:51AM +0100, Duncan Sands wrote: Output the correct device name, show the state of the device (for debugging) and of the ADSL line (anyone want to write a graphical utility to show this, like under windows?). We no longer consult the usb_device struct in

Re: [linux-usb-devel] Re: Trivial patch for usb.h

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 04:32:52PM -0500, Alan Stern wrote: On Wed, 26 Feb 2003, David Brownell wrote: Alan Stern wrote: That sounds like you're saying the macros don't belong in usb.h at all. Shall I send in a patch that takes them out? I think that'd be a good solution. Or

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash in read/write/ioctl in scanner driver

2003-02-26 Thread Greg KH
On Wed, Feb 26, 2003 at 10:37:30PM +0100, Henning Meier-Geinitz wrote: Unable to handle kernel NULL pointer dereference at virtual address printing eip: c01e1dd7 *pde = Oops: CPU:0 EIP:0060:[c01e1dd7]Not tainted EFLAGS: 00010082 EIP is at

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.58

2003-02-26 Thread Matthew Dharm
On Wed, Feb 26, 2003 at 03:37:02PM -0800, Mike Anderson wrote: There still are a few things on the to do list, but should not effect the LLDD interface (at least this is the goal). - scsi_request_fn needs a fix for device offline that will handle all request types. -

Re: [linux-usb-devel] Trouble with ST5481 ISDN TA

2003-02-26 Thread David Brownell
Peter Schildmann wrote: recently I brought a ST5481 based ISDN terminal adapter (Typhoon 50456) that works with the st5481_hisax driver. Sometimes I get errors like these: Feb 22 01:33:58 verdi kernel: st5481_b.c: usb_b_out: usb_submit_urb failed,status=-22 Feb 22 01:33:58 verdi kernel:

Re: [linux-usb-devel] Re: [PATCH 2.5.63] USB: Fix crash inread/write/ioctl in scanner driver

2003-02-26 Thread David Brownell
Greg KH wrote: On Wed, Feb 26, 2003 at 10:37:30PM +0100, Henning Meier-Geinitz wrote: Unable to handle kernel NULL pointer dereference at virtual address ... Call Trace: [c01e2c10] ohci_irq+0x130/0x1d8 David, any clues? Only that (as Henning noted) something about your patch caused

[linux-usb-devel] Re: Configuration changes

2003-02-26 Thread David Brownell
Something I want (eventually) to see between steps 2 4 is notifying the hcd to clear each endpoint's configuration data. That state is known to hardware (OHCI and EHCI) so changing it needs hardware synchronization. Interesting. Could you point me at the code in question? The 2.4 OHCI code has

[linux-usb-devel] Some questions about driver development

2003-02-26 Thread Rui Saraiva
Hello. I'm writing a driver for a digital camera (FujiFilm FinePix F601 Zoom) that also works as a webcam. The manufacturer doesn't release any technical specifications (as usual), so I had to reverse engineering the protocol. Using libusb, I've wrote a program that interoperate successfully with

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.58

2003-02-26 Thread Mike Anderson
Matthew, Sorry for the delay in replying (non coding activities are consuming to many hours). Matthew Dharm [EMAIL PROTECTED] wrote: Okay, I see Linus has now accepted this into his tree. It should propagate to the USB development trees soon. One question: What else is

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.58

2003-02-26 Thread Mike Anderson
Matthew Dharm [EMAIL PROTECTED] wrote: Right... but I removed the release() function because that was marked (in the documentation) as only for the old-style drivers. So I'll need to re-introduce it -- but it looks like all it has to do is free some memory. Does that sound about right? Yes