Re: pull-request: iwlwifi firmwares update 2017-02-03

Hi Kyle, On Fri, 2017-02-03 at 10:41 +0200, Luca Coelho wrote: > Hi Kyle, > > We have updated some of our old firmware releases and also added a new > release, version 27, for the newer devices. More details in the tag > description. > > Please pull or let me know if there are any issues. Are

Re: [Patch] NFC: trf7970a:

On Sun, Dec 18, 2016 at 08:07:33PM -0700, Mark Greer wrote: > On Sat, Dec 17, 2016 at 04:19:04PM -0500, Geoff Lansberry wrote: > > Mark, from our consultant: > > > > It isn't important whether the flood script is successful in writing > > or not. The point of it is to force a segfault by making

Re: [Patch] NFC: trf7970a:

I just realized that the linux-nfc is not CC'd so adding it. On Wed, Feb 08, 2017 at 03:53:39PM -0700, Mark Greer wrote: > On Sun, Dec 18, 2016 at 08:07:33PM -0700, Mark Greer wrote: > > On Sat, Dec 17, 2016 at 04:19:04PM -0500, Geoff Lansberry wrote: > > > Mark, from our consultant: > > > > >

Re: Installing driver for Ubuntu 16.04 Intel(R) Wireless WiFi Link 4965AGN

Dear Sedat, Absolutely clear. As you are my primary contact there, you can extent my question to the people there. I much appreciate your assistance. Kind regards, Leopoldo El 06/02/17 a las 07:01, Sedat Dilek escribió: On Sun, Feb 5, 2017 at 6:31 PM, Leopoldo

Re: pull-request: iwlwifi-next 2017-02-08

Luca Coelho writes: > Here's my third and final pull-request intended for v4.11. As I > mentioned before, I concentrated on our bugfix patches this time. More > details in the tag description. > > I have sent this out before, but I didn't get kbuildbot results yet. > Hopefully

Re: [PATCH V2] mtd: bcm47xxsflash: use platform_(set|get)_drvdata

On Mon, Jan 16, 2017 at 05:28:18PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > We have generic place & helpers for storing platform driver data so > there is no reason for using custom priv pointer. > > This allows cleaning up struct bcma_sflash from unneeded fields.

pull-request: iwlwifi-next 2017-02-08

Hi Kalle, Here's my third and final pull-request intended for v4.11. As I mentioned before, I concentrated on our bugfix patches this time. More details in the tag description. I have sent this out before, but I didn't get kbuildbot results yet. Hopefully there will be no issues. I'm sending

[PATCH 17/17] iwlwifi: mvm: avoid exceeding the allowed print length

From: Golan Ben-Ami Divide a mfuart related print so it won't exceed the allowed MAX_MSG_LEN (110 bytes) per print. Fixes: 19f63c531b85 ("iwlwifi: mvm: support v2 of mfuart load notification") Signed-off-by: Golan Ben-Ami Signed-off-by: Luca

Re: ath10k: remove unneeded semicolon

Waldemar Rymarkiewicz wrote: > Remove redundant semicolon after switch statement. > > Signed-off-by: Waldemar Rymarkiewicz Patch applied to ath-next branch of ath.git, thanks. dab55d1083db ath10k: remove unneeded

Re: [PATCH V3 4/9] brcmfmac: add struct brcmf_pub parameter to the __brcmf_err

On 2017-02-08 15:52, Kalle Valo wrote: Rafał Miłecki writes: On 2017-02-08 10:54, Arend Van Spriel wrote: On 2-2-2017 22:33, Rafał Miłecki wrote: From: Rafał Miłecki This will allow getting struct device reference from the passed brcmf_pub for the needs

RE: KASAN+netlink, was: [PATCH] [net-next?] hns: avoid stack overflow with CONFIG_KASAN

> From: Johannes Berg > Sent: 08 February 2017 12:24 ... > Btw, what's causing this to start with? Can't the compiler reuse the > stack places? Only if it realises they've gone out of scope - which probably doesn't happen when the functions are inlined. The address of the parameter can be saved

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you

[PATCH 16/17] iwlwifi: mvm: Fix removal of IGTK

From: Ilan Peer When removing an IGTK, iwl_mvm_send_sta_igtk() was called before station ID was retrieved, so the function was invoked with an invalid station ID. Fix this by first getting the station ID. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=192411

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

From: Florian Fainelli Date: Tue, 7 Feb 2017 15:02:53 -0800 > I'm hoping this doesn't conflict with what's already in net-next... > > David, this should probably go via your tree considering the diffstat. I think you need one more respin. Are you doing an allmodconfig

[PATCH 11/17] iwlwifi: dvm: don't call << operator with a negative value

From: Emmanuel Grumbach In https://bugzilla.kernel.org/show_bug.cgi?id=177341 Bob reported a UBSAN WARNING on rs.c. Undefined behaviour in drivers/net/wireless/intel/iwlwifi/dvm/rs.c:746:18 This because i = index - 1; for (mask = (1 << i); i >= 0;

[PATCH 15/17] iwlwifi: mvm: avoid race condition in ADD_STA.

From: "Goodstein, Mordechay" The race happens when we send ADD_STA(auth->assoc) -> LQ_CMD between the commands the FW sometimes loses the medium for AUX, and sends a ndp to the AP and the flow becomes, ADD_STA -> send ndp -> LQ_CMD the problem is that there's no

[PATCH 14/17] iwlwifi: mvm: Fix CSA received immediately after association

From: Avraham Stern The session protection set for association is only removed when BSS_CHANGED_BEACON_INFO is set and BSS_CHANGED_ASSOC is not set. However, mac80211 may set both on association (in case a beacon was already received). In this case, mac80211 will not

[PATCH 13/17] iwlwifi: pcie: set STATUS_RFKILL immediately after interrupt

From: Golan Ben Ami Currently, when getting a RFKILL interrupt, the transport enters a flow in which it stops the device, disables other interrupts, etc. After stopping the device, the transport resets the hw, and sleeps. During the sleep, a context switch occurs and

[PATCH 12/17] iwlwifi: mvm: don't call << operator with a negative value

From: Emmanuel Grumbach In https://bugzilla.kernel.org/show_bug.cgi?id=177341 Bob reported a UBSAN WARNING on rs.c in iwldvm. Fix the same bug in iwlmvm. This because i = index - 1; for (mask = (1 << i); i >= 0; i--, mask >>= 1) is unsafe: i could

[PATCH 09/17] iwlwifi: pcie: don't increment / decrement a bool

From: Emmanuel Grumbach David reported that the code I added uses the decrement and increment operator on a boolean variable. Fix that. Fixes: 0cd58eaab148 ("iwlwifi: pcie: allow the op_mode to block the tx queues") Reported-by: David Binderman

Re: [1/3] rt61pci: use entry directly

Stanislaw Gruszka wrote: > Signed-off-by: Stanislaw Gruszka 3 patches applied to wireless-drivers-next.git, thanks. 80a97eae3046 rt61pci: use entry directly 2ceb813798e1 rt2x00: call entry directly in rt2x00_dump_frame cf81db30a6ed rt2x00: remove

Re: rtlwifi: Move items out of rtl_pci_priv and rtl_usb_priv

Larry Finger wrote: > In commit 6773386f977c ("rtlwifi: rtl8192c-common: Fix "BUG: KASAN:"), > a BUG detected when CONFIG_KASAN=y was fixed by reordering the layouts > of struct rtl_pci_priv, and struct rtl_usb_priv so that the variables > used by both PCI and USB

Re: [V3,1/9] brcmfmac: merge two brcmf_err macros into one

Rafał Miłecki wrote: > From: Rafał Miłecki > > This allows simplifying the code by adding a simple IS_ENABLED check for > CONFIG_BRCMDB symbol. > > Signed-off-by: Rafał Miłecki > Acked-by: Arend van Spriel 3 patches applied to

Re: wil6210: include moduleparam.h

Johannes Berg wrote: > From: Johannes Berg > > This now declares a module parameter, so include the necessary > header file for that. > > Signed-off-by: Johannes Berg Patch applied to ath-next branch of ath.git,

Re: ath10k: select WANT_DEV_COREDUMP

Johannes Berg wrote: > From: Johannes Berg > > This is necessary so that - if ath10k is the only driver using > dev_coredump*() - the functionality is built into the kernel. > > Signed-off-by: Johannes Berg Patch

Re: KASAN+netlink, was: [PATCH] [net-next?] hns: avoid stack overflow with CONFIG_KASAN

2017-02-08 16:10 GMT+03:00 Arnd Bergmann : > On Wed, Feb 8, 2017 at 1:24 PM, Johannes Berg > wrote: > >> Btw, what's causing this to start with? Can't the compiler reuse the >> stack places? > > I have no idea. It's trying to find out of bounds accesses

[PATCH] mac80211: fix CSA in IBSS mode

Add the missing IBSS capability flag during capability init as it needs to be inserted into the generated beacon in order for CSA to work. Signed-off-by: Piotr Gawlowicz Signed-off-by: Mikołaj Chwalisz Tested-by: Koen Vandeputte

Re: [PATCH 00/17] iwlwifi: updates intended for v4.11 2017-02-08

On Wed, 2017-02-08 at 16:29 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > This is the third and final pull-request before 4.11's merge window. > > This time I concentrated in bugfixes: > > > > * Fix 802.11w, which was failing to due an IGTK bug; > > * A few more bugzilla

Re: [PATCH 00/17] iwlwifi: updates intended for v4.11 2017-02-08

Luca Coelho writes: > This is the third and final pull-request before 4.11's merge window. > This time I concentrated in bugfixes: > > * Fix 802.11w, which was failing to due an IGTK bug; > * A few more bugzilla bug fixes; > * A channel-switch race condition fix; > * Some fixes

[PATCH v4] wlcore: disable multicast filter in AP mode

Enable AP support for allmulticast for MDNS. It can be enabled by bringing up the interface with ip command with argument allmulticast on --- PATCH v4: fixes space in signed-off, tabbing for comment and indentation of closing bracket drivers/net/wireless/ti/wlcore/main.c | 15 +++

ANNOUNCE: Netdev 2.1 seeking netdev conferences reporter(s)

Folks, We are seeking for qualified people who love to write to cover the netdev 2.1 conference. The idea is to attend the different sessions and describe what was discussed in a timely manner. We would like to publish the events on a daily basis. Requirements: 1) Passion about netdev 2)

Re: [PATCH V3 4/9] brcmfmac: add struct brcmf_pub parameter to the __brcmf_err

On 2017-02-08 10:54, Arend Van Spriel wrote: On 2-2-2017 22:33, Rafał Miłecki wrote: From: Rafał Miłecki This will allow getting struct device reference from the passed brcmf_pub for the needs of dev_err. More detailed messages are really important for home routers which

[PATCH 0/3] rt2x00 skb_desc cleanup

Remove entry field from skb_desc in order to use this skb_desc place for other pointer. This is intended to -next. Stanislaw Gruszka (3): rt61pci: use entry directly rt2x00: call entry directly in rt2x00_dump_frame rt2x00: remove queue_entry from skbdesc

[PATCH 1/3] rt61pci: use entry directly

Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt61pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt61pci.c b/drivers/net/wireless/ralink/rt2x00/rt61pci.c index 5306a3b..8adb5f3 100644

Re: KASAN+netlink, was: [PATCH] [net-next?] hns: avoid stack overflow with CONFIG_KASAN

On Wed, Feb 8, 2017 at 1:24 PM, Johannes Berg wrote: > On Wed, 2017-02-08 at 13:03 +0100, Arnd Bergmann wrote: >> >> - Moving nla_put_{u8,u16,u32} out of line is probably uncontroversial >> and >> it helps enough with br_netlink.c, but nl820211 is worse and needs >>

[PATCH 2/3] rt2x00: call entry directly in rt2x00_dump_frame

Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-

[PATCH 3/3] rt2x00: remove queue_entry from skbdesc

queue_entry field of skbdesc is not read any more, remove it to allow skbdesc contain other data. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 3 --- drivers/net/wireless/ralink/rt2x00/rt2x00queue.h | 2 -- 2 files changed, 5

[PATCH] cfg80211: fix NAN bands definition

From: Luca Coelho The nl80211_nan_dual_band_conf enumeration doesn't make much sense. The default value is assigned to a bit, which makes it weird if the default bit and other bits are set at the same time. To improve this, get rid of NL80211_NAN_BAND_DEFAULT and add a

Re: [PATCH v4 3/5] cfg80211: Accept multiple RSSI thresholds for CQM

> > I think it would make sense to unconditionally apply the hysteresis > > to low/high, i.e. always set > >  low = low - hyst > >  high = high + hyst > > > > so that you get "sticky" ranges once you're in them? > > Yes, maybe that's better, I guess I want to avoid just adding a lag / > delay

[PATCH v3] iw: Add support for controlling tx power for per station

This patch allows userspace to set transmit power, in mBm units, to a station associated to the AP. To set a limit tx power of 2000 mBm: iw wlan0 station set txpwr limit 2000 To revert the user defined tx power for a station: iw wlan0 station set txpwr auto Signed-off-by: Ashok Raj Nagarajan

[PATCH v3] ath10k: add support for controlling tx power to a station

This patch will add the support to control the transmit power for traffic to a station associated with the AP. Userspace provide the transmit power value in mBm units. ath10k firmware expects the value to be in dBm and hence will convert the value from to dBm before passing down to firmware.

[PATCH v3 2/2] mac80211: store tx power value from user to station

This patch introduce a new driver callback drv_sta_set_txpwr. This API will copy the transmit power value passed from user space and call the driver callback to set the tx power for the station. Signed-off-by: Ashok Raj Nagarajan --- v3: - Store txpwr in mBm

Re: [PATCH v4 3/5] cfg80211: Accept multiple RSSI thresholds for CQM

Hi, On 8 February 2017 at 10:58, Johannes Berg wrote: > >> This method doesn't have a hysteresis parameter because there's no >> benefit to the cfg80211 code from having the hysteresis be handled by >> hardware/driver in terms of the number of wakeups. At the same

[PATCH v3 1/2] cfg80211: Add support to set tx power for a station associated

This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow selection of automatic and limited transmit power

[PATCH 2/2] rt2x00usb: fix anchor initialization

If device fail to initialize we can OOPS in rt2x00lib_remove_dev(), due to using uninitialized usb_anchor structure: [ 855.435820] ieee80211 phy3: rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for offset 0x1000 with error -19 [ 855.435826] ieee80211 phy3: rt2800_probe_rt: Error

[PATCH 1/2] rt2x00usb: do not anchor rx and tx urb's

We might kill TX or RX urb during rt2x00usb_flush_entry(), what can cause anchor list corruption like shown below: [ 2074.035633] WARNING: CPU: 2 PID: 14480 at lib/list_debug.c:33 __list_add+0xac/0xc0 [ 2074.035634] list_add corruption. prev->next should be next (88020f362c28), but was

[PATCH 07/17] iwlwifi: mvm: fix reorder timer re-arming

From: Sara Sharon When NSSN is behind the reorder buffer due to timeout the reorder timer isn't getting re-armed until NSSN catches up. Fix it. Fixes: 0690405fef29 ("iwlwifi: mvm: add reorder timeout per frame") Signed-off-by: Sara Sharon

[PATCH 05/17] iwlwifi: mvm: fix a print of NSS for HT rate

From: Gregory Greenman Handling of the number of space time streams was missing for HT rate in rate printing function. Fix it. Signed-off-by: Gregory Greenman Signed-off-by: Luca Coelho ---

[PATCH 00/17] iwlwifi: updates intended for v4.11 2017-02-08

From: Luca Coelho Hi, This is the third and final pull-request before 4.11's merge window. This time I concentrated in bugfixes: * Fix 802.11w, which was failing to due an IGTK bug; * A few more bugzilla bug fixes; * A channel-switch race condition fix; * Some fixes

[PATCH 04/17] iwlwifi: pcie: Re-configure IVAR table after stop device

From: Golan Ben Ami When getting RF_KILL and disabling radio, the device gets stopped and reset. This erases the IVAR table that matches the interrupt to its cause, and is essential for MSIX proper functionality. Till now, the table wasn't re-configured after the reset,

[PATCH 02/17] iwlwifi: pcie: separate between SW and HW MSIX configuration

From: Haim Dreyfuss The MSIX configuration flow includes two different stages: configuring the HW by writing to the IVAR table and configuring the SW to reflect the HW configuration. The HW configuration is needed on each HW reset, whereas the SW configuration is only

[PATCH 08/17] iwlwifi: mvm: use the PROBE_RESP_QUEUE to send deauth to unknown station

From: Emmanuel Grumbach When we send a deauth to a station we don't know about, we need to use the PROBE_RESP queue. This can happen when we send a deauth to a station that is not associated to us. Signed-off-by: Emmanuel Grumbach

[PATCH 03/17] iwlwifi: pcie: re-configure IVAR table after suspend-resume

From: Haim Dreyfuss During the suspend/resume flow some HW blocks are reset. This causes the IVAR table to be completely erased. This table is where interrupt causes are bound to specific IRQs. When the table is empty the interrupt handlers are not called correctly.

[PATCH 01/17] iwlwifi: pcie: move msix conf functions above other functions

From: Haim Dreyfuss msix configuration functions should be called by other functions. For example by pcie_d3_resume, move it above to enable it. Signed-off-by: Haim Dreyfuss Signed-off-by: Luca Coelho ---

[PATCH 06/17] iwlwifi: mvm: fix references to first_agg_queue in DQA mode

From: Sara Sharon In DQA mode, first_agg_queue is initialized to IWL_MVM_DQA_MIN_DATA_QUEUE. This causes two bugs in the tx response flow: 1. When TX fails, we set IEEE80211_TX_STAT_AMPDU_NO_BACK regardless if we actually have aggregation open on the queue. This causes

Re: [PATCH net] brcmfmac: clear skb head state on xmit

On 8-2-2017 10:29, Paolo Abeni wrote: > On Wed, 2017-02-08 at 09:52 +0100, Rafał Miłecki wrote: >> On 8 February 2017 at 09:38, Paolo Abeni wrote: >>> On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: On 7-2-2017 17:50, Paolo Abeni wrote: > the skbs can be

Re: [PATCH V3 4/9] brcmfmac: add struct brcmf_pub parameter to the __brcmf_err

On 2-2-2017 22:33, Rafał Miłecki wrote: > From: Rafał Miłecki > > This will allow getting struct device reference from the passed > brcmf_pub for the needs of dev_err. More detailed messages are really > important for home routers which frequently have 2 (or even 3) wireless >

Re: [PATCH V3 3/9] brcmfmac: merge two remaining brcmf_err macros

On 2-2-2017 22:33, Rafał Miłecki wrote: > From: Rafał Miłecki > > Now we always have __brcmf_err function we can do perfectly fine with > just one macro. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > V3: Add

Re: [PATCH net] brcmfmac: clear skb head state on xmit

Paolo Abeni writes: > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: >> On 7-2-2017 17:50, Paolo Abeni wrote: >> > the skbs can be held by the driver for a long time, so we need >> > to clear any state on xmit to avoid hanging other subsystems. >> > The skbs are

Re: [PATCH net] brcmfmac: clear skb head state on xmit

On Wed, 2017-02-08 at 12:27 +0200, Kalle Valo wrote: > Paolo Abeni writes: > > > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > > > On 7-2-2017 17:50, Paolo Abeni wrote: > > > > the skbs can be held by the driver for a long time, so we need > > > > to clear any

Re: [PATCH v5 3/3] mt76: add driver code for MT76x2e

On Tue, Feb 07, 2017 at 09:20:35PM +0100, Felix Fietkau wrote: > This is a 2x2 PCIe 802.11ac chipset by MediaTek > > Signed-off-by: Felix Fietkau > Signed-off-by: Lorenzo Bianconi Reviewed-by: Stanislaw Gruszka

Re: [PATCH v4 3/5] cfg80211: Accept multiple RSSI thresholds for CQM

> This method doesn't have a hysteresis parameter because there's no > benefit to the cfg80211 code from having the hysteresis be handled by > hardware/driver in terms of the number of wakeups.  At the same time > it would likely be less consistent between drivers if offloaded or > done in the

Re: [PATCH 1/5] nl80211: fix validation of scheduled scan info for wowlan netdetect

On 8-2-2017 10:10, Johannes Berg wrote: > On Fri, 2017-01-27 at 12:09 +, Arend van Spriel wrote: >> For wowlan netdetect a separate limit is defined for the number of >> matchsets. Currently, this limit is ignored and the regular limit >> for scheduled scan matchsets, ie. struct

Re: [PATCH] cfg80211: make rdev assignment clearer in nl80211_testmode_dump()

On Tue, 2017-02-07 at 22:13 +0200, Luca Coelho wrote: > From: Luca Coelho > > Avoid assigning rdev to NULL when we already have it and getting it > again from the wiphy index, by moving this code to relevant if block. Applied. johannes

Re: [PATCH] nl80211: add HT/VHT capabilities to AP parameters

On Tue, 2017-02-07 at 22:40 +0200, Luca Coelho wrote: > From: Johannes Berg > > For the benefit of drivers that rebuild IEs in firmware, parse the > IEs for HT/VHT capabilities and the respective membership selector > in the (extended) supported rates. This avoids

Re: [PATCH v4 2/5] cfg80211: Pass new RSSI level in CQM RSSI notification

Ok, I've applied patches 1-2 right now, that really makes sense regardless of the others. johannes

Re: [PATCH net] brcmfmac: clear skb head state on xmit

On Wed, 2017-02-08 at 09:52 +0100, Rafał Miłecki wrote: > On 8 February 2017 at 09:38, Paolo Abeni wrote: > > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > > > On 7-2-2017 17:50, Paolo Abeni wrote: > > > > the skbs can be held by the driver for a long time, so we

Re: [PATCH V3 2/9] brcmfmac: switch to C function (__brcmf_err) for printing errors

On 2-2-2017 22:33, Rafał Miłecki wrote: > From: Rafał Miłecki > > This will allow extending code and using more detailed messages e.g. > with the help of dev_err. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > ---

Re: [PATCH 1/5] nl80211: fix validation of scheduled scan info for wowlan netdetect

On Fri, 2017-01-27 at 12:09 +, Arend van Spriel wrote: > For wowlan netdetect a separate limit is defined for the number of > matchsets. Currently, this limit is ignored and the regular limit > for scheduled scan matchsets, ie. struct wiphy::max_match_sets, is > used for the net-detect case as

Re: [PATCH V3 1/9] brcmfmac: merge two brcmf_err macros into one

On 2-2-2017 22:33, Rafał Miłecki wrote: > From: Rafał Miłecki > > This allows simplifying the code by adding a simple IS_ENABLED check for > CONFIG_BRCMDB symbol. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > ---

Re: [patch] mac80211: check for allocation failure in debugfs code

On Tue, 2017-02-07 at 16:20 +0300, Dan Carpenter wrote: > kmalloc() can fail.  Also let's move the allocation out of the > declaration block so it's easier to read. > Applied, thanks. johannes

Re: [PATCH net] brcmfmac: clear skb head state on xmit

On 8 February 2017 at 09:38, Paolo Abeni wrote: > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: >> On 7-2-2017 17:50, Paolo Abeni wrote: >> > the skbs can be held by the driver for a long time, so we need >> > to clear any state on xmit to avoid hanging other

Re: [PATCH net] brcmfmac: clear skb head state on xmit

On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > On 7-2-2017 17:50, Paolo Abeni wrote: > > the skbs can be held by the driver for a long time, so we need > > to clear any state on xmit to avoid hanging other subsystems. > > The skbs are already orphaned later in cmsg code, so we just >

Re: [PATCH v2 2/3] mac80211: Make mesh failure moving average configurable

On Tue, 2017-01-31 at 12:07 -0800, Rajkumar Manoharan wrote: > Currently mesh moving fail average is calculated based on constant > weight factor. In worst case moving average reaches threshold by > considering 16 msdu tx ack status and deactivates mesh path. Having > a constant weight factor

Re: [PATCH v2 1/3] mac80211: fix mesh moving average stuck

On Tue, 2017-01-31 at 12:07 -0800, Rajkumar Manoharan wrote: > As moving average is not considering fractional part after > certain ratio, it will stuck at the same state. For example > with current values, moving average stuck at 96 and it will > not move forward. Fortunately current threshold is

RE: [PATCH v9] Add new mac80211 driver mwlwifi.

> From: Rafał Miłecki [mailto:zaj...@gmail.com] worte: > On 8 February 2017 at 08:28, David Lin wrote: > >> From: Rafał Miłecki [mailto:zaj...@gmail.com] worte: > >> Sent: Wednesday, February 08, 2017 3:24 PM On 8 February 2017 at > >> 07:30, David Lin wrote:

Re: [PATCH] mac80211: Remove VHT Capabilities/Operation IEs from mesh beacon if VHT was disabled

> This patch removes VHT Capabilities/Operation IEs when the > wpa_supplicant.conf includes disable_vht=1. We recognize the local > peer > as 11ac ready, when it has more than 80MHz band width. Because > net/mac80211/util.c#ieee80211_build_preq_ies_band() uses 80MHz > threshold > for VHT

Re: [PATCH v3 0/2] mac80211: use crypto shash for AES cmac

Both applied, thanks. johannes

Re: [PATCH] Print text for disassociation reason.

> Don't know why it wasn't printed there with > ieee80211_get_reason_code_string in first > place. Works for me: > > kernel: wlan0: disassociated from 04:b0:20:33:ff:1f (Reason: > 34=DISASSOC_LOW_ACK) This patch needs a "mac80211: " prefix, and I'd prefer no . at the end (but that's not a hard