Re: [PATCH 03/11] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-08 Thread Chi-Hsien Lin
On 11/08/2018 7:53, Arend van Spriel wrote: > On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: >> From: Madhan Mohan R >> >> Along with F2 watermark (existing) configuration, F1 MesBusyCtrl >> should be enabled & configured to avoid overflow errors. > > Reviewed-by: Arend van Spriel >>

Re: [PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

2018-11-08 Thread Ganesh.Krishna
From: Ajay Singh We would like to update the maintainer email id's for wilc1000 driver. Signed-off-by: Aditya Shankar Signed-off-by: Ganesh Krishna Signed-off-by: Adham Abozaeid Signed-off-by: Ajay Singh Acked-by: Ganesh Krishna --- Changes in

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-11-08 Thread Siva Rebbagondla
Hi, Gentle Remainder..!!!. Any update required for this patch?. If not, When can i expect this patch to be available in wireless-next?. Thank you, Siva Rebbagondla On Thu, Oct 18, 2018 at 5:21 PM Siva Rebbagondla wrote: > > On Thu, Oct 18, 2018 at 2:06 PM Johannes Berg > wrote: > > > > From:

Re: [PATCH v4 1/3] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Greg KH
On Thu, Nov 08, 2018 at 09:50:25PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > From: Adham Abozaeid Twice? Something went wrong on your side, for all of these patches :( Please fix up and resend. thanks, greg k-h

[PATCH v4 1/3] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Adham.Abozaeid
From: Adham Abozaeid From: Adham Abozaeid Validate cfg parameters after being called by cfg80211 in set_wiphy_params before scheduling the work executed in handle_cfg_param Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 61 ++-

[PATCH v4 2/3] staging: wilc1000: Don't keep a copy of wiphy parameters in the driver

2018-11-08 Thread Adham.Abozaeid
From: Adham Abozaeid From: Adham Abozaeid host_if_drv.cfg_values is a write only member, and can be removed Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 13 - drivers/staging/wilc1000/host_interface.h | 1 - 2 files changed, 14 deletions(-)

[PATCH v4 3/3] staging: wilc1000: Remove unused mutex cfg_values_lock

2018-11-08 Thread Adham.Abozaeid
From: Adham Abozaeid From: Adham Abozaeid After removing cfg_values member, cfg_values_lock that was used to protect it can also be removed. Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 9 - drivers/staging/wilc1000/host_interface.h | 2 -- 2 files

[PATCH v4 0/3] staging: wilc1000: validate input to set_wiphy_param and return proper

2018-11-08 Thread Adham.Abozaeid
From: Adham Abozaeid Validate input parameters to set_wiphy_param before scheduling handle_cfg_param() to validate them. This way proper errors can be returned to caller. Also cleaned up unused code in handle_cfg_param. Changes since v1: - Correction spelling in subject of patch#2 - Added From:

Re: [iw] [patch] Please support CPPFLAGS in Makefile

2018-11-08 Thread Paride Legovini
Johannes Berg wrote on 08/11/2018: > On Thu, 2018-11-08 at 21:26 +0100, Johannes Berg wrote: >> Hi, >> >>> The attached patch adds support for CPPFLAGS to iw's Makefile. >> >> Please send the patch as plain text (not attachment), and with signed- >> off-by per the CONTRIBUTING file. > > Actually,

Re: [iw] [patch] Please support CPPFLAGS in Makefile

2018-11-08 Thread Johannes Berg
On Thu, 2018-11-08 at 21:26 +0100, Johannes Berg wrote: > Hi, > > > The attached patch adds support for CPPFLAGS to iw's Makefile. > > Please send the patch as plain text (not attachment), and with signed- > off-by per the CONTRIBUTING file. Actually, it looks like patchwork knows how to read

[iw] [patch] Please support CPPFLAGS in Makefile

2018-11-08 Thread Paride Legovini
Dear linux-wireless, The attached patch adds support for CPPFLAGS to iw's Makefile. I am not subscribed to the list, please Cc: me in replies. Paride From f672e0f8690b7f38d29d83b29f2374787694c31e Mon Sep 17 00:00:00 2001 From: Paride Legovini Date: Thu, 8 Nov 2018 21:19:20 +0100 Subject:

Re: [iw] [patch] Please support CPPFLAGS in Makefile

2018-11-08 Thread Johannes Berg
Hi, > The attached patch adds support for CPPFLAGS to iw's Makefile. Please send the patch as plain text (not attachment), and with signed- off-by per the CONTRIBUTING file. Thanks, johannes

Re: [PATCH 2/5] brcmfmac: remove "arp_hostip_clear" from "brcmf_netdev_stop"

2018-11-08 Thread Franky Lin
On Wed, Nov 7, 2018 at 7:48 PM Chi-Hsien Lin wrote: > > From: Wright Feng > > The firmware does not respond ARP request and causes ping failure with > following steps: > > 1. Bring up interface >ifconfig wlan0 up or start wpa_supplicant > 2. Set the IP address >ifconfig wlan0

Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Adham.Abozaeid
On 11/8/18 4:22 AM, Greg KH wrote: > On Tue, Nov 06, 2018 at 12:01:18AM +, adham.aboza...@microchip.com wrote: >> From: Adham Abozaeid >> >> Validate cfg parameters after being called by cfg80211 in set_wiphy_params >> before scheduling the work executed in handle_cfg_param >> >>

Re: [RFC/RFT 2/4] mt76x02: reserve wcid 0 for global traffic

2018-11-08 Thread Felix Fietkau
On 2018-11-08 16:54, Stanislaw Gruszka wrote: > On Thu, Nov 08, 2018 at 04:01:54PM +0100, Lorenzo Bianconi wrote: >> > Restore behaviour on mt76x0 before commit 1bb04bb4b838 ("mt76: move >> > mt76x02_init_device in mt76x02-lib module"). This will allow to use >> > wcid 1 for AP when we work in

Re: [RFC/RFT 1/4] mt76x02: configure basic rates and fallback on STA mode

2018-11-08 Thread Felix Fietkau
On 2018-11-08 16:52, Stanislaw Gruszka wrote: > On Thu, Nov 08, 2018 at 03:58:29PM +0100, Lorenzo Bianconi wrote: >> > For STA mode configure legacy basic rates according to info >> > mac80211 provides to us, as well as follback registers, which >> > are setup in vendor driver under

Re: [RFC/RFT 2/4] mt76x02: reserve wcid 0 for global traffic

2018-11-08 Thread Stanislaw Gruszka
On Thu, Nov 08, 2018 at 04:01:54PM +0100, Lorenzo Bianconi wrote: > > Restore behaviour on mt76x0 before commit 1bb04bb4b838 ("mt76: move > > mt76x02_init_device in mt76x02-lib module"). This will allow to use > > wcid 1 for AP when we work in station mode. It's not clear if this > > is needed,

Re: [RFC/RFT 1/4] mt76x02: configure basic rates and fallback on STA mode

2018-11-08 Thread Stanislaw Gruszka
On Thu, Nov 08, 2018 at 03:58:29PM +0100, Lorenzo Bianconi wrote: > > For STA mode configure legacy basic rates according to info > > mac80211 provides to us, as well as follback registers, which > > are setup in vendor driver under CONFIG_STA_SUPPORT . > > For LB_FBK_CFG1 register use values from

[PATCH FIX] brcmfmac: fix reporting support for 160 MHz channels

2018-11-08 Thread Rafał Miłecki
From: Rafał Miłecki Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later. This fixes info

Re: [RFC/RFT 2/4] mt76x02: reserve wcid 0 for global traffic

2018-11-08 Thread Lorenzo Bianconi
> Restore behaviour on mt76x0 before commit 1bb04bb4b838 ("mt76: move > mt76x02_init_device in mt76x02-lib module"). This will allow to use > wcid 1 for AP when we work in station mode. It's not clear if this > is needed, but this is how vendor driver assign wcid's in STA mode. > This should be

Re: [RFC/RFT 1/4] mt76x02: configure basic rates and fallback on STA mode

2018-11-08 Thread Lorenzo Bianconi
> For STA mode configure legacy basic rates according to info > mac80211 provides to us, as well as follback registers, which > are setup in vendor driver under CONFIG_STA_SUPPORT . > For LB_FBK_CFG1 register use values from vendor driver, which > are different for mt76x0 and mt76x2 . > >

[RFC/RFT 2/4] mt76x02: reserve wcid 0 for global traffic

2018-11-08 Thread Stanislaw Gruszka
Restore behaviour on mt76x0 before commit 1bb04bb4b838 ("mt76: move mt76x02_init_device in mt76x02-lib module"). This will allow to use wcid 1 for AP when we work in station mode. It's not clear if this is needed, but this is how vendor driver assign wcid's in STA mode. This should be harmless

[RFC/RFT 4/4] mt76x02: set protection according to ht capabilities

2018-11-08 Thread Stanislaw Gruszka
Use information about protection that mac80211 provide to us. Used protection should be part of ht capabilites that either remote AP provde to us in STA mode or is set in hostapd.conf in ht_capab option. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 58

[RFC/RFT 3/4] mt76x02: do not set protection on set_rts_threshold callback

2018-11-08 Thread Stanislaw Gruszka
Use set_rts_threshold calback to enable/disable threshold only for legacy traffic. RTS/CTS threshold for HT TXOP make make no sense to me since used protection (RTS/CTS , CTS-to-self or none) should be determined by HT capabilities and applied to any HT frames. Signed-off-by: Stanislaw Gruszka

[RFC/RFT 1/4] mt76x02: configure basic rates and fallback on STA mode

2018-11-08 Thread Stanislaw Gruszka
For STA mode configure legacy basic rates according to info mac80211 provides to us, as well as follback registers, which are setup in vendor driver under CONFIG_STA_SUPPORT . For LB_FBK_CFG1 register use values from vendor driver, which are different for mt76x0 and mt76x2 . Signed-off-by:

[RFC/RFT 0/4] restore some old mt76x0u behaviour

2018-11-08 Thread Stanislaw Gruszka
I can still observe random performance drops on my setup. Those drops are very rare after applying those: mt76x02: assure we update gain after scan mt76x02: run calibration after scanning mt76x0: do not overwrite other MT_BBP(AGC, 8) fields but sill happened in Felix tree up to: 79864387b0a0

Re: [PATCH 10/11] brcmfmac: disable command decode in sdio_aos for 4354

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Double Lo Transaction between AOS and SDIOD is not protected, and if cmd 52 received in AOS and in the middle of response state changed from AOS to SDIOD, response is corrupted and it causes to SDIO Host controller to hang. See comment in

Re: [PATCH 11/11] brcmfmac: disable command decode in sdio_aos for 4373

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Madhan Mohan R By disabling command decode, sdiod_aos module supports the detection of sdio command line toggle only and generates a wakeup request to PMU and to sdiod core. It does not decode any sdio command and generates no response to any

Re: [PATCH 09/11] brcmfmac: disable command decode in sdio_aos for 43012/4339/4345

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Wright Feng Transaction between AOS and SDIOD is not protected, and if cmd 52 received in AOS and in the middle of response state changed from AOS to SDIOD, response is corrupted and it causes to SDIO Host controller to hang. I think it would

Re: [PATCH 08/11] brcmfmac: 4373 save-restore support

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: Use sr_eng_en bit to check 4373 sr support. Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 07/11] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Naveen Gupta The number of words that the read FIFO has to contain except the end of frame before sends data back to the host. Max watermark = (512B - 2* (BurstLength))/4 = (512 - 128)/4 = 384/4 = 0x60 so if burst length (i.e. BurstLength = 64)

Re: [PATCH 05/11] brcmfmac: allow GCI core enumuration

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: GCI core is needed for ULP operation. Allow GCI core enumuration with below changes: - Allow GCI to be added to core list even when it doesn't have a wrapper. - Allow 8K address space size. - Don't overwrite the address value when an additional size

Re: [PATCH 06/11] brcmfmac: saverestore support changes for 43012

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Praveen Babu C Add saverestore register settings for 43012. I would collapse this commit with PATCH 04/11. Reviewed-by: Arend van Spriel Signed-off-by: Praveen Babu C Signed-off-by: Chi-Hsien Lin ---

Re: [PATCH 04/11] brcmfmac: add support for CYW43012 SDIO chipset

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: CYW43012 is a 1x1 802.11a/b/g/n Dual-Band HT20, 256-QAM/Turbo QAM. It is an Ultra Low Power WLAN+BT combo chip. comments below Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c |

Re: [PATCH 01/11] brcmfmac: add 4354 raw pcie device id

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Winnie Chang Add the raw 4354 PCIe device ID. What is the motivation for adding this. I can do an educated guess, but I would like to see it in the commit message. Why only for 4354? Regards, Arend Signed-off-by: Winnie Chang

Re: [PATCH 03/11] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Madhan Mohan R Along with F2 watermark (existing) configuration, F1 MesBusyCtrl should be enabled & configured to avoid overflow errors. Reviewed-by: Arend van Spriel Signed-off-by: Madhan Mohan R Signed-off-by: Chi-Hsien Lin ---

Re: [PATCH 02/11] brcmfmac: set F2 watermark to 256 for 4373

2018-11-08 Thread Arend van Spriel
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote: From: Wright Feng We got SDIO_CRC_ERROR with 4373 on SDR104 when doing bi-directional throughput test. Enable watermark to 256 to guarantee the operation stability. Maybe it would be better to clarify the unit of the watermark. Here you use bytes,

Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Greg KH
On Tue, Nov 06, 2018 at 12:01:18AM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > Validate cfg parameters after being called by cfg80211 in set_wiphy_params > before scheduling the work executed in handle_cfg_param > > Signed-off-by: Adham Abozaeid > --- >