Johannes Berg writes:
> On Wed, 2018-09-05 at 11:56 +0200, Toke Høiland-Jørgensen wrote:
>
>> > So basically this gets rid of a corner case that we shouldn't have.
>> > Either we should decide that using different TXQs is *always* correct
>> > for non-QoS,
false due to
> packet drops or power-save buffering in the tx handlers. In the
> past, this function would return true in such cases, and the change
> to false doesn't seem to be intentional.
Can confirm that this was not intentional; nice catch! :)
Acked-by: Toke Høiland-Jørgensen
-Toke
Johannes Berg writes:
> On Wed, 2018-09-05 at 11:47 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg writes:
>>
>> > From: Johannes Berg
>> >
>> > Some frames may have a non-zero skb->priority assigned by
>> > mac80211 internally,
Johannes Berg writes:
> From: Johannes Berg
>
> Some frames may have a non-zero skb->priority assigned by
> mac80211 internally, e.g. TDLS setup frames, regardless of
> support for QoS.
>
> Currently, we set skb->priority to 0 for all data frames.
> Note that there's a comment that this is "requ
Johannes Berg writes:
>> > Perhaps then it should just be fractional? i.e. 8.8 bits or so?, so
>> > the default would be 1.0 (0x0100) and then you could scale down to 0.5
>> > (0x0080) etc?
>>
>> Hmm, that's an interesting idea. I'll have to run some numbers to see
>> how the precision holds up
Johannes Berg writes:
> On Wed, 2018-08-29 at 11:27 +0200, Toke Høiland-Jørgensen wrote:
>
>> Hmm, the problem with a higher weight is that weight*quantum becomes the
>> time each station is scheduled, so having a higher value means higher
>> latency. This could be fixed
Johannes Berg writes:
> On Wed, 2018-08-29 at 11:22 +0200, Toke Høiland-Jørgensen wrote:
>
>> > We're also working on adding a TXQ for (bufferable) management packets
>> > - I wonder how that should interact here? Always be scheduled first?
>>
>> Ah
Rajkumar Manoharan writes:
> Once a txq is selected for transmission by next_txq(), all data from
> txq are dequeued by driver till hardware descriptors are drained.
> i.e the driver is still allowed to dequeue frames from txq even when
> its fairness deficit goes negative during transmission. Th
Johannes Berg writes:
> On Mon, 2018-07-09 at 18:37 +0200, Toke Høiland-Jørgensen wrote:
>>
>> @@ -427,6 +428,8 @@ struct sta_info *sta_info_alloc(struct
>> ieee80211_sub_if_data *sdata,
>> sta->cparams.interval = MS2TIME(100);
>> sta-&
Johannes Berg writes:
> Rather belatedly reviewing this too ...
>
>> + * The driver can't access the queue directly. To dequeue a frame from a
>> + * txq, it calls ieee80211_tx_dequeue(). Whenever mac80211 adds a new frame
>> to a
>> + * queue, it calls the .wake_tx_queue driver op.
>> + *
>> +
Rajkumar Manoharan writes:
>>> As mentioned earlier, next_txq() can not be used for fetching txq
>>> directly. So reorder_txq() needs to take care of refilling txq after
>>> serving them.
>>
>> Yeah, I got that; but see above. Unless there's a guarantee that the
>> push/pull mechanism will be ro
Rajkumar Manoharan writes:
> On 2018-08-21 05:24, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
>>> This allows the driver to refill airtime fairness deficit
>>> where the driver will not access txqs by ieee80211_next_txq.
>>> In tx pu
Rajkumar Manoharan writes:
> This allows the driver to refill airtime fairness deficit
> where the driver will not access txqs by ieee80211_next_txq.
> In tx push mode data path, high priority txqs will be scheduled
> for data transmission by ieee80211_next_txq and driver will not
> prioritize tx
Arend van Spriel writes:
> On 8/13/2018 2:16 PM, Toke Høiland-Jørgensen wrote:
>> The TXQ teardown code can reference the vif data structures that are
>> stored in the netdev private memory area if there are still packets on
>> the queue when it is being freed. Since the TXQ
TXQ teardown code to earlier in ieee80211_unregister_hw().
Reported-by: Ben Greear
Tested-by: Ben Greear
Signed-off-by: Toke Høiland-Jørgensen
---
net/mac80211/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index e054a2fd8d38
Ben Greear writes:
> On 08/02/2018 01:20 PM, Toke Høiland-Jørgensen wrote:
>> Ben Greear writes:
>>
>>> On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote:
>>>> Ben Greear writes:
>>>>
>>>>> This is from my hacked kernel, co
Ben Greear writes:
> On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote:
>> Ben Greear writes:
>>
>>> This is from my hacked kernel, could be my fault. I thought the fq
>>> guys might want to know however...
>>
>> Hmm, nothing obvious comes to mind
Ben Greear writes:
> This is from my hacked kernel, could be my fault. I thought the fq
> guys might want to know however...
Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a
packet from the queue; it only has two memory derefs, to fq->lock and
flow->queue. Don't see why eith
Rajkumar Manoharan writes:
>>> A simple change in argument may break algo. What would be seqno of
>>> first packet of txq if queue_skb() isn't reset seqno?
>>
>> It would be 0, which would be less than the current seqno in all cases
>> except just when the seqno counter wraps.
>>
>
> One point
Rajkumar Manoharan writes:
> On 2018-07-21 13:54, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
>>> On 2018-07-19 07:18, Toke Høiland-Jørgensen wrote:
>>>> Rajkumar Manoharan writes:
>>>>
>>>>> On 2018-07-13
Rajkumar Manoharan writes:
> On 2018-07-19 07:18, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
>>> On 2018-07-13 06:39, Toke Høiland-Jørgensen wrote:
>>>> Rajkumar Manoharan writes:
>
>>>> It is not generally predictabl
Rajkumar Manoharan writes:
> On 2018-07-13 06:39, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
> [...]
>
>>> Hmm... I thought driver will call ieee80211_schedule_txq when it runs
>>> out of hardware descriptor and break the loop. The ser
Rajkumar Manoharan writes:
> On 2018-07-12 16:13, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
>>> On 2018-07-11 13:48, Toke Høiland-Jørgensen wrote:
>>>> Rajkumar Manoharan writes:
>>>>
>>
Rajkumar Manoharan writes:
> On 2018-07-11 13:48, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan writes:
>>
>>> On 2018-07-09 09:37, Toke Høiland-Jørgensen wrote:
>>> [...]
>>>> +/**
>>>> + * ieee80211_schedule_txq - add txq to s
Rajkumar Manoharan writes:
> On 2018-07-09 09:37, Toke Høiland-Jørgensen wrote:
> [...]
>> +/**
>> + * ieee80211_schedule_txq - add txq to scheduling loop
>> + *
>> + * @hw: pointer as obtained from ieee80211_alloc_hw()
>> + * @txq: pointer obtain
Manikanta Pubbisetty writes:
> On 7/10/2018 8:52 PM, Toke Høiland-Jørgensen wrote:
>> Manikanta Pubbisetty writes:
>>
>>> On 7/10/2018 6:28 PM, Toke Høiland-Jørgensen wrote:
>>>
>>>>> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/i
Manikanta Pubbisetty writes:
> On 7/10/2018 6:28 PM, Toke Høiland-Jørgensen wrote:
>
>>> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
>>> index 172aeae..d07f7f9 100644
>>> --- a/net/mac80211/ieee80211_i.h
>>> +++ b/net/mac80211/
> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> index 172aeae..d07f7f9 100644
> --- a/net/mac80211/ieee80211_i.h
> +++ b/net/mac80211/ieee80211_i.h
> @@ -818,6 +818,7 @@ enum txq_info_flags {
> IEEE80211_TXQ_STOP,
> IEEE80211_TXQ_AMPDU,
> IEEE80211_TXQ_NO_
Sven Eckelmann writes:
> On Donnerstag, 5. Juli 2018 10:47:11 CEST Sven Eckelmann wrote:
>> Hi Toke,
>>
>> we are currently testing DFS with ath10k and noticed that AQM seems to
>> ignore
>> cfg80211_csa_settings->block_tx. Problem is now that the channel switch is
>> started on a detected ra
time.
Signed-off-by: Toke Høiland-Jørgensen
---
include/net/mac80211.h | 50 +---
net/mac80211/agg-tx.c |2 +
net/mac80211/ieee80211_i.h |7
net/mac80211/main.c|3 ++
net/mac80211/sta_info.c|3 ++
net/mac80211/tx.c
This moves the ath9k driver to use the mac80211 TXQ scheduling and
airtime accounting APIs, removing the corresponding state tracking
inside the driver.
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/net/wireless/ath/ath9k/ath9k.h | 14 --
drivers/net/wireless/ath/ath9k/debug.c
airtime policies.
If the extended feature is not set, the scheduler will default to
round-robin scheduling.
Signed-off-by: Toke Høiland-Jørgensen
---
include/net/mac80211.h | 28
include/uapi/linux/nl80211.h |3 ++
net/mac80211/debugfs.c |3 ++
net
This adds airtime statistics to the cfg80211 station dump, and also adds
a new parameter to set the airtime weight of each station. The latter
allows userspace to implement policies for different stations by varying
their weights.
Signed-off-by: Toke Høiland-Jørgensen
---
include/net/cfg80211.h
duler also incorporates weights into
the scheduling, which allows userspace to implement policies for how
airtime is divided between stations. I have a patch series for hostapd
to implement configurable policies, that I will post separately once the
kernel side is in place.
---
Toke Høiland-Jørgens
Johannes Berg writes:
> On Wed, 2018-07-04 at 09:26 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg writes:
>>
>> > I see no evidence of ath9k doing this correctly, so this might fix a
>> > bug there, but I may have missed it.
>>
>> ath9k do
Johannes Berg writes:
> I see no evidence of ath9k doing this correctly, so this might fix a
> bug there, but I may have missed it.
ath9k does check for this, in ath_tx_sched_aggr() and in
ath_tx_form_aggr(); it'll check for the IEEE80211_TX_CTL_AMPDU flag, and
stop building the current aggregat
Johannes Berg writes:
> On Tue, 2018-07-03 at 16:31 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg writes:
>>
>> > From: Johannes Berg
>> >
>> > Since (QoS) NDP frames shouldn't be put into aggregation nor are
>> > assigned
Johannes Berg writes:
> From: Johannes Berg
>
> Since (QoS) NDP frames shouldn't be put into aggregation nor are
> assigned real sequence numbers, etc. it's better to treat them as
> non-data packets and not put them on the normal TXQs, for example
> when building A-MPDUs they need to be treated
Manikanta Pubbisetty writes:
> On 6/26/2018 4:55 PM, Toke Høiland-Jørgensen wrote:
>> Manikanta Pubbisetty writes:
>>
>>> We can still invoke netif stop/wake APIs when wake_tx_queue is
>>> implemented but this could lead to packet drops in network layer;
>>
Manikanta Pubbisetty writes:
> We can still invoke netif stop/wake APIs when wake_tx_queue is
> implemented but this could lead to packet drops in network layer;
> adding stop/start logic for software TXQs in mac80211 instead makes
> more sense; the change proposed adds the same in mac80211.
I a
Tamizh Chelvam Raja writes:
>> This patchsets introduced new NL command and api to support
>> configuring txrate threshold for the connected stations and api to
>> notify userspace application upon crossing the configured txrate threshold.
>> This will be useful for the application which requir
Tamizh chelvam writes:
> This patchsets introduced new NL command and api to support
> configuring txrate threshold for the connected stations and api to
> notify userspace application upon crossing the configured txrate threshold.
> This will be useful for the application which requires
> statio
Niklas Cassel writes:
> Tested-by: Niklas Cassel
Great, thanks!
-Toke
rs to userspace")
Reported-by: Niklas Cassel
Signed-off-by: Toke Høiland-Jørgensen
---
net/mac80211/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index 4d2e797e3f16..722f3d9fb416 100644
--- a/net/mac80211/ma
Niklas Cassel writes:
> Hello
>
>
> Commit 2fe4a29a452a ("mac80211: Support the new cfg80211 TXQ stats API")
>
> Introduces some new lockdep (build with CONFIG_PROVE_LOCKING=y) warning:
>
> [7.368515] the code is fine but needs lockdep annotation.
> [7.372501] turning off the locking corr
o".
>
> Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace")
> Signed-off-by: Dan Carpenter
Ah, right, didn't notice that that was supposed to be a gfp value.
Thanks for the fix :)
Acked-by: Toke Høiland-Jørgensen
-Toke
Niklas Cassel writes:
> [ .. snip .. ]
>> > Sure, the regular way ath10k_mac_op_wake_tx_queue is called is via
>> > ieee80211_subif_start_xmit => __ieee80211_subif_start_xmit =>
>> > ieee80211_xmit_fast
>> > => ieee80211_queue_skb => drv_wake_tx_queue.
>> >
>> > But I was expecting the call to ie
[ Adding Felix ]
Niklas Cassel writes:
> Hello mac80211 and ath10k people
>
> Using ath10k, TX stops working when running iperf
>
> [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec
> [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec
> [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec
> [ 3] 3.0
Sriram R writes:
> This patchset adds support for the collection and propagating of
> per-rate, per-station rx statistics when enabled by a userspace
> application.
Why not report TX rate statistics as well, when it is available?
Minstrel already collects this, and it is available via debugfs (t
On 10 May 2018 15:50:23 CEST, Dedy Lansky wrote:
>Hi Toke,
>
>> --- a/drivers/net/wireless/ath/wil6210/wmi.c
>> +++ b/drivers/net/wireless/ath/wil6210/wmi.c
>> @@ -824,7 +824,7 @@ static void wmi_evt_connect(struct wil6210_vif
>*vif, int id, void *d, int len)
>> struct wireless_dev *wdev =
adds an allocation function that those who want to provide
> per-tid stats should use to allocate the tid array, ie.
> struct station_info::pertid.
>
> Cc: Toke Høiland-Jørgensen
> Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to
> userspace"
space")
Reviewed-by: Sergey Matyukevich
Signed-off-by: Toke Høiland-Jørgensen
---
v5:
- Move allocation below error return in wil6210
- Add Sergey's reviewed-by tag from v4
v4:
- Add missing kfree before return in qtnfmac, as pointed out by Sergey
Matyukevich.
drivers/net/wire
On 10 May 2018 11:58:17 CEST, Dedy Lansky wrote:
>Hi Toke,
>
>Thanks for taking care of wil6210 part. See comment below.
>
>> @@ -824,7 +824,7 @@ static void wmi_evt_connect(struct wil6210_vif
>*vif, int id, void *d, int len)
>> struct wireless_dev *wdev = vif_to_wdev(vif);
>> struct w
space")
Signed-off-by: Toke Høiland-Jørgensen
---
v4:
- Add missing kfree before return in qtnfmac, as pointed out by Sergey
Matyukevich.
drivers/net/wireless/ath/ath6kl/main.c | 14 ---
drivers/net/wireless/ath/wil6210/debugfs.c | 22 +++
drivers/net/wi
ns instead.
>>
>> Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to
>> userspace")
>> Signed-off-by: Toke Høiland-Jørgensen
>> ---
>> drivers/net/wireless/ath/ath6kl/main.c | 14 ++
>> drivers/net/wireless/ath/w
fixes up the drivers.
Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace")
Signed-off-by: Toke Høiland-Jørgensen
---
net/batman-adv/bat_v_elp.c | 22 --
net/wireless/wext-compat.c | 29 +
2 files changed, 33
patch fixes the drivers in the main tree.
Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace")
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
space")
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/net/wireless/ath/ath6kl/main.c | 14 ++
drivers/net/wireless/ath/wil6210/debugfs.c | 22 ++-
drivers/net/wireless/ath/wil6210/wmi.c | 19 -
.../broadcom/brcm80211/brcmfma
On 10 May 2018 00:55:01 CEST, kbuild test robot wrote:
>Hi Toke,
>
>Thank you for the patch! Yet something to improve:
>
>[auto build test ERROR on wireless-drivers-next/master]
>[also build test ERROR on v4.17-rc4 next-20180509]
>[if your patch is applied to the wrong git tree, please drop us a
space")
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/net/wireless/ath/ath6kl/main.c | 14 ++
drivers/net/wireless/ath/wil6210/debugfs.c | 22 ++-
drivers/net/wireless/ath/wil6210/wmi.c | 19 -
.../broadcom/brcm80211/brcmfma
patch fixes the drivers in the main tree.
Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace")
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
fixes up the drivers.
Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace")
Signed-off-by: Toke Høiland-Jørgensen
---
net/batman-adv/bat_v_elp.c | 21 +++--
net/wireless/wext-compat.c | 29 +
2 files changed, 32
Johannes Berg writes:
>> WARN_ON is used where the function has no way to signal errors to the
>> caller.
>
> There isn't really much point in that - failing allocations are already
> *very* noisy. Please respin with that removed (and then I guess you can
> fix the Fixes: too)
OK, will do.
> Yo
Johannes Berg writes:
> On Wed, 2018-05-09 at 23:27 +0200, Toke Høiland-Jørgensen wrote:
>
>> That would be these:
>>
>> https://patchwork.kernel.org/patch/10389333/
>> https://patchwork.kernel.org/patch/10389331/
>> https://patchwork.kernel.org/patch/1038933
Johannes Berg writes:
> On Wed, 2018-05-09 at 23:12 +0200, Arend van Spriel wrote:
>> Since yesterday I get the following build error on wl-testing/master:
>>
>>CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:
.
This patch applies the fix to the rtl8723bs driver in staging while a
separate patch fixes the drivers in the main tree.
Fixes: 52539ca89f36 cfg80211: Expose TXQ stats and parameters to userspace
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 16
.
Fixes: 52539ca89f36 cfg80211: Expose TXQ stats and parameters to userspace
Signed-off-by: Toke Høiland-Jørgensen
---
drivers/net/wireless/ath/ath6kl/main.c | 14 ++
drivers/net/wireless/ath/wil6210/debugfs.c | 22 ++-
drivers/net/wireless/ath/wil6210/wmi.c
.
This patch applies the fix to batman-adv and wext-compat, while a
separate patch fixes up the drivers.
Fixes: 52539ca89f36 cfg80211: Expose TXQ stats and parameters to userspace
Signed-off-by: Toke Høiland-Jørgensen
---
net/batman-adv/bat_v_elp.c | 21 +++--
net/wireless/wext
Kalle Valo writes:
> Toke Høiland-Jørgensen writes:
>
>> Kalle Valo writes:
>>
>>> Toke Høiland-Jørgensen writes:
>>>
>>>> Kalle Valo writes:
>>>>
>>>>> Johannes Berg writes:
>>>>>
>>>
Kalle Valo writes:
> Toke Høiland-Jørgensen writes:
>
>> Kalle Valo writes:
>>
>>> Johannes Berg writes:
>>>
>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote:
>>>>> Johannes Berg writes:
>
Kalle Valo writes:
> Toke Høiland-Jørgensen writes:
>
>> Kalle Valo writes:
>>
>>> Johannes Berg writes:
>>>
>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote:
>>>>> Johannes Berg writes:
>
Kalle Valo writes:
> Johannes Berg writes:
>
>> On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote:
>>> Johannes Berg writes:
>>>
>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>> > > Johannes Berg writes:
&g
Johannes Berg writes:
> On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> Johannes Berg writes:
>>
>> > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > >
>> > > I guess these warnings come because Toke's patch increased size of
>> > > struct cfg80211_tid_stats (which is include
Kalle Valo writes:
> Jia-Ju Bai writes:
>
>> The write operation to "sc->next_chan" is protected by
>> the lock on line 1287, but the read operation to
>> this data on line 1262 is not protected by the lock.
>> Thus, there may exist a data race for "sc->next_chan".
>>
>> To fix this data race, t
: 4194304 bytes
Quantum:300 bytes
Number of queues: 4096
Backlog:12 pkts
Memory usage: 52224 bytes
Packet limit overflows: 0
Memory limit overflows: 0
Hash collisions:1
Signed-off-by: Toke Høiland-Jørgensen
---
info.c |2
MHz, center1: 5825 MHz
txpower 24.00 dBm
multicast TXQ:
qsz-byt qsz-pkt flows drops marks overlmt hashcol
tx-bytestx-packets
0 0 72 0 0 0 0 7380
72
Signed-off-by: Toke Høiland-Jørgensen
This adds support to mac80211 to export TXQ stats via the newly added
cfg80211 API.
Signed-off-by: Toke Høiland-Jørgensen
---
net/mac80211/cfg.c | 99
net/mac80211/ieee80211_i.h |3 +
net/mac80211/main.c|3 +
net/mac80211
itself.
Signed-off-by: Toke Høiland-Jørgensen
---
include/net/cfg80211.h | 50 ++
include/uapi/linux/nl80211.h | 58
net/mac80211/ethtool.c | 32 ---
net/wireless/nl80211.c | 202 --
net/wireless/rdev-ops.h
Johannes Berg writes:
> On Tue, 2018-05-08 at 12:18 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg writes:
>>
>> > net/mac80211/cfg.c:3762:12: warning: context imbalance in
>> > 'ieee80211_get_txq_stats' - different lock contexts for basic
Johannes Berg writes:
> net/mac80211/cfg.c:3762:12: warning: context imbalance in
> 'ieee80211_get_txq_stats' - different lock contexts for basic block
Found and fixed all the other warnings, but I'm not seeing this one. And
I don't really see what is wrong with the locking in that function? Wha
On 7 May 2018 23:21:30 CEST, Johannes Berg wrote:
>On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote:
>>
>> +if (header && tid >= 0)
>> +pos += snprintf(buf, buflen, "\n\t\tTID\tqsz-byt\t"
>> +
On 7 May 2018 21:13:04 CEST, Johannes Berg wrote:
>On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote:
>> This adds support for exporting the mac80211 TXQ stats via nl80211 by
>> way of a nested TXQ stats attribute, as well as for configuring the
>> quantum
Johannes Berg writes:
> On Fri, 2018-04-20 at 00:32 +0200, Bernhard Gabler wrote:
>
>> looking at the patch, I see more occurences of the outdated "IE" in a
>> constant name and function name:
>>
>> case NL80211_REGDOM_SET_BY_COUNTRY_IE:
>> or
>> reg_process_hint_country_ie()
Johannes Berg writes:
> On Thu, 2018-04-19 at 11:20 +0200, Toke Høiland-Jørgensen wrote:
>> Toke Høiland-Jørgensen writes:
>>
>> > This series adds TXQ parameters and statistics that were previously only
>> > available through debugfs to the nl80211 userspac
Toke Høiland-Jørgensen writes:
> This series adds TXQ parameters and statistics that were previously only
> available through debugfs to the nl80211 userspace interface and the
> cfg80211 kernel interface. Patches for iw to print the statistics and
> change the settings are includ
Reported-by: Bernhard Gabler
Signed-off-by: Toke Høiland-Jørgensen
---
net/wireless/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 16c7e4ef5820..ecfee5f06c76 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@
Johannes Berg writes:
> On Wed, 2018-04-18 at 16:55 +0200, Toke Høiland-Jørgensen wrote:
>>
>> Heh, that is a good point, I think. The patch below should fix it; but I
>> worry that the log lines become quite long, then? Maybe better to use
>> "country-IE&q
Bernhard Gabler writes:
> Dear all,
>
> would it be possible to re-write the log message from
> "regdomain ... dynamically updated by country IE"
> in a less ambiguous way, e.g. to:
> "regdomain ... dynamically updated by country-IE"
> "regdomain ... dynamically updated by country inf
On 24 March 2018 00:00:39 GMT, Ben Greear wrote:
>On 02/02/2018 02:36 AM, Toke Høiland-Jørgensen wrote:
>> When ath9k was switched over to use the mac80211 intermediate queues,
>> node cleanup now drains the mac80211 queues. However, this call path
>is
>> not protected
MHz, center1: 5825 MHz
txpower 24.00 dBm
multicast TXQ:
qsz-byt qsz-pkt flows drops marks overlmt hashcol
tx-bytestx-packets
0 0 72 0 0 0 0 7380
72
Signed-off-by: Toke Høiland-Jørgensen
Arend van Spriel writes:
>>> So can we expect some manual in which is described what parameter
>>> should be tweaked based on the retrieved statistics.
>>
>> Heh, not sure I'll promise a whole manual, but I am happy to write a
>> blog post (or wiki page if that's better) explaining what these val
Arend van Spriel writes:
> On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote:
>> This series adds TXQ parameters and statistics that were previously only
>> available through debugfs to the nl80211 userspace interface and the
>> cfg80211 kernel interface. Patches for iw to
sdnlabs Janakaraj writes:
> Hello Toke,
> Thanks for sharing this information.
>
> I took a look at Flent yesterday and planning to test it by the
> weekend due to something things I have to catch up with.
Awesome! Let me know if you run into any problems :)
-Toke
Steve deRosier writes:
> On Mon, Feb 19, 2018 at 9:19 AM, sdnlabs Janakaraj
> wrote:
>>
>> Hello All,
>>
>> I am working on delay analysis of packets in wireless stacks. I am
>> able to see lots of papers talk about therotical analysis. But I am
>> more interested in practical evaluation.
>>
>>
MHz, center1: 5825 MHz
txpower 24.00 dBm
Multicast TXQ:
qsz-byt qsz-pkt flows drops marks overlmt hashcol
tx-bytestx-packets
0 0 72 0 0 0 0 7380
72
Signed-off-by: Toke Høiland
es to nl80211.h in the iw
patchset, so I didn't :)
-Toke
Kernel patch:
Toke Høiland-Jørgensen (1):
cfg80211: Expose TXQ stats and parameters to userspace
include/net/cfg80211.h | 52 +++
include/uapi/linux/nl80211.h | 57 +
net/mac80211/cfg.c
This adds support for exporting the mac80211 TXQ stats via nl80211 by
way of a nested TXQ stats attribute, as well as for configuring the
quantum and limits that were previously only changeable through debugfs.
Signed-off-by: Toke Høiland-Jørgensen
---
include/net/cfg80211.h | 50
memory_limit 1024000
# iw phy phy0 set txq quantum 1000
Signed-off-by: Toke Høiland-Jørgensen
---
info.c | 3 ++
phy.c | 116 +
2 files changed, 119 insertions(+)
diff --git a/info.c b/info.c
index 1eba5c9..291cf24 100644
--- a/info.c
Johannes Berg writes:
> On Mon, 2018-02-19 at 21:51 +0800, kbuild test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git
>> master
>> head: 49241828e8ed0b0a3dc73466d5bc562ae90acfd6
>> commit: 96bd4b9e4a44c6c1da93fd3e48bd8eb1b332584a [6/11] mac80211: Adj
On 14 February 2018 01:43:25 CET, Ryan Hsu wrote:
>On 02/02/2018 07:11 AM, Toke Høiland-Jørgensen wrote:
>
>> Since we now have the convenient helper to do so, actually adjust the
>> TSQ pacing shift for packets going out over a WiFi interface. This
>> significantly
201 - 300 of 491 matches
Mail list logo
