Re: [RFC 0/5] ath6kl: non WMI data service support

2016-10-13 Thread Valo, Kalle
Steve deRosier writes: > Hi Eric, > > On Thu, Oct 13, 2016 at 9:39 AM, Erik Stromdahl > wrote: >> This patch series is intended to prepare the ath6kl driver >> for newer chipsets that doesn't use the current WMI data >> endpoints for data traffic.

Re: [RFC 0/5] ath6kl: non WMI data service support

2016-10-13 Thread Steve deRosier
Hi Eric, On Thu, Oct 13, 2016 at 9:39 AM, Erik Stromdahl wrote: > This patch series is intended to prepare the ath6kl driver > for newer chipsets that doesn't use the current WMI data > endpoints for data traffic. > > The chipset I have been working with (and used for

Re: [PATCH] cfg80211: Add support to update connection parameters

2016-10-13 Thread Arend van Spriel
On 13-10-16 17:39, Jouni Malinen wrote: > From: vamsi krishna > > Add functionality to update the connection parameters when in connected > state, so that driver/firmware uses the updated parameters for > subsequent roaming. This is for drivers that support internal BSS

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:55 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: > >  Even though there is apparently something wrong with this part of the > > ACPI table on you laptop, since it doesn't match our specifications. > >  In any case, it's mostly harmless. >

[RFC 4/5] ath6kl: Updated credit setup

2016-10-13 Thread Erik Stromdahl
This patch simplifies the credit setup and removes a dependency from htc_mbox.c. The service priority (the order in which the endpoint credits are added in target->cred_dist_list) is now determined by the sequence in which the host connects to services. The HTC control endpoint will have highest

[RFC 1/5] ath6kl: HTC mbox tx complete cb support

2016-10-13 Thread Erik Stromdahl
The current implementation always call ath6kl_tx_complete regardless if a tx_complete callback has been associated with the endpoint or not. This patch fixes this by calling the associated callback in case it is present. Signed-off-by: Erik Stromdahl ---

[RFC 0/5] ath6kl: non WMI data service support

2016-10-13 Thread Erik Stromdahl
This patch series is intended to prepare the ath6kl driver for newer chipsets that doesn't use the current WMI data endpoints for data traffic. The chipset I have been working with (and used for testing) is QCA6584. It is SDIO based (at least the variant I have been using) with 802.11p WAVE DSRC

[RFC 5/5] ath6kl: service connect rewrite

2016-10-13 Thread Erik Stromdahl
This patch removes the hardcoded struct htc_service_connect_req from ath6kl_init_service_ep and adds an array of struct htc_service_connect_req's to each element in hw_list. The rationale behind this patch is to make it possible to select which services to connect to depending on chipset.

[RFC 2/5] ath6kl: Updated TARG_VTOP macro with default value

2016-10-13 Thread Erik Stromdahl
A minor modification of the TARG_VTOP macro. The AR6004 VTOP macro is used as default (for all chip's except AR6003) Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath6kl/target.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[RFC 3/5] ath6kl: Added disable credit flow ctrl for mbox

2016-10-13 Thread Erik Stromdahl
Added support for disabling credit flow control for htc_mbox in a similar way as htc_pipe. The tx_credit_flow_enabled member was moved out from the pipe struct in struct htc_endpoint since it is now used by htc_mbox as well. Signed-off-by: Erik Stromdahl ---

[PATCH] cfg80211: Add support to update connection parameters

2016-10-13 Thread Jouni Malinen
From: vamsi krishna Add functionality to update the connection parameters when in connected state, so that driver/firmware uses the updated parameters for subsequent roaming. This is for drivers that support internal BSS selection and roaming. The new command does not

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/14/16 00:00), Sergey Senozhatsky wrote: > kernel: [] ieee80211_crypto_ccmp_decrypt+0x204/0x298 > kernel: [] ieee80211_rx_handlers+0x7df/0x1c1d > kernel: [] ieee80211_prepare_and_rx_handle+0xdc2/0xe79 > kernel: [] ? ieee80211_rx_napi+0x168/0x7b6 > kernel: []

[PATCH v3] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

2016-10-13 Thread Purushottam Kushwaha
This commit enhances the current beacon interval validation to also consider the "radar_detect" and "num_different_channels". Move calculation of GCD for all beaconing interfaces to "cfg80211_iter_combinations". Rename "cfg80211_validate_beacon_int" to "cfg80211_validate_beacon_combination" as

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
SMP kernel: Modules linked in: nls_iso8859_1 nls_cp437 vfat fat mousedev psmouse serio_raw atkbd libps2 i915 coretemp i2c_algo_bit hwmon crc32c_intel mxm_wmi drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect iwlmvm sysimgblt fb_sys_fops i2c_i801 cfbcopyarea ie31200_edac drm iwlwifi i2c

Re: [1/2] ath9k: change entropy formula for easier understanding

2016-10-13 Thread Kalle Valo
miaoqing pan wrote: > From: Miaoqing Pan > > The quality of ADC entropy is 10 bits of min-entropy for > a 32-bit value, change '(((x) * 8 * 320) >> 10)' to > '(((x) * 8 * 10) >> 5)' for easier understanding. > > Signed-off-by: Miaoqing Pan

Re: ath10k: Fix kernel panic due to race in accessing arvif list

2016-10-13 Thread Kalle Valo
Vasanthakumar Thiagarajan wrote: > arvifs list is traversed within data_lock spin_lock in tasklet > context to fill channel information from the corresponding vif. > This means any access to arvifs list for add/del operations > should also be protected with the same

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Johannes Berg
On Thu, 2016-10-13 at 22:42 +0900, Sergey Senozhatsky wrote: >  > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > > t/?h=x86/vmap_stack=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > >

Re: [PATCH v2] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

2016-10-13 Thread Valo, Kalle
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > 'ath10k_htt_rx_h_unchain' needs to be called only if the return > value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this > change makes it more explicit and

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/13/16 22:42), Sergey Senozhatsky wrote: > > On (10/13/16 08:02), Johannes Berg wrote: > > On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > > > > > In a pinch, I have these patches sitting around: > > > > > >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Chris Rorvick
Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick I think the debug output looks as expected, see below for

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/13/16 08:02), Johannes Berg wrote: > On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > > > In a pinch, I have these patches sitting around: > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > >

Re: ath10k: fix debug cal data file

2016-10-13 Thread Kalle Valo
Nikolay Martynov wrote: > It got broken by 0b8e3c4ca29fe2c0efd3d41a76e34a657b9f17a4 > > Signed-off-by: Nikolay Martynov Actually Marty's patch fixed this in a better way so I actually took that instead: f67b107d4ced ath10k: cache calibration data when

Re: [PATCH v10] cfg80211: Provision to allow the support for different beacon intervals

2016-10-13 Thread Johannes Berg
On Wed, 2016-10-12 at 18:26 +0530, Purushottam Kushwaha wrote: > This commit provides a mechanism for the host drivers to advertise > the > support for different beacon intervals among the respective interface > combinations in a group, through beacon_int_min_gcd (u32). > This beacon_int_min_gcd

[PATCH 2/3] rsi: Host to device command frame vap_capabilites modified with new field vap status

2016-10-13 Thread Prameela Rani Garnepudi
* Command frame vap_capabilites is modified to use for vap add, vap delete and vap update in firmware, hence new filed vap status is added. * When interface is down this frame needs to be send with vap status delete. Otherwise it is considered as wrong frame for the same interface in firmware.

Re: [PATCH 1/3] rsi: Fix memory leak in module unload

2016-10-13 Thread Kalle Valo
Prameela Rani Garnepudi writes: > Observed crash when module is unloaded if CONFIG_RSI_DEBUGSFS is not set. > Fix: Debugfs entry removal moved inside CONFIG_RSI_DEBUGSFS flag in > function rsi_mac80211_detach() > Memory leak found and fixed for below

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: >  Even though there is apparently something wrong with this part of the > ACPI table on you laptop, since it doesn't match our specifications. >  In any case, it's mostly harmless. Would a correct implementation by Dell have any benefits for

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

2016-10-13 Thread Johannes Berg
> If the firmware/NIC is putting it on air at a particular encoding, > then I think the stack should report it exactly as it is on air if > possible. It already does. We're only debating what bitrate to report :P Anyway, I don't have the latest patch anymore - somebody please resend it.

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:36 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > > I forgot to say... could you load the iwlwifi module with debug=0x01 > > (module parameter), so we can see the messages the driver is printing > > when it doesn't find a proper

Re: [PATCH 3/3] rsi: Updated boot parameters

2016-10-13 Thread Kalle Valo
Prameela Rani Garnepudi writes: > * Switch clock info is divided in to different clock information fields for > readability and synchronization with firmware code. > * Other parameters are added for future use and to make the frame size in sync > with latest

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > I forgot to say... could you load the iwlwifi module with debug=0x01 > (module parameter), so we can see the messages the driver is printing > when it doesn't find a proper structure? That makes a lot of noise! Here's the first 100 lines or

[PATCH 1/3] rsi: Fix memory leak in module unload

2016-10-13 Thread Prameela Rani Garnepudi
Observed crash when module is unloaded if CONFIG_RSI_DEBUGSFS is not set. Fix: Debugfs entry removal moved inside CONFIG_RSI_DEBUGSFS flag in function rsi_mac80211_detach() Memory leak found and fixed for below structures in function rsi_mac80211_detach() * channel

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 13:27 +0200, Paul Bolle wrote: > Luca, > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Paul Bolle

Re: [PATCH v10] cfg80211: Provision to allow the support for different beacon intervals

2016-10-13 Thread Johannes Berg
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -421,6 +421,8 @@ static int brcmf_vif_change_validate(struct > brcmf_cfg80211_info *cfg, >   .num_different_channels = 1, >  

Re: [PATCH v2] cfg80211: Create structure for combination check/iter function parameters

2016-10-13 Thread Johannes Berg
On Wed, 2016-10-12 at 18:25 +0530, Purushottam Kushwaha wrote: > Move growing parameter list to a structure for check/iter combination > functions in cfg80211 and mac80211. > Thanks, applied. johannes

[PATCH 3/3] rsi: Updated boot parameters

2016-10-13 Thread Prameela Rani Garnepudi
* Switch clock info is divided in to different clock information fields for readability and synchronization with firmware code. * Other parameters are added for future use and to make the frame size in sync with latest firmware. Otherwise firmware will discard the frame considering corrupted

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle Not that this test was worth a lot: it builds cleanly (on top of

Re: ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

2016-10-13 Thread Kalle Valo
Alan Cox wrote: > From: Adam Williamson > > SDIO ID 0271:0418 > > Signed-off-by: Alan Cox > Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921 > Reviewed-by: Steve deRosier > >

Re: Revert "ath9k_hw: implement temperature compensation support for AR9003+"

2016-10-13 Thread Kalle Valo
Felix Fietkau wrote: > This reverts commit 171f6402e4aa5cd3b8407f82501f7ea21fa54ccc. > Some users report that this commit causes a regression in performance > under some conditions. > > Signed-off-by: Felix Fietkau Patch applied to ath-current branch of ath.git,

Re: [v3] ath10k: cache calibration data when the core is stopped

2016-10-13 Thread Kalle Valo
Kalle Valo wrote: > From: Marty Faltesek > > Commit 0b8e3c4ca29f ("ath10k: move cal data len to hw_params") broke > retrieving > the calibration data from cal_data debugfs file. The length of file was always > zero. The reason is: > > static

[PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
From: Luca Coelho The SPLC data parsing is too restrictive and was not trying find the correct element for WiFi. This causes problems with some BIOSes where the SPLC method exists, but doesn't have a WiFi entry on the first element of the list. The domain type values

Re: [V2] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-13 Thread Kalle Valo
Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-13 Thread Luca Coelho
On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: > Hi Luca, > > FYI, It seems that Google does not like your email as I'm not > receiving any of your messages in gmail. Some responses below: That's odd. It works for me. Replied privately to try to sort this out. > On Wed, 2016-10-12

Re: [PATCHv4] mac80211: fix A-MSDU outer SA/DA

2016-10-13 Thread Felix Fietkau
On 2016-10-13 07:41, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA > of A-MSDU frames need to be changed depending on FromDS/ToDS values. > > Signed-off-by: Michael Braun > > -- > v4: > - h_80211_src/dst has been

Re: [PATCHv4] mac80211: fix A-MSDU outer SA/DA

2016-10-13 Thread Johannes Berg
Hi, I think this looks good now. I'd prefer, however, doing the reorg that gets rid of the memcpy() separately, that's now more or less orthogonal to the changes you're making. I suspect it's due to you having just edited the original, rather than starting from scratch, but I think it makes sense

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Johannes Berg
On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > In a pinch, I have these patches sitting around: > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd >