Re: [PATCH] mac80211: rewrite Kconfig text for mesh

2018-12-04 Thread Steve deRosier
For more information visit http://o11s.org/. > + Select this option to enable 802.11 mesh operation in mac80211 > + drivers that support it. 802.11 mesh connects multiple stations > + over (possibly multi-hop) wireless links to form a single logical > + LAN. > Looks good to me. Reviewed-by: Steve deRosier - Steve

Re: Where to report mpdus tx vs failed?

2018-10-19 Thread Steve deRosier
On Fri, Oct 19, 2018 at 10:34 AM Ben Greear wrote: > > While debugging rate-ctrl in ath10k, I found the amount of mpdus transmitted > vs failed > ratio useful. Probably more useful than retries since retries could count an > attempt at > 80Mhz followed by HW trying a 40Mhz rate (afaik). > > Is

Re: list archive

2018-09-25 Thread Steve deRosier
On Tue, Sep 25, 2018 at 12:22 AM Johannes Berg wrote: > > Hi all, > > Konstantin has graciously added this list to lore, so we now have a web > archive here: > > https://lore.kernel.org/linux-wireless > That is fantastic! Thank you Konstantin, Johannes, and Jouni! While the development on this

Re: Build iw for 32bit ARM

2018-08-31 Thread Steve deRosier
Hi Jakov, On Fri, Aug 31, 2018 at 5:59 AM Jakov Simunic wrote: > > Hello, > I am working on an embedded project which uses an armv7l architecture, which > is a 32bit platform, and I am trying to compile iw-4.9 for it, and I don't > know how to compile it for 32bit arches. Unless you're

Re: [PATCH v2] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Steve deRosier
band_2gig = true; > break; > case WMI_11AGN_CAP: > ht = true; > + /* fall through */ > case WMI_11AG_CAP: > band_2gig = true; > band_5gig = true; > -- > 2.7.4 Gustavo, Thanks for the adjustment. It now looks good to me. Reviewed-by: Steve deRosier <deros...@cal-sierra.com>

Re: [PATCH] Added Dell Wireless 1537 Ath6kl sdio card (0x19) to the list.

2018-05-21 Thread Steve deRosier
Hi Guy, On Mon, May 21, 2018 at 9:28 AM Guy Chronister wrote: > Signed-off-by: Guy Chronister > --- > drivers/net/wireless/ath/ath6kl/sdio.c | 1 + > 1 file changed, 1 insertion(+) > diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c

Re: [PATCH] ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Steve deRosier
On Fri, Apr 27, 2018 at 9:57 AM Alfonso Sanchez-Beato < alfonso.sanchez-be...@canonical.com> wrote: > Hi Steve, > On Fri, Apr 27, 2018 at 5:47 PM, Steve deRosier <deros...@gmail.com> wrote: > > Hi Alfonso, > > > > On Thu, Apr 12, 2018 at 8:42 AM Alfonso

Re: [PATCH] ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Steve deRosier
gt; + > #endif /* WMI_H */ > -- > 2.14.1 From your answer to Kalle re: what hardware > I have tested this in an Atheros QCA6234. kmsg shows this about the fw: > ath6kl: ar6004 hw 3.0 sdio fw 3.5.0.604 api 1 > ath6kl: firmware supports: 64bit-rates,ap-inactivity-mins The firmware you're using is old. Mine for the QCA6234 is more advanced than that and has the rsn-cap-override flag, but even the stock one in linux-firmware is more up-to-date: 3.5.0.2356 api 3. I haven't run it recently to see if it also has the rsn-cap-override flag, but it might. Maybe you can try the current firmware to see if it solves your issue? Thanks, - Steve -- Steve deRosier Cal-Sierra Consulting https://www.cal-sierra.com/

Re: ath confusing log message "country IE"

2018-04-18 Thread Steve deRosier
On Wed, Apr 18, 2018 at 7:55 AM, Toke Høiland-Jørgensen wrote: > Bernhard Gabler writes: > >> Dear all, >> >> would it be possible to re-write the log message from >> "regdomain ... dynamically updated by country IE" >> in a less ambiguous way, e.g. to:

Re: second wifi card enforce CN reg dom

2018-04-12 Thread Steve deRosier
s probably a CN radio and is hard-coded to do that. And, the intersection of your FR regulatory domain and the CN is what it is. Have you plugged it in alone? And if so, can you get it on FR or does it stay on CN? - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: second wifi card enforce CN reg dom

2018-04-12 Thread Steve deRosier
rules down further. You asked who to contact. Its not the LKML - it's your relevant government body. And certain manufacturers who improperly interpret said rules because it's easier for them. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: RTL8723BE performance regression

2018-04-04 Thread Steve deRosier
18 That's the most basic setup, check the man page for more options. You will get best results if you can exclude other computers from your test network and other wireless devices from your airspace. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: Wi-Fi Disconnection on Suspend for no wowlan triggers

2018-04-03 Thread Steve deRosier
don't have a terribly high chance of getting merged. But solutions to real-life actual problems do. And it's really difficult for us to speak on vague hypothetical musings. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

2018-03-28 Thread Steve deRosier
On Tue, Mar 27, 2018 at 11:09 PM, <vthia...@codeaurora.org> wrote: > On 2018-03-27 22:18, Steve deRosier wrote: >> >> Hi Vasanthakumar, >> >> On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan >> <vthia...@codeaurora.org> wrote: >>&g

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

2018-03-27 Thread Steve deRosier
Hi Vasanthakumar, On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan wrote: > Adds infrastructure for driver to offload NoAck functionality, driver > like ath10k could make use of it. Also extends the current ndev wide I'm not really much of a fan of adding a

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Steve deRosier
On Tue, Mar 20, 2018 at 8:39 AM, Ben Greear wrote: > On 03/20/2018 03:37 AM, Michal Kubecek wrote: >> >> On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> This is similar to ETHTOOL_GSTATS,

Re: brcmfmac signal/interference issues

2018-03-08 Thread Steve deRosier
tus with this particular chip) in Linux. I see WiFi and BT interfering with each other frequently in my testing setups with my dev boards. Often I can magically make problems go away by simply pulling the enable line high (which is "off"). - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: Max clients on wifi access point with 7265

2018-02-27 Thread Steve deRosier
ve worked with, the number is not specified by QCA and was only determined by us via experimentation. And even on the same chip, it'll change with firmware version as the necessary resources get consumed by new features or fixes. If the firmware can send that number up to the driver (or the driver can reliably know it because it can't change), then expose it, but otherwise I'd advise publishing a value of 0. I'd rather see the unknown flag rather than relying on a number that may or may not be accurate. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: Support on vendor id and device id

2018-02-27 Thread Steve deRosier
nks for bringing this issue up. Something I haven't thought about in a long time but I'm adding it to my talk at ELC on WiFi module interfacing. http://sched.co/DXn3 - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: Support on vendor id and device id

2018-02-27 Thread Steve deRosier
Hi Harsha, On Tue, Feb 27, 2018 at 7:29 AM, Harsha Rao wrote: > On Tue, Feb 27, 2018 at 8:44 PM, Larry Finger > wrote: >> On 02/27/2018 07:30 AM, Harsha Rao wrote: >>> >>> On Tue, Feb 27, 2018 at 4:45 PM, Arend van Spriel >>>

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-27 Thread Steve deRosier
/net/wireless/ath/ath10k/gpio.c Assuming that kbuild robot doesn't kick back another build-time warning, it looks OK to me. Reviewed-by: Steve deRosier <deros...@cal-sierra.com> -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [PATCH v9] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-22 Thread Steve deRosier
Hi Sebastian, On Thu, Feb 22, 2018 at 6:09 PM, Sebastian Gottschall <s.gottsch...@dd-wrt.com> wrote: > Am 22.02.2018 um 23:17 schrieb Steve deRosier: >> >> On Thu, Feb 22, 2018 at 3:15 AM, <s.gottsch...@dd-wrt.com> wrote: >>> >>> From: Sebas

Re: [PATCH v9] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-22 Thread Steve deRosier
like `ath10k_core-$(CONFIG_GPIO) += gpoi.o`. Maybe I'm mistaken. (Note, I didn't look up the actual config option name, I'm guessing. Assume I wrote something reasonable for my example.) I only ask the above two questions, not because I think it's wrong, but because I don't quite know the intention and it makes me wonder. Other than those questions, which are optional as the code looks correct to me, the rest of it looks fine to me. Reviewed-by: Steve deRosier <deros...@cal-sierra.com> - Steve

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Steve deRosier
On Tue, Feb 20, 2018 at 10:06 AM, Sebastian Gottschall <s.gottsch...@dd-wrt.com> wrote: > Am 20.02.2018 um 17:52 schrieb Steve deRosier: >> >> >>> +static int ath10k_register_gpio_chip(struct ath10k *ar) >>> +{ >>> + struct ath10k_gpiocontrol

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Steve deRosier
-8364,6 +8406,8 @@ static const struct wmi_ops wmi_10_2_4_ops = { > .gen_pdev_enable_adaptive_cca = > ath10k_wmi_op_gen_pdev_enable_adaptive_cca, > .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype, > + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config, > + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output, > /* .gen_bcn_tmpl not implemented */ > /* .gen_prb_tmpl not implemented */ > /* .gen_p2p_go_bcn_ie not implemented */ > @@ -8439,6 +8483,8 @@ static const struct wmi_ops wmi_10_4_ops = { > .gen_pdev_bss_chan_info_req = > ath10k_wmi_10_2_op_gen_pdev_bss_chan_info, > .gen_echo = ath10k_wmi_op_gen_echo, > .gen_pdev_get_tpc_config = > ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config, > + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config, > + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output, > }; > > int ath10k_wmi_attach(struct ath10k *ar) > diff --git a/drivers/net/wireless/ath/ath10k/wmi.h > b/drivers/net/wireless/ath/ath10k/wmi.h > index c7b30ed9015d..dc180a86dc3b 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.h > +++ b/drivers/net/wireless/ath/ath10k/wmi.h > @@ -2906,6 +2906,42 @@ enum wmi_10_4_feature_mask { > > }; > > +/* WMI_GPIO_CONFIG_CMDID */ > +enum { > +WMI_GPIO_PULL_NONE, > +WMI_GPIO_PULL_UP, > +WMI_GPIO_PULL_DOWN, > +}; > + > +enum { > +WMI_GPIO_INTTYPE_DISABLE, > +WMI_GPIO_INTTYPE_RISING_EDGE, > +WMI_GPIO_INTTYPE_FALLING_EDGE, > +WMI_GPIO_INTTYPE_BOTH_EDGE, > +WMI_GPIO_INTTYPE_LEVEL_LOW, > +WMI_GPIO_INTTYPE_LEVEL_HIGH > +}; > + > +/* WMI_GPIO_CONFIG_CMDID */ > +struct wmi_gpio_config_cmd { > +__le32 gpio_num; /* GPIO number to be setup */ > +__le32 input;/* 0 - Output/ 1 - Input */ > +__le32 pull_type;/* Pull type defined above */ > +__le32 intr_mode;/* Interrupt mode defined above (Input) */ > +} __packed; > + > +/* WMI_GPIO_OUTPUT_CMDID */ > +struct wmi_gpio_output_cmd { > +__le32 gpio_num;/* GPIO number to be setup */ > +__le32 set; /* Set the GPIO pin*/ > +} __packed; > + > +/* WMI_GPIO_INPUT_EVENTID */ > +struct wmi_gpio_input_event { > +__le32 gpio_num;/* GPIO number which changed state */ > +} __packed; > + > + > struct wmi_ext_resource_config_10_4_cmd { > /* contains enum wmi_host_platform_type */ > __le32 host_platform_config; > -- > 2.14.1 > The rest of this looks OK to me. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: testing tool for packet delay

2018-02-19 Thread Steve deRosier
might be relevant. If you're going, please stop by and say hi. http://sched.co/DXn3 I hope that helps. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [PATCH] v2 ath10k: add LED and GPIO controlling support for various chipsets

2018-02-16 Thread Steve deRosier
On Fri, Feb 16, 2018 at 2:30 AM, wrote: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 and > ipq4019 based chipsets with on chipset connected led's > using WMI Firmware API. > The LED

Re: Max clients on wifi access point with 7265

2018-02-14 Thread Steve deRosier
r-man APs. While it will work for very limited number of clients, they're not intended as AP chips. If you want something to work as an AP, I recommend you choose an AP chip. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Steve deRosier
On Wed, Feb 14, 2018 at 8:26 AM, Jean Pierre TOSONI wrote: > ath9k returns a wrong RSSI value for frames received in a 30ms time > window after a channel change. The correct value is typically 10dB > below the returned value. > > This was found with a Atheros AR9300 Rev:3

Presentation at ELC on debugging wifi modules

2018-02-12 Thread Steve deRosier
Hi Linux Wireless driver maintainers, I'm giving a talk at ELC NA next month in Portland and I'd like a little help from our other driver maintainers. The talk is titled: "Reliable Linux Wireless - Techniques for Debugging Wireless Module Integrations". While I'm familiar with a fairly wide

Re: [RFC v4 00/18] ath10k high latency

2017-12-31 Thread Steve deRosier
Hi Erik, On Sun, Dec 31, 2017 at 9:29 AM, Erik Stromdahl wrote: > Uplink test results (WUSB6100M -> other computer): > > # iperf-client.sh 192.168.1.244 > /usr/bin/iperf > > Client connecting to 192.168.1.244,

Re: [PATCH] ath6kl: remove redundant variable ies_len

2017-11-27 Thread Steve deRosier
return -EINVAL; > - ies_len = info->beacon.head + info->beacon.head_len - ies; > > if (info->ssid == NULL) > return -EINVAL; Oddly, ies_len was never even used in the original patch that added it. Probably used in some debugging code that was stripped before submitting. Seems safe to kill it. Reviewed-by: Steve deRosier <deros...@gmail.com> - Steve

Re: ath6kl : intermittent Wi-Fi on Fedora 27 (Linux 4.13.12-300)

2017-11-17 Thread Steve deRosier
Hi Ken, On Fri, Nov 17, 2017 at 11:58 AM, Ken Harris wrote: > Yesterday, I installed Fedora 27 on a Dell Venue 8 Pro (5830). > > I installed the ath6kl firmware from https://github.com/qca/ath6kl-firmware/ > > The Wi-Fi works for a while, but then stops. It seems to start up >

Re: PS-Poll not behaving as expected

2017-11-13 Thread Steve deRosier
Hi Daniel, On Mon, Nov 13, 2017 at 2:40 PM, Daniel Ghansah wrote: >Here is the problem we experience: > > When the station (wifi devices) sends a null QoS frame with power save > telling our AP that it is going into power save mode. RIght now, our > problem is that

Re: [PATCH] iw: add command to register and capture mgmt frames

2017-10-14 Thread Steve deRosier
Hi Sergey, On Sat, Oct 14, 2017 at 2:00 PM, Sergey Matyukevich wrote: > Add new command to register for receiving multiple mgmt frames, > capture and print them. Frames are selected by their type and > pattern containing their the first several bytes of the

Re: [PATCH 02/11] ath10k_sdio: wb396 reference card fix

2017-10-01 Thread Steve deRosier
Hi Alagu, On Sat, Sep 30, 2017 at 10:37 AM, wrote: > > From: Alagu Sankar > > The QCA9377-3 WB396 sdio reference card does not get initialized > due to the conflict in uart gpio pins. This fix is not required > for other QCA9377 sdio cards. >

carl9170 issue with sniffer mode and dropping probe responses

2017-09-29 Thread Steve deRosier
=134517238506033 [3] https://bugs.kali.org/view.php?id=4220 >From c46a994dd78befbe94e66771db41c18351be2aae Mon Sep 17 00:00:00 2001 From: Steve deRosier <deros...@cal-sierra.com> Date: Fri, 29 Sep 2017 10:48:19 -0700 Subject: [PATCH] wireless: carl9170: Enable sniffer mode promisc flag to fix

Re: Kernel developer to work on wifi injection in mainline

2017-09-14 Thread Steve deRosier
Hi Raphael, On Thu, Sep 14, 2017 at 7:31 AM, Raphael Hertzog wrote: > (Please keep-me in CC and use reply-to all) > ... > > Thus we are looking for a kernel developer that we could work with on a > contractor basis to: > - make wifi injection work on the current Kali kernel on

Re: [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend

2017-09-04 Thread Steve deRosier
ey eric.bent...@lairdtech.com I've tested the patch on my platforms and works as expected. Eric, please add my: Tested-by: Steve deRosier <deros...@gmail.com> Thanks, - Steve

Re: [PATCH] Correctly fail to suspend when SDIO does not support power on suspend

2017-08-31 Thread Steve deRosier
On Thu, Aug 31, 2017 at 4:44 PM, Eric Bentley wrote: > - if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags)) > + if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags)) ( Hi Eric, Shouldn't that be a '{' instead of '('? Maybe I'm missing some

Re: [PATCH v4] brcmfmac: add CLM download support

2017-08-28 Thread Steve deRosier
On Mon, Aug 28, 2017 at 2:25 AM, Wright Feng wrote: > From: Chung-Hsien Hsu > > The firmware for brcmfmac devices includes information regarding > regulatory constraints. For certain devices this information is kept > separately in a binary form

Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

2017-08-09 Thread Steve deRosier
> > /* table of devices that work with this driver */ > -static struct usb_device_id ath6kl_usb_ids[] = { > +static const struct usb_device_id ath6kl_usb_ids[] = { > {USB_DEVICE(0x0cf3, 0x9375)}, > {USB_DEVICE(0x0cf3, 0x9374)}, > { /* Terminating entry *

Re: [PATCH] ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

2017-06-04 Thread Steve deRosier
t;__func__, packet); > action = ep->ep_cb.tx_full(ep->target, > packet); > if (action == HTC_SEND_FULL_DROP) { > -- > 2.11.0 > Looks good to me. Reviewed-by: Steve deRosier <deros...@gmail.com> - Steve

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-05-12 Thread Steve deRosier
Hi Ben, On Fri, May 12, 2017 at 7:12 AM, Ben Greear wrote: > > > On 05/11/2017 04:38 AM, Kalle Valo wrote: >> >> Simon Wunderlich writes: >> >>> it seems like there was some discussion here and I wouldn't expect too >>> many >>> more opinions

Re: [PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Steve deRosier
Hi Adrian, On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > diff --git a/drivers/net/wireless/ath/ath10k/debug.h > b/drivers/net/wireless/ath/ath10k/debug.h > index 257d10985c6e..7bd461927029 100644 > --- a/drivers/net/wireless/ath/ath10k/debug.h > +++

Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

2017-04-26 Thread Steve deRosier
On Wed, Apr 26, 2017 at 12:54 PM, James Hughes <james.hug...@raspberrypi.org> wrote: > On 26 April 2017 at 19:03, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> >> >> On 26-4-2017 17:44, Steve deRosier wrote: >>> On Wed, Apr 26, 2017 at 1:5

Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

2017-04-26 Thread Steve deRosier
On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo wrote: > Arend Van Spriel wrote: >> An issue was found brcmfmac driver in which a skbuff in .start_xmit() >> callback was actually cloned. So instead of checking for sufficient >> headroom it should

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-04-18 Thread Steve deRosier
Hi, (sorry, resending due to my not noticing that gmail had changed my default compose mode to HTML. Why does it randomly do that sometimes?!?!) On Tue, Apr 18, 2017 at 7:50 AM, Simon Wunderlich wrote: > > Hi, > > On Tuesday, April 18, 2017 2:36:54 PM CEST Kalle Valo

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: >> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches <j...@perches.com> wrote: >> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrot

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches <j...@perches.com> wrote: >> > Fix fallout too. > [] >> My only ques

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
intf format verification on the clauses that get compiled out?" So, it looks good to me as is, or if you feel like making the change I'm suggesting, that's fine too. And it builds and runs on my platforms. Reviewed-by: Steve deRosier <deros...@gmail.com> - Steve

Re: [PATCH v9] Add new mac80211 driver mwlwifi.

2017-02-07 Thread Steve deRosier
On Tue, Feb 7, 2017 at 10:15 PM, David Lin <d...@marvell.com> wrote: >> Rafał Miłecki [mailto:zaj...@gmail.com] wrote: >> On 7 February 2017 at 20:12, Steve deRosier <deros...@gmail.com> wrote: >> >> + /* look for all matching property names */ >> >>

Re: [PATCH v9] Add new mac80211 driver mwlwifi.

2017-02-07 Thread Steve deRosier
Hi David, First off, I wanted to say thank-you for your work and effort in trying to get mwlwifi upstream. My comments are in-line with my general notes afterwards. On Tue, Dec 20, 2016 at 8:11 PM, David Lin wrote: > diff --git a/drivers/net/wireless/marvell/mwlwifi/debugfs.h

Re: [RFC 0/5] ath6kl: non WMI data service support

2016-10-13 Thread Steve deRosier
Hi Eric, On Thu, Oct 13, 2016 at 9:39 AM, Erik Stromdahl wrote: > This patch series is intended to prepare the ath6kl driver > for newer chipsets that doesn't use the current WMI data > endpoints for data traffic. > > The chipset I have been working with (and used for

Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

2016-10-12 Thread Steve deRosier
his if the chip does indeed identify itself this way. So please fix the subject and you can add: Reviewed-by: Steve deRosier <steve.deros...@lairdtech.com> - Steve

Re: [PATCH] ath6kl: enable firmware crash dumps on the AR6004

2016-08-03 Thread Steve deRosier
T_AR6003 to reflect support on both chips. > > Signed-off-by: Dan Kephart <dan.keph...@lairdtech.com> Since ath6kl only supports the 6003 and 6004, this looks fine to me and works OK on my platforms. Reviewed-by: Steve deRosier <steve.deros...@lairdtech.com> -- To unsubscribe fro

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Steve deRosier
Hi Julian, First off, let me say I do appreciate your comments and I do understand your perspective. I also generally prefer not to let users shoot-themselves in the foot if it's avoidable. In this case, however, I don't happen to agree with you. For one specific reason: I don't want to say what

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Steve deRosier
Hi Julian, Thanks for looking at the patch. On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby wrote: > Hi Steve, > > This looks like it's using standard serial rates. Does it accept > non-standard rates? If not, should this be checked before being passed > to the hardware?

[PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-15 Thread Steve deRosier
It's useful to permit the customization of the debug uart baud rate. Enable this and send down the value to the chip if we're enabling debug. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/core.c | 3 +++ drivers/net/wireless/ath/ath6kl/

[PATCH] ath6kl: fix missing uart debug pin for 6004 HW 3.0

2016-04-15 Thread Steve deRosier
For some reason, the 6004 HW 3.0 definition was missing the value for the uarttx_pin (used for firmware debug). This corrects this situation. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/init.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] ath6kl: ignore WMI_TXE_NOTIFY_EVENTID based on fw capability flags

2016-03-07 Thread Steve deRosier
method we guard the sending of the WMI_SET_TXE_NOTIFY_CMDID command, we can ignore the spurious event that we don't know how to process. Without this change we call cfg80211_cqm_txe_notify() with possibly bad data. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wi

[PATCH v3 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-22 Thread Steve deRosier
the CHIP_PWD_L pin if the implementer so desires. This code is only available if GPIOLIB is configured. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/sdio.c | 70 +- 1 file changed, 69 insertions(+), 1 de

[PATCH v3 0/2] ath6kl_sdio: add control of CHIP_PWD_L via GPIO

2015-11-22 Thread Steve deRosier
takes care of it * Utilize already available ARCH_NR_GPIOS * Remove msleep on exit as the problem it resolves is taken care of a different patch. This applies against kvalo/ath.git master branch Steve deRosier (2): ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin ath6kl_sdio:

[PATCH v2 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-18 Thread Steve deRosier
the CHIP_PWD_L pin if the implementer so desires. This code is only available if GPIOLIB is configured. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/sdio.c | 73 +- 1 file changed, 72 insertions(+), 1 de

[PATCH v2 0/2] ath6kl_sdio: add control of CHIP_PWD_L via GPIO

2015-11-18 Thread Steve deRosier
s is taken care of a different patch. This applies against kvalo/ath.git master branch Steve deRosier (2): ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin ath6kl_sdio: Add power gpio reset feature into sdio driver for suspend drivers/net/wireless/ath/ath6kl/sd

[PATCH v2 2/2] ath6kl_sdio: Add power gpio reset feature into sdio driver for suspend

2015-11-18 Thread Steve deRosier
and recovery from standby. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/sdio.c | 40 -- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wirele

[PATCH] ath6kl: Don't print error message when recv is canceled

2015-11-18 Thread Steve deRosier
. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc_mbox.c b/drivers/net/wireless/ath/ath6kl/htc_mbox.c index fffb65b..65c31da

Re: [PATCH 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-17 Thread Steve deRosier
Hi Julian, Thanks for looking at this. In short - I agree with your review and will do most of them. As a well as a few minor changes suggested by the kbuild test robot. Expect a new version shortly. On Mon, Nov 16, 2015 at 10:25 PM, Julian Calaby wrote: >> >> static

[PATCH 0/2] ath6kl_sdio: add control of CHIP_PWD_L via GPIO

2015-11-16 Thread Steve deRosier
connected to the CHIP_PWD_L pin on the wifi chip. Steve deRosier (2): ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin ath6kl_sdio: Add power gpio reset feature into sdio driver for suspend drivers/net/wireless/ath/ath6kl/sdio.c | 125 - 1 file changed, 124

[PATCH 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-16 Thread Steve deRosier
the CHIP_PWD_L pin if the implementer so desires. This code is only available if GPIOLIB is configured. Signed-off-by: Steve deRosier <steve.deros...@lairdtech.com> --- drivers/net/wireless/ath/ath6kl/sdio.c | 80 +- 1 file changed, 79 insertions(+), 1 de