Re: [PATCH v2] bcma: Prevent build of PCI host features in module

2018-03-02 Thread Larry Finger
On 03/01/2018 04:45 AM, Kalle Valo wrote: Matt Redfearn writes: Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in a build error due to use of symbols not exported from vmlinux: ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-02 Thread Enrico Mioso
Hello to all of you. I would be very happy if this problem could be sorted out. But I should be honest: when the only possibility seemd to run a git bisect on openwrt,I was discouraged. too many builds, and some patching would be needed if you consider that this thing worked with 3.9 kernel or

Re: [PATCH] Revert "mac80211: use QoS NDP for AP probing"

2018-03-02 Thread Ben Caradoc-Davies
On 27/02/18 23:04, Johannes Berg wrote: Perhaps we can set some sort of flag in the driver that says "don't use QoS" frames. In fact, ath9k already says it doesn't like QoS frames: - skb = ieee80211_nullfunc_get(sc->hw, vif, false); so which place creates them? Thy only place I

[PATCH v3] ath9k: fix crash in spectral scan

2018-03-02 Thread s . gottschall
From: Sebastian Gottschall fixes crash seen on arm smp systems (gateworks ventana imx6) Signed-off-by: Sebastian Gottschall v2: fix wrong field and add signed-off-by v3: forgot to include correct latest patch, so just fix that and refresh

Re: [PATCH 03/15] rtlwifi: btcoex: Add enum DM_INFO for btcoex to query dm's counters

2018-03-02 Thread Pkshih
On Fri, 2018-03-02 at 16:19 -0600, Larry Finger wrote: > On 02/27/2018 09:07 PM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > btcoex uses dm's counters to check the envoriment is nosiy or not. If it > > is clean, btcoex set more time solts to WiFi so that it can

Re: [PATCH 02/15] rtlwifi: remove redundant statement found by static checker

2018-03-02 Thread Larry Finger
On 02/27/2018 09:07 PM, pks...@realtek.com wrote: From: Ping-Ke Shih smatch reports "rtl_is_special_data() warn: inconsistent indenting", but it is an obvious redundant statement so remove it. Signed-off-by: Ping-Ke Shih Acked-by: Larry Finger

Re: [PATCH 01/15] rtlwifi: Add modifier static to functions reported by sparse

2018-03-02 Thread Larry Finger
On 02/27/2018 09:07 PM, pks...@realtek.com wrote: From: Ping-Ke Shih sparse reports some functions were not declared, so add 'static' as modifier. Remove an unused function btc8821a1ant_is_wifi_status_changed() exposed due to 'static'. Signed-off-by: Ping-Ke Shih

Re: [PATCH 03/15] rtlwifi: btcoex: Add enum DM_INFO for btcoex to query dm's counters

2018-03-02 Thread Larry Finger
On 02/27/2018 09:07 PM, pks...@realtek.com wrote: From: Ping-Ke Shih btcoex uses dm's counters to check the envoriment is nosiy or not. If it is clean, btcoex set more time solts to WiFi so that it can transimt as soon as possible. That will save time, and BT will have more

Re: [PATCH 05/15] rtlwifi: btcoex: Get status of multichannel concurrence

2018-03-02 Thread Larry Finger
On 02/27/2018 09:07 PM, pks...@realtek.com wrote: From: Ping-Ke Shih btcoex does different decision according to MCC or SCC status, but driver is still SCC currently. Signed-off-by: Ping-Ke Shih Acked-by: Larry Finger

Re: [PATCH 04/15] rtlwifi: btcoex: Add customer_id to do special deal to oem vendor

2018-03-02 Thread Larry Finger
On 02/27/2018 09:07 PM, pks...@realtek.com wrote: From: Ping-Ke Shih Add customer_id field in structure, and then this is a clue to implement the behavior defined by vendor LENOVO_CHINA. Signed-off-by: Ping-Ke Shih Acked-by: Larry Finger

[PATCH] net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

2018-03-02 Thread Randy Dunlap
rivers/net/wireless/st/Kconfig|4 ++-- drivers/net/wireless/ti/Kconfig|4 ++-- drivers/net/wireless/zydas/Kconfig |4 ++-- 16 files changed, 32 insertions(+), 32 deletions(-) --- linux-next-20180302.orig/drivers/net/wireless/admtek/Kconfig +++ linux-next-20180302/

pull-request: mac80211 2018-03-02

2018-03-02 Thread Johannes Berg
Hi Dave, Just a few more patches, but I'll be travelling over the next week and probably won't be able to send things to you then. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 93c62c45ed5fad1b87e3a45835b251cd68de9c46: rxrpc: Fix

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

2018-03-02 Thread Arend van Spriel
On 3/1/2018 11:37 PM, Hans de Goede wrote: Hi, On 01-03-18 20:54, Arend van Spriel wrote: On 3/1/2018 9:35 AM, Hans de Goede wrote: HI, On 28-02-18 20:43, Arend van Spriel wrote: On 2/28/2018 3:52 PM, Hans de Goede wrote: Hi, On 27-02-18 00:04, Arend van Spriel wrote: On 2/26/2018 12:22

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

2018-03-02 Thread Marcel Holtmann
Hi Arend, This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_OP attribute to enable or disable btcoex. >>> >>> What kind of btcoex are we talking about here? Is it signalling >>> between wlan and bt to get access to the shared RF. >> >> Yes, at least that's

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-02 Thread Sebastian Gottschall
leds-gpio is crap and limited. you can just register one platform data at kernel runtime since its identified by its object name "led-gpio" but the kernel forbidds to register 2 platform datas with the same name consider the ar71xx devices with qca988x wifi chipsets. they all have already a led

Re: [PATCH] ath10k: Add sta rx packet stats per tid

2018-03-02 Thread Vasanthakumar Thiagarajan
On Wednesday 28 February 2018 06:47 PM, Kalle Valo wrote: > Vasanthakumar Thiagarajan writes: > >> Added per tid sta counters for the following >> >> - Total number MSDUs received from firmware >> - Number of MSDUs received with errors like decryption, crc, mic ,etc. >>

pull-request: mac80211-next 2018-03-02

2018-03-02 Thread Johannes Berg
Hi Dave, Like before... Thanks for pulling net into net-next, the Add-BA patch below would otherwise not really be possible :-) The only sort of interesting thing is the fast-RX improvements from Felix, they help on routers where these things (A-MSDU and 4-addr mode) are more important and where

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-02 Thread Pavel Machek
Hi! > >>adds also debugfs interface for gpio control. > >Hi Sebastian, > > > >I just noticed this patch and have one question. It seems you register > >GPIO chip and that WiFi LED is controller by a GPIO. Shouldn't you use > >leds-gpio driver and just register platform device with >

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

2018-03-02 Thread Arend van Spriel
+ Marcel On 3/2/2018 6:14 AM, Kalle Valo wrote: Arend van Spriel writes: On 3/1/2018 6:59 PM, Tamizh chelvam wrote: From: Tamizh chelvam This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_OP attribute to

Re: pull-request: mac80211 2018-03-02

2018-03-02 Thread David Miller
From: Johannes Berg Date: Fri, 2 Mar 2018 10:04:46 +0100 > Just a few more patches, but I'll be travelling over the next > week and probably won't be able to send things to you then. > > Please pull and let me know if there's any problem. Ok, pulled, safe travels.

Re: pull-request: mac80211-next 2018-03-02

2018-03-02 Thread David Miller
From: Johannes Berg Date: Fri, 2 Mar 2018 10:06:54 +0100 > Like before... Thanks for pulling net into net-next, the Add-BA patch > below would otherwise not really be possible :-) No problem. > The only sort of interesting thing is the fast-RX improvements from >

Re: [PATCH trivial resend^2] net: Spelling s/stucture/structure/

2018-03-02 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 2 Mar 2018 14:43:23 +0100 > Signed-off-by: Geert Uytterhoeven I'll let the trivial tree pick this up.

pull-request: iwlwifi 2018-03-02

2018-03-02 Thread Luca Coelho
Hi Kalle, Here is my second set of fixes for 4.16. More details in the tag description. I have sent this out before and kbuildbot didn't find any issues. Please let me know if there are any issues. Cheers, Luca. The following changes since commit 78dc897b7ee67205423dbbc6b56be49fb18d15b5:

Re: [PATCH] mt7601u: Fix system freeze after resuming from hibernation

2018-03-02 Thread cantabile
On 01/03/18 23:01, Luis R. Rodriguez wrote: On Thu, Mar 01, 2018 at 10:11:01PM +0200, cantabile wrote: On 01/03/18 19:29, Luis R. Rodriguez wrote: Correct? The above log is from "20180227-firmware-cache" kernel plus your suggested change that makes it always upload the firmware: diff

Re: [PATCH net-next 1/2] mac80211_hwsim: Make hwsim_netgroup IDA

2018-03-02 Thread Kirill Tkhai
On 01.03.2018 20:22, Benjamin Beichler wrote: > Am 01.03.2018 um 12:30 schrieb Kirill Tkhai: > >> Out of bounds of this patch, just as a report to wireless subsystem >> maintainer, destroy_radio() increaments hwsim_radios_generation >> without hwsim_radio_lock, so this may need one more patch to

pull-request: iwlwifi firmwares update 2018-03-02

2018-03-02 Thread Luca Coelho
Hi, I have updated the firmwares for the 9000 series. Please pull or let me know if there are any issues. Cheers, Luca. The following changes since commit 7344ec9e1df9e27d105ed48d2db99e22370236de: Merge branch 'ath10k-20180219' of

[PATCH v1] ath9k: fix crash in spectral scan

2018-03-02 Thread s . gottschall
From: Sebastian Gottschall fixes crash seen on arm smp systems (gateworks ventana imx6) Unable to handle kernel NULL pointer dereference at virtual address 0014 pgd = 80004000 [0014] *pgd= Internal error: Oops - BUG: 17 [#1] PREEMPT SMP ARM Modules

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

2018-03-02 Thread Arend van Spriel
On 3/2/2018 10:59 AM, Marcel Holtmann wrote: Hi Arend, This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_OP attribute to enable or disable btcoex. What kind of btcoex are we talking about here? Is it signalling between wlan and bt to get access to the shared RF.

[PATCH v2] ath9k: fix crash in spectral scan

2018-03-02 Thread s . gottschall
From: Sebastian Gottschall fixes crash seen on arm smp systems (gateworks ventana imx6) Signed-off-by: Sebastian Gottschall v2: fix wrong field and add signed-off-by Unable to handle kernel NULL pointer dereference at virtual address 0014

[PATCHv2] Revert "ath10k: send (re)assoc peer command when NSS changed"

2018-03-02 Thread Karthikeyan Periyasamy
This reverts commit 55884c045d31a29cf69db8332d1064a1b61dd159. When Ath10k is in AP mode and an unassociated STA sends a VHT action frame (Operating Mode Notification for the NSS change) periodically to AP this causes ath10k to call ath10k_station_assoc() which sends WMI_PEER_ASSOC_CMDID during

[PATCH 3/3] staging: wilc1000: fix line over 80 char in wilc_wlan_handle_rxq()

2018-03-02 Thread Ajay Singh
Refactor wilc_wlan_handle_rxq() to fix line over 80 character issue found by checkpatch.pl script. Added a new function to split 'wilc_wlan_handle_rxq' function code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 114

[PATCH 0/3] staging: wilc1000: fix line over 80 char & coding style

2018-03-02 Thread Ajay Singh
This patch series contains fixes for open parenthesis mismatch and line over 80 char issue found by checkpatch script. Ajay Singh (3): staging: wilc1000: fix open parenthesis mismatch in wilc_wlan_cfg_get() staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set() staging:

[PATCH 1/3] staging: wilc1000: fix open parenthesis mismatch in wilc_wlan_cfg_get()

2018-03-02 Thread Ajay Singh
Fix 'Alignment should match open parenthesis' issue found by checkpatch.pl script. Reduce the leading tab, to make space for open parenthesis match. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 25 + 1 file changed, 13

[PATCH 2/3] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 37 ++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git

[PATCH 00/13] staging: wilc1000: fix camelcase,line over 80 char and few smatch warning

2018-03-02 Thread Ajay Singh
This patch series contains fixes for checkpatch.pl reported issue & 'always true condition' smatch warning. Ajay Singh (13): staging: wilc1000: rename enuEvent to avoid camelCase staging: wilc1000: remove always 'true' check from 'if' statement staging: wilc1000: fix line over 80 char in

[PATCH 09/13] staging: wilc1000: fix line over 80 char in wilc_del_allstation() & wilc_deinit()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 08/13] staging: wilc1000: fix line over 80 char in wilc_add_ptk()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 07/13] staging: wilc1000: rename pstrHostIFkeyAttr to avoid camelCase issue

2018-03-02 Thread Ajay Singh
Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 119 +++--- 1 file changed, 59 insertions(+), 60 deletions(-) diff --git

[PATCH 10/13] staging: wilc1000: fix line over 80 char in wilc_scan_complete_received()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 character' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 02/13] staging: wilc1000: remove always 'true' check from 'if' statement

2018-03-02 Thread Ajay Singh
Fix few smatch warning related to 'warn: always true condition'. handle_cfg_param() warn: always true condition '(cfg_param_attr->auth_timeout < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->rts_threshold < 65536) => (0-u16max < 65536)'

[PATCH 05/13] staging: wilc1000: fix line over 80 char for wilc_gnrl_async_info_received()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 04/13] staging: wilc1000: fix line over 80 char in wilc_network_info_received()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 character' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 06/13] staging: wilc1000: fix line over 80 char in host_int_parse_join_bss_param()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 216 +++--- 1 file changed, 108 insertions(+), 108 deletions(-) diff --git

[PATCH 01/13] staging: wilc1000: rename enuEvent to avoid camelCase

2018-03-02 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 03/13] staging: wilc1000: fix line over 80 char in handle_cfg_param()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 char' issues found by checkpatch.pl script in handle_cfg_param(). Rename variables and used temporary variables to fix the line over 80 characters issue. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 175

[PATCH 11/13] staging: wilc1000: rename handle_connect_timeout() variables to avoid camelCase

2018-03-02 Thread Ajay Singh
Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 12/13] staging: wilc1000: fix line over 80 char in handle_rcvd_ntwrk_info()

2018-03-02 Thread Ajay Singh
Fix 'line over 80 character' issues found by checkpatch.pl script by use of temporary variable and avoided leading tab. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 66 +++ 1 file changed, 33 insertions(+), 33

[PATCH 13/13] staging: wilc1000: rename u16DummyReasonCode to avoid camelCase

2018-03-02 Thread Ajay Singh
Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH] ath10k: Add sta rx packet stats per tid

2018-03-02 Thread Kalle Valo
Vasanthakumar Thiagarajan writes: >> This added new ath10k-check warnings, I fixed those in the pending >> branch: >> >> drivers/net/wireless/ath/ath10k/debug.h:203: Alignment should match open >> parenthesis >> drivers/net/wireless/ath/ath10k/debug.h:226: Alignment

[PATCH trivial resend^2] net: Spelling s/stucture/structure/

2018-03-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/wireless/atmel/atmel.c | 2 +- include/net/iw_handler.h | 2 +- net/socket.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] iwlwifi: fixes intended for 4.16 2018-03-02

2018-03-02 Thread Luca Coelho
From: Luca Coelho Hi, This is my third batch of fixes inteded for 4.16. These are the fixes: * Fix an issue with the multicast queue; * Fix IGTK handling; * Fix some missing return value checks; * Add support for a HW workaround for issues on some platforms; As

[PATCH 2/4] iwlwifi: mvm: Correctly set IGTK for AP

2018-03-02 Thread Luca Coelho
From: Beni Lev Currently when an IGTK is set for an AP, it is set as a regular key. Since the cipher is set to CMAC, the STA_KEY_FLG_EXT flag is added to the host command, which causes assert 0x253D on NICs that do not support this. Fixes: 85aeb58cec1a ("iwlwifi: mvm: Enable

[PATCH 4/4] iwlwifi: add shared clock PHY config flag for some devices

2018-03-02 Thread Luca Coelho
From: Luca Coelho Some devices use a shared clock which is very sensitive to variations and cause trouble in some situations. We need to set a bit in the phy configuration to indicate that to the FW. To make this generic, add a extra_phy_config_flags element to the

[PATCH 3/4] iwlwifi: mvm: fix error checking for multi/broadcast sta

2018-03-02 Thread Luca Coelho
From: Johannes Berg The earlier patch called the station add functions but didn't assign their return value to the ret variable, so that the checks for it were meaningless. Fix that. Found by smatch: .../mac80211.c:2560 iwl_mvm_start_ap_ibss() warn: we tested 'ret'

[PATCH 1/4] iwlwifi: mvm: set the correct tid when we flush the MCAST sta

2018-03-02 Thread Luca Coelho
From: Emmanuel Grumbach The tid being used for the queue (cab_queue) for the MCAST station has been changed recently to be 0 (for BE). The flush path still flushed only the special tid (15) which means that the firmware wasn't flushing the right queue and we could