[PATCH 2/2] mt76: mt76x0: handle chip specific initval differences

2018-10-18 Thread Felix Fietkau
Some RF registers need different values for various chips. For at least mt76x0_rf_central_tab registers, overwriting them later does not work, as the wrong values can cause the entire system to hang on some devices with MT7610E Signed-off-by: Felix Fietkau ---

[PATCH 1/2] mt76: mt76x0: reduce duplication in setting rf bandwidth parameters

2018-10-18 Thread Felix Fietkau
Remove initval table with duplicated registers and driver specific flags in favor of a function that sets the registers directly Signed-off-by: Felix Fietkau --- .../mediatek/mt76/mt76x0/initvals_phy.h | 45 .../net/wireless/mediatek/mt76/mt76x0/phy.c | 73

Re: [PATCH] linux-firmware: add firmware for mt7610e

2018-10-18 Thread Josh Boyer
On Sat, Oct 13, 2018 at 5:06 AM Lorenzo Bianconi wrote: > > Add binary firmware for mt7610e based devices > > Signed-off-by: Lorenzo Bianconi > --- > WHENCE | 3 ++- > mediatek/mt7610e.bin | Bin 0 -> 80680 bytes > 2 files changed, 2 insertions(+), 1 deletion(-) > create mode

Re: [PATCH v4 4/8] rt2800: fix registers init for MT7620

2018-10-18 Thread Tom Psyborg
On 16/10/2018, Stanislaw Gruszka wrote: > Hello > > On Tue, Oct 16, 2018 at 01:32:18PM +0200, Tom Psyborg wrote: >> I am sending you two builds privately so please check if there are any >> differences between the two builds and report back. Thanks. > > I extracted rt2800lib.ko module from

Re: [PATCH] mt76x0: init: simplify mt76x0_init_mac_registers

2018-10-18 Thread Felix Fietkau
On 2018-10-16 11:42, Lorenzo Bianconi wrote: > Simplify mt76x0_init_mac_registers routine using mt76_set, mt76_clear > and mt76_rmw utility routines > > Signed-off-by: Lorenzo Bianconi Applied, thanks. - Felix

Re: [PATCH] mt76: usb: fix static tracepoints

2018-10-18 Thread Felix Fietkau
On 2018-10-18 00:35, Lorenzo Bianconi wrote: > Add submit_urb and rx_urb static tracepoints in mt76-usb module. > Move trace_mac_txstat_fetch in mt76x02_mac_load_tx_status routine > in order to be available to usb drivers. Moreover remove > no longer used mt76x0/trace.{c,h} > > Signed-off-by:

Re: [PATCH v2] mt76x0: antenna select corrections

2018-10-18 Thread Felix Fietkau
On 2018-10-18 12:15, Stanislaw Gruszka wrote: > Update mt76x0_phy_ant_select() to conform vendor driver, most notably > add dual antenna mode support, read configuration from EEPROM and > move ant select out of channel config to init phase. Plus small MT7630E > quirk for MT_CMB_CTRL register which

FTM support on ath10k

2018-10-18 Thread Arthur Watt
Good afternoon I am interested in contributing to the development and testing of FTM using ath10k devices. Currently I am running a standard 4.14 kernel and have QCA988X (WLE600VX) and QCA9984 (WLE1216V5) devices. My QCA9984 is running 10.4.3 firmware and the QCA988X is using 10.2.4.70.66.

[PATCH] nl80211: Emit a NEW_INTERFACE on iftype change

2018-10-18 Thread Andrew Zaborowski
Let userspace learn about iftype changes by sending an NL80211_CMD_NEW_INTERFACE when handling a NL80211_CMD_SET_INTERFACE command. There seems to be no other place where the iftype can change: nl80211_set_interface is the only caller of cfg80211_change_iface which is the only caller of

[PATCH] mt76x0: pci: add missing MODULE_FIRMWARE macro

2018-10-18 Thread Lorenzo Bianconi
Add missing firmware declaration for mt76x0e driver Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 3 +++ drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 2 ++ drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c | 3 --- 3 files changed, 5

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-18 Thread Adham.Abozaeid
On 10/18/2018 01:23 AM, Johannes Berg wrote: > On Fri, 2018-10-12 at 22:08 +, adham.aboza...@microchip.com wrote: >> >> On 10/11/2018 12:01 AM, Johannes Berg wrote: >>> Agree. parameter validation can be done before scheduling the work, and hence appropriate error can be returned

Re: [PATCH] mt76: usb: fix static tracepoints

2018-10-18 Thread Stanislaw Gruszka
On Thu, Oct 18, 2018 at 12:35:32AM +0200, Lorenzo Bianconi wrote: > Add submit_urb and rx_urb static tracepoints in mt76-usb module. > Move trace_mac_txstat_fetch in mt76x02_mac_load_tx_status routine > in order to be available to usb drivers. Moreover remove > no longer used mt76x0/trace.{c,h} >

Re: wireless workshop (was: Re: Announcing Netdev 0x13 conference)

2018-10-18 Thread Stanislaw Gruszka
On Tue, Oct 09, 2018 at 12:28:23PM +0200, Johannes Berg wrote: > Kalle and I have (more or less) decided to propose a wireless workshop > for Netdev 0x13. > > In order to gauge interest and plan room size, can you reply (privately > if you like) if this would work for you and you'd (want to)

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-18 Thread Johannes Berg
On Fri, 2018-10-12 at 21:55 +, adham.aboza...@microchip.com wrote: > > Here the driver is configuring parameters in the device by sending a > WID command for each parameters. > The val pointer points to the value of the parameter to be set, and > here all parameters being set to 0 were

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-18 Thread Johannes Berg
On Fri, 2018-10-12 at 22:08 +, adham.aboza...@microchip.com wrote: > > On 10/11/2018 12:01 AM, Johannes Berg wrote: > > > > > Agree. parameter validation can be done before scheduling the work, > > > and hence appropriate error can be returned to caller . > > > > > > > If I got your point

[PATCH] mac80211: allow hardware scan to fall back to software

2018-10-18 Thread Johannes Berg
From: Johannes Berg In some cases, like in the rsi driver hardware scan offload, there may be scenarios in which hardware scan might not be available or desirable. Allow drivers to cope with this by letting them fall back to software scan by returning the special value 1 from the hardware scan

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Lorenzo Bianconi
> On Thu, Oct 18, 2018 at 11:13:36AM +0200, Lorenzo Bianconi wrote: > > > static void mt76x0_phy_ant_select(struct mt76x02_dev *dev) > > > { > > > - struct ieee80211_channel *chan = dev->mt76.chandef.chan; > > > - > > > - /* single antenna mode */ > > > - if (chan->band == NL80211_BAND_2GHZ) { >

Re: [PATCH] mt76: usb: fix static tracepoints

2018-10-18 Thread Stanislaw Gruszka
On Thu, Oct 18, 2018 at 10:13:51AM +0200, Lorenzo Bianconi wrote: > On Oct 18, Stanislaw Gruszka wrote: > > On Thu, Oct 18, 2018 at 12:35:32AM +0200, Lorenzo Bianconi wrote: > > > Add submit_urb and rx_urb static tracepoints in mt76-usb module. > > > Move trace_mac_txstat_fetch in

[PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Stanislaw Gruszka
Update mt76x0_phy_ant_select() to conform vendor driver, most notably add dual antenna mode support, read configuration from EEPROM and move ant select out of channel config to init phase. Plus small MT7630E quirk for MT_CMB_CTRL register which vendor driver dedicated to this chip do. This make

Re: [PATCH] mt76: usb: fix static tracepoints

2018-10-18 Thread Lorenzo Bianconi
On Oct 18, Stanislaw Gruszka wrote: > On Thu, Oct 18, 2018 at 12:35:32AM +0200, Lorenzo Bianconi wrote: > > Add submit_urb and rx_urb static tracepoints in mt76-usb module. > > Move trace_mac_txstat_fetch in mt76x02_mac_load_tx_status routine > > in order to be available to usb drivers. Moreover

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Lorenzo Bianconi
> Update mt76x0_phy_ant_select() to conform vendor driver, most notably > add dual antenna mode support, read configuration from EEPROM and > move ant select out of channel config to init phase. Plus small MT7630E > quirk for MT_CMB_CTRL register which vendor driver dedicated to this > chip do. >

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Stanislaw Gruszka
On Thu, Oct 18, 2018 at 11:13:36AM +0200, Lorenzo Bianconi wrote: > > static void mt76x0_phy_ant_select(struct mt76x02_dev *dev) > > { > > - struct ieee80211_channel *chan = dev->mt76.chandef.chan; > > - > > - /* single antenna mode */ > > - if (chan->band == NL80211_BAND_2GHZ) { > > -

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-10-18 Thread Johannes Berg
On Thu, 2018-10-18 at 12:42 +0200, Arend van Spriel wrote: > > > + * This callback is also allowed to return the special return value 1, > > + * this indicates that hardware scan isn't desirable right now and a > > + * software scan should be done instead. A driver wishing to use this > > + *

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Stanislaw Gruszka
On Thu, Oct 18, 2018 at 11:28:19AM +0200, Lorenzo Bianconi wrote: > > On Thu, Oct 18, 2018 at 11:13:36AM +0200, Lorenzo Bianconi wrote: > > > > static void mt76x0_phy_ant_select(struct mt76x02_dev *dev) > > > > { > > > > - struct ieee80211_channel *chan = dev->mt76.chandef.chan; > > > > -

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Lorenzo Bianconi
> On Thu, Oct 18, 2018 at 11:40:56AM +0200, Stanislaw Gruszka wrote: > > On GPL realeased driver for MT7610U ( mt7610u_wifi_sta_v3002_dpo_2013091 ) > > it's like this: > > > > CoexCfg3 &= ~(BIT5 | BIT4 | BIT3 | BIT2 | BIT1); > > > > Does your SDK do something diffrent ? > Ok I can see:

RE: Large number of crda failures

2018-10-18 Thread Adam Cottrel
Dear Jean-Pierre, Thank you for getting back to me. My regulatory settings are working, and so the errors might not be very important - however, it is important that know why they are happening. > Code 234 => exit(-EINVAL) > Could be that crda is started in a context where the COUNTRY

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-10-18 Thread Arend van Spriel
On 10/18/2018 10:35 AM, Johannes Berg wrote: From: Johannes Berg In some cases, like in the rsi driver hardware scan offload, there may be scenarios in which hardware scan might not be available or desirable. Allow drivers to cope with this by letting them fall back to software scan by

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Lorenzo Bianconi
> On Thu, Oct 18, 2018 at 11:28:19AM +0200, Lorenzo Bianconi wrote: > > > On Thu, Oct 18, 2018 at 11:13:36AM +0200, Lorenzo Bianconi wrote: > > > > > static void mt76x0_phy_ant_select(struct mt76x02_dev *dev) > > > > > { > > > > > - struct ieee80211_channel *chan = dev->mt76.chandef.chan; >

Re: [PATCH] mt76x0: antenna select corrections

2018-10-18 Thread Stanislaw Gruszka
On Thu, Oct 18, 2018 at 11:40:56AM +0200, Stanislaw Gruszka wrote: > On GPL realeased driver for MT7610U ( mt7610u_wifi_sta_v3002_dpo_2013091 ) > it's like this: > > CoexCfg3 &= ~(BIT5 | BIT4 | BIT3 | BIT2 | BIT1); > Does your SDK do something diffrent ? Ok I can see: CoexCfg3

[PATCH v2] mt76x0: antenna select corrections

2018-10-18 Thread Stanislaw Gruszka
Update mt76x0_phy_ant_select() to conform vendor driver, most notably add dual antenna mode support, read configuration from EEPROM and move ant select out of channel config to init phase. Plus small MT7630E quirk for MT_CMB_CTRL register which vendor driver dedicated to this chip do. This make

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-10-18 Thread Siva Rebbagondla
On Thu, Oct 18, 2018 at 2:06 PM Johannes Berg wrote: > > From: Johannes Berg > > In some cases, like in the rsi driver hardware scan offload, there > may be scenarios in which hardware scan might not be available or > desirable. > > Allow drivers to cope with this by letting them fall back to