On 2018-11-09 15:05, Kalle Valo wrote:
Rafał Miłecki writes:
From: Rafał Miłecki
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's
important to provide valid & complete info about supported bands for
each channel. By default no support for 160 MHz should be assumed
unless
Fix following crash due to a leftover uninitialized mutex access
in mt76x02_set_rts_threshold routine.
[ 55.655884] CPU: 0 PID: 412 Comm: iw Not tainted 4.19.0-rc7+ #2493
[ 55.661739] Call Trace:
[ 55.662523] register_lock_class+0x528/0x530
[ 55.663806] __lock_acquire+0x89/0x15d0
[
> Use set_rts_threshold calback to enable/disable threshold only for
> legacy traffic. RTS/CTS threshold for HT TXOP make make no sense
> to me since used protection (RTS/CTS , CTS-to-self or none)
> should be determined by HT capabilities and applied to any HT
> frames.
>
> Signed-off-by:
There is no need anymore to use custom add interface function
for mt76x02u.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x02.h | 2 --
drivers/net/wireless/mediatek/mt76/mt76x02_util.c| 6 +++---
drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c |
Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
setting BSSID for STA.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
Configure multi bss mode by default on all devices. That mean we
use MAC address for MT_MAC_BSSID_DW and use MT_MAC_APC_BSSID
for configuree bssid for each vif.
This is separe from beaconing as we can have for example 2 STA vifs,
so do not mix bssid init and beacon init.
Signed-off-by: Stanislaw
Remove comment about one configurable BSSID registers since
we utilize AP-Client feature now.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git
Minor MBSS and beaconing fixups. On top of:
"mt76x2u: init: remove mt76x2u_init_beacon_offsets routine"
Stanislaw Gruszka (5):
mt76x02: correct set bssid for STA
mt76x02: initalize mutli bss mode by default
mt76x2u: use common mt76x02_add_interface
mt76x02: minor beaconing init changes
Disable BEACON timer during init and remove interrupt registers
initalization form generic conde since they are PCIe specific.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 7 +++
drivers/net/wireless/mediatek/mt76/mt76x02_util.c| 11
> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
> setting BSSID for STA.
>
> Signed-off-by: Stanislaw Gruszka
> ---
> drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git
> Configure multi bss mode by default on all devices. That mean we
> use MAC address for MT_MAC_BSSID_DW and use MT_MAC_APC_BSSID
> for configuree bssid for each vif.
>
> This is separe from beaconing as we can have for example 2 STA vifs,
> so do not mix bssid init and beacon init.
>
>
> There is no need anymore to use custom add interface function
> for mt76x02u.
>
> Signed-off-by: Stanislaw Gruszka
> ---
> drivers/net/wireless/mediatek/mt76/mt76x02.h | 2 --
> drivers/net/wireless/mediatek/mt76/mt76x02_util.c| 6 +++---
>
On Fri, 2018-11-09 at 11:48 +0530, Siva Rebbagondla wrote:
> Hi,
> Gentle Remainder..!!!.
> Any update required for this patch?. If not, When can i expect this
> patch to be available in wireless-next?.
Sorry, I hadn't been merging things for a while due to the merge window.
I just put it into
> Use information about protection that mac80211 provide to us.
> Used protection should be part of ht capabilites that either
> remote AP provde to us in STA mode or is set in hostapd.conf
> in ht_capab option.
>
> Signed-off-by: Stanislaw Gruszka
> ---
>
We always wait for CMD_CALIBRATION_OP mcu message, but wait argument is used
for do additional MT_MCU_COM_REG0 register operations, which are needed
for mt76x2e devices and we can use appropriate check instead of wait argument.
Signed-off-by: Stanislaw Gruszka
---
v2: use MT_MCU_COM_REG0
> Disable BEACON timer during init and remove interrupt registers
> initalization form generic conde since they are PCIe specific.
>
Since the timer is actually disabled (MT_INT_TIMER_EN set to 0) and
we just set the timer timeout here, does it worth to copy/paste
the same code?
Regards,
d46d731c made it obsolete.
Cc: Sven Eckelmann
Cc: Seth Forshee
Cc: WIRELESS ML
Cc: REGDB ML
Signed-off-by: Xose Vazquez Perez
---
db.txt | 7 ---
1 file changed, 7 deletions(-)
diff --git a/db.txt b/db.txt
index 8f356f7..fa5c0e0 100644
--- a/db.txt
+++ b/db.txt
@@ -359,13 +359,6 @@
Rafał Miłecki writes:
> From: Rafał Miłecki
>
> Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's
> important to provide valid & complete info about supported bands for
> each channel. By default no support for 160 MHz should be assumed unless
> firmware reports it for a given
From: Yan-Hsuan Chuang
cfg80211_sta_opmode_change_notify needs a gfp_t flag to hint the nl80211
stack when allocating new skb, but it is called under tasklet context
here with GFP_KERNEL and kernel will yield a warning about it.
Fixes: ff84e7bfe176 ("mac80211: Add support to notify ht/vht
Hi,
Sorry for the delay in reviewing this.
> + int (*set_sta_mon_rssi_config)(struct wiphy *wiphy,
> + struct net_device *dev,
> + const u8 *addr,
> + const s32 *rssi_tholds,
+ Jouni
On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote:
From: Madhan Mohan R
Send p2p presence response from the p2p interface address instead
of the p2p device address. This is needed for p2p cert 6.1.9 to pass.
I am not really into the P2P spec, but if this is indeed a requirement
(@Jouni:
On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote:
From: Ryohei Kondo
Miracast Certification clause 6.1.2 may fail if there is no WFD IE in
p2p assoc response. This change allows WFD IE to be added to p2p assoc
response.
Related WFA certification:
6.1.2 P-SnUT operating as a Group Owner accepts a WFD
+ Hans
On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote:
P2p spec mentioned that the p2p device address should be the globally
administered address with locally administered bit set. Therefore,
follow this guideline by default.
When the primary interface is set to a locally administered address, the
On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote:
From: Wright Feng
APSTA can work on two band concurrently with using VSDB(Virtual
Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features.
In this case, we have to keep apsta is 1 in firmware side. However, if
we start wpa_supplicant on
On Fri, Nov 09, 2018 at 01:50:51PM +0100, Lorenzo Bianconi wrote:
> > On 2018-11-09 12:09, Lorenzo Bianconi wrote:
> > >> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
> > >> setting BSSID for STA.
> > >>
> > >> Signed-off-by: Stanislaw Gruszka
> > >> ---
> > >>
On 2018-11-09 14:42, Lorenzo Bianconi wrote:
>> On Fri, Nov 09, 2018 at 01:50:51PM +0100, Lorenzo Bianconi wrote:
>> > > On 2018-11-09 12:09, Lorenzo Bianconi wrote:
>> > > >> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
>> > > >> setting BSSID for STA.
>> > > >>
>> > > >> Signed-off-by:
On Fri, Nov 09, 2018 at 12:09:50PM +0100, Lorenzo Bianconi wrote:
> > Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
> > setting BSSID for STA.
> >
> > Signed-off-by: Stanislaw Gruszka
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 12 +---
> > 1 file changed, 9
On Mon, 2018-10-15 at 23:27 +0530, Tamizh chelvam wrote:
>
> + sta_mon_rssi_config_free(sta);
> + sta->rssi_hyst = rssi_hyst;
> + if (fixed_thold) {
> + if (n_rssi_tholds > 2) {
> + ret = -EINVAL;
> +
Oh, umm, that patch is still here ...
I guess we can combine 2 and 3 too.
> + if (sta->rssi_low && bss_conf->enable_beacon) {
> + int last_event =
> + sta->last_rssi_event_value;
> + int sig = -ewma_signal_read(>rx_stats_avg.signal);
> +
Hi Ben,
Apologies for taking so long to look at this.
This looks good to me, but for some reason it doesn't apply on my
(mac80211-next) tree, and basically all of the patch fails. I'm not sure
I dare try to fix that up, could you resend?
johannes
On Fri, 2018-10-19 at 14:42 +0530, Sriram R wrote:
[...]
This looks fine, but I think it would be nice to have some extended
netlink error reporting for at least some of these errors:
> + dfs_region = reg_get_dfs_region(wiphy);
> + if (dfs_region == NL80211_DFS_UNSET)
> +
On 11/9/2018 8:34 AM, Chi-Hsien Lin wrote:
On 11/08/2018 7:53, Arend van Spriel wrote:
On 11/6/2018 4:50 AM, Chi-Hsien Lin wrote:
From: Madhan Mohan R
Along with F2 watermark (existing) configuration, F1 MesBusyCtrl
should be enabled & configured to avoid overflow errors.
Reviewed-by:
> > So I guess attachment is fine, but you need to add the s-o-b and a
> > commit message in the patch itself.
So, actually, that didn't work. I've applied the patch anyway, but in
the future better submit patches inline in the email so patchwork picks
them up and I can track them (and don't
> On 2018-11-09 12:09, Lorenzo Bianconi wrote:
> >> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
> >> setting BSSID for STA.
> >>
> >> Signed-off-by: Stanislaw Gruszka
> >> ---
> >> drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 12 +---
> >> 1 file changed, 9 insertions(+),
On Fri, Nov 09, 2018 at 12:26:51PM +0100, Lorenzo Bianconi wrote:
> > @@ -52,9 +52,6 @@ static int mt76x2u_add_interface(struct ieee80211_hw *hw,
> > struct mt76x02_dev *dev = hw->priv;
> > unsigned int idx = 8;
> >
> > - if (!ether_addr_equal(dev->mt76.macaddr, vif->addr))
> > -
> [root@dhcp-27-155 ~]# iw dev
> phy#1
> Interface wlan1
> ifindex 10
> wdev 0x10001
> addr 2c:4d:54:cb:d8:04
> type managed
> [root@dhcp-27-155 ~]# ip link set addres b0:6e:bf:a5:31:90 wlan1
> [root@dhcp-27-155 ~]# iw dev wlan1
> On Fri, Nov 09, 2018 at 01:50:51PM +0100, Lorenzo Bianconi wrote:
> > > On 2018-11-09 12:09, Lorenzo Bianconi wrote:
> > > >> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
> > > >> setting BSSID for STA.
> > > >>
> > > >> Signed-off-by: Stanislaw Gruszka
> > > >> ---
> > > >>
> On Fri, Nov 09, 2018 at 12:33:32PM +0100, Lorenzo Bianconi wrote:
> > > Disable BEACON timer during init and remove interrupt registers
> > > initalization form generic conde since they are PCIe specific.
> > >
> >
> > Since the timer is actually disabled (MT_INT_TIMER_EN set to 0) and
> > we
On 2018-11-09 12:09, Lorenzo Bianconi wrote:
>> Use MT_MAC_APC_BSSID0_H_EN bit to indicatate we are
>> setting BSSID for STA.
>>
>> Signed-off-by: Stanislaw Gruszka
>> ---
>> drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 12 +---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
On Fri, Nov 9, 2018 at 4:49 PM Johannes Berg wrote:
>
> On Fri, 2018-11-09 at 11:48 +0530, Siva Rebbagondla wrote:
> > Hi,
> > Gentle Remainder..!!!.
> > Any update required for this patch?. If not, When can i expect this
> > patch to be available in wireless-next?.
>
> Sorry, I hadn't been
On Fri, Nov 09, 2018 at 12:33:32PM +0100, Lorenzo Bianconi wrote:
> > Disable BEACON timer during init and remove interrupt registers
> > initalization form generic conde since they are PCIe specific.
> >
>
> Since the timer is actually disabled (MT_INT_TIMER_EN set to 0) and
> we just set the
> We always wait for CMD_CALIBRATION_OP mcu message, but wait argument is used
> for do additional MT_MCU_COM_REG0 register operations, which are needed
> for mt76x2e devices and we can use appropriate check instead of wait argument.
>
> Signed-off-by: Stanislaw Gruszka
> ---
Reviewed-by:
The newest firmwares provide STA info using v7 of the struct. As v7
isn't backward compatible, a union is needed.
Even though brcmfmac does not use any of the new info it's important to
provide the proper struct buffer. Without this change new firmwares will
fallback to the very limited v3
Cc: Luis R. Rodriguez
Cc: WIRELESS ML
Cc: REGDB ML
Signed-off-by: Xose Vazquez Perez
---
README | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README b/README
index 5d89b83..88f2623 100644
--- a/README
+++ b/README
@@ -1,5 +1,6 @@
Central Regulatory Domain Agent (CRDA)
On Fri, Nov 09, 2018 at 02:31:31PM +0100, Lorenzo Bianconi wrote:
> >
> > Anyway I think, to support MAC address change, we should not filter
> > based on MAC address, but maybe only on BSSID ?
> >
> > Thanks
> > Stanislaw
>
> You can create the interface with a given mac address
>
> # iw phy
> On Fri, Nov 09, 2018 at 02:31:31PM +0100, Lorenzo Bianconi wrote:
> > >
> > > Anyway I think, to support MAC address change, we should not filter
> > > based on MAC address, but maybe only on BSSID ?
> > >
> > > Thanks
> > > Stanislaw
> >
> > You can create the interface with a given mac
From: Adham Abozaeid
After removing cfg_values member, cfg_values_lock that was used to protect
it can also be removed.
Signed-off-by: Adham Abozaeid
---
drivers/staging/wilc1000/host_interface.c | 9 -
drivers/staging/wilc1000/host_interface.h | 2 --
2 files changed, 11 deletions(-)
From: Adham Abozaeid
Validate input parameters to set_wiphy_param before scheduling
handle_cfg_param() to validate them.
This way proper errors can be returned to caller.
Also cleaned up unused code in handle_cfg_param.
Changes since v1:
- Correction spelling in subject of patch#2
- Added From:
From: Adham Abozaeid
host_if_drv.cfg_values is a write only member, and can be removed
Signed-off-by: Adham Abozaeid
---
drivers/staging/wilc1000/host_interface.c | 13 -
drivers/staging/wilc1000/host_interface.h | 1 -
2 files changed, 14 deletions(-)
diff --git
From: Adham Abozaeid
Validate cfg parameters after being called by cfg80211 in set_wiphy_params
before scheduling the work executed in handle_cfg_param
Signed-off-by: Adham Abozaeid
---
drivers/staging/wilc1000/host_interface.c | 61 ++-
Cc: Seth Forshee
Cc: WIRELESS ML
Cc: REGDB ML
Signed-off-by: Xose Vazquez Perez
---
README | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/README b/README
index 4028223..4a059de 100644
--- a/README
+++ b/README
@@ -1,3 +1,7 @@
+ wireless-regdb
51 matches
Mail list logo
