Alexander Aring wrote:
> This will add support to skip bytes from skb with the lowpan_fetch_skb
> function.
Maybe add "without copying (data will be NULL in this case)."
Reviewed-by: Werner Almesberger
- Werner
--
Octo
Alexander Aring wrote:
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -705,20 +705,13 @@ static int lowpan_header_create(struct sk_buff *skb,
> static int lowpan_give_skb_to_devices(struct sk_buff *skb)
> {
> struct lowpan_dev_record *entry;
> - struct sk_buff *s
Alexander Aring wrote:
> static int lowpan_give_skb_to_devices(struct sk_buff *skb)
Oh, and you may want to change (in the patch that changes the loop)
the name to lowpan_give_skb_to_device, since we're (almost) sure
it's exactly one :)
I'd also mention in the description of this patch (i.e., th
Alexander Aring wrote:
> Subject: [Linux-zigbee-devel] [PATCH net-next 04/17] 6lowpan: set and use
> mac_len for mac header length
Looks good.
Reviewed-by: Werner Almesberger
- Werner
--
October Webinars: Code for Per
Alexander Aring wrote:
> This is necessary for upcomming patches to calculate the 6lowpan header.
Maybe explain a bit more what you're doing ? I.e., that - if I
understand correctly - you're now making use of skb->transport_header
and skb->network_header to keep track of things, which the old code
Alexander Aring wrote:
> Subject: [Linux-zigbee-devel] [PATCH net-next 06/17] 6lowpan: remove
> unnecessary ret variable
Nice and easy :-)
Reviewed-by: Werner Almesberger
- Werner
--
October Webinars: Code for Perform
Hi Werner,
On Mon, Oct 14, 2013 at 08:36:57PM -0300, Werner Almesberger wrote:
> Alexander Aring wrote:
> > This is necessary for upcomming patches to calculate the 6lowpan header.
>
> Maybe explain a bit more what you're doing ? I.e., that - if I
> understand correctly - you're now making use of
Alexander Aring wrote:
> This patch uses the netdev_alloc_skb instead dev_alloc_skb function.
> Also dropping the assign to skb->dev to netdev.
I'd say "... and drops the separate assignment to skb->dev".
By the way, things like 06/17 and 07/17 could also go in a
"trivial cleanups" series.
Revie
Alexander Aring wrote:
> Subject: [Linux-zigbee-devel] [PATCH net-next 08/17] 6lowpan: remove
> unnecessary check on err >= 0
I'd mention that err is guaranteed to be always 0 when the
condition is evaluated. Another nearly trivial fix.
eviewed-by: Werner Almesberger
- Werner
Alexander Aring wrote:
> lowpan_size = skb->transport_header - skb->network_header;
>
> This patch only preparing it that we can do that. The alternative would
> be to set it in skb_cb, that was the old behaviour. Maybe I should set
> it in the skb_cb, or not?
Maybe you could mention this in the
Alexander Aring wrote:
> This patch drops the directly memcpy on skb and uses the right skb
> memcpy functions. Also remove an unnecessary check if plen is non zero.
The memcpys actually looked a little easier :-) But your
change looks correct.
Reviewed-by: Werner Almesberger
- Werner
Alexander Aring wrote:
> Since we drop the skb copies, we don't need this function.
... and you get rid of a potential (?) compiler warning:
> - int stat = NET_RX_SUCCESS;
Reviewed-by: Werner Almesberger
- Werner
Alexander Aring wrote:
> This patch removes the assign of skb->dev. We don't need it here because
> we use a netdev_alloc_skb... function.
s/assign/assignment/
Another one in the "trivial" category.
Reviewed-by: Werner Almesberger
- Werner
-
Alexander Aring wrote:
> This patch fix the fragmentation on sending side according to rfc4944.
Finally, at the 13th patch, we get to the fragmentation promised
in 00/17 ;-)
I think you want to send all those other small cleanups and
simplifications in a separate set, before the fragmentation
fix
14 matches
Mail list logo
