Re: [PATCH] powerpc/83xx: Enable FIXED_PHY in mpc834x_itx and mpc83xx defconfigs

2008-12-04 Thread Timur Tabi
-by: Timur Tabi [EMAIL PROTECTED] Kumar, please apply. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

2008-12-03 Thread Timur Tabi
the DMA node. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: i2c-mpc clocking scheme

2008-12-01 Thread Timur Tabi
Trent Piepho wrote: Seems like it should keep the clock registers at what u-boot set them too. Or we could have U-Boot put the i2c clock frequency into the I2C node, and let the driver program the hardware again. That would keep the ugliness in U-Boot. -- Timur Tabi Linux kernel developer

Re: i2c-mpc clocking scheme

2008-12-01 Thread Timur Tabi
at all? Do other boot loaders program the I2C bus speed? The reason I ask is that I want to know whether it's okay for Linux to ignore the FDR and DFSRR registers. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc

Re: i2c-mpc clocking scheme

2008-12-01 Thread Timur Tabi
to each I2C device nodes that lists the maximum speed that this supports. Then the I2C driver could find the smallest of these speeds, and program the I2C controller for that speed. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: i2c-mpc clocking scheme

2008-11-27 Thread Timur Tabi
missing something, but U-Boot configures the I2C bus speed. It does this because the algorithm is specific to the SOC itself. For example, the 8544 is different from the 8548. It would be a mess to duplicate this code in the kernel. -- Timur Tabi Linux kernel developer at Freescale

Re: powerpc: udbg based backend for hvc_console

2008-11-21 Thread Timur Tabi
, the console= line goes to the HVC subsystem, and not my driver, and I can't use it to send the configuration data the driver needs. Unfortunately, my driver hasn't been published yet, so it's hard to explain the details. I guess I need to think about this more. -- Timur Tabi Linux kernel developer

Re: powerpc: udbg based backend for hvc_console

2008-11-19 Thread Timur Tabi
patch, only Xen was wrong. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: powerpc: udbg based backend for hvc_console

2008-11-18 Thread Timur Tabi
the Kconfig help file to be very clear that this feature is only meaningful if the platform has a udbg back-end but no other console or TTY driver. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: powerpc: udbg based backend for hvc_console

2008-11-17 Thread Timur Tabi
. You take hvc callbacks and route them through udbg, but this only works on drivers that have udbg callbacks in the first place. In that case, why would these drivers need an hvc middle-man? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc

Re: powerpc: udbg based backend for hvc_console

2008-11-17 Thread Timur Tabi
=938473b24636d77dc5e9c3f41090d071b6cf4389 -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Some udbg questions

2008-11-17 Thread Timur Tabi
() in udbg.c instead. Why do some platforms do it one way, and other platforms do it the other way? Which way is preferred? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

Re: powerpc: udbg based backend for hvc_console

2008-11-17 Thread Timur Tabi
your driver? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc/qe: Move cmxgcr_lock definition from the ucc.c into the qe.c

2008-11-11 Thread Timur Tabi
: In function `qe_usb_clock_set': (.text+0x3cae): undefined reference to `cmxgcr_lock' make: *** [.tmp_vmlinux1] Error 1 While at it, also add missing spinlock.h includes. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Acked-By: Timur Tabi [EMAIL PROTECTED] -- Timur Tabi Linux kernel

Re: [PATCH V3] powerpc: Fix Book-E watchdog timer interval setting

2008-11-06 Thread Timur Tabi
-by: Matthias Fuchs [EMAIL PROTECTED] Acked-by: Timur Tabi [EMAIL PROTECTED] -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH V2] powerpc: Fix Book-E watchdog timer interval setting

2008-11-03 Thread Timur Tabi
) and (3 30) | (15 15). Can you check that please and I will resend my patch. Yes, I think WDTP(0) is correct for Book E. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: Please pull from 'for-2.6.28' branch

2008-10-21 Thread Timur Tabi
then, but what's the point of having a merge window if you don't actually merge the code? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: disable CHRP and PMAC support in various defconfigs

2008-10-10 Thread Timur Tabi
Because CHRP and PMAC are by default enabled, several non-CHRP and non-PMAC PowerPC defconfigs will have these Kconfig options set erroneously. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- arch/powerpc/configs/83xx/asp8347_defconfig |2 ++ arch/powerpc/configs/83xx

[PATCH] powerpc: reserve two DMA channels for audio in MPC8610 HPCD device tree

2008-10-10 Thread Timur Tabi
use. We change the compatible properties for these channels fsl,ssi-dma-channel. This works because the sound drivers don't actually check the compatible property when it grabs channels. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8610_hpcd.dts |4 ++-- 1 files

[PATCH] powerpc: document the fsl, ssi-dma-channel compatible property

2008-10-10 Thread Timur Tabi
drivers. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- Documentation/powerpc/dts-bindings/fsl/dma.txt | 13 +++-- Documentation/powerpc/dts-bindings/fsl/ssi.txt | 20 ++-- 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/Documentation/powerpc/dts

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
is following. Why? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Compact Flash on 8349mITX

2008-10-09 Thread Timur Tabi
if the problem is present there? Sometimes the BSP has a hacked-up kernel that addresses hardware issues, but these patches aren't pushed upstream, so the mainline kernel has problems. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
:) Again, not relevant. One giant kernel that works on a Freescale embedded system *and* an IBM mainframe is useless. No one would actually ever do that. Genesi, Manager, Developer Relations Developer Relations, eh? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
as important as the exalted CHRP is bollocks. All platforms should be treated equally. And like I said earlier, PMAC platforms aren't even being built any more, so it's ridiculous to consider that the default. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
Sven Luther wrote: You just turn it on by default for 64bit and idsable it for 32bit :) That hack might work for now, but it will break once we have 64-bit embedded systems. Regardless, it doesn't address the core issue - there should be no default platform for PowerPC. -- Timur Tabi Linux

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
know, CHRP and PMAC are the only PowerPC platforms that default to Y. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-08 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-08 Thread Timur Tabi
Remove the default y from the Kconfig options for CHRP, PMAC, and PMAC64 platforms. This patch is a follow-up to remove CHRP and PMAC support from defconfigs, fix Kconfigs, which was applied incompletely. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- Ben, in the future, please apply either

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-08 Thread Timur Tabi
that default y left behind. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-06 Thread Timur Tabi
On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi [EMAIL PROTECTED] wrote: The Kconfig files for PowerPC CHRP and PMAC support had default=y for some Kconfig options, and this caused support for CHRP and PMAC platforms to be enabled incorrectly for several platforms. Fix the Kconfigs

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
Drivers --- File systems --- [*] QE GPIO support Library routines --- Kernel hacking --- -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH v2] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
(like UCC GETH). Fortunately, all the current relevant defconfigs do that already. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- This patch should be applied to Kumar's branch for 2.6.28 patches. arch/powerpc/platforms/83xx/Kconfig |5 - arch/powerpc/platforms/85xx/Kconfig |1

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
/powerpc/platforms/Kconfig | 36 arch/powerpc/sysdev/qe_lib/Kconfig | 35 --- 3 files changed, 36 insertions(+), 37 deletions(-) delete mode 100644 arch/powerpc/sysdev/qe_lib/Kconfig Acked-by: Timur Tabi [EMAIL PROTECTED

Re: [PATCH v2] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
-allocated memory for the DIU driver -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-02 Thread Timur Tabi
(like UCC GETH). Fortunately, all the current relevant defconfigs do that already. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- This patch should be applied to Kumar's branch for 2.6.28 patches. arch/powerpc/platforms/83xx/Kconfig |4 arch/powerpc/platforms/Kconfig |3

[PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-09-26 Thread Timur Tabi
The Kconfig files for PowerPC CHRP and PMAC support had default=y for some Kconfig options, and this caused support for CHRP and PMAC platforms to be enabled incorrectly for several platforms. Fix the Kconfigs and the affected defconfigs. Signed-off-by: Timur Tabi [EMAIL PROTECTED

[PATCH] powerpc: fix conflict with Elo DMA driver in MPC8610 device tree

2008-09-26 Thread Timur Tabi
-channel. This works because the sound drivers don't actually check the compatible property when it grabs DMA channels. Also update dma.txt and ssi.txt with this information. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- Documentation/powerpc/dts-bindings/fsl/dma.txt | 13

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
is initialized before most drivers, so it's ready when the drivers are loaded. Acked-by: Li Yang [EMAIL PROTECTED] Thanks. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
that fsldma is already present when DMA clients are loaded/initialized and register. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
, it doesn't *matter* in that nothing will break, but so what? It's nicer if the DMA driver is already available when the client drivers load, so that they can use the DMA facilities right away. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH v2] powerpc: enforce sane MAX_ORDER

2008-09-24 Thread Timur Tabi
On Wed, Sep 24, 2008 at 9:29 AM, Johannes Berg [EMAIL PROTECTED] wrote: Indeed, it makes little sense to allow you to set more than the address space, so here's a version with max 64. Acked-by: Timur Tabi [EMAIL PROTECTED] However, the max is actually less than 64. Assuming a 64-bit address

Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Timur Tabi
Kumar Gala wrote: Dan, any update on this patch? I'm going to post a new version. This whole thing is more complicated than I thought. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

[PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Timur Tabi
although we can call of_platform_bus_probe() to probe the DMA channels, there is no of_platform_bus_remove(). Instead, the DMA channels are manually probed, similar to what fsl_elbc_nand.c does. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- v2: updated per comments This patch is for the 2.6.28

[PATCH] powerpc: remove support for bootmem-allocated memory for the DIU driver

2008-09-23 Thread Timur Tabi
Early versions of the Freescale DIU framebuffer driver depended on a bootmem allocation of memory for the video buffer. The need for this feature was removed in commit 6b51d51a, so now we can remove the platform-specific code that allocated that memory. Signed-off-by: Timur Tabi [EMAIL PROTECTED

Re: Merge linuxppc-embedded with linuxppc-dev

2008-09-23 Thread Timur Tabi
I also vote to kill the separate embedded list. It has such low traffic, and it seems like a lot of messages end up cross-posted to linuxppc-dev, anyway. I also agree that we should kill linuxppc-embedded. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH V2] powerpc: Fix Book-E watchdog timer interval setting

2008-09-23 Thread Timur Tabi
be equal to (3 30) | (15 15)? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] fsldma: remove internal self-test from Freescale Elo DMA driver

2008-09-23 Thread Timur Tabi
), the internal self-test code is not useful anyway. It is extremely unlikely that the test will fail in normal usage. It may have been helpful during development, but not any more. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- This patch is for 2.6.28. drivers/dma/fsldma.c | 132

[PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-19 Thread Timur Tabi
although we can call of_platform_bus_probe() to probe the DMA channels, there is no of_platform_bus_remove(). Therefore, the DMA channels must be manually probed. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- (Reposting because I forgot to CC: the maintainers) This patch is for the 2.6.28 kernel

Re: [git pull] Please pull powerpc.git merge branch

2008-09-18 Thread Timur Tabi
. This fixes that. Did you edit this patch when you pulled it from Kumar's repo? The commit in Kumar's repo says This patch fixes that., which is what I wrote. However, in your tree, the word patch is missing. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH V2] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-12 Thread Timur Tabi
On Fri, Sep 12, 2008 at 10:42 AM, Becky Bruce [EMAIL PROTECTED] wrote: Signed-off-by: Becky Bruce [EMAIL PROTECTED] Acked-By: Timur Tabi [EMAIL PROTECTED] The changelog could be a little beefier, though. I'm not a fan of having the changelog be an extension of the patch title. -- Timur Tabi

Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-09 Thread Timur Tabi
- please CC: me on any UCC UART or QE LIB patches) -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: fix interrupt values for DMA2 in MPC8610 HPCD device tree

2008-09-09 Thread Timur Tabi
The interrupt values in a device tree must be 16 greater than the actual interrupt number for a given device. The interrupt property for the DMA channels for DMA2 in the MPC8610 HPCD device tree was using the raw values, not the adjusted ones. Signed-off-by: Timur Tabi [EMAIL PROTECTED

[PATCH v2] powerpc: fix interrupt values for DMA2 in MPC8610 HPCD device tree

2008-09-09 Thread Timur Tabi
from 0. In the MPC8610 HPCD device tree, the interrupt properties for the DMA channels for DMA2 were not the adjusted values. This patch fixes that. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- I have no idea how this was missed for so long, but this patch is a must-fix for 2.6.27. (changes

Re: [PATCH] powerpc: add SSI-to-DMA properties to Freescale MPC8610 HPCD device tree

2008-09-04 Thread Timur Tabi
On Wed, Aug 6, 2008 at 11:48 AM, Timur Tabi [EMAIL PROTECTED] wrote: Add the fsl,playback-dma and fsl,capture-dma properties to the Freescale MPC8610 HPCD device tree. These properties connect the SSI nodes to the DMA nodes for the DMA channels that the SSI should use. Also update

Re: [PATCH] powerpc: fix memory leaks in QE library

2008-08-20 Thread Timur Tabi
there aren't even more. Of course, it would have been nice if someone had looked up the maintainer of the QE library in the MAINTAINERS file and notified me about these bugs. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing

[PATCH v2] powerpc: fix memory leaks in QE library

2008-08-20 Thread Timur Tabi
Fix two memory leaks in the Freescale QE library: add a missing kfree() in ucc_fast_init() and ucc_slow_init() if the ioremap() fails, and update ucc_fast_free() and ucc_slow_free() to call iounmap() if necessary. Based on a patch from Tony Breeds [EMAIL PROTECTED]. Signed-off-by: Timur Tabi

[PATCH] powerpc: fix memory leaks in QE library

2008-08-18 Thread Timur Tabi
Fix two memory leaks in the Freescale QE library: add a missing kfree() in ucc_fast_init() if the ioremap() fails, and update ucc_fast_free() to call iounmap() on uf_regs. Based on a patch from Tony Breeds [EMAIL PROTECTED]. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- arch/powerpc/sysdev

Re: [PATCH V2] DTC: Remove support for the legacy DTS source file format.

2008-08-15 Thread Timur Tabi
, that haven't been updated yet. How about just printing a warning and saying that the device tree should be updated with the conversion tool? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-13 Thread Timur Tabi
and on Sparc decoding the ihandle with the expectation that there will be further refinements to be made. Ack. -- Timur Tabi Linux Kernel Developer @ Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-07 Thread Timur Tabi
. output. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-07 Thread Timur Tabi
Milton Miller wrote: Why should what the hvc driver support have any effect on what the binding should be? Because my hypervisor console driver uses the hypervisor console/tty subsystem. If the subsystem assumes one stdout/stdin device, then I must abide by that. -- Timur Tabi Linux kernel

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-06 Thread Timur Tabi
these silly macros at all. Reference the structure fields directly, and use the in_ and out_ functions directly. Using macros like these encourages unnecessary typecasts. struct qe_bd has been defined, so you should use it. -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-06 Thread Timur Tabi
in the chosen node. I thought linux,stdout-path is deprecated are we're supposed to be using the aliases node instead? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

[PATCH] powerpc: add SSI-to-DMA properties to Freescale MPC8610 HPCD device tree

2008-08-06 Thread Timur Tabi
version of the Freescale MPC8610 device drivers are merged into the mainline. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- Documentation/powerpc/dts-bindings/fsl/ssi.txt | 15 +++ arch/powerpc/boot/dts/mpc8610_hpcd.dts |8 +--- 2 files changed, 20 insertions(+), 3

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
miss some? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
or an i2c one? gur-pordevsr2 MPC85xx_PORDEVSR2_SEC_CFG That should be guts- I think. The global utilities is a block of miscellaneous registers, one per SOC. It's not part of the I2C block. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
Jon Smirl wrote: What about the Efika which is mpc5200 based and doesn't use uboot? How does the Efika handle the dozen other properties that U-Boot normally initializes in the device tree? -- Timur Tabi Linux Kernel Developer @ Freescale

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
; #elif defined(CONFIG_MPC831X) i2c1_clk = enc_clk; #elif defined(CONFIG_MPC837X) i2c1_clk = sdhc_clk; #endif #if !defined(CONFIG_MPC832X) i2c2_clk = csb_clk; /* i2c-2 clk is equal to csb clk */ #endif -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
don't think you can combine it with the 8xxx table. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
= fsl_i2c_mpc8xxx_div3_set_freq, }, So we need to update this table every time there's a new SOC? All 83xx, 85xx, and 86xx SOCs use the same table. I'd prefer an implementation that does need a specific entry for each variant of 8[356]xx. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Wolfgang Grandegger wrote: We could add a property source-clock-divider = 2/3 if it's needed!? How about we just get U-Boot to put the core frequency in the device tree? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
, and not just a choice that the driver has the option of making on it's own). I was going to suggest the actual clock frequency of the I2C device. It would be value of gd-i2c1_clk or gd-i2c2_clk from U-Boot. The actual divider value is meaningless. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
. Let's take advantage of this and do something clean and elegant in the device tree. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
tree to customize as many things as possible. But that's just my opinion. U-Boot needs to configure the I2C bus speed because U-Boot uses the I2C. We should capitalize on that by taking the information that U-Boot has calculated and re-use it. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Scott Wood wrote: Timur Tabi wrote: Grant Likely wrote: No it doesn't, it depends on the register interface to decide compatibility. Clock interface is part of that. I don't think so. The interface for programming the clock registers is identical on all 8[356]xx parts. The only thing

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
frequency somehow. We may introduce the SOC property i2c-clock-frequency, which could be fixed up by U-Boot or a pre-loader (in case U-Boot is not used). Like for other frequency properties as well. That's what I'm proposing, but drop the i2c-. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
to store the divider? No thanks. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Wolfgang Grandegger wrote: Is it not exactly that? For me it's not a per I2C device property, at least. Of course it's a per-I2C device property. The input frequency to the I2C device is only seen by the I2C device, and no other device. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Wolfgang Grandegger wrote: 2) The speed of the I2C bus, as seen by devices on that bus. This is usually 400KHz. Which should be defined with the property current-speed, right? I would use something like bus-speed, but yes. The word current shouldn't be in a property string. -- Timur

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
as possible. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
to be looked up. a shared register setting? or a register setting within the i2c device? The I2C device itself has no idea what the divider is. It only sees the result of the divider. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
will put the final result in the device tree! That way, we won't need to update the platform driver *and* U-Boot for any new SOC. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
it in the I2C node allows the I2C driver to reference a property directly in the node that its probing. Aren't we talking about the /2 or /3 or /1 divider that appears to be randomly implemented on various members of the mpc8xxx family? Yes. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
into your platform driver. That's why I don't think the divider belongs in the device tree. Just put the actual resulting clock frequency in the device tree. Besides, putting that snippet in the platform driver *is* exposing it. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
fields and creates several properties in the FDT today, so what's wrong with adding another one? The clock frequencies have always been calculated by U-Boot, because putting them in the device tree is a bad idea. -- Timur Tabi Linux kernel developer at Freescale

Re: I2C node in device tree breaks old-style drivers

2008-07-30 Thread Timur Tabi
driver is the only I2C driver used on PowerPC systems that was outdated. :-) -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-25 Thread Timur Tabi
programs the speed, why does the driver program it again? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-25 Thread Timur Tabi
Wolfgang Grandegger wrote: I know but we still need an algorithm for MPC52xx and MPC82xx as well. That's true, but I still think hard-coding values of DFSR and FDR in the device tree is not a good way to do this. -- Timur Tabi Linux kernel developer at Freescale

Re: [alsa-devel] [PATCH v3 0/3] ALSA SoC: MPC5200 audio driver

2008-07-22 Thread Timur Tabi
Jon Smirl wrote: I'm just going to ignore 2.6.27 and wait for 2.6.28. 2.6.28 might have ASoC V2, or at least portions of it. You might want to just port your driver to ASoC V2 like I did and not worry about it. -- Timur Tabi Linux kernel developer at Freescale

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-18 Thread Timur Tabi
Grant Likely wrote: Okay, I've changed my mind. :-) I'll back off a bit from this extreme and call it: sound/soc/fsl/soc-of-simple.c That works for me. And please don't forget to CC: me on any discussion involving sound/soc/fsl. -- Timur Tabi Linux Kernel Developer @ Freescale

Re: [PATCH v2 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-17 Thread Timur Tabi
attention to the of_soc helper, because it's for ASoC V1 only. However, I don't understand why you need to reference it in the codec driver. My CS4270 codec driver knows nothing about OF and works fine in arch/powerpc. -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC] I2C: fsl-i2c: make device probing configurable via FDT

2008-07-16 Thread Timur Tabi
feature that encourages I2C bus probing. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc: fix ALSA options in Freescale 85xx and 86xx defconfigs

2008-07-16 Thread Timur Tabi
Timur Tabi wrote: The defconfigs for Freescale 85xx and 86xx SOCs had bad choices for some audio related options. In particular, OSS emulation should be enabled, and the old ALSA API should be disabled. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- Kumar, can you apply this patch

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-14 Thread Timur Tabi
Jon Smirl wrote: Which are we going to call it, fabric or machine? Fabric. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-14 Thread Timur Tabi
is called machine in ASoC v1. ASoC has always called it a machine driver. Wait, I thought it's supposed to be called a fabric driver now? On PowerPC, it should be called a fabric driver because we already have machine drivers. -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC] [PATCH] task_pt_regs for powerpc systems

2008-07-14 Thread Timur Tabi
Srinivasa D S wrote: +#define task_pt_regs(tsk)(tsk)-thread.regs Shouldn't this be: #define task_pt_regs(tsk) ((tsk)-thread.regs) just to be safe? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-14 Thread Timur Tabi
nodes that classify the motherboard and just let everyone get probed on it. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

<    3   4   5   6   7   8   9   10   11   >