[PATCH 2/8] powerpc/pseries: fix over writing of rtas return code in update_dt_node

2013-08-14 Thread Tyrel Datwyler
returns 0 on success. This results in ibm,update-properties not being called again for the given node when the rtas call rc was previously 1. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 1/8] powerpc/pseries: fix creation of loop in device node property list

2013-08-14 Thread Tyrel Datwyler
since the same property structure is used repeatedly. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries

[PATCH 3/8] powerpc/pseries: pack update_props_workarea to map correctly to rtas buffer header

2013-08-14 Thread Tyrel Datwyler
of fields, that map to the relevant header data, but the sizeof the structure is 24 bytes due to 4 bytes of padding at the end of the structure. Packing the structure ensures that we don't advance too far over the rtas buffer. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

[PATCH 7/8] powerpc/pseries: add mising of_node_put in delete_dt_node

2013-08-14 Thread Tyrel Datwyler
The node to be detached is retrieved via its phandle by a call to of_find_node_by_phandle which increments the ref count. We need a matching call to of_node_put to decrement the ref count and ensure the node is actually freed. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch

[PATCH 0/8] powerpc/pseries: fix/cleanup broken mobility device-tree update code

2013-08-14 Thread Tyrel Datwyler
in a device nodes subtree are initialized correctly. The remainder of the patchset fixes a couple problems with node removal. Tyrel Datwyler (8): powerpc/pseries: fix creation of loop in device node property list powerpc/pseries: fix over writing of rtas return code in update_dt_node powerpc

[PATCH 6/8] powerpc/pseries: make dlpar_configure_connector parent node aware

2013-08-14 Thread Tyrel Datwyler
. Passing the parent node where the new subtree will be created to dlpar_configure_connector allows the correct node path to be prefixed in the full_name field. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c| 55 --- arch

[PATCH 5/8] powerpc/pseries: do all node initialization in dlpar_parse_cc_node

2013-08-14 Thread Tyrel Datwyler
flag set these nodes are prevented from ever being released from memory should they become detached. This initialization step is better done at the time each node is allocated in dlpar_parse_cc_node. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c

[PATCH 8/8] powerpc/pseries: child nodes are not detached by dlpar_detach_node

2013-08-14 Thread Tyrel Datwyler
-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index 4ea667d..7cfdaae 100644 --- a/arch/powerpc/platforms/pseries

[PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal

2014-07-28 Thread Tyrel Datwyler
the bridge in the sysfs device tree it should be torn down first. This patch simply moves the device_unregister call for the PHB bridge device after the device_unregister call for the PHB bus. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/pci_dlpar.c

Re: [PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal

2014-07-29 Thread Tyrel Datwyler
On 07/28/2014 06:44 PM, Michael Ellerman wrote: On Mon, 2014-07-28 at 20:48 -0400, Tyrel Datwyler wrote: Commit bcdde7e made __sysfs_remove_dir() recursive and introduced a BUG_ON during PHB removal while attempting to delete the power managment attribute group of the bus. This is a result

[PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal

2014-07-29 Thread Tyrel Datwyler
-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- v2: - Included stable kernel list on Cc per comment by mpe arch/powerpc/platforms/pseries/pci_dlpar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries

Re: [3/5] pseries: Create device hotplug entry point

2014-09-22 Thread Tyrel Datwyler
On 09/17/2014 12:15 PM, Nathan Fontenot wrote: On 09/17/2014 02:07 AM, Michael Ellerman wrote: On Mon, 2014-09-15 at 15:31 -0500, Nathan Fontenot wrote: For pseries system the kernel will be notified of hotplug requests in the form of rtas hotplug events. Can you flesh that design out a

Re: [PATCH v2 1/3] drivers/of: add of_changeset_apply_locked

2014-09-25 Thread Tyrel Datwyler
On 09/24/2014 11:41 PM, Cyril Bur wrote: Due to the requirement of of_changesets that of_changeset_apply be called holding the of_mutex and that the of_mutex cannot be accessed nicely outside the of code, added a wrapper which grabs the lock and called of_changeset_apply. Signed-off-by:

Re: [PATCH v2 2/3] powerpc/pseries: create rtas buffer accessor

2014-09-25 Thread Tyrel Datwyler
On 09/24/2014 11:41 PM, Cyril Bur wrote: Added simple accessor functions for rtas in memory buffers which performs accesses of appropriate type and performs endian conversions. Signed-off-by: Cyril Bur cyril@au1.ibm.com --- arch/powerpc/platforms/pseries/Makefile | 4 +-

[PATCH] powerpc/pseries: dynamically added OF nodes need to call of_node_init

2014-07-09 Thread Tyrel Datwyler
of the previously removed kref_init calls. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c| 1 + arch/powerpc/platforms/pseries/reconfig.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc

Re: [PATCH] powerpc/pseries: dynamically added OF nodes need to call of_node_init

2014-07-10 Thread Tyrel Datwyler
On 07/09/2014 07:33 PM, Michael Ellerman wrote: On Wed, 2014-07-09 at 21:20 -0400, Tyrel Datwyler wrote: Commit 75b57ecf9 refactored device tree nodes to use kobjects such that they can be exposed via /sysfs. A secondary commit 0829f6d1f furthered this rework by moving the kobect

[PATCH v2] powerpc/pseries: dynamically added OF nodes need to call of_node_init

2014-07-10 Thread Tyrel Datwyler
this by adding of_node_init calls in place of the previously removed kref_init calls. Fixes: 0829f6d1f69e (of: device_node kobject lifecycle fixes) Cc: sta...@vger.kernel.org Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- V2: - included stable kernel list on Cc per comment by mpe

Re: OF_DYNAMIC node lifecycle

2014-07-16 Thread Tyrel Datwyler
On 07/15/2014 10:33 PM, Grant Likely wrote: I've got another question about powerpc reconfiguration. I was looking at the dlpar_configure_connector() function in dlpar.c. I see that the function has the ability to process multiple nodes with additional sibling and child nodes. It appears to

[PATCH 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-01-21 Thread Tyrel Datwyler
a panic. Finally, since the cache list fix utilzes in kernel device tree update code a means for telling drmgr not to perform a device tree update from userspace is required. Tyrel Datwyler (3): powerpc/pseries: Device tree should only be updated once after suspend/migrate powerpc/pseries

[PATCH 1/3] powerpc/pseries: Device tree should only be updated once after suspend/migrate

2014-01-21 Thread Tyrel Datwyler
for update-nodes after activating the FW. It also add rtas_busy delay for the activate-firmware rtas call. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 26 ++ 1 file changed

[PATCH 2/3] powerpc/pseries: Update dynamic cache nodes for suspend/resume operation

2014-01-21 Thread Tyrel Datwyler
list for the boot CPU, updates the device tree before enabling nonboot CPUs and adds cache list for the boot cpu. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/include/asm/rtas.h | 4 arch/powerpc/kernel/rtas.c | 17

[PATCH 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-01-21 Thread Tyrel Datwyler
is required for drmgr to determine who is responsible for the update. This patch adds a show function the the hibernate attribute that returns 1 if the kernel updates the device tree after the resume and 0 if drmgr is responsible. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

[PATCH v2 1/3] powerpc/pseries: Device tree should only be updated once after suspend/migrate

2014-01-22 Thread Tyrel Datwyler
update while adding device nodes. This patch makes a single rtas call for update-nodes after activating the FW. It also add rtas_busy delay for the activate-firmware rtas call. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

[PATCH v2 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-01-22 Thread Tyrel Datwyler
/pseries: Device tree should only be updated once after suspend/migrate powerpc/pseries: Update dynamic cache nodes for suspend/resume operation Tyrel Datwyler (1): powerpc/pseries: Report in kernel device tree update to drmgr arch/powerpc/include/asm/rtas.h | 4 arch

[PATCH v2 2/3] powerpc/pseries: Update dynamic cache nodes for suspend/resume operation

2014-01-22 Thread Tyrel Datwyler
not remove cache entries for the primary CPU. This patch removes the cache list for the boot CPU, updates the device tree before enabling nonboot CPUs and adds cache list for the boot cpu. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch

[PATCH v2 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-01-22 Thread Tyrel Datwyler
is required for drmgr to determine who is responsible for the update. This patch adds a show function to the hibernate attribute that returns 1 if the kernel updates the device tree after the resume and 0 if drmgr is responsible. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

[PATCH v3 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-01-31 Thread Tyrel Datwyler
from v1: - Fixed several commit message typos - Fixed authorship of first two patches Haren Myneni (2): powerpc/pseries: Device tree should only be updated once after suspend/migrate powerpc/pseries: Update dynamic cache nodes for suspend/resume operation Tyrel Datwyler (1): powerpc

[PATCH v3 1/3] powerpc/pseries: Device tree should only be updated once after suspend/migrate

2014-01-31 Thread Tyrel Datwyler
. This patch makes a single rtas call for update-nodes after activating the FW. It also add rtas_busy delay for the activate-firmware rtas call. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 26

[PATCH v3 2/3] powerpc/pseries: Update dynamic cache nodes for suspend/resume operation

2014-01-31 Thread Tyrel Datwyler
CPU. This patch removes the cache list for the boot CPU, updates the device tree before enabling nonboot CPUs and adds cache list for the boot cpu. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/include/asm/rtas.h | 1

[PATCH v3 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-01-31 Thread Tyrel Datwyler
is required for drmgr to determine who is responsible for the update. This patch adds a show function to the hibernate attribute that returns 1 if the kernel updates the device tree after the resume and 0 if drmgr is responsible. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

Re: [PATCH v3 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-02-12 Thread Tyrel Datwyler
On 01/31/2014 03:58 PM, Tyrel Datwyler wrote: This patchset fixes a couple of issues encountered in the suspend/resume code base. First when using the kernel device tree update code update-nodes is unnecessarily called more than once. Second the cpu cache lists are not updated after a suspend

Re: [PATCH v3 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-02-18 Thread Tyrel Datwyler
On 02/16/2014 04:22 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-01-31 at 15:58 -0800, Tyrel Datwyler wrote: Traditionally it has been drmgr's responsibilty to update the device tree through the /proc/ppc64/ofdt interface after a suspend/resume operation. This patchset however has modified

[PATCH v4 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-02-19 Thread Tyrel Datwyler
once after suspend/migrate powerpc/pseries: Update dynamic cache nodes for suspend/resume operation Tyrel Datwyler (1): powerpc/pseries: Report in kernel device tree update to drmgr arch/powerpc/include/asm/rtas.h | 1 + arch/powerpc/platforms/pseries/mobility.c | 26

[PATCH v4 1/3] powerpc/pseries: Device tree should only be updated once after suspend/migrate

2014-02-19 Thread Tyrel Datwyler
. This patch makes a single rtas call for update-nodes after activating the FW. It also add rtas_busy delay for the activate-firmware rtas call. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 26

[PATCH v4 2/3] powerpc/pseries: Update dynamic cache nodes for suspend/resume operation

2014-02-19 Thread Tyrel Datwyler
this is a redundant waste of a couple cycles it is harmless since firmware returns the same data for the subsequent update-nodes/properties rtas calls. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/include/asm/rtas.h | 1

[PATCH v4 3/3] powerpc/pseries: Expose in kernel device tree update to drmgr

2014-02-19 Thread Tyrel Datwyler
-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/suspend.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/suspend.c b/arch/powerpc/platforms/pseries/suspend.c index 1d9c580..b87b978 100644

[PATCH v3 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-02-19 Thread Tyrel Datwyler
is required for drmgr to determine who is responsible for the update. This patch adds a show function to the hibernate attribute that returns 1 if the kernel updates the device tree after the resume and 0 if drmgr is responsible. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc

Re: [PATCH v3 3/3] powerpc/pseries: Report in kernel device tree update to drmgr

2014-02-19 Thread Tyrel Datwyler
On 02/19/2014 12:56 PM, Tyrel Datwyler wrote: Traditionally it has been drmgr's responsibilty to update the device tree through the /proc/ppc64/ofdt interface after a suspend/resume operation. This patchset however has modified suspend/resume ops to preform that update entirely in the kernel

[prefix=PATCH v5 2/3] powerpc/pseries: Update dynamic cache nodes for suspend/resume operation

2014-02-25 Thread Tyrel Datwyler
this is a redundant waste of a couple cycles it is harmless since firmware returns the same data for the subsequent update-nodes/properties rtas calls. Signed-off-by: Haren Myneni hb...@us.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- Changes from v4: - fixes build break for !SMP

Re: [PATCH v4 0/3] powerpc/pseries: fix issues in suspend/resume code

2014-02-25 Thread Tyrel Datwyler
On 02/23/2014 05:53 PM, Benjamin Herrenschmidt wrote: On Wed, 2014-02-19 at 12:56 -0800, Tyrel Datwyler wrote: This patchset fixes a couple of issues encountered in the suspend/resume code base. First when using the kernel device tree update code update-nodes is unnecessarily called more than

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Tyrel Datwyler
On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman noticed, this fix was not complete, the token value was not

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Tyrel Datwyler
On 01/15/2015 02:19 PM, Michael Ellerman wrote: On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from

[PATCH 2/2] MAINTAINERS: ibmvfc driver maintainer change

2015-01-12 Thread Tyrel Datwyler
Change maintainer of ibmvfc driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH 1/2] MAINTAINERS: ibmvscsi driver maintainer change

2015-01-13 Thread Tyrel Datwyler
Change maintainer of ibmvscsi driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH 2/3] powerpc/pseries: Little endian fixes for post mobility device tree update

2015-02-27 Thread Tyrel Datwyler
in big endian format. This patch annotates variables and structure members with __be types as well as performing necessary byte swaps to cpu endian for data that needs to be parsed. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 36

[PATCH 0/3] powerpc/pseries: Fixes and cleanup of suspend/migration code

2015-02-27 Thread Tyrel Datwyler
itself. Tyrel Datwyler (3): powerpc/pseries: Simplify check for suspendability during suspend/migration powerpc/pseries: Little endian fixes for post mobility device tree update powerpc/pseries: Expose post-migration in kernel device tree update to drmgr arch/powerpc/include/asm

[PATCH 1/3] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-02-27 Thread Tyrel Datwyler
the extraneous vasi_state variable and simply uses the return code to communicate how to proceed. We either succeed, fail, or get -EAGAIN in which case we sleep for a second before trying to call rtas_ibm_suspend_me again. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/include

[PATCH 3/3] powerpc/pseries: Expose post-migration in kernel device tree update to drmgr

2015-02-27 Thread Tyrel Datwyler
update after a migration operation and that drmgr should initiated the migration through the sysfs migration attribute. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/mobility.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

Re: [PATCH 1/3] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-03-02 Thread Tyrel Datwyler
On 03/01/2015 08:19 PM, Cyril Bur wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: During suspend/migration operation we must wait for the VASI state reported by the hypervisor to become Suspending prior to making the ibm,suspend-me RTAS call. Calling routines

Re: [PATCH 2/3] powerpc/pseries: Little endian fixes for post mobility device tree update

2015-03-02 Thread Tyrel Datwyler
On 03/01/2015 09:20 PM, Cyril Bur wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: We currently use the device tree update code in the kernel after resuming from a suspend operation to re-sync the kernels view of the device tree with that of the hypervisor. The code as it stands

Re: [PATCH 3/3] powerpc/pseries: Expose post-migration in kernel device tree update to drmgr

2015-03-03 Thread Tyrel Datwyler
On 03/02/2015 10:24 PM, Michael Ellerman wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: Traditionally after a migration operation drmgr has coordinated the device tree update with the kernel in userspace via the ugly /proc/ppc64/ofdt interface. This can be better done

Re: [PATCH 1/3] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-03-03 Thread Tyrel Datwyler
On 03/02/2015 10:15 PM, Michael Ellerman wrote: On Mon, 2015-03-02 at 13:30 -0800, Tyrel Datwyler wrote: On 03/01/2015 08:19 PM, Cyril Bur wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: During suspend/migration operation we must wait for the VASI state reported

Re: [PATCH 0/3] powerpc/pseries: Fixes and cleanup of suspend/migration code

2015-03-03 Thread Tyrel Datwyler
On 03/02/2015 10:10 PM, Michael Ellerman wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: This patchset simplifies the usage of rtas_ibm_suspend_me() by removing an extraneous function parameter, fixes device tree updating on little endian platforms, and adds a mechanism

[Patch v2] powerpc/pseries: Little endian fixes for post mobility device tree update

2015-03-04 Thread Tyrel Datwyler
in big endian format. This patch annotates variables and structure members with __be types as well as performing necessary byte swaps to cpu endian for data that needs to be parsed. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Cyril Bur

[PATCH v2] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-03-04 Thread Tyrel Datwyler
the extraneous vasi_state variable and simply uses the return code to communicate how to proceed. We either succeed, fail, or get -EAGAIN in which case we sleep for a second before trying to call rtas_ibm_suspend_me again. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf

[PATCH] powerpc/pseries: Introduce api_version to migration sysfs interface

2015-03-04 Thread Tyrel Datwyler
versioning indicates it is capable of perfroming all current PAPR requirements for migration including the post-mobility firmware activation and device tree update. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Cyril Bur cyril...@gmail.com

Re: [PATCH 2/3] powerpc/pseries: Little endian fixes for post mobility device tree update

2015-03-03 Thread Tyrel Datwyler
On 03/03/2015 05:20 PM, Cyril Bur wrote: On Tue, 2015-03-03 at 15:15 -0800, Tyrel Datwyler wrote: On 03/02/2015 01:49 PM, Tyrel Datwyler wrote: On 03/01/2015 09:20 PM, Cyril Bur wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: We currently use the device tree update code

Re: [PATCH 2/3] powerpc/pseries: Little endian fixes for post mobility device tree update

2015-03-03 Thread Tyrel Datwyler
On 03/02/2015 01:49 PM, Tyrel Datwyler wrote: On 03/01/2015 09:20 PM, Cyril Bur wrote: On Fri, 2015-02-27 at 18:24 -0800, Tyrel Datwyler wrote: We currently use the device tree update code in the kernel after resuming from a suspend operation to re-sync the kernels view of the device tree

[PATCH v3 1/2] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-03-27 Thread Tyrel Datwyler
the propogated error code on failure. Previously -1 was returned from migrate_store() in the failure case which equates to -EPERM and was clearly wrong. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenont nf...@linux.vnet.ibm.com Cc: Cyril Bur cyril...@gmail.com --- Changes

Re: [PATCH] powerpc/pseries: Introduce api_version to migration sysfs interface

2015-03-23 Thread Tyrel Datwyler
On 03/04/2015 06:25 PM, Tyrel Datwyler wrote: The /sys/kernel/mobility/migration interface was added all the way back in 2.6.37. However, the drmgr userspace tool was never augmented to use this interface to perfrom migrations. Instead it has continued using a faux rtas call coupled

Re: [PATCH v2] powerpc/pseries: Simplify check for suspendability during suspend/migration

2015-03-23 Thread Tyrel Datwyler
On 03/04/2015 12:22 PM, Tyrel Datwyler wrote: During suspend/migration operation we must wait for the VASI state reported by the hypervisor to become Suspending prior to making the ibm,suspend-me RTAS call. Calling routines to rtas_ibm_supend_me() pass a vasi_state variable that exposes

Re: [PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

2015-04-23 Thread Tyrel Datwyler
On 04/22/2015 02:42 PM, Thomas Falcon wrote: On 04/20/2015 08:07 PM, David Gibson wrote: AFAIK the PAPR document which defines the virtual device interface used by the ibmveth driver doesn't specify a specific maximum MTU. So, in the PAPR itself doesn't, but the max-frame-size property, which

Re: [PATCH] powerpc/pseries: Fix possible leaked device node reference

2015-04-30 Thread Tyrel Datwyler
On 04/29/2015 06:44 PM, Nathan Fontenot wrote: Failure return from dlpar_configure_connector when dlpar adding cpus results in leaking references to the cpus parent device node. Move the call to of_node_put() prior to checking the result of dlpar_configure_connector. Fixes: 8d5ff320766f

Re: [PATCH] powerpc/rtas: Replace magic values with defines

2015-07-22 Thread Tyrel Datwyler
On 07/22/2015 09:56 AM, Thomas Huth wrote: rtas.h already has some nice #defines for RTAS return status codes - let's use them instead of hard-coded magic values! Signed-off-by: Thomas Huth th...@redhat.com Reviewed-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- arch/powerpc/kernel

Re: [PATCH] powerpc/pseries: hibernation/migration should honor topology update policy

2015-10-02 Thread Tyrel Datwyler
, Tyrel Datwyler wrote: > From: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > > The suspend call paths for hibernation and migration operations call > stop_topology_update() and start_topology_update() respectively prior to > suspending the LPAR and upon resume. Topology upda

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-04 Thread Tyrel Datwyler
On 02/04/2016 11:55 AM, Manoj Kumar wrote: > On 2/3/2016 5:28 PM, Tyrel Datwyler wrote: >> The PAPR defines four valid header values for the first byte of a >> CRQ message. Namely, an unused/empty message (0x00), a valid >> command/response entry (0x80), a valid initi

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Tyrel Datwyler
On 02/12/2016 08:43 AM, James Bottomley wrote: > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: >> Add defines for mad version and mad os_type, and replace the magic >> numbers in set_adapter_info() accordingly. >> >> Signed-off-by: Tyrel Datwyler

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-09 Thread Tyrel Datwyler
On 02/09/2016 09:41 AM, Manoj Kumar wrote: >> Yeah, I can see how that is confusing. Since, all three possible valid >> crq message types have the first bit set I think this was originally a >> cute hack to grab anything that was likely valid. Then in >> ibmvscsi_handle_crq() we explicitly match

[PATCH] ibmvfc: byteswap scsi_id, wwpn, and node_name prior to logging

2016-02-11 Thread Tyrel Datwyler
When logging async events the scsi_id, wwpn, and node_name values are used directly from the CRQ struct which are of type __be64. This can be confusing to someone looking through the log on a LE system. Instead byteswap these values to host endian prior to logging. Signed-off-by: Tyrel Datwyler

Re: [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

2016-02-04 Thread Tyrel Datwyler
On 02/04/2016 12:03 AM, Johannes Thumshirn wrote: > On Wed, Feb 03, 2016 at 05:28:33PM -0600, Tyrel Datwyler wrote: >> A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in >> the code for some time. From what information I've gathered from >> Brian King this w

[PATCH 1/6] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-03 Thread Tyrel Datwyler
support of PING messages between the VIOS and client adapter relies on VIOSRP_INLINE_FORMAT crq messages. Corrected these enum values to match PAPR definitions. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/viosrp.h | 4 ++-- 1 file changed, 2 insertions

[PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-03 Thread Tyrel Datwyler
of their magic number equivalents. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 14 +++--- drivers/scsi/ibmvscsi/viosrp.h | 7 +++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/d

[PATCH 4/6] ibmvscsi: Use of_root to access OF device tree root node

2016-02-03 Thread Tyrel Datwyler
The root node of the OF device tree is exported as of_root. No need to look up the root by path name. Instead just get a reference directly via of_root. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 14 ++ 1 file chan

[PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

2016-02-03 Thread Tyrel Datwyler
by any AIX based VIOS. Treating as bit rot and removing the sysfs interface and associated host config code accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 78 drivers/scsi/ibmvscsi/vi

[PATCH 3/6] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-03 Thread Tyrel Datwyler
Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- drivers/scsi/ibmvscsi/viosrp.h | 2 ++ 2 files changed, 4 insertions

[PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute show functions

2016-02-03 Thread Tyrel Datwyler
-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index a2b8db1..3621ac5 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c

[PATCH 0/6] ibmvscsi: code cleanup

2016-02-03 Thread Tyrel Datwyler
Fixed up a couple spots that were out of line with the PAPR in regards to its defined VSCSI protocol. Did away with some magic numbers directly in the code. Fixed a minor endian issue. Tyrel Datwyler (6): ibmvscsi: Correct values for several viosrp_crq_format enums ibmvscsi: Add and use enums

Re: [PATCH] powerpc/lpar: Don't crash on H_PROTECT errors

2016-02-29 Thread Tyrel Datwyler
On 02/29/2016 03:52 AM, Anshuman Khandual wrote: > There are certain condition in which H_PROTECT can return error code > other than H_NOT_FOUND and H_SUCCESS. One such being an attempt to > update an hpte owned by adjunct partition. Return 0 in that case so > that user space will retry the

[PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

2016-02-10 Thread Tyrel Datwyler
support of PING messages between the VIOS and client adapter relies on VIOSRP_INLINE_FORMAT crq messages. Corrected these enum values to match PAPR definitions. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s

[PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

2016-02-10 Thread Tyrel Datwyler
initialize (0x01) and initialize complete (0x02). Define these values as enums and use them in the code in place of their magic number equivalents. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 18 +- drivers/scsi/ibmvscsi/viosrp.h

[PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD

2016-02-10 Thread Tyrel Datwyler
by any AIX based VIOS. Treating as bit rot and removing the associated host config code. The config attribute and its show function are left as not to break userspace. The behavior remains the same returning nothing. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- driver

[PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions

2016-02-10 Thread Tyrel Datwyler
-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index e8d4

[PATCH v2 0/7] ibmvscsi code cleanup

2016-02-10 Thread Tyrel Datwyler
lid != VIOSRP_CRQ_FREE before handling in place of hacky bitwise & to check for first bit being set. -Added define for AIX os_type -Left sysfs config attribute to prevent breaking userspace Tyrel Datwyler (7): ibmvscsi: Correct values for several viosrp_crq_format enums ibmvscsi: Add and use enums for va

[PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-10 Thread Tyrel Datwyler
Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 drivers/scsi/ibmvscsi/viosrp.h | 3 +++ 2 files changed, 7 insertions

[PATCH v2 4/7] ibmvscsi: Use of_root to access OF device tree root node

2016-02-10 Thread Tyrel Datwyler
The root node of the OF device tree is exported as of_root. No need to look up the root by path name. Instead just get a reference directly via of_root. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s

[PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number

2016-02-10 Thread Tyrel Datwyler
In a couple places the magic value of 2 is used to check the return code of hypercalls. This translates to H_CLOSED. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH V2 2/2] pseries/eeh: Handle RTAS delay requests in configure_bridge

2016-03-29 Thread Tyrel Datwyler
On 03/28/2016 07:51 PM, Russell Currey wrote: > In the configure_pe and configure_bridge RTAS calls, the spec states > that values of 9900-9905 can be returned, indicating that software > should delay for 10^x (where x is the last digit, i.e. 990x) > milliseconds and attempt the call again.

Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-03 Thread Tyrel Datwyler
On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: > After obtaining a property from of_find_property() and before calling > of_remove_property() most code checks to ensure that the property > returned from of_find_property() is not null. The previous patch > moved this check to the start of the

Re: [PATCH 2/8] powerpc/memory: Parse new memory property to register blocks.

2016-07-25 Thread Tyrel Datwyler
On 07/25/2016 03:21 PM, Michael Bringmann wrote: > powerpc/memory: Add parallel routines to parse the new property > "ibm,dynamic-memory-v2" property when it is present, and then to > register the relevant memory blocks with the operating system. > This property format is intended to provide a

Re: [PATCH 1/8] powerpc/firmware: Add definitions for new firmware features.

2016-07-25 Thread Tyrel Datwyler
On 07/25/2016 03:21 PM, Michael Bringmann wrote: > Firmware Features: Define new bit flags representing the presence of > new device tree properties "ibm,drc-info", and "ibm,dynamic-memory-v2". > These flags are used to tell the front end processor when the Linux > kernel supports the new

Re: [PATCH] powernv/pci: Add PHB register dump debugfs handle

2016-07-25 Thread Tyrel Datwyler
On 07/21/2016 11:36 PM, Gavin Shan wrote: > On Fri, Jul 22, 2016 at 03:23:36PM +1000, Russell Currey wrote: >> On EEH events the kernel will print a dump of relevant registers. >> If EEH is unavailable (i.e. CONFIG_EEH is disabled, a new platform >> doesn't have EEH support, etc) this information

Re: [PATCH 0/2] ibmvfc: FC-TAPE Support

2016-08-11 Thread Tyrel Datwyler
On 08/03/2016 02:36 PM, Tyrel Datwyler wrote: > This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the > ibmvfc client driver. > > Tyrel Datwyler (2): > ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI > ibmvfc: add FC Class 3 Error Recovery support

Re: [PATCH v2 1/2] powerpc/pseries: Implemented indexed-count hotplug memory add

2016-07-19 Thread Tyrel Datwyler
On 07/18/2016 08:07 AM, Sahil Mehta wrote: > Indexed-count add for memory hotplug guarantees that a contiguous block > of lmbs beginning at a specified will be assigned (NOT > that lmbs will be added). Because of Qemu's per-DIMM memory > management, the addition of a contiguous block of memory

[Patch v2] rpaphp: fix slot registration for multiple slots under a PHB

2016-07-11 Thread Tyrel Datwyler
] rpaphp: Slot [C0] registered [ 38.482127] rpaphp: Slot [C1] registered [ 38.482241] rpaphp: Slot [C2] registered [ 38.482356] rpaphp: Slot [C3] registered [ 38.482495] rpaphp: Slot [C4] registered Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- Changes in v2: corrected

[PATCH] rpaphp: fix slot registration for multiple slots under a PHB

2016-07-08 Thread Tyrel Datwyler
] rpaphp: Slot [C0] registered [ 38.482127] rpaphp: Slot [C1] registered [ 38.482241] rpaphp: Slot [C2] registered [ 38.482356] rpaphp: Slot [C3] registered [ 38.482495] rpaphp: Slot [C4] registered Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/pci/hotplug/rpaphp_

Re: [PATCH 1/2] powerpc/pseries: Implemented indexed-count hotplug memory add

2016-07-11 Thread Tyrel Datwyler
On 06/30/2016 12:22 PM, Sahil Mehta wrote: > Indexed-count add for memory hotplug guarantees that a contiguous block > of lmbs beginning at a specified will be assigned (NOT > that lmbs will be added). Because of Qemu's per-DIMM memory > management, the addition of a contiguous block of memory

Re: [PATCH] rpaphp: fix slot registration for multiple slots under a PHB

2016-07-11 Thread Tyrel Datwyler
On 07/08/2016 04:57 PM, Nathan Fontenot wrote: > On 07/08/2016 06:19 PM, Tyrel Datwyler wrote: >> PowerVM seems to only ever provide a single hotplug slot per PHB. >> The under lying slot hotplug registration code assumed multiple slots, >> but the actual implementation i

[PATCH 0/2] ibmvfc: FC-TAPE Support

2016-08-03 Thread Tyrel Datwyler
This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the ibmvfc client driver. Tyrel Datwyler (2): ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI ibmvfc: add FC Class 3 Error Recovery support drivers/scsi/ibmvscsi/ibmvfc.c | 11 +++ drivers/scsi/ibmvscsi

[PATCH] ibmvfc: add FC Class 3 Error Recovery support

2016-08-03 Thread Tyrel Datwyler
at boot time. When enabled the RETRY service parameter bit is set during PRLI, and ibmvfc_cmd->flags includes the IBMVFC_CLASS_3_ERR bit. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++ drivers/scsi/ibmvscsi/ibmvfc.h | 1 +

[PATCH] ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI

2016-08-03 Thread Tyrel Datwyler
The READ FCP_XFER_READY DISABLED bit is required to always be set to one since FCP-3. Set it in the service parameter page frame during process login. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.c | 1 + 1 file changed, 1 insertion(+) diff

  1   2   3   4   5   6   7   >