On Sat, 02 Dec, 2023 13:56:50 -0800 Richard Cochran
wrote:
> On Wed, Nov 22, 2023 at 09:36:36AM -0800, Rahul Rameshbabu via Linuxptp-devel
> wrote:
>> Use the common NSEC_PER_SEC macro in phc_ctl.
>>
>> Signed-off-by: Rahul Rameshbabu
>
> Series applied, but I f
Use the common NSEC_PER_SEC macro in servo source code.
Signed-off-by: Rahul Rameshbabu
---
servo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/servo.c b/servo.c
index ea171cd..6d6753e 100644
--- a/servo.c
+++ b/servo.c
@@ -26,11 +26,10 @@
#include "pi.h"
#include "re
NSEC_PER_SEC conversion is used throughout the linuxptp source code.
Introduce a common macro that can be used throughout the linuxptp codebase
for this purpose.
Signed-off-by: Rahul Rameshbabu
---
util.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util.h b/util.h
index 2bbde71..1cbd9b
Use the common NSEC_PER_SEC macro in port-related source code.
Signed-off-by: Rahul Rameshbabu
---
port.c | 14 +++---
port_private.h | 3 +--
tc.c | 9 -
3 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/port.c b/port.c
index 5803cd3..79f3702 1
Use the common NSEC_PER_SEC macro in phc_ctl.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/phc_ctl.c b/phc_ctl.c
index 893d87d..c5d16ae 100644
--- a/phc_ctl.c
+++ b/phc_ctl.c
@@ -48,8 +48,6 @@
#include "util.h"
#inclu
On Thu, 09 Nov, 2023 21:17:03 -0800 Richard Cochran
wrote:
> On Mon, Sep 25, 2023 at 10:03:09AM -0700, Rahul Rameshbabu via Linuxptp-devel
> wrote:
>> The name NSEC2SEC implies converting nanoseconds to seconds, but the value
>> used for the macro converts seconds to nanosec
On Fri, 20 Oct, 2023 12:47:39 -0700 Richard Cochran
wrote:
> On Thu, Oct 19, 2023 at 03:50:20PM +0100, Luca Fancellu wrote:
>> From: Khem Raj
>>
>> Signed-off-by: Khem Raj
>> ---
>> interface.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/interface.c b/interface.c
>> index 292
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
The patch that introduces support for querying the maximum of
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes:
v1->v2:
- Accounted for conditional formatting changes suggested by Erez.
- Added pre-emptive return o
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro. Move macro to common location in util.h.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes:
v2->v3:
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
On Fri, 22 Sep, 2023 15:47:15 +0200 Przemek Kitszel
wrote:
> On 9/21/23 23:25, Rahul Rameshbabu via Linuxptp-devel wrote:
>> The name NSEC2SEC implies converting nanoseconds to seconds, but the value
>> used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
>&
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes:
v1->v2:
- Accounted for conditional formatting changes suggested by Erez.
- Added pre-emptive return o
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
The patch that introduces support for querying the maximum of
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro. Move macro to common location in util.h.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 8 +++-
port.c
Hi Erez,
On Tue, 05 Sep, 2023 22:15:47 +0200 Erez wrote:
> On Tue, 5 Sept 2023 at 21:56, Rahul Rameshbabu via Linuxptp-devel
> wrote:
>
> Advertise the maximum offset that can be fed to the PHC phase control
> keyword.
>
> Someone already sent this patch, a few months
Hi Erez,
On Wed, 06 Sep, 2023 23:05:12 +0200 Erez wrote:
> On Wed, 6 Sept 2023 at 00:56, Rahul Rameshbabu via Linuxptp-devel
> wrote:
>
> Take double precision floating point representation of an offset value in
> seconds. Feed this value to the PHC's phase control keyw
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro. Move macro to common location in util.h.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes since RFC:
*
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
The patch that introduces support for querying the maximum of
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/phc_ctl.c b/phc_ctl.c
index 34d9e0c..e174189 100644
--
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro. Move macro to common location in util.h.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes since RFC:
*
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/phc_ctl.c b/phc_ctl.c
index 34d9e0c..e174189 100644
--
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
The patch that introduces support for querying the maximum of
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
On Thu, 22 Jun, 2023 12:11:05 +0200 Erez wrote:
> On Wed, 21 Jun 2023 at 01:13, Rahul Rameshbabu wrote:
>
> Hi Erez,
>
> On Wed, 21 Jun, 2023 00:33:28 +0200 Erez wrote:
> > Hi,
> >
> > You already submitted the patch seria.
> > Has it changed?
>
> Yes, I took feedback from the RFC (reques
ee). I did not see a mention of that on the mailing list.
Might have missed it.
Thanks,
Rahul Rameshbabu
>
> Erez
>
> On Tue, 20 Jun 2023 at 19:39, Rahul Rameshbabu via Linuxptp-devel
> wrote:
>
> The main focus of this submission is adding support for testing ADJ_OFF
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/phc_ctl.c b/phc_ctl.c
index 34d9e0c..e174189 100644
--
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro. Move macro to common location in util.h.
Signed-off-by: Rahul Rameshbabu
---
Notes:
Changes since RFC:
*
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
That patch the introduces support for querying the maximum of
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
On Wed, 07 Jun, 2023 18:04:08 +0200 Maciek Machnikowski
wrote:
> On 6/7/2023 17:03, Erez wrote:
>>
>>
>> On Wed, 7 Jun 2023 at 00:09, Rahul Rameshbabu via Linuxptp-devel
>> > <mailto:linuxptp-devel@lists.sourceforge.net>> wrote:
>>
>>
Do not print success notices if clockadj operation fails using return
values provided by the clockadj helpers.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/phc_ctl.c b/phc_ctl.c
index 0db9352..70ee1e9 100644
--
Take double precision floating point representation of an offset value in
seconds. Feed this value to the PHC's phase control keyword.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.8 | 4
phc_ctl.c | 55 ---
2 files changed, 52 insertions(+
The name NSEC2SEC implies converting nanoseconds to seconds, but the value
used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
accurate name for this macro.
Signed-off-by: Rahul Rameshbabu
---
phc_ctl.c | 8
port.c | 14 +++---
port_private.h |
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.
Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu
The main focus of this submission is adding support for testing ADJ_OFFSET with
phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device
is capable of. Some other minor cleanups are also included in the submission.
The patch the introduces support for querying the maximum off
Advertise the maximum offset that can be fed to the PHC phase control
keyword.
Signed-off-by: Rahul Rameshbabu
---
missing.h | 9 +
phc_ctl.c | 4
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/missing.h b/missing.h
index 79a87d4..165a297 100644
--- a/missing.h
+++ b
Hi,
Any feedback on this patch would be appreciated. I believe this patch is useful
for improving the performance of the nullf servo, when write_phase_mode is
enabled. Provided below is demonstration of the performance benefits of the
patch. By transitioning to state s3 (SERVO_LOCKED_STABLE), we s
In the upstream linuxptp tree, the nullf servo has no way to transition to
the SERVO_LOCKED state except when the offset is zero. Transitioning to the
SERVO_LOCKED state is important for a servo that makes no frequency
adjustments because SERVO_LOCKED_STABLE is the only state that invokes
write_pha
The nullf servo can now enter the SERVO_LOCKED_STABLE state by
transitioning first to the SERVO_LOCKED state when the offset is less than
the set value for offset_threshold. If offset_threshold is not set, the
SERVO_LOCKED state can be entered when the offset is less than or equal to
the set value
Signed-off-by: Rahul Rameshbabu
---
servo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/servo.h b/servo.h
index 6c30d33..6e42b0a 100644
--- a/servo.h
+++ b/servo.h
@@ -48,7 +48,7 @@ enum servo_state {
SERVO_UNLOCKED,
/**
-* The is ready to track a
53 matches
Mail list logo
