On 04/05/2021 10:16, Miroslav Lichvar wrote:
> On Tue, May 04, 2021 at 04:43:51PM +0900, 박웅섭 wrote:
>> 1.In the text->length=c->desc.userDescription.length part of clock.c line
>> 368, the length declared in the static_ptp_text structure is of type signed
>> int and the length declared in the
On Tue, May 04, 2021 at 02:24:07PM +0200, Luigi 'Comio' Mantellini wrote:
> As side note, In my testing scenario the master-only ports receive
> announce messages and when the slave port loses the signal the node
> evolves in grand-master flooding the log with "assuming the grand
> master role"
Just like other process_*() that quickly return when the port state
doesn't require to process the incoming message, we can add a test
into process_announce() in order to avoid wasting the cpu.
This is not a special case, the announce messages should be ignored on
Master-only ports and the ports
Hi Richard,
not a problem, of course. I'm just speaking about code cleanup.
luigi
Il giorno mar 4 mag 2021 alle ore 14:00 Richard Cochran <
richardcoch...@gmail.com> ha scritto:
> On Mon, May 03, 2021 at 06:45:56PM +0200, Luigi 'Comio' Mantellini wrote:
> > /*
> > * A port going down can
On Mon, May 03, 2021 at 06:52:02PM +0200, Luigi 'Comio' Mantellini wrote:
> I noticed that the Announce messages received on MasterOnly ports
> generate a SDE condition in bc_event().
and so what? What is the problem?
> I think that we can return
> EV_NONE when the port is a master_only (or we
On Mon, May 03, 2021 at 06:45:56PM +0200, Luigi 'Comio' Mantellini wrote:
> /*
> * A port going down can affect the BMCA result.
> * Force a state decision event.
> */
> if (p->link_status & LINK_DOWN)
> clock_set_sde(p->clock, 1);
>
> I think that should be removed
Why? What problem does it
On Mon, May 03, 2021 at 05:09:09PM +0200, Michael Walle wrote:
> did I miss something or wasn't there a 3.2 release?
You didn't miss anything. I have been delayed in pushing out the 3.2
release.
Sorry,
Richard
___
Linuxptp-devel mailing list
Hi,
The commands we used for testing below issues are:
For 8275.1 profile:
ptp4l -f config_ptp_8275_1.conf -i sriov1 -i sriov0 -H -m 2 --boundary_clock=1
--slaveOnly=1
phc2sys -a -r -m -R 16 -n 24
For 8275.2 profile:
ptp4l -f config_ptp_8275_2.conf -i sriov1 -i sriov0 -H -m 4
Hi,
Based on your comments, we are pulling back this change.
For the issues we saw with the clientOnly=1 and boundary_clock_jbod=1, we have
sent out a new patch fixing them alone.
Thank you for your feedback.
Thanks,
Amar B S
-Original Message-
From: Ramana Reddy
Sent: 28 April 2021
This patch addresses the following issues when ptp4l is ran on multiple ports
with jbod and client only mode (i.e clientOnly=1 and boundary_clock_jbod=1):-
1.SYNCHRONIZATION FAULT occurs at every ANNOUNCE RECEIPT Timeout on LISTENING
port,
which leads to PTP port state of SLAVE port to flap
On Tue, May 04, 2021 at 04:43:51PM +0900, 박웅섭 wrote:
> 1.In the text->length=c->desc.userDescription.length part of clock.c line
> 368, the length declared in the static_ptp_text structure is of type signed
> int and the length declared in the text structure is unsigned int. Why did
> you write
Hi,
I did a static analysis of linuxPTP. Among them, the violation alarm that
occurred for the clock.c source code was analyzed and corrected from the
viewpoint of security.
I have questions among them, so I send an email.
1.In the text->length=c->desc.userDescription.length part of clock.c
12 matches
Mail list logo
