Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-15 Thread Kieran Tyrrell
> On 13 Sep 2016, at 20:00, Richard Cochran wrote: > > On Tue, Sep 13, 2016 at 09:32:39AM +0100, Kieran Tyrrell wrote: >> Should the ptp capabilities (in the igb case) state the number of >> alarms as 2? (even though only one can be enabled at a time, and in >> fact you can create hundreds of po

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-15 Thread Richard Cochran
On Thu, Sep 15, 2016 at 12:46:14PM +0100, Kieran Tyrrell wrote: > I wouldn’t be comfortable removing one of the periodic outputs from > igb in case anyone is using both. I only meant doing this for testing purposes. > I’ve added an ioctl to enable/disable the timer functionality on > either of t

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-15 Thread Kieran Tyrrell
> On 15 Sep 2016, at 12:33, Richard Cochran wrote: > > On Thu, Sep 15, 2016 at 09:56:24AM +0100, Kieran Tyrrell wrote: > >> My signal delivery problem was a bug in the igb interrupt handler, >> where I was assuming I could set a new trigger time for TT0 before >> acknowledging the interrupt. Tu

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-15 Thread Richard Cochran
On Thu, Sep 15, 2016 at 09:56:24AM +0100, Kieran Tyrrell wrote: > My signal delivery problem was a bug in the igb interrupt handler, > where I was assuming I could set a new trigger time for TT0 before > acknowledging the interrupt. Turns out I have to disable TT0, > acknowledge the interrupt, pro

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-15 Thread Kieran Tyrrell
> On 12 Sep 2016, at 18:14, Richard Cochran wrote: > > On Mon, Sep 12, 2016 at 02:52:03PM +0100, Kieran Tyrrell wrote: > >> I agree. Previously I was finding that sending the signals directly >> from ptp_clock_event unreliable (around 1 in 1,000,000 signals >> seemed to be getting lost) while f

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-13 Thread Richard Cochran
On Tue, Sep 13, 2016 at 09:32:39AM +0100, Kieran Tyrrell wrote: > Should the ptp capabilities (in the igb case) state the number of > alarms as 2? (even though only one can be enabled at a time, and in > fact you can create hundreds of posix timers off a single hardware > alarm? Looking back, it i

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-13 Thread Kieran Tyrrell
> On 12 Sep 2016, at 10:09, Richard Cochran wrote: > > On Fri, Sep 09, 2016 at 10:39:09PM +0100, Kieran Tyrrell wrote: >> +int (*timerenable)(struct ptp_clock_info *ptp, bool enable); >> +int (*timersettime)(struct ptp_clock_info *ptp, struct timespec64 *ts); > > These need kerneldoc co

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-12 Thread Richard Cochran
On Mon, Sep 12, 2016 at 02:52:03PM +0100, Kieran Tyrrell wrote: > > The clock_gettime and timer_settime etc prototypes are declared in > struct posix_clock_operations in posix-clock.h, and used by > everything that implements a POSIX clock. The new interfaces that I > have defined between the PTP

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-12 Thread Kieran Tyrrell
> On 12 Sep 2016, at 10:09, Richard Cochran wrote: > > On Fri, Sep 09, 2016 at 10:39:09PM +0100, Kieran Tyrrell wrote: >> a PTP hardware clock supporting timers (alarms) can now be used via the >> POSIX timer (timer_create, timer_settime etc) interface >> >> Signed-off-by: Kieran Tyrrell >> -

Re: [Linuxptp-devel] [PATCH] PTP subsystem: implement POSIX timer interface

2016-09-12 Thread Richard Cochran
On Fri, Sep 09, 2016 at 10:39:09PM +0100, Kieran Tyrrell wrote: > a PTP hardware clock supporting timers (alarms) can now be used via the POSIX > timer (timer_create, timer_settime etc) interface > > Signed-off-by: Kieran Tyrrell > --- > drivers/ptp/ptp_clock.c | 233 > +++