On Mon, Sep 12, 2016 at 02:52:03PM +0100, Kieran Tyrrell wrote: > > The clock_gettime and timer_settime etc prototypes are declared in > struct posix_clock_operations in posix-clock.h, and used by > everything that implements a POSIX clock. The new interfaces that I > have defined between the PTP module and the ethernet driver use > timespec64.
Ok. > likewise here, I am reusing the existing clock_gettime function to > get the current time. I assume you are not suggesting I update the > whole POSIX clock implementation to use timespec64? No, not unless you really want to. That effort is headed by Arnd Bergmann, and I thought this part was finished already. > I agree. Previously I was finding that sending the signals directly > from ptp_clock_event unreliable (around 1 in 1,000,000 signals > seemed to be getting lost) while from a work queue they all arrived > safely. After further debugging I’m not sure if the problem was with > the PTP module, the igb module, my test code, or even my > PC. (running the same posix timer tests on the MONOTONIC clock > occasionally produces kernel log messages hrtimer:interrupt took > 3193ns). Something is fishy, yes, but we should get to the bottom of it. I can help test this once you drop the work queue. I have seen the interrupts on the i210 get stuck when stressing the input time stamp function with a 1 kHz input. The interrupts simply stop triggering. But your issue sounds different. Thanks, Richard ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel