Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-20 Thread Ivan Maguidhir
Hi Christian Many thanks for the reply earlier! On 20/10/2019 16:18, Christian Schoenebeck wrote: Well, since we support both gtk3 and gtk2, and since there are no plans to drop gtk2 support, it was good to know though that there was an gtk2 issue. That's great that both will be supported goin

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-20 Thread Christian Schoenebeck
On Mittwoch, 16. Oktober 2019 23:44:13 CEST Ivan Maguidhir wrote: > Whoops. It was my fault, I didn't have the gtk3-devel package installed. > The configure script now detects gtk3 properly. Well, since we support both gtk3 and gtk2, and since there are no plans to drop gtk2 support, it was good

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-16 Thread Ivan Maguidhir
Hi Christian Whoops. It was my fault, I didn't have the gtk3-devel package installed. The configure script now detects gtk3 properly. All the best, Ivan ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sou

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-16 Thread Ivan Maguidhir
Hi Christian On 16/10/2019 19:02, Christian Schoenebeck wrote: I just wonder why it did not work there on your machine. For me it worked before both on Linux as well as on Mac, so I wonder what's the difference. Are you still using Gtk2? Yes, that was it. I'm using Fedora 30 and I have both gtk

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-16 Thread Christian Schoenebeck
On Dienstag, 8. Oktober 2019 14:50:30 CEST Christian Schoenebeck wrote: > On Dienstag, 8. Oktober 2019 01:00:15 CEST Ivan Maguidhir wrote: > > Hi Christian > > > > I really like the graphical render of the LFO settings! The attached > > gigedit patch connects all of the LFO controls to queue_draw(

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-08 Thread Christian Schoenebeck
On Dienstag, 8. Oktober 2019 01:00:15 CEST Ivan Maguidhir wrote: > Hi Christian > > I really like the graphical render of the LFO settings! The attached > gigedit patch connects all of the LFO controls to queue_draw() so that > the graphic gets redrawn while the user is making changes to any of th

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-07 Thread Ivan Maguidhir
Hi Christian I was missing some changes from my linuxsampler patch earlier. I've attached an updated one. All the best, Ivan diff -Naur linuxsampler_orig/src/engines/common/AbstractVoice.cpp linuxsampler_mod/src/engines/common/AbstractVoice.cpp --- linuxsampler_orig/src/engines/common/Abstrac

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-07 Thread Ivan Maguidhir
Hi Christian I really like the graphical render of the LFO settings! The attached gigedit patch connects all of the LFO controls to queue_draw() so that the graphic gets redrawn while the user is making changes to any of them. I noticed while I was using gigedit that the range for Control Dep

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-10-03 Thread Christian Schoenebeck
On Sonntag, 29. September 2019 21:06:14 CEST Ivan Maguidhir wrote: > On 29/09/2019 11:17, Christian Schoenebeck wrote: > > Ok then I guess I'll change that in our gig engine to: > > * LFO1 (volume): mid start level > > * LFO2 (cutoff): mid start level > > * LFO3 (pitch): max start leve

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-29 Thread Ivan Maguidhir
On 29/09/2019 11:17, Christian Schoenebeck wrote: Ok then I guess I'll change that in our gig engine to: * LFO1 (volume): mid start level * LFO2 (cutoff): mid start level * LFO3 (pitch): max start level Sounds good. Thanks Christian. unless somebody has objections.

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-29 Thread Christian Schoenebeck
On Samstag, 28. September 2019 20:13:16 CEST Ivan Maguidhir wrote: > > As for LFO1: it seems you were right, according to your audio demo file it > > seems as if LFO1 starts with a mid value (instead of a max value that we > > currently have in our implementation). > > Yes, from listening I wasn't

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-28 Thread Ivan Maguidhir
On 28/09/2019 12:51, Christian Schoenebeck wrote: Thanks! No problem. I looked and listened to your audio files. As for LFO1: it seems you were right, according to your audio demo file it seems as if LFO1 starts with a mid value (instead of a max value that we currently have in our implementa

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-28 Thread Christian Schoenebeck
On Samstag, 28. September 2019 00:55:32 CEST Ivan Maguidhir wrote: > On 27/09/2019 20:25, Christian Schoenebeck wrote: > > That way you should clearly hear the difference whether the amp LFO starts > > with max. volume or mid value volume. > > > > For LFO 2 and LFO 3 you would do the same steps. >

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-27 Thread Ivan Maguidhir
On 27/09/2019 20:25, Christian Schoenebeck wrote: That way you should clearly hear the difference whether the amp LFO starts with max. volume or mid value volume. For LFO 2 and LFO 3 you would do the same steps. Hi Christian I've updated the wave files I linked to earlier. Of course they we

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-27 Thread Ivan Maguidhir
On 27/09/2019 20:25, Christian Schoenebeck wrote: Hmm, sounds not very reliable for this issue. Yes, you're right. That way you should clearly hear the difference whether the amp LFO starts with max. volume or mid value volume. For LFO 2 and LFO 3 you would do the same steps. Thanks a mi

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-27 Thread Christian Schoenebeck
On Freitag, 27. September 2019 17:24:43 CEST Ivan Maguidhir wrote: > On 27/09/2019 10:12, Christian Schoenebeck wrote: > > That graphic in the GSt editor might as well just be some symbolic > > representation of the LFO wave form, or does the graphic of the LFO > > function change when you alter an

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-27 Thread Ivan Maguidhir
On 27/09/2019 10:12, Christian Schoenebeck wrote: That graphic in the GSt editor might as well just be some symbolic representation of the LFO wave form, or does the graphic of the LFO function change when you alter any parameter? Yes, the wavelength of the waveform representing the LFO in the

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-27 Thread Christian Schoenebeck
On Freitag, 27. September 2019 04:39:39 CEST Ivan Maguidhir wrote: > I checked the GSt3 editor and its audio window indicates that LFOs 1-3 > start with the mid value. Seeing as the wave-forms in this window appear > to be accurate representations of audio file contents and LFO settings > the phase

Re: [Linuxsampler-devel] GigaStudio LFO compatibility

2019-09-26 Thread Ivan Maguidhir
On 26/09/2019 14:32, Christian Schoenebeck wrote: Hi all, Hi Christian, I was reviewing our gig engine's LFO code and noticed that their behaviour does not match with GigaStudio's original LFO behaviour. So I planned to change that: 1. Our gig engine is using triangle LFOs whereas it looks