Re: [Linuxwacom-devel] [PATCH 1/3] Change b to button and oldButton to oldOption

2010-05-27 Thread Ping Cheng
Thank you for the review (for both patches). My reply is inline as usual. Ping On Wed, May 26, 2010 at 11:08 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, May 25, 2010 at 08:07:58PM -0700, Ping Cheng wrote: Change b to button and oldButton to oldOption to avoid confusion

[Linuxwacom-devel] [PATCH 1/3] Change b to button and oldButton to oldOption

2010-05-25 Thread Ping Cheng
Change b to button and oldButton to oldOption to avoid confusion. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmValidateDevice.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c

[Linuxwacom-devel] [PATCH 2/3] Add a new define (WAC_LCD) for tablet_id

2010-05-25 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmValidateDevice.c | 11 --- src/xf86WacomDefs.h |1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index c46043f..df1375c 100644 --- a/src

[Linuxwacom-devel] [PATCH 3/3] Add two finger gestures for Bamboo with touch

2010-05-25 Thread Ping Cheng
approach, but expect it to be temporary only. Signed-off-by: Ping Cheng pi...@wacom.com --- include/wacom-properties.h |6 + src/wcmCommon.c| 100 - src/wcmConfig.c|7 + src/wcmTouchFilter.c | 552 src

Re: [Linuxwacom-devel] [RFC PATCH] Duplicate the InputAttributes for dependent devices.

2010-05-24 Thread Ping Cheng
The voting window is closed. The official result is 3.5 to 1.5 (the .5 is from Ron :). Approach 1 gets approved (Signed-off-by: Ping Cheng) Peter, go ahead and take your gang (of three and half :) with you to get the job done! I know I don't have friends here :(. Ping On Mon, May 24, 2010

Re: [Linuxwacom-devel] [PATCH] xsetwacom: add a descriptive comment on how xsetwacom works these days.

2010-05-23 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Sun, May 23, 2010 at 4:23 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  tools/xsetwacom.c |   23 +++  1 files changed, 23 insertions(+), 0 deletions

Re: [Linuxwacom-devel] [PATCH v2] xsetwacom: print an error if the property does not exist on the device.

2010-05-23 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Sun, May 23, 2010 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Custom get_funcs that do not have a property name skip this part and go straight to the get_func, all others get the property tested. Signed-off-by: Peter Hutterer

[Linuxwacom-devel] 0.8.7-1 posted

2010-05-21 Thread Ping Cheng
This testing release: Added support for Cintiq 21UX2 and Intuos4 Wireless (the USB EndPoint) Removed kernels 2.6.9 to 2.6.15 support Normalized the 6th valuator to 2048 Updated wacomcpl for button options See details in the ChangeLog. Ping

Re: [Linuxwacom-devel] [PATCH] Don't add the OutOfProximity flag to the axis mode.

2010-05-20 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com On Thu, May 20, 2010 at 12:01 AM, Peter Hutterer peter.hutte...@who-t.net wrote: The server and many clients tends to check for Absolute and/or Relative, but don't use Absolute as a flag. The XI protocol spec only allows for 0 or 1 (Relative

Re: [Linuxwacom-devel] [PATCH] xsetwacom: print an error if the property does not exist on the device.

2010-05-20 Thread Ping Cheng
I am not familiar with the xf86-input-wacom/tools/xsetwacom.c code. And , I don't have time to read through the file to see the whole picture. So, just throw a wild question at you to see if it hits anything or not :). Ping On Wed, May 19, 2010 at 10:07 PM, Peter Hutterer

Re: [Linuxwacom-devel] Waltop (VisTablet PenPad) support

2010-05-19 Thread Ping Cheng
On Wed, May 19, 2010 at 9:17 AM, Matt Harrison matthewharri...@gmail.com wrote: On Fri, May 14, 2010 at 10:54 AM, Matt Harrison matthewharri...@gmail.com wrote: Hey Folks- So I've got a few questions: * What needs to happen to have vendor checking in the project support waltop? Still

Re: [Linuxwacom-devel] xf86-input-wacom-multihead.patch

2010-05-19 Thread Ping Cheng
Thank you Ron for catching the ball. I've never seen it coming my way :(. Hi Rob, We got your patch this time. The multi-monitor support on X servers newer than 1.7 could have been totally broken since there are quite a few server and video driver changes in the past a year or so. No one has

[Linuxwacom-devel] [PATCH] Centralize TPCButton/Touch/Gesture initialization

2010-05-19 Thread Ping Cheng
touch can change these options. If a tool other than touch tries to set those common touch options, a warning will be reported and the option will be ignored. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmConfig.c |2 +- src/wcmISDV4.c |7 -- src/wcmUSB.c

Re: [Linuxwacom-devel] [Linuxwacom-discuss] Button 4 and 5 events on wheel with xf86-input-wacom and xorg 1.7

2010-05-10 Thread Ping Cheng
or just the fix? Ping On Mon, May 10, 2010 at 10:18 AM, Emil Assarsson emil.assars...@gmail.com wrote: I reverted Always init wheel buttons to 4/5. 0fbd3e34d792cb17163c1974d7e8ce93c24242a0 and got rid of the problem :-) On Mon, May 10, 2010 at 6:10 PM, Ping Cheng pingli...@gmail.com wrote

[Linuxwacom-devel] [PATCH] xf86-input-wacom: Button 4 and 5 events are only for touch ring

2010-05-10 Thread [Ping Cheng
From: Ping Cheng pi...@wacom.com Only absolute wheels on the pad (normally touch rings) can send button events. Absolute wheels that are defined for the stylus, such as airbrush wheel or ArtPen rotation should only report raw data. It would be up to the client/application to translate those raw

Re: [Linuxwacom-devel] bamboo touch resolution

2010-05-05 Thread Ping Cheng
On Tue, May 4, 2010 at 11:49 PM, Rafi Rubin r...@ugcs.caltech.edu wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I was just glancing at the report description from lsusb of my bamboo.            Item(Global): Usage Page, data= [ 0x01 ] 1                            Generic Desktop

Re: [Linuxwacom-devel] [PATCH] Remove redundand MAX_USB_EVENTS definition from xf86Wacom.h

2010-05-05 Thread Ping Cheng
Hi Przemo, It might make sense to move MAX_USB_EVENTS along with wcmEvents from xf86WacomDefs.h to wcmUSB.c since only that file requires them. Ping On Wed, May 5, 2010 at 11:40 AM, Przemo Firszt prz...@firszt.eu wrote: Hi, git grep MAX_USB_EVENTS told me that we don't need that definition..

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: Add two finger gestures for Bamboo with touch

2010-05-02 Thread Ping Cheng
On Wed, Apr 28, 2010 at 10:55 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Apr 22, 2010 at 05:13:49PM -0700, Ping Cheng wrote: From 5b4ef69ca90d5d35eb3df89573cfadd5d6e1a5e7 Mon Sep 17 00:00:00 2001 From: Ping Cheng pingli...@gmail.com Date: Thu, 22 Apr 2010 16:19:13 -0700

Re: [Linuxwacom-devel] [PATCH] conf: add WACf, FUJ02e5 and FUJ02e7 to serial identifers.

2010-04-28 Thread Ping Cheng
Reviewed-by: Ping Cheng pi...@wacom.com Ping On Wed, Apr 28, 2010 at 4:18 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  conf/50-wacom.conf |    8  1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/conf

[Linuxwacom-devel] [PATCH 1 of 4] xf86-input-wacom: Add tablet_type to WacomModel

2010-04-25 Thread Ping Cheng
tablet_type is introduced to distingush the specific features that a group of tablets supported. It will be used to replace the wcmModel-name check. Signed-off-by: Ping Cheng pi...@wacom.com 0001-add-tablet_type-to-WacomModel.patch Description: Binary data

[Linuxwacom-devel] [PATCH 3 of 4] xf86-input-wacom: Replace Bamboo touch tablet_id check with tablet_type

2010-04-25 Thread Ping Cheng
Replace Bamboo touch tablet_id check with tablet_type Signed-off-by: Ping Cheng pi...@wacom.com 0003-Replace-Bamboo-touch-tablet_id-check-with-tablet_typ.patch Description: Binary data

[Linuxwacom-devel] [PATCH 4 of 4] xf86-input-wacom: Centralize TPCButton/Touch/Gesture initialization

2010-04-25 Thread Ping Cheng
through xorg.conf, only touch can change these options. Common options would not be overridden in xorg.conf as long as the options are the same for all the tools that are associated with the same tablet. Common options set through xsetwacom apply to the whole tablet. Signed-off-by: Ping Cheng pi

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: Add two finger gestures for Bamboo with touch

2010-04-25 Thread Ping Cheng
solution is in place, more people could help us bring linuxwacom and xf86-input-wacom in sync. Ping On Thu, Apr 22, 2010 at 7:13 PM, Ping Cheng pingli...@gmail.com wrote: This patch is a little bit long.  But all changes serve the same purpose: add two finger gestures for Bamboo with touch

[Linuxwacom-devel] [PATCH] xf86-input-wacom: Add two finger gestures for Bamboo with touch

2010-04-22 Thread Ping Cheng
This patch is a little bit long. But all changes serve the same purpose: add two finger gestures for Bamboo with touch. Both src and tools/include are updated Signed-off-by: Ping Cheng pi...@wacom.com 0002-Add-two-finger-gestures-for-Bamboo-with-touch.patch Description: Binary data

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: Assign-wcmTPCButton-based-on-the-device-only

2010-04-22 Thread Ping Cheng
On Thu, Apr 22, 2010 at 7:47 PM, Chris Bagwell ch...@cnpbagwell.com wrote: doesn't removing this get rid of the default on for tablet PCs? what am I missing here? Probably we finally  have enough info (tablet_id?) in preInit() that you can set wcmTPCButtonDefault and then just rely on single

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: Assign-wcmTPCButton-based-on-the-device-only

2010-04-22 Thread Ping Cheng
On Thu, Apr 22, 2010 at 7:47 PM, Chris Bagwell ch...@cnpbagwell.com wrote: diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 97b3fe6..93ea166 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -462,8 +462,7 @@ static Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)       }      

Re: [Linuxwacom-devel] [PATCH] Fix some indentation in xf86WacomDefs.h.

2010-04-21 Thread Ping Cheng
Acked-by: Ping Cheng pi...@wacom.com P.S., I wasn't the author :). Ping On Wed, Apr 21, 2010 at 9:27 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Every time I look at it this confuses me... Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  src/xf86WacomDefs.h |    4

[Linuxwacom-devel] [PATCH] xf86-input-wacom: Normalize pressure sensitivity

2010-04-14 Thread Ping Cheng
have a pre-loaded initial pressure. This patch checks the in-prox pressure and subtract it from the raw pressure to prevent a potential left-click before the pen touches the tablet. Left click threshold and pressure curve are updated accordingly. Signed-off-by: Ping Cheng pi...@wacom.com From

[Linuxwacom-devel] [PATCH v2] xf86-input-wacom: Normalize pressure sensitivity

2010-04-14 Thread Ping Cheng
pressure to prevent a potential left-click before the pen touches the tablet. Left click threshold and pressure curve are updated accordingly. Signed-off-by: Ping Cheng pi...@wacom.com From 4769e48d408397a0bbce744ab2ceb0f9bb4077df Mon Sep 17 00:00:00 2001 From: Ping Cheng pi...@wacom.com Date: Wed, 14

Re: [Linuxwacom-devel] [PATCH] Use SETBIT and CLEARBIT macros to set the tool types.

2010-04-08 Thread Ping Cheng
Acked-by: Ping Cheng pi...@wacom.com On Thu, Apr 8, 2010 at 4:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Macros like this are in common use in the kernel, X server, etc. and are slightly more readable than the |= and = ~ expressions. Signed-off-by: Peter Hutterer peter.hutte

[Linuxwacom-devel] [PATCH] xf86-input-wacom: Normalize pressure sensitivity

2010-03-30 Thread Ping Cheng
pressure to prevent a potential left-click before the pen touches the tablet. Left click threshold and pressure curve are updated accordingly. Signed-off-by: Ping Cheng pi...@wacom.com From b31371bdc655d554074fe0f3982498d2d4c062e0 Mon Sep 17 00:00:00 2001 From: Ping Cheng pi...@wacom.com Date: Tue, 30

[Linuxwacom-devel] [PATCH] xf86-input-wacom - TPCButton is on by default for ISDV4 devices

2010-03-29 Thread Ping Cheng
This patch fixes the issue reported at https://sourceforge.net/projects/linuxwacom/forums/forum/236872/topic/3647761/index/page/1. The recent updates for ISDV4.c didn't set TPCButton on by default. Signed-off-by: Ping Cheng pi...@wacom.com From db4c47c79aea3903cd299d0ecd99e16556f494a1 Mon Sep 17

[Linuxwacom-devel] 0.8.5-12 posted

2010-03-26 Thread Ping Cheng
This dash release: * Updated kernel driver for 2FGT and Bamboo touch * Added 2.6.30 path for kernels 2.6.30 and later * Normalized pressure sensitivity to 2048 * Updated 2FGT gesture with Chris Bagwell's suggestion The whole 0.8.5 unstable release: Support USB

Re: [Linuxwacom-devel] [PATCH 0/6] xsetwacom: allow for special button mappings

2010-03-25 Thread Ping Cheng
Acked-by: Ping Cheng pi...@wacom.com Ping On Thu, Mar 25, 2010 at 6:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This series fixes a few bugs with the special button assigment and adds the ability to use the button keywords. Options like xsetwacom set device Button1 button 1 key

[Linuxwacom-devel] [PATCH] xf86-input-wacom: User defined ISDV4 device types in xorg.conf are always valid

2010-03-24 Thread Ping Cheng
We might not get all the valid types for ISDV4 devices in wcmPreInit(). Assuming users know what they are doing so we make their types valid. Signed-off-by: Ping Cheng pi...@wacom.com From fcf8974b5f9ee3d515a12296467efc0a14b6ce82 Mon Sep 17 00:00:00 2001 From: Ping Cheng pi...@wacom.com Date: Wed

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: User defined ISDV4 device types in xorg.conf are always valid

2010-03-24 Thread Ping Cheng
On Wed, Mar 24, 2010 at 5:15 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 24, 2010 at 03:13:10PM -0700, Ping Cheng wrote: We might not get all the valid types for ISDV4 devices in wcmPreInit(). Assuming users know what they are doing so we make their types valid. Signed-off

Re: [Linuxwacom-devel] [PATCH] xf86-input-wacom: User defined ISDV4 device types in xorg.conf are always valid

2010-03-24 Thread Ping Cheng
On Wed, Mar 24, 2010 at 6:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 24, 2010 at 06:15:31PM -0700, Ping Cheng wrote: On Wed, Mar 24, 2010 at 5:15 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 24, 2010 at 03:13:10PM -0700, Ping Cheng wrote: We might

[Linuxwacom-devel] [PATCH 1/2] xf86-input-wacom: Move BTN_TOOL_TRIPLETAP to the header

2010-03-23 Thread Ping Cheng
Move BTN_TOOL_TRIPLETAP definition from wcmUSB.c to xf86WacomDefs.h since it is also used by wcmValidateDevice.c and wcmISDV4.c Signed-off-by: Ping Cheng pi...@wacom.com From a8e9058175702eea96c9f9daa57a804a5133d823 Mon Sep 17 00:00:00 2001 From: Ping Cheng pi...@wacom.com Date: Tue, 23 Mar 2010

Re: [Linuxwacom-devel] [PATCH 1/2] xf86-input-wacom: Move BTN_TOOL_TRIPLETAP to the header

2010-03-23 Thread Ping Cheng
Looks like I attached a wrong one last time. Sorry. Ping On Tue, Mar 23, 2010 at 10:11 PM, Ping Cheng pingli...@gmail.com wrote: Move BTN_TOOL_TRIPLETAP definition from wcmUSB.c to xf86WacomDefs.h since it is also used by wcmValidateDevice.c and wcmISDV4.c Signed-off-by: Ping Cheng pi

Re: [Linuxwacom-devel] Reporting speed switching from userspace (wacom bluetooth pen tablet)

2010-03-21 Thread Ping Cheng
Both xsetwacom and the echo string are command line interface. We need a true user-friendly interface, preferably a graphic one like wacomcpl, for Xorg 1.7 and later. Peter has initiated a desktop solution at: https://bugzilla.gnome.org/show_bug.cgi?id=610901. If anyone here is interested in

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-19 Thread Ping Cheng
On Fri, Mar 19, 2010 at 4:26 PM, Chris Bagwell ch...@cnpbagwell.com wrote: No complaints here... Do what ever allows you to keep moving forward with least resistance..  I am lead of other projects so I understand. Thank you for your understand. It was very hard for me to make that decision.

Re: [Linuxwacom-devel] [PATCH] Pressure threshold must be smaller than maxZ, not 21.

2010-03-18 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Peter, I think you copied the ClickForce option code for threshold somehow since ClickForce ranges from 1 to 21. ClickForce was an option for wacomcpl to display the threshold in integer (scroll bar scales

[Linuxwacom-devel] [PATCH 1/2] xf86-input-wacom: Make keys into wcmKeys

2010-03-17 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com Date: Wed, 17 Mar 2010 17:43:53 -0700 Subject: [PATCH 1/2] Make keys into wcmKeys Tool type and other device/tool specific characters can be retrieved through the supported events, defined in keys, from the kernel. Make this variable an attribute of common so we

[Linuxwacom-devel] [PATCH 2/2] xf86-input-wacom: use wcmKeys to check tool type

2010-03-17 Thread Ping Cheng
From: Ping Cheng pi...@wacom.com Date: Wed, 17 Mar 2010 17:50:31 -0700 Subject: [PATCH 2/2] xf86-input-wacom: use wcmKeys to check tool type Since wcmKeys can be accessed from usbWcmGetRanges, we retrieve the supported tool types instead of product ID for touch devices that also report pad data

Re: [Linuxwacom-devel] [PATCH 2/2] xf86-input-wacom: use wcmKeys to check tool type

2010-03-17 Thread Ping Cheng
On Wed, Mar 17, 2010 at 6:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 17, 2010 at 05:58:48PM -0700, Ping Cheng wrote: From: Ping Cheng pi...@wacom.com Date: Wed, 17 Mar 2010 17:50:31 -0700 Subject: [PATCH 2/2] xf86-input-wacom: use wcmKeys to check tool type Since

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Ping Cheng
could start using the DOUBLETAP/TRIPLETAP like they are intended to be used and then these applications using pre-2.6.30 kernels can still detect 2 and 3 finger swipes... Just not exact locations... i.e. align with synaptics. Chris On Wed, Mar 17, 2010 at 3:43 PM, Ping Cheng pingli

[Linuxwacom-devel] [PATCH 1/3] xf86-input-wacom: Make keys into wcmKeys

2010-03-17 Thread Ping Cheng
Tool type and other device/tool specific characters can be retrieved through the supported events, defined in keys, from the kernel. Make this variable an attribute of common so we only need to retrieve it once in wcmPreInit. Signed-off-by: Ping Cheng pi...@wacom.com From

Re: [Linuxwacom-devel] [PATCH 1/3] xf86-input-wacom: Make keys into wcmKeys

2010-03-17 Thread Ping Cheng
Sorry I sent a wrong patch last time. On Wed, Mar 17, 2010 at 10:19 PM, Ping Cheng pingli...@gmail.com wrote: Tool type and other device/tool specific characters can be retrieved through the supported events, defined in keys, from the kernel. Make this variable an attribute of common so we

[Linuxwacom-devel] [PATCH 2/3] xf86-input-wacom: use wcmKeys to check tool type

2010-03-17 Thread Ping Cheng
Since wcmKeys can be accessed from usbWcmGetRanges, we retrieve the supported tool types instead of product ID for touch devices that also report pad data. This change makes the code generic to all touch devices that report pad data. Signed-off-by: Ping Cheng pi...@wacom.com P.S., hope it passes

Re: [Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-10 Thread Ping Cheng
On Wed, Mar 10, 2010 at 6:44 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Mar 9, 2010 at 10:38 PM, Ping Cheng pingli...@gmail.com wrote: I'm not sure if you actively develop older kernels once you branch directories. But if you do, I think a version of my patch can be used even

[Linuxwacom-devel] 0.8.5-11 posted

2010-03-10 Thread Ping Cheng
This dash release: * Added HAL_CFLAGS to CFLAGS - by Pedro Gimeno pg-lwd...@personal.formauri.es * Retrieve tablet_id early on in wcmValidateDevice * Call getRange for both touch and pad, whichever comes the first - by Chris Bagwell ch...@cnpbagwell.com * Fixed a

Re: [Linuxwacom-devel] 0.8.5-11 posted

2010-03-10 Thread Ping Cheng
On Wed, Mar 10, 2010 at 8:39 PM, Chris Bagwell ch...@cnpbagwell.com wrote: I ported my MT patch patch and then did some very basic testing. Seemed good overall. I did notice that on BPT kernel driver, the logic to prevent sending touch events when pen is in proximity got removed. I verified

Re: [Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-09 Thread Ping Cheng
On Tue, Mar 9, 2010 at 6:35 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Mar 8, 2010 at 10:57 PM, Ping Cheng pingli...@gmail.com wrote: Hi Chris, I see your point. But I need to get in touch with kernel input tree maintainer to see what's they think. This may take some time

Re: [Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-09 Thread Ping Cheng
Hi Chris, On Tue, Mar 9, 2010 at 9:40 AM, Chris Bagwell ch...@cnpbagwell.com wrote: My patch is related to Bamboo PenTouch code path... They are very similar though and I offered to develop the same patch for the tablet pc part. If your willing to test and debug then I'll write it up and

Re: [Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-09 Thread Ping Cheng
Ok, here is the decision. -11 will be out tomorrow without this patch. This patch will be in -12 and will be applied to kernels 2.6.30 and later. Hence, a new path src/2.6.30 will be added to linuxwacom for -12. Corresponding _MT_ related wcmUSB.c changes will be incorporated into xdrv then. We

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Ping Cheng
) + common-tablet_id = 0xd0 common-tablet_id = 0xd3) Sorry for coming up with this idea so late. Ping Signed-off-by: Chris Bagwell ch...@cnpbagwell Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 21 - 1

Re: [Linuxwacom-devel] Porting from xdrv to xf86-input-wacom

2010-03-02 Thread Ping Cheng
On Tue, Mar 2, 2010 at 6:45 AM, Chris Bagwell ch...@cnpbagwell.com wrote: At this point I do not think the bamboo branch should ever be directly merged back over to master.  The patches do not align with those you've submitted to linuxwacom anymore and I've been cherrypicking the very

Re: [Linuxwacom-devel] Porting from xdrv to xf86-input-wacom

2010-03-01 Thread Ping Cheng
Hi Chris, Do you feel your bamboo branch is in the position to merge back to the master? If there is not much you can do on that branch, I think you can merge it back. This would make the porting from xdrv to xf86-input-wacom a bit easier for you, I hope. Ping On Tue, Feb 16, 2010 at 6:57 AM,

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-28 Thread Ping Cheng
Hi Chris, I read your commit comments again. It clearly spelled out the rational behind the patch. I am convinced. Sorry for making you explain it again. Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Sat, Feb 27, 2010 at 8:56 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Sat, Feb

Re: [Linuxwacom-devel] [PATCH 1/3] Remove user setting of MaxX/MaxY/MaxZ in xorg.conf.

2010-02-28 Thread Ping Cheng
doing, I think we can safely say there is no current need for user to be able to set/override those Max values reported by hardware... so no need to get the broken logic working. So, reviewed-by: Ping Cheng pingli...@gmail.com. Ping

Re: [Linuxwacom-devel] [PATCH 00/13] misc driver cleanup and purging

2010-02-28 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com for the whole series. Ping On Tue, Feb 23, 2010 at 9:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: A rather large set of patches, mostly just cleaning up and purging a bunch of things that don't apply anymore (and I haven't even gotten

Re: [Linuxwacom-devel] [PATCH v2] Take scroll buttons into accounts when allocating buttons.

2010-02-24 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com Both the attached patch below and the man page patch of this thread look good to me. I know my comment below is outside of the two patches that we are talking about, I'd still like to bring it up one more time so someone may fix the issue in the server

Re: [Linuxwacom-devel] [PATCH 00/12] xf86Wacom.h header file cleanup

2010-02-22 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com Ping On Sun, Feb 21, 2010 at 10:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This set of patchs is just janitor work, moving various functions around to clean up the header file. Most of it should be quite straightforward to understand, so

[Linuxwacom-devel] PATCH] Fix copy/paste error in license header referring to LGP instead of GPL.

2010-02-17 Thread Ping Cheng
From: Ping Cheng pingli...@gmail.com xf86-input-wacom (and linuxwacom) is licensed under the GPL, not the LGPL as the first paragraph of the license blurb states:  * This program is free software; you can redistribute it and/or  * modify it under the terms of the GNU General Public License

Re: [Linuxwacom-devel] New device name format

2010-02-13 Thread Ping Cheng
Thank you Chris. I see your point. Will make a -11 with your suggestion. How's the + idx hack work for you? I tried to localize the fix to Bamboo only. Ping On Sat, Feb 13, 2010 at 10:06 AM, Chris Bagwell ch...@cnpbagwell.com wrote: Ping, I see you've improved upon the device naming patch

Re: [Linuxwacom-devel] New device name format

2010-02-13 Thread Ping Cheng
This is a good way to fix the issue. I don't think Peter has started to clean the tablet_id code. So your patch should be fine. You might want to update the tablet_ids for the ISDV4 devices as well. Here is a list of the existing serial IDs: WACf000 - WACf007 penabled (translated into 0x90)

Re: [Linuxwacom-devel] [RFC][PATCH] Fix for lost x/y/pressure data in two finger case

2010-02-11 Thread Ping Cheng
Hi Chris, Thank you for the patch and your new solution. I like it. However, I would hold your patches (this one and the one for X driver) to the next release (-11) since I really want to get -10 out this week. This way we have more time to work on your solution while the community test

Re: [Linuxwacom-devel] Initial proximity events

2010-02-10 Thread Ping Cheng
On Wed, Feb 10, 2010 at 7:23 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Feb 10, 2010 at 12:33 AM, Ping Cheng pingli...@gmail.com wrote: On Tue, Feb 9, 2010 at 8:05 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Can someone double check following logic issue?  There happens to be two

Re: [Linuxwacom-devel] Initial proximity events

2010-02-08 Thread Ping Cheng
On Mon, Feb 8, 2010 at 9:15 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Feb 8, 2010 at 9:43 PM, Jason Childs obliv...@users.sourceforge.net wrote: I've looked at a lot of kernel data by putting extra buffer print statements in the kernel over the past few months.  I've yet to see the

Re: [Linuxwacom-devel] Status update on Bamboo PT and xf86-input-wacom

2010-02-07 Thread Ping Cheng
On Sat, Feb 6, 2010 at 9:01 PM, Chris Bagwell ch...@cnpbagwell.com wrote: OK, turns out to be simple issue and unique to xf86-input-wacom.  It declares emitKeysym as a static function in wcmCommon.c and provides no prototype for it in wcmTouchFilter.c. Aligning prototypes to linuxwacom and it

Re: [Linuxwacom-devel] [PATCH 0/9] Misc cleanup patches

2010-02-07 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com The whole series. Ping On Sun, Feb 7, 2010 at 7:16 PM, Peter Hutterer peter.hutte...@who-t.net wrote: A bunch of cleanup patches, nothing overly exciting, just things I stumbled across while trying to find a bug. Cheers,  Peter

Re: [Linuxwacom-devel] Initial proximity events

2010-02-07 Thread Ping Cheng
On Sun, Feb 7, 2010 at 5:15 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Hi all, I've a quick question on expected behavior when a finger first comes into proxity for touch pads while in relative mode.  I see that its very common for the first event message to have a non-zero X value but

Re: [Linuxwacom-devel] Status update on Bamboo PT and xf86-input-wacom

2010-02-03 Thread Ping Cheng
On Tue, Feb 2, 2010 at 4:00 PM, Jason Childs obliv...@users.sourceforge.net wrote: Ping, Got a chance to test your 10-linuxwacom.fdi.  Works ok.  Tablet still works with both pen and touch, and the xsetwacom still shows the same list of devices. Thank you. -10 will use this simplified .fdi.

Re: [Linuxwacom-devel] [PATCH 2/2] Rename xf86Wcm* to wcm* - part 3

2010-02-01 Thread Ping Cheng
2010/1/29 Przemysław Firszt prz...@firszt.eu Hi, It's the last part of rename xf86Wcm* to wcm* story. There are a few more remaining, but only in xf86Msg calls: src/wcmCommon.c:xf86Msg(X_ERROR, Wacom xf86WcmWrite error : %s\n, strerror(errno)); src/wcmISDV4.c: xf86Msg(X_WARNING, %s:

Re: [Linuxwacom-devel] howto or documentation to use the wacom-driver in applications

2010-02-01 Thread Ping Cheng
Do you know the product ID of your PenStation2? Which kernel and XOrg version are you using? Ping On Mon, Feb 1, 2010 at 12:27 AM, Rainer Klier rainer.kl...@xyzmo.comwrote: hi list, i am new to programming and using wacom-tablets under linux. i want to use wacom-tablets like the

Re: [Linuxwacom-devel] Status update on Bamboo PT and xf86-input-wacom

2010-01-31 Thread Ping Cheng
On Sun, Jan 31, 2010 at 2:10 AM, Enrico Ros enrico...@email.it wrote: On Sunday 31 January 2010 02:28:21 Chris Bagwell wrote: Hi all, I wanted to let you know the status of Bamboo PT and xf86-input-wacom; especially related to making use of patches that Jason Child has produced. Hello

Re: [Linuxwacom-devel] Bamboo PT patches against 0.8.5-9

2010-01-24 Thread Ping Cheng
On Sun, Jan 24, 2010 at 1:08 PM, Jason Childs obliv...@users.sourceforge.net wrote: On Sat, 2010-01-23 at 20:40 -0800, Ping Cheng wrote: If we go with this serial number approach, tcp2fg will definitely need to be updated.  My concern is if you can receive both pad and 2FGT data in the same

Re: [Linuxwacom-devel] Bamboo PT patches against 0.8.5-9

2010-01-23 Thread Ping Cheng
On Sat, Jan 23, 2010 at 8:56 AM, Jason Childs obliv...@users.sourceforge.net wrote: Hi guys, I'm responding to my original post to try and minimize confusion (hopefully).  Here is a resubmittal of the original 17 patches plus another 6 that get the total for bamboo support to 23. I think

Re: [Linuxwacom-devel] [PATCH] Eradicate hardcoded rotation tables

2010-01-18 Thread Ping Cheng
Tested-by: Ping Cheng pingli...@gmail.com for the whole set. The patchset is fine except 0003-Move-wcmTilt2Rotation has 2 extra trailing whitespaces. There is an issue with the rotation output from xinput test. The output is wrong although the rotation value posted from the driver is correct (I

Re: [Linuxwacom-devel] [PATCH] Eradicate hardcoded rotation tables

2010-01-16 Thread Ping Cheng
2010/1/16 Przemysław Firszt prz...@firszt.eu: Dnia 2010-01-14, czw o godzinie 17:43 -0800, Ping pisze:  Please complete this task as a patchset with the file removal patch included. See attached and check if they are OK. The following lines in the third patch have extra tab-indent: +

<    3   4   5   6   7   8