Author: tfiala
Date: Fri Aug 29 11:19:27 2014
New Revision: 216739
URL: http://llvm.org/viewvc/llvm-project?rev=216739&view=rev
Log:
lldb - ELF: add ARM64 relocation jump slot handling in ELFHeader.
See http://reviews.llvm.org/D4579 for more details.
Change by Paul Osmialowski.
Modified:
ll
Any feedback on this? If not, I'll go ahead and get this in later today.
http://reviews.llvm.org/D5108
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Committed revision 216737.
On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala wrote:
> (And thanks for checking it out!)
>
>
> On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala wrote:
>
>> > Is this necessary in RegisterInfos_arm64.h?
>> > +#include "../../../Utilit
Submitted here, with a minor tweak:
```
svn commit
Sendingsource/Plugins/Process/Linux/NativeThreadLinux.cpp
Sendingsource/Plugins/Process/POSIX/POSIXThread.cpp
Sendingsource/Plugins/Process/Utility/CMakeLists.txt
Sendingsource/Plugins/Process/Utility/RegisterContext
Author: tfiala
Date: Fri Aug 29 11:01:35 2014
New Revision: 216737
URL: http://llvm.org/viewvc/llvm-project?rev=216737&view=rev
Log:
lldb - Register Context Linux ARM64
Yet another step toward ARM64 support. With this commit, lldb-gdbserver started
on ARM64 target can be accessed by lldb running
l
> >
> > http://reviews.llvm.org/D4381
> >
> >
> >
> > _______
> > lldb-commits mailing list
> > lldb-commits@cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
> _
(And thanks for checking it out!)
On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala wrote:
> > Is this necessary in RegisterInfos_arm64.h?
> > +#include "../../../Utility/ARM64_GCC_Registers.h"
> >+#include "../../../Utility/ARM64_DWARF_Registers.h"
>
>
ntext_arm64 just included these as
> "ARM64_GCC_Registers.h" without any directory paths - the cmake/xcode
> configurations must have put the source/Utility directory in the list of
> include directories?
>
> J
>
>
> On Aug 28, 2014, at 7:57 AM, Todd Fiala wrote:
>
>
I'm going to put this in since I haven't heard any feedback on it.
On Tue, Jul 29, 2014 at 10:02 AM, Todd Fiala wrote:
> BTW - I'm using LLDB_DEBUGSERVER_* as the prefix because there are already
> some more-specialized environment variables for similar tasks that sta
Author: tfiala
Date: Thu Aug 28 17:17:54 2014
New Revision: 216690
URL: http://llvm.org/viewvc/llvm-project?rev=216690&view=rev
Log:
Added setting: platform.plugin.linux.use-llgs-for-local (boolean), defaults to
false
This setting is not yet hooked up to anything. In preparation for
adding/test
Author: tfiala
Date: Thu Aug 28 16:21:39 2014
New Revision: 216686
URL: http://llvm.org/viewvc/llvm-project?rev=216686&view=rev
Log:
Ensure the Host wait4 thread is able to show pid in thread name.
For hosts that cannot support long thread names, shrink the host
wait4 thread name so that it does
Small tweak - a flag from another branch snuck in. Harmless for the change but
still not intended to be there.
http://reviews.llvm.org/D5108
Files:
include/lldb/Host/Host.h
include/lldb/Target/Process.h
include/lldb/lldb-private-forward.h
lldb.xcodeproj/project.pbxproj
source/Host/com
Hi emaste,
This change does the following:
* eliminates the Process::GetUnixSignals() virtual method and replaces with a
fixed getter.
* replaces the Process UnixSignals storage with a shared pointer.
* guarantees that Process::GetUnixSignals() can always return a UnixSignals
reference.
* adds a
Author: tfiala
Date: Thu Aug 28 10:46:54 2014
New Revision: 216670
URL: http://llvm.org/viewvc/llvm-project?rev=216670&view=rev
Log:
llgs: add proper exec support for Linux.
This change:
* properly captures execs in NativeProcessLinux.
* clears out all non-main-thread thread metadata in NativePro
Attaching the final diff I'm using over here (needed minor rebasing against
TOT, r216668).
On Thu, Aug 28, 2014 at 7:40 AM, Todd Fiala wrote:
> Hey Greg and Jim,
>
> Can I get somebody on the Apple side to review the Darwin side of this
> change?
>
> http://reviews.
I just tested this patch against lldb/llvm/clang svn r216668.
The only changes needed were to convert Host:: to HostInfo:: in POSIXThread.cpp
and NativeThreadLinux.cpp.
The tests came back clean on x86_64 Ubuntu and MacOSX 10.9.4.
Waiting on Apple review (just sent out email) of header file cha
svn commit
Sendinginclude/lldb/Core/ArchSpec.h
Sendingsource/Core/ArchSpec.cpp
Transmitting file data ..
Committed revision 216668.
http://reviews.llvm.org/D4381
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.ui
Author: tfiala
Date: Thu Aug 28 09:32:43 2014
New Revision: 216668
URL: http://llvm.org/viewvc/llvm-project?rev=216668&view=rev
Log:
lldb - towards AArch64 being recognised as platform architecture
See http://reviews.llvm.org/D4381.
Change by Paul Osmialowski.
Modified:
lldb/trunk/include/l
LGTM.
Tested on Ubuntu 14.04 x86_64,
MacOSX 10.9.4.
http://reviews.llvm.org/D4381
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
y rebasing, I'll post the updated patch here.
(It's from a while back now).
Thanks!
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
No need to rebase this one. Testing it now.
http://reviews.llvm.org/D4381
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
I took.
-Todd
On Wed, Aug 27, 2014 at 10:11 AM, Todd Fiala wrote:
> Author: tfiala
> Date: Wed Aug 27 12:11:56 2014
> New Revision: 216564
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216564&view=rev
> Log:
> NativeThreadLinux: remove translation of some Linux signa
Author: tfiala
Date: Wed Aug 27 17:58:26 2014
New Revision: 216630
URL: http://llvm.org/viewvc/llvm-project?rev=216630&view=rev
Log:
Add some logging around Process attaching and inferior exec handling.
Modified:
lldb/trunk/include/lldb/Target/Process.h
lldb/trunk/source/Target/Process.cp
Hey Paul,
Trying to catch up on the patches that didn't make it in yet. This looks like
one of them. Can you shoot me an email with all the changes that are not in
yet? Can you also add me as reviewers on them (user tfiala) and rebase them
against lldb top of tree? Thanks!
-Todd
http://re
uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Aug 27 14:56:58 2014
New Revision: 216581
URL: http://llvm.org/viewvc/llvm-project?rev=216581&view=rev
Log:
llgs: remove all Initialize() calls except for Debugger::Initialize().
See thread here:
http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140825/012580.
Author: tfiala
Date: Wed Aug 27 12:11:56 2014
New Revision: 216564
URL: http://llvm.org/viewvc/llvm-project?rev=216564&view=rev
Log:
NativeThreadLinux: remove translation of some Linux signals to gdb signals.
I copied this originally based on what debugserver was doing. This appears to
be incorr
svn commit
Sendingsource/Plugins/Process/POSIX/ProcessPOSIX.cpp
Transmitting file data .
Committed revision 216559.
http://reviews.llvm.org/D5078
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/
Author: tfiala
Date: Wed Aug 27 11:32:02 2014
New Revision: 216559
URL: http://llvm.org/viewvc/llvm-project?rev=216559&view=rev
Log:
lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added.
See http://reviews.llvm.org/D5078.
Change by Paul Osmialowski.
Modified:
lldb/trunk/source/Plugin
Tested:
Ubuntu 14.04 x86_64, clang-3.5-built lldb.
http://reviews.llvm.org/D5078
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Testing now, change looks good.
http://reviews.llvm.org/D5078
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
svn commit
Sendingsource/Host/common/HostInfoBase.cpp
Transmitting file data .
Committed revision 216556.
http://reviews.llvm.org/D5070
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi
Author: tfiala
Date: Wed Aug 27 11:21:41 2014
New Revision: 216556
URL: http://llvm.org/viewvc/llvm-project?rev=216556&view=rev
Log:
lldb AArch64 should be listed as yet another 64-bit architecture in
HostInfoBase.
See http://reviews.llvm.org/D5070.
Change by Paul Osmialowski.
Modified:
ll
Tested:
MacOSX 10.9.4, Xcode6-Beta6-built lldb. (only running x86_64 tests).
Ubuntu 14.04 x86_64, clang3.5-built lldb.
http://reviews.llvm.org/D5070
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb
As Greg already called out, LGTM.
Just giving it a test run on MacOSX, then will check in.
http://reviews.llvm.org/D5069
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Testing now. Already reviewed by Greg Clayton.
http://reviews.llvm.org/D5070
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
LGTM.
Tested:
Ubuntu 14.04 x86_64, clang-3.5-built lldb.
http://reviews.llvm.org/D5073
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Looking at this now.
http://reviews.llvm.org/D5073
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
svn commit
Sendingsource/Plugins/Process/Utility/StopInfoMachException.cpp
Transmitting file data .
Committed revision 216554.
http://reviews.llvm.org/D5069
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailma
Author: tfiala
Date: Wed Aug 27 11:12:35 2014
New Revision: 216554
URL: http://llvm.org/viewvc/llvm-project?rev=216554&view=rev
Log:
lldb Missing break statement added.
See http://reviews.llvm.org/D5069.
Change by Paul Osmialowski.
Modified:
lldb/trunk/source/Plugins/Process/Utility/StopInf
Tested:
MacOSX 10.9.4, Xcode6-Beta6-built lldb.
http://reviews.llvm.org/D5069
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Aug 27 11:05:26 2014
New Revision: 216553
URL: http://llvm.org/viewvc/llvm-project?rev=216553&view=rev
Log:
Add Linux support for get thread area on ARM64 using ProcessMonitor debugging.
See http://reviews.llvm.org/D5073.
Change by Paul Osmialowski.
Modified:
lldb/t
svn commit
Sendingsource/Plugins/Process/Linux/ProcessMonitor.cpp
Transmitting file data .
Committed revision 216553.
http://reviews.llvm.org/D5073
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinf
mits mailing list
> > lldb-commits@cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
> ___
> lldb-commits mailing list
> lldb-commits@cs.uiuc.edu
> http://lis
2014 at 11:52 AM, Todd Fiala wrote:
> Ok - but - are we okay with moving PluginManager::Initialize() within
> there? If so, we're good. Because HostInfo::Initialize() needs to come
> *before* PluginManager::Initialize().
>
> Seems reasonable, I just need to peek where we&#
t 11:51 AM, Greg Clayton wrote:
> then HostInfo::Initialize() should go first within Debugger::Initialize()
> and HostInfo::Terminate() should go last in Debugger::Terminate().
>
> > On Aug 26, 2014, at 11:46 AM, Todd Fiala wrote:
> >
> > > But I think Debugger dep
> But I think Debugger depends on HostInfo being initialized first.
Rather I meant:
* PluginManager::Initialize() requires HostInfo to already be initialized.
* Debugger::Initialize() expects PluginManager is already initialized.
On Tue, Aug 26, 2014 at 11:44 AM, Todd Fiala wrote:
>
There might be an issue there.
PluginManager uses the file system initialization. But I think Debugger
depends on HostInfo being initialized first.
I'll look and see if I can detangle that.
On Tue, Aug 26, 2014 at 11:43 AM, Todd Fiala wrote:
> Ah ok. I'll move those in a min
gt; We want there to be single call to initialize everything and terminate
> everything and this is done via the Debugger calls.
>
> > On Aug 21, 2014, at 3:41 PM, Todd Fiala wrote:
> >
> > Author: tfiala
> > Date: Thu Aug 21 17:41:25 2014
> > New Revision:
Author: tfiala
Date: Tue Aug 26 13:21:02 2014
New Revision: 216470
URL: http://llvm.org/viewvc/llvm-project?rev=216470&view=rev
Log:
Fix llgs to send triple for non-Apple platforms and lldb to interpret correctly.
This change addresses this bug:
http://llvm.org/bugs/show_bug.cgi?id=20755
This ch
Author: tfiala
Date: Tue Aug 26 12:19:10 2014
New Revision: 216465
URL: http://llvm.org/viewvc/llvm-project?rev=216465&view=rev
Log:
Refactored existing gdb-remote qProcessInfo tests into separate python file.
I'm about to add some more qProcessInfo tests so I wanted to first pull them out
of the
;
>>> >
>>> > On Mon, Aug 25, 2014 at 2:45 PM, Tong Shen
>>> wrote:
>>> > Of course :-)
>>> > Keeping the old name may cause confusion in the future.
>>> >
>>> > I will test it now and make sure it works.
>>&
Submitted.
svn commit
Sendingsource/Symbol/DWARFCallFrameInfo.cpp
Transmitting file data .
Committed revision 216409.
On Mon, Aug 25, 2014 at 2:46 PM, Todd Fiala wrote:
> Great, will do - thanks Jason!
>
>
> On Mon, Aug 25, 2014 at 2:44 PM, Jason Molenda wrote:
>
Great, will do - thanks Jason!
On Mon, Aug 25, 2014 at 2:44 PM, Jason Molenda wrote:
> Ah sorry I missed that patch.
>
> Yes, this looks correct, please commit.
>
>
> > On Aug 25, 2014, at 1:41 PM, Todd Fiala wrote:
> >
> > Bump!
> >
> >
> >
ng is
> correct.
>
> Thank you.
>
> --
> Best Regards, Tong Shen
>
> ___
> lldb-commits mailing list
> lldb-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
--
Todd Fiala | Software Engineer | tfi...@g
/UnwindAssembly-x86.h
Sendingsource/Symbol/FuncUnwinders.cpp
Sendingsource/Symbol/UnwindPlan.cpp
Transmitting file data ...
Committed revision 216406.
On Mon, Aug 25, 2014 at 1:21 PM, Todd Fiala wrote:
> LGTM. Jason - I'm going to check this in based on your previous
ears
to be unrelated to Tong's change.
On Mon, Aug 25, 2014 at 10:55 AM, Tong Shen wrote:
> Sorry, wrong version of patch...
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-com
Putting Ed on this :-)
http://reviews.llvm.org/D4918
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
see if this instruction will change how we locate CFA
> and make corresponding changes.
> >
> > The code assume there's prologue description.
> > It checks whether there's an FDE for the first instruction; if not,
> augmentation is aborted and we fallback to assembly prof
Ok - holding off on checking this per communication with Tong. Will see a
new patch later today on this.
On Fri, Aug 22, 2014 at 9:49 AM, Todd Fiala wrote:
> Er I'll "get it" in... eek..
>
>
> On Fri, Aug 22, 2014 at 9:49 AM, Todd Fiala wrote:
>
>> I&
gt;> > >>>>>
>> > >>>>> Thanks Jason! That's a very informative post, clarify things a
>> lot :-)
>> > >>>>>
>> > >>>>> Well I have to admit that my patch is specifically for certain
>> ki
Er I'll "get it" in... eek..
On Fri, Aug 22, 2014 at 9:49 AM, Todd Fiala wrote:
> I'm going to test this now. If it all looks good, I'll ge tit in.
>
>
> On Tue, Aug 19, 2014 at 5:01 PM, Tong Shen wrote:
>
>> Thanks Jason!
>> I will finis
Awesome - fixes an issue in my branch as well :-) Thanks, Jason!
On Thu, Aug 21, 2014 at 4:22 PM, Jason Molenda wrote:
> Author: jmolenda
> Date: Thu Aug 21 18:22:33 2014
> New Revision: 216243
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216243&view=rev
> Log:
> Two small fixes to get Mac
Author: tfiala
Date: Thu Aug 21 17:41:25 2014
New Revision: 216238
URL: http://llvm.org/viewvc/llvm-project?rev=216238&view=rev
Log:
Add missing HostInfo::Initialize() in llgs.
This fixes an llgs segfault on startup.
Modified:
lldb/trunk/tools/lldb-gdbserver/lldb-gdbserver.cpp
Modified: lld
.
Submitted here:
svn commit
Sendingsource/Core/Communication.cpp
Transmitting file data .
Committed revision 216194.
On Thu, Aug 21, 2014 at 9:54 AM, Todd Fiala wrote:
> Giving this a final test now.
>
> -Todd
>
>
> On Wed, Aug 20, 2014 at 4:53 PM, Alex Pepper
> wrote
Author: tfiala
Date: Thu Aug 21 12:16:26 2014
New Revision: 216194
URL: http://llvm.org/viewvc/llvm-project?rev=216194&view=rev
Log:
Fix on Linux for ReadThread lingering after inferior exits
See this email thread:
http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140818/012487.html
ror in this way.
>> >
>> > Thanks,
>> >
>> > Alex
>> >
>> ___
>> > lldb-commits mailing list
>> > lldb-commits@cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>>
&g
svn commit
Sendingsource/Plugins/Platform/Linux/PlatformLinux.cpp
Sendingsource/Plugins/Process/Linux/NativeProcessLinux.cpp
Transmitting file data ..
Committed revision 216188.
http://reviews.llvm.org/D4969
___
lldb-commits mailing li
Author: tfiala
Date: Thu Aug 21 11:42:31 2014
New Revision: 216188
URL: http://llvm.org/viewvc/llvm-project?rev=216188&view=rev
Log:
Add software breakpoint support for Linux aarch64.
See http://reviews.llvm.org/D4969 for details.
Change by Paul Osmialowski.
Modified:
lldb/trunk/source/Plug
LGTM.
Tested:
Ubuntu 14.04 x86_64: llvm-3.5-built lldb. All tests passed.
http://reviews.llvm.org/D4969
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Thu Aug 21 11:34:03 2014
New Revision: 216185
URL: http://llvm.org/viewvc/llvm-project?rev=216185&view=rev
Log:
Enable more Linux aarch64 PTRACE support for local and remote debugging.
See http://reviews.llvm.org/D4803 for more details.
Change by Paul Osmialowski.
Modified:
svn commit
Sendingsource/Plugins/Process/Linux/NativeProcessLinux.cpp
Sendingsource/Plugins/Process/Linux/ProcessMonitor.cpp
Transmitting file data ..
Committed revision 216185.
http://reviews.llvm.org/D4803
___
lldb-commits mailing li
LGTM.
Tested:
Ubuntu 14.04 x86_64: clang-3.5-built lldb. All local tests passed.
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Ok - those were the changes I was looking for. Thanks for cleaning up those
other #ifdefs, Paul. Testing now.
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hey Paul - I'll be looking to get your patches in today (I was OOO
yesterday).
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
essLinux.cpp
> source/Plugins/Process/Linux/ProcessMonitor.cpp
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
ne.cpp
>> + AppleObjCClassDescriptorV2.cpp
>> + AppleObjCTypeEncodingParser.cpp
>>)
>>
>>
>> ___
>> lldb-commits mailing list
>> lldb-commits@cs.uiuc.edu
>> http://lists.cs.uiuc.edu
_lldb_library(lldbPluginAppleObjCRunt
>AppleObjCTrampolineHandler.cpp
>AppleObjCTypeVendor.cpp
>AppleThreadPlanStepThroughObjCTrampoline.cpp
> + AppleObjCClassDescriptorV2.cpp
> + AppleObjCTypeEncodingParser.cpp
>)
>
>
> ___
> lldb-commits mail
Ok - marking as accepted and closing out (with understanding this functionality
already went in via another patch).
http://reviews.llvm.org/D4580
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-co
Okay - thanks Paul. Closing out. Listing as accepted with understanding this
already went in (albeit slightly differently).
http://reviews.llvm.org/D4579
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinf
Ok - that sounds good. Would you like to pull those out and put it in this
patch, since they seem to be atomically related?
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo
t;
> http://reviews.llvm.org/D4803
>
>
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Submitted:
tfiala-macpro2:lldb tfiala$ svn commit
Sendinginclude/lldb/Target/Process.h
Sendingsource/Commands/CommandObjectProcess.cpp
Sendingsource/Target/Process.cpp
Transmitting file data ...
Committed revision 215996.
On Tue, Aug 19, 2014 at 10:28 AM, Todd Fiala
Author: tfiala
Date: Tue Aug 19 12:40:43 2014
New Revision: 215996
URL: http://llvm.org/viewvc/llvm-project?rev=215996&view=rev
Log:
Adjust process launch --disable-aslr to take true/false value.
This change modifies the 'process launch' --disable-aslr option to take a
boolean argument. If the
Thanks. I'll get that in and be done with it (wipes hands clean...) ;-)
On Tue, Aug 19, 2014 at 10:27 AM, wrote:
> That looks right to me.
>
> Jim
>
> > On Aug 18, 2014, at 9:07 PM, Todd Fiala wrote:
> >
> > Hey Jim,
> >
> > Does this patch
Minor style nit - parens around sizeof arg to match rest of code.
When you address that, if you wanted to fix the Error idiomatic usage I pointed
out (which is due to me - you're just following my non-idiomatic usage of
Error), feel free to clean that up in those two routines. If not, I'll catc
Same with this - did this go in while I was on vacation?
Looking to close out some reviews that are still listed as open.
http://reviews.llvm.org/D4580
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/l
Hey Paul, did this go in while I was on vacation?
http://reviews.llvm.org/D4579
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Closed by this commit:
svn commit
Sendinglldb.xcodeproj/project.pbxproj
Sendingsource/Plugins/Process/FreeBSD/ProcessMonitor.cpp
Sendingsource/Plugins/Process/FreeBSD/ProcessMonitor.h
Sendingsource/Plugins/Process/Linux/NativeProcessLinux.cpp
Sendingsource/
Look at this now (in isolation from http://reviews.llvm.org/D4803).
http://reviews.llvm.org/D4969
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hey Paul,
I have just a few questions that all boil down to checking if we need a guard
#ifdef around a particular pattern in the code above. (See code-inlined
comments).
Aside from that, LGTM.
Tested:
Ubuntu 14.04 x86_64, clang-3.5-built lldb, all tests passed.
Comment at:
Looking at this now.
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hey Jim,
Does this patch adequately address your comments on the earlier patch?
Thanks!
-Todd
On Mon, Aug 18, 2014 at 4:14 PM, Todd Fiala wrote:
> Adjust process launch --disable-aslr to take true/false value.
>
> This change modifies the 'process launch' --disable-as
R disabled accordingly. In the event that the setting is not
explicitly made on the process launch command line, then the value is
retrieved from the target.disable-aslr setting (i.e. settings show
target.disable-aslr).
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
Index: in
Great, thanks!
On Mon, Aug 18, 2014 at 3:22 PM, wrote:
>
> > On Aug 18, 2014, at 3:18 PM, Todd Fiala wrote:
> >
> > On Mon, Aug 18, 2014 at 2:47 PM, wrote:
> >
> > > On Aug 18, 2014, at 12:45 PM, Todd Fiala wrote:
> > >
> > > On Mon,
On Mon, Aug 18, 2014 at 2:47 PM, wrote:
>
> > On Aug 18, 2014, at 12:45 PM, Todd Fiala wrote:
> >
> > On Mon, Aug 18, 2014 at 11:22 AM, wrote:
> > I don't think we have any other instances where we use two flags to
> express "do x" and "don
the tooth - `process
launch --disable-aslr false` when you want ASLR.)
Thoughts on that? I'll code up whatever we decide on.
If backward compat for option (1) is a concern, we could continue to
accept `settings set disable-aslr ` and just have it do the
right thing.
-Todd
> Jim
>
Thanks Paul. I'll have a look today.
http://reviews.llvm.org/D4803
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
urce/Plugins/Process/Linux/ProcessMonitor.cpp
>
> ___
> lldb-commits mailing list
> lldb-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
_
> Thanks Todd - I'm playing around with the Xcode build now and just noticed
> this today.
My pleasure, Ed!
http://reviews.llvm.org/D4941
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
201 - 300 of 543 matches
Mail list logo
