[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Utility/XcodeSDK.cpp:72 + llvm::VersionTuple version = ParseSDKVersion(input); + return {sdk, version}; +} sylvestre.ledru wrote: > With older version of the

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

sylvestre.ledru added inline comments. Comment at: lldb/source/Utility/XcodeSDK.cpp:72 + llvm::VersionTuple version = ParseSDKVersion(input); + return {sdk, version}; +} With older version of the libcstdc++ (some Ubuntu LTS), it fails with: ``` error: chosen

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e05d7b3d3c6: Remap the target (Xcode) SDK directory to the host SDK directory. (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, I think we've done what we can here. In D76471#1958814 , @aprantl wrote: > > Yeah, it seems acceptable. The "sdk type" argument still seems

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. > Yeah, it seems acceptable. The "sdk type" argument still seems somewhat > redundant. Theoretically we could pass in just the triple component out the > xcodesdk object, but that would just mean the individual platforms would have > to reconstruct the XcodeSDK object,

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254696. aprantl marked 7 inline comments as done. aprantl added a comment. Renamed SDK -> XcodeSDK where applicable. Sorry I missed this earlier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Ok, I think we have converged onto something here. I just think it would be good to rename some functions/variables to make it clear they are working with an xcode sdk, and not some generic entity. In D76471#1955908 , @aprantl

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. In D76471#1954205 , @labath wrote: > I don't think that spreading this out over host and platform is convoluted. > In fact, I was going to propose something like that myself. However, it does > bring us back to the question of

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254326. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Host/HostInfoBase.h lldb/include/lldb/Host/macosx/HostInfoMacOSX.h

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. I don't think that spreading this out over host and platform is convoluted. In fact, I was going to propose something like that myself. However, it does bring us back to the question of the "linux" sdk. A couple of comments ago you said: > The "Linux" SDK is a

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

JDevlieghere added a comment. I think the current separation makes a lot of sense, but I don't like that `XcodeSDK` class is part of Utility. I understand the need from a layering perspective and I don't really have a better idea, but maybe someone else does? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254071. aprantl added a comment. I just had an off-list conversation with @jingham were we discussed what should be Platform versus Host in detail. The resulting solution looks even more convoluted at first, but it actually solves a bunch of problems that I

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Having this in the host layer sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. > In case of Apple platforms, this won't make a difference in practice, since > the support for that is implemented in PlatformDarwin (which all of these > inherit from), but it sounds like this will be a problem for the "linux" sdk > (assuming this is what I think it

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. In D76471#1947250 , @aprantl wrote: > I've reworked this a little based on your feedback. > > First, I've renamed `SDK` to `XcodeSDK`. An Xcode SDK is a fairly specific > concept and I'm not going to pretend that it makes sense to

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 253257. aprantl added a comment. Herald added a subscriber: mgorny. I've reworked this a little based on your feedback. First, I've renamed `SDK` to `XcodeSDK`. An Xcode SDK is a fairly specific concept and I'm not going to pretend that it makes sense to

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Thanks for the explanation. I have some ideas on this below, though I am not sure if I know enough about the problem to be able to tell which ones are feasible. In D76471#1933923 , @aprantl wrote: > Thanks, Pavel, these are all

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. Thanks, Pavel, these are all very valid concerns and in retrospect I should have at least slapped an RFC label on this before dumping into phabricator last night. The goal of this (and I should have mentioned that in the description) is to make the Xcode SDK something

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

shafik added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1318 + +static llvm::VersionTuple ParseSDKVersion(llvm::StringRef ) { + unsigned i = 0; We should document what we expect the format to be. I mean I can deduce it

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I think this needs a lot more discussion. First, there's some weird layering going on here, where the class SDK is declared in lldb/Utility, but it's implemented in PlatformDarwin.

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 251526. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Target/Platform.h lldb/include/lldb/Utility/SDK.h lldb/source/Core/Module.cpp

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl created this revision. aprantl added reviewers: JDevlieghere, jingham, friss. aprantl updated this revision to Diff 251526. This is mostly useful for Swift support; it allows LLDB to substitute a matching SDK it shipped with instead of the sysroot path that was used at compile time.