[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, thanks for the test. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:30 +self.expect("platform

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:257-259 +template <> struct serializer_tag { + typedef NotImplementedTag type; +}; This still doesn't seem right to me. Though you have removed the direct

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk closed this revision. kwk added a comment. Closed by 2c082b48274fcba62bf9b3acb63075aedcc7a976 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

jhenderson added a comment. Can't comment too much on the file format details, but I've made some more general comments. FYI, I'll be away from end of day Wednesday for 2 and a half weeks, so won't be able to further review after that point until I'm back. Comment at:

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath added a comment. (Ideally, all of these tests would be just (gtest) unit tests. There's no need to pull in python to do something our build system already knows perfectly well to do.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

labath added subscribers: jankratochvil, kwk. labath added a comment. I don't know much about this stuff, but it seems relatively reasonable to me. Tagging @kwk and @jankratochvil because they were involved in some elf symbol merging discussions recently, and so they may find this interesting.

[Lldb-commits] [lldb] r373891 - [lldb][ELF] Read symbols from .gnu_debugdata sect.

Author: kwk Date: Mon Oct 7 03:32:16 2019 New Revision: 373891 URL: http://llvm.org/viewvc/llvm-project?rev=373891=rev Log: [lldb][ELF] Read symbols from .gnu_debugdata sect. Summary: If the .symtab section is stripped from the binary it might be that there's a .gnu_debugdata section which

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223482. kwk added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added a subscriber: jasonmolenda. labath added a comment. The encoding scheme looks fine to me. There's just two more additional things that came to mind: - r373789 by @jasonmolenda reminded me that we have a document for describing the gdb-remote protocol extensions. It would be good

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

labath added a reviewer: jingham. labath added a comment. Adding Jim for the API design aspects. Two things come to mind here: - It's unfortunate that we have to add the FileSP overload (and the associated cruft) to every API that used to take a FILE*. I take it that is needed to get rid of

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

labath added a comment. (Also, the documentation for the `-f` option should be updated to reflect the new functionality.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68545/new/ https://reviews.llvm.org/D68545

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

labath added a comment. Sounds reasonable to me. The existing filtering method was indeed quite tricky to use. Does anyone else have any opinions on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68545/new/ https://reviews.llvm.org/D68545

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. This looks fine to me. I'll leave it up to you to figure out the best way to compute the relative python path... Comment at: lldb/CMakeLists.txt:42

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

labath added inline comments. Comment at: lldb/lit/SymbolFile/Breakpad/symtab.test:20 # CHECK: Address: symtab.out[0x004000c0] (symtab.out.PT_LOAD[0]..text2 + 16) -# CHECK: Symbol: id = {0x}, range = [0x004000c0-0x004000d0), name="f2" +# CHECK:

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG182b4652e542: [StringRef] Add enable-if to StringLiteral. (authored by zturner). Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Changed prior to commit:

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath added a comment. Thanks for the review. I am fairly confident in the minidump details, as I based this code on the existing functional implementation in lldb, which I have also cross-referenced with the publicly available microsoft documentation. @amccarth, @clayborg: do you want to

[Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc9db524492: Track expression language from one place in ClangExpressionParser (authored by EwanCrawford). Herald added

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:84 + lzma_ret xzerr = lzma_stream_footer_decode( + , InputBuffer.data() + InputBuffer.size() - LZMA_STREAM_HEADER_SIZE); + if (xzerr != LZMA_OK) { kwk wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D13617: Fix ref-counting of Python objects

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8b22f8fea18: Fix ref counting of Python objects. (authored by zturner). Herald added a project: LLDB. Changed prior

[Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c03462f52a: Some fixes for case insensitive paths on Windows. (authored by zturner). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D17492?vs=48871=223585#toc

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath updated this revision to Diff 223616. labath marked 6 inline comments as done. labath added a comment. Address review comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68210/new/ https://reviews.llvm.org/D68210 Files:

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

sammccall added a comment. Mostly LG, just a couple of possible logic bugs. Apologies, I was out on vacation and hoped someone else would see this. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:650 + bool Fallthrough() const { return ExternalFSValidWD &&

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

labath added a comment. I like the direction this is going in. Some questions about the implementation/interface inline.. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:44-45 +using llvm::Error; +using llvm::Expected; + Please

[Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG30ff4b485147: Fix lldb build on Mac. (authored by labath). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

mgorny accepted this revision. mgorny added a comment. Cool work. I presume you've tested it. I can test it tomorrow if you need me to. However, I can do that after the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3695 + bool debug_only) { + const bool is_debug = ((nlist.n_type & N_STAB) != 0); + if (is_debug != debug_only)

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

JDevlieghere updated this revision to Diff 223688. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Code review feedback Adrian. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68536/new/ https://reviews.llvm.org/D68536 Files:

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3736 if (is_debug) { switch (nlist.n_type) { aprantl wrote: > because of the early exit above — isn't this either always true or always >

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

friss updated this revision to Diff 223683. friss added a comment. Addressed review feedback. Completely removed the clean code for the Makefiles and reworked it in Makefile.rules to be much simpler and catch-all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r373954 - [MachO] Shuffle some things around in ParseSymtab (NFC)

Author: jdevlieghere Date: Mon Oct 7 13:31:22 2019 New Revision: 373954 URL: http://llvm.org/viewvc/llvm-project?rev=373954=rev Log: [MachO] Shuffle some things around in ParseSymtab (NFC) Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified:

[Lldb-commits] [lldb] r373968 - Mark constructor as default and remove implementation (NFC)

Author: adrian Date: Mon Oct 7 14:23:19 2019 New Revision: 373968 URL: http://llvm.org/viewvc/llvm-project?rev=373968=rev Log: Mark constructor as default and remove implementation (NFC) Modified: lldb/trunk/include/lldb/Core/Mangled.h lldb/trunk/source/Core/Mangled.cpp Modified:

[Lldb-commits] [PATCH] D68595: Remove constructor and unused function (NFC)

aprantl created this revision. aprantl added a reviewer: JDevlieghere. https://reviews.llvm.org/D68595 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:771 else - $(RM) "$(EXE)" + $(RM) -r $(wildcard $(BUILDDIR)/*) endif I would just error, period. IMHO `make clean` shouldn'd delete anything that

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

shafik added a comment. @wallace it looks like `TestPlatformClient.py` is failing on osx see green dragon log here: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2317/testReport/junit/lldb-Suite/functionalities_gdb_remote_client/TestPlatformClient_py/

[Lldb-commits] [lldb] r373970 - [CMake] We only want to copy the headers for macOS.

Author: davide Date: Mon Oct 7 14:38:30 2019 New Revision: 373970 URL: http://llvm.org/viewvc/llvm-project?rev=373970=rev Log: [CMake] We only want to copy the headers for macOS. Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake

[Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

aprantl created this revision. aprantl added a reviewer: JDevlieghere. I just don't think that we are saving anything by making these StringRefs global variables. The strings they reference are constants anyway. https://reviews.llvm.org/D68597 Files:

[Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

aprantl updated this revision to Diff 223664. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68597/new/ https://reviews.llvm.org/D68597 Files: lldb/source/Interpreter/OptionValueBoolean.cpp lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace added a comment. damn, i'll rebase and try to fix it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3736 if (is_debug) { switch (nlist.n_type) { because of the early exit above — isn't this either always true or always false?

[Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the `g_` prefixes removed. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4199 if

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

jingham added a comment. SBProcess::ReportEventState was introduced in r112221, and SBStream was added in r114188, so Pavel's speculation seems like a reasonable one, though that was 9 years ago... But in the SB API's we use SBStream in a bunch of places to be more like an SBString, something

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

lawrence_danna updated this revision to Diff 223686. lawrence_danna added a comment. updated help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68545/new/ https://reviews.llvm.org/D68545 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, labath. This makes parsing the symbol table of clang ~10ms faster. (Hashtable versus tree). https://reviews.llvm.org/D68605 Files: lldb/include/lldb/Utility/ConstString.h

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223638. hhb marked an inline comment as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked 3 inline comments as done and an inline comment as not done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False,

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb added a comment. In D68442#1698053 , @mgorny wrote: > Cool work. I presume you've tested it. I can test it tomorrow if you need me > to. However, I can do that after the commit. I'm doing a final round of testing on linux/darwin/windows(mingw).

[Lldb-commits] [lldb] r373957 - [debugserver] Include the correct header.

Author: davide Date: Mon Oct 7 13:35:22 2019 New Revision: 373957 URL: http://llvm.org/viewvc/llvm-project?rev=373957=rev Log: [debugserver] Include the correct header. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachVMMemory.cpp Modified:

Re: [Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

Pavel, It looks like this change breaks a couple of tests: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2315/ Reverting it fixes those on my end. -Shafik > On Oct 7, 2019, at 10:17 AM, Pavel Labath via lldb-commits

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223689. hhb added a comment. Converts python output path to cmake format. This looks like a bug on windows exists before this change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere updated this revision to Diff 223639. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 Files: llvm/include/llvm/Support/VirtualFileSystem.h llvm/lib/Support/VirtualFileSystem.cpp llvm/unittests/Support/VirtualFileSystemTest.cpp

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

JDevlieghere updated this revision to Diff 223641. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address code review feedback. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68536/new/ https://reviews.llvm.org/D68536 Files:

[Lldb-commits] [lldb] r373953 - [gdb-remote] process properly effective uid

Author: wallace Date: Mon Oct 7 13:26:49 2019 New Revision: 373953 URL: http://llvm.org/viewvc/llvm-project?rev=373953=rev Log: [gdb-remote] process properly effective uid Summary: Someone wrote SetEffectiveSetEffectiveGroupID instead of SetEffectiveUserID. After this fix, the android process

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

JDevlieghere added a comment. Would it be possible to add a test for this? Maybe you can extend `TestGuiBasic.py`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 ___

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

JDevlieghere added a comment. In D68558#1698031 , @friss wrote: > Pretty sure the test runs don't need the clean rule, but it's nice to have > when manually iterating over the build phase of a test. OTOH, manually doing > a "rm -rf" of the build

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:280 + template + Expected CallMethod(const char *name, const char *format, +Args... args) { labath wrote: >

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223690. lawrence_danna marked 13 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files:

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

friss marked an inline comment as done. friss added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:771 else - $(RM) "$(EXE)" + $(RM) -r $(wildcard $(BUILDDIR)/*) endif aprantl wrote: > I would just error,

[Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

Author: labath Date: Mon Oct 7 10:17:53 2019 New Revision: 373925 URL: http://llvm.org/viewvc/llvm-project?rev=373925=rev Log: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested Since D68289, a couple of tests on linux started being extremely flaky. All

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

labath added a comment. In D68289#1696654 , @jankratochvil wrote: > It has regressed on Linux Fedora 30 x86_64: > > lldb-Suite :: commands/process/attach/TestProcessAttach.py > lldb-Suite :: tools/lldb-vscode/attach/TestVSCode_attach.py > > >

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:30 +self.expect("platform process list -x", +startstr="1 matching

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked 3 inline comments as done. labath added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, +

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. Thank you for looking into this, @labath I'd like to fix that, but I'm not sure if I understand the code well enough/ it's not clear to me what the solution would look like. > I think the only reasonable way to do that would be to change the > RegisterInfo offset

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

friss added a comment. In D68558#1697890 , @labath wrote: > I like the idea of passing the variable values "inline". The MAKECMDGOALS > thingy seems... clever. I sort of like it, and it also feels like it might be > too much. This is why I didn't

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

aprantl added a comment. This is some really tricky Make (wow), but I think the benefit of it being so much shorter and localized outweighs the steeper learning curve. Thanks! Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/top-level/Makefile:9 +

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

jingham added a comment. This is great, and will make the -f option much easier to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68545/new/ https://reviews.llvm.org/D68545 ___ lldb-commits

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

labath added a comment. I like the idea of passing the variable values "inline". The MAKECMDGOALS thingy seems... clever. I sort of like it, and it also feels like it might be too much. I suppose that is fine, but.. do we actually need a functional clean rule? I was under the impression that

[Lldb-commits] [lldb] r373927 - [DWARFASTParserClang] Factor out structure-like type parsing, NFC

Author: vedantk Date: Mon Oct 7 10:22:53 2019 New Revision: 373927 URL: http://llvm.org/viewvc/llvm-project?rev=373927=rev Log: [DWARFASTParserClang] Factor out structure-like type parsing, NFC Split out the logic to parse structure-like types into a separate function, in an attempt to reduce

[Lldb-commits] [lldb] r373926 - [DWARFASTParserClang] Delete commented-out typedef, NFC

Author: vedantk Date: Mon Oct 7 10:22:50 2019 New Revision: 373926 URL: http://llvm.org/viewvc/llvm-project?rev=373926=rev Log: [DWARFASTParserClang] Delete commented-out typedef, NFC (& group together all the protected members & typedefs) Modified:

[Lldb-commits] [lldb] r373931 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Mon Oct 7 10:49:32 2019 New Revision: 373931 URL: http://llvm.org/viewvc/llvm-project?rev=373931=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

teemperor added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9195 + GetAsEnumDecl(type->GetFullCompilerType())) + enum_decl->dump(s.AsRawOstream()); +else { shafik wrote: > aprantl wrote: > > is an EnumDecl not a

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. In D67994#1695172 , @shafik wrote: > In D67994#1692645 , @labath wrote: > > > Maybe this is my fault since I'm the one who introduced the first bunch of > > arguments here IIRC, but anyway,

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBCommandReturnObject.cpp:296 + (FileSP), file_sp); + return SetImmediateOutputFile(SBFile(file_sp)); +}

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

JDevlieghere added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68558/new/ https://reviews.llvm.org/D68558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68609: Replace regex match with rfind (NFCish)

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss. This change is mostly performance-neutral since our regex engine is fast, but it's IMHO slightly more readable. Also, matching matching parenthesis is not a great match for regular expressions.

[Lldb-commits] [lldb] r373997 - DWIMy filterspecs for dotest.py

Author: lawrence_danna Date: Mon Oct 7 17:26:53 2019 New Revision: 373997 URL: http://llvm.org/viewvc/llvm-project?rev=373997=rev Log: DWIMy filterspecs for dotest.py Summary: dotest.py currently requires a filterspec to be of the form `TestCase.test_method`. This patch makes it more

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb closed this revision. hhb added a comment. This is merged as 61f471a and 0016b45 . Closing... Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] r374000 - [CMake] Add two more uses of add_lldb_test_dependency

Author: jdevlieghere Date: Mon Oct 7 17:44:54 2019 New Revision: 374000 URL: http://llvm.org/viewvc/llvm-project?rev=374000=rev Log: [CMake] Add two more uses of add_lldb_test_dependency Modified: lldb/trunk/CMakeLists.txt lldb/trunk/lit/CMakeLists.txt lldb/trunk/test/CMakeLists.txt

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

dblaikie added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, + LookupPooledAddress) + .begin();

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL373927: [DWARFASTParserClang] Factor out structure-like type parsing, NFC (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D68618: test fix: TestLoadUsingPaths should use realpath

This revision was automatically updated to reflect the committed changes. Closed by commit rL374007: test fix: TestLoadUsingPaths should use realpath (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223693. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. use is_trivially_copyable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/

[Lldb-commits] [lldb] r373990 - [Symbol] Remove unused method ClangASTContext::GetObjCClassName

Author: xiaobai Date: Mon Oct 7 16:43:33 2019 New Revision: 373990 URL: http://llvm.org/viewvc/llvm-project?rev=373990=rev Log: [Symbol] Remove unused method ClangASTContext::GetObjCClassName Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223699. lawrence_danna marked 5 inline comments as done. lawrence_danna added a comment. get rid of dummy registrations in SBFile.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna added inline comments. Comment at: lldb/source/API/SBFile.cpp:115 + + R.Register(, "", "SBFile", "SBFile", "()"); + R.Register(, "", "SBFile", "SBFile", labath wrote: > I don't think these are right because there nothing here to connect the

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

friss marked 3 inline comments as done. friss added a comment. In D67520#1668494 , @jingham wrote: > (lldb) expr (enum bitfield) whatever > > Be nice to see a test of that to make sure that works through the expression > parser as well. This works now

[Lldb-commits] [PATCH] D68613: [CMake] Fix building without python on Windows

xiaobai created this revision. xiaobai added reviewers: stella.stamenova, JDevlieghere, labath, mgorny. Herald added a project: LLDB. find_python_libs_windows might set LLDB_DISABLE_PYTHON to ON. Unfortunately we do not re-check this variable before using variables filled in by

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm updated this revision to Diff 223707. aadsm added a comment. Don't destroy the Breakpad test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 Files:

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

xiaobai added a reviewer: JDevlieghere. xiaobai added a comment. @JDevlieghere has been touching similar things today. You should coordinate with him on this change. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1697302 , @labath wrote: > Adding Jim for the API design aspects. > > It's unfortunate that we have to add the FileSP overload (and the associated > cruft) to every API that used to take a FILE*. I take it that

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223701. hhb added a comment. Reverts the change related to python dir for windows. FileSpec should always contain normalized path. I.e. using '/' even in windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r373995 - [CMake] Remove stale comment

Author: jdevlieghere Date: Mon Oct 7 17:14:02 2019 New Revision: 373995 URL: http://llvm.org/viewvc/llvm-project?rev=373995=rev Log: [CMake] Remove stale comment Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL:

[Lldb-commits] [lldb] r373994 - [MachO] Fix symbol merging during symtab parsing.

Author: jdevlieghere Date: Mon Oct 7 17:13:59 2019 New Revision: 373994 URL: http://llvm.org/viewvc/llvm-project?rev=373994=rev Log: [MachO] Fix symbol merging during symtab parsing. The symtab parser in ObjectFileMachO has logic to coalesce debug (STAB) and non-debug symbols, based on the

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

JDevlieghere created this revision. JDevlieghere added reviewers: xiaobai, labath, mgorny, vsk. Herald added a subscriber: teemperor. Herald added a project: LLDB. I often use `ninja lldb-test-deps` to build all the test dependencies before running a subset of the tests with `lit --filter`. This

[Lldb-commits] [lldb] r374008 - Revert "ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested"

Author: jdevlieghere Date: Mon Oct 7 18:16:59 2019 New Revision: 374008 URL: http://llvm.org/viewvc/llvm-project?rev=374008=rev Log: Revert "ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested" This breaks TestProcessAttach and TestHelloWorld on Darwin.

[Lldb-commits] [lldb] r374007 - test fix: TestLoadUsingPaths should use realpath

Author: lawrence_danna Date: Mon Oct 7 18:16:29 2019 New Revision: 374007 URL: http://llvm.org/viewvc/llvm-project?rev=374007=rev Log: test fix: TestLoadUsingPaths should use realpath Summary: TestLoadUsingPaths will fail if the build directory has symlinks in its path, because the real paths

Re: [Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

Hey Pavel, I've reverted your change in r374008. This was breaking TestProcessAttach and TestHelloWorld on Darwin. -- Jonas On Mon, Oct 7, 2019 at 1:57 PM Shafik Yaghmour via lldb-commits wrote: > > Pavel, > > It looks like this change breaks a couple of tests: > >

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:257-259 +template <> struct serializer_tag { + typedef NotImplementedTag type; +}; labath wrote: > This

[Lldb-commits] [lldb] r373996 - [CMake] Track test dependencies with add_lldb_test_dependency

Author: jdevlieghere Date: Mon Oct 7 17:21:34 2019 New Revision: 373996 URL: http://llvm.org/viewvc/llvm-project?rev=373996=rev Log: [CMake] Track test dependencies with add_lldb_test_dependency I often use `ninja lldb-test-deps` to build all the test dependencies before running a subset of the

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

JDevlieghere added a comment. In D68612#1698614 , @xiaobai wrote: > Looks good to me. I find it interesting that we had an lldb-test-deps custom > target before but most things were depending on `${LLDB_TEST_DEPS}` anyway. Yep. IIRC the main motivation

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. Personally, I think `%extend` is a bit ugly as it increases the difference between what's in the headers and what's actually in the python bindings, so I'd rather not do it that way.But I'm not dogmatically opposed to it. Repository: rG LLVM Github

  1   2   >