[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

friss added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:52 +#include "Plugins/TypeSystem/Clang/TypeSystemClang.h" + You don't want to introduce a dependency between Core and a plugin. What you need here might need to be introduced as a new

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin added a comment. Jim, do you think this is good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

omjavaid added a subscriber: clayborg. omjavaid added a comment. In D75607#2020365 , @labath wrote: > Thanks for trying this out. Do you by any chance have any ideas why would > lldb assign a dwarf number to the pc register when neither llvm nor the

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added a comment. Thanks a lot for this! > Nevertheless, I am still interested in making assembly-based tests for this > (and similar features) because it enables testing scenarios that we could not > get (reliably or at all) a compiler to produce. I also think this would be more

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath added a comment. Thanks for the patch. In D79559#2024573 , @Geod24 wrote: > I wasn't sure what would be the best place / how to add an unit test for > this. Could a reviewer provide some pointers ? I think the simplest approach would be to

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

labath added a reviewer: teemperor. labath added a comment. The ValueObject change looks very worrying to me. The ability to pretty-print incomplete types seems pretty useful, but the implementation of that looks a bit... scary. I mean you're not even checking whether the incomplete type is a

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. I wasn't sure what would be the best place / how to add an unit test for this. Could a reviewer provide some pointers ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 created this revision. Geod24 added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Geod24 added a comment. I wasn't sure what would be the best place / how to add an unit test for this. Could a reviewer provide some pointers ? The D

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked 6 inline comments as done. labath added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:21-22 + ++global; //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=FUNC1-DESC") //

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath updated this revision to Diff 262595. labath marked an inline comment as done. labath added a comment. - make the test architecture-independent (and rename accordingly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79491/new/

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py:5 + +supported_archs = ["x86_64", "arm", "aarch64"] + djtodoro wrote: > I haven't

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath created this revision. labath added reviewers: vsk, JDevlieghere. Herald added a project: LLDB. The test machinery translates each continuous block of "//%" comments into a single breakpoint. If there's no code between the blocks the breakpoints will end up at the same location in the

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added inline comments. Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py:5 + +supported_archs = ["x86_64", "arm", "aarch64"] + I haven't refreshed the page before submitting my previous comment. WDYT

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Will this also fix these problems? int i = 0; //% code_that_is_executed //% that that isn't executed as it's behind an empty line :( I think disabling the check is fine. You

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

djtodoro added a comment. In D79491#2024771 , @labath wrote: > In D79491#2024647 , @djtodoro wrote: > > > Thanks a lot for this! > > > > > Nevertheless, I am still interested in making assembly-based tests for > >

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor added a comment. Changing might actually be a better idea as this way we at least know this isn't crashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added a comment. In D79491#2024647 , @djtodoro wrote: > Thanks a lot for this! > > > Nevertheless, I am still interested in making assembly-based tests for this > > (and similar features) because it enables

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath added a reviewer: teemperor. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/commands/expression/dollar-in-variable/main.c:20 //%self.expect("expr int $foo = 123", error=True, substrs=["declaration conflicts"]) -

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath updated this revision to Diff 262614. labath added a comment. - disable a check that fails now. AFAICT, this never worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 Files:

[Lldb-commits] [lldb] 34a57dc - [lldb/Reproducers] Make DoConnectRemote connect to the replay server.

Author: Jonas Devlieghere Date: 2020-05-07T10:09:09-07:00 New Revision: 34a57dc972c2d16f176e47339a7c2c95cdc31e75 URL: https://github.com/llvm/llvm-project/commit/34a57dc972c2d16f176e47339a7c2c95cdc31e75 DIFF:

[Lldb-commits] [lldb] a14f4a7 - tab completion for register read/write

Author: Gongyu Deng Date: 2020-05-07T18:14:27+02:00 New Revision: a14f4a7531f083a4820b5452808a1d003f1e88cc URL: https://github.com/llvm/llvm-project/commit/a14f4a7531f083a4820b5452808a1d003f1e88cc DIFF: https://github.com/llvm/llvm-project/commit/a14f4a7531f083a4820b5452808a1d003f1e88cc.diff

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/XcodeSDK.h:70 llvm::StringRef GetString() const; + bool SupportsModules() const; + /// Whether this Xcode SDK supports Swift. Not implemented? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

vsk added a comment. Thanks! LGTM, modulo any comments Raphael may have about the test change. Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:155 process, lldb.eStopReasonBreakpoint) -breakpoint_id =

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, thanks. It'd be nice to have a skipUnlessEntryValuesSupportedArch decorator, but I don't think that has to be folded into this change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor added a comment. I don't really know that ValueObject code, but I wish we could just pretend that the dereferenced type of X is a type named Y or something like that and then just map *Ref classes to their non-opaque bridged types when dereferenced. No idea if that's possible though.

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

shafik added a comment. Thank you! I am pleasantly surprised there was only one hidden broken test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 ___

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:665 bool child_is_deref_of_parent = false; + CompilerType compiler_type = GetCompilerType(); uint64_t language_flags = 0; teemperor wrote: > This

[Lldb-commits] [PATCH] D79490: tab completion for register read/write

This revision was automatically updated to reflect the committed changes. Closed by commit rGa14f4a7531f0: tab completion for register read/write (authored by Gongyu Deng gy_d...@icloud.com, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

emrekultursay created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. On Android, this method gets called twice: first when establishing a host-server connection, then when attaching to a process id. Each call takes several seconds to finish

[Lldb-commits] [lldb] d7c2c2e - [lldb][NFC] Also initialize language_flags in ValueObject::Dereference

Author: Raphael Isemann Date: 2020-05-07T17:52:12+02:00 New Revision: d7c2c2ed79abd5446f8b485fe8249e1d3b78488d URL: https://github.com/llvm/llvm-project/commit/d7c2c2ed79abd5446f8b485fe8249e1d3b78488d DIFF:

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

shafik added a comment. I have to agree w/ Pavel here that I am not crazy about creating creating an empty struct here, it is not clear why there is no other way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79554/new/

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

aprantl updated this revision to Diff 262699. aprantl marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79535/new/ https://reviews.llvm.org/D79535 Files: lldb/include/lldb/Utility/XcodeSDK.h lldb/source/Utility/XcodeSDK.cpp

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Nice test! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79535/new/ https://reviews.llvm.org/D79535 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/XcodeSDK.h:70 llvm::StringRef GetString() const; + bool SupportsModules() const; + /// Whether this Xcode SDK supports Swift. JDevlieghere wrote: > Not implemented? I had another commit

[Lldb-commits] [PATCH] D79538: Add an XcodeSDK::GetSDKTypeForTriple function

vsk accepted this revision. vsk added a comment. lgtm as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79538/new/ https://reviews.llvm.org/D79538 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79538: Add an XcodeSDK::GetSDKTypeForTriple function

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e95d51ecfab: Add an XcodeSDK::GetSDKTypeForTriple function (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79538?vs=262519=262706#toc

[Lldb-commits] [PATCH] D79535: Add a function to detect whether an Xcode SDK supports Swift

This revision was automatically updated to reflect the committed changes. Closed by commit rGdec1c94e801f: Add a function to detect whether an Xcode SDK supports Swift (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

aprantl created this revision. aprantl added reviewers: JDevlieghere, vsk. Unfortunately I discovered that I do need to be able to go full round-trip in swift-lldb. Also, this moves numSDKs out of the actual enum, as to not mess with the switch-cases-covered warning.

[Lldb-commits] [lldb] 13062d0 - [lldb/Test] Skip more tests that are not expected to work with passive replay

Author: Jonas Devlieghere Date: 2020-05-07T15:16:52-07:00 New Revision: 13062d0fb76913802f94314090b1a2b36bd480d9 URL: https://github.com/llvm/llvm-project/commit/13062d0fb76913802f94314090b1a2b36bd480d9 DIFF:

[Lldb-commits] [lldb] e6fbce6 - [lldb/Test] Fix typo in find-and-replace.

Author: Jonas Devlieghere Date: 2020-05-07T11:54:29-07:00 New Revision: e6fbce675d99982dab2e00eab390359e306d00a8 URL: https://github.com/llvm/llvm-project/commit/e6fbce675d99982dab2e00eab390359e306d00a8 DIFF:

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:52 +#include "Plugins/TypeSystem/Clang/TypeSystemClang.h" + friss wrote: > You don't want to introduce a dependency between Core and a plugin. What

[Lldb-commits] [lldb] 4356aa2 - Reuse existing functionality in XcodeSDK::SDKSupportsModules (NFC)

Author: Adrian Prantl Date: 2020-05-07T10:46:51-07:00 New Revision: 4356aa20bcea05b0f89c9977e41076552985f8c2 URL: https://github.com/llvm/llvm-project/commit/4356aa20bcea05b0f89c9977e41076552985f8c2 DIFF: https://github.com/llvm/llvm-project/commit/4356aa20bcea05b0f89c9977e41076552985f8c2.diff

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D79533: Reuse existing functionality in XcodeSDK::SDKSupportsModules (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4356aa20bcea: Reuse existing functionality in XcodeSDK::SDKSupportsModules (NFC) (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6e95d51 - Add an XcodeSDK::GetSDKTypeForTriple function

Author: Adrian Prantl Date: 2020-05-07T11:12:42-07:00 New Revision: 6e95d51ecfab0801b75448b20bd3447645a1142a URL: https://github.com/llvm/llvm-project/commit/6e95d51ecfab0801b75448b20bd3447645a1142a DIFF: https://github.com/llvm/llvm-project/commit/6e95d51ecfab0801b75448b20bd3447645a1142a.diff

[Lldb-commits] [lldb] 8c0ff17 - [lldb/Test] Add @skipIfReproducer to tests using lldb::FileSP.

Author: Jonas Devlieghere Date: 2020-05-07T11:17:00-07:00 New Revision: 8c0ff17c3bb44edf455a2964e6035f28be68c9f3 URL: https://github.com/llvm/llvm-project/commit/8c0ff17c3bb44edf455a2964e6035f28be68c9f3 DIFF:

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

jingham added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2846 + if (llvm::isa(compiler_type.GetTypeSystem())) { +if (HasSyntheticValue()) { + TargetSP target_sp = GetTargetSP(); mib wrote: > friss wrote: > > I am

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

jingham added a comment. The way the ValueObject code works w.r.t. Synthetic child providers is that you first look up and make a ValueObject for the actual value the user requested, (for instance a ValueObjectVariable or a ValueObjectChild or a ValueObjectConstResult for expressions, etc.),

[Lldb-commits] [lldb] dec1c94 - Add a function to detect whether an Xcode SDK supports Swift

Author: Adrian Prantl Date: 2020-05-07T11:29:31-07:00 New Revision: dec1c94e801f6fe1bae01c4679aca67abe0cb8a6 URL: https://github.com/llvm/llvm-project/commit/dec1c94e801f6fe1bae01c4679aca67abe0cb8a6 DIFF: https://github.com/llvm/llvm-project/commit/dec1c94e801f6fe1bae01c4679aca67abe0cb8a6.diff

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jingham accepted this revision. jingham added a comment. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

vsk updated this revision to Diff 262799. vsk added a comment. - Reinstated comment about SIP to explain why we copy python - Added a platform check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79607/new/ https://reviews.llvm.org/D79607 Files:

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

JDevlieghere added inline comments. Comment at: lldb/test/API/lldbtest.py:78 -# The macOS system integrity protection (SIP) doesn't allow injecting -# libraries into system binaries, but this can be worked around by -# copying the binary into a

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

vsk created this revision. vsk added a reviewer: JDevlieghere. Herald added a project: LLDB. On macOS, we can't do the DYLD_INSERT_LIBRARIES trick with a shim python binary as the ASan interceptors get loaded too late. Find the "real" python binary, copy it, and invoke it. Hopefully this makes

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

vsk updated this revision to Diff 262792. vsk added a comment. Query dyld while running within the right python process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79607/new/ https://reviews.llvm.org/D79607 Files:

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda created this revision. jasonmolenda added reviewers: labath, clayborg. jasonmolenda added a project: LLDB. I've been experimenting with returning richer error messages in debugserver recently, and I found a bug the other day where qLaunchSuccess returns its error code with an "E"

[Lldb-commits] [lldb] 2ea7187 - Add a new lockdownd plist for launching posix processes

Author: Jason Molenda Date: 2020-05-07T18:53:51-07:00 New Revision: 2ea7187ab9b7f0eab38a0b5be45c48b1f4f4938d URL: https://github.com/llvm/llvm-project/commit/2ea7187ab9b7f0eab38a0b5be45c48b1f4f4938d DIFF: https://github.com/llvm/llvm-project/commit/2ea7187ab9b7f0eab38a0b5be45c48b1f4f4938d.diff

[Lldb-commits] [PATCH] D79607: [lldb/test][Darwin] Ask dyld where the real python is

JDevlieghere added a comment. Thanks Vedant for coming up with a structural solution to this problem! Comment at: lldb/test/API/lldbtest.py:36 +# a Homebrew python3 binary, which also appears to be some kind of shim. +def getDarwinRealPythonExecutable(): +import ctypes

[Lldb-commits] [PATCH] D79603: Add an API to construct an XcodeSDK from an SDK type.

vsk added inline comments. Comment at: lldb/source/Utility/XcodeSDK.cpp:44 + } + static_assert(XcodeSDK::Linux == XcodeSDK::numSDKTypes - 1, +"New SDK type was added, update this list!"); I'd expect -Wcovered-switch to break the build if a new