Re: [Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. I wish we had a better abstraction for machine-specific behaviors than ArchSpec, since it seems sad to put

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, that looks good. Repository: rL LLVM http://reviews.llvm.org/D13073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r251657 - Give the test class it's own name (it was reusing the name from TestCompletions.py).

Author: jingham Date: Thu Oct 29 16:54:50 2015 New Revision: 251657 URL: http://llvm.org/viewvc/llvm-project?rev=251657=rev Log: Give the test class it's own name (it was reusing the name from TestCompletions.py). Modified:

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

> On Oct 29, 2015, at 3:34 AM, Mohit Bhakkad wrote: > > mohit.bhakkad added a comment. > > In http://reviews.llvm.org/D13296#265608, @jingham wrote: > >> This change alters the timing for the handling of ignore counts for >> watchpoints. The original implementation

[Lldb-commits] [lldb] r251564 - Change Target::EvaluateExpression to take an ExecutionContextScope * rather than a

Author: jingham Date: Wed Oct 28 17:23:17 2015 New Revision: 251564 URL: http://llvm.org/viewvc/llvm-project?rev=251564=rev Log: Change Target::EvaluateExpression to take an ExecutionContextScope * rather than a StackFrame * (StackFrame is an ExecutionContextScope.) That allows you to call an

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

-d:\src\llvmbuild\ninja_release\bin\clang.exe > Session info generated @ Thu Nov 12 15:44:43 2015 > To rerun this test, issue the following command from the 'test' directory: > > If it's not obvious what the problem is, can we revert this until we figure > it out and then reland i

[Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

Author: jingham Date: Thu Nov 12 16:32:09 2015 New Revision: 252963 URL: http://llvm.org/viewvc/llvm-project?rev=252963=rev Log: Another little stepping optimization: if any of the source step commands are running through a range of addresses, and the range has no branches, instead of running

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

f expected %d with pattern '%s'."%(cur_line, target_line, pattern)) > > AssertionError: False is not True : Stepped to line 0 instead of expected > > 19 with pattern 'intermediate_return_value = > > called_from_nodebug_actual(some_value)'. > > Config=i686-d:\src\llvmbuild

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

) > > > File > > > "D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\step-avoids-no-debug\TestStepNoDebug.py", > > > line 57, in hit_correct_line > > > self.assertTrue (cur_line == target_line, "Stepped to line %d inste

[Lldb-commits] [lldb] r253008 - Fix commit 252963 to work around a bug on some platforms where they don't

Author: jingham Date: Thu Nov 12 21:37:48 2015 New Revision: 253008 URL: http://llvm.org/viewvc/llvm-project?rev=253008=rev Log: Fix commit 252963 to work around a bug on some platforms where they don't correctly handle stepping over one breakpoint directly onto another breakpoint. This isn't

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

seems it wasn't just Windows that was affected by this. Makes me feel > > a little better :) > > > > Posting the link to the buildbot failures here so that Jim can get full > > logs if it helps. > > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/

[Lldb-commits] [lldb] r253094 - Change the test to use the instruction list to get the consecutive addresses to break on. Rerunning

Author: jingham Date: Fri Nov 13 16:19:08 2015 New Revision: 253094 URL: http://llvm.org/viewvc/llvm-project?rev=253094=rev Log: Change the test to use the instruction list to get the consecutive addresses to break on. Rerunning was being foiled by ASLR. Modified:

Re: [Lldb-commits] [lldb] r253086 - Add a null check against the ThreadPlan

Thanks. When I first did the thread plan stuff I wasn't sure whether I would have a use for an empty plan stack, so I didn't rigorously go through and assert everywhere that might happen. I had some idea for using an empty plan stack which was apparently so kooky that not only did I never

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

:57 PM, Zachary Turner <ztur...@google.com> wrote: >>> >>> Ahh, seems it wasn't just Windows that was affected by this. Makes me feel >>> a little better :) >>> >>> Posting the link to the buildbot failures here so that Jim can get full >>> log

Re: [Lldb-commits] [lldb] r253086 - Add a null check against the ThreadPlan

GetCurrentPlan should never return NULL. The Thread constructor pushes the Base thread plan onto the stack, and pop won't remove the Base plan. When we destroy the thread (in ThreadDestroy) we clear the plan stack and then push a ThreadPlanNull onto the plan stack. So if you are seeing a

[Lldb-commits] [lldb] r253106 - Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll to reverse

Author: jingham Date: Fri Nov 13 18:20:33 2015 New Revision: 253106 URL: http://llvm.org/viewvc/llvm-project?rev=253106=rev Log: Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll to reverse the sense of the test. Modified:

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

jingham added a comment. If the problem is that the self of the test object doesn't always have a debug_info setting, why not just always initialize it to None? Seems weird to have a general property like this that we don't initialize. http://reviews.llvm.org/D14673

[Lldb-commits] [lldb] r253308 - Add the ability (through the SB API & command line) to specify an address

Author: jingham Date: Mon Nov 16 21:39:13 2015 New Revision: 253308 URL: http://llvm.org/viewvc/llvm-project?rev=253308=rev Log: Add the ability (through the SB API & command line) to specify an address breakpoint as "file address" so that the address breakpoint will track that module even if it

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes. Repository: rL LLVM http://reviews.llvm.org/D13296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r251721 - Add a few missing includes.

Author: jingham Date: Fri Oct 30 16:32:25 2015 New Revision: 251721 URL: http://llvm.org/viewvc/llvm-project?rev=251721=rev Log: Add a few missing includes. Modified: lldb/trunk/include/lldb/API/LLDB.h Modified: lldb/trunk/include/lldb/API/LLDB.h URL:

[Lldb-commits] [lldb] r251720 - Fix an error message (the debugger was invalid, not the target.)

Author: jingham Date: Fri Oct 30 16:32:03 2015 New Revision: 251720 URL: http://llvm.org/viewvc/llvm-project?rev=251720=rev Log: Fix an error message (the debugger was invalid, not the target.) Modified: lldb/trunk/source/API/SBDebugger.cpp Modified: lldb/trunk/source/API/SBDebugger.cpp

[Lldb-commits] [lldb] r251722 - Make the error return more explicit when an SBValue has no value.

Author: jingham Date: Fri Oct 30 16:43:15 2015 New Revision: 251722 URL: http://llvm.org/viewvc/llvm-project?rev=251722=rev Log: Make the error return more explicit when an SBValue has no value. Modified: lldb/trunk/source/API/SBValue.cpp Modified: lldb/trunk/source/API/SBValue.cpp URL:

Re: [Lldb-commits] [lldb] r251678 - Some test cases that need the lldbExec path were failing because lldbExec was turning out to be None even though it was being validly set by dotest.py

Note, the other important step was that you had to have an lldb installed in /usr/bin/lldb that FAILED this test. If you have a more recent lldb there, the test will succeed, and you won't notice you aren't testing your newly built sources. Jim > On Oct 30, 2015, at 1:25 PM, Enrico Granata

[Lldb-commits] [lldb] r251727 - Abstract the notion of the truth value of an expression result, for use

Author: jingham Date: Fri Oct 30 19:02:18 2015 New Revision: 251727 URL: http://llvm.org/viewvc/llvm-project?rev=251727=rev Log: Abstract the notion of the truth value of an expression result, for use in breakpoint conditions. Modified: lldb/trunk/include/lldb/Core/ValueObject.h

[Lldb-commits] [lldb] r252072 - Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero out

Author: jingham Date: Wed Nov 4 14:32:27 2015 New Revision: 252072 URL: http://llvm.org/viewvc/llvm-project?rev=252072=rev Log: Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero out the Expression ResultVariable so it's in a known initial state. Modified:

[Lldb-commits] [lldb] r252129 - Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in place.

Author: jingham Date: Wed Nov 4 19:50:42 2015 New Revision: 252129 URL: http://llvm.org/viewvc/llvm-project?rev=252129=rev Log: Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in place. Modified: lldb/trunk/include/lldb/lldb-forward.h

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

; On Nov 4, 2015, at 6:00 PM, Jim Ingham <jing...@apple.com> wrote: >> >> Why? >> >> Jim >> >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda <jmole...@apple.com> wrote: >>> >>> We do the same thing in other MacOSX platform files where t

[Lldb-commits] [lldb] r252122 - CommandObjectProxy needs to proxy GenerateHelpText as well as

Author: jingham Date: Wed Nov 4 19:18:07 2015 New Revision: 252122 URL: http://llvm.org/viewvc/llvm-project?rev=252122=rev Log: CommandObjectProxy needs to proxy GenerateHelpText as well as everything else. Modified: lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

Why? Jim > On Nov 4, 2015, at 5:43 PM, Jason Molenda <jmole...@apple.com> wrote: > > We do the same thing in other MacOSX platform files where they depend on > Apple specific libraries. > > >> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits >>

[Lldb-commits] [lldb] r252106 - One of the File constructors was missing initializers. Didn't seem

Author: jingham Date: Wed Nov 4 18:22:19 2015 New Revision: 252106 URL: http://llvm.org/viewvc/llvm-project?rev=252106=rev Log: One of the File constructors was missing initializers. Didn't seem to cause any problems, but still... Modified: lldb/trunk/include/lldb/Host/File.h Modified:

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

Why are we trying to build this at all on Linux? Seems odd to build an empty file rather than just not build it. Jim > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits > wrote: > > Author: chaoren > Date: Wed Nov 4 19:23:19 2015 > New Revision: 252124 >

[Lldb-commits] [lldb] r252356 - Make the language specifier to "break set" actually filter the names by their language. So for

Author: jingham Date: Fri Nov 6 16:48:59 2015 New Revision: 252356 URL: http://llvm.org/viewvc/llvm-project?rev=252356=rev Log: Make the language specifier to "break set" actually filter the names by their language. So for instance: break set -l c++ -r Name will only break on C++ symbols

[Lldb-commits] [lldb] r252188 - Add a comment explaining TypeImpl.

Author: jingham Date: Thu Nov 5 13:20:39 2015 New Revision: 252188 URL: http://llvm.org/viewvc/llvm-project?rev=252188=rev Log: Add a comment explaining TypeImpl. Modified: lldb/trunk/include/lldb/Symbol/Type.h Modified: lldb/trunk/include/lldb/Symbol/Type.h URL:

Re: [Lldb-commits] [lldb] r252179 - Do not build any of the simulator material on non-Darwin

.mm means compile with the ObjectiveC++ compiler, not the ObjectiveC compiler. Probably wouldn't effect these files but it seems a really bogus way to tell the build system not to build files... Jim > On Nov 5, 2015, at 10:58 AM, Zachary Turner via lldb-commits >

[Lldb-commits] [lldb] r252184 - Remove Copy and Paste error in a comment.

Author: jingham Date: Thu Nov 5 12:51:48 2015 New Revision: 252184 URL: http://llvm.org/viewvc/llvm-project?rev=252184=rev Log: Remove Copy and Paste error in a comment. Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h URL:

Re: [Lldb-commits] [lldb] r252031 - Add a few useful methods to ThreadSafeDense{Map, Set}. Not used yet.

, and don't want to get side-tracked. Jim > On Nov 3, 2015, at 5:43 PM, Zachary Turner <ztur...@google.com> wrote: > > Seems like this class would be a good candidate for using an RWMutex. Any > reason you can think of why that wouldn't work? > > On Tue, Nov 3, 2015 a

[Lldb-commits] [lldb] r252029 - Fix a shadowed ivar in SearchFilterByModuleListAndCU.

Author: jingham Date: Tue Nov 3 19:24:04 2015 New Revision: 252029 URL: http://llvm.org/viewvc/llvm-project?rev=252029=rev Log: Fix a shadowed ivar in SearchFilterByModuleListAndCU. Modified: lldb/trunk/include/lldb/Core/SearchFilter.h Modified: lldb/trunk/include/lldb/Core/SearchFilter.h

[Lldb-commits] [lldb] r252024 - Actually implement Section::GetSectionData.

Author: jingham Date: Tue Nov 3 19:02:43 2015 New Revision: 252024 URL: http://llvm.org/viewvc/llvm-project?rev=252024=rev Log: Actually implement Section::GetSectionData. Modified: lldb/trunk/include/lldb/Core/Section.h lldb/trunk/source/Core/Section.cpp Modified:

[Lldb-commits] [lldb] r252224 - Let the process help figure out the Host OS if nobody else

Author: jingham Date: Thu Nov 5 16:33:17 2015 New Revision: 252224 URL: http://llvm.org/viewvc/llvm-project?rev=252224=rev Log: Let the process help figure out the Host OS if nobody else can figure it out. Modified: lldb/trunk/include/lldb/Target/Platform.h

[Lldb-commits] [lldb] r252240 - Add a generic API to return the Concrete type for a given abstract type

Author: jingham Date: Thu Nov 5 17:52:05 2015 New Revision: 252240 URL: http://llvm.org/viewvc/llvm-project?rev=252240=rev Log: Add a generic API to return the Concrete type for a given abstract type name and the execution context in which it is realized. Modified:

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

The substance is fine. I fixed up the grammar a little, maybe something like: TODO: This condition should be checked in the synchronous part of the watchpoint code (Watchpoint::ShouldStop), so that we avoid pulling an event even if the watchpoint fails the ignore count condition. It is moved

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

jingham added a subscriber: jingham. jingham added a comment. The substance is fine. I fixed up the grammar a little, maybe something like: TODO: This condition should be checked in the synchronous part of the watchpoint code (Watchpoint::ShouldStop), so that we avoid pulling an event even if

Re: [Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

> On Aug 14, 2015, at 1:47 PM, Paul Herman wrote: > > paulherman added a comment. > > This patch does exactly that. It detects the language of the frame and > upgrades it according to the rules you said (I think I might've missed ObjC > -> ObjC++, but that can be

Re: [Lldb-commits] [lldb] r250753 - Added the concept of a Read-Eval-Print-Loop to LLDB.

> On Oct 19, 2015, at 4:18 PM, Zachary Turner via lldb-commits > wrote: > > I think this is going to break the CMake build. Can you update the relevant > CMakeLists.txt file? > > Also, are there any tests for this? This doesn't actually add a REPL for any of

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

jingham added a comment. The generic parts of this change look fine to me, with a few inlined style comments. I didn't read the Go specific parts of this in detail, I assume you're going to get those right. I mentioned a couple of style things inline, though I didn't mark everywhere that

[Lldb-commits] [lldb] r250081 - Fix test for change in a summary string (objects -> elements).

Author: jingham Date: Mon Oct 12 14:00:28 2015 New Revision: 250081 URL: http://llvm.org/viewvc/llvm-project?rev=250081=rev Log: Fix test for change in a summary string (objects -> elements). Modified: lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py Modified:

[Lldb-commits] [lldb] r250082 - Add a doc string for ReturnFromFrame.

Author: jingham Date: Mon Oct 12 14:02:08 2015 New Revision: 250082 URL: http://llvm.org/viewvc/llvm-project?rev=250082=rev Log: Add a doc string for ReturnFromFrame. Modified: lldb/trunk/scripts/interface/SBThread.i Modified: lldb/trunk/scripts/interface/SBThread.i URL:

[Lldb-commits] [lldb] r250083 - Return the right answer for ShouldStop for the RunToAddress plan. This isn't

Author: jingham Date: Mon Oct 12 14:03:32 2015 New Revision: 250083 URL: http://llvm.org/viewvc/llvm-project?rev=250083=rev Log: Return the right answer for ShouldStop for the RunToAddress plan. This isn't strictly necessary because RunToAddress is always used as a subsidiary plan, so it's

[Lldb-commits] [lldb] r250084 - Fix a misunderstanding of the ThreadPlan::OkayToDiscard flag in InferiorCallPOSIX. It was

Author: jingham Date: Mon Oct 12 14:11:03 2015 New Revision: 250084 URL: http://llvm.org/viewvc/llvm-project?rev=250084=rev Log: Fix a misunderstanding of the ThreadPlan::OkayToDiscard flag in InferiorCallPOSIX. It was set to true, but all plans run by RunThreadPlan need to have this set to

Re: [Lldb-commits] [PATCH] D13678: [libstdc++ data-formatters] Remove size limits and loop detector.

jingham added a subscriber: jingham. jingham added a comment. I don't know about the std::list implementation in specific, but in the debugger you have to be aware of the possibility that you are looking at an entity that is in the middle of being modified. Note, it may not be obvious to the

Re: [Lldb-commits] [PATCH] D13678: [libstdc++ data-formatters] Remove size limits and loop detector.

I don't know about the std::list implementation in specific, but in the debugger you have to be aware of the possibility that you are looking at an entity that is in the middle of being modified. Note, it may not be obvious to the user that that is being done since it may be happening on

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This change alters the timing for the handling of ignore counts for watchpoints. The original implementation (and the way ignore counts work for breakpoints) is that the

[Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

Author: jingham Date: Tue Sep 1 20:59:14 2015 New Revision: 246616 URL: http://llvm.org/viewvc/llvm-project?rev=246616=rev Log: Move more functionality from the LanguageRuntimes to the Languages. Modified: lldb/trunk/include/lldb/Target/CPPLanguageRuntime.h

[Lldb-commits] [lldb] r246611 - Move things from the LanguageRuntime that obviously belong in the new Language plugin instead.

Author: jingham Date: Tue Sep 1 20:06:46 2015 New Revision: 246611 URL: http://llvm.org/viewvc/llvm-project?rev=246611=rev Log: Move things from the LanguageRuntime that obviously belong in the new Language plugin instead. Modified: lldb/trunk/include/lldb/Target/Language.h

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

If the user says "break set -a " I have no problem with our setting the breakpoint there even if we don't think it is a terribly good idea. But if lldb is converting any other specification to an address, it should always move past data in text. The failure modes if you aren't careful about

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

jingham added a subscriber: jingham. jingham added a comment. If the user says "break set -a " I have no problem with our setting the breakpoint there even if we don't think it is a terribly good idea. But if lldb is converting any other specification to an address, it should always move past

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

I agree with Zachary that we shouldn't mess around with options piecemeal, but let Todd get done with this first round of fixes then go take a hatchet to the options that dotest has, hopefully removing all the ones that nobody needs and rationalizing the others. Jim > On Sep 4, 2015, at 1:31

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

jingham added a comment. That look good. There's one place (noted inline) where you are missing a newline at the end of a file. Fix that and it's good to go. Comment at: source/Expression/ExpressionVariable.cpp:32-33 @@ +31,2 @@ +return NULL; +} \ No newline at end of

[Lldb-commits] [lldb] r247046 - SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed

Author: jingham Date: Tue Sep 8 13:40:59 2015 New Revision: 247046 URL: http://llvm.org/viewvc/llvm-project?rev=247046=rev Log: SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed is valid, and that its thread is the same as this SBThread. Modified:

[Lldb-commits] [lldb] r246740 - Remove the list of all languages in the help for "help language" since

Author: jingham Date: Wed Sep 2 20:13:26 2015 New Revision: 246740 URL: http://llvm.org/viewvc/llvm-project?rev=246740=rev Log: Remove the list of all languages in the help for "help language" since almost all the elements on the list can't actually be passed to the language command and all the

[Lldb-commits] [lldb] r246744 - Purge a few places where *LanguageRuntime.h was being used when it

Author: jingham Date: Wed Sep 2 20:40:51 2015 New Revision: 246744 URL: http://llvm.org/viewvc/llvm-project?rev=246744=rev Log: Purge a few places where *LanguageRuntime.h was being used when it wasn't needed. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

jingham added a subscriber: jingham. jingham added a comment. It isn't technically necessary, but on OS X it is very common for people to want to examine global app state from wherever and that is always ObjC, so we'd tick off our users if we forced them to explicitly dial up ObjC in other

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

It isn't technically necessary, but on OS X it is very common for people to want to examine global app state from wherever and that is always ObjC, so we'd tick off our users if we forced them to explicitly dial up ObjC in other contexts. For other platforms it would be fine to choose just

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. In general this looks good. It seems to me that in almost all the uses of ClangExpressionVariable::CreateVariableInList, you actually only want the ClangExpressionVariable *,

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

jingham added a subscriber: jingham. jingham added a comment. The point of the file name check is to catch the case where you had nested inlines that share the same address, and the compiler (errantly, but...) decided to emit duplicate entries at the same address for the two levels of

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. This change means that the two cases "no debug info" and "couldn't find your sources" end up looking very

[Lldb-commits] [lldb] r247709 - Make the source-map help grammatical.

Author: jingham Date: Tue Sep 15 13:03:00 2015 New Revision: 247709 URL: http://llvm.org/viewvc/llvm-project?rev=247709=rev Log: Make the source-map help grammatical. Modified: lldb/trunk/source/Target/Target.cpp Modified: lldb/trunk/source/Target/Target.cpp URL:

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

> On Sep 15, 2015, at 2:27 PM, Greg Clayton wrote: > > clayborg accepted this revision. > clayborg added a comment. > > I would rather not see a warning. If you don't have sources I don't really > want to see: > > warning: couldn't find foo.c > 0x1000: add r1, r2, r3 >

[Lldb-commits] [lldb] r247589 - Remove a debugging printf that got left in SymbolFileDWARFDebugMap.

Author: jingham Date: Mon Sep 14 13:28:28 2015 New Revision: 247589 URL: http://llvm.org/viewvc/llvm-project?rev=247589=rev Log: Remove a debugging printf that got left in SymbolFileDWARFDebugMap. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Modified:

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. The part of this fix which is using info in the SymbolContext to make the language detection more accurate is fine. We have to do something better about how we detect the language

Re: [Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

jingham added a subscriber: jingham. jingham added a comment. It seems like an awful lot of logic is duplicated between the POSIX & Android versions of LoadImage when all that really changes is the name of the function you are calling. Is it possible to centralize this some more? Repository:

Re: [Lldb-commits] [PATCH] D15152: Change Platform::LoadImage to copy the file to the remote platform

jingham added a subscriber: jingham. jingham added a comment. We use process load to load images that are already extant (and system libraries at that.) So it's got to be possible to load a library into a target process without trying to get the image over to the target. And given how slow

Re: [Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. OK. It would have been better to make a patch that fixes the specific problem with other C variants. That's just a straight up bug, and mixing it with comments on the two separate issues,

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. It doesn't require any thread rendezvousing or anything fancy like that. http://reviews.llvm.org/D15241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

jingham added a comment. "cstring_is_mangled" does NOT mean that the string is a C++ mangled string, it means it is ANY kind of mangled string - you can tell because it is used to determine whether to populate the m_mangled and m_demangled components of the Mangled structure, which it should

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The logic was: - Set a breakpoint on some loop that will get hit multiple times in some thread worker function. - The first time it is hit, make it specific to the thread that hit it by setting a Thread ID on the breakpoint. - Then add a condition to the breakpoint

[Lldb-commits] [lldb] r254763 - Add documentation for SBTarget::CreateValueFromAddress.

Author: jingham Date: Fri Dec 4 14:16:51 2015 New Revision: 254763 URL: http://llvm.org/viewvc/llvm-project?rev=254763=rev Log: Add documentation for SBTarget::CreateValueFromAddress. Modified: lldb/trunk/scripts/interface/SBTarget.i Modified: lldb/trunk/scripts/interface/SBTarget.i URL:

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The test that test "Only breakpoint conditions" will always have LLDB_INVALID_ID for the breakpoint thread ID. That means the thread test is a no-op. So it doesn't test the case "thread passes, condition doesn't" or "condition passes, thread doesn't". I wrote this

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Anyway, adding a separate test is fine with me. http://reviews.llvm.org/D15241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r254790 - Make it clear how you would get the pointee out of an SBValue with

Author: jingham Date: Fri Dec 4 16:51:19 2015 New Revision: 254790 URL: http://llvm.org/viewvc/llvm-project?rev=254790=rev Log: Make it clear how you would get the pointee out of an SBValue with GetType().IsPointerType() returns true. Modified: lldb/trunk/include/lldb/API/SBValue.h

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The comments in llvm.org/pr18522 seem to me to be bugs that the test is uncovering, not bugs in the test itself. It looks like we hit a breakpoint on thread A, and try to run the condition on thread B. In some cases, thread B isn't really alive yet, and so the

Re: [Lldb-commits] [PATCH] D15183: Remove some duplicated code from PlatformPOSIX/Android

jingham added a comment. Cute! That's much nicer. Repository: rL LLVM http://reviews.llvm.org/D15183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. If we really can't tell whether a symbol is CPP or Pascal based on the name, then GetLanguageForSymbolByName should be reworked to take a std::vector& in which to return the

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits > wrote: > > > > On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner > wrote: > On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits >

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

We don't indent access modifiers, so if AccessModifierOffset does what it's name suggests, then that's right. Jim > On Dec 16, 2015, at 8:09 AM, Todd Fiala wrote: > > tfiala added a reviewer: jingham. > tfiala added a comment. > > Hey Jim, this looks right to me.

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. I don't think this is sufficiently different from "target modules dump line-tables" to warrant a separate

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

jingham added a comment. Provided we error out appropriately I don't think we need to support all possible combinations of options. I'd happier doing it by options and not supporting the combinations that aren't worth the effort. Then if anybody really needs one of the unsupported ones, the

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

That seems fine for now. Note, if you use the OptionGroupOptions way of defining the new options for your command, then you can call OptionsSeen to tell you which options were actually provided by the user, so for extra credit, if --compile-unit-only is true and no other options were

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

jingham added a comment. That seems fine for now. Note, if you use the OptionGroupOptions way of defining the new options for your command, then you can call OptionsSeen to tell you which options were actually provided by the user, so for extra credit, if --compile-unit-only is true and no

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

jingham added a comment. Okay. So it seems like there are a couple of orthogonal differences here. 1. The current behavior requires that the the source file you pass in be a compile unit. We don't search inside the line tables. So for instance target modules dump line-tables foo.h would

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks fine. http://reviews.llvm.org/D15407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r255598 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

I see the value of replacing NULL with nullptr, but I don't see the value of these sorts of changes: > On Dec 14, 2015, at 5:33 PM, Eugene Zelenko via lldb-commits > wrote: > > @@ -118,19 +111,13 @@ ThreadPlanStepInstruction::IsPlanStale ( > StackID

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:42 PM, Zachary Turner wrote: > > Yes, but as I mentioned, two things are still unsupported due to limitations > in clang-format. They are return-type-on-new-line (only in declarations. > clang-format supports it for definitions) and the

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Note, it is pure speculation that this is a bug in clang-format based on where the : is placed. I prefer the way we write it, because it places all the initializers on the same level, though I don’t feel so strongly about this one. I would really rather not go through making wholesale changes

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks good. I have one worry. If the plan is stepping through a range of line 10, and that code branches to: 0x120 - line 0 0x128 - line 11 0x130 - line 12 You will see

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham added a comment. The comment about "sometimes we step through another line" wasn't clear. I wanted to say - as a last recourse we do this, but we shouldn't if we can avoid it, which in this case I think we can. Repository: rL LLVM http://reviews.llvm.org/D15407

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

jingham added a subscriber: jingham. jingham added a comment. This patch is not acceptable as is. It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do. As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

This patch is not acceptable as is. It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do. As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled flavor against Itanium and MSVC. So it shouldn’t be hard to

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't so much mind that you couldn't reuse AdvanceAddressToNextBranchInstruction, we wouldn't be using the "get the disassembly" part of it, which is the biggest bit, since

  1   2   3   4   5   6   7   8   9   10   >