[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed friss wrote: > Is there a reliable way to check that the expansion we

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed JDevlieghere wrote: >

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere updated this revision to Diff 222759. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Check pointer returned by `getpwuid`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68316/new/ https://reviews.llvm.org/D68316 Files:

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

jarin added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2 +""" +Test that expression evaluator can access members of nested classes even if +the parents of the nested classes

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

jarin updated this revision to Diff 222803. jarin marked 5 inline comments as done. jarin added a comment. Fixed the nits, thanks for the careful review! I will indeed need someone to submit this for me. Thanks in advance :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68278/new/

[Lldb-commits] [lldb] r373457 - [lldb][NFC] Create the ASTContext in ClangASTContext exactly once.

Author: teemperor Date: Wed Oct 2 05:26:08 2019 New Revision: 373457 URL: http://llvm.org/viewvc/llvm-project?rev=373457=rev Log: [lldb][NFC] Create the ASTContext in ClangASTContext exactly once. Reason for this patch is the Ssame reason as for the previous patches: Having a ClangASTContext

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath planned changes to this revision. labath marked an inline comment as done. labath added a comment. Thanks for the quick feedback. I didn't realize that the range list code handles some of this stuff already (I didn't look at it -- I guess I should've). I'll try to play around with this a

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. Hmm... I like your solution of the typemap problem, but this CRTP class seems to be way more complicated than needed. There shouldn't be any need for CRTP as we already have regular dynamic dispatch via virtual methods. Also, I don't think the forwarding should be

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2 +""" +Test that expression evaluator can access members of nested classes even if +the parents of the nested

[Lldb-commits] [lldb] r373460 - [lldb][NFC] Remove ClangASTContext::Clear

Author: teemperor Date: Wed Oct 2 05:38:04 2019 New Revision: 373460 URL: http://llvm.org/viewvc/llvm-project?rev=373460=rev Log: [lldb][NFC] Remove ClangASTContext::Clear We now only use this function directly after initialization. As Clear() resets the ASTContext back to its initial state,

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. Thanks. The code looks fine now, but it doesn't look like you've addressed my comments in the test (or at least, they didn't make it into the uploaded version). Also, I don't think the long comment before the code in ObjectFileELF really reflects what the code does

[Lldb-commits] [PATCH] D68302: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerPlatform

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, with the same caveat about about namespaces. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68302/new/ https://reviews.llvm.org/D68302

[Lldb-commits] [PATCH] D68305: [JSON] Remove Utility/JSON.{h|cpp}

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yay. This turned to be easier than I expected. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68305/new/ https://reviews.llvm.org/D68305

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am happy to accept this patch as-is, but since you seem to be on a quest to improve the process listing I thought I'd mention that `getgrgid_r` seems to be available on android since API

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

labath added a comment. It seems to me that the Host class is too low level to be encoding some of the android specifics into it. I think it would be better to handle these things higher up. Please see inline comments for details. Comment at:

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

labath added a comment. Makes sense to me, just delete the custom make_shared stuff. Comment at: lldb/include/lldb/Host/File.h:377-381 + template + static std::shared_ptr make_shared(Args... args) { +return std::static_pointer_cast( +std::make_shared(args...));

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

teemperor added a comment. Just a few nitpicks about some minor typos, otherwise this LGTM. Thanks for the patch! I assume you need someone to commit this for you? Comment at:

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

labath added inline comments. Comment at: lldb/lit/Host/TestCustomShell.test:5 +# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s +# CHECK: error: shell expansion failed JDevlieghere wrote: > JDevlieghere wrote: > > friss wrote: > > > Is there a

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

teemperor created this revision. teemperor added reviewers: shafik, martong. Herald added subscribers: lldb-commits, JDevlieghere, abidh, christof, rnkovacs, aprantl. Herald added a project: LLDB. As we figured out in D67803 , importing declarations from a

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk planned changes to this revision. kwk added a comment. LLVM reasoning for why to go with `std::vector`: http://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

labath added a comment. Sounds reasonable, but you'll also need to update the test in ProcessInstanceInfoTest.cpp. Maybe also change/add an entry to that test so that it includes this long android triple while you're inside? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added a comment. Including the args sounds like a good idea, but I don't think the chosen encoding scheme is very good. The encoding done in `GetCommandString` is very naive and not reversible. Since you're hex-encoding the result anyway, and the nul character cannot be present inside

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

labath added a comment. Someone also didn't write a test for that. :) Let's not make the same mistake. The same two options I mentioned in D68293 should apply here too, though for this case, I would slightly prefer the c++ unit test route, as it will isolate

[Lldb-commits] [PATCH] D68304: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerCommon

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, with the usual question/caveat. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68304/new/ https://reviews.llvm.org/D68304

[Lldb-commits] [PATCH] D68301: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, though I'm not sure whether using `using namespace llvm` is such a good idea. There's a fair number of classes with identical names in llvm and lldb_private namespaces. As we start using

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Thanks for doing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68299/new/ https://reviews.llvm.org/D68299 ___ lldb-commits

[Lldb-commits] [lldb] r373470 - [lldb] Fix evaluation of nested classes with parent from other CU

Author: teemperor Date: Wed Oct 2 06:46:17 2019 New Revision: 373470 URL: http://llvm.org/viewvc/llvm-project?rev=373470=rev Log: [lldb] Fix evaluation of nested classes with parent from other CU This makes sure that we associate DIEs that are imported from other CUs with the appropriate decl

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

aprantl added inline comments. Comment at: clang/include/clang/AST/ExternalASTMerger.h:87 const OriginMap +/// True iff the source only exists temporary, i.e. it will be removed from +/// the ExternalASTMerger during the life time of the ExternalASTMerger.

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 222845. kwk marked 12 inline comments as done. kwk added a comment. - Change logic and comment for when .dynsym is parsed - Use different pattern for error checking - use less auto - Remove required system-linux test feature from LZMA tests Repository: rG

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk planned changes to this revision. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731 Section *symtab = section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get(); -if (!symtab) { - // The

[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

This revision was automatically updated to reflect the committed changes. Closed by commit rL373470: [lldb] Fix evaluation of nested classes with parent from other CU (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1691129 , @labath wrote: > Hmm... I like your solution of the typemap problem, but this CRTP class seems > to be way more complicated than needed. There shouldn't be any need for CRTP > as we already have

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath any more comments on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. I actually just completely missed the first comment on the .s test and forgot about the comment . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth added a comment. In D68258#1690757 , @aleksandr.urakov wrote: > In D68258#1690756 , > @aleksandr.urakov wrote: > > > I've made it in the way similar to Zachary have made for the > >

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. In D68188#1691337 , @lawrence_danna wrote: > In D68188#1691129 , @labath wrote: > > > Then depending on what you need, you create either a NativeFile, > > OwningPythonFile, or a

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk abandoned this revision. kwk added a comment. Here's the relevant transcript from #lldb@otfc for why this change is abandoned. [10/02/19 15:22:25] labath: Is it acceptable for you? "BTW given how this unique-ness of symbols turns out to be non-trivial is it really needed? Because for

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

martong added a comment. With [modern-type-lookup], we completely evade the use of `ASTImporterDelegate`? That would be a wonderful thing to use only the the ExternalASTMerger on a long term... > ... a bunch of duplicated declarations This popped a few thoughts into my head: One way to

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nah, this looks fine to me now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

labath added a comment. In D68258#1691485 , @amccarth wrote: > The environment variable for using the native PDB was always intended to be > temporary, since the native PDB reader would eventually be the only PDB > reader. I don't know whether that's

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk requested review of this revision. kwk added a comment. This revision is now accepted and ready to land. Tests did pass so this change is ready for review @labath @jankratochvil . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222853. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik marked 7 inline comments as done. shafik added a comment. I ended up splitting out the functionality into a new method `dumpClangAST` it looks PDB is not as lazy as DWARF and there are several PDB tests already using the current `dumpAST` as it is. Comment at:

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

aprantl added inline comments. Comment at: include/lldb/Symbol/ClangASTContext.h:895 + /// Dump clang AST types from the symbol table + /// nit: `.` at the end Comment at: include/lldb/Symbol/ClangASTContext.h:896 + /// Dump clang AST

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/SymbolFile/dissassemble-entry-point.s:10 + +.global _Start +_start: This .global _Start is also unneeded, as it does not even match

[Lldb-commits] [PATCH] D68304: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerCommon

This revision was automatically updated to reflect the committed changes. Closed by commit rL373500: [JSON] Use LLVMs library for encoding JSON in… (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68305: [JSON] Remove Utility/JSON.{h|cpp}

This revision was automatically updated to reflect the committed changes. Closed by commit rL373501: [JSON] Remove Utility/JSON.{h|cpp} (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

This revision was automatically updated to reflect the committed changes. Closed by commit rL373497: [JSON] Use LLVMs library for encoding JSON in GDBRemoteCommunicationServerLLGS (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D68302: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerPlatform

This revision was automatically updated to reflect the committed changes. Closed by commit rL373499: [JSON] Use LLVMs library for encoding JSON in… (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68301: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient

This revision was automatically updated to reflect the committed changes. Closed by commit rL373498: [JSON] Use LLVMs library for encoding JSON in GDBRemoteCommunicationClient (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna added inline comments. Comment at: lldb/include/lldb/Host/File.h:377-381 + template + static std::shared_ptr make_shared(Args... args) { +return std::static_pointer_cast( +std::make_shared(args...)); + } labath wrote: > Please

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 222861. shafik retitled this revision from "[WIP] Modify lldb-test to print out ASTs from symbol file" to "Modify lldb-test to print out ASTs from symbol file". shafik added a comment. - Updated approach based on comment - Pushed clang ast manipulation into

[Lldb-commits] [lldb] r373498 - [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient

Author: jdevlieghere Date: Wed Oct 2 11:02:26 2019 New Revision: 373498 URL: http://llvm.org/viewvc/llvm-project?rev=373498=rev Log: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient This patch replaces the LLDB's JSON implementation with the one from LLVM in

[Lldb-commits] [lldb] r373499 - [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerPlatform

Author: jdevlieghere Date: Wed Oct 2 11:02:29 2019 New Revision: 373499 URL: http://llvm.org/viewvc/llvm-project?rev=373499=rev Log: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerPlatform This patch replaces the LLDB's JSON implementation with the one from LLVM in

[Lldb-commits] [lldb] r373501 - [JSON] Remove Utility/JSON.{h|cpp}

Author: jdevlieghere Date: Wed Oct 2 11:02:36 2019 New Revision: 373501 URL: http://llvm.org/viewvc/llvm-project?rev=373501=rev Log: [JSON] Remove Utility/JSON.{h|cpp} This patch is the final step in my quest to get rid of the JSON parser in LLDB. Vedant's coverage report [1] shows that it was

[Lldb-commits] [lldb] r373500 - [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerCommon

Author: jdevlieghere Date: Wed Oct 2 11:02:32 2019 New Revision: 373500 URL: http://llvm.org/viewvc/llvm-project?rev=373500=rev Log: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerCommon This patch replaces the LLDB's JSON implementation with the one from LLVM in

[Lldb-commits] [lldb] r373497 - [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

Author: jdevlieghere Date: Wed Oct 2 11:02:23 2019 New Revision: 373497 URL: http://llvm.org/viewvc/llvm-project?rev=373497=rev Log: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS This patch replaces the LLDB's JSON implementation with the one from LLVM in

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222848. aadsm added a comment. Update comment and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

shafik added inline comments. Comment at: clang/include/clang/AST/ExternalASTMerger.h:95 public: -ImporterSource(ASTContext &_AST, FileManager &_FM, const OriginMap &_OM) -: AST(_AST), FM(_FM), OM(_OM) {} +ImporterSource(ASTContext &_AST, FileManager &_FM,

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace marked 3 inline comments as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:178-185 LLDB_LOG(log, "failed to read link exe link for {0}: {1}", pid, Status(errno, eErrorTypePOSIX)); -return false; +

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222883. lawrence_danna added a comment. get rid of CRTP gobbledygook Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

JDevlieghere updated this revision to Diff 222882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68316/new/ https://reviews.llvm.org/D68316 Files: lldb/lit/Host/Inputs/simple.c lldb/lit/Host/TestCustomShell.test lldb/source/Host/posix/HostInfoPosix.cpp Index:

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1683934 , @labath wrote: > In D67994#1683440 , @shafik wrote: > > > I believe this is due to us being lazy as to when we import. > > > Yes, but doesn't calling

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

labath added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:178-185 LLDB_LOG(log, "failed to read link exe link for {0}: {1}", pid, Status(errno, eErrorTypePOSIX)); -return false; +ExePath.resize(0); +#if defined(__ANDROID__) +// On

[Lldb-commits] [lldb] r373507 - [ObjectFileMachO] Catch up with FileDesc changes.

Author: davide Date: Wed Oct 2 12:20:15 2019 New Revision: 373507 URL: http://llvm.org/viewvc/llvm-project?rev=373507=rev Log: [ObjectFileMachO] Catch up with FileDesc changes. This didn't show up because nobody built __arm64__ in a while. Modified:

[Lldb-commits] [lldb] r373508 - [ObjectFileMachO] FileSpec::SetFile() now takes the style as arg.

Author: davide Date: Wed Oct 2 12:20:18 2019 New Revision: 373508 URL: http://llvm.org/viewvc/llvm-project?rev=373508=rev Log: [ObjectFileMachO] FileSpec::SetFile() now takes the style as arg. Another block that's only compiled on __arm64__ and wasn't updated. Modified:

[Lldb-commits] [lldb] r373509 - [RegisterContextDarwin_arm64] Include the headers for getsysctlbyname.

Author: davide Date: Wed Oct 2 12:20:21 2019 New Revision: 373509 URL: http://llvm.org/viewvc/llvm-project?rev=373509=rev Log: [RegisterContextDarwin_arm64] Include the headers for getsysctlbyname. This code is only used under __arm64__, use the correct guard. Modified:

[Lldb-commits] [lldb] r373510 - [ARM64] XPC services are unsupported on device.

Author: davide Date: Wed Oct 2 12:20:24 2019 New Revision: 373510 URL: http://llvm.org/viewvc/llvm-project?rev=373510=rev Log: [ARM64] XPC services are unsupported on device. While around, clean up support for a 8 years old OS. Modified: lldb/trunk/source/Host/macosx/objcxx/Host.mm

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace created this revision. wallace added reviewers: labath, xiaobai, aadsm, clayborg. Herald added subscribers: lldb-commits, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: LLDB. For context: https://reviews.llvm.org/D68293 We need a way to show all the processes on

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1854 + gdd_objfile_section_list->FindSectionByType( + eSectionTypeELFSymbolTable, true)) { +SectionSP module_section_sp =

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace added a comment. Btw, I couldn't find a better short command than 'x', but if you have a better suggestion, i'd be happy to accept it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222905. wallace added a comment. i'm learning arc... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222903. wallace added a comment. simplify this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Commands/CommandObjectPlatform.cpp

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace added a comment. I removed all android-specific logic from this diff, and relaxed most of the checks inside GetProcessAndStatInfo so that more processes are displayed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 222908. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

rupprecht added a comment. FYI, we've root caused some internal lldb asan failures to this patch. I don't have a repro yet (my lldb tests seem to be failing locally for unrelated reasons), but e.g. `Register/x86-64-read.test` is failing to read all the non-general purpose registers: (lldb)

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

wallace updated this revision to Diff 222921. wallace added a comment. Herald added a subscriber: srhines. updated the unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68291/new/ https://reviews.llvm.org/D68291 Files:

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 222923. tetsuo-cpp added a comment. Rebased onto trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h Index:

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 222935. shafik marked 14 inline comments as done. shafik added a comment. Updates based on comments: - Remove use of AsCString() - Fixed use of old API - other minor issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

JDevlieghere created this revision. JDevlieghere added reviewers: friss, aprantl, thegameg. Herald added subscribers: llvm-commits, mgorny. Herald added projects: LLDB, LLVM. This patch reimplements command line option parsing in dsymutil with Tablegen and libOption. The main motivation for this

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Thank you for the suggestions! I'm assuming that since only the `debugserver` portion of this change is left, I should write a test specifically for that. I had a quick look and it wasn't obvious how to do that but I will spend some more time on it this weekend.

[Lldb-commits] [PATCH] D67831: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67831/new/ https://reviews.llvm.org/D67831 ___

[Lldb-commits] [PATCH] D68363: Segregate the Python class + key/value dictionary into a separate OptionGroup

jingham created this revision. jingham added reviewers: clayborg, teemperor. Herald added subscribers: lldb-commits, JDevlieghere, abidh, mgorny. Herald added a project: LLDB. I want to reuse these options (break set's -P -k -v) in another command (thread step-scripted) in a future commit, so I

[Lldb-commits] [lldb] r373563 - SBDebugger::SetInputFile, SetOutputFile, etc.

Author: lawrence_danna Date: Wed Oct 2 21:04:48 2019 New Revision: 373563 URL: http://llvm.org/viewvc/llvm-project?rev=373563=rev Log: SBDebugger::SetInputFile, SetOutputFile, etc. Summary: Add new methods to SBDebugger to set IO files as SBFiles instead of as FILE* streams. In future commits,

[Lldb-commits] [PATCH] D67793: new api class: SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL373562: new api class: SBFile (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

aadsm created this revision. aadsm added reviewers: labath, xiaobai, clayborg, lanza. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. I'd like to install lldb using the install-distribution target with LLVM_DISTRIBUTION_COMPONENTS but this is currently not possible

[Lldb-commits] [lldb] r373562 - new api class: SBFile

Author: lawrence_danna Date: Wed Oct 2 21:01:07 2019 New Revision: 373562 URL: http://llvm.org/viewvc/llvm-project?rev=373562=rev Log: new api class: SBFile Summary: SBFile is a scripting API wrapper for lldb_private::File This is the first step in a project to enable arbitrary python

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

This revision was automatically updated to reflect the committed changes. Closed by commit rL373564: factor out an abstract base class for File (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222967. aadsm added a comment. Remove .global _Start Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

jingham created this revision. jingham added reviewers: labath, JDevlieghere, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham added a parent revision: D68363: Segregate the Python class + key/value dictionary into a separate OptionGroup. It is trivial to

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373563: SBDebugger::SetInputFile, SetOutputFile, etc. (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

jingham updated this revision to Diff 222952. jingham added a comment. Missed a bit that removed m_class_name from the old command options (and didn't use the new option.) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68366/new/

[Lldb-commits] [lldb] r373564 - factor out an abstract base class for File

Author: lawrence_danna Date: Wed Oct 2 21:31:46 2019 New Revision: 373564 URL: http://llvm.org/viewvc/llvm-project?rev=373564=rev Log: factor out an abstract base class for File Summary: This patch factors out File as an abstract base class and moves most of its actual functionality into a