[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

mstorsjo added a reviewer: zturner. mstorsjo added a comment. As context (I haven't followed lldb almost at all), what's the general status of lldb on windows - generally working, or still a work in progress? Does it work with dwarf debug info in COFF (as commonly used in mingw environments),

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

mstorsjo created this revision. mstorsjo added reviewers: compnerd, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This matches how it is done in all other similar ifdefs throughout lldb (modulo inconsistencies between `_M_AMD64` and `_M_X64`); both

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo added a comment. In D67856#1677356 , @davide wrote: > If this doesn't break clang and gcc, fine. FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc. But the issue can be tested with a snippet like this: class

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes a warning when built with Clang instead of MSVC. Repository: rLLDB LLDB https://reviews.llvm.org/D67860 Files:

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo created this revision. mstorsjo added reviewers: hhb, xen2, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. `__MINGW64__` is only defined for 64 bit targets, and the define without trailing underscores is never defined automatically (neither by clang

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo created this revision. mstorsjo added reviewers: asmith, labath, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes build errors like these: NativeRegisterContextWindows.h:22:33: error: extra qualification on member 'NativeRegisterContextWindows'

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo created this revision. mstorsjo added reviewers: lanza, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes MinGW builds, that otherwise fail due to use of undeclared `GetLastError()` and `ERROR_OPERATION_ABORTED`. The use of

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67859 Files: lldb/include/lldb/Host/Socket.h Index: lldb/include/lldb/Host/Socket.h

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, compnerd. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This silences warnings about comparison of integers between unsigned long long (which is what the Windows SOCKET type is) and signed int

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath, compnerd. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. SetErrorStringWithFormat only supports normal printf style format strings. Repository: rLLDB LLDB https://reviews.llvm.org/D67862

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo updated this revision to Diff 221122. mstorsjo added a comment. Use static_cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67863/new/ https://reviews.llvm.org/D67863 Files: lldb/source/Host/common/Socket.cpp lldb/tools/lldb-vscode/lldb-vscode.cpp Index:

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL372484: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL372485: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372486: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

This revision was automatically updated to reflect the committed changes. Closed by commit rL372482: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372483: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb. Herald added subscribers: JDevlieghere, abidh, mgorny. Herald added a project: LLDB. The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in anywhere. Current MSVC

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

This revision was automatically updated to reflect the committed changes. Closed by commit rL373144: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC. (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo added a comment. In D68134#1686970 , @thakis wrote: > We can add flags for omitting access specifiers etc if it's critical for > lldb. Or maybe we can just change the test that caused the revert. Yeah I doubt it's critical to maintain the

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo added a comment. In D68134#1687865 , @labath wrote: > In D68134#1687518 , @mstorsjo wrote: > > > In D68134#1687500 , @labath wrote: > > > > > I'm not sure what

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk, compnerd. Herald added subscribers: JDevlieghere, erik.pilkington. Herald added a project: LLDB. I'm unsure if there's any lldb testcase which exercise this directly (I didn't find any); such testcases could be made

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb, asmith. Herald added subscribers: JDevlieghere, abidh, kristof.beyls, mgorny. Herald added a project: LLDB. This seems to be enough for getting a backtrace and variable values for MinGW-built binaries for

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. These can appear in a different order depending on the relative layout of the source and build trees. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added subscribers: JDevlieghere, abidh, kristof.beyls. Herald added a project: LLDB. Add a test case for the change from SVN r372657, and for the preexisting ARM identification. Add a missing

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67952 Files: lldb/lit/Commands/command-script-import.test

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. > This seems to be enough for getting a backtrace and variable values for > MinGW-built binaries for ARM64. To clarify; this is binaries that use DWARF debug info. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL372700: [LLDB] Avoid warnings about redefining posix mode defines on MinGW (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372699: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

mstorsjo updated this revision to Diff 221276. mstorsjo retitled this revision from "[LLDB] Check for the __MINGW32__ define instead of __MINGW64" to "[LLDB] Remove a now redundant windows specific workaround". mstorsjo edited the summary of this revision. mstorsjo added a comment. Updated the

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. In D67885#1678701 , @MyDeveloperDay wrote: > Just as a drive by comment, there is code in > DebugInfo/Symbolize/Symbolize.cpp that loads dbghelp via #pragma > comment(lib... trick Yes, but as I mentioned in the patch

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo added a comment. In D67861#1678618 , @labath wrote: > Judging by the microsoft docs > , > `vsnprintf` is

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D67911#1679333 , @compnerd wrote: > What do you think of adding some sort of notification that hardware > breakpoints are currently unsupported and that we are falling back to >

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

This revision was automatically updated to reflect the committed changes. Closed by commit rL372656: [LLDB] Rework a MinGW build fix from D65691 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372658: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

This revision was automatically updated to reflect the committed changes. Closed by commit rL372657: [LLDB] [PECOFF] Recognize arm64 executables (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo added a comment. In D67911#1679696 , @compnerd wrote: > I think that `printf` is quite an amazing notification :-) Ok, I'll make it an `LLDB_LOG` then, as I'd presume using raw printfs isn't really allowed :-) Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo updated this revision to Diff 221406. mstorsjo added a comment. Added a log message, changed an `x86_64` ifdef into `_WIN64`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67911/new/ https://reviews.llvm.org/D67911 Files:

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

This revision was automatically updated to reflect the committed changes. Closed by commit rL372740: [LLDB] [test] Allow differing order of some matches (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

This revision was automatically updated to reflect the committed changes. Closed by commit rL372739: [LLDB] [test] Add a few missing cases of REQUIRES: python (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

This revision was automatically updated to reflect the committed changes. Closed by commit rL372741: [LLDB] Add tests for PECOFF arm architecture identification (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rL372738: [LLDB] Fix typo in RegisterContextDarwin_arm64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modulo watchpoints, which I > need to get around to reviewing). It

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo abandoned this revision. mstorsjo added a comment. D67887 was committed with the same change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67857/new/ https://reviews.llvm.org/D67857

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

mstorsjo added a comment. Just FTR, this was identical to D67857 that I posted a few days ago. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67887/new/ https://reviews.llvm.org/D67887

[Lldb-commits] [PATCH] D67942: Install python dll to bin

mstorsjo added a comment. Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67942/new/

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo updated this revision to Diff 222358. mstorsjo edited the summary of this revision. mstorsjo added a reviewer: thakis. mstorsjo added a comment. I tried to update the testcases based on the log output

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo reopened this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D68134#1687500 , @labath wrote: > In D68134#1687031 , @mstorsjo wrote: > > > In D68134#1686970

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added reviewers: labath, amccarth. mstorsjo added a comment. Good catch, thanks! But would we need to add something like `(void)result;` to silence potential compiler warnings about an unused (or set but not read) variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1714143 , @labath wrote: > In D69031#1714107 , @mstorsjo wrote: > > > In D69031#1713900 , @aprantl wrote: > > > > > Check out

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

mstorsjo added a comment. Yes, this definitely is a race condition. Without any changes, I triggered this condition on arm64, but not on x86_64. The issue is in the subclass ProcessWindows, where OnExitProcess does this: void ProcessWindows::OnDebuggerError(const Status , uint32_t type) {

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py

mstorsjo abandoned this revision. mstorsjo added a comment. This is no longer necessary since D69031 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980 ___

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. For the record, this was reapplied in rG1739c7c10c42748c278b0ea194e32bbfdd04fb98 (which Phabricator doesn't seem to have picked up on here) . Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added a comment. I presume you applied the patch with `arc patch`? It seems to apply the Phabricator username as git user, which is a bit odd, as it is customary to use realnames in the git author field. Earlier, when everything ended up mangled by svn, everything ended up normalized

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. llvm::object::createBinary returns an Expected<>, which requires not only checking the object for success, but also requires

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo updated this revision to Diff 227183. mstorsjo added a comment. Added a testcase based on @labath 's patch. (Thanks! That managed to trigger the condition!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69502/new/ https://reviews.llvm.org/D69502 Files:

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo created this revision. mstorsjo added reviewers: labath, zturner, amccarth, aleksandr.urakov. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. When running the lldb command line debugger in a console, it can be convenient to get the output of the debuggee inline in

[Lldb-commits] [PATCH] D70386: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70386 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo added a comment. Thanks for the excellent explanations of the situation so far. I'll have a look at how it behaves with input and other aspects of console sharing. You might be right that it can cause some issues, as I did run into cases where the main lldb console UI hung if the

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1765373 , @clayborg wrote: > So some background on how address masks are handled in LLDB: > > Typically the way we have tried to take care of the extra Thumb bit for ARM > using: > > lldb::addr_t

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D70848#1768730 , @labath wrote: > BTW, I don't know if you've noticed, but the new test is failing on windows: >

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1767049 , @labath wrote: > In D70840#1767028 , @mstorsjo wrote: > > > In D70840#1765373 , @clayborg > > wrote: > > > > > So some

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0f72441c898: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

mstorsjo added a comment. @labath does this one seem sensible and like what you suggested in D70848 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71108/new/ https://reviews.llvm.org/D71108

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1782951 , @clayborg wrote: > So my idea would be: > 1 - add all virtual functions to from lldb_private::Architecture as normal > members of ArchSpec. > 2 - have ArchSpec grap the the lldb_private::Architecture using

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763639 , @labath wrote: > - I think we ought to have some kind of a utility function to hold the logic > for the `&~1` stuff. there is something like that in > Architecture::GetOpcodeLoadAddress. The Architecture

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 233586. mstorsjo edited the summary of this revision. mstorsjo added a comment. Added ArchSpec::GetOpcodeLoadAddress() (didn't refactor Architecture to use it yet, so this is still duplicated code with the ArchitectureArm and ArchitectureMips plugins, but

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1767611 , @mstorsjo wrote: > In D70840#1767049 , @labath wrote: > > > In D70840#1767028 , @mstorsjo > > wrote: > > > > > In

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

mstorsjo created this revision. mstorsjo added reviewers: labath, clayborg. Herald added a project: LLDB. If not set, the address byte size was implied to be the one of the host process. This allows reverting the functional change from 31087b2ae9154, since now PECOFF does the same as ELF and

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable);

[Lldb-commits] [PATCH] D69226: [LLDB] [Windows] Initial support for ARM register contexts

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, asmith, amccarth. Herald added subscribers: llvm-commits, JDevlieghere, teemperor, delcypher, kristof.beyls, mgorny. Herald added projects: LLDB, LLVM. Repository: rLLDB LLDB https://reviews.llvm.org/D69226 Files:

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This can happen e.g. when unwinding doesn't work perfectly. Repository: rLLDB LLDB https://reviews.llvm.org/D69502

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This can e.g. happen if the debugged executable depends on unavailable DLLs. One could also return e.g. Status(ERROR_DLL_NOT_FOUND,

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1723385 , @aleksandr.urakov wrote: > LGTM, thank you! Can you send me an example of binary on which unwinding > fails with a crash, please? It is a very interesting case... It is on arm64, so it's not something that

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1723549 , @labath wrote: > Any way to get a test for this? Maybe creating a object file with a bogus > unwind RVA via yaml2obj ? Do we have a suitable test as basis for it? I'm not quite sure which way is the most

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1713900 , @aprantl wrote: > Check out `lldb/test/Shell/helper/toolchain.py`, you probably need to filter > out some options for clang_cl specifically. Yeah, I later found that. The issue is that it's passed to

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp:6 +// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s +// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

This revision was automatically updated to reflect the committed changes. Closed by commit rG13993a6f8681: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69226: [LLDB] [Windows] Initial support for ARM register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59444a35608: [LLDB] [Windows] Initial support for ARM register contexts (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69226/new/

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1714143 , @labath wrote: > In D69031#1714107 , @mstorsjo wrote: > > > In D69031#1713900 , @aprantl wrote: > > > > > Check out

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

mstorsjo added a comment. Looks and sounds good to me, although I'm not familiar with this code and its context yet - so I'm not sure if I'm qualified to formally approve it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/ https://reviews.llvm.org/D69100

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. I've happened to poke around a bit more in this piece of code now recently, and it does indeed seem reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709954 , @stella.stamenova wrote: > Both. Again, it's been a long time, but when we use VS for building, the > environment already contains a path to clang-cl so regardless of whether the > build is standalone or

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709931 , @labath wrote: > In D68980#1709884 , > @stella.stamenova wrote: > > > The two things that come to mind are the path to clang-cl (which is > > sometimes a clang build

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1710018 , @stella.stamenova wrote: > In D68980#1709967 , @mstorsjo wrote: > > > In D68980#1709931 , @labath wrote: > > > > > In

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py

mstorsjo updated this revision to Diff 225171. mstorsjo retitled this revision from "[LLDB] [test] Pass --target=-windows-msvc to clang-cl" to "[LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py". mstorsjo edited the summary of this revision. mstorsjo added a comment.

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo created this revision. mstorsjo added reviewers: labath, stella.stamenova, aleksandr.urakov, amccarth. Herald added subscribers: JDevlieghere, teemperor, abidh, kristof.beyls. Herald added a project: LLDB. This allows explicitly specifying the intended target architecture, for tests

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo updated this revision to Diff 224969. mstorsjo added a comment. Using newly added demangler options to (hopefully) avoid any changes to test outputs (at least the differences seen when applied earlier shouldn't be present any longer). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f6ba2a2ecd: [LLDB] [Windows] Initial support for ARM64 register contexts (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG674d55438d25: [LLDB] [PECOFF] Use a pc vendor name in aarch64 triples (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68939/new/

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo requested review of this revision. mstorsjo added a comment. Does anyone want to ack this one after updating it to not need changes to tests (as far as I know), by using new demangler options? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo created this revision. mstorsjo added reviewers: rnk, labath, amccarth, aleksandr.urakov. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. This fixes running check-lldb on arm linux. Previously the helper python scipt only passed -m32/-m64, but some

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

mstorsjo updated this revision to Diff 226216. mstorsjo added a comment. Updated the testcase to check for symbols in more than one section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69366/new/ https://reviews.llvm.org/D69366 Files:

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. The virtual container/header section causes the section list to be offset by one. Previously, symbols in the first section were given addresses in

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections

mstorsjo updated this revision to Diff 226321. mstorsjo retitled this revision from "[LLDB] [PECOFF] Fix symbols to refer to the right section" to "[LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections". mstorsjo edited the summary of this revision. mstorsjo added a comment.

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1725146 , @labath wrote: > In D69502#1723715 , @mstorsjo wrote: > > > In D69502#1723549 , @labath wrote: > > > > > Any way to get a test

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG4394b5bee615: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); mstorsjo wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1713532 , @aprantl wrote: > Probably this commit. Can you please revert or fix? Sorry about this, reverted it for now. I think the reason might be that %clang_cl ends up expanding to something (maybe `-isysroot`)

  1   2   3   4   5   >