[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. In https://reviews.llvm.org/D42955#1027142, @clayborg wrote: > Again, we need any objects coming out of the ObjectFile to have the correct > sections. Not sure how we would accomplish that with a solution where the > dSYM file uses it own useless sections. I think we h

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. In https://reviews.llvm.org/D42955#1026296, @labath wrote: > In https://reviews.llvm.org/D42955#1026216, @clayborg wrote: > > > AS for the ELF example where only debug info is around, it might not be > > running into issues if it doesn't contain a symbol table. If it do

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath abandoned this revision. labath added a comment. I don't think this approach is good while ObjectFileMachO is messing with sections of other object files. At this point I think, I've actually learned enough about MachO to understand what the code is doing there, so I'm going to see if I

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. In https://reviews.llvm.org/D42955#1026216, @clayborg wrote: > AS for the ELF example where only debug info is around, it might not be > running into issues if it doesn't contain a symbol table. If it does contain > a symbol table, hopefully it is using the unified secti

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. AS for the ELF example where only debug info is around, it might not be running into issues if it doesn't contain a symbol table. If it does contain a symbol table, hopefully it is using the unified section table, otherwise if might have symbol's whose addresses have s

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. In https://reviews.llvm.org/D42955#1026197, @labath wrote: > In https://reviews.llvm.org/D42955#1026175, @clayborg wrote: > > > The dSYM file is a mach-o file that contains symbols only, It is because > > the dSYM file (stand alone debug info file) has all of the sectio

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. In https://reviews.llvm.org/D42955#1026175, @clayborg wrote: > The dSYM file is a mach-o file that contains symbols only, It is because the > dSYM file (stand alone debug info file) has all of the section definitions > from the main executable, but no section content for

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. In https://reviews.llvm.org/D42955#1026116, @labath wrote: > I can try to split the patch up a bit if you think it will make things > easier. I'm not sure how much I will be able to do that, as the patch is not > that big, it just needs to touch a bunch of files for t

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. I can try to split the patch up a bit if you think it will make things easier. I'm not sure how much I will be able to do that, as the patch is not that big, it just needs to touch a bunch of files for the changed interfaces. In https://reviews.llvm.org/D42955#1026061,

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine, a bit hard to tell exactly what is going on so I will accept as long as the following things are still true: - each lldb_private::ObjectFile has its own section list that perfe

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath requested review of this revision. labath added a comment. Explicitly requesting re-review to make sure this is on your radar. We have a new patch that would benefit from this, but if this is not ready to go in yet (it's a turned into a fairly big refact

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath updated this revision to Diff 135975. labath added a comment. Remove the changes to source/Plugins/SymbolVendor/CMakeLists.txt that snuck in (I was experimenting with enabling the plugin on non-mac systems, but realized that's not possible right now). https://reviews.llvm.org/D42955 File

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath updated this revision to Diff 135971. labath added a comment. Herald added subscribers: JDevlieghere, mgorny. This version moves the logic for the building of unified section list into the symbol vendor plugin. The idea was to keep the construction of section lists of individual object fil

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: source/Core/Module.cpp:1283-1284 if (!m_sections_ap) { -ObjectFile *obj_file = GetObjectFile(); -if (obj_file != nullptr) +if (ObjectFile *obj_file = GetObjectFile()) obj_file->CreateSections(*GetUnifiedSectionList()

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added a comment. Back from vacation, sorry for the delay. Only one question on who is actually responsible for creating the sections. I vote to let SymbolVendor::CreateSection() always do the work. Let me know what you think. Comment at: source/Core/Module.cpp:1283-1

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } ---

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added a comment. Greg, with my last comment in mind, how do you feel about this patch? https://reviews.llvm.org/D42955 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } clayborg wrote: > should we pass "obj_file" down into the SymbolVendor::CreateSe

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added inline comments. Herald added a subscriber: arichardson. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } should we pass "obj_file" down into th

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: tools/lldb-test/lldb-test.cpp:75 ModuleSpec Spec{FileSpec(File, false)}; -Spec.GetSymbolFileSpec().SetFile(File, false); The expliciting symbol filespec setting was short-circuiting the regular search process.

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath created this revision. labath added reviewers: clayborg, jingham, davide. Herald added a subscriber: emaste. The result of Module::GetSectionList depended on whether the symbol vendor has been loaded (which would augment the section list with the extra sections that have been found by the v