Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/21/17 17:27, Honnappa Nagarahalli wrote: Hi Maxim, This is a new file added by us. Hence the ARM copyright. Thanks, Honnappa Was this work done as Linaro member/assignee? If yes - it has to have Linaro copyright as I know. Maxim. On 21 June 2017 at 09:06, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/19/17 22:12, Brian Brooks wrote: Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 309 +++ 2 files

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/19/17 22:12, Brian Brooks wrote: --- /dev/null +++ b/platform/linux-generic/include/odp_llqueue.h @@ -0,0 +1,309 @@ +/* Copyright (c) 2017, ARM Limited. + * All rights reserved. + * + * SPDX-License-Identifier:BSD-3-Clause + */ + Has to be Linaro copyright. Maxim.

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

On 06/13/17 17:44, Joe Savage wrote: Any progress on this, Maxim? Merged! Maxim.

Re: [lng-odp] [PATCH v3 3/3] travis: enable tests when make distcheck

On 06/21/17 11:00, Github ODP bot wrote: From: Yi He Make distcheck with all test configurations to confirm test programs installation in odp distribution package. Signed-off-by: Yi He --- /** Email created from pull request 35 (heyi-linaro:install-check)

Re: [lng-odp] [PATCH v2 2/2] travis: enable samples and tests when make distcheck

Yi, how about something like: diff --git a/.travis.yml b/.travis.yml index 50b3b9c2..3d641209 100644 --- a/.travis.yml +++ b/.travis.yml @@ -139,6 +139,13 @@ jobs: - ./configure - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make

Re: [lng-odp] [PATCH v2 2/2] travis: enable samples and tests when make distcheck

No, that patch is not correct. Take a look at top level Makefile.am: AM_DISTCHECK_CONFIGURE_FLAGS = --enable-test-cpp \ --enable-test-perf \ --enable-test-vald \ --with-testdir parameters to configure are

Re: [lng-odp] [PATCH] arch: arm: add CPU global time

Merged, Maxim. On 06/08/17 07:04, Bill Fischofer wrote: > On Wed, Jun 7, 2017 at 10:46 PM, Brian Brooks wrote: >> Expose ARMv8 Generic Timer through internal CPU global time functions. >> >> Signed-off-by: Brian Brooks > > Reviewed-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

Does anybody wants to add his review to this patch? According to call a lot of people needed this patch but no review provided. Maxim. On 06/19/17 15:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> I think queue_t should be removed completely. We should just use >> odp_queue_t for internal

Re: [lng-odp] [API-NEXT PATCH v8 0/5] A scalable software scheduler

please add CI commit to current serries on next update. On 19 June 2017 at 19:09, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Travis found a bug: > > https://travis-ci.org/muvarov/odp/jobs/243801892 > > In file included from > ../../../platform/linux-generic/include

Re: [lng-odp] [API-NEXT PATCH v8 0/5] A scalable software scheduler

Travis found a bug: https://travis-ci.org/muvarov/odp/jobs/243801892 In file included from ../../../platform/linux-generic/include/odp_schedule_scalable.h:15:0, from ../../../platform/linux-generic/include/odp_queue_scalable_internal.h:24, from

[lng-odp] v1.15.0.0 released

Hello, development release v1.15.0.0 has been tagged in the repo. Please find the detailed log bellow. While writing these lines I see that number of bugs are already fixed and are part of current release. Since current release we significantly improved our testing with Travis CI integrated to

Re: [lng-odp] [PATCH] linux-gen: makefile: fix out of tree build

Patch breaks native build. I had to test it before apply :( On 19 June 2017 at 17:16, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Merged. > > On 19 June 2017 at 17:12, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > >> For this patch: >> >

Re: [lng-odp] [PATCH] linux-gen: makefile: fix out of tree build

Merged. On 19 June 2017 at 17:12, Bill Fischofer <bill.fischo...@linaro.org> wrote: > For this patch: > > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > > On Mon, Jun 19, 2017 at 8:12 AM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > > t

Re: [lng-odp] [PATCH] linux-gen: makefile: fix out of tree build

top_builddir alphabetical before top_srcdir. But here I'm ok with current change. Bill, review + ? Maxim. On 19 June 2017 at 14:58, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: Bill Fischofer

Re: [lng-odp] [PATCH] linux-gen: makefile: fix out of tree build

it should. top chunk is good, but chunk bellow is not. On 19 June 2017 at 13:30, Bill Fischofer wrote: > On Mon, Jun 19, 2017 at 3:25 AM, Petri Savolainen > wrote: > > Generated files need $(top_builddir) instead of $(top_srcdir) > > > >

Re: [lng-odp] [API-NEXT PATCH v7 0/5] A scalable software scheduler

On 06/14/17 04:21, Brian Brooks wrote: > Brian Brooks (5): > test: odp_pktio_ordered: add queue size > Add arch/ files > Add a bitset > Add a concurrent queue > Add scalable scheduler Please rename commits with existence commit style. Has to be: linux-gen: sched scalable: addr arch

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

On 06/15/17 11:50, Dmitry Eremin-Solenikov wrote: > On 15.06.2017 11:47, shally verma wrote: >> Does it mean that going further there would be certain limitation on >> gcc version to be used? I just tried to compile next branch and >> ./configure throws an error >> >> ./configure: line 22786:

Re: [lng-odp] [NEXT PATCH] changelog: add bug 3039 to list of bug fixes for v1.15

Merged. Maxim. On 06/14/17 20:12, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > CHANGELOG | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/CHANGELOG b/CHANGELOG > index 25e90347..866e51e9 100644 > --- a/CHANGELOG > +++ b/CHANGELOG > @@

Re: [lng-odp] [PATCH v5 0/2] GCC 7 fixes

uh, this needs to be tested before submitting. If autoconf-archive is not installed there is error: ./configure: line 22658: syntax error near unexpected token `-Wimplicit-fallthrough=0,' ./configure: line 22658: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,' I think that needs to be

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

On 06/13/17 17:44, Joe Savage wrote: > Joe, > > can you please make it work with clang? I sent a patch to ml before. It > might still apply, so you can review it. > https://travis-ci.org/muvarov/odp/jobs/223572921 > > the goal is to find good combination of -mcx16 and

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: add additional doxygen doc for time type

Merged. On 06/03/17 00:26, Dmitry Eremin-Solenikov wrote: > On 03.06.2017 00:24, Bill Fischofer wrote: >> Latest doxygen requires all items to be documented so add doxygen for >> enclosing union around variant time types. >> >> Signed-off-by: Bill Fischofer > >

Re: [lng-odp] [PATCH] Fixes for GCC 7

On 06/02/17 18:36, Brian Brooks wrote: > On 06/02 15:07:48, Maxim Uvarov wrote: >> I think this patch has to be spit on several patches. Having patch which >> correct unrelated things is strange and make it hard to merge/cherry-pick. > > They are all related to things

Re: [lng-odp] Release needed

lenikov <dmitry.ereminsoleni...@linaro.org> > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > > This is part of IPsec which isn't ready for release yet. > > On Fri, Jun 2, 2017 at 1:38 PM, Bill Fischofer > <bill.fischo...@linaro.org> wrote: &

Re: [lng-odp] Release needed

w IPSEC event type. > > Signed-off-by: Petri Savolainen <petri.savolai...@linaro.org> > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > Signed-off-by: Maxim

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On 06/02/17 12:44, Elo, Matias (Nokia - FI/Espoo) wrote: >>> >>> /** >>> + * System huge page sizes in bytes >>> + * >>> + * Returns the number of huge page sizes supported by the system. Outputs >>> up to >>> + * 'num' sizes when the 'size' array pointer is not NULL. If return value >>> is >>>

Re: [lng-odp] [PATCH] Fixes for GCC 7

I think this patch has to be spit on several patches. Having patch which correct unrelated things is strange and make it hard to merge/cherry-pick. Maxim. On 06/02/17 10:39, Dmitry Eremin-Solenikov wrote: > On 01.06.2017 22:05, Brian Brooks wrote: >> Signed-off-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On 06/01/17 13:52, Matias Elo wrote: > A system may simultaneously support multiple huge page sizes. Add a new API > function odp_sys_huge_page_size_all() which returns all supported page > sizes. odp_sys_huge_page_size() stays unmodified to maintain backward > compatibility. > > Signed-off-by:

Re: [lng-odp] Need session on GitHub

Honnoppa, sorry had ugent things to do today. Please take a look at this first. https://help.github.com/articles/about-pull-requests/ https://help.github.com/articles/creating-a-pull-request/ Please ping me tomorrow in HO I will try to help. Maxim. On 29 May 2017 at 19:07, Honnappa

Re: [lng-odp] [PATCH 0/3] Fix pktio with single segment packet pool

it? > done. > For this series: > > Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > merged. Maxim. > On Wed, May 24, 2017 at 9:40 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> if it is useful case let's add this test to .travis.yaml >&g

Re: [lng-odp] [PATCH v2 1/1] travis: use pkg-config to discover ODP flags

something like --- a/pkgconfig/libodp-linux.pc.in +++ b/pkgconfig/libodp-linux.pc.in @@ -6,6 +6,6 @@ includedir=@includedir@ Name: libodp-linux Description: The ODP packet processing engine Version: @PKGCONFIG_VERSION@ -Libs: -L${libdir} -lodp-linux +Libs: -L${libdir} -lodp-linux @LIBS@

Re: [lng-odp] Release needed

Ok, thanks for details. I will try to prepare release according to your list on this week. On 24 May 2017 at 10:38, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > It's already two months since 1.14 release. We have again missed the > target of a release per

Re: [lng-odp] api-next branch broken?

On 05/20/17 01:07, Bill Fischofer wrote: > Something is clearly going on as I'm seeing the pktio/pktio_ipc_run.sh > script suddenly start failing for completely unrelated changes. > Can you reproduce it manually? I can not reproduce it locally and here looks like it passed for the latest code

Re: [lng-odp] [PATCH API-NEXT v5 10/11] linux-generic: ipsec: draft IPsec implementation

On 05/16/17 19:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > For now it's only a preview with the following limitation: > - No inbound inline processing support > - Only IPv4 support > - No zeroing of mutable IPv4 options for AH ICV

Re: [lng-odp] [PATCH v1 1/1] configure.ac: fix mcx16 vs clang check

On 05/12/2017 03:00 AM, Github ODP bot wrote: From: Dmitry Eremin-Solenikov Currently configure script outputs the following error on my sistem, because the syntax is far from being standard. Use standard case/esac instead. ./configure: line 23507:

Re: [lng-odp] [PATCH] helper: tables: avoid invalid odp_shm_addr() calls

On 05/11/2017 03:06 PM, Elo, Matias (Nokia - FI/Espoo) wrote: Patch itself is ok, it might be reasonable to rewrite the latest chunk in more readable way (if you already touched that chunk): Instead of: shm = odp_shm_lookup(name); if (shm != ODP_SHM_INVALID) hash_tbl =

Re: [lng-odp] odp_packet_free_multi with invalid packets

On 05/10/2017 09:00 PM, Dmitry Eremin-Solenikov wrote: On 10.05.2017 20:57, Maxim Uvarov wrote: On 05/10/2017 08:14 PM, Dmitry Eremin-Solenikov wrote: On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun

Re: [lng-odp] odp_packet_free_multi with invalid packets

On 05/10/2017 08:14 PM, Dmitry Eremin-Solenikov wrote: On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry Eremin-Solenikov Sent: Wednesday, May 10, 2017 8:00 PM To:

Re: [lng-odp] [PATCH v2 1/1] linux-gen: tm: fix wrr/wfq bug when weight=1

Bill, you clicked to review on github page, can you please write review by in email if reviewed? Also one comment bellow. On 05/04/2017 01:00 PM, Github ODP bot wrote: From: Dmitriy Krot Usage of 0x1 in the inverted weight calculation causes overflow of uint16_t if

Re: [lng-odp] [API-NEXT PATCH 2/3] api: ipsec: add capability for max packets per result event

On 05/05/2017 11:55 PM, Dmitry Eremin-Solenikov wrote: On 05.05.2017 15:34, Petri Savolainen wrote: Added maximum number of packets per result event to make it easy for application to prepare enough storage for packets. I'm still not sure that this is a good idea. It will be good to get

Re: [lng-odp] [PATCH] helper: tables: avoid invalid odp_shm_addr() calls

On 05/05/2017 03:49 PM, Matias Elo wrote: odp_shm_lookup() return value can be used to detect name conflicts. Signed-off-by: Matias Elo --- helper/hashtable.c | 3 +-- helper/lineartable.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [lng-odp] [PATCH] Revert "travis: add code style checks"

th giving that one a go before pulling the plug? > I will check if it fixes some latest patches in api-next. Also I think maybe for CamelCase have some list of regexp functions which we accept like Cunit, SSL. And not all functions. Maxim. > On Thu, May 4, 2017 at 2:03 PM, Maxim Uvarov

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 05/03/17 17:06, Dmitry Eremin-Solenikov wrote: > On 03.05.2017 17:00, Github ODP bot wrote: >> From: Dmitry Eremin-Solenikov >> >> Both tunnel and lookup parameters refer IP protocol version. Factor that >> out as an IPsec enum used in both places. >> >>

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 05/03/17 19:18, Dmitry Eremin-Solenikov wrote: > On 03.05.2017 19:00, Github ODP bot wrote: >> From: Dmitry Eremin-Solenikov >> >> Both tunnel and lookup parameters refer IP protocol version. Factor that >> out as an IPsec enum used in both places. > >

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 05/02/17 14:43, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of maxim >> Sent: Tuesday, May 02, 2017 1:06 PM >> To: lng-odp@lists.linaro.org >> Subject: Re: [lng-odp] [API-NEXT PATCH v2 0/4]

Re: [lng-odp] [API-NEXT PATCH] api: packet: introduce odp_packet_data_range_t

Shally, I'm ok to merge it as soon as we will get agreement from everybody. For this patches we need Dmitry review as he started to work on it and Petri as api gate keeper. Maxim. On 2 May 2017 at 11:33, Verma, Shally wrote: > Hi Dmitry > > We are okay with proposed

Re: [lng-odp] Modular queue interface

I think that If vendors are going to ship several variants of schedulers then we need api to switch between them. If there will be only one scheduler then we can add getenv() variant of selection to linux-generic and test all of them. Maxim. On 2 May 2017 at 11:10, Savolainen, Petri (Nokia -

[lng-odp] github web hook updated

Updated github web hook: Changes: Now on merge request topic (title) of merge request automatic changed to: [PATCH vX] title or [PATCH API-NEXT vX] title where: title is how you named this merge request. X - is auto increment of version. I.e. if merge request was created from branch

Re: [lng-odp] Regarding how ODP closes scheduled PKTIOs

Correct steps are: 1. odp_pktio_stop() 2. flush queues (or with call to odp_schedule() while there are packets, or odp_queue_dequeue()). 3. odp_pktio_close(). I.e. when you call close() all queues have to be empty. Maxim. On 2 May 2017 at 06:01, Bill Fischofer wrote:

Re: [lng-odp] [API-NEXT PATCH v3 01/11] api: time: remove odp_time_to_u64 from API

On 04/28/17 22:09, Bill Fischofer wrote: > I agree that the validation test for odp_time_to_u64() is suspect and > should be fixed, but why remove this API? We've established that various > abstract types have odp_xxx_to_u64() routines designed for debugging use > and this makes odp_time_t an

[lng-odp] [PATCHv2 2/2] test: pktio_run: exit if binary was not found

No need to continue run if binary was not found in paths. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- test/linux-generic/validation/api/pktio/pktio_run.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/linux-generic/validation/api/pktio/pktio_run.sh b/test/linux-g

[lng-odp] [PATCHv2 1/2] test: tm: add paths to find tm binary

Use the same algorithm as pktio_run.sh to find paths in different cases (in tree build, out of tree build, distcheck and etc). Fixes: https://bugs.linaro.org/show_bug.cgi?id=2969 Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v2: fix Matias comments .../validation/api/traffi

Re: [lng-odp] [PATCH 1/2] test: tm: add paths to find tm binary

Petri, is that fixes your problem? Can you provide review to I can apply it? Thank you, Maxim. On 26 April 2017 at 12:00, Github ODP bot <odp...@yandex.ru> wrote: > From: Maxim Uvarov <maxim.uva...@linaro.org> > > Use the same algorithm as pktio_run.sh to find paths

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/26/17 12:40, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> odp_sched_latency currently uses clock_gettime. It is my understanding >>> that clock_gettime does not have the over head of the system call. Can >>> you elaborate more on the 'improved significantly' part? >>> >> >> clock_gettime()

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On 04/26/17 17:27, Dmitry Eremin-Solenikov wrote: > On 26.04.2017 17:06, Codecov wrote: >> Impacted Files >> Coverage Δ >> test/common_plat/validation/api/packet/packet.c >>

Re: [lng-odp] make check FAILS on TM test

sending patch for that... On 26 April 2017 at 09:46, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > 'make check' fails now on both master and api-next. > > > FAIL: ../../test/common_plat/validation/api/traffic_mngr/traffic_mngr >

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/25/17 21:51, Brian Brooks wrote: > On 04/25 12:25:03, Brian Brooks wrote: >> On 04/24 08:07:58, Savolainen, Petri (Nokia - FI/Espoo) wrote: > diff --git a/platform/linux-generic/arch/x86/odp_cpu_arch.c b/platform/linux-generic/arch/x86/odp_cpu_arch.c > index c8cf27b6..9ba601a3

Re: [lng-odp] [API-NEXT PATCH v2 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

On 25 April 2017 at 09:59, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Maxim > > Uvarov > > Sent: Monday,

Re: [lng-odp] [API-NEXT PATCH v2 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

ERROR: Macros with complex values should be enclosed in parentheses #239: FILE: platform/linux-generic/arch/x86/cpu_flags.c:172: +#define FEAT_DEF(name, leaf, subleaf, reg, bit) \ + [RTE_CPUFLAG_##name] = {leaf, subleaf, reg, bit, #name }, CHECK: architecture specific defines should be

Re: [lng-odp] [PATCH] test: tm: use script instead of binary when calling traffic manager test

That was merged, Maxim. On 20.04.2017 19:09, Bill Fischofer wrote: > On Wed, Apr 19, 2017 at 7:00 PM, Github ODP bot wrote: > >> From: Dmitry Eremin-Solenikov >> >> Since 51e3b8776b78180741fa57a621f9d13b9ae8bbfb tm test received wrapper >>

Re: [lng-odp] [API-NEXT PATCH 3/8] linux-gen: system: implement system info print

On 24.04.2017 10:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> + >>> +void odp_sys_info_print(void) >>> +{ >>> + printf("\n" >>> + "ODP system info\n" >>> + "---\n" >>> + "ODP API version: %s\n" >>> + "ODP impl name:

Re: [lng-odp] pcap file discovery

On 21 April 2017 at 00:25, Brian Brooks wrote: > In test/common_plat/performance/odp_pktio_ordered_run.sh > > PCAP_IN=`find . ${TEST_SRC_DIR} $(dirname $0) -name udp64.pcap -print > -quit` > > It looks like this script is run from workspace root when you do a > "make

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

On 04/20/17 19:12, Bill Fischofer wrote: > On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > >> Add proper handling for errors returned by odp_packet_copy_from_pkt(). >> >> Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] shmem pool APIs

On 04/20/17 21:54, Bill Fischofer wrote: > On Thu, Apr 20, 2017 at 12:26 PM, Honnappa Nagarahalli < > honnappa.nagaraha...@linaro.org> wrote: > >> Hi, >>I looked at the shmem pool APIs for allocating smaller chunks of >> shared memory. Following are the APIs I am looking at: >> >>

Re: [lng-odp] Patches to merge from V2 of scalable scheduler

I merged bunch of patches, please check. There have to be email from github. Maxim. On 20 April 2017 at 18:43, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Hi Maxim, > Any update on merging these patches to API-NEXT? > > Thank you, > Honnappa > > On 18 April 2017 at

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

On 04/19/17 19:15, Joe Savage wrote: >> Joe, >> >> can you please make it work with clang? I sent a patch to ml before. It >> might still apply, so you can review it. >> https://travis-ci.org/muvarov/odp/jobs/223572921 >> >> the goal is to find good combination of -mcx16 and -latomic flags. And >>

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

Joe, can you please make it work with clang? I sent a patch to ml before. It might still apply, so you can review it. https://travis-ci.org/muvarov/odp/jobs/223572921 the goal is to find good combination of -mcx16 and -latomic flags. And we need to test that it still works on arm due to there is

Re: [lng-odp] [API-NEXT v5] api: ipsec: factor out definitions for feature support levels

Dmitry, please name patches as API-NEXT PATH v5, not as API-NEXT. Maxim. On 19.04.2017 16:41, Dmitry Eremin-Solenikov wrote: > Instead of having magic 0-1-2 numbers, let's have the special enum for > feature support levels (unsupported/supported/preferred). > > Signed-off-by: Dmitry

Re: [lng-odp] [API-NEXT v4] api: ipsec: factor out definitions for feature support levels

On 19 April 2017 at 10:42, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > Maxim, > > Why this API change is now in api-next *without* by review? > > We discussed that on meeting and everybody said that it is good improvement and we need to apply that. >

Re: [lng-odp] [PATCH v3] build: fix native Clang build on ARMv8

Brian, where I can take arm clang to test this patch? Thanks, Maxim. On 19 April 2017 at 00:09, Brian Brooks wrote: > The build is broken when using clang on ARM. -mcx16 is being passed to > clang when building natively on ARM. This combined with -Werror causes > the

Re: [lng-odp] [PATCH] test: tm: skip tm result under travis run

test to make code coverage happy and check that there is no critical error i.e. segfault. If test does not fit in low/high acceptable borders for tm time slots then mark test as skipped due to not isolated environment Travis CI. Maxim. > On Tue, Apr 18, 2017 at 11:27 AM, Maxim Uvarov <maxim

Re: [lng-odp] [PATCH] examples: generator: UDP ports configuration

On 04/12/17 15:54, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/example/generator/odp_generator.c >

Re: [lng-odp] [PATCH] test: tm: skip tm result under travis run

ping. If people do not want to see any entries for CI env in test suite code then I can make this patch be applied on each Travis run. If it's good I need a review. Some times this test fails. On 6 April 2017 at 17:39, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Please review this

Re: [lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

make distcheck fails: In file included from ../../../platform/linux-generic/include/protocols/ip.h:20:0, from ../../../platform/linux-generic/include/odp_classification_datamodel.h:28, from ../../../platform/linux-generic/include/odp_packet_io_internal.h:23,

Re: [lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

Petri, ok? Maxim. On 04/15/17 07:19, Bala Manoharan wrote: > Reviewed-by: Balasubramanian Manoharan > > > On 15 April 2017 at 07:18, Dmitry Eremin-Solenikov > wrote: >> Instead of having magic 0-1-2 numbers, let's have the special

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

merged. Maxim. On 04/13/17 19:08, Bala Manoharan wrote: For the series: Reviewed-by: Balasubramanian Manoharan On 13-Apr-2017, at 9:13 PM, Honnappa Nagarahalli wrote: For this series: Reviewed-by: Honnappa Nagarahalli

Re: [lng-odp] [PATCH] linux-gen: set errno = 0 before mmap

Why not just set errno to 0 in the success case? On 04/13/17 17:05, Oriol Arcas wrote: > Fixes bug #2921. > > During odp_shm_reserve() mmap is tried with huge pages, and if it fails, > without huge pages. The first call leaves errno set, which can confuse > the client app. > > In general, errno

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

13.04.2017 15:31, Dmitry Eremin-Solenikov wrote: On 13.04.2017 15:26, Bill Fischofer wrote: On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: I vote for default build will not build with deprecating support. Yes all general propose distributives wil

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

I vote for default build will not build with deprecating support. Yes all general propose distributives will need to enable --enable-deprecated-api to support some old software. But developers who work with git should not work with deprecated api. Maxim. On 13 April 2017 at 13:57, Dmitry

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 13 April 2017 at 13:49, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > ODP is about HW abstraction and CPU instructions are HW features. Of > > course, > > > applications are free to use other libs/APIs/GCC features, but should > > our > > > examples

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 13.04.2017 12:55, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Joe Savage [mailto:joe.sav...@arm.com] >> Sent: Thursday, April 13, 2017 11:57 AM >> To: Savolainen, Petri (Nokia - FI/Espoo) > labs.com>; Dmitry

Re: [lng-odp] [PATCH] example: l3fwd: check rc from odph_eth_addr_parse()

On 04/06/17 00:16, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking > the return code from odph_eth_addr_parse() and failing the call if > dst_mac is unparseable. > > Signed-off-by: Bill Fischofer > --- >

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 13:15, Joe Savage wrote: The problem is that when we discussed this patch on ODP call people very worry about having 128bit instructions in ODP examples. At least Petri and Barry asked if it would be possible to rewrite that with 64 bit instructions? Some

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

Brian, can you please resend all patches as new version of patch set. Not embed them into current email thread. I think it will be more easy for second review. Maxim. On 04.04.2017 21:48, Brian Brooks wrote: > Remove erroneous assertion that is handled in later code > > Signed-off-by: Kevin

Re: [lng-odp] [API-NEXT PATCHv2 00/23] driver items registration and probing

On 04/11/17 17:06, Yi He wrote: > Hi, team > > Today in odp cloud meeting we talked about the DDF status, before the new > LNG colleague joining to take over the DDF works, I'll take the ownership > of the DDF and continue to move this patch series forward and related bugs, > comments. > > This

Re: [lng-odp] [PATCH v3 1/2] api: queue: added queue size param

Petri, whom review is needed for that? Maxim. On 11 April 2017 at 09:29, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > Ping. Spec for queue size and capability. > > > > -Original Message- > > From: lng-odp

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

Merged, Maxim. On 04/10/17 15:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, April 07, 2017 3:53 PM >> To: Peltonen, Janne (Nokia - FI/Espoo)

Re: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

iginal Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Maxim > > Uvarov > > Sent: Monday, April 10, 2017 3:43 PM > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt >

[lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

From: Dmitry Eremin-Solenikov It does not make sense to specify negative amount inside num_*. Make respective fields unsigned instead. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 13

[lng-odp] [PATCH] example:ipsec_offload: Adding ipsec_offload example

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- /** Email created from pull request 12 (NikhilA-Linaro:api-next) ** https://github.com/Linaro/odp/pull/12 ** Patch: https://github.com/Linaro/odp/pull/12.patch ** Base sha:

Re: [lng-odp] [PATCH] linux-gen: packet: add pkt_to_buffer_hdr() function

Yes, also patch should pass code coverage. That is set on github and it should warn that there are function which are not used marked with red color. We are trying to remove all not used functions from the code. So that should go with code where it's used. Maxim. On 10 April 2017 at 13:20,

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

I forget to note that it will be great to update .travis file for testing new option. Maxim. On 04/04/17 21:47, Brian Brooks wrote: > This work derives from Ola Liljedahl's prototype [1] which introduced a > scalable scheduler design based on primarily lock-free algorithms and > data structures

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: spi_overlap and lookup modes

Merged this patch. Maxim. On 04/07/17 15:47, Bill Fischofer wrote: > On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen > wrote: >> Lookup modes are per SA and thus may be used in a mix. Spi_overlap >> parameter is global. So, removed comment about ignoring it in >>

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

I'm ok with this patch. That can go to master, not need for api-next. Maxim. On 04/06/17 20:09, Brian Brooks wrote: > On 04/05 01:24:44, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 23:34, Brian Brooks wrote: >>> On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote: On 04.04.2017 23:26,

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 04/06/17 13:35, Ola Liljedahl wrote: > On 5 April 2017 at 23:39, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> On 04/05/17 17:30, Ola Liljedahl wrote: >>> On 5 April 2017 at 14:50, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >>>> On

Re: [lng-odp] [PATCH] test: tm: skip tm result under travis run

Please review this patch. TM very often fails in Travis CI. This patch has to fix it. Maxim. On 31 March 2017 at 23:39, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > tm test fails time to time in Travis environment. Because > of we can not control that machine we can not do

Re: [lng-odp] [API-NEXT PATCH v2 2/4] linux-gen: packet: remove lazy parsing

I merged v2 for that to api-next. Initially I applied to master not to api next. Please check that patches are merged. Maxim. On 5 April 2017 at 09:03, Elo, Matias (Nokia - FI/Espoo) < matias@nokia-bell-labs.com> wrote: > > > > > On 4 Apr 2017, at 18:30, Ma

[lng-odp] [PATCH] example:ipsec_offload: Adding ipsec_offload example

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- /** Email created from pull request 8 (NikhilA-Linaro:master) ** https://github.com/Linaro/odp/pull/8 ** Patch: https://github.com/Linaro/odp/pull/8.patch ** Base sha:

[lng-odp] [PATCH 1/8] validation: crypto: add tests for checking message digests

From: Dmitry Eremin-Solenikov Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry

[lng-odp] [PATCH] linux-generic: debug: enable helper use from c++ programs

From: Bill Fischofer The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when used in C++ programs this needs to expand to static_assert(). This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2852 Reported-by: Moshe Tubul

<    1   2   3   4   5   6   7   8   9   10   >