Re: [lng-odp] measuring time and/or cycles

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> That is why CPU ISAs provide a timer that increments at a constant rate > (fixed frequency). It is not bound to the core's clock frequency. If the > core's frequency adjusts dynamically you can no longer use cycle counter > to measure time. If the core's frequency is fixed, it's still not >

Re: [lng-odp] [PATCH v3 0/8] First ABI files

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Yi He [mailto:yi...@linaro.org] Sent: Tuesday, February 14, 2017 3:59 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: Brian Brooks <brian.bro...@linaro.org>; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v3 0/8] First ABI file

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Wednesday, February 15, 2017 11:40 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Mike Holmes <mike.hol

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Monday, February 13, 2017 5:41 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Mike Holmes <mike.hol...@linaro.org>;

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Monday, February 13, 2017 5:02 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: lng-odp <lng-odp@lists.linaro.org> Subject: Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_e

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Friday, February 10, 2017 5:02 PM To: Petri Savolainen Cc: lng-odp Subject: Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers On 3 February 2017 at

Re: [lng-odp] Packet references API

2017-02-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > I'll send an API and validation test updates (for option 1)) with simple > copy style implementation. > > It's not clear why we need a copy style implementation given that we > have a zero-copy implementation. While it's good to discuss this as an > option in the ODP implementation guide, as

Re: [lng-odp] Packet references API

2017-02-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Friday, February 10, 2017 12:46 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng

[lng-odp] Packet references API

2017-02-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, I still think that packet ref API should be defined so that an implementation may fall back to doing packet copy instead of reference to shared data (if it simply cannot handle packets by reference). Now after implementing packet ref API as copy (in about 90 lines), only issues are with

Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio driver print out

2017-02-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, February 07, 2017 2:10 AM > To: Petri Savolainen > Cc: lng-odp-forward > Subject: Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio

Re: [lng-odp] [PATCH 03/10] linux-gen: packet: packet handle is hdr pointer

2017-02-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, February 07, 2017 2:05 AM > To: Petri Savolainen > Cc: lng-odp-forward > Subject: Re: [lng-odp] [PATCH 03/10] linux-gen: packet: packet

Re: [lng-odp] [PATCH 05/10] validation: packet: print reason for suite init failure

2017-02-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Monday, February 06, 2017 5:05 PM > To: Mike Holmes <mike.hol...@linaro.org> > Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; lng

Re: [lng-odp] [PATCH 05/10] validation: packet: print reason for suite init failure

2017-02-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Monday, February 06, 2017 4:41 PM > To: Maxim Uvarov > Cc: lng-odp > Subject: Re: [lng-odp] [PATCH 05/10] validation:

Re: [lng-odp] [PATCH 05/10] validation: packet: print reason for suite init failure

2017-02-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Monday, February 06, 2017 4:34 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 05/10] validation: packet: print reason for > suite init failure > > On

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, February 03, 2017 3:37 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: LNG ODP Mailman List <lng-odp@lists.lina

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, February 03, 2017 2:29 PM > To: Petri Savolainen > Cc: LNG ODP Mailman List > Subject: Re: [lng-odp] [PATCH 1/2] helper: linux:

Re: [lng-odp] [PATCH v4 0/8] First ABI files

2017-02-02 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. I have next patch set ready (for packet accessor function inline), just waiting for this to be merged first. -Petri > -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Wednesday, February 01, 2017 3:11 AM > To: Petri Savolainen

Re: [lng-odp] [PATCH 0/5] Add ABI compatibility to helper lib

2017-02-02 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Thursday, February 02, 2017 2:39 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 0/5] Add ABI compatibility to helper lib On 2 Februar

Re: [lng-odp] [PATCH 0/5] Add ABI compatibility to helper lib

2017-02-02 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Wednesday, February 01, 2017 3:14 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 0/5] Add ABI compatibility to helper lib > > Reusing the mechanism used for

Re: [lng-odp] [PATCH v3 0/8] First ABI files

2017-01-27 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > create mode 100644 include/odp/arch/arm32-linux/odp/api/abi/buffer.h > > Will the types in the ABI spec be the same for Linux and another OS? ABI includes e.g. function calling convention. Linux defines one, other OS or bare metal may define something different. ODP defined ABIs (as of

Re: [lng-odp] 32-bit support in examples

2017-01-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Tuesday, January 24, 2017 12:15 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: Brian Brooks <brian.bro...@linaro.org>; Francois Ozog <francois.o...@linaro.org>; nd <n

Re: [lng-odp] schedule_multi returning tasks from multiple queues

2017-01-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Honnappa Nagarahalli > Sent: Tuesday, January 24, 2017 8:29 AM > To: Bill Fischofer > Cc: Kevin Wang ; Yi He ; lng-odp- >

Re: [lng-odp] [PATCH 0/4] introduce odph_api.h and clean up public helper API

2017-01-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Monday, January 23, 2017 9:46 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 0/4] introduce odph_api.h and clean up public > helper API > > Greatly reduce the

Re: [lng-odp] [PATCH v2 1/8] abi: event: added the first ABI spec file

2017-01-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Brian Brooks [mailto:brian.bro...@linaro.org] > Sent: Tuesday, January 24, 2017 9:25 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp

Re: [lng-odp] [PATCH v4 3/4] helper: move thread implementation under platform

2017-01-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Mike Holmes [mailto:mike.hol...@linaro.org] > Sent: Monday, January 23, 2017 3:01 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp]

Re: [lng-odp] [PATCH v2 1/8] abi: event: added the first ABI spec file

2017-01-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > +#ifndef ODP_ABI_EVENT_H_ > > +#define ODP_ABI_EVENT_H_ > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +#include > > + > > +/** @internal Dummy type for strong typing */ > > +typedef struct { char dummy; /**< @internal Dummy */ } > _odp_abi_event_t; > > Why change from

Re: [lng-odp] [PATCH v4 3/4] helper: move thread implementation under platform

2017-01-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> --- /dev/null > +++ b/helper/include/odp/helper/platform/linux-generic/threads_extn.h This file and these functions are not odp-linux specific. Those depend mainly on Linux and somewhat on ODP, but should not depend at all on the odp-linux implementation. Should it be moved to here:

Re: [lng-odp] 32-bit support in examples

2017-01-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
axim Uvarov <maxim.uva...@linaro.org>; Savolainen, > Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com>; lng- > o...@lists.linaro.org; nd <n...@arm.com> > Subject: Re: [lng-odp] 32-bit support in examples > > CAS is a universal primitive in the se

Re: [lng-odp] [PATCH 0/8] First ABI files

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Friday, January 20, 2017 4:13 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> >

Re: [lng-odp] [PATCH 0/8] First ABI files

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > I think we should stop right here of doing "significant changes" through > api-next. Last time that policy effectively stopped the work in master due > to dependencies over many files changed. Api-next should be reserved only > for API spec changing modifications, since only those are visible

Re: [lng-odp] 32-bit support in examples

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Joe Savage [mailto:joe.sav...@arm.com] > Sent: Friday, January 20, 2017 1:51 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; Maxim Uvarov <maxim.uva...@linaro.org>; lng- > o...@li

Re: [lng-odp] 32-bit support in examples

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Thursday, January 19, 2017 3:27 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] 32-bit support in examples > > On 01/19/17 16:23, Joe Savage wrote: > > Hey, > >

Re: [lng-odp] [PATCH 0/8] First ABI files

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, January 19, 2017 11:53 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> >

Re: [lng-odp] [PATCH] linux-gen: align: round up power of two as macro

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> +#define ODP_ROUNDUP_POWER2_U32(x) \ > +       (((x) > 0x8000) ? 0 : (_POW2_U32_R5(x - 1) + 1)) > > it's better to not name internal macros with ODP_ > > > Agree, but that's the current convention over the odp_align_interal.h. All > are internal macros and are ODP_ prefixed. Another

Re: [lng-odp] [PATCH] linux-gen: align: round up power of two as macro

2017-01-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > /** > > * @internal > > - * When 'x' is not already a power of two, round it up to the next > > - * power of two value. Zero is not supported as an input value. > > - */ > > -#define ODP_ROUNDUP_POWER_2(x)\ > > - (1 << (((int)(8 * sizeof(x))) - __builtin_clz((x) - 1))) > > + * Round

Re: [lng-odp] [PATCH] linux-gen: align: round up power of two as macro

2017-01-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
 /**   * @internal - * When 'x' is not already a power of two, round it up to the next - * power of two value. Zero is not supported as an input value. - */ -#define ODP_ROUNDUP_POWER_2(x)\ -       (1 << (((int)(8 * sizeof(x))) - __builtin_clz((x) - 1))) + * Round up a uint32_t value 'x' to the

Re: [lng-odp] [API-NEXT PATCH] linux-gen: align: fix round up power of two

2017-01-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
code with clz instruction). -Petri From: Yi He [mailto:yi...@linaro.org] Sent: Thursday, January 19, 2017 10:43 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: bill.fischo...@linaro.org; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH]

Re: [lng-odp] [PATCH 0/8] First ABI files

2017-01-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
rom: Mike Holmes [mailto:mike.hol...@linaro.org] > Sent: Wednesday, January 18, 2017 8:25 PM > To: Bill Fischofer <bill.fischo...@linaro.org> > Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; lng-odp-forward <lng-odp@lists.linaro.org>

Re: [lng-odp] [API-NEXT PATCH] linux-gen: align: fix round up power of two

2017-01-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
This is not correct. With e.g. uint64_t x = 1; __builtin_clz(x) == 63 and 8*sizeof(unsigned int) == 32, the shift value would negative. Sizeof is there to calculate bits of the variable that deliver x. You cannot fix it to 'unsigned int' without fixing the variable size seen by

Re: [lng-odp] [API-NEXT PATCH 1/4] validation: crypto: fix hw cipher/auth algorithm check

2017-01-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
Now when master is up to date with api-next, this patch set may be merged to master also. Actually, it would be good to have it in the release since it fixes false assumptions (in crypto validation test) and makes it possible to pass the test with various crypto implementations (that follow the

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Sunday, January 15, 2017 5:09 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> > Huge performance degradation. Numbers are now many times worse than > >> before or after my optimizations. To me this shows that almost a > complete > >> rewrite (or revert) is needed. > >> > >> My guess is this is due to the atomics needed for reference counting > >> not being properly

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, January 12, 2017 2:22 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
This patch is now merged, although I had some doubts that it has bad impact on performance. Here are some performance results for couple of simple, single thread packet alloc/free test cases. No references involved, just plain packets as before. Test results before and after "linux-generic:

[lng-odp] master release status

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, What's the status of upgrading master with latest api-next commits and tagging it? I can see that next branch is now at ... commit 23e7745272bd405483da737824af25e2e18c8b21 Author: Bill Fischofer Date: Tue Jan 10 09:59:40 2017 -0600 linux-generic: pool:

Re: [lng-odp] [API-NEXT PATCHv4] linux-generic: pool: defer ring allocation until pool creation

2017-01-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Tuesday, January 10, 2017 6:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv4]

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

2017-01-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, January 10, 2017 3:20 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Maxim Uvarov <maxim.uva...@lina

Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations

2017-01-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Monday, January 09, 2017 11:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> >

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

2017-01-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
t; than Bill can do v2 with more clean shm names. > > Maxim. > > On 12/16/16 17:08, Bill Fischofer wrote: > > On Fri, Dec 16, 2016 at 7:13 AM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > >> On 12/16/16 11:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >&g

Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations

2017-01-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
7 5:49 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations > > Since there is no API change this patch could go to MASTER directly. > > Regards, > Bala > >

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: init: add openssl locking support for thread safety

2017-01-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
This bug fix belongs to master (and monarch), especially if there are no conflicts with the changes in api-next. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Friday, January 06, 2017 3:54 PM > To:

Re: [lng-odp] [API-NEXT PATCHv3 2/6] drv: adding odpdrv_shm_pool functions

2016-12-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
hol...@linaro.org; yi...@linaro.org; bill.fischo...@linaro.org; > Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; lng-odp@lists.linaro.org > Cc: Christophe Milard <christophe.mil...@linaro.org> > Subject: [API-NEXT PATCHv3 2/6] drv: adding od

Re: [lng-odp] [API-NEXT PATCHv2 2/6] drv: adding odpdrv_shm_pool functions

2016-12-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > > >> + uint64_t pool_size; > >> + > >> + /** Minimum alloc size application will request from pool > (bytes)*/ > >> + uint64_t min_alloc; > > > > Since this is a driver interface: ... size *driver* will request ... > > It is not limited to drivers: other driver elements such as >

Re: [lng-odp] [NEXT PATCH] changelog: summary of changes for odp v1.13.0.0

2016-12-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > +=== Known Issues > > + > > + https://bugs.linaro.org/show_bug.cgi?id=2765[Bug 2765] > > +The fixed storage overhead for supporting the new pool structures is > large > > +(over a quarter of a gigabyte). This may have an impact on smaller > systems. > > + > > > I think we need merge this

Re: [lng-odp] [API-NEXT PATCHv2 2/6] drv: adding odpdrv_shm_pool functions

2016-12-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Christophe Milard > Sent: Thursday, December 29, 2016 9:57 AM > To: mike.hol...@linaro.org; bill.fischo...@linaro.org; yi...@linaro.org; > forrest@linaro.org; lng-odp@lists.linaro.org >

Re: [lng-odp] api for small buffer allocations

2016-12-27 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> > > >> > typedef struct { > >> > // sum of all (simultaneous) allocs > >> > uint64_t pool_size; > >> > > >> > // Minimum alloc size application will request from pool > >> > uint32_t min_alloc; > >> > > >> > // Maximum alloc size application will

Re: [lng-odp] api for small buffer allocations

2016-12-27 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, December 23, 2016 3:36 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Subject: Re: api for small buffer allocations

Re: [lng-odp] api for small buffer allocations

2016-12-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, December 23, 2016 10:57 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Mike Holmes <mike.hol...@linaro.org>;

Re: [lng-odp] [API-NEXTv2 1/1] api: pktio: adds further definition for classification configuration

2016-12-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen Otherwise OK, but a typo could be corrected during merge. See under. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Balasubramanian Manoharan > Sent: Friday, November 04,

Re: [lng-odp] api for small buffer allocations

2016-12-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Thursday, December 22, 2016 3:13 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Mike Holmes <mike.hol...@linaro.org>;

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

2016-12-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, December 22, 2016 6:59 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

2016-12-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, December 22, 2016 4:20 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Mike Holmes <mike.hol...@linaro.org&

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

2016-12-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Thursday, December 22, 2016 4:08 PM > To: Maxim Uvarov > Cc: lng-odp > Subject: Re: [lng-odp] [PATCHv2] linux-generic:

Re: [lng-odp] api for small buffer allocations

2016-12-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
HTML mail ... otherwise looks reasonable. See some comments under (for the future API spec for the same feature). From: Christophe Milard [mailto:christophe.mil...@linaro.org] Sent: Thursday, December 22, 2016 11:24 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-b

Re: [lng-odp] Merge API-NEXT to NEXT

2016-12-21 Thread Savolainen, Petri (Nokia - FI/Espoo)
I'd like to get this to api-next and after that to next/master. linux-gen: schedule_sp: use ringas priority queue -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Tuesday, December 20, 2016 6:57 PM >

Re: [lng-odp] Suspected SPAM - [API-NEXT PATCH 1/3] api: unify ODP_*_NAME_LEN specifications

2016-12-21 Thread Savolainen, Petri (Nokia - FI/Espoo)
For the entire patch set: Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Matias Elo > Sent: Tuesday, December 20, 2016 3:45 PM > To: lng-odp@lists.linaro.org > Subject: Suspected

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

2016-12-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Thursday, December 08, 2016 1:04 PM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - [lng-odp] [API-NEXT PATCH] linux-gen: > schedule_sp: use ring as

Re: [lng-odp] [API-NEXT PATCHv9 1/3] api: random: add explicit controls over random data

2016-12-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Monday, December 12, 2016 5:06 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv9 1/3]

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

2016-12-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > @@ -172,6 +172,7 @@ static pool_t *reserve_pool(void) > { > int i; > pool_t *pool; > + char ring_name[ODP_POOL_NAME_LEN]; > > for (i = 0; i < ODP_CONFIG_POOLS; i++) { > pool = pool_entry(i); > @@ -180,6 +181,17 @@ static pool_t *reserve_pool(void) >

Re: [lng-odp] [API-NEXT PATCH v3 01/10] api: crypto: rename _params_t to _param_t

2016-12-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Thursday, December 15, 2016 8:22 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v3 01/10] api: crypto: rename > _params_t to _param_t > > Patch

Re: [lng-odp] [PATCH 0/6] Remove Linux specifics from odp/helpers

2016-12-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Tuesday, December 13, 2016 2:48 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 0/6] Remove Linux specifics from odp/helpers On 13 De

Re: [lng-odp] sizeof(pool_table_t) = 272M

2016-12-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, December 13, 2016 4:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Maxim Uvarov <maxim.uva...@lina

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

2016-12-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Tuesday, December 13, 2016 4:06 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [A

Re: [lng-odp] [PATCH] linux-gen: explicitly ignore return values

2016-12-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > > > --- a/platform/linux-generic/odp_pool.c > > > > +++ b/platform/linux-generic/odp_pool.c > > > > @@ -433,8 +433,8 @@ odp_pool_t _pool_create(const char *name, > > > > pool->s.blk_freelist = NULL; > > > > > > > > /* Initialization will

Re: [lng-odp] [PATCH 0/6] Remove Linux specifics from odp/helpers

2016-12-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Monday, December 12, 2016 4:52 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 0/6] Remove Linux specifics from odp/helpers > > To allow other implementations

Re: [lng-odp] [PATCH 2/6] helper: remove unused linux specific apis

2016-12-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Monday, December 12, 2016 4:52 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 2/6] helper: remove unused linux specific apis > > Signed-off-by: Mike Holmes

Re: [lng-odp] sizeof(pool_table_t) = 272M

2016-12-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Monday, December 12, 2016 6:45 PM > To: lng-odp-forward > Subject: [lng-odp] sizeof(pool_table_t) = 272M > > The latest pool changed set huge

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

2016-12-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > +static void add_group(sched_group_t *sched_group, int thr, int group) > > +{ > > + int num; > > + uint32_t gen_cnt; > > + thr_group_t *thr_group = _group->s.thr[thr]; > > + > > + num = thr_group->num_group; > > + thr_group->group[num] = group; > > + thr_group->num_group = num +

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

2016-12-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Monday, December 12, 2016 3:01 AM > To: Bala Manoharan <bala.manoha...@linaro.org> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>; Savolainen, Petri (Nokia - > FI/Espoo

Re: [lng-odp] [API-NEXT PATCH] linux-gen: sched: fix SP scheduler hang in process mode

2016-12-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Yi He [mailto:yi...@linaro.org] > Sent: Friday, December 09, 2016 5:35 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; Elo, Matias (Nokia - FI/Espoo) <matias.elo@nokia-bell- > labs.com>; lng

Re: [lng-odp] odp_rwlock_read_trylock

2016-12-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu] > Sent: Friday, December 09, 2016 12:14 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; LNG ODP Mailman List <lng-odp@lists.linaro.org&

Re: [lng-odp] odp_rwlock_read_trylock

2016-12-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu] > Sent: Thursday, December 08, 2016 5:30 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com>; LNG ODP Mailman List <lng-odp@lists.linaro.org&

Re: [lng-odp] [API-NEXT PATCHv8 1/3] api: random: add explicit controls over random data

2016-12-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
> + > +/** > + * Generate repeatable random data for testing purposes > + * > + * For testing purposes it is often useful to generate "random" sequences > that > + * are repeatable. This is accomplished by supplying a seed value that is > used > + * for pseudo-random data generation. The

Re: [lng-odp] odp_rwlock_read_trylock

2016-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Nicolas Morey-Chaisemartin > Sent: Wednesday, December 07, 2016 10:12 AM > To: LNG ODP Mailman List > Subject: [lng-odp] odp_rwlock_read_trylock > > HI, > > > While

Re: [lng-odp] [API-NEXT PATCH v3] api: ipsec: added IPSEC API

2016-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Thursday, December 08, 2016 11:16 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>

Re: [lng-odp] [API-NEXT PATCH v3] api: ipsec: added IPSEC API

2016-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > + > > +/** > > + * Fragmentation mode > > + * > > + * These options control outbound IP packet fragmentation offload. When > offload > > + * is enabled, IPSEC operation will determine if fragmentation is > needed and > > + * does it according to the mode. > > + */ > > +typedef enum

Re: [lng-odp] [API-NEXT PATCHv7 1/3] api: random: add explicit controls over random data

2016-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> /** > + * Random kind selector > + * > + * The kind of random denotes the statistical quality of the random data > + * returned. Basic random simply appears uniformly distributed, > Cryptographic > + * random is statistically random and suitable for use by cryptographic > + * functions. True

Re: [lng-odp] [API-NEXT PATCH] linux-gen: scheduler: solve ordered context inversion

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
: Thursday, December 08, 2016 9:40 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: lng-odp@lists.linaro.org; bill.fischo...@linaro.org; Elo, Matias (Nokia - FI/Espoo) <matias@nokia-bell-labs.com> Subject: Re: [lng-odp] [API-NEXT PATCH] linux-ge

Re: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Wednesday, December 07, 2016 9:43 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0 > > Signed-off-by: Mike Holmes

Re: [lng-odp] [API-NEXT PATCH] linux-gen: scheduler: solve ordered context inversion

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
This patch belongs to the iquery scheduler patch set. Without the rest of the code, it's impossible to tell if this change is needed or correct. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Yi He > Sent: Thursday, December 08, 2016

Re: [lng-odp] [API-NEXT PATCH v2 1/7] api: crypto: decouple key length from algorithm enumeration

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Wednesday, December 07, 2016 2:35 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>

Re: [lng-odp] [APO-NEXT PATCHv6 1/3] api: random: add explicit controls over random data

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> +int32_t odp_random_repeatable_data(uint8_t *buf, uint32_t len, > >> +odp_random_kind_t kind, uint32_t > *seed); > >> > > > > If pseudo/deterministic is not a good term for this, then I think it's > better to profile it strictly for testing (all production

Re: [lng-odp] [API-NEXT PATCHv3 1/3] api: dev: add device apis for numa support

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
plementation details of the interface. -Petri From: Francois Ozog [mailto:francois.o...@linaro.org] Sent: Wednesday, December 07, 2016 1:34 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: Bill Fischofer <bill.fischo...@linaro.org>; lng-odp-fo

Re: [lng-odp] [API-NEXT PATCHv3 1/3] api: dev: add device apis for numa support

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Francois Ozog [mailto:francois.o...@linaro.org] Sent: Tuesday, December 06, 2016 5:10 PM To: Bill Fischofer <bill.fischo...@linaro.org> Cc: lng-odp-forward <lng-odp@lists.linaro.org>; Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com>; Christophe

Re: [lng-odp] [API-NEXT PATCHv3 1/3] api: dev: add device apis for numa support

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
ancois Ozog [mailto:francois.o...@linaro.org] Sent: Tuesday, December 06, 2016 5:10 PM To: Bill Fischofer <bill.fischo...@linaro.org> Cc: lng-odp-forward <lng-odp@lists.linaro.org>; Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com>; Christophe Milard <c

Re: [lng-odp] [API-NEXT PATCH v2 4/7] api: crypto: added session params init

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > /** > > + * Initialize crypto session parameters > > + * > > + * Initialize an odp_crypto_session_params_t to its default values for > > + * all fields. > > + * > > + * @param params Pointer to odp_crypto_session_params_t to be > initialized > > + */ > > +void

Re: [lng-odp] [API-NEXT PATCH v2 1/7] api: crypto: decouple key length from algorithm enumeration

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > /** > > + * Cipher algorithm capabilities > > + */ > > +typedef struct odp_crypto_cipher_capa_t { > > + /** Key length in bytes */ > > + uint32_t key_len; > > + > > + /** IV length in bytes */ > > + uint32_t iv_len; > > + > > +} odp_crypto_cipher_capa_t; > > This

Re: [lng-odp] [PATCH] validation: packet: fix concat test

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
Pool re-implementation in api-next fixes a number of validation test bugs. This may be fixed already there, since I first implemented pools with single segment. Also concat test tried to concat a single packet into the end of itself... I suggest to postpone this until api-next is merged to

Re: [lng-odp] [APO-NEXT PATCHv6 1/3] api: random: add explicit controls over random data

2016-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Monday, December 05, 2016 11:29 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [APO-NEXT PATCHv6 1/3] api: random: add explicit > controls over random data > >

Re: [lng-odp] [API-NEXT PATCHv5 3/7] api: crypto: add random kind info to odp_crypto_capabilities() api

2016-12-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h > index 0cb8814..10373a3 100644 > --- a/include/odp/api/spec/crypto.h > +++ b/include/odp/api/spec/crypto.h > @@ -19,6 +19,8 @@ > extern "C" { > #endif > > +#include > + > /** @defgroup odp_crypto ODP CRYPTO > *

<    1   2   3   4   5   6   7   8   9   10   >