Merged,
Maxim.
On 03/11/15 20:42, Bill Fischofer wrote:
On Wed, Mar 11, 2015 at 7:59 AM, Petri Savolainen
petri.savolai...@nokia.com mailto:petri.savolai...@nokia.com wrote:
Cleaned up usage of buf count, thread args and globals.
Signed-off-by: Petri Savolainen
Reviewed-by: Maxim Uvarov maxim.uva...@linaro.org
On 03/11/15 21:43, Bill Fischofer wrote:
On Wed, Mar 11, 2015 at 1:30 PM, Mike Holmes mike.hol...@linaro.org
mailto:mike.hol...@linaro.org wrote:
This docuemtnation has been moved to the API document
Signed-off-by: Mike Holmes
Merged,
Maxim.
On 03/11/15 19:54, Bill Fischofer wrote:
I originally was going to point out the 'typo' but my first reaction
was that if should be of rather than in. However, on reflection it
seemed that if was what was intended. However, I agree that this
revised wording is clearer.
On
Merged,
Maxim.
On 03/06/15 16:24, Stuart Haslam wrote:
The default logger prints all log levels to stderr. To make things
easier when debugging failures change it to print only errors to stderr
and everything else to stdout.
Signed-off-by: Stuart Haslam stuart.has...@linaro.org
Reviewed-by:
These examples won't leak memory continuously so why is this a problem?
Are we catering to e.g. bare metal environments which may not clean up
after applications have terminated?
On 11 March 2015 at 14:52, Ciprian Barbu ciprian.ba...@linaro.org wrote:
This series continues the patch I sent
The odp_ipsec example leaks some strings allocated during parse_args.
https://bugs.linaro.org/show_bug.cgi?id=1117
CID 56899: Resource leak (RESOURCE_LEAK)
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
example/generator/odp_generator.c | 30 --
1 file
So after a little chat we had, Maxim suggested I remove the ioctl code
that needs struct ifreq. There is a USE_MAC_ADDR_HACK define in
odp_ipsec that is now set to 1, removing all that code should fix the
problem.
The problem was described here: https://bugs.linaro.org/show_bug.cgi?id=627
Robbie
https://bugs.linaro.org/show_bug.cgi?id=1079
Ciprian Barbu ciprian.ba...@linaro.org changed:
What|Removed |Added
CC|
On 03/06/15 13:37, Stuart Haslam wrote:
On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
Virtual interfaces for linux-generic tests does not have
arp addresses. Arp discovery has to be turned off.
Why? Presumably you're making this change because without it you had a
problem,
How about move that to ODP api guidelines?
Maxim.
On 03/12/15 02:27, Mike Holmes wrote:
Clarify the locations that variables may be declared
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
CONTRIBUTING | 15 +++
1 file changed, 15 insertions(+)
diff --git a/CONTRIBUTING
Can somebody test that patch?
Maxim.
On 03/11/15 16:13, Ciprian Barbu wrote:
Remove the old hack and switch to using the provided API
This also fixes https://bugs.linaro.org/show_bug.cgi?id=1330
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
example/ipsec/odp_ipsec.c | 58
I would like to reword that subject from:
validation: packet: use true == \!0 per ODP API Guidelines
to
validation: check packet flags not not 0
odp packet flags functions return int while it's intend to be odp_bool_t.
odp_bool_t have to be checked for no 0.
It should be better due to:
1.
On 11 March 2015 at 17:25, Mike Holmes mike.hol...@linaro.org wrote:
On 11 March 2015 at 10:32, Ola Liljedahl ola.liljed...@linaro.org wrote:
These examples won't leak memory continuously so why is this a problem?
Are we catering to e.g. bare metal environments which may not clean up
after
Merged,
Maxim.
On 03/11/15 12:40, Stuart Haslam wrote:
On Wed, Mar 11, 2015 at 11:36:25AM +0300, Maxim Uvarov wrote:
Fix CID 88056 to check return code of pool_destroy.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
---
This documentation was moved from the architecture doc to this API doc.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
doc/api_guide_lines.dox | 178
1 file changed, 178 insertions(+)
create mode 100644 doc/api_guide_lines.dox
diff --git
https://bugs.linaro.org/show_bug.cgi?id=1313
--- Comment #3 from Ola Liljedahl ola.liljed...@linaro.org ---
http://patches.opendataplane.org/patch/1034/
v2 changes the wording of some comments.
--
You are receiving this mail because:
You are on the CC list for the
Any comments on making parsing the interface list common for all
examples? This touches on
https://bugs.linaro.org/show_bug.cgi?id=1079. I don't think it's time
to do that yet. In fact I think we could try changing the way we pass
the if names, instead of using a comma separated list we could
On 12 March 2015 at 06:54, Stuart Haslam stuart.has...@linaro.org wrote:
On Wed, Mar 11, 2015 at 04:47:59PM -0400, Mike Holmes wrote:
I simultaneously ran two independent instances of odp with make check
and neither had an issue, one had this patch the other did not.
At the same time I
Ping. I think it's time to merge these two patches. This sets the stage for
testing odp_timeout_xxx() after timer cancel.
-Petri
-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Tuesday, March 10, 2015 4:11 PM
To: Savolainen, Petri (Nokia -
On 03/12/2015 12:03 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, March 11, 2015 5:18 PM
To: Savolainen, Petri (Nokia - FI/Espoo); ext Christophe Milard; lng-
o...@lists.linaro.org
On Wed, Mar 11, 2015 at 04:47:59PM -0400, Mike Holmes wrote:
I simultaneously ran two independent instances of odp with make check
and neither had an issue, one had this patch the other did not.
At the same time I used the ./build.sh script from the cleanup branch of
On Thu, Mar 12, 2015 at 12:23:28PM +0300, Maxim Uvarov wrote:
On 03/06/15 13:37, Stuart Haslam wrote:
On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
Virtual interfaces for linux-generic tests does not have
arp addresses. Arp discovery has to be turned off.
Why? Presumably
Ola, do you want to add your review-by to these patches?
Maxim.
On 03/12/15 13:26, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Ping. I think it's time to merge these two patches. This sets the stage for
testing odp_timeout_xxx() after timer cancel.
-Petri
-Original Message-
From:
On 12 March 2015 at 11:34, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 03/12/2015 12:03 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, March 11, 2015 5:18 PM
To:
https://bugs.linaro.org/show_bug.cgi?id=1344
Bug ID: 1344
Summary: CID 87295: Improper use of negative value:
odp_classification_basic.c
Product: OpenDataPlane
Version: 1.0
Hardware: Other
OS: Linux
On 03/11/15 17:22, Stuart Haslam wrote:
+ cnt=$[$cnt+1]
That is not portable, use expr.
./test/validation/odp_pktio_run: 43: [: Illegal number: $[0+1]
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
To keep it simple:
1) Merge with spelling fixed: “requensting” = “requesting”
2) Send another patch that enables odp_timeout_user_ptr() test and adds
odp_timeout_timer() test.
-Petri
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Thursday, March 12, 2015 2:58 PM
To:
https://bugs.linaro.org/show_bug.cgi?id=1175
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=1102
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |NON REPRODUCIBLE
Hi All,
ODP API reference manual states that API odp_queue_deq cannot be used with
queue of type ODP_QUEUE_TYPE_SCHED, Which is logical as queue is already
scheduled so we need to call odp_schedule for these type of queues.
In contrast with above statement ODP IPSEC example application creates
https://bugs.linaro.org/show_bug.cgi?id=1259
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
Possibly build C++ test against gnu-c++ standard which may allow this as an
extension.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.linaro.org/show_bug.cgi?id=1284
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--
You are receiving
https://bugs.linaro.org/show_bug.cgi?id=1246
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=1306
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=1168
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
CC||mike.hol...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=1330
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
CC||mike.hol...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=1313
Maxim Uvarov maxim.uva...@linaro.org changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Add basic timer cancel test that checks that everything is OK when
a timer is reset and then cancelled before expiration.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
v2:
Enabled test of odp_timeout_user_ptr().
Added test of
This is a v2 of Petris [2/2] validation: timer: added cancel test
-- Ola
On 12 March 2015 at 17:03, Ola Liljedahl ola.liljed...@linaro.org wrote:
Add basic timer cancel test that checks that everything is OK when
a timer is reset and then cancelled before expiration.
Signed-off-by: Petri
https://bugs.linaro.org/show_bug.cgi?id=1334
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
CC||mike.hol...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=706
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|robk...@cisco.com |santosh.shu...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=641
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Ever confirmed|0 |1
https://bugs.linaro.org/show_bug.cgi?id=634
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Ever confirmed|0 |1
https://bugs.linaro.org/show_bug.cgi?id=625
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--
You are receiving
https://bugs.linaro.org/show_bug.cgi?id=620
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--
You are receiving
https://bugs.linaro.org/show_bug.cgi?id=634
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--
You are receiving
https://bugs.linaro.org/show_bug.cgi?id=620
--- Comment #3 from Mike Holmes mike.hol...@linaro.org ---
https://cards.linaro.org/browse/LNG-857
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the
https://bugs.linaro.org/show_bug.cgi?id=625
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
https://cards.linaro.org/browse/LNG-857
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the
https://bugs.linaro.org/show_bug.cgi?id=626
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
https://cards.linaro.org/browse/LNG-857
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the
https://bugs.linaro.org/show_bug.cgi?id=626
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--
You are receiving
https://bugs.linaro.org/show_bug.cgi?id=641
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |1.0
--- Comment #3 from
C++ doesn't like null structs so add a dummy variable to make it happy.
Note that we only use these types as pseudo-pointers for strong typing
so the contents of what they apparently point to is irrelevant since
we never reference it.
This addresses Bug
https://bugs.linaro.org/show_bug.cgi?id=1259
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org|mike.hol...@linaro.org
--
https://bugs.linaro.org/show_bug.cgi?id=1340
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.linaro.org/show_bug.cgi?id=706
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Component|General ODP API or |General
On 12 March 2015 at 12:21, Maxim Uvarov maxim.uva...@linaro.org wrote:
Ola, do you want to add your review-by to these patches?
I think the patch should be reposted (by someone) with the user_ptr test
enabled and the spelling error corrected. I could do this but then someone
else needs to
On 03/11/15 23:47, Mike Holmes wrote:
for i in {1..10}; do make clean check -e; done
Mike do you run that under root or not? I.e. which pktio in test odp
loop or linux veth?
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, March 11, 2015 5:18 PM
To: Savolainen, Petri (Nokia - FI/Espoo); ext Christophe Milard; lng-
o...@lists.linaro.org
Subject: Re: [lng-odp] odp_cpu_count() vs odp_cpumask size
On
On 10 March 2015 at 16:11, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 03/10/15 18:08, Ola Liljedahl wrote:
On 10 March 2015 at 15:59, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 03/10/15 17:43, Ola Liljedahl wrote:
Ensure that the timeout user_ptr and timer fields are set when the
https://bugs.linaro.org/show_bug.cgi?id=1334
--- Comment #1 from Bill Fischofer bill.fischo...@linaro.org ---
Patch series starting at http://patches.opendataplane.org/patch/1011/ submitted
to correct type specification of the packet flag API and linux-generic
implementation as well as to relax
60 matches
Mail list logo
