Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Dmitry Eremin-Solenikov
Hello, On 7 February 2017 at 10:14, Maxim Uvarov wrote: > What is function is not used error? Is it gcc or #error in includes? First error: In file included from ./include/odp_packet_internal.h:28:0, from odp_classification.c:13:

[lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Dmitry Eremin-Solenikov
-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 1 + platform/linux-generic/odp_crypto.c| 78 -- 2 files changed, 59 insertions(+), 20 deletions(-) diff --git a/platform/linux-g

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Dmitry Eremin-Solenikov
On 07.02.2017 00:57, Bill Fischofer wrote: The problem is not what level of OpenSSL ODP might be compiled against, but what level is installed on the system the ODP application is running on, since we don't distribute OpenSSL with ODP. OpenSSL v1.1.0 is backward-compatible with the older

[lng-odp] [PATCH v2 3/3] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Dmitry Eremin-Solenikov
OpenSSL 1.1.0 uses new threading API. It is no longer necessary to set locking callbacks to use OpenSSL in a multi-threaded environment. The old threading API should no longer be used. So don't allocate/set locking callbacks with new OpenSSL. Signed-off-by: Dmitry Eremin-Solenikov

[lng-odp] [PATCH v2 2/3] linux-generic: crypto: move OpenSSL locks out of global crypto data

2017-02-07 Thread Dmitry Eremin-Solenikov
In preparation to update crypto code for OpenSSL 1.1.0 move locks out of global data. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 67 ++--- 1 file changed, 47 insertions(+), 20 del

[lng-odp] [PATCH v2 1/3] linux-generic: crypto: add missing include

2017-02-07 Thread Dmitry Eremin-Solenikov
*ctx; ^~ Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_crypto_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/include/odp_crypto_internal.h b/platform/linux-generic/i

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Dmitry Eremin-Solenikov
On 07.02.2017 18:59, Maxim Uvarov wrote: On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: Hello, On 7 February 2017 at 10:14, Maxim Uvarov <maxim.uva...@linaro.org> wrote: What is function is not used error? Is it gcc or #error in includes? First error: In file included from ./i

Re: [lng-odp] [API-NEXT PATCH 4/4] validation: crypto: add stubs for sha-1 and sha-512 tests

2017-02-22 Thread Dmitry Eremin-Solenikov
On 22.02.2017 18:08, Petri Savolainen wrote: > API enumerations are tested but functional tests are missing still. If nobody steps up, I will take a look onto implementing funcionality and tests. I have several issues with the current code anyway. > > Signed-off-by: Petri Savolainen

[lng-odp] [PATCH v3 2/3] linux-generic: crypto: port to OpenSSL 1.0.x thread id API

2017-02-23 Thread Dmitry Eremin-Solenikov
OpenSSL 1.0.x has deperecated old 0.9.x thread id callbacks. If the library is compiled without deprecated functions, compiling ODP fails with missing functions errors. So, let's port odp_crypto to OpenSSL 1.0 thread ID API. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsol

[lng-odp] [PATCH v3 3/3] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-23 Thread Dmitry Eremin-Solenikov
, add ODP_UNUSED annotiations to lock/thread_id callbacks. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/pl

[lng-odp] [PATCH v3 1/3] linux-generic: crypto: add missing include

2017-02-23 Thread Dmitry Eremin-Solenikov
*ctx; ^~ Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_crypto_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/include/odp_crypto_internal.h b/platform/linux-generic/i

[lng-odp] [PATCH 1/4] example: ipsec_offload: enable compilation

2017-02-21 Thread Dmitry Eremin-Solenikov
Enable compilation of the ipsec_offload example. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- example/ipsec_offload/Makefile.am | 1 + example/m4/configure.m4 | 1 + 2 files changed, 2 insertions(+) diff --git a/example/ipsec_offload/Makefile

[lng-odp] [PATCH 4/4] api: crypto: add definitions for SHA-1 HMAC authentication

2017-02-21 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/crypto.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index 9855bf98..cdff8e94 100644 --- a/include/odp/ap

[lng-odp] [PATCH 2/4] example: ipsef_offload: port to odpthreads helpers

2017-02-21 Thread Dmitry Eremin-Solenikov
Switch from old linux-pthread API to odpthread. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- example/ipsec_offload/odp_ipsec_offload.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/example/ipsec_o

[lng-odp] [PATCH 3/4] abi: event: add ODP_EVENT_IPSEC_RESULT

2017-02-21 Thread Dmitry Eremin-Solenikov
ODP_EVENT_IPSEC_RESULT is an event type used for result reporting from IPsec offload. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/arch/default/api/abi/event.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/od

Re: [lng-odp] ABI and deprecated API flag

2017-03-14 Thread Dmitry Eremin-Solenikov
Hi, On 14.03.2017 07:06, Honnappa Nagarahalli wrote: > 2) What is the purpose of the deprecated API flag? It's purpose is to allow applications to recognize that the API is going to be removed in the next release and thus to migrate from old API to new replacement. -- With best wishes Dmitry

[lng-odp] [API-NEXT v2 5/8] linux-generic: crypto: unify auth code

2017-04-03 Thread Dmitry Eremin-Solenikov
Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/i

[lng-odp] [API-NEXT v2 0/8] crypto rework and support for SHA-1/-512

2017-04-03 Thread Dmitry Eremin-Solenikov
due to odp_crypto using OpenSSL (which uses mixed case for function names). Dmitry Eremin-Solenikov (8): validation: crypto: add tests for checking message digests validation: crypto: correct comment for HMAC-SHA-256 tests validation: crypto: add HMAC-SHA-1-96 test cases validation: crypto

[lng-odp] [API-NEXT v2 2/8] validation: crypto: correct comment for HMAC-SHA-256 tests

2017-04-03 Thread Dmitry Eremin-Solenikov
Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++--

[lng-odp] [API-NEXT v2 1/8] validation: crypto: add tests for checking message digests

2017-04-03 Thread Dmitry Eremin-Solenikov
Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> ---

[lng-odp] [API-NEXT v2 4/8] validation: crypto: add HMAC-SHA-512 test cases

2017-04-03 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 97 +- .../validation/api/crypto/test_vectors.h | 50 +++ .../validation/api/crypto/test_vectors_len.h | 6 ++ 3

[lng-odp] [API-NEXT v2 3/8] validation: crypto: add HMAC-SHA-1-96 test cases

2017-04-03 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 99 +- .../validation/api/crypto/test_vectors.h | 44 ++ .../validation/api/crypto/test_vectors_len.h | 6 ++ 3

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 23:26, Brian Brooks wrote: > On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 21:47, Brian Brooks wrote: >>> Signed-off-by: Brian Brooks <brian.bro...@arm.com> >> >> Brian, >> >> how does this fail with clang on

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 21:47, Brian Brooks wrote: > Signed-off-by: Brian Brooks Brian, how does this fail with clang on ARMv8? Could you please include error message in the commit message? -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 22:25, Maxim Uvarov wrote: > it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > defined and one for not. Seconding that. At least LLDSCD and non-LLDSCD code should not be interleaved. -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > --- > platform/linux-generic/include/odp_llsc.h | 332 >

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

2017-04-04 Thread Dmitry Eremin-Solenikov
On 05.04.2017 01:00, Brian Brooks wrote: > On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl <ola.liljed...@arm.com> wrote: >> On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" >> <dmitry.ereminsoleni...@linaro.org> wrote: >>> On 04.04

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

2017-04-04 Thread Dmitry Eremin-Solenikov
On 05.04.2017 02:34, Ola Liljedahl wrote: > > > > > On 05/04/2017, 01:29, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 05.04.2017 01:00, Brian Brooks wrote: >>> On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljed

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 23:34, Brian Brooks wrote: > On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 23:26, Brian Brooks wrote: >>> On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: >>>> On 04.04.2017 21:47, Brian Brooks wrote: >>>>> Sign

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Dmitry Eremin-Solenikov
On 05.04.2017 00:31, Brian Brooks wrote: > On 04/04 14:53:23, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: >>> On 04/04 21:55:06, Maxim Uvarov wrote: this patch should be not part of this serries and can go to master as standalone

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-04 Thread Dmitry Eremin-Solenikov
On 05.04.2017 00:25, Brian Brooks wrote: > On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 22:25, Maxim Uvarov wrote: >>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>> defined and one for not. >> >> Secondi

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

2017-04-04 Thread Dmitry Eremin-Solenikov
On 05.04.2017 00:00, Ola Liljedahl wrote: > I think I missed one comment. > > > On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 04.04.2017 21:48, Brian Brooks wrote: >>> Signed-off-by: O

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 23:52, Ola Liljedahl wrote: > Sending from my ARM email account, I hope Outlook does not mess up the > format. > > > > On 04/04/2017, 22:21, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 04.04.2017 21:

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > +/**

[lng-odp] [PATCH] api: ipsec: change semantics of odp_ipsec_result function

2017-04-10 Thread Dmitry Eremin-Solenikov
one to copy packets from the event in small batches and process them accordingly. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/odp/api/spec/ips

[lng-odp] [API-NEXT v2 7/8] linux-generic: crypto: add SHA-1 authentication support

2017-04-03 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index ad4d169c..66

[lng-odp] [API-NEXT v2 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-04-03 Thread Dmitry Eremin-Solenikov
if there will be more AEAD ciphers. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 16 +- platform/linux-generic/odp_crypto.c| 232 + 2 files changed, 52 insertions(+

[lng-odp] [API-NEXT v2 8/8] linux-generic: crypto: add HMAC-SHA-512 authentication support

2017-04-03 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 6663e48f..9c

Re: [lng-odp] odp_ipsec_result behaviour

2017-04-04 Thread Dmitry Eremin-Solenikov
On 04.04.2017 10:15, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Dmitry Eremin-Solenikov >> Sent: Monday, April 03, 2017 10:48 PM >> To: lng-o

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-02 Thread Dmitry Eremin-Solenikov
On 13 March 2017 at 14:44, Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > --- > platform/lin

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 17:24, Bill Fischofer wrote: > On Wed, Apr 12, 2017 at 8:22 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 12.04.2017 15:21, Bill Fischofer wrote: >>> On Wed, Apr 12, 2017 at 7:11 AM, Dmitry Eremin-Solenikov >>>

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 17:24, Brian Brooks wrote: > On Wed, Apr 12, 2017 at 8:24 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 12.04.2017 16:01, Joe Savage wrote: >>> On 12/04/17 13:22, Dmitry Eremin-Solenikov wrote: >>>> On 12.04.20

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 16:01, Joe Savage wrote: > On 12/04/17 13:22, Dmitry Eremin-Solenikov wrote: >> On 12.04.2017 14:05, Joe Savage wrote: >>> On 12/04/17 11:32, Maxim Uvarov wrote: >>>> On 12.04.2017 13:15, Joe Savage wrote: >>>>>>>> The problem i

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 16:37, Joe Savage wrote: > On 12/04/17 14:24, Dmitry Eremin-Solenikov wrote: >> On 12.04.2017 16:01, Joe Savage wrote: >>> I'm not sure I quite follow your comments regarding $(ARCH_DIR) though. Are >>> there some ODP-defined macros that I can

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 14:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, April 12, 2017 2:32 PM >> To: Petri Savolainen <petri.

Re: [lng-odp] [PATCH] api: ipsec: change semantics of odp_ipsec_result function

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 12:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Dmitry Eremin-Solenikov >> Sent: Tuesday, April 11, 2017 2:02 AM >> To: lng-odp@l

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Dmitry Eremin-Solenikov
On 30.03.2017 16:58, Petri Savolainen wrote: > Replaced ODP_DEPRECATED macro (which was based on GCC __attribute__) with > compiler independent mechanism to control if deprecated API definitions are > visible to the application. ODP_DEPRECATED_API can be used both in > application > and

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 10.02.2017 19:06, Joe Savage wrote: > Add an example application implementing lock-free IPv4 fragmentation > and reassembly functionality using ODP's packet "concat" and "split". > > Signed-off-by: Joe Savage > Reviewed-and-tested-by: Bill Fischofer

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 14:05, Joe Savage wrote: > On 12/04/17 11:32, Maxim Uvarov wrote: >> On 12.04.2017 13:15, Joe Savage wrote: >> The problem is that when we discussed this patch on ODP call people very >> worry about having 128bit instructions in ODP examples. At least Petri >> and Barry

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Dmitry Eremin-Solenikov
On 12.04.2017 14:05, Joe Savage wrote: > On 12/04/17 11:32, Maxim Uvarov wrote: >> On 12.04.2017 13:15, Joe Savage wrote: >> The problem is that when we discussed this patch on ODP call people very >> worry about having 128bit instructions in ODP examples. At least Petri >> and Barry

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Dmitry Eremin-Solenikov
On 07.04.2017 13:00, Nikhil Agarwal wrote: > +typedef union odp_ipsec_protocols_t { > + /** Cipher algorithms */ > + struct { > + /** ODP_IPSEC_ESP */ > + uint32_t esp: 1; > + > + /** ODP_IPSEC_AH */ > + uint32_t ah : 1;

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 15:16, Ola Liljedahl wrote: > On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 05.04.2017 02:31, Ola Liljedahl wrote: >>> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov&q

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 17:40, Ola Liljedahl wrote: > On 5 April 2017 at 14:20, Maxim Uvarov wrote: >> On 04/05/17 01:46, Ola Liljedahl wrote: >>> On 4 April 2017 at 21:25, Maxim Uvarov wrote: it's better to have 2 separate files for that. One for

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 16:33, Ola Liljedahl wrote: > > > > > On 05/04/2017, 15:22, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: > >> On 05.04.2017 15:16, Ola Liljedahl wrote: >>> On 05/04/2017, 12:36, "Dmitry Eremin

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-06 Thread Dmitry Eremin-Solenikov
On 05.04.2017 21:36, Ola Liljedahl wrote: > On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 05.04.2017 17:40, Ola Liljedahl wrote: >>> On 5 April 2017 at 14:20, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >

Re: [lng-odp] [RFC][PATCH] added asymmetric crypto algorithm support.

2017-04-06 Thread Dmitry Eremin-Solenikov
On 05.04.2017 13:02, Umesh Kartha wrote: > Asymmetric crypto algorithms are essential in protocols such as SSL/TLS. > As the current ODP crypto library lacks support for asymmetric crypto > algorithms, this RFC is an attempt to address it and add support for the > same. If you target TLS, you

Re: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

2017-04-10 Thread Dmitry Eremin-Solenikov
On 10.04.2017 16:30, Maxim Uvarov wrote: > On 10 April 2017 at 16:14, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia-bell-labs.com> wrote: > >> Is there a way to get Github to send individual patches to the list ? ... >> Instead of this all-patches-in-one-mail format, with a

[lng-odp] [PATCH 3/3] api: ipsec: add default queue for outbound events

2017-04-10 Thread Dmitry Eremin-Solenikov
If SA lookup fails for outbound IPsec packet in async mode, there is no way to report it back to application except using default queue (which does not exist at this moment). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec

[lng-odp] [PATCH 2/3] api: ipsec: mark odp_ipsec_sa_create argument as constant

2017-04-10 Thread Dmitry Eremin-Solenikov
odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 del

Re: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

2017-04-10 Thread Dmitry Eremin-Solenikov
ge- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim >> Uvarov >> Sent: Monday, April 10, 2017 3:43 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt >> unsigned >> &

[lng-odp] [API-NEXT][RFC] linux-gen: ipsec: draft IPsec implementation

2017-04-11 Thread Dmitry Eremin-Solenikov
For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No tunnel support - No header modification according to RFCs Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-g

[lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

2017-04-11 Thread Dmitry Eremin-Solenikov
For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No tunnel support - No header modification according to RFCs Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-g

Re: [lng-odp] [PATCH v2] build: fix native Clang build on ARMv8

2017-04-12 Thread Dmitry Eremin-Solenikov
+-- > 1 file changed, 16 insertions(+), 14 deletions(-) Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > > diff --git a/configure.ac b/configure.ac > index 9320f360..d364b8dd 100644 > --- a/configure.ac > +++ b/configure.ac >

[lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/feature.h | 53 i

[lng-odp] [API-NEXT PATCH v2] api: ipsec: change semantics of odp_ipsec_result function

2017-04-19 Thread Dmitry Eremin-Solenikov
one to copy packets from the event in small batches and process them accordingly. - Freeing the event in odp_ipsec_result() leaves space for optimized implementations, where an event is actually a packet with additional metadata. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsol

Re: [lng-odp] [RFC, API-NEXT v2 1/1] comp:compression interface

2017-04-19 Thread Dmitry Eremin-Solenikov
On 19.04.2017 17:02, Verma, Shally wrote: > > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Verma, > Shally > Sent: 19 April 2017 19:30 > To: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>;

[lng-odp] [API-NEXT v5] api: ipsec: factor out definitions for feature support levels

2017-04-19 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 39 +--- include/o

Re: [lng-odp] [API-NEXT PATCHv2 2/6] api: ipsec: add additional doxygen documentation

2017-04-20 Thread Dmitry Eremin-Solenikov
ill.fischo...@linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

2017-04-14 Thread Dmitry Eremin-Solenikov
Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> For now it's only a preview with the following limitation: >> - No inline processing support >> - No SA lookups >> - Only IPv4 support >> - No tunnel support >> - No header modification a

[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 56 +++-

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-13 Thread Dmitry Eremin-Solenikov
On 13.04.2017 10:33, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, April 12, 2017 3:11 PM >> To: Savolainen, Petri (Nokia - FI/Espoo

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-13 Thread Dmitry Eremin-Solenikov
On 13.04.2017 15:26, Bill Fischofer wrote: > On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: >> I vote for default build will not build with deprecating support. Yes all >> general propose distributives will need to enable --enable-deprecated-api >> to support some

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
he header file, where to place this definition. > > On Fri, Apr 14, 2017 at 8:49 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 14.04.2017 16:25, Bill Fischofer wrote: >>> On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan >>>

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
On 14.04.2017 16:25, Bill Fischofer wrote: > On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan > <bala.manoha...@linaro.org> wrote: >> Regards, >> Bala >> >> >> On 14 April 2017 at 16:52, Bill Fischofer <bill.fischo...@linaro.org> wrote: >>>

[lng-odp] [API-NEXT v2] api: feature: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/feature.h | 54 i

[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 56 +++-

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

2017-04-18 Thread Dmitry Eremin-Solenikov
am.iv.length = odp_random_data(crypto_param.iv.data, >>> ipsec_sa->esp_iv_len, ODP_RANDOM_CRYPTO); > > Note that for AES-GCM one cannot use random IV since IV values must > never be reused in GCM. With AES-GCM a counter or alike would work. AES-GCM definitely needs more work,

Re: [lng-odp] [RFC, API-NEXT v2 1/1] comp:compression interface

2017-04-19 Thread Dmitry Eremin-Solenikov
On 19.04.2017 13:00, Shally Verma wrote: > An API set to add compression/decompression support in ODP > interface. > > Signed-off-by: Shally Verma > Signed-off-by: Mahipal Challa > --- > include/odp/api/spec/comp.h | 748 >

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-22 Thread Dmitry Eremin-Solenikov
On 20.04.2017 23:25, Maxim Uvarov wrote: > On 04/20/17 19:12, Bill Fischofer wrote: >> On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < >> dmitry.ereminsoleni...@linaro.org> wrote: >> >>> Add proper handling for errors returned by odp_packet_copy_from_

[lng-odp] [PATCH v3] linux-generic: crypto: properly handle errors in packet copy

2017-04-22 Thread Dmitry Eremin-Solenikov
Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/platform

[lng-odp] [PATCH v2] linux-generic: pool: don't allocate buffers from invalid pool

2017-03-10 Thread Dmitry Eremin-Solenikov
Add ODP_ASSERT checking that passed pool is not ODP_POOL_INVALID before tring to allocate buffers from that pool. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_pool.c | 4 1 file changed, 4 insertions(+) diff --git a/pl

[lng-odp] [API-NEXT 3/8] validation: crypto: add HMAC-SHA-1-96 test cases

2017-03-09 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 99 +- .../validation/api/crypto/test_vectors.h | 44 ++ .../validation/api/crypto/test_vectors_len.h | 6 ++ 3

Re: [lng-odp] [API-NEXT 0/8] crypto rework and support for SHA-1/-512

2017-03-09 Thread Dmitry Eremin-Solenikov
On 09.03.2017 11:51, Bill Fischofer wrote: > Part 3/8 doesn't appear either on the mailing list or in patchworks. Strange. Anyway, I've resent the patch and this time it showed in archives. > > On Wed, Mar 8, 2017 at 10:45 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsolen

[lng-odp] [PATCH] linux-generic: pool: don't allocate buffers from invalid pool

2017-03-09 Thread Dmitry Eremin-Solenikov
Check that passed pool is not ODP_POOL_INVALID before goint to try to allocate buffers from that pool. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_pool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/linux-g

Re: [lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-09 Thread Dmitry Eremin-Solenikov
On 09.03.2017 17:17, Bill Fischofer wrote: > Checkpatch issue with this part: > > WARNING: Missing a blank line after declarations > #163: FILE: platform/linux-generic/odp_crypto.c:312: > +EVP_CIPHER_CTX *ctx = >cipher.ctx; > +EVP_CIPHER_CTX_init(ctx); OK, I should fix this. The rest comes from

Re: [lng-odp] [API-NEXT 5/8] linux-generic: crypto: unify auth code

2017-03-09 Thread Dmitry Eremin-Solenikov
On 09.03.2017 17:15, Bill Fischofer wrote: > Checkpatch issue with this part: > > WARNING: Missing a blank line after declarations > #38: FILE: platform/linux-generic/include/odp_crypto_internal.h:66: > +uint32_t bytes; > +const EVP_MD *evp_md; > > total: 0 errors, 1 warnings, 0 checks, 205

[lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-03-13 Thread Dmitry Eremin-Solenikov
Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_cr

Re: [lng-odp] [PATCHv2] example:ipsec_offload: Adding ipsec_offload example

2017-03-08 Thread Dmitry Eremin-Solenikov
Let's get some final changes, so that we can hopefully merge this patch On 22.02.2017 15:27, Nikhil Agarwal wrote: > Signed-off-by: Nikhil Agarwal > --- [skipped] > + /* Read the source MAC address for this interface */ > + ret = odp_pktio_mac_addr(pktio,

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 16:44, Maxim Uvarov wrote: > On 03/07/2017 12:16 PM, Janne Peltonen wrote: >> Fix the ABI symlink creation that went broken in 3d6cbd2. >> >> Signed-off-by: Janne Peltonen >> --- >> platform/linux-generic/Makefile.am | 2 +- >> 1 file changed, 1

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 16:57, Maxim Uvarov wrote: > On 03/08/2017 04:47 PM, Dmitry Eremin-Solenikov wrote: >> On 08.03.2017 16:44, Maxim Uvarov wrote: >>> On 03/07/2017 12:16 PM, Janne Peltonen wrote: >>>> Fix the ABI symlink creation that went broken in 3d6cbd2. >>&

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 17:13, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Are you saying that in your shell this works (echoes foobar): > if false ; then : else echo foobar ; fi Does not work here (bash 4.4.11(1)-release). -- With best wishes Dmitry

[lng-odp] [PATCH] linux-generic: crypto: properly handle errors in packet copy

2017-03-06 Thread Dmitry Eremin-Solenikov
Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/platform/linux-g

Re: [lng-odp] [API-NEXT 0/3] deprecated hints proposal

2017-03-07 Thread Dmitry Eremin-Solenikov
On 07.03.2017 14:47, Dmitry Eremin-Solenikov wrote: > As promised, here comes a reworked deprecated API proposal. Main differences > from Petri's proposal: > > - No configure-time switches. ODP and helper libraries are ABI-compatible with > both kinds applications: using

[lng-odp] [API-NEXT 1/3] api: hints: rework ODP_DEPRECATED API

2017-03-07 Thread Dmitry Eremin-Solenikov
applications SHOULD try to compile without ODP_ALLOW_DEPRECATED macro defined. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- doc/helper-guide/Doxyfile | 1 + doc/platform-api-guide/Doxyfile| 1 + helper/Makefile.am | 1 + include/odp/ap

[lng-odp] [API-NEXT 0/3] deprecated hints proposal

2017-03-07 Thread Dmitry Eremin-Solenikov
of deprecated API just for the applications/examples that are not ported yet. Dmitry Eremin-Solenikov (2): api: hints: rework ODP_DEPRECATED API api: crypto: use ODP_DEPRECATED{,_FIELD} declarations Petri Savolainen (1): test: crypto: remove references to deprecated crypto apis doc/helper-guide

[lng-odp] [API-NEXT 3/3] test: crypto: remove references to deprecated crypto apis

2017-03-07 Thread Dmitry Eremin-Solenikov
From: Petri Savolainen Remove last remaining references to deprecated API definitions. Signed-off-by: Petri Savolainen --- example/ipsec/odp_ipsec_misc.h| 4 ++-- example/ipsec/odp_ipsec_sa_db.c | 4 ++--

[lng-odp] [API-NEXT 1/3] api: hints: rework ODP_DEPRECATED API

2017-03-07 Thread Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov <dbarysh...@gmail.com> The ODP_DEPRECATED macro uses the deprecated attribute which works only for types and functions, but not e.g. for fields of structure. So let's add ODP_DEPRECATED_FIELD macro suitable for fields, variables and enum values. Als

[lng-odp] [API-NEXT 0/3] deprecated hints proposal

2017-03-07 Thread Dmitry Eremin-Solenikov
of deprecated API just for the applications/examples that are not ported yet. Dmitry Eremin-Solenikov (2): api: hints: rework ODP_DEPRECATED API api: crypto: use ODP_DEPRECATED{,_FIELD} declarations Petri Savolainen (1): test: crypto: remove references to deprecated crypto apis doc/helper-guide

[lng-odp] [API-NEXT 3/3] test: crypto: remove references to deprecated crypto apis

2017-03-07 Thread Dmitry Eremin-Solenikov
From: Petri Savolainen Remove last remaining references to deprecated API definitions. Signed-off-by: Petri Savolainen --- example/ipsec/odp_ipsec_misc.h| 4 ++-- example/ipsec/odp_ipsec_sa_db.c | 4 ++--

[lng-odp] [API-NEXT 2/3] api: crypto: use ODP_DEPRECATED{, _FIELD} declarations

2017-03-07 Thread Dmitry Eremin-Solenikov
Add ODP_DEPRECATED and ODP_DEPRECATED_FIELD declarations to crypto API header, actually urging applications to switch to newer API. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/crypto.h | 26 ++ 1 file chang

  1   2   3   4   5   >