On 04/20/2015 02:04 PM, Taras Kondratiuk wrote:
On 04/17/2015 11:55 PM, Rosenboim, Leonid wrote:
Guys,
There are several versions of the Classifier API document floating in Google
docs, here is one such copy:
https://docs.google.com/document/d/14KMqNPIgd7InwGzdP2EaI9g_V3o0_wxpgp3N-nd-RBE
On 04/22/2015 04:39 PM, Radu-Andrei Bulie wrote:
Hi,
One question. The operation of linking a pmr to a port is performed by pmr
creation function
by providing as src_cos the default port cos?
Right.
___
lng-odp mailing list
lng-odp@lists.linaro.org
On 04/21/2015 10:14 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/odp_pool.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/test/validation/odp_pool.c b/test/validation/odp_pool.c
index 1a518a0..c2f9a1b 100644
---
On 04/22/2015 12:39 AM, Mike Holmes wrote:
Code rules IMHO - the compiler will ensure we follow the rules.
Can we add test cases to prove the behavior across all platforms,
linux-generic being one of them, and thus the code is correct no matter
what is written anywhere else. Presumably the api
On 04/22/2015 02:29 PM, Mike Holmes wrote:
On 22 April 2015 at 07:26, Bill Fischofer bill.fischo...@linaro.org
mailto:bill.fischo...@linaro.org wrote:
Good points. I agree it's better to leave this behavior undefined.
If that is consensus I will send a patch for the docs to add.
please add Reviewed-by tag if you are ok with the patch?
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
On 04/10/2015 06:52 PM, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/packet.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h
index a31c54d..840e152 100644
---
On 04/10/2015 06:52 PM, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/pool.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h
index 241b98a..0092132 100644
--- a/include/odp/api/pool.h
On 04/16/2015 11:35 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
If it stays I want it tested or it will rot like odp_shm has in this
very directory. To test it that probably means that helpers are
independently tested from the API so we need to find the correct
location for the test - maybe
On 04/16/2015 04:29 PM, Mike Holmes wrote:
We have an 80 char limit that is frequently an issue for strings and we
just accept that we ignore the warning.
Allow split strings so that there is a valid alternative
Thus the following example becomes a legal alternative to the 80 chars
warning.
On 04/16/2015 04:50 PM, Mike Holmes wrote:
On 16 April 2015 at 09:41, Taras Kondratiuk taras.kondrat...@linaro.org
mailto:taras.kondrat...@linaro.org wrote:
On 04/16/2015 04:29 PM, Mike Holmes wrote:
We have an 80 char limit that is frequently an issue for strings
and we
On 04/15/2015 05:29 AM, Mike Holmes wrote:
On 14 April 2015 at 16:21, Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org wrote:
On 04/14/15 22:59, Mike Holmes wrote:
The shm test is obsolte, remove it
Why is it obsolete?
A few reasons
It is never called
pmr_id, odp_cos_t src_cos, odp_cos_t dst_cos);
+int odp_pktio_pmr_cos( odp_pktio_t src_pktio, odp_cos_t pktio_cos);
/**
* Inquire about matching terms supported by the classifier
From: Taras Kondratiuk taras.kondrat...@linaro.org
Sent: Wednesday, April 8
On 04/06/2015 07:41 PM, Bill Fischofer wrote:
I would call these pool groups for symmetry with queue groups and so
the API would be odp_pool_create_group(), odp_pool_destroy_group(), etc.
If it is called pool group, then it sounds like a separate
abstraction. Which in turn needs a separate
PMRs with
intermediate CoS queues pointing to 'drop' queue (from your example).
If platform has some limitations then you can hit them either by
cascading single PMRs or creating PMR-sets. So I don't see how a
separate abstraction for PMR-set helps here.
--
Taras Kondratiuk
Sync and Async crypto tests are almost identical and have a lot
duplicated code.
Move unique configuration into testsuite's init function and reuse Async
test code for both Sync and Async.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/Makefile.am
be merged.
The same approach should allow to easily add tests for 'out of place'
operations.
Taras Kondratiuk (2):
validation: crypto: handle synchronous operations in async test
validation: crypto: combine sync and async tests
test/validation/Makefile.am| 3
Current API can't force crypto operation to be strictly sync or async.
Hence test should handle synchronous operation even if 'pref_mode' is
set to ODP_CRYPTO_ASYNC.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.c | 27
On 03/12/2015 12:03 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, March 11, 2015 5:18 PM
To: Savolainen, Petri (Nokia - FI/Espoo); ext Christophe Milard; lng-
o...@lists.linaro.org
On 03/11/2015 04:46 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Continuation of cpumask discussion on the call… For creating arbitrary
masks (e.g. fill in a mask with CPU ids of another ODP program in the
system, or testing all possible mask bits), we may need two more calls:
/**
* @return
On 03/11/2015 10:37 AM, Radu-Andrei Bulie wrote:
Hi,
Regarding the functions that set the proto flags (e.g
*odp_packet_has_xx_set*) isn’t more
suitable not to pass an int value as second parameter, in fact not to
have any parameter at all because
howsoever inside the function we have some
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 2 +
.../include/odp/plat/shared_resource.h | 150 +
platform/linux-keystone2/odp_shr.c
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 4 +-
platform/linux-keystone2/include/odp/event.h | 67 ++
.../linux-keystone2/include/odp/plat
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 5 +-
platform/linux-keystone2/include/odp.h | 2 +
platform/linux-keystone2/include/odp/packet.h | 524
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 3 +-
platform/linux-keystone2/include/odp/packet_io.h | 111 +---
.../include/odp/plat/packet_io_types.h | 42
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 8 +-
platform/linux-keystone2/include/odp.h | 2 +
platform/linux-keystone2/include/odp/buffer.h | 164
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 6 +-
platform/linux-keystone2/include/odp.h | 2 +
.../linux-keystone2/include/odp/plat/queue_types.h | 95
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 3 +-
platform/linux-keystone2/include/odp.h | 2 +
platform/linux-keystone2/include/odp/crypto.h | 366
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 6 +-
platform/linux-keystone2/include/odp.h | 1 +
platform/linux-keystone2/include/odp/plat/state.h| 3
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 15 ++-
platform/linux-keystone2/include/odp.h | 47 ++
platform/linux-keystone2/include/odp/plat
-keystone2. So timer API is not available for now.
Taras Kondratiuk (15):
linux-ks2: update include structure
linux-ks2: debug: sort out after merge
linux-ks2: align: move internal macros to a public place
linux-ks2: align: add ODP_ALIGNOF() macro
linux-ks2: build only init part
linux
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 1 +
platform/linux-keystone2/include/odp/plat/debug.h | 88 ++
.../linux-keystone2/include/odp_debug_internal.h
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 1 +
platform/linux-keystone2/include/odp/plat/osal.h | 310 +++
2 files changed, 311 insertions(+)
create mode
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/Makefile.am | 152 +++--
.../include/{api/odp_buffer.h = odp/buffer.h} | 0
.../{api/odp_buffer_pool.h = odp/buffer_pool.h
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk ta...@ti.com
---
platform/linux-keystone2/include/odp/plat/align.h | 4
1 file changed, 4 insertions(+)
diff --git a/platform/linux-keystone2/include/odp/plat/align.h
b/platform/linux-keystone2
On 03/09/2015 01:05 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Reviewed-by: Petri Savolainen petri.savolai...@nokia.com
/** Packet pool*/
#define ODP_POOL_PACKET ODP_EVENT_PACKET
/** Buffer pool */
#define ODP_POOL_BUFFER ODP_EVENT_BUFFER
/** Timeout pool */
#define
_odp_flush_caches() is called from odp_term_local() now.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_linux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/platform/linux-generic/odp_linux.c
b/platform/linux-generic/odp_linux.c
index 2f95131
ping
On 02/25/2015 11:30 AM, Taras Kondratiuk wrote:
stdarg.h is not needed in odp_debug_internal.h, but instead should be
included in odp_weak.c.
The change is needed to be able to reuse odp_weak.c from other
platforms.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
/platform/linux-generic/odp_weak.c
@@ -14,9 +14,20 @@ int odp_override_log(odp_log_level_e level ODP_UNUSED, const
char *fmt, ...)
Remove ODP_UNUSED. Otherwise
Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org
{
va_list args;
int r;
+ FILE *logfd;
+
+ switch (level
On 02/27/2015 01:19 AM, Taras Kondratiuk wrote:
Current crypto tests have a few issues:
- Asynchronous tests assume that operation is always executed asynchronously,
but specification does not demand it (I hope I read it correctly). So tests
have to handle synchronous operations also
On 02/26/2015 05:45 PM, Mike Holmes wrote:
We need to throttle change in 1.0 to only ODP API only now.
This should go in 1.0.1
Can this be merged now?
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
On 02/26/2015 08:31 PM, Robbie King (robking) wrote:
The only nit that I have, and not sure we have any way around it
today, is the size of the test buffer being hard coded to 32.
Seems eventually that should be a #define for a given implementation's
capabilities, or perhaps a minimum
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/validation/crypto/odp_crypto_test_async_inp.c
b/test/validation/crypto/odp_crypto_test_async_inp.c
On 02/26/2015 05:45 PM, Mike Holmes wrote:
We need to throttle change in 1.0 to only ODP API only now.
This should go in 1.0.1
That's fine.
But it can be reviewed anyway :)
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
the smallest patch. You can change that behaviour:
git diff --patience
git config --global diff.algorithm patience
It works especially when you replace large blocks of lines.
Thanks, great hint!
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp
On 02/05/2015 11:13 AM, Taras Kondratiuk wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/hints.h | 12
platform/linux-generic/include/odp_debug_internal.h | 19 ---
2 files changed, 12 insertions
On 02/26/2015 01:47 PM, Taras Kondratiuk wrote:
On 02/05/2015 11:13 AM, Taras Kondratiuk wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/hints.h | 12
platform/linux-generic/include/odp_debug_internal.h | 19
Sync and Async crypto tests are almost identical and have a lot
duplicated code.
Move unique configuration into testsuite's init function and reuse Async
test code for both Sync and Async.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/Makefile.am
Current API can't force crypto operation to be strictly sync or async.
Hence test should handle synchronous operation even if 'pref_mode' is
set to ODP_CRYPTO_ASYNC.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.c | 19
is a subset of Async -
they can't be merged.
The same approach should allow to easily add tests for 'out of place'
operations.
Taras Kondratiuk (2):
validation: crypto: handle synchronous operations in async test
validation: crypto: combine sync and async tests
test/validation/Makefile.am
Check 'result' pointer before dereferencing it in case of synchronous
operation.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic
should
not destroy resource created by testsuite init function, because it can
be used by other tests.
What are you concern regarding global variable for a pool? Why to do a
lookup if you can just save a handle?
--
Taras Kondratiuk
___
lng-odp mailing list
(-)
Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Kondratiuk taras.kondrat...@linaro.org
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
__odp_errno is a private variable.
odp_errno() function should be used instead.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/odp_pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/odp_pktio.c b/test/validation
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/odp_queue.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c
index 91a32dc..5d47399 100644
--- a/test/validation/odp_queue.c
Number of crypto sessions may be limited by HW. Application should be
able to destroy unused sessions.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/crypto.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/odp/api/crypto.h b/include
On 02/24/2015 02:33 PM, Taras Kondratiuk wrote:
Allocation timeout from an empty pool causes segmentation fault
because an invalid event it passed to odp_timeout_from_event() which
Maxim, will you be able to fix a typo during merge?
s/event it passed/event is passed/
eventually calls
stdarg.h is not needed in odp_debug_internal.h, but instead should be
included in odp_weak.c.
The change is needed to be able to reuse odp_weak.c from other
platforms.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp_debug_internal.h | 1
It doesn't make sense to process crypto operation results if operation
have failed.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.c | 4
1 file changed, 4 insertions(+)
diff --git a/test/validation/crypto
Patches are independent and can be applied separately.
Taras Kondratiuk (3):
validation: crypto: don't create completion pool
validation: crypto: verify odp_crypto_operation() return code
validation: crypto: don't check detailed operation status
test/validation/crypto
Detailed status have to be filled only in case of failed operation.
So don't verify it in case of success.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/test/validation
-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/odp_init_log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/validation/odp_init_log.c b/test/validation/odp_init_log.c
index c072147..275d343 100644
--- a/test/validation/odp_init_log.c
+++ b/test/validation
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_weak.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_weak.c
b/platform/linux-generic/odp_weak.c
index 9dc3a4a..7fa5955 100644
--- a/platform/linux
v2: No code change. Updated commit messages and grouped dependent
patches together.
Mike Holmes (1):
validation: odp_init_log: fix clang format string error
Taras Kondratiuk (2):
api: hints: add printf format attribute
linux-generic: weak: fix -Wformat-nonliteral warning
include/odp
The patch triggers checkpatch warning, but the warning is Linux kernel
specific and should be ignored.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Reviewed-by: Mike Holmes mike.hol...@linaro.org
---
include/odp/api/hints.h | 5 +
1 file changed, 5 insertions(+)
diff --git
Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org
I'll repost this patch with its dependency in one series.
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Add an error code for a case when a session is created without
specifying an IV value, and then crypto operation is invoked without
a valid override_iv_ptr.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/crypto.h | 3 +++
platform
v2: added a separate return code for this case
Taras Kondratiuk (2):
api: crypto: add error code for invalid IV
linux-generic: crypto: fix crypto operation return code for invalid IV
include/odp/api/crypto.h | 3 +++
platform/linux-generic/include/odp/plat
Current code returns an incompatible enum value as an error code in
case of not specified IV. Use a proper return code instead.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
on this.
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
On 02/13/2015 05:13 AM, Bill Fischofer wrote:
On Fri, Feb 13, 2015 at 10:59 AM, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote:
Split pools, buffers, packets tests into separate executables to make
them independent.
Alloc and free API
On 02/19/2015 01:23 PM, Maxim Uvarov wrote:
On 02/19/2015 01:43 PM, Taras Kondratiuk wrote:
On 02/13/2015 05:13 AM, Bill Fischofer wrote:
On Fri, Feb 13, 2015 at 10:59 AM, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org
wrote:
Split pools, buffers
On 02/17/2015 11:35 PM, Maxim Uvarov wrote:
On 02/17/2015 11:28 PM, Bala wrote:
Reviewed-by: Bala Manoharan bala.manoha...@linaro.org
mailto:bala.manoha...@linaro.org
P.S: A similar patch was proposed earlier by Taras also.
Yes, somehow everybody skipped review of Tarases patch set.
Yes,
On 02/18/2015 05:53 PM, Robbie King (robking) wrote:
Hey Mike (and everyone else),
I noticed this code is replicated throughout the patch:
cos_shm = odp_shm_lookup(shm_odp_cos_tbl);
if (cos_shm == ODP_SHM_INVALID)
return -1;
ret = odp_shm_free(cos_shm);
On 02/17/2015 05:49 PM, Maxim Uvarov wrote:
On 02/17/2015 06:35 PM, Taras Kondratiuk wrote:
On 02/17/2015 05:26 PM, Maxim Uvarov wrote:
On 02/17/2015 06:09 PM, Taras Kondratiuk wrote:
On 02/17/2015 05:04 PM, Maxim Uvarov wrote:
On 02/17/2015 05:50 PM, Taras Kondratiuk wrote:
On 02/17/2015
On 02/12/2015 02:31 AM, Mike Holmes wrote:
looks good to me, did you force an abort call to check it works?
I see about 23 locations in the current implementation that call abort,
but I don't know if any can be triggered by API calls in the unit tests
to prove this works.
Please ignore it.
On 02/17/2015 05:26 PM, Maxim Uvarov wrote:
On 02/17/2015 06:09 PM, Taras Kondratiuk wrote:
On 02/17/2015 05:04 PM, Maxim Uvarov wrote:
On 02/17/2015 05:50 PM, Taras Kondratiuk wrote:
On 02/17/2015 04:42 PM, Maxim Uvarov wrote:
On 02/17/2015 04:11 PM, Mike Holmes wrote:
On 17 February
On 02/17/2015 05:04 PM, Maxim Uvarov wrote:
On 02/17/2015 05:50 PM, Taras Kondratiuk wrote:
On 02/17/2015 04:42 PM, Maxim Uvarov wrote:
On 02/17/2015 04:11 PM, Mike Holmes wrote:
On 17 February 2015 at 07:57, Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org wrote:
I
/api/version.h
+#include odp/plat/version_types.h
#include odp/version.h
will include them both.
Also you won't have to touch these lines in patch #2.
+
+const char *odp_version_api_str(void)
+{
+ return ODP_VERSION_API_STR;
+}
If above comment are addressed, then
Reviewed-by: Taras
On 02/16/2015 02:07 PM, Maxim Uvarov wrote:
On 02/16/2015 02:58 PM, Taras Kondratiuk wrote:
On 02/11/2015 09:09 AM, Maxim Uvarov wrote:
Patch 1 and 2 have to go before current tag. Others can go latter.
Maxim Uvarov (6):
linux-generic: imp.c: remove header defines from c file
linux
char *odp_version_impl_str(void)
#ifdef __cplusplus
}
#endif
-
-#endif
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
/version.h
#define ODP_VERSION_IMPL 0
@@ -24,7 +14,3 @@ const char *odp_version_impl_str(void)
{
return ODP_VERSION_IMPL_STR;
}
-
-#ifdef __cplusplus
-}
-#endif
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
(+), 17 deletions(-)
delete mode 100644 platform/linux-generic/odp_impl.c
If odp_impl.c is removed, then why clean-up patches #1 and #4 are
needed?
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman
(ODP_VERSION_IMPL)
-
const char *odp_version_impl_str(void)
{
return ODP_VERSION_IMPL_STR;
--
Taras Kondratiuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
patches which are logically
dependent. To understand what this series is doing one have to merge
patches in mind or apply them locally. Some patches seems to be
redundant. This looks like one logical change which can be one patch of
digestible size.
--
Taras Kondratiuk
Split pools, buffers, packets tests into separate executables to make
them independent.
Alloc and free API functions are now part of corresponding event types:
buffers, packets, timeouts, etc. Hence remove them from pool tests.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp/plat/strong_types.h | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/platform/linux-generic/include/odp/plat/strong_types.h
b/platform/linux-generic/include/odp
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp_debug_internal.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/include/odp_debug_internal.h
b/platform/linux-generic/include/odp_debug_internal.h
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/buffer.h | 19 +++
include/odp/api/pool.h| 20
platform/linux-generic/include/odp/pool.h | 1 +
3 files changed, 20 insertions(+), 20
Start header guards with ODP_API_ prefix to avoid confusion with other
files with the same name.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/align.h | 4 ++--
include/odp/api/atomic.h | 4 ++--
include/odp/api/barrier.h| 4
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
example/Makefile.inc | 1 +
test/Makefile.inc| 1 +
2 files changed, 2 insertions(+)
diff --git a/example/Makefile.inc b/example/Makefile.inc
index 91f8f49..b3a9706 100644
--- a/example/Makefile.inc
+++ b/example/Makefile.inc
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/hints.h | 12
platform/linux-generic/include/odp_debug_internal.h | 19 ---
2 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/include/odp/api
odp_global_data should be defined once in a C file.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp_internal.h | 6 --
platform/linux-generic/odp_init.c | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
On 02/05/2015 07:40 PM, Bill Fischofer wrote:
This looks like a reasonable precaution.
Changes to ticketlock.h were not saved in editor, so it is missed.
I'll post v2.
___
lng-odp mailing list
lng-odp@lists.linaro.org
On 02/04/2015 12:28 AM, Ola Liljedahl wrote:
On 3 February 2015 at 23:24, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
On 02/03/2015 11:57 PM, Ola Liljedahl wrote:
The re-org has make it easier for the implementors of ODP.
However, its a bit harder to follow the structure now maybe
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 46766fa..fa7d51f 100644
--- a/platform/linux
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_weak.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_weak.c
b/platform/linux-generic/odp_weak.c
index 9dc3a4a..7fa5955 100644
--- a/platform/linux
Fix all reported errors.
Taras Kondratiuk (5):
api: debug: fix static assert macro
linux-generic: classification: Remove typedef forward declarations
linux-generic: crypto: fix crypto_alg_err enum return values
api: hints: add printf format attribute
linux-generic: weak: fix -Wformat
1 - 100 of 374 matches
Mail list logo
