Re: [lng-odp] [PATCH] Add 64 bit context to packet

2014-08-19 Thread Robbie King (robking)
...@linaro.org] Sent: Tuesday, August 19, 2014 9:47 AM To: Robbie King (robking) Cc: Bill Fischofer; lng-odp-forward Subject: Re: [lng-odp] [PATCH] Add 64 bit context to packet Better use a pointer than a 64 bit integer. On a 32 bit system, someone may use this to store both a pointer and a 32-bit

Re: [lng-odp] [PATCH v4 1/1] API support for querying mac address

2014-08-20 Thread Robbie King (robking)
Hi Bala, I patched this in and was able to query mac address using odp_pktio_t handle. Thanks! -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Balasubramanian Manoharan Sent: Wednesday, August 20, 2014 10:08 AM To:

Re: [lng-odp] [PATCHv2 0/2] Add infrastructure required by IPSec example

2014-08-21 Thread Robbie King (robking)
Please ignore this one, I will put these out as part of the IPsec example application patch. -Original Message- From: Robbie King (robking) Sent: Tuesday, August 19, 2014 10:31 AM To: lng-odp@lists.linaro.org Cc: Robbie King (robking) Subject: [PATCHv2 0/2] Add infrastructure required

Re: [lng-odp] [PATCH 00/13] IPsec example application

2014-08-21 Thread Robbie King (robking)
will add the scheduling logic back and merge the patches, then resend later today. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, August 21, 2014 11:20 AM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 00/13

[lng-odp] Any restrictions on when odp_pktio_open can be called?

2014-08-24 Thread Robbie King (robking)
Hi Petri, my apologies if you’re not the right person for my question. I’m working on the Cisco DP port to ODP, and I’ve hit a problem that I’m trying to root cause. I am calling “odp_pktio_open” after worker threads have started calling odp_schedule, but I’m not seeing any work from the input

Re: [lng-odp] Any restrictions on when odp_pktio_open can be called?

2014-08-24 Thread Robbie King (robking)
Never mind. ;-) Bug in my code, now just have to back out 37 printfs. Really need to start using “git branch” when going down these rat holes… From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Robbie King (robking) Sent: Sunday, August 24, 2014 3:03

Re: [lng-odp] Clarification of ICV handling in linux-generic crypto...

2014-08-25 Thread Robbie King (robking)
Badicioiu [mailto:alexandru.badici...@linaro.org] Sent: Monday, August 25, 2014 10:38 AM To: Robbie King (robking) Cc: Taras Kondratiuk; lng-odp-forward (lng-odp@lists.linaro.org); Bala Manoharan Subject: Re: Clarification of ICV handling in linux-generic crypto... Hi Robbie, if I understand correctly

Re: [lng-odp] [PATCHv3 2/4] Add helper include file with IPSec headers

2014-08-27 Thread Robbie King (robking)
Haslam [mailto:stuart.has...@arm.com] Sent: Wednesday, August 27, 2014 8:37 AM To: Savolainen, Petri (NSN - FI/Espoo) Cc: Robbie King (robking); Victor Kamensky; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv3 2/4] Add helper include file with IPSec headers On Wed, Aug 27, 2014 at 01:10:13PM

Re: [lng-odp] [PATCH v4 1/1] API support for querying mac address

2014-09-03 Thread Robbie King (robking)
Anders has requested that I put a bugID in my patches for IPsec example application where I have a #define to work around the fact this patch isn't in yet. Does such a bugID already exist, or is there a chance this patch will be accepted soon? I would really like to get the IPsec app patches in

Re: [lng-odp] [PATCHv3 0/4] IPsec example application

2014-09-03 Thread Robbie King (robking)
Taras, do you have a bug ID for the IPSEC_POLL_QUEUES workaround? Anders has requested that be included in my IPsec application patch. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Tuesday, August 26, 2014 10:42 AM To: Robbie King (robking); lng-odp

Re: [lng-odp] [PATCHv3 0/4] IPsec example application

2014-09-04 Thread Robbie King (robking)
apologies if these details are already spelled out somewhere. Thanks, Robbie -Original Message- From: Anders Roxell [mailto:anders.rox...@linaro.org] Sent: Thursday, September 04, 2014 8:25 AM To: Taras Kondratiuk Cc: Robbie King (robking); lng-odp@lists.linaro.org; Mike Holmes (Google Drive

Re: [lng-odp] [PATCHv5 4/4] Add IPsec example app to build environment

2014-09-04 Thread Robbie King (robking)
Thanks Anders, sorry just getting to this. Please see [rk] inline, need to get clarification on a couple things. -Original Message- From: Anders Roxell [mailto:anders.rox...@linaro.org] Sent: Friday, August 29, 2014 11:02 AM To: Robbie King (robking) Cc: lng-odp@lists.linaro.org Subject

Re: [lng-odp] [PATCHv7 0/4] IPsec example application

2014-09-12 Thread Robbie King (robking)
Woo hoo! Thanks everyone, see you next week. Safe travels. Sent from Ninehttp://www.9folders.com/ From: Maxim Uvarov maxim.uva...@linaro.org Sent: Sep 12, 2014 5:01 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv7 0/4] IPsec example application Patch was merged, thanks Robbie

[lng-odp] LCU14:ODP discussions after lunch today?

2014-09-15 Thread Robbie King (robking)
Thought I remembered discussions about afternoon sessions. Thanks, Robbie ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] LCU14:ODP discussions after lunch today?

2014-09-15 Thread Robbie King (robking)
Got it, thanks. Copying Blake as well. From: Marshall Guillory marshall.guill...@linaro.org Sent: Sep 15, 2014 11:11 AM To: Robbie King (robking) Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] LCU14:ODP discussions after lunch today? ODP Project UPdate from Bill is at 1210pm in Grand

Re: [lng-odp] crypto session/operation symmetry testing

2014-10-09 Thread Robbie King (robking)
...@linaro.org] Sent: Wednesday, August 20, 2014 10:51 AM To: Robbie King (robking) Cc: Taras Kondratiuk; lng-odp-forward (lng-odp@lists.linaro.org); Bala Manoharan Subject: Re: Clarification of ICV handling in linux-generic crypto... Hi Robbie, I noticed myself that the application takes care

Re: [lng-odp] [PATCH] ipsec: Fix ctx-state update race

2014-11-18 Thread Robbie King (robking)
Oops! Good catch. I looked and I don't see any other manifestations. Reviewed-by: Robert King robk...@cisco.com Robbie. -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Jerin Jacob Sent: Friday, November 14, 2014 6:31

Re: [lng-odp] [PATCH] API: crypto: Remove unused async API

2014-11-25 Thread Robbie King (robking)
Reviewed-by: Robert King robk...@cisco.com From: lng-odp-boun...@lists.linaro.org [lng-odp-boun...@lists.linaro.org] on behalf of Mike Holmes [mike.hol...@linaro.org] Sent: Monday, November 24, 2014 12:18 PM To: lng-odp@lists.linaro.org Subject: [lng-odp]

[lng-odp] Build failure with older GCC versions...

2014-12-09 Thread Robbie King (robking)
After cloning tip just now, I found that I couldn’t build the fresh workspace due to having GCC 4.6.3 (the C11 changes to the atomics bumps minimum GCC up to 4.8 as best I can tell). I’m not very familiar with what “./configure” can and can’t do, but it seems we should verify the compiler

Re: [lng-odp] Build failure with older GCC versions...

2014-12-10 Thread Robbie King (robking)
, December 10, 2014 4:32 AM To: Robbie King (robking) Cc: lng-odp-forward (lng-odp@lists.linaro.org) Subject: Re: [lng-odp] Build failure with older GCC versions... On 9 December 2014 at 17:48, Robbie King (robking) robk...@cisco.com wrote: After cloning tip just now, I found that I couldn’t build

Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new completion event constructs

2014-12-11 Thread Robbie King (robking)
See [rk] below. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Wednesday, December 10, 2014 7:12 PM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new completion event

Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new completion event constructs

2014-12-11 Thread Robbie King (robking)
Ahh, now I see what you mean. Good catch. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, December 11, 2014 9:39 AM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new

Re: [lng-odp] [PATCH 0/3] linux-generic: crypto: fix validation tests failures

2014-12-15 Thread Robbie King (robking)
Yes working on it today -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Monday, December 15, 2014 9:37 AM To: lng-odp@lists.linaro.org; Robbie King (robking) Subject: Re: [PATCH 0/3] linux-generic: crypto: fix validation tests failures Hi Robby

Re: [lng-odp] [PATCHv2 0/4] linux-generic: crypto: fix validation tests failures

2014-12-18 Thread Robbie King (robking)
Yes, my apologies I thought I had responded to it. From: Taras Kondratiuk taras.kondrat...@linaro.org Sent: Dec 18, 2014 7:09 AM To: Robbie King (robking) Cc: Maxim Uvarov maxim.uva...@linaro.org;lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv2 0/4] linux-generic: crypto: fix validation

Re: [lng-odp] [PATCHv4 0/5] api: crypto: ODP 1.0 API update

2015-01-30 Thread Robbie King (robking)
Awesome, thanks guys. I could see from the hangout this AM that it was a non-trivial exercise... -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Friday, January 30, 2015 11:32 AM To:

Re: [lng-odp] [PATCH 1/2] api: random: Added random.h

2015-02-04 Thread Robbie King (robking)
Per our conversation on today's call we are making the API change and still have the future @todo to document entropy once we have input for vendor implementations. Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp-boun...@lists.linaro.org

Re: [lng-odp] [PATCHv3 0/9] implement odp_cpumask to the latest spec

2015-01-15 Thread Robbie King (robking)
Thanks for all your help Anders! -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Anders Roxell Sent: Wednesday, January 14, 2015 5:48 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCHv3 0/9] implement odp_cpumask to

Re: [lng-odp] [PATCH 3/5] linux-generic: crypto: fix crypto_alg_err enum return values

2015-02-17 Thread Robbie King (robking)
King (robking); Alexandru Badicioiu; Maxim Uvarov Subject: Re: [lng-odp] [PATCH 3/5] linux-generic: crypto: fix crypto_alg_err enum return values Robbie, Alex, please review that patch. Maxim. On 02/04/2015 03:00 PM, Taras Kondratiuk wrote: Signed-off-by: Taras Kondratiuk taras.kondrat

Re: [lng-odp] [PATCH v2 00/10] add global and local termination

2015-02-18 Thread Robbie King (robking)
Hey Mike (and everyone else), I noticed this code is replicated throughout the patch: cos_shm = odp_shm_lookup(shm_odp_cos_tbl); if (cos_shm == ODP_SHM_INVALID) return -1; ret = odp_shm_free(cos_shm); As I was looking to make the changes we discussed

Re: [lng-odp] [PATCH v2 00/10] add global and local termination

2015-02-18 Thread Robbie King (robking)
[mailto:taras.kondrat...@linaro.org] Sent: Wednesday, February 18, 2015 11:01 AM To: Robbie King (robking) Cc: Mike Holmes; lng-odp@lists.linaro.org; Petri Savolainen (petri.savolai...@linaro.org) Subject: Re: [lng-odp] [PATCH v2 00/10] add global and local termination On 02/18/2015 05:53 PM, Robbie King

Re: [lng-odp] [PATCHv2 0/3] api: crypto: ODP 1.0 API update

2015-01-27 Thread Robbie King (robking)
sorry forgot to fix that, will make the change -Original Message- From: Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Tuesday, January 27, 2015 10:26 AM To: Robbie King (robking) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCHv2 0/3] api: crypto: ODP 1.0 API update Have

[lng-odp] ODP coremask changes...

2015-01-09 Thread Robbie King (robking)
Hey Petri, I have instrumented the ODP coremask APIs using the “CPU_xxx” macros and unit tested things. The other piece is to convert the pthread and process creation helper routines to use masks versus a starting core and count. To minimize the upheaval I thought it might make sense to also

Re: [lng-odp] [PATCHv2 1/2] Convert linux thread/proc helpers to use core mask

2015-01-13 Thread Robbie King (robking)
Yes, that’s a good point. A quick usage blurb would be useful. -Original Message- From: Savolainen, Petri (NSN - FI/Espoo) [mailto:petri.savolai...@nsn.com] Sent: Tuesday, January 13, 2015 10:33 AM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: RE: [lng-odp] [PATCHv2 1/2

Re: [lng-odp] [PATCHv2 1/2] Convert linux thread/proc helpers to use core mask

2015-01-13 Thread Robbie King (robking)
(mask, cpu); * } * * @param maskCPU mask to find next cpu in * @param cpu CPU to start from * @return cpu found else -1 */ -Original Message- From: Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Tuesday, January 13, 2015 10:58 AM To: Robbie King (robking) Cc

Re: [lng-odp] [PATCHv1 2/3] validation: crypto: add common test cleanup

2015-03-03 Thread Robbie King (robking)
CU_ASSERT doesn't seem to work within the term_global routine, apparently they can only be called within the tests themselves? At the moment I'm inclined to leave my patch as is. -Original Message- From: Robbie King (robking) Sent: Tuesday, March 03, 2015 9:08 AM To: 'Maxim Uvarov'; lng

Re: [lng-odp] [RFC 0/2] validation: crypto: remove code duplication

2015-03-03 Thread Robbie King (robking)
Sorry Taras I haven't. I'll try to get to it today. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Tuesday, March 03, 2015 11:24 AM To: Robbie King (robking) Cc: lng-odp@lists.linaro.org; mike.hol...@linaro.org Subject: Re: [RFC 0/2] validation

Re: [lng-odp] [RFC 0/2] validation: crypto: remove code duplication

2015-03-03 Thread Robbie King (robking)
...@linaro.org; Robbie King (robking); Taras Kondratiuk Subject: [RFC 0/2] validation: crypto: remove code duplication Current crypto tests have a few issues: - Asynchronous tests assume that operation is always executed asynchronously, but specification does not demand it (I hope I read it correctly

Re: [lng-odp] [PATCHv1 2/3] validation: crypto: add common test cleanup

2015-03-03 Thread Robbie King (robking)
I believe this will always print the one of the two legs even when successful: if ((ODP_POOL_INVALID != pool odp_pool_destroy(pool)) fprintf(stderr, Completion pool destroy failed.\n); else fprintf(stderr, Completion pool not found.\n); I will change to the CUnit

Re: [lng-odp] [PATCH 2/3] validation: crypto: verify odp_crypto_operation() return code

2015-02-25 Thread Robbie King (robking)
: mike.hol...@linaro.org; Robbie King (robking); Taras Kondratiuk Subject: [PATCH 2/3] validation: crypto: verify odp_crypto_operation() return code It doesn't make sense to process crypto operation results if operation have failed. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test

Re: [lng-odp] [PATCHv3 00/10] add global and local termination

2015-02-23 Thread Robbie King (robking)
Makes perfect sense to me ;-) From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Monday, February 23, 2015 6:39 PM To: Robbie King (robking) Cc: Bill Fischofer; LNG ODP Mailman List Subject: Re: [lng-odp] [PATCHv3 00/10] add global and local termination Ok so this is a little superstitious

Re: [lng-odp] [PATCHv3 07/10] linux-generic: thread: add term_global

2015-02-24 Thread Robbie King (robking)
Yep that's a precious resource. -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Tuesday, February 24, 2015 10:41 AM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv3 07/10] linux-generic: thread: add term_global On 02/24

Re: [lng-odp] [PATCHv3 08/10] linux-generic: shm: add term_global

2015-02-24 Thread Robbie King (robking)
Fixed. -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Tuesday, February 24, 2015 8:07 AM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv3 08/10] linux-generic: shm: add term_global On

Re: [lng-odp] [PATCHv3 07/10] linux-generic: thread: add term_global

2015-02-24 Thread Robbie King (robking)
Hey Maxim, are you saying we should be setting this memory to zero immediately before we free it? To my knowledge we're not doing that any where else. + + ret = odp_shm_free(odp_shm_lookup(odp_thread_globals)); + if (ret 0) + ODP_ERR(shm free failed for

Re: [lng-odp] [PATCHv3 06/10] linux-generic: buffer_pool: add term_global

2015-02-24 Thread Robbie King (robking)
From our discussion on the call, the idea in the linux-generic term functions is just to point out to the application that it did not clean up correctly (i.e. here it prints an error message about a pool not being destroyed). Beyond that it's assumed that the operating system will clean

Re: [lng-odp] [PATCHv3 03/10] linux-generic: packet_io: add term_global

2015-02-24 Thread Robbie King (robking)
My understanding of the pktio global termination is that it is simply cleaning up queues that it created internally in order to prevent termination issues for the other sub systems (like odp_queue.c) in linux generic. -Original Message- From: lng-odp-boun...@lists.linaro.org

Re: [lng-odp] [PATCHv3 05/10] linux-generic: queue: add term_global

2015-02-24 Thread Robbie King (robking)
Same here, just pointing out to the application that it has left queues in an undefined state. -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Tuesday, February 24, 2015 8:36 AM To:

Re: [lng-odp] [PATCHv2 0/2] fix crypto operation return code for invalid IV

2015-02-24 Thread Robbie King (robking)
, February 24, 2015 6:03 AM To: lng-odp@lists.linaro.org Cc: Robbie King (robking); Taras Kondratiuk Subject: [PATCHv2 0/2] fix crypto operation return code for invalid IV v2: added a separate return code for this case Taras Kondratiuk (2): api: crypto: add error code for invalid IV linux-generic

Re: [lng-odp] [PATCHv3 07/10] linux-generic: thread: add term_global

2015-02-24 Thread Robbie King (robking)
OK, cool. I removed the unnecessary set to zero. -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Tuesday, February 24, 2015 10:16 AM To: Robbie King (robking); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv3 07/10] linux-generic: thread: add

Re: [lng-odp] [PATCHv3 00/10] add global and local termination

2015-02-23 Thread Robbie King (robking)
Thanks Bill and yes you're absolutely correct. We probably need bugs and owners. I'll have a look at crypto. From: Bill Fischofer bill.fischo...@linaro.org Sent: Feb 23, 2015 6:13 PM To: Robbie King (robking) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCHv3 00/10] add global and local

Re: [lng-odp] [PATCH] linux-generic: odp_crypto: use intptr_t to find the pointer

2015-02-26 Thread Robbie King (robking)
it should be done at some point before being (re)used. -Original Message- From: Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Thursday, February 26, 2015 12:49 PM To: Anders Roxell; Taras Kondratiuk; Robbie King (robking) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH] linux

Re: [lng-odp] [PATCH] linux-generic: odp_crypto: use intptr_t to find the pointer

2015-02-26 Thread Robbie King (robking)
[mailto:ola.liljed...@linaro.org] Sent: Thursday, February 26, 2015 2:14 PM To: Robbie King (robking) Cc: Anders Roxell; Taras Kondratiuk; LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH] linux-generic: odp_crypto: use intptr_t to find the pointer On 26 February 2015 at 18:52, Robbie King

Re: [lng-odp] [PATCH] validation: crypto: split crypto and random tests

2015-02-26 Thread Robbie King (robking)
. Reviewed-and-tested-by: Robbie King robk...@cisco.com -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, February 26, 2015 8:26 AM To: lng-odp@lists.linaro.org Cc: mike.hol...@linaro.org; Robbie King (robking); Taras Kondratiuk Subject: [PATCH

Re: [lng-odp] [PATCHv2 0/2] fix crypto operation return code for invalid IV

2015-02-26 Thread Robbie King (robking)
Sorry for being dense Mike, do you need me to do something else? From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Thursday, February 26, 2015 4:01 PM To: Robbie King (robking) Cc: Taras Kondratiuk; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv2 0/2] fix crypto operation return

Re: [lng-odp] [PATCH 3/5] linux-generic: crypto: fix crypto_alg_err enum return values

2015-02-20 Thread Robbie King (robking)
Sorry, did a new patch set with my recommended change come out and I missed it? From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Friday, February 20, 2015 11:54 AM To: Robbie King (robking) Cc: Maxim Uvarov; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 3/5] linux-generic: crypto

Re: [lng-odp] [PATCH 0/3] validation: crypto: few fixes

2015-02-25 Thread Robbie King (robking)
Applies to complete patch series. Reviewed-and-tested-by: Robbie King robk...@cisco.com -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Wednesday, February 25, 2015 6:14 AM To: lng-odp@lists.linaro.org Cc: mike.hol...@linaro.org; Robbie King (robking

Re: [lng-odp] [PATCH] linux-generic: crypto: check 'result' pointer

2015-02-26 Thread Robbie King (robking)
Reviewed-by: Robert King robk...@cisco.com -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, February 26, 2015 5:48 PM To: lng-odp@lists.linaro.org Cc: Robbie King (robking); Taras Kondratiuk Subject: [PATCH] linux-generic: crypto: check

Re: [lng-odp] [API-NEXT PATCH v2 1/5] api: packet_io: change word instance to interface

2015-04-29 Thread Robbie King (robking)
Hey Petri, I like the API changes. A very minor nit, looks like a few places where extra whitespace got injected if you happen to be making other changes. The review is for the patch set. Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp

Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel mode support

2015-05-18 Thread Robbie King (robking)
Hi Maxim, Steve Kordus is going to handle this one. Thanks Steve! -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Monday, May 18, 2015 12:56 PM To: lng-odp@lists.linaro.org; Robbie King (robking) Subject: Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel

Re: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: handle alloc_pkt_ctx failure

2015-04-09 Thread Robbie King (robking)
Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of alexandru.badici...@linaro.org Sent: Wednesday, April 08, 2015 2:28 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec:

Re: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: runtime select scheduled vs poll queues

2015-04-09 Thread Robbie King (robking)
Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of alexandru.badici...@linaro.org Sent: Wednesday, April 08, 2015 2:28 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: