Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: .travis.yml line 4 @@ -58,6 +58,7 @@ env: - CONF="--enable-schedule-scalable" - CONF="--enable-dpdk-zero-copy" - CONF="--disable-static-applications" +- CONF="--enable-pcapng-support" Comment: @apalos I

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/m4/odp_pcapng.m4 line 17 @@ -0,0 +1,19 @@ +## +# Enable PCAPNG support +

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/odp_packet_io.c line 12 @@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl) sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq); } + if (ODP_PCAPNG) { Comment: There

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: platform/linux-generic/odp_packet_io.c line 56 @@ -1650,18 +1659,30 @@ int odp_pktout_queue(odp_pktio_t pktio, odp_pktout_queue_t queues[], int num) return num_queues; } +static inline void dump_pcapng_pkts(pktio_entry_t *entry, int

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: doc/users-guide/users-guide.adoc line 4 @@ -1198,4 +1198,6 @@ include::users-guide-tm.adoc[] include::users-guide-cls.adoc[] +include::users-guide-utilities-examples.adoc[] Comment: will fix > Ilias Apalodimas(apalos) wrote: > no the ext

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: doc/users-guide/users-guide-utilities-examples.adoc line 8 @@ -0,0 +1,17 @@ +== Utilities and examples + +=== PcapNg capture +If compiled using `--enable-pcapng-support` ODP will offer packet capturing +functionality in PcapNg format. If /var/ru

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: .travis.yml line 4 @@ -58,6 +58,7 @@ env: - CONF="--enable-schedule-scalable" - CONF="--enable-dpdk-zero-copy" - CONF="--disable-static-applications" +- CONF="--enable-pcapng-support" Comment: Cuinit caught a

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: platform/linux-generic/m4/odp_pcapng.m4 line 17 @@ -0,0 +1,19 @@ +## +# Enable PCAPNG support +## +ha

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-20 Thread Github ODP bot
Ilias Apalodimas(apalos) replied on github web page: platform/linux-generic/odp_packet_io.c line 12 @@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl) sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq); } + if (ODP_PCAPNG) { Comment: This is how

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-19 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/odp_packet_io.c line 12 @@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl) sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq); } + if (ODP_PCAPNG) { Comment

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-19 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: doc/users-guide/users-guide-utilities-examples.adoc line 8 @@ -0,0 +1,17 @@ +== Utilities and examples + +=== PcapNg capture +If compiled using `--enable-pcapng-support` ODP will offer packet capturing +functionality in PcapNg forma

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-19 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: doc/users-guide/users-guide.adoc line 4 @@ -1198,4 +1198,6 @@ include::users-guide-tm.adoc[] include::users-guide-cls.adoc[] +include::users-guide-utilities-examples.adoc[] Comment: Having this as a section of the User Guide

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-19 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: .travis.yml line 4 @@ -58,6 +58,7 @@ env: - CONF="--enable-schedule-scalable" - CONF="--enable-dpdk-zero-copy" - CONF="--disable-static-applications" +- CONF="--enable-pcapng-support" Comment: @l

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-16 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/odp_packet_io.c line 56 @@ -1650,18 +1659,30 @@ int odp_pktout_queue(odp_pktio_t pktio, odp_pktout_queue_t queues[], int num) return num_queues; } +static inline void dump_pcapng_pkts(pktio_entry_t *entry

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-16 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/odp_packet_io.c line 12 @@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl) sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq); } + if (ODP_PCAPNG) { Comment: And a

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-16 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: .travis.yml line 4 @@ -58,6 +58,7 @@ env: - CONF="--enable-schedule-scalable" - CONF="--enable-dpdk-zero-copy" - CONF="--disable-static-applications" +- CONF="--enable-pcapng-support" Comment: I'm think

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-16 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/odp_packet_io.c line 12 @@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl) sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq); } + if (ODP_PCAPNG) { Comment: Neat

Re: [lng-odp] [PATCH v1] odp: pktio: add pcapng capture capabilities

2018-02-16 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/m4/odp_pcapng.m4 line 17 @@ -0,0 +1,19 @@ +## +# Enable PCAPNG support +