[jira] [Commented] (LOG4J2-1051) NoClassDefFoundError when starting app on Google App Engine

[ https://issues.apache.org/jira/browse/LOG4J2-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508836#comment-15508836 ] Frank Conover commented on LOG4J2-1051: --- Same error. Same line number. BTW This is a java desktop

[jira] [Commented] (LOG4J2-1051) NoClassDefFoundError when starting app on Google App Engine

[ https://issues.apache.org/jira/browse/LOG4J2-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508775#comment-15508775 ] Gary Gregory commented on LOG4J2-1051: -- Please try the 2.6.3-SNAPSHOT files from our SNAPSHOT

[jira] [Commented] (LOG4J2-1051) NoClassDefFoundError when starting app on Google App Engine

[ https://issues.apache.org/jira/browse/LOG4J2-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508725#comment-15508725 ] Frank Conover commented on LOG4J2-1051: --- I see the following with 2.6.2 and the latest api

Re: Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

As was Objects.hashcode(...). Sorry for the noise, as you were ... Greg -- Sent from my iPhone > On 21 Sep 2016, at 03:17, Remko Popma wrote: > > Sorry I was thinking of Long.hashCode(long), but I see now that this was > introduced in java 1.8... > > Sent from my

Re: Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

Sorry I was thinking of Long.hashCode(long), but I see now that this was introduced in java 1.8... Sent from my iPhone > On 2016/09/21, at 10:09, Gary Gregory wrote: > > Where do you see such a method? > > Gary > >> On Tue, Sep 20, 2016 at 4:43 PM, Remko Popma

Jenkins build is back to stable : Log4j 2.x #2340

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508383#comment-15508383 ] Remko Popma commented on LOG4J2-1010: - I was unable to work on this yesterday but I will try to

Re: logging-log4j2 git commit: Add equals() and hashCode() since Log4jLogEvent's equals() and hashCode() depends on them, all implementors should implement these methods.

It has to be in the contract (the interface) because it signals the intent and expectation formally. That, and it let's the compiler's lint pass (depending on the compiler), tooling, and FindBugs provide better feedback. Gary On Tue, Sep 20, 2016 at 5:03 PM, Remko Popma

Re: Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

Where do you see such a method? Gary On Tue, Sep 20, 2016 at 4:43 PM, Remko Popma wrote: > Objects.hashCode(long) does exactly the same, but is certainly easier to > read. Go for it! > > Sent from my iPhone > > On 2016/09/21, at 5:06, Greg Thomas

[jira] [Closed] (LOG4J2-1599) Prevent potential NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

[ https://issues.apache.org/jira/browse/LOG4J2-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1599. Resolution: Fixed > Prevent potential NPE in >

Re: NPE's reported by FindBugs

Done. Gary On Tue, Sep 20, 2016 at 6:04 PM, Gary Gregory wrote: > Sure, will do. > > Gary > > On Tue, Sep 20, 2016 at 4:40 PM, Remko Popma > wrote: > >> It's good to prevent potential NPEs of course, but in the release notes >> (changes.xml) can

[jira] [Updated] (LOG4J2-1599) Prevent potential NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

[ https://issues.apache.org/jira/browse/LOG4J2-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1599: - Summary: Prevent potential NPE in

[jira] [Reopened] (LOG4J2-1600) NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1600: -- > NPE due to >

[jira] [Updated] (LOG4J2-1601) Prevent potential NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configur

[ https://issues.apache.org/jira/browse/LOG4J2-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1601: - Summary: Prevent potential NPE due to

[jira] [Closed] (LOG4J2-1601) Prevent potential NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configura

[ https://issues.apache.org/jira/browse/LOG4J2-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1601. Resolution: Fixed > Prevent potential NPE due to >

[jira] [Closed] (LOG4J2-1600) Prevent potential NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1600. Resolution: Fixed > Prevent potential NPE due to >

[jira] [Reopened] (LOG4J2-1599) NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

[ https://issues.apache.org/jira/browse/LOG4J2-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1599: -- > NPE in > org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, >

[jira] [Updated] (LOG4J2-1600) Prevent potential NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1600: - Summary: Prevent potential NPE due to

[jira] [Reopened] (LOG4J2-1601) NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1601: -- > NPE due to >

[jira] [Updated] (LOG4J2-1602) Prevent potential NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

[ https://issues.apache.org/jira/browse/LOG4J2-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1602: - Summary: Prevent potential NPE in

[jira] [Closed] (LOG4J2-1602) Prevent potential NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

[ https://issues.apache.org/jira/browse/LOG4J2-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1602. Resolution: Fixed > Prevent potential NPE in >

[jira] [Updated] (LOG4J2-1602) Prevented potential NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

[ https://issues.apache.org/jira/browse/LOG4J2-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1602: - Summary: Prevented potential NPE in

[jira] [Reopened] (LOG4J2-1602) NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

[ https://issues.apache.org/jira/browse/LOG4J2-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1602: -- > NPE in > org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) >

Re: NPE's reported by FindBugs

Sure, will do. Gary On Tue, Sep 20, 2016 at 4:40 PM, Remko Popma wrote: > It's good to prevent potential NPEs of course, but in the release notes > (changes.xml) can we change the explanation to _prevented potential_ NPEs? > > As it stands the release notes make it look

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508223#comment-15508223 ] Ralph Goers commented on LOG4J2-1010: - If it is immutable then I would think you could just always

Jenkins build became unstable: Log4j 2.x #2339

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: logging-log4j2 git commit: Add equals() and hashCode() since Log4jLogEvent's equals() and hashCode() depends on them, all implementors should implement these methods.

It may be more effective to add a "note to implementors" to that effect in the javadoc. Programmers are more likely to follow your advice if they know the reason behind it. Sent from my iPhone > On 2016/09/21, at 8:29, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated

Re: Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

Objects.hashCode(long) does exactly the same, but is certainly easier to read. Go for it! Sent from my iPhone > On 2016/09/21, at 5:06, Greg Thomas wrote: > > Could you use simply > > return Objects.hashcode(...) > > To avoid the maths In the first place ?? > -- >

NPE's reported by FindBugs

It's good to prevent potential NPEs of course, but in the release notes (changes.xml) can we change the explanation to _prevented potential_ NPEs? As it stands the release notes make it look like we're having massive issues with NullPointerExceptions... Sent from my iPhone

Bug in pattern or usage

We have code like this in a couple of places: final String search = String.format(StatusLoggerAdminMBean.PATTERN, escape(contextName), "*"); Where: String PATTERN = Server.DOMAIN + ":type=%s,component=StatusLogger"; And: public static final String DOMAIN =

Jenkins build is back to stable : Log4j 2.x #2338

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1603) Redo hashCode() and equals() methods in org.apache.logging.log4j.core.net.ssl classes.

Gary Gregory created LOG4J2-1603: Summary: Redo hashCode() and equals() methods in org.apache.logging.log4j.core.net.ssl classes. Key: LOG4J2-1603 URL: https://issues.apache.org/jira/browse/LOG4J2-1603

[jira] [Closed] (LOG4J2-1602) NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

[ https://issues.apache.org/jira/browse/LOG4J2-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1602. Resolution: Fixed In Git master. > NPE in >

[jira] [Created] (LOG4J2-1602) NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null

Gary Gregory created LOG4J2-1602: Summary: NPE in org.apache.logging.log4j.core.util.datetime.FormatCache.MultipartKey.equals(Object) when object is null Key: LOG4J2-1602 URL:

Jenkins build became unstable: Log4j 2.x #2337

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

Could you use simply return Objects.hashcode(...) To avoid the maths In the first place ?? -- Sent from my iPhone > On 20 Sep 2016, at 19:53, Gary Gregory wrote: > > I see a Findbugs error in: > > org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode() > > for:

[jira] [Closed] (LOG4J2-1601) NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1601. Resolution: Fixed In Git master. > NPE due to >

[jira] [Updated] (LOG4J2-1601) NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1601: - Description: NPE due to

[jira] [Created] (LOG4J2-1601) NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configuration)

Gary Gregory created LOG4J2-1601: Summary: NPE due to org.apache.logging.log4j.core.layout.ScriptPatternSelector.createSelector(AbstractScript, PatternMatch[], String, boolean, boolean, Configuration) Key: LOG4J2-1601

[jira] [Closed] (LOG4J2-1600) NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1600. Resolution: Fixed Fix Version/s: 2.7 In Git master. > NPE due to >

[jira] [Reopened] (LOG4J2-1600) NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1600: -- > NPE due to >

[jira] [Closed] (LOG4J2-1600) NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

[ https://issues.apache.org/jira/browse/LOG4J2-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1600. Resolution: Fixed > NPE due to >

[jira] [Created] (LOG4J2-1600) NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration)

Gary Gregory created LOG4J2-1600: Summary: NPE due to org.apache.logging.log4j.core.layout.MarkerPatternSelector.createSelector(PatternMatch[], String, boolean, boolean, Configuration) Key: LOG4J2-1600 URL:

org.apache.logging.log4j.core.script.ScriptManager.addScript(AbstractScript)

We have no removeScript API here, which I would use for scripts that are run only once per configuration. Thoughts? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

Bit twiddling in org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()

I see a Findbugs error in: org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode() for: result = 31 * result + (threadPriority ^ (threadPriority >>> 32)); "The code performs shift of a 32 bit int by a constant amount outside the range -31..31. The effect of this is to use the lower

[jira] [Closed] (LOG4J2-1599) NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

[ https://issues.apache.org/jira/browse/LOG4J2-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1599. Resolution: Fixed Assignee: Gary Gregory Fix Version/s: 2.7 In Git master. > NPE

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on Tomcat shutdown

[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507277#comment-15507277 ] Gary Gregory commented on LOG4J2-1259: -- Are you able to test our Git master? > Log4j threads are

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on Tomcat shutdown

[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507208#comment-15507208 ] Gabriel Stanek commented on LOG4J2-1259: Great, thank you! > Log4j threads are leaking on Tomcat

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on Tomcat shutdown

[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506777#comment-15506777 ] Matt Sicker commented on LOG4J2-1259: - It'll be in 2.7, and we're getting read to release that within

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on Tomcat shutdown

[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506734#comment-15506734 ] Gabriel Stanek commented on LOG4J2-1259: Hello [~garydgregory] - could you confirm which official

Early Access build 136 for JDK 9 & JDK 9 with Project Jigsaw are available on java.net

Hi Nick, Early Access b136 for JDK 9 is available on java.net, summary of changes are listed here . Early Access b136 (#5506) for JDK 9 with Project Jigsaw is

[jira] [Resolved] (LOG4J2-1436) Log4j2 migration tools

[ https://issues.apache.org/jira/browse/LOG4J2-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal resolved LOG4J2-1436. Resolution: Duplicate > Log4j2 migration tools > -- > >

[jira] [Reopened] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-1010: - Reopening since Ralph found that the FilterPerformanceComparison performance test showed a large

Re: ThreadContextMapFilter performance

That's obviously not good. Looking at this now. Sent from my iPhone > On 2016/09/20, at 15:33, Ralph Goers wrote: > > I started the release process tonight but stopped it when I noticed that the > FilterPerformanceComparison test is now taking over 200 seconds to

ThreadContextMapFilter performance

I started the release process tonight but stopped it when I noticed that the FilterPerformanceComparison test is now taking over 200 seconds to complete. Where it used to be faster than Logback it is now from 3 to 60 times slower depending on the number of threads. I am assuming this is due to